#10 Add flags to disable certain dependencies

Open
sheaf wants to merge 1 commits from sheaf/flags into koz.ross/master
sheaf commented 3 years ago

In my opinion other packages should import finitary and provide instances, instead of having finitary incur dependencies.

I've taken the liberty to add some cabal flags that allow users to turn off these dependencies. I've checked that the library builds without warnings with all 4 combinations of the two flags I added.

Up to you whether you want these flags turned on or off by default. I've left them on, so that passing no flags recovers the current behaviour.

In my opinion other packages should import `finitary` and provide instances, instead of having `finitary` incur dependencies. I've taken the liberty to add some `cabal` flags that allow users to turn off these dependencies. I've checked that the library builds without warnings with all 4 combinations of the two flags I added. Up to you whether you want these flags turned on or off by default. I've left them on, so that passing no flags recovers the current behaviour.
Koz Ross commented 3 years ago
Owner

Thanks for the PR! Unfortunately, I'm no longer working on finitary. If you'd like the package, let me know.

Thanks for the PR! Unfortunately, I'm no longer working on `finitary`. If you'd like the package, let me know.
This pull request can be merged automatically.
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.