#27 dragora-installer: Activate swap automatically (except for exceptional scenarios)

Closed
opened 4 years ago by msi · 2 comments
msi commented 4 years ago

When there is only one swap partition – which is probably the most common case –, formatting and activating it should, IMO, be done in one step, without requiring user intervention.

Currently, you'll have to hit [OK] after the installer has finished running mkswap. But there's really no other choice than either hitting [OK] or aborting the installation at this point. So, this doesn't make all too much sense, does it?

When there are multiple swap partitions, letting the user choose which ones to activate (the default being all, maybe) would make sense, though.

When there is only one _swap_ partition – which is probably the most common case –, formatting and activating it should, IMO, be done in one step, without requiring user intervention. Currently, you'll have to hit [OK] after the installer has finished running `mkswap`. But there's really no other choice than either hitting [OK] or aborting the installation at this point. So, this doesn't make all too much sense, does it? When there are multiple _swap_ partitions, letting the user choose which ones to activate (the default being all, maybe) would make sense, though.
Matías Fonzo commented 3 years ago
Owner

The current installer can already detect multiple swap partitions, if these were previously activated, they are added to the fstab entry, and if not, formatting is possible.

The installer does not deactivate any (partition, in this case) swap, since it does not hurt to have one there. Also because it will try to use it if it is already activated (previously) and manually by the user (before entering the installer) or if it has been formatted and activated during the installation process...

The current installer can already detect multiple swap partitions, if these were previously activated, they are added to the fstab entry, and if not, formatting is possible. The installer does not deactivate any (partition, in this case) swap, since it does not hurt to have one there. Also because it will try to use it if it is already activated (previously) and manually by the user (before entering the installer) or if it has been formatted and activated during the installation process...
Matías Fonzo commented 3 years ago
Owner

By the way, there is no need in press [OK] anymore. Simply, the progress will be shown...

By the way, there is no need in press [OK] anymore. Simply, the progress will be shown...
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.