#31 Add optimized vector versions of logo

Merged
zPlus merged 1 commits from dustdfg/media-logos into peers/main 1 year ago
There is no content yet.
zPlus commented 1 year ago
Owner

This looks OK to me. Did you make them from src/media/glider-circles.svg? Would you mind adding a bit more details in the commit message before merging? I'm not sure what "optimized vector versions" means. Are these optimized for space?

This looks OK to me. Did you make them from `src/media/glider-circles.svg`? Would you mind adding a bit more details in the commit message before merging? I'm not sure what "optimized vector versions" means. Are these optimized for space?

Are it derivatives of src/media/glider-circles.svg and src/media/hack.png?

— Yes.

Did I edited src/media/glider-circles.svg?

— No. I just looked on it to see proportions. i made it from scratch. I just looked into glider-circles.svg. It isn't so bad as I thought when created them but it contains not exact values and dirty trash produced by Inkscape (I expected much more trash from Inkscape but it is present).

I'm not sure what "optimized vector versions" means. Are these optimized for space?

— Yes, it is optimized for size but it is only one of two aims that I try to reach in every vector image. It is also optimized for text editor and people like I who love to open svg files in the text editor.

Would you mind adding a bit more details in the commit message before merging?

For example, what exactly? I am not against but it seems to me it is enough.

P.S Trash produced by Inkscape is not about it's metadata but it is redundant here.

>Are it derivatives of `src/media/glider-circles.svg` and `src/media/hack.png`? — Yes. >Did I edited `src/media/glider-circles.svg`? — No. I just looked on it to see proportions. i made it from scratch. I just looked into `glider-circles.svg`. It isn't so bad as I thought when created them but it contains not exact values and dirty trash produced by Inkscape (I expected much more trash from Inkscape but it is present). >I'm not sure what "optimized vector versions" means. Are these optimized for space? — Yes, it is optimized for size but it is only one of two aims that I try to reach in every vector image. It is also optimized for text editor and people like I who love to open svg files in the text editor. >Would you mind adding a bit more details in the commit message before merging? For example, what exactly? I am not against but it seems to me it is enough. P.S Trash produced by Inkscape is not about it's metadata but it is redundant here.
zPlus commented 1 year ago
Owner

For example, what exactly?

Your last comment. It explains in details what the commit is about.

> For example, what exactly? Your last comment. It explains in details what the commit is about.

Your last comment. It explains in details what the commit is about.

OK. I did it

P.S Check your e-mail

>Your last comment. It explains in details what the commit is about. OK. I did it P.S Check your e-mail
zPlus commented 1 year ago
Owner

P.S Check your e-mail

I don't see anything besides the NAB notifications for this merge request. Am I missing something?

> P.S Check your e-mail I don't see anything besides the NAB notifications for this merge request. Am I missing something?
This pull request has been merged successfully!
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.