ChangeLog-2012-10-02 1.1 MB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342534353445345534653475348534953505351535253535354535553565357535853595360536153625363536453655366536753685369537053715372537353745375537653775378537953805381538253835384538553865387538853895390539153925393539453955396539753985399540054015402540354045405540654075408540954105411541254135414541554165417541854195420542154225423542454255426542754285429543054315432543354345435543654375438543954405441544254435444544554465447544854495450545154525453545454555456545754585459546054615462546354645465546654675468546954705471547254735474547554765477547854795480548154825483548454855486548754885489549054915492549354945495549654975498549955005501550255035504550555065507550855095510551155125513551455155516551755185519552055215522552355245525552655275528552955305531553255335534553555365537553855395540554155425543554455455546554755485549555055515552555355545555555655575558555955605561556255635564556555665567556855695570557155725573557455755576557755785579558055815582558355845585558655875588558955905591559255935594559555965597559855995600560156025603560456055606560756085609561056115612561356145615561656175618561956205621562256235624562556265627562856295630563156325633563456355636563756385639564056415642564356445645564656475648564956505651565256535654565556565657565856595660566156625663566456655666566756685669567056715672567356745675567656775678567956805681568256835684568556865687568856895690569156925693569456955696569756985699570057015702570357045705570657075708570957105711571257135714571557165717571857195720572157225723572457255726572757285729573057315732573357345735573657375738573957405741574257435744574557465747574857495750575157525753575457555756575757585759576057615762576357645765576657675768576957705771577257735774577557765777577857795780578157825783578457855786578757885789579057915792579357945795579657975798579958005801580258035804580558065807580858095810581158125813581458155816581758185819582058215822582358245825582658275828582958305831583258335834583558365837583858395840584158425843584458455846584758485849585058515852585358545855585658575858585958605861586258635864586558665867586858695870587158725873587458755876587758785879588058815882588358845885588658875888588958905891589258935894589558965897589858995900590159025903590459055906590759085909591059115912591359145915591659175918591959205921592259235924592559265927592859295930593159325933593459355936593759385939594059415942594359445945594659475948594959505951595259535954595559565957595859595960596159625963596459655966596759685969597059715972597359745975597659775978597959805981598259835984598559865987598859895990599159925993599459955996599759985999600060016002600360046005600660076008600960106011601260136014601560166017601860196020602160226023602460256026602760286029603060316032603360346035603660376038603960406041604260436044604560466047604860496050605160526053605460556056605760586059606060616062606360646065606660676068606960706071607260736074607560766077607860796080608160826083608460856086608760886089609060916092609360946095609660976098609961006101610261036104610561066107610861096110611161126113611461156116611761186119612061216122612361246125612661276128612961306131613261336134613561366137613861396140614161426143614461456146614761486149615061516152615361546155615661576158615961606161616261636164616561666167616861696170617161726173617461756176617761786179618061816182618361846185618661876188618961906191619261936194619561966197619861996200620162026203620462056206620762086209621062116212621362146215621662176218621962206221622262236224622562266227622862296230623162326233623462356236623762386239624062416242624362446245624662476248624962506251625262536254625562566257625862596260626162626263626462656266626762686269627062716272627362746275627662776278627962806281628262836284628562866287628862896290629162926293629462956296629762986299630063016302630363046305630663076308630963106311631263136314631563166317631863196320632163226323632463256326632763286329633063316332633363346335633663376338633963406341634263436344634563466347634863496350635163526353635463556356635763586359636063616362636363646365636663676368636963706371637263736374637563766377637863796380638163826383638463856386638763886389639063916392639363946395639663976398639964006401640264036404640564066407640864096410641164126413641464156416641764186419642064216422642364246425642664276428642964306431643264336434643564366437643864396440644164426443644464456446644764486449645064516452645364546455645664576458645964606461646264636464646564666467646864696470647164726473647464756476647764786479648064816482648364846485648664876488648964906491649264936494649564966497649864996500650165026503650465056506650765086509651065116512651365146515651665176518651965206521652265236524652565266527652865296530653165326533653465356536653765386539654065416542654365446545654665476548654965506551655265536554655565566557655865596560656165626563656465656566656765686569657065716572657365746575657665776578657965806581658265836584658565866587658865896590659165926593659465956596659765986599660066016602660366046605660666076608660966106611661266136614661566166617661866196620662166226623662466256626662766286629663066316632663366346635663666376638663966406641664266436644664566466647664866496650665166526653665466556656665766586659666066616662666366646665666666676668666966706671667266736674667566766677667866796680668166826683668466856686668766886689669066916692669366946695669666976698669967006701670267036704670567066707670867096710671167126713671467156716671767186719672067216722672367246725672667276728672967306731673267336734673567366737673867396740674167426743674467456746674767486749675067516752675367546755675667576758675967606761676267636764676567666767676867696770677167726773677467756776677767786779678067816782678367846785678667876788678967906791679267936794679567966797679867996800680168026803680468056806680768086809681068116812681368146815681668176818681968206821682268236824682568266827682868296830683168326833683468356836683768386839684068416842684368446845684668476848684968506851685268536854685568566857685868596860686168626863686468656866686768686869687068716872687368746875687668776878687968806881688268836884688568866887688868896890689168926893689468956896689768986899690069016902690369046905690669076908690969106911691269136914691569166917691869196920692169226923692469256926692769286929693069316932693369346935693669376938693969406941694269436944694569466947694869496950695169526953695469556956695769586959696069616962696369646965696669676968696969706971697269736974697569766977697869796980698169826983698469856986698769886989699069916992699369946995699669976998699970007001700270037004700570067007700870097010701170127013701470157016701770187019702070217022702370247025702670277028702970307031703270337034703570367037703870397040704170427043704470457046704770487049705070517052705370547055705670577058705970607061706270637064706570667067706870697070707170727073707470757076707770787079708070817082708370847085708670877088708970907091709270937094709570967097709870997100710171027103710471057106710771087109711071117112711371147115711671177118711971207121712271237124712571267127712871297130713171327133713471357136713771387139714071417142714371447145714671477148714971507151715271537154715571567157715871597160716171627163716471657166716771687169717071717172717371747175717671777178717971807181718271837184718571867187718871897190719171927193719471957196719771987199720072017202720372047205720672077208720972107211721272137214721572167217721872197220722172227223722472257226722772287229723072317232723372347235723672377238723972407241724272437244724572467247724872497250725172527253725472557256725772587259726072617262726372647265726672677268726972707271727272737274727572767277727872797280728172827283728472857286728772887289729072917292729372947295729672977298729973007301730273037304730573067307730873097310731173127313731473157316731773187319732073217322732373247325732673277328732973307331733273337334733573367337733873397340734173427343734473457346734773487349735073517352735373547355735673577358735973607361736273637364736573667367736873697370737173727373737473757376737773787379738073817382738373847385738673877388738973907391739273937394739573967397739873997400740174027403740474057406740774087409741074117412741374147415741674177418741974207421742274237424742574267427742874297430743174327433743474357436743774387439744074417442744374447445744674477448744974507451745274537454745574567457745874597460746174627463746474657466746774687469747074717472747374747475747674777478747974807481748274837484748574867487748874897490749174927493749474957496749774987499750075017502750375047505750675077508750975107511751275137514751575167517751875197520752175227523752475257526752775287529753075317532753375347535753675377538753975407541754275437544754575467547754875497550755175527553755475557556755775587559756075617562756375647565756675677568756975707571757275737574757575767577757875797580758175827583758475857586758775887589759075917592759375947595759675977598759976007601760276037604760576067607760876097610761176127613761476157616761776187619762076217622762376247625762676277628762976307631763276337634763576367637763876397640764176427643764476457646764776487649765076517652765376547655765676577658765976607661766276637664766576667667766876697670767176727673767476757676767776787679768076817682768376847685768676877688768976907691769276937694769576967697769876997700770177027703770477057706770777087709771077117712771377147715771677177718771977207721772277237724772577267727772877297730773177327733773477357736773777387739774077417742774377447745774677477748774977507751775277537754775577567757775877597760776177627763776477657766776777687769777077717772777377747775777677777778777977807781778277837784778577867787778877897790779177927793779477957796779777987799780078017802780378047805780678077808780978107811781278137814781578167817781878197820782178227823782478257826782778287829783078317832783378347835783678377838783978407841784278437844784578467847784878497850785178527853785478557856785778587859786078617862786378647865786678677868786978707871787278737874787578767877787878797880788178827883788478857886788778887889789078917892789378947895789678977898789979007901790279037904790579067907790879097910791179127913791479157916791779187919792079217922792379247925792679277928792979307931793279337934793579367937793879397940794179427943794479457946794779487949795079517952795379547955795679577958795979607961796279637964796579667967796879697970797179727973797479757976797779787979798079817982798379847985798679877988798979907991799279937994799579967997799879998000800180028003800480058006800780088009801080118012801380148015801680178018801980208021802280238024802580268027802880298030803180328033803480358036803780388039804080418042804380448045804680478048804980508051805280538054805580568057805880598060806180628063806480658066806780688069807080718072807380748075807680778078807980808081808280838084808580868087808880898090809180928093809480958096809780988099810081018102810381048105810681078108810981108111811281138114811581168117811881198120812181228123812481258126812781288129813081318132813381348135813681378138813981408141814281438144814581468147814881498150815181528153815481558156815781588159816081618162816381648165816681678168816981708171817281738174817581768177817881798180818181828183818481858186818781888189819081918192819381948195819681978198819982008201820282038204820582068207820882098210821182128213821482158216821782188219822082218222822382248225822682278228822982308231823282338234823582368237823882398240824182428243824482458246824782488249825082518252825382548255825682578258825982608261826282638264826582668267826882698270827182728273827482758276827782788279828082818282828382848285828682878288828982908291829282938294829582968297829882998300830183028303830483058306830783088309831083118312831383148315831683178318831983208321832283238324832583268327832883298330833183328333833483358336833783388339834083418342834383448345834683478348834983508351835283538354835583568357835883598360836183628363836483658366836783688369837083718372837383748375837683778378837983808381838283838384838583868387838883898390839183928393839483958396839783988399840084018402840384048405840684078408840984108411841284138414841584168417841884198420842184228423842484258426842784288429843084318432843384348435843684378438843984408441844284438444844584468447844884498450845184528453845484558456845784588459846084618462846384648465846684678468846984708471847284738474847584768477847884798480848184828483848484858486848784888489849084918492849384948495849684978498849985008501850285038504850585068507850885098510851185128513851485158516851785188519852085218522852385248525852685278528852985308531853285338534853585368537853885398540854185428543854485458546854785488549855085518552855385548555855685578558855985608561856285638564856585668567856885698570857185728573857485758576857785788579858085818582858385848585858685878588858985908591859285938594859585968597859885998600860186028603860486058606860786088609861086118612861386148615861686178618861986208621862286238624862586268627862886298630863186328633863486358636863786388639864086418642864386448645864686478648864986508651865286538654865586568657865886598660866186628663866486658666866786688669867086718672867386748675867686778678867986808681868286838684868586868687868886898690869186928693869486958696869786988699870087018702870387048705870687078708870987108711871287138714871587168717871887198720872187228723872487258726872787288729873087318732873387348735873687378738873987408741874287438744874587468747874887498750875187528753875487558756875787588759876087618762876387648765876687678768876987708771877287738774877587768777877887798780878187828783878487858786878787888789879087918792879387948795879687978798879988008801880288038804880588068807880888098810881188128813881488158816881788188819882088218822882388248825882688278828882988308831883288338834883588368837883888398840884188428843884488458846884788488849885088518852885388548855885688578858885988608861886288638864886588668867886888698870887188728873887488758876887788788879888088818882888388848885888688878888888988908891889288938894889588968897889888998900890189028903890489058906890789088909891089118912891389148915891689178918891989208921892289238924892589268927892889298930893189328933893489358936893789388939894089418942894389448945894689478948894989508951895289538954895589568957895889598960896189628963896489658966896789688969897089718972897389748975897689778978897989808981898289838984898589868987898889898990899189928993899489958996899789988999900090019002900390049005900690079008900990109011901290139014901590169017901890199020902190229023902490259026902790289029903090319032903390349035903690379038903990409041904290439044904590469047904890499050905190529053905490559056905790589059906090619062906390649065906690679068906990709071907290739074907590769077907890799080908190829083908490859086908790889089909090919092909390949095909690979098909991009101910291039104910591069107910891099110911191129113911491159116911791189119912091219122912391249125912691279128912991309131913291339134913591369137913891399140914191429143914491459146914791489149915091519152915391549155915691579158915991609161916291639164916591669167916891699170917191729173917491759176917791789179918091819182918391849185918691879188918991909191919291939194919591969197919891999200920192029203920492059206920792089209921092119212921392149215921692179218921992209221922292239224922592269227922892299230923192329233923492359236923792389239924092419242924392449245924692479248924992509251925292539254925592569257925892599260926192629263926492659266926792689269927092719272927392749275927692779278927992809281928292839284928592869287928892899290929192929293929492959296929792989299930093019302930393049305930693079308930993109311931293139314931593169317931893199320932193229323932493259326932793289329933093319332933393349335933693379338933993409341934293439344934593469347934893499350935193529353935493559356935793589359936093619362936393649365936693679368936993709371937293739374937593769377937893799380938193829383938493859386938793889389939093919392939393949395939693979398939994009401940294039404940594069407940894099410941194129413941494159416941794189419942094219422942394249425942694279428942994309431943294339434943594369437943894399440944194429443944494459446944794489449945094519452945394549455945694579458945994609461946294639464946594669467946894699470947194729473947494759476947794789479948094819482948394849485948694879488948994909491949294939494949594969497949894999500950195029503950495059506950795089509951095119512951395149515951695179518951995209521952295239524952595269527952895299530953195329533953495359536953795389539954095419542954395449545954695479548954995509551955295539554955595569557955895599560956195629563956495659566956795689569957095719572957395749575957695779578957995809581958295839584958595869587958895899590959195929593959495959596959795989599960096019602960396049605960696079608960996109611961296139614961596169617961896199620962196229623962496259626962796289629963096319632963396349635963696379638963996409641964296439644964596469647964896499650965196529653965496559656965796589659966096619662966396649665966696679668966996709671967296739674967596769677967896799680968196829683968496859686968796889689969096919692969396949695969696979698969997009701970297039704970597069707970897099710971197129713971497159716971797189719972097219722972397249725972697279728972997309731973297339734973597369737973897399740974197429743974497459746974797489749975097519752975397549755975697579758975997609761976297639764976597669767976897699770977197729773977497759776977797789779978097819782978397849785978697879788978997909791979297939794979597969797979897999800980198029803980498059806980798089809981098119812981398149815981698179818981998209821982298239824982598269827982898299830983198329833983498359836983798389839984098419842984398449845984698479848984998509851985298539854985598569857985898599860986198629863986498659866986798689869987098719872987398749875987698779878987998809881988298839884988598869887988898899890989198929893989498959896989798989899990099019902990399049905990699079908990999109911991299139914991599169917991899199920992199229923992499259926992799289929993099319932993399349935993699379938993999409941994299439944994599469947994899499950995199529953995499559956995799589959996099619962996399649965996699679968996999709971997299739974997599769977997899799980998199829983998499859986998799889989999099919992999399949995999699979998999910000100011000210003100041000510006100071000810009100101001110012100131001410015100161001710018100191002010021100221002310024100251002610027100281002910030100311003210033100341003510036100371003810039100401004110042100431004410045100461004710048100491005010051100521005310054100551005610057100581005910060100611006210063100641006510066100671006810069100701007110072100731007410075100761007710078100791008010081100821008310084100851008610087100881008910090100911009210093100941009510096100971009810099101001010110102101031010410105101061010710108101091011010111101121011310114101151011610117101181011910120101211012210123101241012510126101271012810129101301013110132101331013410135101361013710138101391014010141101421014310144101451014610147101481014910150101511015210153101541015510156101571015810159101601016110162101631016410165101661016710168101691017010171101721017310174101751017610177101781017910180101811018210183101841018510186101871018810189101901019110192101931019410195101961019710198101991020010201102021020310204102051020610207102081020910210102111021210213102141021510216102171021810219102201022110222102231022410225102261022710228102291023010231102321023310234102351023610237102381023910240102411024210243102441024510246102471024810249102501025110252102531025410255102561025710258102591026010261102621026310264102651026610267102681026910270102711027210273102741027510276102771027810279102801028110282102831028410285102861028710288102891029010291102921029310294102951029610297102981029910300103011030210303103041030510306103071030810309103101031110312103131031410315103161031710318103191032010321103221032310324103251032610327103281032910330103311033210333103341033510336103371033810339103401034110342103431034410345103461034710348103491035010351103521035310354103551035610357103581035910360103611036210363103641036510366103671036810369103701037110372103731037410375103761037710378103791038010381103821038310384103851038610387103881038910390103911039210393103941039510396103971039810399104001040110402104031040410405104061040710408104091041010411104121041310414104151041610417104181041910420104211042210423104241042510426104271042810429104301043110432104331043410435104361043710438104391044010441104421044310444104451044610447104481044910450104511045210453104541045510456104571045810459104601046110462104631046410465104661046710468104691047010471104721047310474104751047610477104781047910480104811048210483104841048510486104871048810489104901049110492104931049410495104961049710498104991050010501105021050310504105051050610507105081050910510105111051210513105141051510516105171051810519105201052110522105231052410525105261052710528105291053010531105321053310534105351053610537105381053910540105411054210543105441054510546105471054810549105501055110552105531055410555105561055710558105591056010561105621056310564105651056610567105681056910570105711057210573105741057510576105771057810579105801058110582105831058410585105861058710588105891059010591105921059310594105951059610597105981059910600106011060210603106041060510606106071060810609106101061110612106131061410615106161061710618106191062010621106221062310624106251062610627106281062910630106311063210633106341063510636106371063810639106401064110642106431064410645106461064710648106491065010651106521065310654106551065610657106581065910660106611066210663106641066510666106671066810669106701067110672106731067410675106761067710678106791068010681106821068310684106851068610687106881068910690106911069210693106941069510696106971069810699107001070110702107031070410705107061070710708107091071010711107121071310714107151071610717107181071910720107211072210723107241072510726107271072810729107301073110732107331073410735107361073710738107391074010741107421074310744107451074610747107481074910750107511075210753107541075510756107571075810759107601076110762107631076410765107661076710768107691077010771107721077310774107751077610777107781077910780107811078210783107841078510786107871078810789107901079110792107931079410795107961079710798107991080010801108021080310804108051080610807108081080910810108111081210813108141081510816108171081810819108201082110822108231082410825108261082710828108291083010831108321083310834108351083610837108381083910840108411084210843108441084510846108471084810849108501085110852108531085410855108561085710858108591086010861108621086310864108651086610867108681086910870108711087210873108741087510876108771087810879108801088110882108831088410885108861088710888108891089010891108921089310894108951089610897108981089910900109011090210903109041090510906109071090810909109101091110912109131091410915109161091710918109191092010921109221092310924109251092610927109281092910930109311093210933109341093510936109371093810939109401094110942109431094410945109461094710948109491095010951109521095310954109551095610957109581095910960109611096210963109641096510966109671096810969109701097110972109731097410975109761097710978109791098010981109821098310984109851098610987109881098910990109911099210993109941099510996109971099810999110001100111002110031100411005110061100711008110091101011011110121101311014110151101611017110181101911020110211102211023110241102511026110271102811029110301103111032110331103411035110361103711038110391104011041110421104311044110451104611047110481104911050110511105211053110541105511056110571105811059110601106111062110631106411065110661106711068110691107011071110721107311074110751107611077110781107911080110811108211083110841108511086110871108811089110901109111092110931109411095110961109711098110991110011101111021110311104111051110611107111081110911110111111111211113111141111511116111171111811119111201112111122111231112411125111261112711128111291113011131111321113311134111351113611137111381113911140111411114211143111441114511146111471114811149111501115111152111531115411155111561115711158111591116011161111621116311164111651116611167111681116911170111711117211173111741117511176111771117811179111801118111182111831118411185111861118711188111891119011191111921119311194111951119611197111981119911200112011120211203112041120511206112071120811209112101121111212112131121411215112161121711218112191122011221112221122311224112251122611227112281122911230112311123211233112341123511236112371123811239112401124111242112431124411245112461124711248112491125011251112521125311254112551125611257112581125911260112611126211263112641126511266112671126811269112701127111272112731127411275112761127711278112791128011281112821128311284112851128611287112881128911290112911129211293112941129511296112971129811299113001130111302113031130411305113061130711308113091131011311113121131311314113151131611317113181131911320113211132211323113241132511326113271132811329113301133111332113331133411335113361133711338113391134011341113421134311344113451134611347113481134911350113511135211353113541135511356113571135811359113601136111362113631136411365113661136711368113691137011371113721137311374113751137611377113781137911380113811138211383113841138511386113871138811389113901139111392113931139411395113961139711398113991140011401114021140311404114051140611407114081140911410114111141211413114141141511416114171141811419114201142111422114231142411425114261142711428114291143011431114321143311434114351143611437114381143911440114411144211443114441144511446114471144811449114501145111452114531145411455114561145711458114591146011461114621146311464114651146611467114681146911470114711147211473114741147511476114771147811479114801148111482114831148411485114861148711488114891149011491114921149311494114951149611497114981149911500115011150211503115041150511506115071150811509115101151111512115131151411515115161151711518115191152011521115221152311524115251152611527115281152911530115311153211533115341153511536115371153811539115401154111542115431154411545115461154711548115491155011551115521155311554115551155611557115581155911560115611156211563115641156511566115671156811569115701157111572115731157411575115761157711578115791158011581115821158311584115851158611587115881158911590115911159211593115941159511596115971159811599116001160111602116031160411605116061160711608116091161011611116121161311614116151161611617116181161911620116211162211623116241162511626116271162811629116301163111632116331163411635116361163711638116391164011641116421164311644116451164611647116481164911650116511165211653116541165511656116571165811659116601166111662116631166411665116661166711668116691167011671116721167311674116751167611677116781167911680116811168211683116841168511686116871168811689116901169111692116931169411695116961169711698116991170011701117021170311704117051170611707117081170911710117111171211713117141171511716117171171811719117201172111722117231172411725117261172711728117291173011731117321173311734117351173611737117381173911740117411174211743117441174511746117471174811749117501175111752117531175411755117561175711758117591176011761117621176311764117651176611767117681176911770117711177211773117741177511776117771177811779117801178111782117831178411785117861178711788117891179011791117921179311794117951179611797117981179911800118011180211803118041180511806118071180811809118101181111812118131181411815118161181711818118191182011821118221182311824118251182611827118281182911830118311183211833118341183511836118371183811839118401184111842118431184411845118461184711848118491185011851118521185311854118551185611857118581185911860118611186211863118641186511866118671186811869118701187111872118731187411875118761187711878118791188011881118821188311884118851188611887118881188911890118911189211893118941189511896118971189811899119001190111902119031190411905119061190711908119091191011911119121191311914119151191611917119181191911920119211192211923119241192511926119271192811929119301193111932119331193411935119361193711938119391194011941119421194311944119451194611947119481194911950119511195211953119541195511956119571195811959119601196111962119631196411965119661196711968119691197011971119721197311974119751197611977119781197911980119811198211983119841198511986119871198811989119901199111992119931199411995119961199711998119991200012001120021200312004120051200612007120081200912010120111201212013120141201512016120171201812019120201202112022120231202412025120261202712028120291203012031120321203312034120351203612037120381203912040120411204212043120441204512046120471204812049120501205112052120531205412055120561205712058120591206012061120621206312064120651206612067120681206912070120711207212073120741207512076120771207812079120801208112082120831208412085120861208712088120891209012091120921209312094120951209612097120981209912100121011210212103121041210512106121071210812109121101211112112121131211412115121161211712118121191212012121121221212312124121251212612127121281212912130121311213212133121341213512136121371213812139121401214112142121431214412145121461214712148121491215012151121521215312154121551215612157121581215912160121611216212163121641216512166121671216812169121701217112172121731217412175121761217712178121791218012181121821218312184121851218612187121881218912190121911219212193121941219512196121971219812199122001220112202122031220412205122061220712208122091221012211122121221312214122151221612217122181221912220122211222212223122241222512226122271222812229122301223112232122331223412235122361223712238122391224012241122421224312244122451224612247122481224912250122511225212253122541225512256122571225812259122601226112262122631226412265122661226712268122691227012271122721227312274122751227612277122781227912280122811228212283122841228512286122871228812289122901229112292122931229412295122961229712298122991230012301123021230312304123051230612307123081230912310123111231212313123141231512316123171231812319123201232112322123231232412325123261232712328123291233012331123321233312334123351233612337123381233912340123411234212343123441234512346123471234812349123501235112352123531235412355123561235712358123591236012361123621236312364123651236612367123681236912370123711237212373123741237512376123771237812379123801238112382123831238412385123861238712388123891239012391123921239312394123951239612397123981239912400124011240212403124041240512406124071240812409124101241112412124131241412415124161241712418124191242012421124221242312424124251242612427124281242912430124311243212433124341243512436124371243812439124401244112442124431244412445124461244712448124491245012451124521245312454124551245612457124581245912460124611246212463124641246512466124671246812469124701247112472124731247412475124761247712478124791248012481124821248312484124851248612487124881248912490124911249212493124941249512496124971249812499125001250112502125031250412505125061250712508125091251012511125121251312514125151251612517125181251912520125211252212523125241252512526125271252812529125301253112532125331253412535125361253712538125391254012541125421254312544125451254612547125481254912550125511255212553125541255512556125571255812559125601256112562125631256412565125661256712568125691257012571125721257312574125751257612577125781257912580125811258212583125841258512586125871258812589125901259112592125931259412595125961259712598125991260012601126021260312604126051260612607126081260912610126111261212613126141261512616126171261812619126201262112622126231262412625126261262712628126291263012631126321263312634126351263612637126381263912640126411264212643126441264512646126471264812649126501265112652126531265412655126561265712658126591266012661126621266312664126651266612667126681266912670126711267212673126741267512676126771267812679126801268112682126831268412685126861268712688126891269012691126921269312694126951269612697126981269912700127011270212703127041270512706127071270812709127101271112712127131271412715127161271712718127191272012721127221272312724127251272612727127281272912730127311273212733127341273512736127371273812739127401274112742127431274412745127461274712748127491275012751127521275312754127551275612757127581275912760127611276212763127641276512766127671276812769127701277112772127731277412775127761277712778127791278012781127821278312784127851278612787127881278912790127911279212793127941279512796127971279812799128001280112802128031280412805128061280712808128091281012811128121281312814128151281612817128181281912820128211282212823128241282512826128271282812829128301283112832128331283412835128361283712838128391284012841128421284312844128451284612847128481284912850128511285212853128541285512856128571285812859128601286112862128631286412865128661286712868128691287012871128721287312874128751287612877128781287912880128811288212883128841288512886128871288812889128901289112892128931289412895128961289712898128991290012901129021290312904129051290612907129081290912910129111291212913129141291512916129171291812919129201292112922129231292412925129261292712928129291293012931129321293312934129351293612937129381293912940129411294212943129441294512946129471294812949129501295112952129531295412955129561295712958129591296012961129621296312964129651296612967129681296912970129711297212973129741297512976129771297812979129801298112982129831298412985129861298712988129891299012991129921299312994129951299612997129981299913000130011300213003130041300513006130071300813009130101301113012130131301413015130161301713018130191302013021130221302313024130251302613027130281302913030130311303213033130341303513036130371303813039130401304113042130431304413045130461304713048130491305013051130521305313054130551305613057130581305913060130611306213063130641306513066130671306813069130701307113072130731307413075130761307713078130791308013081130821308313084130851308613087130881308913090130911309213093130941309513096130971309813099131001310113102131031310413105131061310713108131091311013111131121311313114131151311613117131181311913120131211312213123131241312513126131271312813129131301313113132131331313413135131361313713138131391314013141131421314313144131451314613147131481314913150131511315213153131541315513156131571315813159131601316113162131631316413165131661316713168131691317013171131721317313174131751317613177131781317913180131811318213183131841318513186131871318813189131901319113192131931319413195131961319713198131991320013201132021320313204132051320613207132081320913210132111321213213132141321513216132171321813219132201322113222132231322413225132261322713228132291323013231132321323313234132351323613237132381323913240132411324213243132441324513246132471324813249132501325113252132531325413255132561325713258132591326013261132621326313264132651326613267132681326913270132711327213273132741327513276132771327813279132801328113282132831328413285132861328713288132891329013291132921329313294132951329613297132981329913300133011330213303133041330513306133071330813309133101331113312133131331413315133161331713318133191332013321133221332313324133251332613327133281332913330133311333213333133341333513336133371333813339133401334113342133431334413345133461334713348133491335013351133521335313354133551335613357133581335913360133611336213363133641336513366133671336813369133701337113372133731337413375133761337713378133791338013381133821338313384133851338613387133881338913390133911339213393133941339513396133971339813399134001340113402134031340413405134061340713408134091341013411134121341313414134151341613417134181341913420134211342213423134241342513426134271342813429134301343113432134331343413435134361343713438134391344013441134421344313444134451344613447134481344913450134511345213453134541345513456134571345813459134601346113462134631346413465134661346713468134691347013471134721347313474134751347613477134781347913480134811348213483134841348513486134871348813489134901349113492134931349413495134961349713498134991350013501135021350313504135051350613507135081350913510135111351213513135141351513516135171351813519135201352113522135231352413525135261352713528135291353013531135321353313534135351353613537135381353913540135411354213543135441354513546135471354813549135501355113552135531355413555135561355713558135591356013561135621356313564135651356613567135681356913570135711357213573135741357513576135771357813579135801358113582135831358413585135861358713588135891359013591135921359313594135951359613597135981359913600136011360213603136041360513606136071360813609136101361113612136131361413615136161361713618136191362013621136221362313624136251362613627136281362913630136311363213633136341363513636136371363813639136401364113642136431364413645136461364713648136491365013651136521365313654136551365613657136581365913660136611366213663136641366513666136671366813669136701367113672136731367413675136761367713678136791368013681136821368313684136851368613687136881368913690136911369213693136941369513696136971369813699137001370113702137031370413705137061370713708137091371013711137121371313714137151371613717137181371913720137211372213723137241372513726137271372813729137301373113732137331373413735137361373713738137391374013741137421374313744137451374613747137481374913750137511375213753137541375513756137571375813759137601376113762137631376413765137661376713768137691377013771137721377313774137751377613777137781377913780137811378213783137841378513786137871378813789137901379113792137931379413795137961379713798137991380013801138021380313804138051380613807138081380913810138111381213813138141381513816138171381813819138201382113822138231382413825138261382713828138291383013831138321383313834138351383613837138381383913840138411384213843138441384513846138471384813849138501385113852138531385413855138561385713858138591386013861138621386313864138651386613867138681386913870138711387213873138741387513876138771387813879138801388113882138831388413885138861388713888138891389013891138921389313894138951389613897138981389913900139011390213903139041390513906139071390813909139101391113912139131391413915139161391713918139191392013921139221392313924139251392613927139281392913930139311393213933139341393513936139371393813939139401394113942139431394413945139461394713948139491395013951139521395313954139551395613957139581395913960139611396213963139641396513966139671396813969139701397113972139731397413975139761397713978139791398013981139821398313984139851398613987139881398913990139911399213993139941399513996139971399813999140001400114002140031400414005140061400714008140091401014011140121401314014140151401614017140181401914020140211402214023140241402514026140271402814029140301403114032140331403414035140361403714038140391404014041140421404314044140451404614047140481404914050140511405214053140541405514056140571405814059140601406114062140631406414065140661406714068140691407014071140721407314074140751407614077140781407914080140811408214083140841408514086140871408814089140901409114092140931409414095140961409714098140991410014101141021410314104141051410614107141081410914110141111411214113141141411514116141171411814119141201412114122141231412414125141261412714128141291413014131141321413314134141351413614137141381413914140141411414214143141441414514146141471414814149141501415114152141531415414155141561415714158141591416014161141621416314164141651416614167141681416914170141711417214173141741417514176141771417814179141801418114182141831418414185141861418714188141891419014191141921419314194141951419614197141981419914200142011420214203142041420514206142071420814209142101421114212142131421414215142161421714218142191422014221142221422314224142251422614227142281422914230142311423214233142341423514236142371423814239142401424114242142431424414245142461424714248142491425014251142521425314254142551425614257142581425914260142611426214263142641426514266142671426814269142701427114272142731427414275142761427714278142791428014281142821428314284142851428614287142881428914290142911429214293142941429514296142971429814299143001430114302143031430414305143061430714308143091431014311143121431314314143151431614317143181431914320143211432214323143241432514326143271432814329143301433114332143331433414335143361433714338143391434014341143421434314344143451434614347143481434914350143511435214353143541435514356143571435814359143601436114362143631436414365143661436714368143691437014371143721437314374143751437614377143781437914380143811438214383143841438514386143871438814389143901439114392143931439414395143961439714398143991440014401144021440314404144051440614407144081440914410144111441214413144141441514416144171441814419144201442114422144231442414425144261442714428144291443014431144321443314434144351443614437144381443914440144411444214443144441444514446144471444814449144501445114452144531445414455144561445714458144591446014461144621446314464144651446614467144681446914470144711447214473144741447514476144771447814479144801448114482144831448414485144861448714488144891449014491144921449314494144951449614497144981449914500145011450214503145041450514506145071450814509145101451114512145131451414515145161451714518145191452014521145221452314524145251452614527145281452914530145311453214533145341453514536145371453814539145401454114542145431454414545145461454714548145491455014551145521455314554145551455614557145581455914560145611456214563145641456514566145671456814569145701457114572145731457414575145761457714578145791458014581145821458314584145851458614587145881458914590145911459214593145941459514596145971459814599146001460114602146031460414605146061460714608146091461014611146121461314614146151461614617146181461914620146211462214623146241462514626146271462814629146301463114632146331463414635146361463714638146391464014641146421464314644146451464614647146481464914650146511465214653146541465514656146571465814659146601466114662146631466414665146661466714668146691467014671146721467314674146751467614677146781467914680146811468214683146841468514686146871468814689146901469114692146931469414695146961469714698146991470014701147021470314704147051470614707147081470914710147111471214713147141471514716147171471814719147201472114722147231472414725147261472714728147291473014731147321473314734147351473614737147381473914740147411474214743147441474514746147471474814749147501475114752147531475414755147561475714758147591476014761147621476314764147651476614767147681476914770147711477214773147741477514776147771477814779147801478114782147831478414785147861478714788147891479014791147921479314794147951479614797147981479914800148011480214803148041480514806148071480814809148101481114812148131481414815148161481714818148191482014821148221482314824148251482614827148281482914830148311483214833148341483514836148371483814839148401484114842148431484414845148461484714848148491485014851148521485314854148551485614857148581485914860148611486214863148641486514866148671486814869148701487114872148731487414875148761487714878148791488014881148821488314884148851488614887148881488914890148911489214893148941489514896148971489814899149001490114902149031490414905149061490714908149091491014911149121491314914149151491614917149181491914920149211492214923149241492514926149271492814929149301493114932149331493414935149361493714938149391494014941149421494314944149451494614947149481494914950149511495214953149541495514956149571495814959149601496114962149631496414965149661496714968149691497014971149721497314974149751497614977149781497914980149811498214983149841498514986149871498814989149901499114992149931499414995149961499714998149991500015001150021500315004150051500615007150081500915010150111501215013150141501515016150171501815019150201502115022150231502415025150261502715028150291503015031150321503315034150351503615037150381503915040150411504215043150441504515046150471504815049150501505115052150531505415055150561505715058150591506015061150621506315064150651506615067150681506915070150711507215073150741507515076150771507815079150801508115082150831508415085150861508715088150891509015091150921509315094150951509615097150981509915100151011510215103151041510515106151071510815109151101511115112151131511415115151161511715118151191512015121151221512315124151251512615127151281512915130151311513215133151341513515136151371513815139151401514115142151431514415145151461514715148151491515015151151521515315154151551515615157151581515915160151611516215163151641516515166151671516815169151701517115172151731517415175151761517715178151791518015181151821518315184151851518615187151881518915190151911519215193151941519515196151971519815199152001520115202152031520415205152061520715208152091521015211152121521315214152151521615217152181521915220152211522215223152241522515226152271522815229152301523115232152331523415235152361523715238152391524015241152421524315244152451524615247152481524915250152511525215253152541525515256152571525815259152601526115262152631526415265152661526715268152691527015271152721527315274152751527615277152781527915280152811528215283152841528515286152871528815289152901529115292152931529415295152961529715298152991530015301153021530315304153051530615307153081530915310153111531215313153141531515316153171531815319153201532115322153231532415325153261532715328153291533015331153321533315334153351533615337153381533915340153411534215343153441534515346153471534815349153501535115352153531535415355153561535715358153591536015361153621536315364153651536615367153681536915370153711537215373153741537515376153771537815379153801538115382153831538415385153861538715388153891539015391153921539315394153951539615397153981539915400154011540215403154041540515406154071540815409154101541115412154131541415415154161541715418154191542015421154221542315424154251542615427154281542915430154311543215433154341543515436154371543815439154401544115442154431544415445154461544715448154491545015451154521545315454154551545615457154581545915460154611546215463154641546515466154671546815469154701547115472154731547415475154761547715478154791548015481154821548315484154851548615487154881548915490154911549215493154941549515496154971549815499155001550115502155031550415505155061550715508155091551015511155121551315514155151551615517155181551915520155211552215523155241552515526155271552815529155301553115532155331553415535155361553715538155391554015541155421554315544155451554615547155481554915550155511555215553155541555515556155571555815559155601556115562155631556415565155661556715568155691557015571155721557315574155751557615577155781557915580155811558215583155841558515586155871558815589155901559115592155931559415595155961559715598155991560015601156021560315604156051560615607156081560915610156111561215613156141561515616156171561815619156201562115622156231562415625156261562715628156291563015631156321563315634156351563615637156381563915640156411564215643156441564515646156471564815649156501565115652156531565415655156561565715658156591566015661156621566315664156651566615667156681566915670156711567215673156741567515676156771567815679156801568115682156831568415685156861568715688156891569015691156921569315694156951569615697156981569915700157011570215703157041570515706157071570815709157101571115712157131571415715157161571715718157191572015721157221572315724157251572615727157281572915730157311573215733157341573515736157371573815739157401574115742157431574415745157461574715748157491575015751157521575315754157551575615757157581575915760157611576215763157641576515766157671576815769157701577115772157731577415775157761577715778157791578015781157821578315784157851578615787157881578915790157911579215793157941579515796157971579815799158001580115802158031580415805158061580715808158091581015811158121581315814158151581615817158181581915820158211582215823158241582515826158271582815829158301583115832158331583415835158361583715838158391584015841158421584315844158451584615847158481584915850158511585215853158541585515856158571585815859158601586115862158631586415865158661586715868158691587015871158721587315874158751587615877158781587915880158811588215883158841588515886158871588815889158901589115892158931589415895158961589715898158991590015901159021590315904159051590615907159081590915910159111591215913159141591515916159171591815919159201592115922159231592415925159261592715928159291593015931159321593315934159351593615937159381593915940159411594215943159441594515946159471594815949159501595115952159531595415955159561595715958159591596015961159621596315964159651596615967159681596915970159711597215973159741597515976159771597815979159801598115982159831598415985159861598715988159891599015991159921599315994159951599615997159981599916000160011600216003160041600516006160071600816009160101601116012160131601416015160161601716018160191602016021160221602316024160251602616027160281602916030160311603216033160341603516036160371603816039160401604116042160431604416045160461604716048160491605016051160521605316054160551605616057160581605916060160611606216063160641606516066160671606816069160701607116072160731607416075160761607716078160791608016081160821608316084160851608616087160881608916090160911609216093160941609516096160971609816099161001610116102161031610416105161061610716108161091611016111161121611316114161151611616117161181611916120161211612216123161241612516126161271612816129161301613116132161331613416135161361613716138161391614016141161421614316144161451614616147161481614916150161511615216153161541615516156161571615816159161601616116162161631616416165161661616716168161691617016171161721617316174161751617616177161781617916180161811618216183161841618516186161871618816189161901619116192161931619416195161961619716198161991620016201162021620316204162051620616207162081620916210162111621216213162141621516216162171621816219162201622116222162231622416225162261622716228162291623016231162321623316234162351623616237162381623916240162411624216243162441624516246162471624816249162501625116252162531625416255162561625716258162591626016261162621626316264162651626616267162681626916270162711627216273162741627516276162771627816279162801628116282162831628416285162861628716288162891629016291162921629316294162951629616297162981629916300163011630216303163041630516306163071630816309163101631116312163131631416315163161631716318163191632016321163221632316324163251632616327163281632916330163311633216333163341633516336163371633816339163401634116342163431634416345163461634716348163491635016351163521635316354163551635616357163581635916360163611636216363163641636516366163671636816369163701637116372163731637416375163761637716378163791638016381163821638316384163851638616387163881638916390163911639216393163941639516396163971639816399164001640116402164031640416405164061640716408164091641016411164121641316414164151641616417164181641916420164211642216423164241642516426164271642816429164301643116432164331643416435164361643716438164391644016441164421644316444164451644616447164481644916450164511645216453164541645516456164571645816459164601646116462164631646416465164661646716468164691647016471164721647316474164751647616477164781647916480164811648216483164841648516486164871648816489164901649116492164931649416495164961649716498164991650016501165021650316504165051650616507165081650916510165111651216513165141651516516165171651816519165201652116522165231652416525165261652716528165291653016531165321653316534165351653616537165381653916540165411654216543165441654516546165471654816549165501655116552165531655416555165561655716558165591656016561165621656316564165651656616567165681656916570165711657216573165741657516576165771657816579165801658116582165831658416585165861658716588165891659016591165921659316594165951659616597165981659916600166011660216603166041660516606166071660816609166101661116612166131661416615166161661716618166191662016621166221662316624166251662616627166281662916630166311663216633166341663516636166371663816639166401664116642166431664416645166461664716648166491665016651166521665316654166551665616657166581665916660166611666216663166641666516666166671666816669166701667116672166731667416675166761667716678166791668016681166821668316684166851668616687166881668916690166911669216693166941669516696166971669816699167001670116702167031670416705167061670716708167091671016711167121671316714167151671616717167181671916720167211672216723167241672516726167271672816729167301673116732167331673416735167361673716738167391674016741167421674316744167451674616747167481674916750167511675216753167541675516756167571675816759167601676116762167631676416765167661676716768167691677016771167721677316774167751677616777167781677916780167811678216783167841678516786167871678816789167901679116792167931679416795167961679716798167991680016801168021680316804168051680616807168081680916810168111681216813168141681516816168171681816819168201682116822168231682416825168261682716828168291683016831168321683316834168351683616837168381683916840168411684216843168441684516846168471684816849168501685116852168531685416855168561685716858168591686016861168621686316864168651686616867168681686916870168711687216873168741687516876168771687816879168801688116882168831688416885168861688716888168891689016891168921689316894168951689616897168981689916900169011690216903169041690516906169071690816909169101691116912169131691416915169161691716918169191692016921169221692316924169251692616927169281692916930169311693216933169341693516936169371693816939169401694116942169431694416945169461694716948169491695016951169521695316954169551695616957169581695916960169611696216963169641696516966169671696816969169701697116972169731697416975169761697716978169791698016981169821698316984169851698616987169881698916990169911699216993169941699516996169971699816999170001700117002170031700417005170061700717008170091701017011170121701317014170151701617017170181701917020170211702217023170241702517026170271702817029170301703117032170331703417035170361703717038170391704017041170421704317044170451704617047170481704917050170511705217053170541705517056170571705817059170601706117062170631706417065170661706717068170691707017071170721707317074170751707617077170781707917080170811708217083170841708517086170871708817089170901709117092170931709417095170961709717098170991710017101171021710317104171051710617107171081710917110171111711217113171141711517116171171711817119171201712117122171231712417125171261712717128171291713017131171321713317134171351713617137171381713917140171411714217143171441714517146171471714817149171501715117152171531715417155171561715717158171591716017161171621716317164171651716617167171681716917170171711717217173171741717517176171771717817179171801718117182171831718417185171861718717188171891719017191171921719317194171951719617197171981719917200172011720217203172041720517206172071720817209172101721117212172131721417215172161721717218172191722017221172221722317224172251722617227172281722917230172311723217233172341723517236172371723817239172401724117242172431724417245172461724717248172491725017251172521725317254172551725617257172581725917260172611726217263172641726517266172671726817269172701727117272172731727417275172761727717278172791728017281172821728317284172851728617287172881728917290172911729217293172941729517296172971729817299173001730117302173031730417305173061730717308173091731017311173121731317314173151731617317173181731917320173211732217323173241732517326173271732817329173301733117332173331733417335173361733717338173391734017341173421734317344173451734617347173481734917350173511735217353173541735517356173571735817359173601736117362173631736417365173661736717368173691737017371173721737317374173751737617377173781737917380173811738217383173841738517386173871738817389173901739117392173931739417395173961739717398173991740017401174021740317404174051740617407174081740917410174111741217413174141741517416174171741817419174201742117422174231742417425174261742717428174291743017431174321743317434174351743617437174381743917440174411744217443174441744517446174471744817449174501745117452174531745417455174561745717458174591746017461174621746317464174651746617467174681746917470174711747217473174741747517476174771747817479174801748117482174831748417485174861748717488174891749017491174921749317494174951749617497174981749917500175011750217503175041750517506175071750817509175101751117512175131751417515175161751717518175191752017521175221752317524175251752617527175281752917530175311753217533175341753517536175371753817539175401754117542175431754417545175461754717548175491755017551175521755317554175551755617557175581755917560175611756217563175641756517566175671756817569175701757117572175731757417575175761757717578175791758017581175821758317584175851758617587175881758917590175911759217593175941759517596175971759817599176001760117602176031760417605176061760717608176091761017611176121761317614176151761617617176181761917620176211762217623176241762517626176271762817629176301763117632176331763417635176361763717638176391764017641176421764317644176451764617647176481764917650176511765217653176541765517656176571765817659176601766117662176631766417665176661766717668176691767017671176721767317674176751767617677176781767917680176811768217683176841768517686176871768817689176901769117692176931769417695176961769717698176991770017701177021770317704177051770617707177081770917710177111771217713177141771517716177171771817719177201772117722177231772417725177261772717728177291773017731177321773317734177351773617737177381773917740177411774217743177441774517746177471774817749177501775117752177531775417755177561775717758177591776017761177621776317764177651776617767177681776917770177711777217773177741777517776177771777817779177801778117782177831778417785177861778717788177891779017791177921779317794177951779617797177981779917800178011780217803178041780517806178071780817809178101781117812178131781417815178161781717818178191782017821178221782317824178251782617827178281782917830178311783217833178341783517836178371783817839178401784117842178431784417845178461784717848178491785017851178521785317854178551785617857178581785917860178611786217863178641786517866178671786817869178701787117872178731787417875178761787717878178791788017881178821788317884178851788617887178881788917890178911789217893178941789517896178971789817899179001790117902179031790417905179061790717908179091791017911179121791317914179151791617917179181791917920179211792217923179241792517926179271792817929179301793117932179331793417935179361793717938179391794017941179421794317944179451794617947179481794917950179511795217953179541795517956179571795817959179601796117962179631796417965179661796717968179691797017971179721797317974179751797617977179781797917980179811798217983179841798517986179871798817989179901799117992179931799417995179961799717998179991800018001180021800318004180051800618007180081800918010180111801218013180141801518016180171801818019180201802118022180231802418025180261802718028180291803018031180321803318034180351803618037180381803918040180411804218043180441804518046180471804818049180501805118052180531805418055180561805718058180591806018061180621806318064180651806618067180681806918070180711807218073180741807518076180771807818079180801808118082180831808418085180861808718088180891809018091180921809318094180951809618097180981809918100181011810218103181041810518106181071810818109181101811118112181131811418115181161811718118181191812018121181221812318124181251812618127181281812918130181311813218133181341813518136181371813818139181401814118142181431814418145181461814718148181491815018151181521815318154181551815618157181581815918160181611816218163181641816518166181671816818169181701817118172181731817418175181761817718178181791818018181181821818318184181851818618187181881818918190181911819218193181941819518196181971819818199182001820118202182031820418205182061820718208182091821018211182121821318214182151821618217182181821918220182211822218223182241822518226182271822818229182301823118232182331823418235182361823718238182391824018241182421824318244182451824618247182481824918250182511825218253182541825518256182571825818259182601826118262182631826418265182661826718268182691827018271182721827318274182751827618277182781827918280182811828218283182841828518286182871828818289182901829118292182931829418295182961829718298182991830018301183021830318304183051830618307183081830918310183111831218313183141831518316183171831818319183201832118322183231832418325183261832718328183291833018331183321833318334183351833618337183381833918340183411834218343183441834518346183471834818349183501835118352183531835418355183561835718358183591836018361183621836318364183651836618367183681836918370183711837218373183741837518376183771837818379183801838118382183831838418385183861838718388183891839018391183921839318394183951839618397183981839918400184011840218403184041840518406184071840818409184101841118412184131841418415184161841718418184191842018421184221842318424184251842618427184281842918430184311843218433184341843518436184371843818439184401844118442184431844418445184461844718448184491845018451184521845318454184551845618457184581845918460184611846218463184641846518466184671846818469184701847118472184731847418475184761847718478184791848018481184821848318484184851848618487184881848918490184911849218493184941849518496184971849818499185001850118502185031850418505185061850718508185091851018511185121851318514185151851618517185181851918520185211852218523185241852518526185271852818529185301853118532185331853418535185361853718538185391854018541185421854318544185451854618547185481854918550185511855218553185541855518556185571855818559185601856118562185631856418565185661856718568185691857018571185721857318574185751857618577185781857918580185811858218583185841858518586185871858818589185901859118592185931859418595185961859718598185991860018601186021860318604186051860618607186081860918610186111861218613186141861518616186171861818619186201862118622186231862418625186261862718628186291863018631186321863318634186351863618637186381863918640186411864218643186441864518646186471864818649186501865118652186531865418655186561865718658186591866018661186621866318664186651866618667186681866918670186711867218673186741867518676186771867818679186801868118682186831868418685186861868718688186891869018691186921869318694186951869618697186981869918700187011870218703187041870518706187071870818709187101871118712187131871418715187161871718718187191872018721187221872318724187251872618727187281872918730187311873218733187341873518736187371873818739187401874118742187431874418745187461874718748187491875018751187521875318754187551875618757187581875918760187611876218763187641876518766187671876818769187701877118772187731877418775187761877718778187791878018781187821878318784187851878618787187881878918790187911879218793187941879518796187971879818799188001880118802188031880418805188061880718808188091881018811188121881318814188151881618817188181881918820188211882218823188241882518826188271882818829188301883118832188331883418835188361883718838188391884018841188421884318844188451884618847188481884918850188511885218853188541885518856188571885818859188601886118862188631886418865188661886718868188691887018871188721887318874188751887618877188781887918880188811888218883188841888518886188871888818889188901889118892188931889418895188961889718898188991890018901189021890318904189051890618907189081890918910189111891218913189141891518916189171891818919189201892118922189231892418925189261892718928189291893018931189321893318934189351893618937189381893918940189411894218943189441894518946189471894818949189501895118952189531895418955189561895718958189591896018961189621896318964189651896618967189681896918970189711897218973189741897518976189771897818979189801898118982189831898418985189861898718988189891899018991189921899318994189951899618997189981899919000190011900219003190041900519006190071900819009190101901119012190131901419015190161901719018190191902019021190221902319024190251902619027190281902919030190311903219033190341903519036190371903819039190401904119042190431904419045190461904719048190491905019051190521905319054190551905619057190581905919060190611906219063190641906519066190671906819069190701907119072190731907419075190761907719078190791908019081190821908319084190851908619087190881908919090190911909219093190941909519096190971909819099191001910119102191031910419105191061910719108191091911019111191121911319114191151911619117191181911919120191211912219123191241912519126191271912819129191301913119132191331913419135191361913719138191391914019141191421914319144191451914619147191481914919150191511915219153191541915519156191571915819159191601916119162191631916419165191661916719168191691917019171191721917319174191751917619177191781917919180191811918219183191841918519186191871918819189191901919119192191931919419195191961919719198191991920019201192021920319204192051920619207192081920919210192111921219213192141921519216192171921819219192201922119222192231922419225192261922719228192291923019231192321923319234192351923619237192381923919240192411924219243192441924519246192471924819249192501925119252192531925419255192561925719258192591926019261192621926319264192651926619267192681926919270192711927219273192741927519276192771927819279192801928119282192831928419285192861928719288192891929019291192921929319294192951929619297192981929919300193011930219303193041930519306193071930819309193101931119312193131931419315193161931719318193191932019321193221932319324193251932619327193281932919330193311933219333193341933519336193371933819339193401934119342193431934419345193461934719348193491935019351193521935319354193551935619357193581935919360193611936219363193641936519366193671936819369193701937119372193731937419375193761937719378193791938019381193821938319384193851938619387193881938919390193911939219393193941939519396193971939819399194001940119402194031940419405194061940719408194091941019411194121941319414194151941619417194181941919420194211942219423194241942519426194271942819429194301943119432194331943419435194361943719438194391944019441194421944319444194451944619447194481944919450194511945219453194541945519456194571945819459194601946119462194631946419465194661946719468194691947019471194721947319474194751947619477194781947919480194811948219483194841948519486194871948819489194901949119492194931949419495194961949719498194991950019501195021950319504195051950619507195081950919510195111951219513195141951519516195171951819519195201952119522195231952419525195261952719528195291953019531195321953319534195351953619537195381953919540195411954219543195441954519546195471954819549195501955119552195531955419555195561955719558195591956019561195621956319564195651956619567195681956919570195711957219573195741957519576195771957819579195801958119582195831958419585195861958719588195891959019591195921959319594195951959619597195981959919600196011960219603196041960519606196071960819609196101961119612196131961419615196161961719618196191962019621196221962319624196251962619627196281962919630196311963219633196341963519636196371963819639196401964119642196431964419645196461964719648196491965019651196521965319654196551965619657196581965919660196611966219663196641966519666196671966819669196701967119672196731967419675196761967719678196791968019681196821968319684196851968619687196881968919690196911969219693196941969519696196971969819699197001970119702197031970419705197061970719708197091971019711197121971319714197151971619717197181971919720197211972219723197241972519726197271972819729197301973119732197331973419735197361973719738197391974019741197421974319744197451974619747197481974919750197511975219753197541975519756197571975819759197601976119762197631976419765197661976719768197691977019771197721977319774197751977619777197781977919780197811978219783197841978519786197871978819789197901979119792197931979419795197961979719798197991980019801198021980319804198051980619807198081980919810198111981219813198141981519816198171981819819198201982119822198231982419825198261982719828198291983019831198321983319834198351983619837198381983919840198411984219843198441984519846198471984819849198501985119852198531985419855198561985719858198591986019861198621986319864198651986619867198681986919870198711987219873198741987519876198771987819879198801988119882198831988419885198861988719888198891989019891198921989319894198951989619897198981989919900199011990219903199041990519906199071990819909199101991119912199131991419915199161991719918199191992019921199221992319924199251992619927199281992919930199311993219933199341993519936199371993819939199401994119942199431994419945199461994719948199491995019951199521995319954199551995619957199581995919960199611996219963199641996519966199671996819969199701997119972199731997419975199761997719978199791998019981199821998319984199851998619987199881998919990199911999219993199941999519996199971999819999200002000120002200032000420005200062000720008200092001020011200122001320014200152001620017200182001920020200212002220023200242002520026200272002820029200302003120032200332003420035200362003720038200392004020041200422004320044200452004620047200482004920050200512005220053200542005520056200572005820059200602006120062200632006420065200662006720068200692007020071200722007320074200752007620077200782007920080200812008220083200842008520086200872008820089200902009120092200932009420095200962009720098200992010020101201022010320104201052010620107201082010920110201112011220113201142011520116201172011820119201202012120122201232012420125201262012720128201292013020131201322013320134201352013620137201382013920140201412014220143201442014520146201472014820149201502015120152201532015420155201562015720158201592016020161201622016320164201652016620167201682016920170201712017220173201742017520176201772017820179201802018120182201832018420185201862018720188201892019020191201922019320194201952019620197201982019920200202012020220203202042020520206202072020820209202102021120212202132021420215202162021720218202192022020221202222022320224202252022620227202282022920230202312023220233202342023520236202372023820239202402024120242202432024420245202462024720248202492025020251202522025320254202552025620257202582025920260202612026220263202642026520266202672026820269202702027120272202732027420275202762027720278202792028020281202822028320284202852028620287202882028920290202912029220293202942029520296202972029820299203002030120302203032030420305203062030720308203092031020311203122031320314203152031620317203182031920320203212032220323203242032520326203272032820329203302033120332203332033420335203362033720338203392034020341203422034320344203452034620347203482034920350203512035220353203542035520356203572035820359203602036120362203632036420365203662036720368203692037020371203722037320374203752037620377203782037920380203812038220383203842038520386203872038820389203902039120392203932039420395203962039720398203992040020401204022040320404204052040620407204082040920410204112041220413204142041520416204172041820419204202042120422204232042420425204262042720428204292043020431204322043320434204352043620437204382043920440204412044220443204442044520446204472044820449204502045120452204532045420455204562045720458204592046020461204622046320464204652046620467204682046920470204712047220473204742047520476204772047820479204802048120482204832048420485204862048720488204892049020491204922049320494204952049620497204982049920500205012050220503205042050520506205072050820509205102051120512205132051420515205162051720518205192052020521205222052320524205252052620527205282052920530205312053220533205342053520536205372053820539205402054120542205432054420545205462054720548205492055020551205522055320554205552055620557205582055920560205612056220563205642056520566205672056820569205702057120572205732057420575205762057720578205792058020581205822058320584205852058620587205882058920590205912059220593205942059520596205972059820599206002060120602206032060420605206062060720608206092061020611206122061320614206152061620617206182061920620206212062220623206242062520626206272062820629206302063120632206332063420635206362063720638206392064020641206422064320644206452064620647206482064920650206512065220653206542065520656206572065820659206602066120662206632066420665206662066720668206692067020671206722067320674206752067620677206782067920680206812068220683206842068520686206872068820689206902069120692206932069420695206962069720698206992070020701207022070320704207052070620707207082070920710207112071220713207142071520716207172071820719207202072120722207232072420725207262072720728207292073020731207322073320734207352073620737207382073920740207412074220743207442074520746207472074820749207502075120752207532075420755207562075720758207592076020761207622076320764207652076620767207682076920770207712077220773207742077520776207772077820779207802078120782207832078420785207862078720788207892079020791207922079320794207952079620797207982079920800208012080220803208042080520806208072080820809208102081120812208132081420815208162081720818208192082020821208222082320824208252082620827208282082920830208312083220833208342083520836208372083820839208402084120842208432084420845208462084720848208492085020851208522085320854208552085620857208582085920860208612086220863208642086520866208672086820869208702087120872208732087420875208762087720878208792088020881208822088320884208852088620887208882088920890208912089220893208942089520896208972089820899209002090120902209032090420905209062090720908209092091020911209122091320914209152091620917209182091920920209212092220923209242092520926209272092820929209302093120932209332093420935209362093720938209392094020941209422094320944209452094620947209482094920950209512095220953209542095520956209572095820959209602096120962209632096420965209662096720968209692097020971209722097320974209752097620977209782097920980209812098220983209842098520986209872098820989209902099120992209932099420995209962099720998209992100021001210022100321004210052100621007210082100921010210112101221013210142101521016210172101821019210202102121022210232102421025210262102721028210292103021031210322103321034210352103621037210382103921040210412104221043210442104521046210472104821049210502105121052210532105421055210562105721058210592106021061210622106321064210652106621067210682106921070210712107221073210742107521076210772107821079210802108121082210832108421085210862108721088210892109021091210922109321094210952109621097210982109921100211012110221103211042110521106211072110821109211102111121112211132111421115211162111721118211192112021121211222112321124211252112621127211282112921130211312113221133211342113521136211372113821139211402114121142211432114421145211462114721148211492115021151211522115321154211552115621157211582115921160211612116221163211642116521166211672116821169211702117121172211732117421175211762117721178211792118021181211822118321184211852118621187211882118921190211912119221193211942119521196211972119821199212002120121202212032120421205212062120721208212092121021211212122121321214212152121621217212182121921220212212122221223212242122521226212272122821229212302123121232212332123421235212362123721238212392124021241212422124321244212452124621247212482124921250212512125221253212542125521256212572125821259212602126121262212632126421265212662126721268212692127021271212722127321274212752127621277212782127921280212812128221283212842128521286212872128821289212902129121292212932129421295212962129721298212992130021301213022130321304213052130621307213082130921310213112131221313213142131521316213172131821319213202132121322213232132421325213262132721328213292133021331213322133321334213352133621337213382133921340213412134221343213442134521346213472134821349213502135121352213532135421355213562135721358213592136021361213622136321364213652136621367213682136921370213712137221373213742137521376213772137821379213802138121382213832138421385213862138721388213892139021391213922139321394213952139621397213982139921400214012140221403214042140521406214072140821409214102141121412214132141421415214162141721418214192142021421214222142321424214252142621427214282142921430214312143221433214342143521436214372143821439214402144121442214432144421445214462144721448214492145021451214522145321454214552145621457214582145921460214612146221463214642146521466214672146821469214702147121472214732147421475214762147721478214792148021481214822148321484214852148621487214882148921490214912149221493214942149521496214972149821499215002150121502215032150421505215062150721508215092151021511215122151321514215152151621517215182151921520215212152221523215242152521526215272152821529215302153121532215332153421535215362153721538215392154021541215422154321544215452154621547215482154921550215512155221553215542155521556215572155821559215602156121562215632156421565215662156721568215692157021571215722157321574215752157621577215782157921580215812158221583215842158521586215872158821589215902159121592215932159421595215962159721598215992160021601216022160321604216052160621607216082160921610216112161221613216142161521616216172161821619216202162121622216232162421625216262162721628216292163021631216322163321634216352163621637216382163921640216412164221643216442164521646216472164821649216502165121652216532165421655216562165721658216592166021661216622166321664216652166621667216682166921670216712167221673216742167521676216772167821679216802168121682216832168421685216862168721688216892169021691216922169321694216952169621697216982169921700217012170221703217042170521706217072170821709217102171121712217132171421715217162171721718217192172021721217222172321724217252172621727217282172921730217312173221733217342173521736217372173821739217402174121742217432174421745217462174721748217492175021751217522175321754217552175621757217582175921760217612176221763217642176521766217672176821769217702177121772217732177421775217762177721778217792178021781217822178321784217852178621787217882178921790217912179221793217942179521796217972179821799218002180121802218032180421805218062180721808218092181021811218122181321814218152181621817218182181921820218212182221823218242182521826218272182821829218302183121832218332183421835218362183721838218392184021841218422184321844218452184621847218482184921850218512185221853218542185521856218572185821859218602186121862218632186421865218662186721868218692187021871218722187321874218752187621877218782187921880218812188221883218842188521886218872188821889218902189121892218932189421895218962189721898218992190021901219022190321904219052190621907219082190921910219112191221913219142191521916219172191821919219202192121922219232192421925219262192721928219292193021931219322193321934219352193621937219382193921940219412194221943219442194521946219472194821949219502195121952219532195421955219562195721958219592196021961219622196321964219652196621967219682196921970219712197221973219742197521976219772197821979219802198121982219832198421985219862198721988219892199021991219922199321994219952199621997219982199922000220012200222003220042200522006220072200822009220102201122012220132201422015220162201722018220192202022021220222202322024220252202622027220282202922030220312203222033220342203522036220372203822039220402204122042220432204422045220462204722048220492205022051220522205322054220552205622057220582205922060220612206222063220642206522066220672206822069220702207122072220732207422075220762207722078220792208022081220822208322084220852208622087220882208922090220912209222093220942209522096220972209822099221002210122102221032210422105221062210722108221092211022111221122211322114221152211622117221182211922120221212212222123221242212522126221272212822129221302213122132221332213422135221362213722138221392214022141221422214322144221452214622147221482214922150221512215222153221542215522156221572215822159221602216122162221632216422165221662216722168221692217022171221722217322174221752217622177221782217922180221812218222183221842218522186221872218822189221902219122192221932219422195221962219722198221992220022201222022220322204222052220622207222082220922210222112221222213222142221522216222172221822219222202222122222222232222422225222262222722228222292223022231222322223322234222352223622237222382223922240222412224222243222442224522246222472224822249222502225122252222532225422255222562225722258222592226022261222622226322264222652226622267222682226922270222712227222273222742227522276222772227822279222802228122282222832228422285222862228722288222892229022291222922229322294222952229622297222982229922300223012230222303223042230522306223072230822309223102231122312223132231422315223162231722318223192232022321223222232322324223252232622327223282232922330223312233222333223342233522336223372233822339223402234122342223432234422345223462234722348223492235022351223522235322354223552235622357223582235922360223612236222363223642236522366223672236822369223702237122372223732237422375223762237722378223792238022381223822238322384223852238622387223882238922390223912239222393223942239522396223972239822399224002240122402224032240422405224062240722408224092241022411224122241322414224152241622417224182241922420224212242222423224242242522426224272242822429224302243122432224332243422435224362243722438224392244022441224422244322444224452244622447224482244922450224512245222453224542245522456224572245822459224602246122462224632246422465224662246722468224692247022471224722247322474224752247622477224782247922480224812248222483224842248522486224872248822489224902249122492224932249422495224962249722498224992250022501225022250322504225052250622507225082250922510225112251222513225142251522516225172251822519225202252122522225232252422525225262252722528225292253022531225322253322534225352253622537225382253922540225412254222543225442254522546225472254822549225502255122552225532255422555225562255722558225592256022561225622256322564225652256622567225682256922570225712257222573225742257522576225772257822579225802258122582225832258422585225862258722588225892259022591225922259322594225952259622597225982259922600226012260222603226042260522606226072260822609226102261122612226132261422615226162261722618226192262022621226222262322624226252262622627226282262922630226312263222633226342263522636226372263822639226402264122642226432264422645226462264722648226492265022651226522265322654226552265622657226582265922660226612266222663226642266522666226672266822669226702267122672226732267422675226762267722678226792268022681226822268322684226852268622687226882268922690226912269222693226942269522696226972269822699227002270122702227032270422705227062270722708227092271022711227122271322714227152271622717227182271922720227212272222723227242272522726227272272822729227302273122732227332273422735227362273722738227392274022741227422274322744227452274622747227482274922750227512275222753227542275522756227572275822759227602276122762227632276422765227662276722768227692277022771227722277322774227752277622777227782277922780227812278222783227842278522786227872278822789227902279122792227932279422795227962279722798227992280022801228022280322804228052280622807228082280922810228112281222813228142281522816228172281822819228202282122822228232282422825228262282722828228292283022831228322283322834228352283622837228382283922840228412284222843228442284522846228472284822849228502285122852228532285422855228562285722858228592286022861228622286322864228652286622867228682286922870228712287222873228742287522876228772287822879228802288122882228832288422885228862288722888228892289022891228922289322894228952289622897228982289922900229012290222903229042290522906229072290822909229102291122912229132291422915229162291722918229192292022921229222292322924229252292622927229282292922930229312293222933229342293522936229372293822939229402294122942229432294422945229462294722948229492295022951229522295322954229552295622957229582295922960229612296222963229642296522966229672296822969229702297122972229732297422975229762297722978229792298022981229822298322984229852298622987229882298922990229912299222993229942299522996229972299822999230002300123002230032300423005230062300723008230092301023011230122301323014230152301623017230182301923020230212302223023230242302523026230272302823029230302303123032230332303423035230362303723038230392304023041230422304323044230452304623047230482304923050230512305223053230542305523056230572305823059230602306123062230632306423065230662306723068230692307023071230722307323074230752307623077230782307923080230812308223083230842308523086230872308823089230902309123092230932309423095230962309723098230992310023101231022310323104231052310623107231082310923110231112311223113231142311523116231172311823119231202312123122231232312423125231262312723128231292313023131231322313323134231352313623137231382313923140231412314223143231442314523146231472314823149231502315123152231532315423155231562315723158231592316023161231622316323164231652316623167231682316923170231712317223173231742317523176231772317823179231802318123182231832318423185231862318723188231892319023191231922319323194231952319623197231982319923200232012320223203232042320523206232072320823209232102321123212232132321423215232162321723218232192322023221232222322323224232252322623227232282322923230232312323223233232342323523236232372323823239232402324123242232432324423245232462324723248232492325023251232522325323254232552325623257232582325923260232612326223263232642326523266232672326823269232702327123272232732327423275232762327723278232792328023281232822328323284232852328623287232882328923290232912329223293232942329523296232972329823299233002330123302233032330423305233062330723308233092331023311233122331323314233152331623317233182331923320233212332223323233242332523326233272332823329233302333123332233332333423335233362333723338233392334023341233422334323344233452334623347233482334923350233512335223353233542335523356233572335823359233602336123362233632336423365233662336723368233692337023371233722337323374233752337623377233782337923380233812338223383233842338523386233872338823389233902339123392233932339423395233962339723398233992340023401234022340323404234052340623407234082340923410234112341223413234142341523416234172341823419234202342123422234232342423425234262342723428234292343023431234322343323434234352343623437234382343923440234412344223443234442344523446234472344823449234502345123452234532345423455234562345723458234592346023461234622346323464234652346623467234682346923470234712347223473234742347523476234772347823479234802348123482234832348423485234862348723488234892349023491234922349323494234952349623497234982349923500235012350223503235042350523506235072350823509235102351123512235132351423515235162351723518235192352023521235222352323524235252352623527235282352923530235312353223533235342353523536235372353823539235402354123542235432354423545235462354723548235492355023551235522355323554235552355623557235582355923560235612356223563235642356523566235672356823569235702357123572235732357423575235762357723578235792358023581235822358323584235852358623587235882358923590235912359223593235942359523596235972359823599236002360123602236032360423605236062360723608236092361023611236122361323614236152361623617236182361923620236212362223623236242362523626236272362823629236302363123632236332363423635236362363723638236392364023641236422364323644236452364623647236482364923650236512365223653236542365523656236572365823659236602366123662236632366423665236662366723668236692367023671236722367323674236752367623677236782367923680236812368223683236842368523686236872368823689236902369123692236932369423695236962369723698236992370023701237022370323704237052370623707237082370923710237112371223713237142371523716237172371823719237202372123722237232372423725237262372723728237292373023731237322373323734237352373623737237382373923740237412374223743237442374523746237472374823749237502375123752237532375423755237562375723758237592376023761237622376323764237652376623767237682376923770237712377223773237742377523776237772377823779237802378123782237832378423785237862378723788237892379023791237922379323794237952379623797237982379923800238012380223803238042380523806238072380823809238102381123812238132381423815238162381723818238192382023821238222382323824238252382623827238282382923830238312383223833238342383523836238372383823839238402384123842238432384423845238462384723848238492385023851238522385323854238552385623857238582385923860238612386223863238642386523866238672386823869238702387123872238732387423875238762387723878238792388023881238822388323884238852388623887238882388923890238912389223893238942389523896238972389823899239002390123902239032390423905239062390723908239092391023911239122391323914239152391623917239182391923920239212392223923239242392523926239272392823929239302393123932239332393423935239362393723938239392394023941239422394323944239452394623947239482394923950239512395223953239542395523956239572395823959239602396123962239632396423965239662396723968239692397023971239722397323974239752397623977239782397923980239812398223983239842398523986239872398823989239902399123992239932399423995239962399723998239992400024001240022400324004240052400624007240082400924010240112401224013240142401524016240172401824019240202402124022240232402424025240262402724028240292403024031240322403324034240352403624037240382403924040240412404224043240442404524046240472404824049240502405124052240532405424055240562405724058240592406024061240622406324064240652406624067240682406924070240712407224073240742407524076240772407824079240802408124082240832408424085240862408724088240892409024091240922409324094240952409624097240982409924100241012410224103241042410524106241072410824109241102411124112241132411424115241162411724118241192412024121241222412324124241252412624127241282412924130241312413224133241342413524136241372413824139241402414124142241432414424145241462414724148241492415024151241522415324154241552415624157241582415924160241612416224163241642416524166241672416824169241702417124172241732417424175241762417724178241792418024181241822418324184241852418624187241882418924190241912419224193241942419524196241972419824199242002420124202242032420424205242062420724208242092421024211242122421324214242152421624217242182421924220242212422224223242242422524226242272422824229242302423124232242332423424235242362423724238242392424024241242422424324244242452424624247242482424924250242512425224253242542425524256242572425824259242602426124262242632426424265242662426724268242692427024271242722427324274242752427624277242782427924280242812428224283242842428524286242872428824289242902429124292242932429424295242962429724298242992430024301243022430324304243052430624307243082430924310243112431224313243142431524316243172431824319243202432124322243232432424325243262432724328243292433024331243322433324334243352433624337243382433924340243412434224343243442434524346243472434824349243502435124352243532435424355243562435724358243592436024361243622436324364243652436624367243682436924370243712437224373243742437524376243772437824379243802438124382243832438424385243862438724388243892439024391243922439324394243952439624397243982439924400244012440224403244042440524406244072440824409244102441124412244132441424415244162441724418244192442024421244222442324424244252442624427244282442924430244312443224433244342443524436244372443824439244402444124442244432444424445244462444724448244492445024451244522445324454244552445624457244582445924460244612446224463244642446524466244672446824469244702447124472244732447424475244762447724478244792448024481244822448324484244852448624487244882448924490244912449224493244942449524496244972449824499245002450124502245032450424505245062450724508245092451024511245122451324514245152451624517245182451924520245212452224523245242452524526245272452824529245302453124532245332453424535245362453724538245392454024541245422454324544245452454624547245482454924550245512455224553245542455524556245572455824559245602456124562245632456424565245662456724568245692457024571245722457324574245752457624577245782457924580245812458224583245842458524586245872458824589245902459124592245932459424595245962459724598245992460024601246022460324604246052460624607246082460924610246112461224613246142461524616246172461824619246202462124622246232462424625246262462724628246292463024631246322463324634246352463624637246382463924640246412464224643246442464524646246472464824649246502465124652246532465424655246562465724658246592466024661246622466324664246652466624667246682466924670246712467224673246742467524676246772467824679246802468124682246832468424685246862468724688246892469024691246922469324694246952469624697246982469924700247012470224703247042470524706247072470824709247102471124712247132471424715247162471724718247192472024721247222472324724247252472624727247282472924730247312473224733247342473524736247372473824739247402474124742247432474424745247462474724748247492475024751247522475324754247552475624757247582475924760247612476224763247642476524766247672476824769247702477124772247732477424775247762477724778247792478024781247822478324784247852478624787247882478924790247912479224793247942479524796247972479824799248002480124802248032480424805248062480724808248092481024811248122481324814248152481624817248182481924820248212482224823248242482524826248272482824829248302483124832248332483424835248362483724838248392484024841248422484324844248452484624847248482484924850248512485224853248542485524856248572485824859248602486124862248632486424865248662486724868248692487024871248722487324874248752487624877248782487924880248812488224883248842488524886248872488824889248902489124892248932489424895248962489724898248992490024901249022490324904249052490624907249082490924910249112491224913249142491524916249172491824919249202492124922249232492424925249262492724928249292493024931249322493324934249352493624937249382493924940249412494224943249442494524946249472494824949249502495124952249532495424955249562495724958249592496024961249622496324964249652496624967249682496924970249712497224973249742497524976249772497824979249802498124982249832498424985249862498724988249892499024991249922499324994249952499624997249982499925000250012500225003250042500525006250072500825009250102501125012250132501425015250162501725018250192502025021250222502325024250252502625027250282502925030250312503225033250342503525036250372503825039250402504125042250432504425045250462504725048250492505025051250522505325054250552505625057250582505925060250612506225063250642506525066250672506825069250702507125072250732507425075250762507725078250792508025081250822508325084250852508625087250882508925090250912509225093250942509525096250972509825099251002510125102251032510425105251062510725108251092511025111251122511325114251152511625117251182511925120251212512225123251242512525126251272512825129251302513125132251332513425135251362513725138251392514025141251422514325144251452514625147251482514925150251512515225153251542515525156251572515825159251602516125162251632516425165251662516725168251692517025171251722517325174251752517625177251782517925180251812518225183251842518525186251872518825189251902519125192251932519425195251962519725198251992520025201252022520325204252052520625207252082520925210252112521225213252142521525216252172521825219252202522125222252232522425225252262522725228252292523025231252322523325234252352523625237252382523925240252412524225243252442524525246252472524825249252502525125252252532525425255252562525725258252592526025261252622526325264252652526625267252682526925270252712527225273252742527525276252772527825279252802528125282252832528425285252862528725288252892529025291252922529325294252952529625297252982529925300253012530225303253042530525306253072530825309253102531125312253132531425315253162531725318253192532025321253222532325324253252532625327253282532925330253312533225333253342533525336253372533825339253402534125342253432534425345253462534725348253492535025351253522535325354253552535625357253582535925360253612536225363253642536525366253672536825369253702537125372253732537425375253762537725378253792538025381253822538325384253852538625387253882538925390253912539225393253942539525396253972539825399254002540125402254032540425405254062540725408254092541025411254122541325414254152541625417254182541925420254212542225423254242542525426254272542825429254302543125432254332543425435254362543725438254392544025441254422544325444254452544625447254482544925450254512545225453254542545525456254572545825459254602546125462254632546425465254662546725468254692547025471254722547325474254752547625477254782547925480254812548225483254842548525486254872548825489254902549125492254932549425495254962549725498254992550025501255022550325504255052550625507255082550925510255112551225513255142551525516255172551825519255202552125522255232552425525255262552725528255292553025531255322553325534255352553625537255382553925540255412554225543255442554525546255472554825549255502555125552255532555425555255562555725558255592556025561255622556325564255652556625567255682556925570255712557225573255742557525576255772557825579255802558125582255832558425585255862558725588255892559025591255922559325594255952559625597255982559925600256012560225603256042560525606256072560825609256102561125612256132561425615256162561725618256192562025621256222562325624256252562625627256282562925630256312563225633256342563525636256372563825639256402564125642256432564425645256462564725648256492565025651256522565325654256552565625657256582565925660256612566225663256642566525666256672566825669256702567125672256732567425675256762567725678256792568025681256822568325684256852568625687256882568925690256912569225693256942569525696256972569825699257002570125702257032570425705257062570725708257092571025711257122571325714257152571625717257182571925720257212572225723257242572525726257272572825729257302573125732257332573425735257362573725738257392574025741257422574325744257452574625747257482574925750257512575225753257542575525756257572575825759257602576125762257632576425765257662576725768257692577025771257722577325774257752577625777257782577925780257812578225783257842578525786257872578825789257902579125792257932579425795257962579725798257992580025801258022580325804258052580625807258082580925810258112581225813258142581525816258172581825819258202582125822258232582425825258262582725828258292583025831258322583325834258352583625837258382583925840258412584225843258442584525846258472584825849258502585125852258532585425855258562585725858258592586025861258622586325864258652586625867258682586925870258712587225873258742587525876258772587825879258802588125882258832588425885258862588725888258892589025891258922589325894258952589625897258982589925900259012590225903259042590525906259072590825909259102591125912259132591425915259162591725918259192592025921259222592325924259252592625927259282592925930259312593225933259342593525936259372593825939259402594125942259432594425945259462594725948259492595025951259522595325954259552595625957259582595925960259612596225963259642596525966259672596825969259702597125972259732597425975259762597725978259792598025981259822598325984259852598625987259882598925990259912599225993259942599525996259972599825999260002600126002260032600426005260062600726008260092601026011260122601326014260152601626017260182601926020260212602226023260242602526026260272602826029260302603126032260332603426035260362603726038260392604026041260422604326044260452604626047260482604926050260512605226053260542605526056260572605826059260602606126062260632606426065260662606726068260692607026071260722607326074260752607626077260782607926080260812608226083260842608526086260872608826089260902609126092260932609426095260962609726098260992610026101261022610326104261052610626107261082610926110261112611226113261142611526116261172611826119261202612126122261232612426125261262612726128261292613026131261322613326134261352613626137261382613926140261412614226143261442614526146261472614826149261502615126152261532615426155261562615726158261592616026161261622616326164261652616626167261682616926170261712617226173261742617526176261772617826179261802618126182261832618426185261862618726188261892619026191261922619326194261952619626197261982619926200262012620226203262042620526206262072620826209262102621126212262132621426215262162621726218262192622026221262222622326224262252622626227262282622926230262312623226233262342623526236262372623826239262402624126242262432624426245262462624726248262492625026251262522625326254262552625626257262582625926260262612626226263262642626526266262672626826269262702627126272262732627426275262762627726278262792628026281262822628326284262852628626287262882628926290262912629226293262942629526296262972629826299263002630126302263032630426305263062630726308263092631026311263122631326314263152631626317263182631926320263212632226323263242632526326263272632826329263302633126332263332633426335263362633726338263392634026341263422634326344263452634626347263482634926350263512635226353263542635526356263572635826359263602636126362263632636426365263662636726368263692637026371263722637326374263752637626377263782637926380263812638226383263842638526386263872638826389263902639126392263932639426395263962639726398263992640026401264022640326404264052640626407264082640926410264112641226413264142641526416264172641826419264202642126422264232642426425264262642726428264292643026431264322643326434264352643626437264382643926440264412644226443264442644526446264472644826449264502645126452264532645426455264562645726458264592646026461264622646326464264652646626467264682646926470264712647226473264742647526476264772647826479264802648126482264832648426485264862648726488264892649026491264922649326494264952649626497264982649926500265012650226503265042650526506265072650826509265102651126512265132651426515265162651726518265192652026521265222652326524265252652626527265282652926530265312653226533265342653526536265372653826539265402654126542265432654426545265462654726548265492655026551265522655326554265552655626557265582655926560265612656226563265642656526566265672656826569265702657126572265732657426575265762657726578265792658026581265822658326584265852658626587265882658926590265912659226593265942659526596265972659826599266002660126602266032660426605266062660726608266092661026611266122661326614266152661626617266182661926620266212662226623266242662526626266272662826629266302663126632266332663426635266362663726638266392664026641266422664326644266452664626647266482664926650266512665226653266542665526656266572665826659266602666126662266632666426665266662666726668266692667026671266722667326674266752667626677266782667926680266812668226683266842668526686266872668826689266902669126692266932669426695266962669726698266992670026701267022670326704267052670626707267082670926710267112671226713267142671526716267172671826719267202672126722267232672426725267262672726728267292673026731267322673326734267352673626737267382673926740267412674226743267442674526746267472674826749267502675126752267532675426755267562675726758267592676026761267622676326764267652676626767267682676926770267712677226773267742677526776267772677826779267802678126782267832678426785267862678726788267892679026791267922679326794267952679626797267982679926800268012680226803268042680526806268072680826809268102681126812268132681426815268162681726818268192682026821268222682326824268252682626827268282682926830268312683226833268342683526836268372683826839268402684126842268432684426845268462684726848268492685026851268522685326854268552685626857268582685926860268612686226863268642686526866268672686826869268702687126872268732687426875268762687726878268792688026881268822688326884268852688626887268882688926890268912689226893268942689526896268972689826899269002690126902269032690426905269062690726908269092691026911269122691326914269152691626917269182691926920269212692226923269242692526926269272692826929269302693126932269332693426935269362693726938269392694026941269422694326944269452694626947269482694926950269512695226953269542695526956269572695826959269602696126962269632696426965269662696726968269692697026971269722697326974269752697626977269782697926980269812698226983269842698526986269872698826989269902699126992269932699426995269962699726998269992700027001270022700327004270052700627007270082700927010270112701227013270142701527016270172701827019270202702127022270232702427025270262702727028270292703027031270322703327034270352703627037270382703927040270412704227043270442704527046270472704827049270502705127052270532705427055270562705727058270592706027061270622706327064270652706627067270682706927070270712707227073270742707527076270772707827079270802708127082270832708427085270862708727088270892709027091270922709327094270952709627097270982709927100271012710227103271042710527106271072710827109271102711127112271132711427115271162711727118271192712027121271222712327124271252712627127271282712927130271312713227133271342713527136271372713827139271402714127142271432714427145271462714727148271492715027151271522715327154271552715627157271582715927160271612716227163271642716527166271672716827169271702717127172271732717427175271762717727178271792718027181271822718327184271852718627187271882718927190271912719227193271942719527196271972719827199272002720127202272032720427205272062720727208272092721027211272122721327214272152721627217272182721927220272212722227223272242722527226272272722827229272302723127232272332723427235272362723727238272392724027241272422724327244272452724627247272482724927250272512725227253272542725527256272572725827259272602726127262272632726427265272662726727268272692727027271272722727327274272752727627277272782727927280272812728227283272842728527286272872728827289272902729127292272932729427295272962729727298272992730027301273022730327304273052730627307273082730927310273112731227313273142731527316273172731827319273202732127322273232732427325273262732727328273292733027331273322733327334273352733627337273382733927340273412734227343273442734527346273472734827349273502735127352273532735427355273562735727358273592736027361273622736327364273652736627367273682736927370273712737227373273742737527376273772737827379273802738127382273832738427385273862738727388273892739027391273922739327394273952739627397273982739927400274012740227403274042740527406274072740827409274102741127412274132741427415274162741727418274192742027421274222742327424274252742627427274282742927430274312743227433274342743527436274372743827439274402744127442274432744427445274462744727448274492745027451274522745327454274552745627457274582745927460274612746227463274642746527466274672746827469274702747127472274732747427475274762747727478274792748027481274822748327484274852748627487274882748927490274912749227493274942749527496274972749827499275002750127502275032750427505275062750727508275092751027511275122751327514275152751627517275182751927520275212752227523275242752527526275272752827529275302753127532275332753427535275362753727538275392754027541275422754327544275452754627547275482754927550275512755227553275542755527556275572755827559275602756127562275632756427565275662756727568275692757027571275722757327574275752757627577275782757927580275812758227583275842758527586275872758827589275902759127592275932759427595275962759727598275992760027601276022760327604276052760627607276082760927610276112761227613276142761527616276172761827619276202762127622276232762427625276262762727628276292763027631276322763327634276352763627637276382763927640276412764227643276442764527646276472764827649276502765127652276532765427655276562765727658276592766027661276622766327664276652766627667276682766927670276712767227673276742767527676276772767827679276802768127682276832768427685276862768727688276892769027691276922769327694276952769627697276982769927700277012770227703277042770527706277072770827709277102771127712277132771427715277162771727718277192772027721277222772327724277252772627727277282772927730277312773227733277342773527736277372773827739277402774127742277432774427745277462774727748277492775027751277522775327754277552775627757277582775927760277612776227763277642776527766277672776827769277702777127772277732777427775277762777727778277792778027781277822778327784277852778627787277882778927790277912779227793277942779527796277972779827799278002780127802278032780427805278062780727808278092781027811278122781327814278152781627817278182781927820278212782227823278242782527826278272782827829278302783127832278332783427835278362783727838278392784027841278422784327844278452784627847278482784927850278512785227853278542785527856278572785827859278602786127862278632786427865278662786727868278692787027871278722787327874278752787627877278782787927880278812788227883278842788527886278872788827889278902789127892278932789427895278962789727898278992790027901279022790327904279052790627907279082790927910279112791227913279142791527916279172791827919279202792127922279232792427925279262792727928279292793027931279322793327934279352793627937279382793927940279412794227943279442794527946279472794827949279502795127952279532795427955279562795727958279592796027961279622796327964279652796627967279682796927970279712797227973279742797527976279772797827979279802798127982279832798427985279862798727988279892799027991279922799327994279952799627997279982799928000280012800228003280042800528006280072800828009280102801128012280132801428015280162801728018280192802028021280222802328024280252802628027280282802928030280312803228033280342803528036280372803828039280402804128042280432804428045280462804728048280492805028051280522805328054280552805628057280582805928060280612806228063280642806528066280672806828069280702807128072280732807428075280762807728078280792808028081280822808328084280852808628087280882808928090280912809228093280942809528096280972809828099281002810128102281032810428105281062810728108281092811028111281122811328114281152811628117281182811928120281212812228123281242812528126281272812828129281302813128132281332813428135281362813728138281392814028141281422814328144281452814628147281482814928150281512815228153281542815528156281572815828159281602816128162281632816428165281662816728168281692817028171281722817328174281752817628177281782817928180281812818228183281842818528186281872818828189281902819128192281932819428195281962819728198281992820028201282022820328204282052820628207282082820928210282112821228213282142821528216282172821828219282202822128222282232822428225282262822728228282292823028231282322823328234282352823628237282382823928240282412824228243282442824528246282472824828249282502825128252282532825428255282562825728258282592826028261282622826328264282652826628267282682826928270282712827228273282742827528276282772827828279282802828128282282832828428285282862828728288282892829028291282922829328294282952829628297282982829928300283012830228303283042830528306283072830828309283102831128312283132831428315283162831728318283192832028321283222832328324283252832628327283282832928330283312833228333283342833528336283372833828339283402834128342283432834428345283462834728348283492835028351283522835328354283552835628357283582835928360283612836228363
  1. 2012-10-02 Daniel Bates <dbates@webkit.org>
  2. Define watch list "webkitperl", "SVNScripts", and "XSS" to watch for changes
  3. to Tools/Scripts/{VCSUtils.pm, webkitdirs.pm, webkitperl}, Tools/Scripts/svn-*
  4. scripts, and files whose name contains the word "XSS", respectively. Subscribe
  5. myself to these lists.
  6. * Scripts/webkitpy/common/config/watchlist:
  7. 2012-10-02 Roger Fong <roger_fong@apple.com>
  8. executive_unittest.py fails on Apple Windows bots but not when run locally.
  9. https://bugs.webkit.org/show_bug.cgi?id=98196
  10. Reviewed by Eric Seidel.
  11. Making the test more flexible to check for cygwin and allow different outputs from process.wait().
  12. * Scripts/webkitpy/common/system/executive_unittest.py:
  13. (ExecutiveTest.serial_test_kill_process):
  14. 2012-10-02 Roger Fong <roger_fong@apple.com>
  15. Ignore failing line of SpacebarScrolling API test on Windows.
  16. https://bugs.webkit.org/show_bug.cgi?id=84961
  17. Reviewed by Anders Carlsson.
  18. Test is failing because of https://bugs.webkit.org/show_bug.cgi?id=97946.
  19. Ignoring the line that fails on Windows for now until the larger problem at hand is fixed.
  20. * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  21. (TestWebKitAPI::TEST):
  22. 2012-10-02 Tony Chang <tony@chromium.org>
  23. check-webkit-style can't handle qt-arm, qt-win, qt-mac, qt-5.0, qt-5.0-wk1 and qt-5.0-wk2 TestExpecatations
  24. https://bugs.webkit.org/show_bug.cgi?id=98140
  25. Reviewed by Eric Seidel.
  26. Fix a bug where we were always using the host OS rather than using what was passed in as part of the
  27. port name on Qt.
  28. There's also a bug with being able to test for qt-5.0 expectations files when on a system with
  29. Qt 4.8 installed. I'm not sure how to solve that, so for now, stop emitting a style warning about
  30. not checking a file.
  31. * Scripts/webkitpy/layout_tests/port/qt.py:
  32. (QtPort._search_paths): Use passed in OS.
  33. * Scripts/webkitpy/style/checkers/test_expectations.py:
  34. (TestExpectationsChecker.check): Don't warn if we don't know about the TestExpectations file.
  35. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  36. (TestExpectationsTestCase.test_determine_port_from_expectations_path): Added a test case for the OS fix.
  37. Add a commented out test for the version case.
  38. 2012-10-02 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  39. Remove the last bits of MSYS support from webkitperl.
  40. https://bugs.webkit.org/show_bug.cgi?id=98195
  41. Reviewed by Eric Seidel.
  42. No ports currently need MinGW/MSYS support, so remove the last
  43. hackish bits related to it from our Perl code.
  44. * Scripts/commit-log-editor:
  45. (createCommitMessage):
  46. * Scripts/old-run-webkit-tests:
  47. * Scripts/webkitdirs.pm:
  48. (isAnyWindows):
  49. (isWindows):
  50. 2012-10-02 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  51. Remove MSYS-related changes to the http testing infrastructure.
  52. https://bugs.webkit.org/show_bug.cgi?id=98183
  53. Reviewed by Eric Seidel.
  54. In the process of removing the cruft that has accumulated in our
  55. Apache configuration code, we can basically revert r77161 which
  56. added some MSYS (mingw)-specific code to old-run-webkit-tests,
  57. since it is not being used by any port anymore.
  58. * Scripts/run-webkit-httpd: Remove isMsys()-dependent hacks.
  59. * Scripts/webkitperl/httpd.pm:
  60. (getHTTPDPath): Remove isMsys() code path.
  61. (getDefaultConfigForTestDirectory): Revert isMsys() hacks.
  62. (getHTTPDConfigPathForTestDirectory): Do not point to the noew
  63. removed apache2-msys-httpd.conf.
  64. (convertMsysPath): Removed.
  65. 2012-10-02 Sadrul Habib Chowdhury <sadrul@chromium.org>
  66. [chromium] Make sure the touch-points in the touch-events have the correct state.
  67. https://bugs.webkit.org/show_bug.cgi?id=98110
  68. Reviewed by Adam Barth.
  69. TestWebPlugin can now be configured to print out some details about
  70. events. For now, details for only touch events are printed. This is
  71. used to verify that touch-points in the touch-events are properly
  72. set.
  73. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  74. (pointState):
  75. (printTouchList):
  76. (printEventDetails):
  77. (TestWebPlugin::TestWebPlugin):
  78. (TestWebPlugin::handleInputEvent):
  79. * DumpRenderTree/chromium/TestWebPlugin.h:
  80. (TestWebPlugin):
  81. 2012-10-02 Zan Dobersek <zandobersek@gmail.com>
  82. [XvfbDriver] First tests in each worker occasionally crash
  83. https://bugs.webkit.org/show_bug.cgi?id=96203
  84. Reviewed by Dirk Pranke.
  85. Often in debug builds, the first tests in each worker crash because they
  86. can't yet open the Xvfb display assigned to them. This indicates Xvfb hasn't
  87. yet been set up.
  88. To avoid this, the execution should halt for a small amount of time before tests
  89. are run so the Xvfb process has enough time to get ready. At the moment this is
  90. done right after the Xvfb process is spawned and the execution halts for one
  91. second. That value is overriden to zero when testing to not prolong the testing time.
  92. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  93. (XvfbDriver.__init__):
  94. (XvfbDriver._start):
  95. * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
  96. (XvfbDriverTest.make_driver):
  97. 2012-10-02 Christophe Dumez <christophe.dumez@intel.com>
  98. [EFL] Use XvfbDriver for layout tests
  99. https://bugs.webkit.org/show_bug.cgi?id=98162
  100. Reviewed by Kenneth Rohde Christiansen.
  101. Use XvfbDriver for layout tests on EFL port.
  102. * Scripts/webkitpy/layout_tests/port/efl.py:
  103. (EflPort._driver_class):
  104. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  105. (XvfbDriver._start): Set DUMPRENDERTREE_TEMP and LOCAL_RESOURCE_ROOT
  106. environment variables in XvfbDriver as those are needed for
  107. TestRunner::pathToLocalResource().
  108. 2012-10-02 Zan Dobersek <zandobersek@gmail.com>
  109. [Gtk] Several tests launch g_object_ref/unref assertion messages
  110. https://bugs.webkit.org/show_bug.cgi?id=95062
  111. Reviewed by Martin Robinson.
  112. Only increase and decrease reference count of the accessibility
  113. UI element if it actually exists.
  114. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  115. (AccessibilityUIElement::AccessibilityUIElement):
  116. (AccessibilityUIElement::~AccessibilityUIElement):
  117. 2012-10-02 Douglas Stockwell <dstockwell@chromium.org>
  118. [chromium] running layout tests on mountainlion should use chromium TestExpectations
  119. https://bugs.webkit.org/show_bug.cgi?id=98119
  120. Reviewed by Adam Barth.
  121. Some basic support for mountainlion has already been committed but it failed to refer
  122. to the chromium TestExpectations.
  123. * Scripts/webkitpy/layout_tests/port/chromium.py:
  124. (ChromiumPort):
  125. * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
  126. (ChromiumPortTestCase.test_all_test_configurations):
  127. 2012-10-02 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  128. webkitpy: Stop listening on port 8081 when using Apache.
  129. https://bugs.webkit.org/show_bug.cgi?id=98155
  130. Reviewed by Eric Seidel.
  131. No test currently uses this port, and the lighttpd configuration
  132. does not open it.
  133. This helps the efforts of bringing some consistency to the Apache
  134. configuration at the moment by opening the same ports in the
  135. webkitpy side and in the httpd.conf side (the idea is to remove
  136. the httpd.conf side later), and also makes the behavior consistent
  137. across the two servers we currently support.
  138. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  139. (LayoutTestApacheHttpd.__init__):
  140. 2012-10-02 Csaba Osztrogonác <ossy@webkit.org>
  141. [WK2] REGRESSION(r128623): It made layout tests extremely slow
  142. https://bugs.webkit.org/show_bug.cgi?id=96862
  143. Reviewed by Simon Hausmann.
  144. Disable calling the extremely slow WKBundleSetDatabaseQuota() between tests until proper fix.
  145. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  146. (WTR::InjectedBundle::beginTesting):
  147. 2012-10-02 Philip Rogers <pdr@google.com>
  148. Fix PerfTest standard deviation calculation.
  149. https://bugs.webkit.org/show_bug.cgi?id=98115
  150. Reviewed by Ryosuke Niwa.
  151. Previously our standard deviation calculation was incorrect. This patch
  152. updates perftest.py's algorithm to calculate the sample standard deviation
  153. (with Bessel's correction) using Knuth's online algorithm:
  154. http://en.wikipedia.org/wiki/Algorithms_for_calculating_variance#Online_algorithm
  155. An existing test has been modified to prove our new results.
  156. This patch also updates runner.js to use Bessel's correction in
  157. its sample standard deviation calculation, which is more accurate
  158. for small sample sizes.
  159. Additionally, runner.js has been modified to not calculate
  160. the 'sum' statistic, which was not very useful.
  161. * Scripts/webkitpy/performance_tests/perftest.py:
  162. The unused variable valueSum has also been removed.
  163. (PageLoadingPerfTest.run):
  164. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  165. This test calculates the stdev of {2000, 3000, ..., 20000} which
  166. was hand-calculated using a spreadsheet.
  167. (TestPageLoadingPerfTest.test_run):
  168. 2012-10-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  169. webkitpy should accept a different httpd.conf specified by the user
  170. https://bugs.webkit.org/show_bug.cgi?id=98071
  171. Reviewed by Dirk Pranke.
  172. The existing httpd.conf variants (or lighttpd.conf, for that
  173. matter) we have do not always suit the user's system. This is
  174. particularly true on Linux/Unix, where Apache can be installed in
  175. a plethora of ways and the LoadModule calls can fail to specify
  176. the proper module paths.
  177. For now, we start accepting the WEBKIT_HTTP_SERVER_CONF_PATH
  178. environment variable, which allows the user to specify the
  179. absolute path to another http server configuration file that might
  180. work on the user's system.
  181. In the long term, we should try to generate our configuration file
  182. and stop requiring all the different httpd.conf files we have as
  183. well as this hack.
  184. * Scripts/webkitpy/layout_tests/port/base.py:
  185. (Port._path_to_apache_config_file):
  186. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  187. (test_path_to_apache_config_file):
  188. 2012-10-01 Emil A Eklund <eae@chromium.org>
  189. Unreviewed, upgrade eae to reviewer.
  190. http://lists.webkit.org/mailman/private/webkit-committers/2012-October/000191.html
  191. * Scripts/webkitpy/common/config/committers.py:
  192. 2012-10-01 Ming Xie <mxie@rim.com>
  193. [BlackBerry] Add a early return in buildCMakeProjectOrExit()
  194. https://bugs.webkit.org/show_bug.cgi?id=98052
  195. Reviewed by Rob Buis.
  196. This option allows our build to only run the CMake build configuration
  197. step when environment variable GENERATE_CMAKE_PROJECT_ONLY is specified.
  198. * Scripts/webkitdirs.pm:
  199. (buildCMakeProjectOrExit):
  200. 2012-10-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  201. [webkitpy] Detect the multiple names of the wdiff binary in the Port class.
  202. https://bugs.webkit.org/show_bug.cgi?id=98039
  203. Reviewed by Dirk Pranke.
  204. Unify the duplicate checks for the wdiff binary present in
  205. different ports into the base Port class.
  206. * Scripts/webkitpy/layout_tests/port/base.py:
  207. (Port):
  208. (Port._path_to_wdiff):
  209. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  210. (ChromiumLinuxPort._path_to_wdiff): Removed.
  211. * Scripts/webkitpy/layout_tests/port/gtk.py:
  212. (GtkPort._path_to_wdiff): Removed.
  213. 2012-10-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  214. [chromium] Remove custom implementation of _path_to_apache_config_file in chromium_linux.
  215. https://bugs.webkit.org/show_bug.cgi?id=98042
  216. Reviewed by Dirk Pranke.
  217. The Chromium-based ports inherit from Port these days, so get rid
  218. of the custom implementation of _path_to_apache_config_file() in
  219. favor of the more portable one in the Port class.
  220. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  221. (ChromiumLinuxPort._path_to_apache_config_file):
  222. 2012-10-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  223. [chromium] Remove duplicated _is_redhat_based() implementation from chromium_linux.py.
  224. https://bugs.webkit.org/show_bug.cgi?id=98035
  225. Reviewed by Dirk Pranke.
  226. Since the Chromium port classes inherit from Port these days, it
  227. can rely on the same implementation of _is_redhat_based() present
  228. there instead of duplicating it.
  229. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  230. (ChromiumLinuxPort._is_redhat_based): Removed.
  231. 2012-10-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  232. [GTK] Rely on the general implementation for detecting the Apache server path.
  233. https://bugs.webkit.org/show_bug.cgi?id=98033
  234. Reviewed by Martin Robinson.
  235. The implemenentation of _path_to_apache() in base.py already
  236. checks for the same paths gtk.py tries; the only difference is
  237. that all of the are tried regardless of the current distro.
  238. Doing so is more portable, and lets us remove some distro-checking
  239. from the code.
  240. * Scripts/webkitpy/layout_tests/port/gtk.py:
  241. (GtkPort._path_to_apache): Remove.
  242. 2012-10-01 Csaba Osztrogonác <ossy@webkit.org>
  243. Unreviewed, update the URL of the Szeged SVN mirror.
  244. * BuildSlaveSupport/build.webkit.org-config/config.json:
  245. 2012-10-01 Yuta Kitamura <yutak@chromium.org>
  246. Unreviewed. Create WebSocket watch list, and add myself to that list.
  247. * Scripts/webkitpy/common/config/watchlist:
  248. 2012-09-30 Taiju Tsuiki <tzik@chromium.org>
  249. Unreviewed. Adding myself as a committer.
  250. * Scripts/webkitpy/common/config/committers.py:
  251. 2012-09-30 Sadrul Habib Chowdhury <sadrul@chromium.org>
  252. [chromium] Add a test to verify that a plugin does not receive touch-events unless it explicitly requests for them
  253. https://bugs.webkit.org/show_bug.cgi?id=97975
  254. Reviewed by Adam Barth.
  255. TestWebPlugin can now be configured to accept touch events or not. Use this
  256. configurability to verify that a plugin does not receive touch events unless
  257. it explicitly requests for them.
  258. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  259. (TestWebPlugin::TestWebPlugin):
  260. (TestWebPlugin::initialize):
  261. (TestWebPlugin::parseBoolean):
  262. * DumpRenderTree/chromium/TestWebPlugin.h:
  263. (TestWebPlugin):
  264. 2012-09-28 Mariusz Grzegorczyk <mariusz.g@samsung.com>
  265. [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port
  266. https://bugs.webkit.org/show_bug.cgi?id=91844
  267. Reviewed by Simon Hausmann.
  268. Turn on Netscape Plugin API option by default.
  269. * Scripts/webkitperl/FeatureList.pm:
  270. 2012-09-28 Dirk Pranke <dpranke@chromium.org>
  271. webkit-patch rebaseline-expectations is broken
  272. https://bugs.webkit.org/show_bug.cgi?id=97619
  273. Reviewed by Ojan Vafai.
  274. The new expectations format is causing two problems for
  275. webkit-patch rebaseline expectations
  276. 1) the transformation into and out of the old syntax (which is
  277. still used internally) is somewhat lossy, e.g., we're not
  278. preserving the case of Bug(x) identifiers. Also, we can't
  279. tell if the input was [ WontFix ] or [ Skip WontFix Pass ]
  280. 2) the new syntax is more lenient, allowing for multiple ways to
  281. specify the same result, e.g., "[ Skip ]" may or may not be
  282. missing.
  283. As a result, we end up rewriting a whole bunch of lines for
  284. purely syntactic differences.
  285. Both of these things are bugs that need to be fixed, but
  286. we should also not just rewrite lines that shouldn't be
  287. modified.
  288. This patch fixes the last issue (no rewriting).
  289. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  290. (TestExpectationLine._format_line):
  291. (TestExpectations.remove_rebaselined_tests):
  292. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  293. (RebaseliningTest.test_remove):
  294. 2012-09-28 Dirk Pranke <dpranke@chromium.org>
  295. virtual directories should just rename the beginning of the test path
  296. https://bugs.webkit.org/show_bug.cgi?id=97925
  297. Reviewed by Ojan Vafai.
  298. We were replacing all occurrences of the base prefix of a
  299. virtual test suite with the virtual name, instead of just the
  300. first. So, where we had softwarecompositing running the
  301. compositing tests, any compositing test that actually had
  302. "compositing" in the test base name would get that expanded
  303. incorrectly.
  304. * Scripts/webkitpy/layout_tests/port/base.py:
  305. (Port.populated_virtual_test_suites):
  306. (Port.lookup_virtual_test_base):
  307. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  308. (PortTest.test_tests):
  309. * Scripts/webkitpy/layout_tests/port/test.py:
  310. 2012-09-28 Ojan Vafai <ojan@chromium.org>
  311. Garden-o-matic sometimes things buildbot warnings are failures
  312. https://bugs.webkit.org/show_bug.cgi?id=97926
  313. Reviewed by Tony Chang.
  314. It turns out the JSON clearly tells us if it's a failure.
  315. We want to skip all warnings even if they don't have "warning" in the text.
  316. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  317. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  318. 2012-09-28 Harald Tveit Alvestrand <harald@alvestrand.no>
  319. Implement the GetStats interface on PeerConnection
  320. https://bugs.webkit.org/show_bug.cgi?id=95193
  321. Reviewed by Adam Barth.
  322. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  323. (RTCStatsRequestSucceededTask):
  324. (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
  325. (MockWebRTCPeerConnectionHandler::getStats):
  326. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  327. (MockWebRTCPeerConnectionHandler):
  328. 2012-09-28 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  329. [NRWT] XvfbDriver should choose the next free display
  330. https://bugs.webkit.org/show_bug.cgi?id=88414
  331. Reviewed by Dirk Pranke.
  332. This change how the XvfbDriver choose the next display. Before
  333. this the choosing are based on the worker number but it caused
  334. errors when several nrwt run on the same time. This add process
  335. based free diplay search.
  336. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  337. (XvfbDriver.__init__):
  338. (XvfbDriver._next_free_display):
  339. (XvfbDriver._start):
  340. (XvfbDriver.stop):
  341. * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
  342. (XvfbDriverTest.make_driver):
  343. (XvfbDriverTest.test_start_no_pixel_tests):
  344. (XvfbDriverTest.test_start_pixel_tests):
  345. (XvfbDriverTest.test_start_arbitrary_worker_number):
  346. (XvfbDriverTest.test_next_free_display):
  347. (XvfbDriverTest):
  348. (XvfbDriverTest.test_start_next_worker):
  349. 2012-09-28 Huang Dongsung <luxtella@company100.net>
  350. [GTK] Enable CSS Shaders layout LayoutTests on GTK+
  351. https://bugs.webkit.org/show_bug.cgi?id=97821
  352. Reviewed by Martin Robinson.
  353. This feature is disabled via Settings by default, but for testing,
  354. we enable it using layoutTestController.overridePreferences. Add the
  355. necessary plumbing for DRT.
  356. WTR already works because support was added for Apple Mac earlier.
  357. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  358. (resetDefaultsToConsistentValues): Feature is off by default.
  359. * DumpRenderTree/gtk/TestRunnerGtk.cpp:
  360. (TestRunner::overridePreference): Add handling of WebKitCSSCustomFilterEnabled.
  361. 2012-09-28 Csaba Osztrogonác <ossy@webkit.org>
  362. [Qt] Make NRWT use wk2/TestExpectations file
  363. https://bugs.webkit.org/show_bug.cgi?id=97894
  364. Reviewed by Simon Hausmann.
  365. * Scripts/webkitpy/layout_tests/port/qt.py: Remove unnecessary _skipped_file_search_paths function.
  366. (QtPort.expectations_files): Add wk2 if --webkit-test-runner option added.
  367. * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Remove unnecessary test__skipped_file_search_paths function.
  368. (QtPortTest._assert_search_path): Removed.
  369. (QtPortTest.test_expectations_files): Add wk2 if --webkit-test-runner option added, and code cleanup.
  370. 2012-09-28 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  371. [EFL][DRT] EFL's layoutTestController.keepWebHistory should enable visited links tracking
  372. https://bugs.webkit.org/show_bug.cgi?id=97901
  373. Reviewed by Kenneth Rohde Christiansen.
  374. EFL's DRT testRunner.keepWebHistory should enable visited links tracking in order
  375. to be consistent with WTR implementation and also several tests rely on that (fast/history).
  376. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  377. (TestRunner::keepWebHistory):
  378. 2012-09-28 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  379. [EFL][DRT] EFL DRT should disable visited links tracking by default
  380. https://bugs.webkit.org/show_bug.cgi?id=97881
  381. Reviewed by Kenneth Rohde Christiansen.
  382. Visited links tracking is disabled by default for each test.
  383. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  384. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  385. 2012-09-28 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  386. Unreviewed, rolling out r129863.
  387. http://trac.webkit.org/changeset/129863
  388. https://bugs.webkit.org/show_bug.cgi?id=97173
  389. Broken debug WK2 layout test
  390. * MiniBrowser/efl/main.c:
  391. (quit):
  392. (main):
  393. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
  394. (WTR::initEcoreEvas):
  395. (WTR::PlatformWebView::~PlatformWebView):
  396. * WebKitTestRunner/efl/main.cpp:
  397. (main):
  398. 2012-09-28 Kai Koehne <kai.koehne@digia.com>
  399. [Qt] Use qInstallMessageHandler()
  400. https://bugs.webkit.org/show_bug.cgi?id=96648
  401. Reviewed by Jocelyn Turcotte.
  402. qInstallMsgHandler() got deprecated in Qt 5.
  403. * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
  404. (messageHandler):
  405. (main):
  406. * WebKitTestRunner/qt/main.cpp:
  407. (messageHandler):
  408. (main):
  409. 2012-09-28 Eunmi Lee <eunmi15.lee@samsung.com>
  410. [EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries.
  411. https://bugs.webkit.org/show_bug.cgi?id=97173
  412. Reviewed by Gyuyoung Kim.
  413. The initialization and shutdown are done inside the webkit, so we don't
  414. have to call them out of the webkit.
  415. * MiniBrowser/efl/main.c:
  416. (quit):
  417. (main):
  418. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
  419. (WTR::initEcoreEvas):
  420. (WTR::PlatformWebView::~PlatformWebView):
  421. * WebKitTestRunner/efl/main.cpp:
  422. (main):
  423. 2012-09-27 Alexandre Elias <aelias@chromium.org>
  424. [chromium] DumpRenderTree support for software compositing
  425. https://bugs.webkit.org/show_bug.cgi?id=96853
  426. Reviewed by James Robinson.
  427. This adds software compositor support to DumpRenderTree. The only
  428. thing needed is a minimal OutputSurfaceSoftware that holds a
  429. viewport-sized bitmap. Then, I added virtual test suite
  430. platform/chromium/virtual/softwarecompositing -- a mirror of the
  431. compositing/ directory with --enable-software-compositing, and
  432. expectations for not yet supported tests.
  433. * DumpRenderTree/DumpRenderTree.gypi:
  434. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  435. (main):
  436. * DumpRenderTree/chromium/TestShell.cpp:
  437. (TestShell::TestShell):
  438. * DumpRenderTree/chromium/TestShell.h:
  439. (TestShell::softwareCompositingEnabled):
  440. (TestShell::setSoftwareCompositingEnabled):
  441. (TestShell):
  442. * DumpRenderTree/chromium/WebViewHost.cpp:
  443. (WebViewHost::createOutputSurface):
  444. * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp:
  445. (WebKit::WebViewHostOutputSurface::create3d):
  446. (WebKit):
  447. (WebKit::WebViewHostOutputSurface::createSoftware):
  448. (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
  449. (WebKit::WebViewHostOutputSurface::bindToClient):
  450. (WebKit::WebViewHostOutputSurface::surfaceSoftware):
  451. * DumpRenderTree/chromium/WebViewHostOutputSurface.h:
  452. (WebKit):
  453. (WebViewHostOutputSurface):
  454. * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.
  455. (WebKit):
  456. (WebKit::WebViewHostSoftwareOutputDevice::lockForWrite):
  457. (WebKit::WebViewHostSoftwareOutputDevice::unlockForWrite):
  458. (WebKit::WebViewHostSoftwareOutputDevice::lockForRead):
  459. (WebKit::WebViewHostSoftwareOutputDevice::unlockForRead):
  460. (WebKit::WebViewHostSoftwareOutputDevice::viewportChanged):
  461. * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.
  462. (WebKit):
  463. (WebViewHostSoftwareOutputDevice):
  464. * Scripts/webkitpy/layout_tests/port/chromium.py:
  465. (ChromiumPort.virtual_test_suites):
  466. 2012-09-27 Nasko Oskov <nasko@chromium.org>
  467. Move DumpRenderTree to use newer version of the name method of
  468. WebFrame and the willCheckAndDispatchMessageEvent method of WebFrameClient
  469. https://bugs.webkit.org/show_bug.cgi?id=95254
  470. Reviewed by Adam Barth.
  471. The WebFrame name() method is removed and replaced by better named
  472. uniqueName() method, so DRT needs to be updated to use this new version.
  473. Also the willCheckAndDispatchMessageEvent in WebFrameClient gained
  474. one more parameter, which had to be added in DRT.
  475. * DumpRenderTree/chromium/TestShell.cpp:
  476. (dumpFramesAsText):
  477. (dumpFramesAsPrintedText):
  478. (dumpFrameScrollPosition):
  479. * DumpRenderTree/chromium/WebViewHost.cpp:
  480. (WebViewHost::unableToImplementPolicyWithError):
  481. (WebViewHost::willCheckAndDispatchMessageEvent):
  482. (WebViewHost::printFrameDescription):
  483. * DumpRenderTree/chromium/WebViewHost.h:
  484. (WebViewHost):
  485. 2012-09-27 Julie Parent <jparent@chromium.org>
  486. Add webkit_unit_tests to the flakiness dashboard
  487. https://bugs.webkit.org/show_bug.cgi?id=97814
  488. Reviewed by Dirk Pranke.
  489. webkit_unit_tests run on the same bots as test_shell_tests.
  490. * TestResultServer/static-dashboards/builders.js:
  491. (loadBuildersList):
  492. * TestResultServer/static-dashboards/dashboard_base.js:
  493. (currentBuilderGroupCategory):
  494. 2012-09-27 Florin Malita <fmalita@chromium.org>
  495. [Perftest] PerfTestRunner exception when using nested git checkouts
  496. https://bugs.webkit.org/show_bug.cgi?id=97796
  497. Reviewed by Ryosuke Niwa.
  498. In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
  499. instantiate per-repository SCM objects when collecting revision information.
  500. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  501. (PerfTestsRunner._generate_results_dict):
  502. 2012-09-27 Sudarsana Nagineni <sudarsana.nagineni@intel.com>
  503. [Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
  504. https://bugs.webkit.org/show_bug.cgi?id=97805
  505. Reviewed by Alexey Proskuryakov.
  506. Add support for handling a string as modifier argument to keyDown().
  507. This support has already been added to other ports, so implementing
  508. this on Mac too, to be consistent with the other ports.
  509. * DumpRenderTree/mac/EventSendingController.mm:
  510. (modifierFlags):
  511. (buildModifierFlags):
  512. 2012-09-27 Dirk Pranke <dpranke@chromium.org>
  513. efl wk2 bots weren't looking at platform/wk2/TestExpectations
  514. https://bugs.webkit.org/show_bug.cgi?id=97815
  515. Unreviewed, build fix.
  516. Should clean up this logic later so that we're just using the
  517. implementation in base ...
  518. * Scripts/webkitpy/layout_tests/port/efl.py:
  519. (EflPort._search_paths):
  520. (EflPort.expectations_files):
  521. 2012-09-27 Dirk Pranke <dpranke@chromium.org>
  522. webkitpy: make warning about missing BUG identifiers per-port configurable
  523. https://bugs.webkit.org/show_bug.cgi?id=97751
  524. Reviewed by Ojan Vafai.
  525. Prior to this change linting TestExpectations files (checking their style)
  526. would raise warnings if lines were missing a BUG modifier, even
  527. though such a modifier is actually optional in the syntax. As we
  528. migrate the entries over from the Skipped files, these warnings
  529. will generate a lot of noise, and it's not yet clear that we
  530. actually want to require the modifiers on all ports.
  531. So, this change makes this per-port configurable so that they
  532. will generate warnings in the Chromium TestExpectations and not
  533. anywhere else.
  534. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  535. (TestExpectationParser._parse_modifiers):
  536. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  537. (MiscTests.test_parse_warning):
  538. (SemanticTests.test_missing_bugid):
  539. * Scripts/webkitpy/layout_tests/port/base.py:
  540. (Port.warn_if_bug_missing_in_test_expectations):
  541. * Scripts/webkitpy/layout_tests/port/chromium.py:
  542. (ChromiumPort.warn_if_bug_missing_in_test_expectations):
  543. 2012-09-27 Xianzhu Wang <wangxianzhu@chromium.org>
  544. [Chromium-Android] Push more fonts for layout tests to match chromium-linux
  545. https://bugs.webkit.org/show_bug.cgi?id=97746
  546. Reviewed by Dirk Pranke.
  547. * DumpRenderTree/chromium/android_fallback_fonts.xml: Added the new fonts into fallback list. Removed the Android system fallback font DroidSansFallback.ttf.
  548. * Scripts/webkitpy/layout_tests/port/builders.py: Add chromium-android to pass style check.
  549. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  550. (ChromiumAndroidPort.check_build): Added check for md5sum and forwarder utilities to give better error message when they are missing.
  551. (ChromiumAndroidPort.check_sys_deps): Allow host font files to come from one of multiple directories.
  552. (ChromiumAndroidPort._path_to_md5sum):
  553. (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
  554. (ChromiumAndroidDriver._push_fonts):
  555. (ChromiumAndroidDriver._push_test_resources):
  556. 2012-09-27 Tommy Widenflycht <tommyw@google.com>
  557. MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
  558. https://bugs.webkit.org/show_bug.cgi?id=97559
  559. Reviewed by Adam Barth.
  560. Refactoring for the new WebMediaConstraints api.
  561. * DumpRenderTree/chromium/MockConstraints.cpp:
  562. (MockConstraints::verify):
  563. 2012-09-27 Tommy Widenflycht <tommyw@google.com>
  564. MediaStream API: Rename MockConstraints::verify to verifyConstraints
  565. https://bugs.webkit.org/show_bug.cgi?id=97779
  566. Reviewed by Csaba Osztrogonác.
  567. The Mac OS X sdk has a macro called verify :/
  568. * DumpRenderTree/chromium/MockConstraints.cpp:
  569. (MockConstraints::verifyConstraints):
  570. * DumpRenderTree/chromium/MockConstraints.h:
  571. (MockConstraints):
  572. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  573. (MockWebRTCPeerConnectionHandler::initialize):
  574. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  575. (WebUserMediaClientMock::requestUserMedia):
  576. 2012-09-27 Tommy Widenflycht <tommyw@google.com>
  577. MediaStream API: Update getUserMedia to match the latest specification
  578. https://bugs.webkit.org/show_bug.cgi?id=97540
  579. Reviewed by Adam Barth.
  580. http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
  581. Navigator.getUserMedia is changed so that the audio and video members can either
  582. be a bool or a constraints object.
  583. * public/WebUserMediaRequest.h:
  584. (WebKit):
  585. (WebUserMediaRequest):
  586. * src/WebUserMediaRequest.cpp:
  587. (WebKit::WebUserMediaRequest::audioConstraints):
  588. (WebKit):
  589. (WebKit::WebUserMediaRequest::videoConstraints):
  590. 2012-09-26 Laszlo Gombos <l.gombos@samsung.com>
  591. Unreviewed. Update my e-mail address.
  592. * Scripts/webkitpy/common/config/committers.py:
  593. 2012-09-26 Dirk Pranke <dpranke@chromium.org>
  594. modify old-run-webkit-tests to support TestExpectations files a little
  595. https://bugs.webkit.org/show_bug.cgi?id=97276
  596. Reviewed by Daniel Bates.
  597. This patch adds minimal support to old-run-webkit-tests so that
  598. it can read a TestExpectations file and skip the tests listed
  599. there. It will skip *all* tests, regardless of the expectation
  600. (even if the test is listed as [ Pass ]), and it will only look
  601. at the TestExpectations file if there isn't a Skipped file next
  602. to it.
  603. This will allow us to switch to using just using
  604. TestExpectations files without making old-run-webkit-tests
  605. totally useless.
  606. * Scripts/old-run-webkit-tests:
  607. (readSkippedFiles):
  608. (processSkippedFileEntry): Added.
  609. (startsWith): Added.
  610. 2012-09-26 Dirk Pranke <dpranke@chromium.org>
  611. The style bot spams about skia_test_expectations.txt
  612. https://bugs.webkit.org/show_bug.cgi?id=97699
  613. Reviewed by Adam Barth.
  614. Remove the warning about a missing skia_test_expectations.txt
  615. file for now. There are some situations where it would be
  616. helpful to get this warning as it might indicate that the user
  617. is going to get results different than what they're expecting,
  618. but at the moment it looks difficult if not impossible to get
  619. those warnings and not also get warnings that we don't care
  620. about, so the noise is outweighing the value of the signal.
  621. This at least will stop the false negatives we're getting on the
  622. style bots. If it turns out people do need the warning we can
  623. add it back in in some other more conditional way.
  624. * Scripts/webkitpy/layout_tests/port/chromium.py:
  625. (ChromiumPort.expectations_files):
  626. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  627. (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
  628. (test_rebaseline_updates_expectations_file):
  629. (test_rebaseline_does_not_include_overrides):
  630. (test_rebaseline_expectations):
  631. (_assert_command):
  632. 2012-09-26 David Michael Barr <davidbarr@chromium.org>
  633. Unreviewed. Upgrade myself from contributor to committer.
  634. * Scripts/webkitpy/common/config/committers.py:
  635. 2012-09-26 Ryosuke Niwa <rniwa@webkit.org>
  636. Remove deprecated code from perftestrunner.py
  637. https://bugs.webkit.org/show_bug.cgi?id=97724
  638. Reviewed by Adam Barth.
  639. Remove the code deprecated in r129580 now that we have landed r129597,
  640. which updated master.cfg to use new options, and restarted the buildbot master.
  641. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  642. (PerfTestsRunner._parse_args):
  643. (PerfTestsRunner._generate_and_show_results):
  644. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  645. (test_run_with_slave_config_json):
  646. (test_parse_args):
  647. 2012-09-26 Beth Dakin <bdakin@apple.com>
  648. https://bugs.webkit.org/show_bug.cgi?id=97629
  649. http/tests/security/cross-frame-access-put.html failing on Mac WK2 bots after
  650. being unskipped
  651. Reviewed by Tim Horton.
  652. The test was failing because we were failing to use the fake window origin. We
  653. should really always use the fake origin. This patch eliminates
  654. _shouldUseFakeOrigin in favor of always using it.
  655. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  656. (-[WebKitTestRunnerWindow setFrameOrigin:]):
  657. (-[WebKitTestRunnerWindow setFrame:display:animate:]):
  658. (-[WebKitTestRunnerWindow setFrame:display:]):
  659. (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
  660. 2012-09-26 Tony Chang <tony@chromium.org>
  661. C++ style checker should warn when the indentation is wrong
  662. https://bugs.webkit.org/show_bug.cgi?id=97602
  663. Reviewed by Ojan Vafai.
  664. Rewrite the indentation checker to ensure that indentation is always a factor of 4
  665. and that we only indent 4 spaces from the previous line.
  666. I deleted some of the old indentation checking code since it was filtered out
  667. and didn't match the webkit style.
  668. * Scripts/webkitpy/style/checker.py:
  669. * Scripts/webkitpy/style/checkers/cpp.py:
  670. (check_indentation_amount): New function that checks indentation. Intentionally runs after
  671. other indentation checks.
  672. (check_style): Delete the old indentation code since we were already filtering out the whitespace/labels warnings.
  673. (CppChecker): Remove the whitespace/labels filter.
  674. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  675. (CppStyleTest.test_multi_line_comments): Force 4 space indent.
  676. (CppStyleTest.test_explicit_single_argument_constructors):
  677. (CppStyleTest.test_explicit_single_argument_constructors.Foo):
  678. (CppStyleTest.test_explicit_single_argument_constructors.Qualifier):
  679. (CppStyleTest.test_slash_star_comment_on_single_line):
  680. (CppStyleTest.test_braces):
  681. (CppStyleTest.test_spacing_before_last_semicolon):
  682. (CppStyleTest.test_static_or_global_stlstrings):
  683. (CppStyleTest.test_indent): Added macro test case.
  684. (CppStyleTest.test_build_class):
  685. (NoNonVirtualDestructorsTest.test_no_error):
  686. (NoNonVirtualDestructorsTest.test_no_error.Foo):
  687. (NoNonVirtualDestructorsTest.test_no_error.Qualified):
  688. (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed):
  689. (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo):
  690. (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed):
  691. (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo):
  692. (NoNonVirtualDestructorsTest.test_no_warn_when_derived):
  693. (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo):
  694. (NoNonVirtualDestructorsTest.test_internal_braces):
  695. (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
  696. (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor):
  697. (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo):
  698. (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo):
  699. (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor):
  700. (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo):
  701. (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo):
  702. (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor):
  703. (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified):
  704. (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error):
  705. (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo):
  706. (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
  707. (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo):
  708. (WebKitStyleTest.test_indentation):
  709. (WebKitStyleTest.test_braces): Add test for call params spanning lines.
  710. 2012-09-26 Adam Barth <abarth@webkit.org>
  711. Rollout messages should be clickable in bugzilla
  712. https://bugs.webkit.org/show_bug.cgi?id=97711
  713. Reviewed by Simon Fraser.
  714. If we say Bug NNNN instead of just NNNN, bugzilla will autolink to the
  715. actual bug.
  716. * Scripts/webkitpy/tool/commands/download_unittest.py:
  717. * Scripts/webkitpy/tool/steps/createbug.py:
  718. (CreateBug.run):
  719. 2012-09-26 Marcelo Lira <marcelo.lira@openbossa.org>
  720. run-perf-tests must expand environment variables in user provided paths
  721. https://bugs.webkit.org/show_bug.cgi?id=97686
  722. Reviewed by Ryosuke Niwa.
  723. The run-perf-tests command line options that receive paths from the
  724. user now expand any possible environment variables, because Python's
  725. file handling methods do not handle those.
  726. Examples:
  727. run-perf-tests --platform=qt --release --output-json-path=~/perf-results
  728. run-perf-tests --platform=qt --release --output-json-path=$HOME/perf-results
  729. Also removed unused imports.
  730. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  731. (PerfTestsRunner._parse_args._expand_path): expand environment variables in a path passed via command line
  732. (PerfTestsRunner._parse_args):
  733. 2012-09-26 Sheriff Bot <webkit.review.bot@gmail.com>
  734. Unreviewed, rolling out r129654.
  735. http://trac.webkit.org/changeset/129654
  736. https://bugs.webkit.org/show_bug.cgi?id=97702
  737. breaks chromium windows build (Requested by schenney on
  738. #webkit).
  739. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  740. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  741. (MockWebRTCPeerConnectionHandler):
  742. 2012-09-26 Michael Saboff <msaboff@apple.com>
  743. Unreviewed build change.
  744. Reverting inadvertent change to project file.
  745. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  746. 2012-09-26 Harald Tveit Alvestrand <harald@alvestrand.no>
  747. Implement the GetStats interface on PeerConnection
  748. https://bugs.webkit.org/show_bug.cgi?id=95193
  749. Reviewed by Adam Barth.
  750. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  751. (RTCStatsRequestSucceededTask):
  752. (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
  753. (MockWebRTCPeerConnectionHandler::getStats):
  754. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  755. (MockWebRTCPeerConnectionHandler):
  756. 2012-09-26 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  757. [WK2][WTR] Policy client: dumping from decidePolicyForResponse callback
  758. https://bugs.webkit.org/show_bug.cgi?id=97034
  759. Reviewed by Kenneth Rohde Christiansen.
  760. Provided dumping from WTR Policy client 'decidePolicyForResponse' callback.
  761. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  762. (WTR::InjectedBundlePage::decidePolicyForResponse):
  763. 2012-09-26 Zoltan Arvai <zarvai@inf.u-szeged.hu>
  764. [Qt][WTR] Build fix for MSVC.
  765. https://bugs.webkit.org/show_bug.cgi?id=97667
  766. Reviewed by Csaba Osztrogonác.
  767. WTR misses InjectedBundle headers. Adding $$PWD to Target.pri is required for MSVC. Clean build is necessary on Windows.
  768. * WebKitTestRunner/InjectedBundle/Target.pri:
  769. 2012-09-26 Xiaobo Wang <xbwang@torchmobile.com.cn>
  770. [BlackBerry] [DRT] eventSender.keyDown() doesn't support Ctrl key modifier
  771. https://bugs.webkit.org/show_bug.cgi?id=97665
  772. Reviewed by Rob Buis.
  773. This patch fixes test fast/forms/input-text-option-delete.html.
  774. * DumpRenderTree/blackberry/EventSender.cpp:
  775. (keyDownCallback):
  776. 2012-09-26 Dinu Jacob <dinu.s.jacob@intel.com>
  777. Unreviewed. Adding myself as a committer.
  778. * Scripts/webkitpy/common/config/committers.py:
  779. 2012-09-26 Carlos Garcia Campos <cgarcia@igalia.com>
  780. [GTK] Remove color codes characters from run-gtk-tests output when not writing to a TTY
  781. https://bugs.webkit.org/show_bug.cgi?id=97660
  782. Reviewed by Philippe Normand.
  783. Remove also the '\r' characters returned by TTY output to try to fix
  784. the double line endings of the script output in the bots.
  785. * Scripts/run-gtk-tests:
  786. (TestRunner.__init__): Compile a regexp for color codes if stdout
  787. it not a TTY.
  788. (TestRunner._run_test_command.parse_line): Remove color codes and
  789. '\r' characters from the line returned by the pseudo-terminal if
  790. stdout is not a TTY.
  791. * gtk/common.py:
  792. (parse_output_lines): Fix the last chunk check to make sure we
  793. always send entire lines to the callback, otherwise color codes
  794. regexp might fail if the line is not complete.
  795. 2012-09-25 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  796. [DRT][WTR] Support overriding the 'WebKitDisplayImagesKey' preference
  797. https://bugs.webkit.org/show_bug.cgi?id=96883
  798. Reviewed by Kenneth Rohde Christiansen.
  799. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  800. (TestRunner::overridePreference): Support the
  801. 'WebKitDisplayImagesKey' preference.
  802. 2012-09-26 Zan Dobersek <zandobersek@gmail.com>
  803. [GTK] Enable some of the unstable CSS features
  804. https://bugs.webkit.org/show_bug.cgi?id=97572
  805. Reviewed by Martin Robinson.
  806. Enable the <style scoped> support via DumpRenderTreeSupportGtk method
  807. whenever resetting defualts to consistent values.
  808. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  809. (resetDefaultsToConsistentValues):
  810. 2012-09-26 Zan Dobersek <zandobersek@gmail.com>
  811. REGRESSION (r126189): No more mismatch-did-not-occur failures in reftests
  812. https://bugs.webkit.org/show_bug.cgi?id=97112
  813. Reviewed by Dirk Pranke.
  814. Don't use the reftest's image hash when gathering output of its reference.
  815. This indirectly forces the driver to return the reference's image output
  816. as well. This specifically solves the problem when the reftest and its
  817. mismatch reference are equal but the unexpected match failure is not
  818. reported due to missing image output of the reference file.
  819. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  820. (SingleTestRunner._run_reftest):
  821. * Scripts/webkitpy/layout_tests/port/test.py:
  822. (TestPort.diff_image):
  823. (TestDriver.run_test):
  824. 2012-09-25 Ryosuke Niwa <rniwa@webkit.org>
  825. Update master.cfg to invoke run-perf-tests with --no-show-results and --reset-results
  826. https://bugs.webkit.org/show_bug.cgi?id=97613
  827. Reviewed by Dirk Pranke.
  828. Use options added in r129580.
  829. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  830. (RunAndUploadPerfTests):
  831. 2012-09-25 Peter Rybin <peter.rybin@gmail.com>
  832. Web Inspector: Fix logging in pure protocol test harness
  833. https://bugs.webkit.org/show_bug.cgi?id=97579
  834. Reviewed by Yury Semikhatsky.
  835. JavaScript alert implementation in DumpRenderTree gets immediate flush to make sure that
  836. the message survives crash or kill by timeout.
  837. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  838. (BlackBerry::WebKit::DumpRenderTree::runJavaScriptAlert):
  839. * DumpRenderTree/chromium/WebViewHost.cpp:
  840. (WebViewHost::runModalAlertDialog):
  841. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  842. (onJavaScriptAlert):
  843. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  844. (webViewScriptAlert):
  845. * DumpRenderTree/mac/UIDelegate.mm:
  846. (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
  847. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  848. (WebCore::WebPage::javaScriptAlert):
  849. * DumpRenderTree/win/UIDelegate.cpp:
  850. (UIDelegate::runJavaScriptAlertPanelWithMessage):
  851. 2012-09-25 Dan Bernstein <mitz@apple.com>
  852. Tools part of <rdar://problem/11455228> [mac] Stop using screen fonts
  853. https://bugs.webkit.org/show_bug.cgi?id=97620
  854. Reviewed by John Sullivan.
  855. * DumpRenderTree/mac/DumpRenderTree.mm:
  856. (resetDefaultsToConsistentValues): Enable screen font substitution when
  857. running the tests.
  858. * WebKitTestRunner/TestController.cpp:
  859. (WTR::TestController::resetStateToConsistentValues): Ditto.
  860. 2012-09-25 Ryosuke Niwa <rniwa@webkit.org>
  861. Build fix. "values" doesn't necessarily contain multiple values but it needs to be always parsed as an array.
  862. * Scripts/webkitpy/performance_tests/perftest.py:
  863. (PerfTest.parse_output):
  864. 2012-09-25 Ryosuke Niwa <rniwa@webkit.org>
  865. run-perf-tests: cleanup options and results generation code
  866. https://bugs.webkit.org/show_bug.cgi?id=97611
  867. Reviewed by Dirk Pranke.
  868. Previously, --test-results-server triggered old JSOn format where the outermost structure was a dictionary
  869. instead of an array, and also implicitly triggered --no-show-results, caused the old outputs not to merge,
  870. and prevented the generation of results page. Also, it was not obvious that --source-json-path is an option
  871. used only on buildbot slaves.
  872. This patch will:
  873. - Remove the old format since perf-o-matic supports new format now.
  874. - Add --reset-results option so that we can explicitly clear existing outputs.
  875. - Add --slave-config-json-path option to replace --source-json-path option.
  876. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  877. (PerfTestsRunner._parse_args): Added --reset-results and --slave-config-json-path options.
  878. (PerfTestsRunner._generate_and_show_results): Refactored. Also removed the code to strip "values" from
  879. results since perf-o-matic can parse and store these values now.
  880. (PerfTestsRunner._merge_outputs_if_needed): Renamed from _merge_outputs_if_needed.
  881. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  882. (test_run_with_json_output): Test a harmless behavioral change to generate resuls page even when
  883. --test-results-server is present.
  884. (test_run_with_description):
  885. (test_run_generates_json_by_default):
  886. (test_run_merges_output_by_default): Added.
  887. (test_run_respects_reset_results): Added.
  888. (test_run_with_slave_config_json):
  889. (test_run_with_bad_slave_config_json): Use --slave-config-json-path instead of --source-json-path to make
  890. sure this optioon works as well.
  891. (test_run_with_multiple_repositories):
  892. (test_run_with_upload_json):
  893. 2012-09-25 Simon Fraser <simon.fraser@apple.com>
  894. Fix SnowLeopard build by adding #ifdefs.
  895. Fix crashes on some tests where the CFURLRef appears to be null.
  896. * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
  897. (WTR::testPathFromURL):
  898. (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
  899. 2012-09-25 Simon Fraser <simon.fraser@apple.com>
  900. Speculative build fix for Production builds.
  901. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  902. * WebKitTestRunner/Configurations/Base.xcconfig:
  903. 2012-09-25 Simon Fraser <simon.fraser@apple.com>
  904. Fix the build after r129566.
  905. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  906. 2012-09-25 Dominic Mazzoni <dmazzoni@google.com>
  907. AX: AccessibilityUIElementChromium.cpp won't build on Windows without wtf/StringExtras.h
  908. https://bugs.webkit.org/show_bug.cgi?id=97614
  909. Unreviewed, fixing windows breakage.
  910. Added wtf/StringExtras.h to the includes to fix the Chromium/Windows build.
  911. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  912. 2012-09-24 Simon Fraser <simon.fraser@apple.com>
  913. <rdar://problem/12351906> Have DumpRenderTree and WebKitTestRunner crash logs show which test crashed
  914. Reviewed by Mark Rowe.
  915. Use a new WebKitSytemInterface function to add data to crash logs about which
  916. test was running when the crash happened.
  917. * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Make sure WEBKIT_SYSTEM_INTERFACE_LIBRARY is defined.
  918. * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: link with the WebKitSystemInterface library.
  919. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  920. (testPathFromURL): Given a (probably) file URL, return the part after "/LayoutTests/"
  921. (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Tell Crash Reporter which test was running,
  922. if we're the main frame and the test is active.
  923. * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Make sure WEBKIT_SYSTEM_INTERFACE_LIBRARY is defined.
  924. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: link the injected bundle with the WebKitSystemInterface library.
  925. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  926. (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Call platformDidStartProvisionalLoadForFrame().
  927. (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Stub for non-Mac platforms.
  928. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  929. Add a platformDidStartProvisionalLoadForFrame() for platform-specific work.
  930. * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm: Added.
  931. (WTR::testPathFromURL): Given a (probably) file URL, return the part after "/LayoutTests/"
  932. (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Tell Crash Reporter which test was running,
  933. if we're the main frame.
  934. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add InjectedBundlePageMac.mm.
  935. 2012-09-25 Julie Parent <jparent@chromium.org>
  936. Make test_shell_tests show up in flakiness dashboard.
  937. https://bugs.webkit.org/show_bug.cgi?id=97585
  938. Reviewed by Dirk Pranke.
  939. test_shell_tests run only on chromium.org, and on the same bots as
  940. the layout tests, so do not use the generic fallbacks.
  941. * TestResultServer/static-dashboards/builders.js:
  942. (loadBuildersList):
  943. * TestResultServer/static-dashboards/dashboard_base.js:
  944. (currentBuilderGroupCategory):
  945. 2012-09-25 Lucas Forschler <lforschler@apple.com>
  946. Python tests fail on Windows bots when running with more than one child process. Temporarily use only one child process until the problem can be fixed.
  947. https://bugs.webkit.org/show_bug.cgi?id=97465
  948. Reviewed by Tim Horton.
  949. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  950. (RunPythonTests.start):
  951. 2012-09-25 Mike West <mkwst@chromium.org>
  952. Unreviewed. Adding myself as a committer.
  953. Yay. :)
  954. * Scripts/webkitpy/common/config/committers.py:
  955. 2012-09-25 Beth Dakin <bdakin@apple.com>
  956. https://bugs.webkit.org/show_bug.cgi?id=95397
  957. Need to merge didFirstVisuallyNonEmptyLayout and
  958. didNewFirstVisuallyNonEmptyLayout
  959. -and corresponding-
  960. <rdar://problem/10791680>
  961. Reviewed by Sam Weinig.
  962. Account for the new member of the PageLoadClient.
  963. * MiniBrowser/mac/BrowserWindowController.m:
  964. (-[BrowserWindowController awakeFromNib]):
  965. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  966. (WTR::InjectedBundlePage::InjectedBundlePage):
  967. * WebKitTestRunner/TestController.cpp:
  968. (WTR::TestController::initialize):
  969. The NewFirstVisuallyNonEmptyLayoutForImages has existed for a while,
  970. but it did not have the right target membership.
  971. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  972. Use new didLayout API instead of old
  973. didNewFirstVisuallyNonEmptyLayout API.
  974. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
  975. (TestWebKitAPI):
  976. (TestWebKitAPI::didLayout):
  977. (TestWebKitAPI::setPageLoaderClient):
  978. (TestWebKitAPI::TEST):
  979. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
  980. (TestWebKitAPI):
  981. (TestWebKitAPI::didLayout):
  982. (TestWebKitAPI::setPageLoaderClient):
  983. (TestWebKitAPI::TEST):
  984. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
  985. (TestWebKitAPI):
  986. (TestWebKitAPI::didLayout):
  987. (TestWebKitAPI::setPageLoaderClient):
  988. (TestWebKitAPI::TEST):
  989. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
  990. (TestWebKitAPI):
  991. (TestWebKitAPI::didLayout):
  992. (TestWebKitAPI::setPageLoaderClient):
  993. (TestWebKitAPI::TEST):
  994. 2012-09-25 Benjamin Poulain <bpoulain@apple.com>
  995. Add missing support for Geolocation tests on WebKit2
  996. https://bugs.webkit.org/show_bug.cgi?id=97518
  997. Reviewed by Sam Weinig.
  998. There are two main features added to the tooling to make the test run:
  999. -Add support for error reporting for position errors through setMockGeolocationPositionUnavailableError.
  1000. -Support the 3 states permission: undefined-allowed-denied.
  1001. * WebKitTestRunner/GeolocationProviderMock.cpp:
  1002. (WTR::GeolocationProviderMock::GeolocationProviderMock):
  1003. (WTR::GeolocationProviderMock::setPosition):
  1004. (WTR::GeolocationProviderMock::setPositionUnavailableError):
  1005. (WTR::GeolocationProviderMock::startUpdating):
  1006. (WTR::GeolocationProviderMock::sendPositionIfNeeded):
  1007. (WTR::GeolocationProviderMock::sendErrorIfNeeded):
  1008. * WebKitTestRunner/GeolocationProviderMock.h:
  1009. (GeolocationProviderMock):
  1010. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  1011. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  1012. (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
  1013. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  1014. (InjectedBundle):
  1015. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  1016. (WTR::TestRunner::setMockGeolocationPositionUnavailableError):
  1017. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  1018. (TestRunner):
  1019. * WebKitTestRunner/TestController.cpp:
  1020. (WTR::TestController::TestController):
  1021. (WTR::decidePolicyForGeolocationPermissionRequest):
  1022. (WTR::TestController::resetStateToConsistentValues):
  1023. (WTR::TestController::setGeolocationPermission):
  1024. (WTR::TestController::setMockGeolocationPosition):
  1025. (WTR::TestController::setMockGeolocationPositionUnavailableError):
  1026. (WTR::TestController::handleGeolocationPermissionRequest):
  1027. (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
  1028. * WebKitTestRunner/TestController.h:
  1029. (TestController):
  1030. * WebKitTestRunner/TestInvocation.cpp:
  1031. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  1032. 2012-09-25 Sheriff Bot <webkit.review.bot@gmail.com>
  1033. Unreviewed, rolling out r129517.
  1034. http://trac.webkit.org/changeset/129517
  1035. https://bugs.webkit.org/show_bug.cgi?id=97582
  1036. Link errors in chromium (Requested by alecf on #webkit).
  1037. * DumpRenderTree/DumpRenderTree.gypi:
  1038. * DumpRenderTree/chromium/MockConstraints.cpp: Removed.
  1039. * DumpRenderTree/chromium/MockConstraints.h: Removed.
  1040. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  1041. (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
  1042. (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
  1043. (RTCVoidRequestTask::RTCVoidRequestTask):
  1044. (isSupportedConstraint):
  1045. (isValidConstraint):
  1046. (MockWebRTCPeerConnectionHandler::initialize):
  1047. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  1048. (WebKit::WebUserMediaClientMock::requestUserMedia):
  1049. * DumpRenderTree/chromium/WebUserMediaClientMock.h:
  1050. (WebKit):
  1051. (WebUserMediaClientMock):
  1052. * DumpRenderTree/chromium/WebViewHost.h:
  1053. (WebKit):
  1054. (WebViewHost):
  1055. 2012-09-25 Dominic Mazzoni <dmazzoni@google.com>
  1056. AX: Chromium doesn't pass accessibility text range and line number tests
  1057. https://bugs.webkit.org/show_bug.cgi?id=97246
  1058. Reviewed by Chris Fleizach.
  1059. Provide a chromium implementation of some AccessibilityUIElement
  1060. methods needed by accessibility tests.
  1061. Enables four existing tests to pass on Chromium:
  1062. Tests: accessibility/textarea-insertion-point-line-number.html
  1063. accessibility/textarea-line-for-index.html
  1064. accessibility/textarea-selected-text-range.html
  1065. accessibility/textbox-role-reports-selection.html
  1066. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  1067. (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
  1068. (AccessibilityUIElement::selectedTextRangeGetterCallback):
  1069. (AccessibilityUIElement::lineForIndexCallback):
  1070. (AccessibilityUIElement::setSelectedTextRangeCallback):
  1071. 2012-09-25 Peter Beverloo <peter@chromium.org>
  1072. [Chromium] Android's build archives have grown from 38M to 102M in 11 days
  1073. https://bugs.webkit.org/show_bug.cgi?id=97336
  1074. Reviewed by Adam Barth.
  1075. Each WebKit target results in four APKs in the out/{Debug,Release}/ directory,
  1076. while we really only need one. Ignoring the unsigned APKs removes six from
  1077. the archive will make sure that we only archive a single APK per target,
  1078. bringing its size back to rougly 40 megabytes.
  1079. * BuildSlaveSupport/built-product-archive:
  1080. (archiveBuiltProduct):
  1081. 2012-09-25 Tommy Widenflycht <tommyw@google.com>
  1082. MediaStream API: Update getUserMedia to match the latest specification
  1083. https://bugs.webkit.org/show_bug.cgi?id=97540
  1084. Reviewed by Adam Barth.
  1085. Adding mock support for the enhanced getUserMedia call.
  1086. * DumpRenderTree/DumpRenderTree.gypi:
  1087. * DumpRenderTree/chromium/MockConstraints.cpp: Copied from Source/WebCore/platform/chromium/support/WebMediaConstraints.cpp.
  1088. (MockConstraints):
  1089. (MockConstraints::isSupported):
  1090. (MockConstraints::isValid):
  1091. (MockConstraints::verify):
  1092. * DumpRenderTree/chromium/MockConstraints.h: Copied from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.
  1093. (WebKit):
  1094. (MockConstraints):
  1095. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  1096. (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
  1097. (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
  1098. (RTCVoidRequestTask::RTCVoidRequestTask):
  1099. (MockWebRTCPeerConnectionHandler::initialize):
  1100. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  1101. (UserMediaRequestTask):
  1102. (UserMediaRequestTask::UserMediaRequestTask):
  1103. (WebUserMediaClientMock::requestUserMedia):
  1104. * DumpRenderTree/chromium/WebUserMediaClientMock.h:
  1105. (WebUserMediaClientMock):
  1106. (WebUserMediaClientMock::taskList):
  1107. * DumpRenderTree/chromium/WebViewHost.h:
  1108. (WebKit):
  1109. (WebViewHost):
  1110. 2012-09-25 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  1111. [EFL] Do not dump inspector output in DRT
  1112. https://bugs.webkit.org/show_bug.cgi?id=97018
  1113. Reviewed by Kenneth Rohde Christiansen.
  1114. Some inspector-related layout tests expect console output from the
  1115. inspector view to be suppressed. Do that by setting a property in
  1116. the inspector view that makes the onConsoleMessage callback return
  1117. early and not output anything.
  1118. Using evas_object_data_{get,set} is not very beautiful, but it is
  1119. still better than properly subclassing Ewk_View and having to
  1120. implement something similar to drt_view_console_message_enable_set().
  1121. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  1122. (DumpRenderTreeChrome::createWebInspectorView):
  1123. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  1124. (onConsoleMessage):
  1125. 2012-09-25 Christophe Dumez <christophe.dumez@intel.com>
  1126. [WK2][WKTR] TestRunner needs support for setWillSendRequestReturnsNullOnRedirect
  1127. https://bugs.webkit.org/show_bug.cgi?id=97542
  1128. Reviewed by Kenneth Rohde Christiansen.
  1129. Implement support for setWillSendRequestReturnsNullOnRedirect
  1130. in WebKitTestRunner.
  1131. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  1132. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  1133. (WTR::InjectedBundlePage::willSendRequestForFrame):
  1134. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  1135. (WTR::TestRunner::TestRunner):
  1136. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  1137. (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
  1138. (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
  1139. (TestRunner):
  1140. 2012-09-25 Xiaobo Wang <xbwang@torchmobile.com.cn>
  1141. [BlackBerry] [DRT] fast/forms/textarea-live-pseudo-selectors.html failed
  1142. https://bugs.webkit.org/show_bug.cgi?id=97189
  1143. Reviewed by Rob Buis.
  1144. Translate ASCII key code to BlackBerry key code for BACKSPACE and DELETE key.
  1145. * DumpRenderTree/blackberry/EventSender.cpp:
  1146. (keyDownCallback):
  1147. 2012-09-25 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  1148. [WK2][WTR] WTR bundle client loads binary data as text
  1149. https://bugs.webkit.org/show_bug.cgi?id=97532
  1150. Reviewed by Kenneth Rohde Christiansen.
  1151. WTR::InjectedBundlePage::decidePolicyForResponse now checks response MIME type
  1152. and returns WKBundlePagePolicyActionPassThrough if it cannot be shown.
  1153. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  1154. (WTR::InjectedBundlePage::decidePolicyForResponse):
  1155. 2012-09-25 Zan Dobersek <zandobersek@gmail.com>
  1156. Unreviewed, another test case adjustment after r129459. Python 2.7 doesn't
  1157. seem to be a requirement yet so the assertDictEqual method is not yet available
  1158. on all builders. Assert that the empty dictionary length equals 0 instead.
  1159. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  1160. (ResultSummaryTest.test_interpret_test_failures):
  1161. 2012-09-24 Simon Hausmann <simon.hausmann@digia.com>
  1162. [Qt] Fix build with latest Qt 5
  1163. https://bugs.webkit.org/show_bug.cgi?id=97479
  1164. Reviewed by Tor Arne Vestbø.
  1165. The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
  1166. remove them from default_pre.prf once we're past Qt 5 beta2.
  1167. * qmake/mkspecs/features/default_pre.prf:
  1168. 2012-09-25 Zan Dobersek <zandobersek@gmail.com>
  1169. Unreviewed, adjusting the test cases after r129459. The JSON data
  1170. for reftests now contains the 'reftest_type' key and no more 'is_reftest'
  1171. or 'is_mismatch_reftest' keys.
  1172. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  1173. (EndToEndTest.test_reftest_with_two_notrefs):
  1174. 2012-09-24 Zan Dobersek <zandobersek@gmail.com>
  1175. Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well
  1176. https://bugs.webkit.org/show_bug.cgi?id=97426
  1177. Reviewed by Ojan Vafai.
  1178. The 'is_reftest' member of the TestResult class has been replaced by the reftest_type
  1179. member which is a set containing either '!=', '==', both or none if the test represented
  1180. by the object is not a reftest.
  1181. When summarizing results, the test dictionary is updated to contain the 'reftest_type' key
  1182. if the test is a reftest. The value of this key is a list of all the reftest types of this test.
  1183. The test failure interpretation method has been refactored, it now reports only
  1184. missing results of various formats and image diff percent in case of image or
  1185. reftest mismatch.
  1186. Unit tests have been modified accordingly.
  1187. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  1188. (LayoutTestRunner._update_summary_with_result):
  1189. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
  1190. (LayoutTestRunnerTests.test_update_summary_with_result):
  1191. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  1192. (interpret_test_failures):
  1193. (summarize_results):
  1194. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  1195. (ResultSummaryTest.test_interpret_test_failures):
  1196. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  1197. (SingleTestRunner.run):
  1198. (SingleTestRunner._run_reftest):
  1199. * Scripts/webkitpy/layout_tests/models/test_results.py:
  1200. (TestResult.__init__):
  1201. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  1202. (EndToEndTest.test_reftest_with_two_notrefs):
  1203. 2012-09-24 Sam Weinig <sam@webkit.org>
  1204. Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
  1205. https://bugs.webkit.org/show_bug.cgi?id=97514
  1206. Reviewed by Anders Carlsson.
  1207. * Scripts/webkitdirs.pm:
  1208. (argumentsForRunAndDebugMacWebKitApp):
  1209. Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
  1210. is provided to set the user default. Move adding of @ARGV to after custom additions as calling
  1211. shouldUseXPCServiceForWebProcess() can change @ARGV.
  1212. (runMacWebKitApp):
  1213. (execMacWebKitAppForDebugging):
  1214. Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.
  1215. 2012-09-24 Laszlo Gombos <l.gombos@samsung.com>
  1216. [GTK][EFL] Make sure cairo is built with fontconfig support
  1217. https://bugs.webkit.org/show_bug.cgi?id=97513
  1218. Reviewed by Martin Robinson.
  1219. The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support.
  1220. * efl/jhbuild.modules:
  1221. * gtk/jhbuild.modules:
  1222. 2012-09-24 Benjamin Poulain <bpoulain@apple.com>
  1223. Fix Geolocation error reporting in the test support
  1224. https://bugs.webkit.org/show_bug.cgi?id=97386
  1225. Reviewed by Sam Weinig.
  1226. The TestRunner was exposing internal implementation details of
  1227. the Geolocation object through setMockGeolocationError().
  1228. In practice, only the error code PositionUnavailable is supported
  1229. or even implemented.
  1230. Exposing setMockGeolocationError() does not make sense for WebKit2 as
  1231. passing generic errors from the UIProcess is a bad idea. This is the
  1232. opportunity to clean TestRunner and prepare and interface suitable for WebKit2.
  1233. * DumpRenderTree/TestRunner.cpp:
  1234. (setMockGeolocationPositionUnavailableErrorCallback):
  1235. (TestRunner::staticFunctions):
  1236. * DumpRenderTree/TestRunner.h:
  1237. (TestRunner):
  1238. * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  1239. (TestRunner::setMockGeolocationPositionUnavailableError):
  1240. * DumpRenderTree/chromium/DRTTestRunner.cpp:
  1241. (DRTTestRunner::DRTTestRunner):
  1242. (DRTTestRunner::setMockGeolocationPositionUnavailableError):
  1243. * DumpRenderTree/chromium/DRTTestRunner.h:
  1244. (DRTTestRunner):
  1245. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  1246. (TestRunner::setMockGeolocationPositionUnavailableError):
  1247. * DumpRenderTree/gtk/TestRunnerGtk.cpp:
  1248. (TestRunner::setMockGeolocationPositionUnavailableError):
  1249. * DumpRenderTree/mac/MockGeolocationProvider.h:
  1250. * DumpRenderTree/mac/MockGeolocationProvider.mm:
  1251. (-[MockGeolocationProvider dealloc]):
  1252. (-[MockGeolocationProvider resetError]):
  1253. (-[MockGeolocationProvider setPosition:]):
  1254. (-[MockGeolocationProvider setPositionUnavailableErrorWithMessage:]):
  1255. (-[MockGeolocationProvider lastPosition]):
  1256. (-[MockGeolocationProvider timerFired]):
  1257. * DumpRenderTree/mac/TestRunnerMac.mm:
  1258. (TestRunner::setMockGeolocationPositionUnavailableError):
  1259. * DumpRenderTree/qt/TestRunnerQt.cpp:
  1260. (TestRunner::setMockGeolocationPositionUnavailableError):
  1261. * DumpRenderTree/qt/TestRunnerQt.h:
  1262. (TestRunner):
  1263. * DumpRenderTree/win/TestRunnerWin.cpp:
  1264. (TestRunner::setMockGeolocationPositionUnavailableError):
  1265. * DumpRenderTree/wx/TestRunnerWx.cpp:
  1266. (TestRunner::setMockGeolocationPositionUnavailableError):
  1267. 2012-09-24 Nikhil Bansal <n.bansal@samsung.com>
  1268. [EFL][WK2] TestRunner needs touch events support.
  1269. https://bugs.webkit.org/show_bug.cgi?id=96465
  1270. Reviewed by Kenneth Rohde Christiansen.
  1271. Simulate touch events in WebkitTestRunner for touch related
  1272. layout tests. This patch uses ewk_view_feed_touch_event() to
  1273. generate touch events.
  1274. * WebKitTestRunner/EventSenderProxy.h:
  1275. (EventSenderProxy):
  1276. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
  1277. (WTR):
  1278. (WTR::setEvasModifiers):
  1279. (WTR::EventSenderProxy::EventSenderProxy):
  1280. (WTR::EventSenderProxy::~EventSenderProxy):
  1281. (WTR::EventSenderProxy::sendTouchEvent):
  1282. (WTR::EventSenderProxy::addTouchPoint):
  1283. (WTR::EventSenderProxy::updateTouchPoint):
  1284. (WTR::EventSenderProxy::setTouchModifier):
  1285. (WTR::EventSenderProxy::touchStart):
  1286. (WTR::EventSenderProxy::touchMove):
  1287. (WTR::EventSenderProxy::touchEnd):
  1288. (WTR::EventSenderProxy::touchCancel):
  1289. (WTR::EventSenderProxy::clearTouchPoints):
  1290. (WTR::EventSenderProxy::releaseTouchPoint):
  1291. (WTR::EventSenderProxy::cancelTouchPoint):
  1292. 2012-09-24 Christophe Dumez <christophe.dumez@intel.com>
  1293. [WK2] TestRunner does not support overridePreference with value "0"
  1294. https://bugs.webkit.org/show_bug.cgi?id=97457
  1295. Reviewed by Alexey Proskuryakov.
  1296. testRunner.overridePreference() was marked as taking a boolean
  1297. in argument in testRunner.idl even though the test cases are
  1298. passing strings to it. The current code works if the test
  1299. case wants to enable a setting and therefore passes "1" string.
  1300. However, if the test wants to disable a setting and passes "0"
  1301. string, the current code also evaluates this to true causing
  1302. certain test cases to fail.
  1303. The argument to testRunner.overridePreference() is now of string
  1304. type and a function has been added to convert the string passed
  1305. by the test to a boolean value.
  1306. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  1307. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  1308. (WTR::toBool):
  1309. (WTR):
  1310. (WTR::TestRunner::overridePreference):
  1311. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  1312. (TestRunner):
  1313. 2012-09-24 Sheriff Bot <webkit.review.bot@gmail.com>
  1314. Unreviewed, rolling out r129343.
  1315. http://trac.webkit.org/changeset/129343
  1316. https://bugs.webkit.org/show_bug.cgi?id=97479
  1317. It broke the build (Requested by Ossy_NIGHT on #webkit).
  1318. * qmake/mkspecs/features/default_pre.prf:
  1319. 2012-09-24 Zan Dobersek <zandobersek@gmail.com>
  1320. [Gtk] Unskip the Shadow DOM layout tests
  1321. https://bugs.webkit.org/show_bug.cgi?id=90776
  1322. Reviewed by Ryosuke Niwa.
  1323. Enable Shadow DOM through DumpRenderTreeSupport when resetting defaults in between tests.
  1324. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  1325. (resetDefaultsToConsistentValues):
  1326. 2012-09-24 Zan Dobersek <zandobersek@gmail.com>
  1327. REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
  1328. https://bugs.webkit.org/show_bug.cgi?id=97404
  1329. Reviewed by Philippe Normand.
  1330. Print out the 'didReceiveTitle' information when dumping frame load callbacks.
  1331. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  1332. (webViewTitleChanged):
  1333. 2012-09-24 Simon Hausmann <simon.hausmann@digia.com>
  1334. [Qt] Fix build with latest Qt 5
  1335. Reviewed by Tor Arne Vestbø.
  1336. The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
  1337. remove them from default_pre.prf once we're past Qt 5 beta2.
  1338. * qmake/mkspecs/features/default_pre.prf:
  1339. 2012-09-22 Dominic Mazzoni <dmazzoni@google.com>
  1340. AX: Layout tests would be easier to write if AccessibilityController could find an element by id
  1341. https://bugs.webkit.org/show_bug.cgi?id=97301
  1342. Reviewed by Chris Fleizach.
  1343. Adds a new accessibleElementById method to AccessibilityController, to make it
  1344. easier to write cross-platform layout tests.
  1345. Implemented for Chromium and for Mac (DRT and WKTR).
  1346. * DumpRenderTree/AccessibilityController.cpp:
  1347. (getAccessibleElementByIdCallback):
  1348. (AccessibilityController::getJSClass):
  1349. * DumpRenderTree/AccessibilityController.h:
  1350. (AccessibilityController):
  1351. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  1352. * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
  1353. (AccessibilityController::AccessibilityController):
  1354. (AccessibilityController::findAccessibleElementByIdRecursive):
  1355. (AccessibilityController::getAccessibleElementById):
  1356. (AccessibilityController::accessibleElementByIdGetterCallback):
  1357. * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h:
  1358. (AccessibilityController):
  1359. * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
  1360. (AccessibilityController::accessibleElementById):
  1361. * DumpRenderTree/mac/AccessibilityCommonMac.h: added
  1362. * DumpRenderTree/mac/AccessibilityCommonMac.mm: added
  1363. (+[NSString stringWithJSStringRef:]):
  1364. (-[NSString createJSStringRef]):
  1365. * DumpRenderTree/mac/AccessibilityControllerMac.mm:
  1366. (findAccessibleObjectById):
  1367. (AccessibilityController::accessibleElementById):
  1368. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  1369. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  1370. (AccessibilityController::accessibleElementById):
  1371. * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
  1372. (WTR::AccessibilityController::accessibleElementById):
  1373. * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
  1374. (AccessibilityController):
  1375. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
  1376. * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: added
  1377. * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: added
  1378. (+[NSString stringWithJSStringRef:]):
  1379. (-[NSString createJSStringRef]):
  1380. * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
  1381. (WTR::findAccessibleObjectById):
  1382. (WTR):
  1383. (WTR::AccessibilityController::accessibleElementById):
  1384. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  1385. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  1386. 2012-09-22 Zan Dobersek <zandobersek@gmail.com>
  1387. Unexpected reftest passes are only reported when pixel testing is enabled
  1388. https://bugs.webkit.org/show_bug.cgi?id=97242
  1389. Reviewed by Dirk Pranke.
  1390. LayoutTestRunner should know whether the finished test it's handling is
  1391. a reftest. This is necessary when updating result summary for reftests
  1392. when pixel testing is not enabled - in these circumstances an unexpectedly
  1393. passing reftest was not reported as such due to pixel testing then being
  1394. determined by searching for reftest failures in failures list, which were
  1395. not found in an empty failure list of a passing test. Now the TestResult
  1396. objects have a member variable indicating the test is a reftest whenever
  1397. that's the case.
  1398. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  1399. (LayoutTestRunner._update_summary_with_result):
  1400. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
  1401. (LayoutTestRunnerTests.test_update_summary_with_result):
  1402. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  1403. (SingleTestRunner.run):
  1404. (SingleTestRunner._run_reftest):
  1405. * Scripts/webkitpy/layout_tests/models/test_results.py:
  1406. (TestResult.__init__):
  1407. 2012-09-21 Sam Weinig <sam@webkit.org>
  1408. WebProcess XPC services need have their environment set without disrupting all other XPC services
  1409. https://bugs.webkit.org/show_bug.cgi?id=95161
  1410. Reviewed by Anders Carlsson.
  1411. Remove setting the __XPC_* environment variables.
  1412. * Scripts/webkitdirs.pm:
  1413. (setUpGuardMallocIfNeeded):
  1414. (runMacWebKitApp):
  1415. (execMacWebKitAppForDebugging):
  1416. 2012-09-21 Dirk Pranke <dpranke@chromium.org>
  1417. Fix typo in additional-platform-directory patch just landed
  1418. https://bugs.webkit.org/show_bug.cgi?id=97380
  1419. Unreviewed, build fix.
  1420. * Scripts/webkitpy/layout_tests/port/base.py:
  1421. (Port.relative_test_filename):
  1422. (Port.relative_perf_test_filename):
  1423. 2012-09-21 Dirk Pranke <dpranke@chromium.org>
  1424. nrwt: don't require additional-platform-directory to be an abspath or live under LayoutTests
  1425. https://bugs.webkit.org/show_bug.cgi?id=97380
  1426. Reviewed by Ojan Vafai.
  1427. There doesn't seem to be a good reason for this restriction and
  1428. it's useful to be able to point to directories outside the
  1429. checkout for results (e.g., for local failures due to a 10.7.4
  1430. install ;).
  1431. * Scripts/webkitpy/layout_tests/port/base.py:
  1432. (Port.relative_test_filename):
  1433. (Port.relative_perf_test_filename):
  1434. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  1435. (ChromiumAndroidDriver._command_from_driver_input):
  1436. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  1437. (_set_up_derived_options):
  1438. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  1439. (MainTest.test_additional_platform_directory):
  1440. 2012-09-21 Dirk Pranke <dpranke@chromium.org>
  1441. webkitpy: drop support for old TestExpectations syntax
  1442. https://bugs.webkit.org/show_bug.cgi?id=97364
  1443. Reviewed by Ryosuke Niwa.
  1444. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  1445. (TestExpectationParser._collect_matching_tests):
  1446. (TestExpectationParser):
  1447. (TestExpectationParser._tokenize_line):
  1448. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  1449. (SkippedTests.test_skipped_entry_dont_exist):
  1450. (ExpectationSyntaxTests.assert_tokenize_exp):
  1451. (ExpectationSyntaxTests.test_bare_name):
  1452. (ExpectationSyntaxTests.test_bare_name_and_bugs):
  1453. (ExpectationSyntaxTests.test_comments):
  1454. (ExpectationSyntaxTests.test_config_modifiers):
  1455. (ExpectationSyntaxTests.test_unknown_config):
  1456. (ExpectationSyntaxTests.test_unknown_expectation):
  1457. (ExpectationSyntaxTests.test_skip):
  1458. (ExpectationSyntaxTests.test_slow):
  1459. (ExpectationSyntaxTests.test_wontfix):
  1460. (ExpectationSyntaxTests.test_blank_line):
  1461. (ExpectationSyntaxTests.test_warnings):
  1462. (RebaseliningTest.test_no_get_rebaselining_failures):
  1463. 2012-09-21 Simon Fraser <simon.fraser@apple.com>
  1464. Improve WTR unresponsiveness output a little
  1465. https://bugs.webkit.org/show_bug.cgi?id=97370
  1466. Reviewed by Timothy Horton.
  1467. Distinguish between conditions that already set the errorMessage,
  1468. and unresponsiveness due to slow about:blank loads when WTR
  1469. reports unresponsiveness.
  1470. * WebKitTestRunner/TestInvocation.cpp:
  1471. (WTR::TestInvocation::invoke):
  1472. 2012-09-21 Chris Rogers <crogers@google.com>
  1473. Add Web Audio support for deprecated/legacy APIs
  1474. https://bugs.webkit.org/show_bug.cgi?id=97050
  1475. Reviewed by Eric Carlson.
  1476. * Scripts/webkitperl/FeatureList.pm:
  1477. 2012-09-21 Dirk Pranke <dpranke@chromium.org>
  1478. webkitpy: update remaining tests to use the new expectation syntax
  1479. https://bugs.webkit.org/show_bug.cgi?id=97362
  1480. Reviewed by Ojan Vafai.
  1481. This patch updates all the unit tests that were still using the
  1482. old TestExpectations syntax to use the new syntax *except* for
  1483. the tests that were specifically testing that we parsed the old
  1484. syntax correctly.
  1485. Also, a block of tests for the new syntax were duplicated, so
  1486. I've deleted the duplicate.
  1487. Note that the old syntax is still supported so this change should
  1488. produce no visible changes.
  1489. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  1490. (MiscTests.test_multiple_results):
  1491. (MiscTests.test_category_expectations):
  1492. (MiscTests.test_error_on_different_platform):
  1493. (MiscTests.test_error_on_different_build_type):
  1494. (MiscTests.test_overrides):
  1495. (MiscTests.test_overrides__directory):
  1496. (MiscTests.test_overrides__duplicate):
  1497. (MiscTests.test_more_specific_override_resets_skip):
  1498. (SkippedTests.check):
  1499. (SkippedTests.test_duplicate_skipped_test_fails_lint):
  1500. (SkippedTests.test_skipped_file_overrides_expectations):
  1501. (SkippedTests.test_skipped_dir_overrides_expectations):
  1502. (SkippedTests.test_skipped_file_overrides_overrides):
  1503. (SkippedTests.test_skipped_dir_overrides_overrides):
  1504. (ExpectationSyntaxTests.disabled_test_missing_expectation):
  1505. (ExpectationSyntaxTests.disabled_test_missing_colon):
  1506. (ExpectationSyntaxTests.disabled_test_too_many_colons):
  1507. (ExpectationSyntaxTests.disabled_test_too_many_equals_signs):
  1508. (ExpectationSyntaxTests):
  1509. (ExpectationSyntaxTests.test_unrecognized_expectation):
  1510. (ExpectationSyntaxTests.test_macro):
  1511. (SemanticTests.test_bug_format):
  1512. (SemanticTests.test_bad_bugid):
  1513. (SemanticTests.test_missing_bugid):
  1514. (SemanticTests.test_slow_and_timeout):
  1515. (SemanticTests.test_rebaseline):
  1516. (test_missing_file):
  1517. (test_ambiguous):
  1518. (test_more_modifiers):
  1519. (test_order_in_file):
  1520. (test_macro_overrides):
  1521. (OldExpectationParserTests):
  1522. (OldExpectationParserTests._tokenize):
  1523. (OldExpectationParserTests.test_tokenize_extra_colon):
  1524. (OldExpectationParserTests.test_tokenize_missing_equal):
  1525. (OldExpectationParserTests.test_tokenize_extra_equal):
  1526. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  1527. (MainTest.test_skip_failing_tests):
  1528. (MainTest.test_additional_expectations):
  1529. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  1530. (TestExpectationsTestCase.test_valid_expectations):
  1531. (TestExpectationsTestCase.test_invalid_expectations):
  1532. (TestExpectationsTestCase.test_tab):
  1533. 2012-09-21 Benjamin Poulain <bpoulain@apple.com>
  1534. [WK2] Add basic testing support for Geolocation
  1535. https://bugs.webkit.org/show_bug.cgi?id=97278
  1536. Reviewed by Kenneth Rohde Christiansen.
  1537. Update the Geolocation testing to use the proper API in the UIProcess.
  1538. * WebKitTestRunner/CMakeLists.txt:
  1539. * WebKitTestRunner/GNUmakefile.am:
  1540. * WebKitTestRunner/GeolocationProviderMock.cpp: Added.
  1541. (WTR::startUpdatingCallback):
  1542. (WTR::stopUpdatingCallback):
  1543. (WTR::GeolocationProviderMock::GeolocationProvierMock):
  1544. (WTR::GeolocationProviderMock::setMockGeolocationPosition):
  1545. (WTR::GeolocationProviderMock::startUpdating):
  1546. (WTR::GeolocationProviderMock::stopUpdating):
  1547. (GeolocationProviderMock):
  1548. The GeolocationProvider store the location update and deliver them as needed.
  1549. WebCore GeolocationController do not support asynchronous update on start/stop. This is not
  1550. a problem in this case because all the messages between the WebProcess and the UIProcess are
  1551. asynchronous. Because of this, unlike GeolocationClientMock, we do not use a timer for event
  1552. delivery.
  1553. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  1554. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  1555. (WTR::InjectedBundle::setGeolocationPermission):
  1556. (WTR::InjectedBundle::setMockGeolocationPosition):
  1557. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  1558. (InjectedBundle):
  1559. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  1560. (WTR::TestRunner::setGeolocationPermission):
  1561. (WTR::TestRunner::setMockGeolocationPosition):
  1562. From the InjectedBundle, we now pass the information to the UIProcess so that
  1563. GeolocationProvider and the TestController can respond appropriately.
  1564. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  1565. (TestRunner):
  1566. * WebKitTestRunner/Target.pri:
  1567. * WebKitTestRunner/TestController.cpp:
  1568. (WTR::TestController::TestController):
  1569. (WTR::decidePolicyForGeolocationPermissionRequest):
  1570. (WTR::TestController::createOtherPage):
  1571. (WTR::TestController::initialize):
  1572. (WTR::TestController::setMockGeolocationPosition):
  1573. * WebKitTestRunner/TestController.h:
  1574. (TestController):
  1575. (WTR::TestController::setGeolocationPermission):
  1576. (WTR::TestController::isGeolocationPermissionAllowed):
  1577. * WebKitTestRunner/TestInvocation.cpp:
  1578. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  1579. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  1580. * WebKitTestRunner/win/WebKitTestRunner.vcproj:
  1581. 2012-09-21 Joanmarie Diggs <jdiggs@igalia.com>
  1582. REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
  1583. https://bugs.webkit.org/show_bug.cgi?id=96196
  1584. Reviewed by Martin Robinson.
  1585. The "regression" is that a new test was added but the support was missing
  1586. in the Gtk port for spin buttons.
  1587. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  1588. (AccessibilityUIElement::valueDescription): Updated the FIXME comment to
  1589. indicate that this cannot be implemented until it is implemented in ATK.
  1590. URL of the newly-filed ATK bug included for reference.
  1591. 2012-09-21 Dirk Pranke <dpranke@chromium.org>
  1592. Fix test_skip_and_wontfix failure
  1593. https://bugs.webkit.org/show_bug.cgi?id=97225
  1594. Unreviewed, build fix.
  1595. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  1596. (SemanticTests.test_skip_and_wontfix):
  1597. 2012-09-21 Carlos Garcia Campos <cgarcia@igalia.com>
  1598. [GTK] Implement ViewState methods in PageClientImpl in WebKit2
  1599. https://bugs.webkit.org/show_bug.cgi?id=97202
  1600. Reviewed by Martin Robinson.
  1601. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
  1602. (WTR::PlatformWebView::focus): Focus the view.
  1603. 2012-09-21 Sudarsana Nagineni <sudarsana.nagineni@intel.com>
  1604. [WTR] Memory leaks in InjectedBundleController::initialize()
  1605. https://bugs.webkit.org/show_bug.cgi?id=97329
  1606. Reviewed by Alexey Proskuryakov.
  1607. Fix leaks in InjectedBundleController::initialize() by adopting
  1608. strings created with WKStringCreateWithUTF8CString().
  1609. * TestWebKitAPI/InjectedBundleController.cpp:
  1610. (TestWebKitAPI::InjectedBundleController::initialize):
  1611. 2012-09-21 Marcelo Lira <marcelo.lira@openbossa.org>
  1612. [Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
  1613. https://bugs.webkit.org/show_bug.cgi?id=97235
  1614. Reviewed by Luiz Agostini.
  1615. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  1616. (WTR::EventSenderProxy::keyDown):
  1617. 2012-09-21 Gergely Kis <gergely@homejinni.com>
  1618. Add MIPS build slave to build.webkit.org
  1619. https://bugs.webkit.org/show_bug.cgi?id=96713
  1620. Reviewed by Csaba Osztrogonác.
  1621. Added a build slave for MIPS, and enabled a builder for
  1622. Qt Linux MIPS32R2 little-endian release build.
  1623. * BuildSlaveSupport/build.webkit.org-config/config.json:
  1624. 2012-09-21 Peter Beverloo <peter@chromium.org>
  1625. [Chromium] Switch back to a fixed fifo path for Android
  1626. https://bugs.webkit.org/show_bug.cgi?id=97230
  1627. Reviewed by Tony Chang.
  1628. Because not all external storage cards will be formated using a file
  1629. system that supports named pipes, Chromium has been changed to creating
  1630. the pipes in a temporary folder on the internal storage. Adapt this in
  1631. WebKit so we can continue to run layout tests.
  1632. This also includes an *unreviewed* fix for a breakage in the webkitpy
  1633. tests I made in r129221. Two lines and related to this code, so I decided
  1634. to include it in this change.
  1635. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  1636. (ChromiumAndroidDriver.__init__):
  1637. (ChromiumAndroidDriver._setup_test):
  1638. (ChromiumAndroidDriver._update_version):
  1639. 2012-09-20 Peter Beverloo <peter@chromium.org>
  1640. Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
  1641. https://bugs.webkit.org/show_bug.cgi?id=97227
  1642. Reviewed by Tony Chang.
  1643. We switched Chromium to using FIFOs in order to achieve better consistency,
  1644. which was done by Marcus in r157541. Remove all custom WebKit code in
  1645. favor of Chromium's implementation.
  1646. Remove more FIFO code in the test runner itself, including the code in
  1647. DumpRenderTree that invoked it. We can now switch to Chromium's brand
  1648. new FIFO-creating code, which is being set-up for all test targets build
  1649. for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.
  1650. This also changes the ChromiumAndroidDriver._remove_all_pipes method to
  1651. delete the files individually. "rm" would fail if one of the earlier files
  1652. does not exist, and the "-f" argument doesn't seem to be reliable.
  1653. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  1654. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  1655. (platformInit):
  1656. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  1657. (ChromiumAndroidDriver.__init__):
  1658. (ChromiumAndroidDriver._setup_test):
  1659. (ChromiumAndroidDriver._get_external_storage):
  1660. (ChromiumAndroidDriver._drt_cmd_line):
  1661. (ChromiumAndroidDriver._remove_all_pipes):
  1662. (ChromiumAndroidDriver.stop):
  1663. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  1664. 2012-09-21 Christophe Dumez <christophe.dumez@intel.com>
  1665. [WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
  1666. https://bugs.webkit.org/show_bug.cgi?id=97326
  1667. Reviewed by Kenneth Rohde Christiansen.
  1668. Implement scheduleAsynchronousClick() in WebKitTestRunner's
  1669. EventSender by sending a "MouseDown" and a "MouseUp" message
  1670. asynchronously to the WebProcess.
  1671. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  1672. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  1673. (WTR::createMouseMessageBody):
  1674. (WTR):
  1675. (WTR::EventSendingController::mouseDown):
  1676. (WTR::EventSendingController::mouseUp):
  1677. (WTR::EventSendingController::scheduleAsynchronousClick):
  1678. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  1679. (EventSendingController):
  1680. * WebKitTestRunner/TestController.cpp:
  1681. (WTR::TestController::didReceiveMessageFromInjectedBundle):
  1682. 2012-09-21 Simon Hausmann <simon.hausmann@digia.com>
  1683. [Qt] Error out early if we don't have ICU available
  1684. Reviewed by Tor Arne Vestbø.
  1685. * qmake/mkspecs/features/configure.prf:
  1686. 2012-09-21 Simon Hausmann <simon.hausmann@digia.com>
  1687. [Qt] Bail out when trying to build WebKit with Qt != 5
  1688. Reviewed by Tor Arne Vestbø.
  1689. Moved check for Qt version out of default_pre into top-level WebKit.pro,
  1690. because we never reach default_pre.prf due to the lack of .qmake.conf support
  1691. in older versions of Qt/QMake.
  1692. * qmake/mkspecs/features/default_pre.prf:
  1693. 2012-09-21 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  1694. WebKitTestRunner needs to print frame load delegate information
  1695. https://bugs.webkit.org/show_bug.cgi?id=42705
  1696. Reviewed by Kenneth Rohde Christiansen.
  1697. Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.
  1698. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  1699. (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
  1700. 2012-09-21 Christophe Dumez <christophe.dumez@intel.com>
  1701. [EFL] EventSender should mimic CTRL+o emacs shortcut
  1702. https://bugs.webkit.org/show_bug.cgi?id=97224
  1703. Reviewed by Kenneth Rohde Christiansen.
  1704. Add support for mimicking CTRL+o emacs shortcut in EFL's
  1705. EventSender in DumpRenderTree and WebKitTestRunner.
  1706. * DumpRenderTree/efl/EventSender.cpp:
  1707. (sendKeyDown):
  1708. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
  1709. (WTR::EventSenderProxy::keyDown):
  1710. 2012-09-21 Simon Hausmann <simon.hausmann@digia.com>
  1711. [Qt] Re-fix clean builds
  1712. Reviewed by Tor Arne Vestbø.
  1713. Re-introduce the sanitization for LIBS when creating a module to use
  1714. LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
  1715. continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
  1716. throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
  1717. causes build issues when depending system libraries end up in LIBS before
  1718. LIBS_PRIVATE.
  1719. * qmake/mkspecs/features/default_post.prf:
  1720. * qmake/mkspecs/features/functions.prf:
  1721. 2012-09-20 Simon Fraser <simon.fraser@apple.com>
  1722. Comment out a failing webkitpy unit test until Dirk can fix it.
  1723. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  1724. (SemanticTests.test_skip_and_wontfix):
  1725. 2012-09-20 Dirk Pranke <dpranke@chromium.org>
  1726. make Skip, WontFix be the only expectations on a line
  1727. https://bugs.webkit.org/show_bug.cgi?id=97225
  1728. Reviewed by Ojan Vafai.
  1729. It is now incorrect in the new syntax to have a line like:
  1730. foo.html [ WontFix Crash ]
  1731. This will generate a lint warning and be treated as an invalid
  1732. line. Fixing this caused a whole bunch of unit tests to need updating
  1733. to no longer be marked as WontFix :). Also, this patch adjusts
  1734. the warnings so that missing Bug() identifiers will cause lint
  1735. warnings but will *not* cause the line to be treated as invalid.
  1736. Fixing these issues also revealed that test_hung_thread was no
  1737. longer testing the right logic, so I adjusted the timeouts in
  1738. test.py to make that test work again.
  1739. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  1740. (Worker._run_test_in_another_thread):
  1741. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  1742. (ResultSummaryTest.test_summarized_results_wontfix):
  1743. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  1744. (TestExpectationParser._parse_modifiers):
  1745. (TestExpectationParser._tokenize_line_using_new_format):
  1746. (TestExpectationLine.is_invalid):
  1747. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  1748. (BasicTests.test_basic):
  1749. (test_get_test_set):
  1750. (test_parse_warning):
  1751. (test_pixel_tests_flag):
  1752. (SemanticTests.test_missing_bugid):
  1753. (SemanticTests):
  1754. (SemanticTests.test_skip_and_wontfix):
  1755. * Scripts/webkitpy/layout_tests/port/test.py:
  1756. (TestDriver.run_test):
  1757. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  1758. (MainTest.test_hung_thread):
  1759. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  1760. (PrintExpectationsTest.test_basic):
  1761. (PrintExpectationsTest.test_multiple):
  1762. (PrintExpectationsTest.test_full):
  1763. (PrintExpectationsTest.test_exclude):
  1764. (PrintExpectationsTest.test_csv):
  1765. 2012-09-20 Lucas Forschler <lforschler@apple.com>
  1766. Unreviewed. Start running tests on the mac-ews.
  1767. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  1768. (MacEWS):
  1769. 2012-09-20 Tony Chang <tony@chromium.org>
  1770. [chromium] Enable more clang warnings
  1771. https://bugs.webkit.org/show_bug.cgi?id=97257
  1772. Reviewed by James Robinson.
  1773. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
  1774. there are lots of violations in these files.
  1775. 2012-09-19 Ryosuke Niwa <rniwa@webkit.org>
  1776. run-perf-tests should record individual value instead of statistics
  1777. https://bugs.webkit.org/show_bug.cgi?id=97155
  1778. Reviewed by Hajime Morita.
  1779. Parse the list of individual value reported by tests and include them as "values".
  1780. We strip "values" from the output JSON when uploading it to the perf-o-matic
  1781. since it doesn't know how to parse "values" or ignore it.
  1782. * Scripts/webkitpy/performance_tests/perftest.py:
  1783. (PerfTest):
  1784. (PerfTest.parse_output): Parse and report "values".
  1785. (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
  1786. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  1787. (MainTest.test_parse_output):
  1788. (MainTest.test_parse_output_with_failing_line):
  1789. (TestPageLoadingPerfTest.test_run):
  1790. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  1791. (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
  1792. until we update perf-o-matic.
  1793. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  1794. (test_run_memory_test):
  1795. (test_run_with_json_output):
  1796. (test_run_with_description):
  1797. (test_run_with_slave_config_json):
  1798. (test_run_with_multiple_repositories):
  1799. 2012-09-20 Simon Hausmann <simon.hausmann@digia.com>
  1800. [Qt] Fix production builds
  1801. Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
  1802. Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
  1803. * qmake/mkspecs/features/functions.prf:
  1804. 2012-09-20 Dirk Pranke <dpranke@chromium.org>
  1805. REGRESSION: layout test results doesn't show diffs
  1806. https://bugs.webkit.org/show_bug.cgi?id=97182
  1807. Reviewed by Ojan Vafai.
  1808. Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
  1809. so that results.html (and hopefully garden-o-matic) can
  1810. determine which things actually failed. However, we keep mapping
  1811. these results to Failure so that we still only have a single
  1812. expectation type for them.
  1813. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  1814. (JSONLayoutResultsGenerator):
  1815. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  1816. (TestExpectationParser):
  1817. (TestExpectations):
  1818. (TestExpectations.result_was_expected):
  1819. * Scripts/webkitpy/layout_tests/models/test_failures.py:
  1820. (determine_result_type):
  1821. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  1822. (MainTest.test_missing_and_unexpected_results):
  1823. (MainTest.test_retrying_and_flaky_tests):
  1824. 2012-09-20 Tommy Widenflycht <tommyw@google.com>
  1825. MediaStream API: Extend UserMediaRequest with a ownerDocument method
  1826. https://bugs.webkit.org/show_bug.cgi?id=97095
  1827. Reviewed by Adam Barth.
  1828. Extending WebUserMediaClientMock to check that the owning document is valid,
  1829. and that the document has a frame.
  1830. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  1831. (WebKit::WebUserMediaClientMock::requestUserMedia):
  1832. 2012-09-20 Stephen Chenney <schenney@chromium.org>
  1833. [Chromium] DRT does not support --dump-all-pixels flag
  1834. https://bugs.webkit.org/show_bug.cgi?id=95098
  1835. Reviewed by Dirk Pranke.
  1836. Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
  1837. of this flag causes pixel results to be created for all tests, regardless of
  1838. individual test options. If an individual test provides a pixel hash it will be used,
  1839. otherwise the hash will be empty. This replaces a previously defined but unused option
  1840. --dump-all-pixels, and is useful primarily when debugging DRT instances.
  1841. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  1842. (runTest): Add a parameter and code to force pixel results for the test.
  1843. (main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
  1844. 2012-09-20 Carlos Garcia Campos <cgarcia@igalia.com>
  1845. [GTK] run-api-tests should not buffer test stdout
  1846. https://bugs.webkit.org/show_bug.cgi?id=88474
  1847. Reviewed by Philippe Normand.
  1848. * Scripts/run-gtk-tests:
  1849. (TestRunner._run_test_command): Use os.forkpty() instead of
  1850. subprocess.Popen() so that gtest sends the output with colors to
  1851. stdout. Use common.parse_output_lines() to parse the output and
  1852. write it to stdout while it's read.
  1853. (TestRunner._run_test_command.parse_line): Parse the line to get
  1854. the test pid and write the line to stdout.
  1855. (TestRunner._run_test_command.waitpid): Helper function to call
  1856. waitpid handling EINTR.
  1857. (TestRunner._run_test_command.return_code_from_exit_status):
  1858. Helper function to convert exit status of test commands to a
  1859. return code.
  1860. * gtk/common.py:
  1861. (parse_output_lines): Helper function that uses select to read
  1862. the given file descriptor and call the given callback for every
  1863. line read.
  1864. 2012-09-20 Simon Hausmann <simon.hausmann@digia.com>
  1865. [Qt] Fix initial build
  1866. Reviewed by Tor Arne Vestbø.
  1867. When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
  1868. $$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
  1869. causing incorrect linking for Makefile.api, etc.
  1870. Fix the determination by simply checking if MODULE is set, which only happens in api.pri.
  1871. * qmake/mkspecs/features/webkit_modules.prf:
  1872. 2012-09-20 Sheriff Bot <webkit.review.bot@gmail.com>
  1873. Unreviewed, rolling out r129091.
  1874. http://trac.webkit.org/changeset/129091
  1875. https://bugs.webkit.org/show_bug.cgi?id=97205
  1876. It broke perf tests everywhere (Requested by Ossy on #webkit).
  1877. * Scripts/webkitpy/performance_tests/perftest.py:
  1878. (PerfTest):
  1879. (PerfTest.parse_output):
  1880. (PageLoadingPerfTest.run):
  1881. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  1882. (MainTest.test_parse_output):
  1883. (MainTest.test_parse_output_with_failing_line):
  1884. (TestPageLoadingPerfTest.test_run):
  1885. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  1886. (PerfTestsRunner._generate_and_show_results):
  1887. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  1888. (test_run_memory_test):
  1889. (test_run_with_json_output):
  1890. (test_run_with_description):
  1891. (test_run_with_slave_config_json):
  1892. (test_run_with_multiple_repositories):
  1893. 2012-09-20 Simon Hausmann <simon.hausmann@digia.com>
  1894. [Qt] QtWebKit module header includes private dependencies
  1895. Reviewed by Tor Arne Vestbø.
  1896. * qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
  1897. that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
  1898. sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
  1899. we can't do it in default_pre.
  1900. * qmake/mkspecs/features/webkit_modules.prf:
  1901. 2012-09-20 Simon Hausmann <simon.hausmann@digia.com>
  1902. [Qt] Fix build with MingW
  1903. Reviewed by Tor Arne Vestbø.
  1904. Don't try to compile WebCore, etc. with debug symbols for production
  1905. builds, it's just too big.
  1906. * qmake/mkspecs/features/production_build.prf:
  1907. 2012-09-20 Michał Pakuła vel Rutka <m.pakula@samsung.com>
  1908. [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
  1909. https://bugs.webkit.org/show_bug.cgi?id=97087
  1910. Reviewed by Gyuyoung Kim.
  1911. Add focusing a main frame on settings reset.
  1912. After editing/undo/undo-iframe-location-change was executed a frame
  1913. was left in unfocused state. This caused flakiness in two tests results.
  1914. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  1915. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  1916. 2012-09-20 Allan Sandfeld Jensen <allan.jensen@digia.com>
  1917. [Qt] Add eventSender.gestureTap
  1918. https://bugs.webkit.org/show_bug.cgi?id=66173
  1919. Reviewed by Kenneth Rohde Christiansen.
  1920. Implement support for sending raw QGesture events.
  1921. * DumpRenderTree/qt/EventSenderQt.cpp:
  1922. (EventSender::EventSender):
  1923. (EventSender::gestureTap):
  1924. * DumpRenderTree/qt/EventSenderQt.h:
  1925. (EventSender):
  1926. 2012-09-19 Sheriff Bot <webkit.review.bot@gmail.com>
  1927. Unreviewed, rolling out r129007.
  1928. http://trac.webkit.org/changeset/129007
  1929. https://bugs.webkit.org/show_bug.cgi?id=97172
  1930. It broke the build on the Qt bots (Requested by Ossy on
  1931. #webkit).
  1932. * qmake/config.tests/gccdepends/empty.cpp:
  1933. * qmake/config.tests/gccdepends/gccdepends.pro:
  1934. * qmake/mkspecs/features/default_pre.prf:
  1935. 2012-09-19 Ryosuke Niwa <rniwa@webkit.org>
  1936. run-perf-tests should record indivisual value instead of statistics
  1937. https://bugs.webkit.org/show_bug.cgi?id=97155
  1938. Reviewed by Hajime Morita.
  1939. Parse the list of indivisual value reported by tests and include them as "values".
  1940. We strip "values" from the output JSON when uploading it to the perf-o-matic
  1941. since it doesn't know how to parse "values" or ignore it.
  1942. * Scripts/webkitpy/performance_tests/perftest.py:
  1943. (PerfTest):
  1944. (PerfTest.parse_output): Parse and report "values".
  1945. (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
  1946. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  1947. (MainTest.test_parse_output):
  1948. (MainTest.test_parse_output_with_failing_line):
  1949. (TestPageLoadingPerfTest.test_run):
  1950. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  1951. (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
  1952. until we update perf-o-matic.
  1953. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  1954. (test_run_memory_test):
  1955. (test_run_with_json_output):
  1956. (test_run_with_description):
  1957. (test_run_with_slave_config_json):
  1958. (test_run_with_multiple_repositories):
  1959. 2012-09-19 Dirk Pranke <dpranke@chromium.org>
  1960. Fix regex groups for bug matching in flakiness dashboard.
  1961. https://bugs.webkit.org/show_bug.cgi?id=97152
  1962. Unreviewed, build fix.
  1963. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  1964. (htmlForBugs):
  1965. 2012-09-19 Dirk Pranke <dpranke@chromium.org>
  1966. nrwt: print unexpected results using new TestExpectations syntax
  1967. https://bugs.webkit.org/show_bug.cgi?id=97159
  1968. Unreviewed, build fix.
  1969. Change new-run-webkit-tests to print out failures using the new
  1970. syntax when there are unexpected results, e.g.:
  1971. 52 tests ran as expected, 19 didn't:
  1972. Regressions: Unexpected failures : (2)
  1973. failures/flaky/text.html [ Failure ]
  1974. failures/unexpected/text-image-checksum.html [ Failure ]
  1975. and so forth
  1976. * Scripts/webkitpy/layout_tests/views/printing.py:
  1977. (Printer._print_unexpected_results):
  1978. 2012-09-19 Dirk Pranke <dpranke@chromium.org>
  1979. update flakiness dashboard after cutover to new test expectations syntax
  1980. https://bugs.webkit.org/show_bug.cgi?id=97152
  1981. Unreviewed, build fix.
  1982. Handle (??) the new Bug notations as well. Hopefully we don't
  1983. still need the old ones.
  1984. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  1985. (filterBugs):
  1986. (htmlForBugs):
  1987. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  1988. 2012-09-19 Dirk Pranke <dpranke@chromium.org>
  1989. update flakiness dashboard after cutover to new test expectations syntax
  1990. https://bugs.webkit.org/show_bug.cgi?id=97152
  1991. Reviewed by Ryosuke Niwa.
  1992. This change clones the TestExpectation parsing state machine
  1993. from python into javascript.
  1994. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  1995. (parsedExpectations.lines.forEach):
  1996. (parsedExpectations):
  1997. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  1998. 2012-09-19 Dana Jansens <danakj@chromium.org>
  1999. Add backer@chromium.org as contributor
  2000. https://bugs.webkit.org/show_bug.cgi?id=97150
  2001. * Scripts/webkitpy/common/config/committers.py:
  2002. 2012-09-19 Dirk Pranke <dpranke@chromium.org>
  2003. fix MISSING after TestExpectations conversion
  2004. https://bugs.webkit.org/show_bug.cgi?id=97148
  2005. Unreviewed, expectations change / build fix.
  2006. * Scripts/convert-test-expectations:
  2007. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  2008. (TestExpectationParser):
  2009. 2012-09-19 Dirk Pranke <dpranke@chromium.org>
  2010. nrwt: convert chromium TestExpectations to the new syntax
  2011. https://bugs.webkit.org/show_bug.cgi?id=97139
  2012. Reviewed by Ryosuke Niwa.
  2013. Add in a file temporarily that does the conversion of
  2014. test expectations formats
  2015. * Tools/Scripts/convert-test-expectations: Added.
  2016. 2012-09-19 Ryosuke Niwa <rniwa@webkit.org>
  2017. REGRESSION: run-perf-tests no longer reports the total test time
  2018. https://bugs.webkit.org/show_bug.cgi?id=97138
  2019. Reviewed by Tony Chang.
  2020. Report the finished time as a info-level log as opposed to a debug level log.
  2021. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  2022. (PerfTestsRunner._run_single_test):
  2023. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  2024. (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
  2025. (test_run_test_pause_before_testing):
  2026. (test_run_test_set_for_parser_tests):
  2027. (test_run_memory_test):
  2028. (_test_run_with_json_output):
  2029. 2012-09-19 Dirk Pranke <dpranke@chromium.org>
  2030. Support new TestExpectations format alongside old one
  2031. https://bugs.webkit.org/show_bug.cgi?id=96588
  2032. Reviewed by Ojan Vafai.
  2033. This patch adds support for actually reading in lines formatted
  2034. in the new style, and when we re-serialize/write out the file,
  2035. all lines will be written in the new style. Note that reading in
  2036. the old style is still supported, and no updates are being made
  2037. to the actual TestExpectations files as part of this change.
  2038. This change updates most but not all of the unit tests to use
  2039. the new syntax. I will update the rest when (or before where
  2040. possible) I drop support for the old format.
  2041. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  2042. (TestExpectationParser):
  2043. (TestExpectationParser._tokenize_line):
  2044. (TestExpectationParser._tokenize_line_using_new_format):
  2045. (TestExpectationLine.to_string):
  2046. (TestExpectationLine._format_line):
  2047. (TestExpectations):
  2048. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  2049. (test_parse_warning):
  2050. (SkippedTests.test_skipped_entry_dont_exist):
  2051. (NewExpectationSyntaxTests.test_warnings):
  2052. (RemoveConfigurationsTest.test_remove):
  2053. (test_remove_line):
  2054. (RebaseliningTest.test_remove):
  2055. (RebaseliningTest.test_no_get_rebaselining_failures):
  2056. (TestExpectationParserTests.test_tokenize_blank):
  2057. (TestExpectationParserTests.test_tokenize_extra_colon):
  2058. (TestExpectationParserTests.test_tokenize_missing_equal):
  2059. (TestExpectationParserTests.test_tokenize_extra_equal):
  2060. (TestExpectationSerializationTests.test_unparsed_to_string):
  2061. (TestExpectationSerializationTests.test_unparsed_list_to_string):
  2062. (TestExpectationSerializationTests.test_parsed_to_string):
  2063. (TestExpectationSerializationTests.test_format_line):
  2064. (TestExpectationSerializationTests.test_string_roundtrip):
  2065. (TestExpectationSerializationTests.test_list_roundtrip):
  2066. (TestExpectationSerializationTests.test_reconstitute_only_these):
  2067. (TestExpectationSerializationTests.test_string_whitespace_stripping):
  2068. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  2069. (LintTest.test_lint_test_files__errors):
  2070. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  2071. (PrintExpectationsTest.test_basic):
  2072. (PrintExpectationsTest.test_multiple):
  2073. (PrintExpectationsTest.test_full):
  2074. (PrintExpectationsTest.test_exclude):
  2075. * Scripts/webkitpy/tool/commands/rebaseline.py:
  2076. (RebaselineExpectations.execute):
  2077. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  2078. (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
  2079. (test_rebaseline_updates_expectations_file):
  2080. (test_rebaseline_does_not_include_overrides):
  2081. (test_rebaseline_expectations_noop):
  2082. (test_overrides_are_included_correctly):
  2083. 2012-09-19 Dirk Pranke <dpranke@chromium.org>
  2084. implement first part of support for the new TestExpectations syntax
  2085. https://bugs.webkit.org/show_bug.cgi?id=96569
  2086. Reviewed by Ryosuke Niwa.
  2087. This patch implements support for parsing a line of the new
  2088. format for the TestExpectations file and converting it back into
  2089. the old format for compatibility. This routine is not yet used
  2090. by anything.
  2091. The new format is documented at:
  2092. http://trac.webkit.org/wiki/TestExpectations
  2093. but, in short:
  2094. [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
  2095. - Comments are indicated with "#" instead of "//"
  2096. - If no expectations are specified we default to Skip for
  2097. compatibility with the Skipped files (these two changes make
  2098. Skipped files a subset of TestExpectations files)
  2099. - All of the tokens are now CamelCase instead of ALLCAPS.
  2100. - FAIL -> Failure
  2101. - IMAGE -> ImageOnlyFailure
  2102. - WONTFIX -> WontFix
  2103. - modifiers refer to just the platforms and configurations
  2104. (release/debug) that the line applies to.
  2105. - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
  2106. expectations
  2107. - expectations will typically be written out in lexicographic order
  2108. - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
  2109. instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
  2110. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  2111. (TestExpectationParser):
  2112. (TestExpectationParser._tokenize_line_using_new_format):
  2113. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  2114. (NewExpectationSyntaxTests):
  2115. (NewExpectationSyntaxTests.assert_exp):
  2116. (NewExpectationSyntaxTests.test_bare_name):
  2117. (NewExpectationSyntaxTests.test_bare_name_and_bugs):
  2118. (NewExpectationSyntaxTests.test_comments):
  2119. (NewExpectationSyntaxTests.test_config_modifiers):
  2120. (NewExpectationSyntaxTests.test_unknown_config):
  2121. (NewExpectationSyntaxTests.test_unknown_expectation):
  2122. (NewExpectationSyntaxTests.test_skip):
  2123. (NewExpectationSyntaxTests.test_slow):
  2124. (NewExpectationSyntaxTests.test_wontfix):
  2125. (NewExpectationSyntaxTests.test_blank_line):
  2126. (NewExpectationSyntaxTests.test_warnings):
  2127. 2012-09-19 Dirk Pranke <dpranke@chromium.org>
  2128. nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
  2129. https://bugs.webkit.org/show_bug.cgi?id=96845
  2130. Reviewed by Ojan Vafai.
  2131. In preparation for the new TestExpectations syntax, we replace
  2132. all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
  2133. make switching to the new syntax lossless (i.e., we lose
  2134. information now, not then).
  2135. Note that we can still parse in results.json files that have the
  2136. old data for backwards compatibility.
  2137. * Scripts/webkitpy/common/net/resultsjsonparser.py:
  2138. (JSONTestResult._failure_types_from_actual_result):
  2139. * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  2140. (ResultsJSONParserTest):
  2141. (test_basic):
  2142. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  2143. (ResultSummaryTest.test_summarized_results_wontfix):
  2144. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  2145. (JSONLayoutResultsGenerator):
  2146. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  2147. (TestExpectations):
  2148. (TestExpectations.remove_pixel_failures):
  2149. (TestExpectations.has_pixel_failures):
  2150. (TestExpectations.suffixes_for_expectations):
  2151. (TestExpectations.get_rebaselining_failures):
  2152. (TestExpectations.remove_configuration_from_test):
  2153. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  2154. (assert_bad_expectations):
  2155. (BasicTests):
  2156. (BasicTests.test_basic):
  2157. (MiscTests):
  2158. (MiscTests.test_multiple_results):
  2159. (MiscTests.test_result_was_expected):
  2160. (MiscTests.test_remove_pixel_failures):
  2161. (MiscTests.test_suffixes_for_expectations):
  2162. (test_get_expectations_string):
  2163. (test_parse_warning):
  2164. (test_error_on_different_platform):
  2165. (test_error_on_different_build_type):
  2166. (test_overrides):
  2167. (test_overrides__directory):
  2168. (test_overrides__duplicate):
  2169. (test_pixel_tests_flag):
  2170. (test_more_specific_override_resets_skip):
  2171. (SkippedTests.test_skipped_file_overrides_expectations):
  2172. (SkippedTests.test_skipped_dir_overrides_expectations):
  2173. (SkippedTests.test_skipped_file_overrides_overrides):
  2174. (SkippedTests.test_skipped_dir_overrides_overrides):
  2175. (ExpectationSyntaxTests.test_missing_colon):
  2176. (ExpectationSyntaxTests.test_too_many_equals_signs):
  2177. (SemanticTests.test_bug_format):
  2178. (SemanticTests.test_bad_bugid):
  2179. (SemanticTests.test_missing_bugid):
  2180. (SemanticTests.test_rebaseline):
  2181. (test_missing_file):
  2182. (test_more_modifiers):
  2183. (test_order_in_file):
  2184. (test_macro_overrides):
  2185. (RemoveConfigurationsTest.test_remove):
  2186. (test_remove_line):
  2187. (RebaseliningTest.test_remove):
  2188. (TestExpectationSerializationTests.test_serialize_parsed_expectations):
  2189. * Scripts/webkitpy/layout_tests/models/test_failures.py:
  2190. (determine_result_type):
  2191. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  2192. (test_test_expectations):
  2193. * Scripts/webkitpy/layout_tests/port/test.py:
  2194. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  2195. (MainTest.test_missing_and_unexpected_results):
  2196. (MainTest.test_retrying_and_flaky_tests):
  2197. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  2198. (TestExpectationsTestCase.test_valid_expectations):
  2199. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  2200. (PrintExpectationsTest.test_basic):
  2201. (PrintExpectationsTest.test_multiple):
  2202. (PrintExpectationsTest.test_full):
  2203. (PrintExpectationsTest.test_exclude):
  2204. (PrintExpectationsTest.test_csv):
  2205. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  2206. (test_rebaseline_does_not_include_overrides):
  2207. (test_overrides_are_included_correctly):
  2208. 2012-09-19 Dominic Mazzoni <dmazzoni@google.com>
  2209. AX: A few control types are returning the wrong answer for isReadOnly
  2210. https://bugs.webkit.org/show_bug.cgi?id=96735
  2211. Reviewed by Chris Fleizach.
  2212. Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
  2213. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  2214. (AccessibilityUIElement::AccessibilityUIElement):
  2215. (AccessibilityUIElement::isReadOnlyGetterCallback):
  2216. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
  2217. (AccessibilityUIElement):
  2218. 2012-09-19 Sudarsana Nagineni <sudarsana.nagineni@intel.com>
  2219. [WTR] Memory leaks in TestRunner::deliverWebIntent()
  2220. https://bugs.webkit.org/show_bug.cgi?id=97111
  2221. Reviewed by Kenneth Rohde Christiansen.
  2222. Fix memory leaks in deliverWebIntent() by adopting strings
  2223. created with WKStringCreateWithUTF8CString().
  2224. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  2225. (WTR::TestRunner::deliverWebIntent):
  2226. 2012-09-19 Simon Hausmann <simon.hausmann@digia.com>
  2227. [Qt] Fix incremental builds with all-in-one-files and gccdepends
  2228. Reviewed by Tor Arne Vestbø.
  2229. Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
  2230. are not only created for header files but also for .cpp files. AllInOne.cpp files
  2231. include other .cpp files, and when those are removed we need those dummy rules to
  2232. avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
  2233. * qmake/config.tests/gccdepends/empty.cpp:
  2234. (main):
  2235. * qmake/config.tests/gccdepends/gccdepends.pro:
  2236. * qmake/mkspecs/features/default_pre.prf:
  2237. 2012-09-19 Rick Byers <rbyers@chromium.org>
  2238. Do touch adjustment on GestureTapDown
  2239. https://bugs.webkit.org/show_bug.cgi?id=96677
  2240. Reviewed by Antonio Gomes.
  2241. Allow radius to be set for GestureTapDown events.
  2242. * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
  2243. (EventSender::gestureEvent):
  2244. 2012-09-19 Christophe Dumez <christophe.dumez@intel.com>
  2245. [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
  2246. https://bugs.webkit.org/show_bug.cgi?id=97100
  2247. Reviewed by Gyuyoung Kim.
  2248. EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
  2249. preference, in order to match WebKitTestRunner functionality.
  2250. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2251. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  2252. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  2253. (TestRunner::overridePreference):
  2254. 2012-09-18 Kangil Han <kangil.han@samsung.com>
  2255. [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
  2256. https://bugs.webkit.org/show_bug.cgi?id=96181
  2257. Reviewed by Daniel Bates.
  2258. This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
  2259. * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
  2260. (new):
  2261. (_parseLicenseBlock):
  2262. (_parseLicenseBlockFromFile):
  2263. (_defaultLicenseBlock):
  2264. (_licenseBlock):
  2265. (_generateHeaderFile):
  2266. (_generateImplementationFile):
  2267. 2012-09-18 Byungwoo Lee <bw80.lee@samsung.com>
  2268. Title string should be changed when document.title is set to ''.
  2269. https://bugs.webkit.org/show_bug.cgi?id=96793
  2270. Reviewed by Kenneth Rohde Christiansen.
  2271. Change dump format of dumpTitleChanges more understandable.
  2272. Uses single quotation marks for the title string.
  2273. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  2274. (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
  2275. * DumpRenderTree/chromium/WebViewHost.cpp:
  2276. (WebViewHost::didReceiveTitle):
  2277. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2278. (DumpRenderTreeChrome::onFrameTitleChanged):
  2279. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  2280. (webViewTitleChanged):
  2281. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  2282. (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
  2283. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  2284. (WebCore::DumpRenderTree::titleChanged):
  2285. * DumpRenderTree/win/FrameLoadDelegate.cpp:
  2286. (FrameLoadDelegate::didReceiveTitle):
  2287. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  2288. (LayoutWebViewEventHandler::OnReceivedTitleEvent):
  2289. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  2290. (WTR::InjectedBundlePage::didReceiveTitleForFrame):
  2291. 2012-09-18 Szilard Ledan <szledan@inf.u-szeged.hu>
  2292. EWS shouldn't sleep if there are new patches in its queue
  2293. https://bugs.webkit.org/show_bug.cgi?id=83038
  2294. Reviewed by Eric Seidel.
  2295. EWS tries to process a security patch. Of course it can't, because the EWS isn't
  2296. the member of the security group. But the problem is that after it can't process
  2297. the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
  2298. and push the security patch to the end of the queue.
  2299. Now it stays in the loop until it finds a patch or the queue gets empty.
  2300. * Scripts/webkitpy/tool/commands/queues.py:
  2301. (AbstractPatchQueue._next_patch):
  2302. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  2303. (AbstractPatchQueueTest.test_next_patch):
  2304. 2012-09-18 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  2305. [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
  2306. https://bugs.webkit.org/show_bug.cgi?id=97014
  2307. Reviewed by Kenneth Rohde Christiansen.
  2308. According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
  2309. be used for literals rather than WTF::StringBuilder::append().
  2310. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  2311. (WTR::InjectedBundle::booleanForKey):
  2312. 2012-09-18 Simon Hausmann <simon.hausmann@digia.com>
  2313. Update my e-mail address.
  2314. * Scripts/webkitpy/common/config/committers.py:
  2315. 2012-09-18 Andras Becsi <andras.becsi@digia.com>
  2316. Update my e-mail address.
  2317. Unreviewed.
  2318. * Scripts/webkitpy/common/config/committers.py:
  2319. 2012-09-18 Andras Becsi <andras.becsi@digia.com>
  2320. [Qt] qt_webkit.pri should not be listed in Tools.pro
  2321. Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
  2322. Since r128751 the module pri file is auto-generated
  2323. but it was still listed in OTHER_FILES.
  2324. * Tools.pro: Remove unneeded line.
  2325. 2012-09-18 Simon Hausmann <simon.hausmann@digia.com>
  2326. [Qt] Fix build with some versions of the gold linker
  2327. Reviewed by Tor Arne Vestbø.
  2328. Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
  2329. Instead run a compile/link test first to see if it works.
  2330. * qmake/config.tests/gnuld/gnuld.pro: Added.
  2331. * qmake/config.tests/gnuld/main.cpp: Added.
  2332. (main):
  2333. * qmake/mkspecs/features/unix/default_post.prf:
  2334. 2012-09-18 Simon Hausmann <simon.hausmann@digia.com>
  2335. [Qt] Remove forced use of gold.
  2336. Reviewed by Tor Arne Vestbø.
  2337. The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
  2338. modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
  2339. often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
  2340. * qmake/mkspecs/features/unix/default_post.prf:
  2341. 2012-09-18 Simon Hausmann <simon.hausmann@digia.com>
  2342. [Qt] Prospective Qt/Windows cross-compiling fix
  2343. Reviewed by Tor Arne Vestbø.
  2344. The win32 scope is not set when cross-compiling from Linux to Windows.
  2345. * qmake/mkspecs/features/functions.prf:
  2346. 2012-09-18 Seokju Kwon <seokju.kwon@samsung.com>
  2347. [EFL] Remove background view on EWebLauncher and MiniBrowser
  2348. https://bugs.webkit.org/show_bug.cgi?id=96905
  2349. Reviewed by Gyuyoung Kim.
  2350. The size of webview was changed after adding url bar.
  2351. And the background view is not necessary anymore, since it was used for debugging back in the day.
  2352. * EWebLauncher/main.c:
  2353. (_ELauncher):
  2354. (on_ecore_evas_resize):
  2355. (browserCreate):
  2356. * MiniBrowser/efl/main.c:
  2357. (_MiniBrowser):
  2358. (on_ecore_evas_resize):
  2359. (browserCreate):
  2360. 2012-09-18 Sergio Villar Senin <svillar@igalia.com>
  2361. [GTK] run-webkit-tests unable to find TestExpectations for WK2
  2362. https://bugs.webkit.org/show_bug.cgi?id=96998
  2363. Reviewed by Philippe Normand.
  2364. We should look for TestExpectations files in all the locations where
  2365. we currently look for Skipped files. This will allow
  2366. run-webkit-tests to look for TestExpectations files in
  2367. platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
  2368. * Scripts/webkitpy/layout_tests/port/gtk.py:
  2369. (GtkPort.expectations_files):
  2370. 2012-09-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2371. [Qt] Fix build without the QtQuick module
  2372. Reviewed by Simon Hausmann.
  2373. * qmake/mkspecs/features/features.prf:
  2374. 2012-09-18 Stephanie Lewis <slewis@apple.com>
  2375. Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
  2376. Unreviewed.
  2377. * DumpRenderTree/mac/DumpRenderTree.mm:
  2378. (poseAsClass):
  2379. 2012-09-18 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  2380. Unreviewed update of email addresses for Berlin QtWebKit office.
  2381. * Scripts/webkitpy/common/config/committers.py:
  2382. 2012-09-17 Zan Dobersek <zandobersek@gmail.com>
  2383. [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
  2384. https://bugs.webkit.org/show_bug.cgi?id=96899
  2385. Reviewed by Martin Robinson.
  2386. When overriding the 'WebKitDisplayImageKey' preference, use the
  2387. 'auto-load-images' property of WebKitWebSettings as the property which
  2388. should be updated with the corresponding preference value.
  2389. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  2390. (resetDefaultsToConsistentValues):
  2391. * DumpRenderTree/gtk/TestRunnerGtk.cpp:
  2392. (TestRunner::overridePreference):
  2393. 2012-09-17 Pratik Solanki <psolanki@apple.com>
  2394. DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
  2395. https://bugs.webkit.org/show_bug.cgi?id=96973
  2396. Reviewed by Dan Bernstein.
  2397. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  2398. * WebKitTestRunner/Configurations/Base.xcconfig:
  2399. * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
  2400. 2012-09-17 Dirk Pranke <dpranke@chromium.org>
  2401. nrwt: remove "unexpected EOF" warnings
  2402. https://bugs.webkit.org/show_bug.cgi?id=96970
  2403. Reviewed by Ojan Vafai.
  2404. After debugging this a bit, it looks like there aren't any cases
  2405. that I can reproduce where a read() of zero indicates something
  2406. actually wrong; either it is a prelude to a crash, or a false
  2407. negative. So, I'm removing these warnings and adding a comment.
  2408. * Scripts/webkitpy/layout_tests/port/server_process.py:
  2409. (ServerProcess._wait_for_data_and_update_buffers_using_select):
  2410. 2012-09-17 Dirk Pranke <dpranke@chromium.org>
  2411. [chromium] ASAN bot is crashing at the end of the run
  2412. https://bugs.webkit.org/show_bug.cgi?id=96967
  2413. Reviewed by Abhishek Arya.
  2414. The ASAN bot is crashing attempting to decode some output into
  2415. UTF-8; there's no reason to do this, so let's not do this and
  2416. see if something else is going on as well.
  2417. * Scripts/webkitpy/layout_tests/port/chromium.py:
  2418. (ChromiumPort._get_crash_log):
  2419. 2012-09-17 Dirk Pranke <dpranke@chromium.org>
  2420. nrwt: --results-directory isn't getting printed properly
  2421. https://bugs.webkit.org/show_bug.cgi?id=96965
  2422. Reviewed by Ojan Vafai.
  2423. options.results_directory isn't actually initialized with the
  2424. default values until after we call print_config(), so this
  2425. changes things to print the value directly.
  2426. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  2427. (run):
  2428. * Scripts/webkitpy/layout_tests/views/printing.py:
  2429. (Printer.print_config):
  2430. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  2431. (Testprinter.test_print_config):
  2432. 2012-09-17 Rob Buis <rbuis@rim.com>
  2433. [BlackBerry] Enable VIDEO_TRACK
  2434. https://bugs.webkit.org/show_bug.cgi?id=96949
  2435. Reviewed by Antonio Gomes.
  2436. * Scripts/webkitperl/FeatureList.pm:
  2437. 2012-09-17 Rick Byers <rbyers@chromium.org>
  2438. Add handling of new GestureTapCancel in DRT
  2439. https://bugs.webkit.org/show_bug.cgi?id=96183
  2440. Reviewed by Antonio Gomes.
  2441. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  2442. (TestWebPlugin::handleInputEvent):
  2443. * DumpRenderTree/chromium/EventSender.cpp:
  2444. (EventSender::gestureTapCancel):
  2445. 2012-09-17 Philip Rogers <pdr@google.com>
  2446. Teach style checker about preprocessor directive indentation rules
  2447. https://bugs.webkit.org/show_bug.cgi?id=96874
  2448. Reviewed by Adam Barth.
  2449. Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
  2450. This is not explicit in our style guide but is generally followed in our code.
  2451. Searching for violations in our codebase shows these are rarely indented:
  2452. #include - indented in 6 files
  2453. #ifdef - indented in 0 files
  2454. #ifndef - indented in 1 file
  2455. #define - indented in 11 files
  2456. #if - indented in 7 files
  2457. * Scripts/webkitpy/style/checkers/cpp.py:
  2458. (check_directive_indentation):
  2459. This is the simple test where we look for spaces followed by a #.
  2460. (check_style):
  2461. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  2462. A few tests needed to be modified because they had unintentionally indented
  2463. preprocessor directives.
  2464. (CppStyleTest.test_build_class.Foo):
  2465. (CppStyleTest.test_build_class):
  2466. (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
  2467. (WebKitStyleTest.test_line_breaking):
  2468. (WebKitStyleTest.test_directive_indentation):
  2469. 2012-09-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2470. [Qt] Auto-generate the module pri file for QtWebKit
  2471. Reviewed by Simon Hausmann.
  2472. * qmake/qt_webkit.pri: Removed.
  2473. 2012-09-14 Dirk Pranke <dpranke@chromium.org>
  2474. nrwt: --additional-platform-dir is broken on chromium ports
  2475. https://bugs.webkit.org/show_bug.cgi?id=96840
  2476. Reviewed by Ojan Vafai.
  2477. Looks like I broke this when cleaning things up as part of
  2478. adding ML support. Fixing and adding a test.
  2479. * Scripts/webkitpy/layout_tests/port/chromium.py:
  2480. (ChromiumPort.default_baseline_search_path):
  2481. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  2482. (ChromiumAndroidPort.default_baseline_search_path):
  2483. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  2484. (ChromiumLinuxPort.default_baseline_search_path):
  2485. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  2486. (ChromiumMacPort.__init__):
  2487. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  2488. (ChromiumWinPort.setup_environ_for_server):
  2489. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  2490. (test_check_build):
  2491. (test_additional_platform_directory):
  2492. 2012-09-13 Stephanie Lewis <slewis@apple.com>
  2493. mac-future ignores previous platform TestExpectations.
  2494. https://bugs.webkit.org/show_bug.cgi?id=96718.
  2495. Reviewed by Dirk Pranke.
  2496. TestExpectations match an expectation's configuraton against a list of configurations that are
  2497. valid for that port. That list does not contain mac-future so none of the expectations can be
  2498. applied.
  2499. * Scripts/webkitpy/layout_tests/port/apple.py:
  2500. (ApplePort._generate_all_test_configurations):
  2501. 2012-09-14 Adam Barth <abarth@webkit.org>
  2502. Remove webkitPostMessage
  2503. https://bugs.webkit.org/show_bug.cgi?id=96577
  2504. Reviewed by Ojan Vafai.
  2505. Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
  2506. * Scripts/webkitperl/FeatureList.pm:
  2507. * qmake/mkspecs/features/features.pri:
  2508. 2012-09-14 Alexey Proskuryakov <ap@apple.com>
  2509. [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
  2510. https://bugs.webkit.org/show_bug.cgi?id=96817
  2511. Reviewed by Kenneth Rohde Christiansen.
  2512. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  2513. (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
  2514. got overlooked when adding logging elsewhere.
  2515. 2012-09-14 Peter Beverloo <peter@chromium.org>
  2516. [Chromium] Build fix for DumpRenderTree following r128628
  2517. https://bugs.webkit.org/show_bug.cgi?id=96808
  2518. Reviewed by Tony Chang.
  2519. When building DumpRenderTree from the Chromium project, a compile error
  2520. shows up because including the header ForwardIOStreamsAndroid.h cannot
  2521. be located. TestWebKitAPI does this correctly.
  2522. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  2523. 2012-09-14 Dana Jansens <danakj@chromium.org>
  2524. Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
  2525. https://bugs.webkit.org/show_bug.cgi?id=96805
  2526. Reviewed by Dirk Pranke.
  2527. * Scripts/webkitpy/common/config/committers.py:
  2528. * Scripts/webkitpy/common/config/watchlist:
  2529. 2012-09-14 Peter Beverloo <peter@chromium.org>
  2530. [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
  2531. https://bugs.webkit.org/show_bug.cgi?id=96687
  2532. Reviewed by Tony Chang.
  2533. Android's DumpRenderTree currently supports these arguments, implemented
  2534. as part of TestShellAndroid:
  2535. http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
  2536. They're used by the layout test runner to get the STDOUT and STDERR while
  2537. a layout test run is in process, which is a safer alternative to parsing
  2538. all the logcat output manually. The implementation can be seen here:
  2539. http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
  2540. This patch generalizes parsing of and applying the effects of these arguments
  2541. so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
  2542. After this patch, this will make it possible to pull out the output-reading
  2543. code from Android's layout test port and generalize it so it can be re-used
  2544. in the new test-runner for the other two test suites.
  2545. This has no effect when compiling and running these tests as part of Chromium
  2546. code, which has a much more advanced test-runner that does parse complete log
  2547. output, but also directly depends on code licensed under Apache 2.
  2548. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  2549. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  2550. (platformInit):
  2551. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  2552. 2012-09-14 Zoltan Horvath <zoltan@webkit.org>
  2553. check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
  2554. https://bugs.webkit.org/show_bug.cgi?id=96656
  2555. Reviewed by Adam Barth.
  2556. We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
  2557. macros in 1 line.
  2558. * Scripts/webkitpy/style/checkers/cpp.py:
  2559. (check_style.definitions):
  2560. (check_style): Add rule.
  2561. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  2562. (WebKitStyleTest.test_line_breaking): Add unittest.
  2563. 2012-09-14 Christophe Dumez <christophe.dumez@intel.com>
  2564. WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
  2565. https://bugs.webkit.org/show_bug.cgi?id=57570
  2566. Reviewed by Kenneth Rohde Christiansen.
  2567. Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
  2568. and dump the information expected by the test cases.
  2569. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  2570. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  2571. (WTR::InjectedBundle::beginTesting): Explicitly set the default
  2572. database quota.
  2573. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  2574. (WTR::securityOriginToStr): New convenience function to convert
  2575. a security origin to the string expected in test results.
  2576. (WTR):
  2577. (WTR::InjectedBundlePage::InjectedBundlePage):
  2578. (WTR::InjectedBundlePage::didExceedDatabaseQuota):
  2579. (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
  2580. refactoring to share code with didExceedDatabaseQuota.
  2581. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  2582. (InjectedBundlePage):
  2583. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  2584. (WTR::TestRunner::TestRunner):
  2585. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  2586. (WTR::TestRunner::dumpDatabaseCallbacks):
  2587. (WTR::TestRunner::shouldDumpDatabaseCallbacks):
  2588. (TestRunner):
  2589. 2012-09-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2590. [Qt] Set force_static_libs_as_shared early enough to be caught by configure
  2591. Rubber-stamped by Simon Hausmann.
  2592. * qmake/mkspecs/features/default_post.prf:
  2593. 2012-09-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2594. [Qt] Remove old cruft from the qmake build system
  2595. Rubber-stamped by Simon Hausmann.
  2596. * DumpRenderTree/qt/DumpRenderTree.pro:
  2597. * qmake/mkspecs/features/default_post.prf:
  2598. 2012-09-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2599. [Qt] Enable force_static_libs_as_shared for development
  2600. Not enabled for buildbots or production-builds (part of Qt5)
  2601. Reviewed by Simon Hausmann.
  2602. * qmake/mkspecs/features/default_post.prf:
  2603. 2012-09-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2604. [Qt] Make force_static_libs_as_shared work on Mac OS
  2605. We had to move a few LIBS += around that were in the wrong place,
  2606. and not caught when everything was just linked into the final
  2607. QtWebKit library.
  2608. Reviewed by Simon Hausmann.
  2609. * qmake/mkspecs/features/default_post.prf:
  2610. * qmake/mkspecs/features/force_static_libs_as_shared.prf:
  2611. 2012-09-14 Simon Hausmann <simon.hausmann@nokia.com>
  2612. [Qt] Fix build of WTR on Windows
  2613. Reviewed by Tor Arne Vestbø.
  2614. WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
  2615. With qmake's unix makefile generator as well as with the MingW generator,
  2616. the directory where the pro file lives (WTR/) is automatically added to
  2617. the include search path, but not so with MSVC. Instead of relying on qmake's
  2618. implicit feature here, add WTR/ explicitly to the include search path.
  2619. * WebKitTestRunner/Target.pri:
  2620. 2012-09-14 Christophe Dumez <christophe.dumez@intel.com>
  2621. WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
  2622. https://bugs.webkit.org/show_bug.cgi?id=42691
  2623. Reviewed by Kenneth Rohde Christiansen.
  2624. Add implementation for testrunner.setStopProvisionalFrameLoads()
  2625. in WebKitTestRunner.
  2626. Original patch by Alexey Proskuryakov.
  2627. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  2628. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  2629. (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
  2630. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  2631. (WTR::TestRunner::TestRunner):
  2632. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  2633. (TestRunner):
  2634. (WTR::TestRunner::setStopProvisionalFrameLoads):
  2635. (WTR::TestRunner::shouldStopProvisionalFrameLoads):
  2636. 2012-09-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2637. [Qt] Fix handling of debug/release/debug_and_release/build_all
  2638. We now pick up the defaults from Qt, in default_pre (CONFIG already
  2639. contains the appropriate values for debug and release). We then let
  2640. the command line arguments to qmake, or the project files themselves,
  2641. override the configuration, and finally we sanitize the configuration
  2642. in default_post.
  2643. Reviewed by Simon Hausmann.
  2644. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  2645. * Scripts/webkitdirs.pm:
  2646. (buildQMakeProjects):
  2647. * qmake/mkspecs/features/default_post.prf:
  2648. * qmake/mkspecs/features/default_pre.prf:
  2649. * qmake/mkspecs/features/mac/default_pre.prf:
  2650. 2012-09-14 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  2651. WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
  2652. https://bugs.webkit.org/show_bug.cgi?id=42687
  2653. Reviewed by Kenneth Rohde Christiansen.
  2654. Implement testRunner.setTabKeyCyclesThroughElements for
  2655. WebKitTestRunner.
  2656. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  2657. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  2658. (WTR::InjectedBundle::beginTesting):
  2659. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  2660. (WTR::TestRunner::setTabKeyCyclesThroughElements):
  2661. (WTR):
  2662. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  2663. (TestRunner):
  2664. 2012-09-14 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  2665. EventSendingController::keyDown does not support non-array modifier arguments
  2666. https://bugs.webkit.org/show_bug.cgi?id=96727
  2667. Reviewed by Kenneth Rohde Christiansen.
  2668. Add support for handling a string as modifier argument to
  2669. EventSendingController::keyDown.
  2670. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  2671. (WTR::parseModifierArray):
  2672. 2012-09-14 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  2673. WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
  2674. https://bugs.webkit.org/show_bug.cgi?id=42546
  2675. Reviewed by Kenneth Rohde Christiansen.
  2676. Exported TestRunner::setCustomPolicyDelegate() method.
  2677. Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
  2678. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  2679. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  2680. (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
  2681. 2012-09-14 Zan Dobersek <zandobersek@gmail.com>
  2682. [GTK] Clear application cache between tests in DumpRenderTree
  2683. https://bugs.webkit.org/show_bug.cgi?id=96543
  2684. Reviewed by Philippe Normand.
  2685. Call the new DumpRenderTreeSupportGtk method to clear application cache
  2686. after each test in DumpRenderTree.
  2687. Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
  2688. as well. It's now being set in XvfbDriver._start so that each driver is assigned
  2689. a cache directory that's constructed out of the driver's name and its worker
  2690. number. These directories are located in the layout tests results directory.
  2691. At least on the builders this ensures a driver-specific empty cache directory
  2692. with each test run.
  2693. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  2694. (runTest):
  2695. * Scripts/webkitpy/layout_tests/port/gtk.py:
  2696. (GtkPort.setup_environ_for_server):
  2697. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  2698. (XvfbDriver._start):
  2699. 2012-09-14 Simon Hausmann <simon.hausmann@nokia.com>
  2700. [Qt] Fix linking on Windows
  2701. Reviewed by Tor Arne Vestbø.
  2702. When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
  2703. macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
  2704. the QtWebKit.dll creation in the build process and be off afterwards. This is done in
  2705. win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
  2706. r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
  2707. want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
  2708. after the module. Therefore QT did never contain webkit anymore and we always passed
  2709. QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
  2710. This patch introduces a creating_module configuration that is used to
  2711. scope the qt/pkgconfig sanitization.
  2712. * qmake/mkspecs/features/default_post.prf:
  2713. 2012-09-14 Christophe Dumez <christophe.dumez@intel.com>
  2714. [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
  2715. https://bugs.webkit.org/show_bug.cgi?id=96740
  2716. Reviewed by Kenneth Rohde Christiansen.
  2717. Dump information expected by the test cases about the following
  2718. frame load callbacks:
  2719. "didDisplayInsecureContentForFrame"
  2720. "didRunInsecureContentForFrame"
  2721. "didDetectXSSForFrame"
  2722. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  2723. (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
  2724. as expected by test results by calling pathSuitableForTestResult() instead
  2725. of printing raw URL.
  2726. (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
  2727. (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
  2728. (WTR::InjectedBundlePage::didDetectXSSForFrame):
  2729. 2012-09-14 Peter Beverloo <peter@chromium.org>
  2730. The runtime/unsigned category should be valid in the cpp style-checker.
  2731. https://bugs.webkit.org/show_bug.cgi?id=96748
  2732. Reviewed by Csaba Osztrogonác.
  2733. This is causing the webkitpy tests to fail because it's not listed in the
  2734. category array. Furthermore, change an "int" to "long" because it's
  2735. throwing a double error in one of the earlier asserts.
  2736. * Scripts/webkitpy/style/checkers/cpp.py:
  2737. (CppChecker):
  2738. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  2739. (WebKitStyleTest.test_names):
  2740. 2012-09-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
  2741. Evas_Object* is a ref'ed structure, so tread it as such
  2742. https://bugs.webkit.org/show_bug.cgi?id=96659
  2743. Reviewed by Adam Barth.
  2744. Replace OwnPtr<Evas_Object> with RefPtr.
  2745. * DumpRenderTree/efl/ImageDiff.cpp:
  2746. (calculateDifference):
  2747. (printImageDifferences):
  2748. (readImageFromStdin):
  2749. (main):
  2750. 2012-09-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  2751. Unreviewed, rolling out r128507.
  2752. http://trac.webkit.org/changeset/128507
  2753. https://bugs.webkit.org/show_bug.cgi?id=96659
  2754. Revert. r128507 makes too many crashes in EFL layout test bots.
  2755. * DumpRenderTree/efl/ImageDiff.cpp:
  2756. (calculateDifference):
  2757. (printImageDifferences):
  2758. (readImageFromStdin):
  2759. (main):
  2760. 2012-09-13 Kevin Funk <kevin.funk@kdab.com>
  2761. Make compile with both OS(WINCE) and PLATFORM(QT) support
  2762. https://bugs.webkit.org/show_bug.cgi?id=95536
  2763. Reviewed by Simon Hausmann.
  2764. Fix wince support in qmake files
  2765. * Tools.pro:
  2766. * qmake/mkspecs/features/configure.prf:
  2767. * qmake/mkspecs/features/default_post.prf:
  2768. * qmake/mkspecs/features/features.prf:
  2769. * qmake/mkspecs/features/functions.prf:
  2770. 2012-09-13 KwangYong Choi <ky0.choi@samsung.com>
  2771. [WK2] Add color picker API support for WebKit2
  2772. https://bugs.webkit.org/show_bug.cgi?id=95058
  2773. Reviewed by Gyuyoung Kim.
  2774. Initialization code for color picker callbacks in UI client.
  2775. * MiniBrowser/mac/BrowserWindowController.m:
  2776. (-[BrowserWindowController awakeFromNib]):
  2777. * MiniBrowser/win/BrowserView.cpp:
  2778. (BrowserView::create):
  2779. * WebKitTestRunner/TestController.cpp:
  2780. (WTR::TestController::createOtherPage):
  2781. (WTR::TestController::initialize):
  2782. 2012-09-13 Yuta Kitamura <yutak@chromium.org>
  2783. Upgrade yutak to reviewer
  2784. https://bugs.webkit.org/show_bug.cgi?id=96721
  2785. Reviewed by Kent Tamura.
  2786. * Scripts/webkitpy/common/config/committers.py:
  2787. 2012-09-13 Adenilson Cavalcanti <cavalcantii@gmail.com>
  2788. Make the style checker report usage of "unsigned int"
  2789. https://bugs.webkit.org/show_bug.cgi?id=96693
  2790. Reviewed by Dirk Pranke.
  2791. Add a rule to check for uses of unsigned int, as the updated coding style recomends.
  2792. * Scripts/webkitpy/style/checkers/cpp.py:
  2793. (check_language):
  2794. 2012-09-13 Philip Rogers <pdr@google.com>
  2795. Add gender-neutral form of webkit-patch land-cowboy
  2796. https://bugs.webkit.org/show_bug.cgi?id=96709
  2797. Reviewed by Adam Barth.
  2798. Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
  2799. * Scripts/webkitpy/tool/commands/download.py:
  2800. (LandCowhand):
  2801. 2012-09-13 Seokju Kwon <seokju.kwon@samsung.com>
  2802. [EFL] Remove some parameters in browserCreate()
  2803. https://bugs.webkit.org/show_bug.cgi?id=96499
  2804. Reviewed by Kenneth Rohde Christiansen.
  2805. There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
  2806. And I have moved some parameters into User_Arguments.
  2807. * EWebLauncher/main.c:
  2808. (_User_Arguments):
  2809. (_ELauncher):
  2810. (on_key_down):
  2811. (browserCreate):
  2812. (findThemePath):
  2813. (parseUserArguments):
  2814. (main):
  2815. 2012-09-13 Mark Lam <mark.lam@apple.com>
  2816. Unreviewed. Adding myself to the committers list.
  2817. * Scripts/webkitpy/common/config/committers.py:
  2818. 2012-09-13 Ryosuke Niwa <rniwa@webkit.org>
  2819. run-perf-tests output cryptic error when the config file is missing.
  2820. https://bugs.webkit.org/show_bug.cgi?id=96453
  2821. Reviewed by Tony Chang.
  2822. Add a special error message when a configuration file is missing.
  2823. Also update the help message of --source-json-path to signify the fact it specifies
  2824. the configuration file on performance tests bots.
  2825. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  2826. (PerfTestsRunner._parse_args):
  2827. (PerfTestsRunner._generate_and_show_results):
  2828. (PerfTestsRunner._merge_slave_config_json):
  2829. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  2830. (_test_run_with_json_output): Make upload to fail by default and assert the result
  2831. in the function so that we can return logs instead.
  2832. (_test_run_with_json_output.mock_upload_json):
  2833. (test_run_with_json_output):
  2834. (test_run_with_description):
  2835. (test_run_respects_no_results):
  2836. (test_run_with_slave_config_json):
  2837. (test_run_with_bad_slave_config_json):
  2838. (test_run_with_multiple_repositories):
  2839. 2012-09-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
  2840. Evas_Object* is a ref'ed structure, so tread it as such
  2841. https://bugs.webkit.org/show_bug.cgi?id=96659
  2842. Reviewed by Adam Barth.
  2843. Replace OwnPtr<Evas_Object> with RefPtr.
  2844. * DumpRenderTree/efl/ImageDiff.cpp:
  2845. (calculateDifference):
  2846. (printImageDifferences):
  2847. (readImageFromStdin):
  2848. (main):
  2849. 2012-09-13 Csaba Osztrogonác <ossy@webkit.org>
  2850. One more unreviewed trivial fix after r128399.
  2851. * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
  2852. 2012-09-13 Csaba Osztrogonác <ossy@webkit.org>
  2853. Unreviewed trivial fix after r128399.
  2854. * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
  2855. (getLatestSVNRevision):
  2856. (waitForSVNRevision):
  2857. 2012-09-13 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  2858. [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
  2859. https://bugs.webkit.org/show_bug.cgi?id=96366
  2860. Reviewed by Anders Carlsson.
  2861. Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
  2862. by calling shouldClose() on the FrameLoader.
  2863. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  2864. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  2865. (WTR::TestRunner::callShouldCloseOnWebView):
  2866. (WTR):
  2867. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  2868. (TestRunner):
  2869. 2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
  2870. Unreviewed, rolling out r128453.
  2871. http://trac.webkit.org/changeset/128453
  2872. https://bugs.webkit.org/show_bug.cgi?id=96681
  2873. Having tests use the same appcache directory leads to timeouts
  2874. (Requested by zdobersek on #webkit).
  2875. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  2876. (runTest):
  2877. * Scripts/webkitpy/layout_tests/port/gtk.py:
  2878. (GtkPort.setup_environ_for_server):
  2879. 2012-09-13 James Robinson <jamesr@chromium.org>
  2880. [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
  2881. https://bugs.webkit.org/show_bug.cgi?id=96678
  2882. Reviewed by Dirk Pranke.
  2883. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  2884. (.):
  2885. 2012-09-13 Rob Buis <rbuis@rim.com>
  2886. Unreviewed changes to watchlist.
  2887. - Add myself to BlackBerry bugs
  2888. * Scripts/webkitpy/common/config/watchlist:
  2889. 2012-09-13 Stephen Chenney <schenney@chromium.org>
  2890. Add an SVG entry to the watchlist
  2891. Unreviewed config change.
  2892. * Scripts/webkitpy/common/config/watchlist:
  2893. - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
  2894. - Added myself and pdr as watchers
  2895. 2012-09-13 Simon Hausmann <simon.hausmann@nokia.com>
  2896. [Qt] Make WebKit2 work on Windows with Qt 5
  2897. https://bugs.webkit.org/show_bug.cgi?id=76776
  2898. Reviewed by Tor Arne Vestbø.
  2899. WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
  2900. the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
  2901. that for the GL TextureMapper (it's only built when that feature is set).
  2902. * qmake/mkspecs/features/configure.prf:
  2903. 2012-09-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2904. [Qt] Ensure that QT is finalized before loading qt_module.prf
  2905. As qt_module.prf does dependency tracking based on the content of the
  2906. QT variable. The intermediate WebKit modules modify the variable in
  2907. their .pri files, so we have to ensure we've loaded all the modules
  2908. before loading qt_module.
  2909. Reviewed by Tor Arne Vestbø.
  2910. Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
  2911. * qmake/mkspecs/features/default_post.prf:
  2912. * qmake/mkspecs/features/webkit_modules.prf: Added.
  2913. 2012-09-13 Simon Hausmann <simon.hausmann@nokia.com>
  2914. [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
  2915. https://bugs.webkit.org/show_bug.cgi?id=96633
  2916. Reviewed by Csaba Osztrogonác.
  2917. WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
  2918. builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
  2919. It's the usual problem and the usual solution is to rename one of the conflicting files.
  2920. This patch chooses to rename DRT instead of WTR and MBR.
  2921. Fixed include order at the same time to match style guide.
  2922. * DumpRenderTree/qt/DumpRenderTree.pro:
  2923. * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
  2924. (messageHandler):
  2925. (isOption):
  2926. (takeOptionValue):
  2927. (printUsage):
  2928. (main):
  2929. 2012-09-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
  2930. The Script run-launcher should support -2 in combination with --efl
  2931. https://bugs.webkit.org/show_bug.cgi?id=96639
  2932. Reviewed by Simon Hausmann.
  2933. Support running the MiniBrowser then supplied -2 as argument.
  2934. * Scripts/run-launcher:
  2935. 2012-09-13 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  2936. Unreviewed, add my Intel email address to the list.
  2937. * Scripts/webkitpy/common/config/committers.py:
  2938. 2012-09-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2939. [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
  2940. Reviewed by Ossy.
  2941. * qmake/mkspecs/features/default_post.prf:
  2942. 2012-09-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
  2943. [EFL][DRT] Implement LayoutTestController::layerTreeAsText
  2944. https://bugs.webkit.org/show_bug.cgi?id=82294
  2945. Reviewed by Gyuyoung Kim.
  2946. Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
  2947. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  2948. (TestRunner::layerTreeAsText):
  2949. 2012-09-13 Zan Dobersek <zandobersek@gmail.com>
  2950. [GTK] Clear application cache between tests in DumpRenderTree
  2951. https://bugs.webkit.org/show_bug.cgi?id=96543
  2952. Reviewed by Philippe Normand.
  2953. Call the new DumpRenderTreeSupportGtk method to clear application cache
  2954. after each test.
  2955. Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
  2956. as well. Currently it points to a subdirectory in the layout tests results
  2957. directory. At least on the builders this ensures an empty cache directory
  2958. with each test run.
  2959. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  2960. (runTest):
  2961. * Scripts/webkitpy/layout_tests/port/gtk.py:
  2962. (GtkPort.setup_environ_for_server):
  2963. 2012-09-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2964. [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
  2965. Unless it's actually a dependency of the public QtWebKit API.
  2966. We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
  2967. files with their _PRIVATE equivivalent, but that's likely to break when
  2968. someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
  2969. clean up the variables in default_post.
  2970. This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
  2971. longer needed, as it was a workaround for the intermediate libraries ending
  2972. up in the prl file. And, since CONFIG -= staticlib was there to support
  2973. the explicitlib option, we can remove that too (as well as the exception
  2974. for gprof, since it would be empty). If gprof needs tweaks to always link
  2975. statically they should go in gprof.prf.
  2976. Reviewed by Simon Hausmann.
  2977. * qmake/mkspecs/features/default_post.prf:
  2978. * qmake/mkspecs/features/functions.prf:
  2979. 2012-09-13 Mario Sanchez Prada <msanchez@igalia.com>
  2980. [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
  2981. https://bugs.webkit.org/show_bug.cgi?id=96632
  2982. Reviewed by Carlos Garcia Campos.
  2983. Fix this by using atk_object_get_n_accessible_children instead of
  2984. calling getChildren() from childCount.
  2985. * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
  2986. (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
  2987. loop by using atk_object_get_n_accessible_children().
  2988. 2012-09-13 Simon Hausmann <simon.hausmann@nokia.com>
  2989. [Qt][Win] Enable USE(3D_GRAPHICS)
  2990. https://bugs.webkit.org/show_bug.cgi?id=90879
  2991. Reviewed by Kenneth Rohde Christiansen.
  2992. Enable it on Windows as well as on QNX (bug fixed).
  2993. * qmake/mkspecs/features/features.prf:
  2994. 2012-09-13 Simon Hausmann <simon.hausmann@nokia.com>
  2995. [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
  2996. https://bugs.webkit.org/show_bug.cgi?id=96359
  2997. Reviewed by Tor Arne Vestbø.
  2998. GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
  2999. lexer. The only viable alternative I could find on Windows that provides
  3000. binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
  3001. so let's use that one instead.
  3002. * Scripts/webkitdirs.pm:
  3003. (checkRequiredSystemConfig):
  3004. * qmake/mkspecs/features/default_pre.prf:
  3005. 2012-09-13 Simon Hausmann <simon.hausmann@nokia.com>
  3006. [Qt] Add configuration for production builds
  3007. https://bugs.webkit.org/show_bug.cgi?id=96607
  3008. Reviewed by Kenneth Rohde Christiansen.
  3009. Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
  3010. and enable all-in-one-files optimizations.
  3011. * qmake/mkspecs/features/production_build.prf: Added.
  3012. 2012-09-13 Simon Hausmann <simon.hausmann@nokia.com>
  3013. [Qt] GStreamer detection does not work when cross-compiling
  3014. https://bugs.webkit.org/show_bug.cgi?id=96608
  3015. Reviewed by Kenneth Rohde Christiansen.
  3016. When cross-compiling it is not safe to just use system(pkg-config),
  3017. because there is a high probability that it will find packages in the
  3018. host system instead of in the target one. Instead use qmake's new
  3019. packagesExist() function that takes care of this delicate aspect of
  3020. cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
  3021. PKG_CONFIG_LIBDIR accordingly.
  3022. * qmake/mkspecs/features/features.prf:
  3023. 2012-09-13 Christophe Dumez <christophe.dumez@intel.com>
  3024. [WK2][WTR] More efficient string handling in InjectedBundlePage
  3025. https://bugs.webkit.org/show_bug.cgi?id=96609
  3026. Reviewed by Kenneth Rohde Christiansen.
  3027. Update StringBuilder usage in InjectedBundlePage to follow
  3028. the latest recommandations for efficient string handling:
  3029. http://trac.webkit.org/wiki/EfficientStrings
  3030. This involves using appendLiteral() or appendNumber()
  3031. instead of append() whenever possible.
  3032. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  3033. (WTR::dumpPath):
  3034. (WTR::rangeToStr):
  3035. (WTR::styleDecToStr):
  3036. (WTR::frameToStr):
  3037. (WTR::dumpResourceURL):
  3038. (WTR):
  3039. (WTR::dumpFrameDescriptionSuitableForTestResult):
  3040. (WTR::dumpRequestDescriptionSuitableForTestResult):
  3041. (WTR::dumpResponseDescriptionSuitableForTestResult):
  3042. (WTR::dumpErrorDescriptionSuitableForTestResult):
  3043. (WTR::InjectedBundlePage::didReceiveIntentForFrame):
  3044. (WTR::InjectedBundlePage::registerIntentServiceForFrame):
  3045. (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
  3046. (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
  3047. (WTR::InjectedBundlePage::didCommitLoadForFrame):
  3048. (WTR::InjectedBundlePage::didFinishProgress):
  3049. (WTR::dumpFrameScrollPosition):
  3050. (WTR::dumpFrameText):
  3051. (WTR::dumpDescendantFramesText):
  3052. (WTR::InjectedBundlePage::didFinishLoadForFrame):
  3053. (WTR::InjectedBundlePage::didReceiveTitleForFrame):
  3054. (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
  3055. (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
  3056. (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
  3057. (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
  3058. (WTR::InjectedBundlePage::willSendRequestForFrame):
  3059. (WTR::InjectedBundlePage::didReceiveResponseForResource):
  3060. (WTR::InjectedBundlePage::didFinishLoadForResource):
  3061. (WTR::InjectedBundlePage::didFailLoadForResource):
  3062. (WTR::InjectedBundlePage::shouldCacheResponse):
  3063. (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
  3064. (WTR::InjectedBundlePage::willAddMessageToConsole):
  3065. (WTR::InjectedBundlePage::willSetStatusbarText):
  3066. (WTR::InjectedBundlePage::willRunJavaScriptAlert):
  3067. (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
  3068. (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
  3069. (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
  3070. (WTR::InjectedBundlePage::shouldBeginEditing):
  3071. (WTR::InjectedBundlePage::shouldEndEditing):
  3072. (WTR::InjectedBundlePage::shouldInsertNode):
  3073. (WTR::InjectedBundlePage::shouldInsertText):
  3074. (WTR::InjectedBundlePage::shouldDeleteRange):
  3075. (WTR::InjectedBundlePage::shouldChangeSelectedRange):
  3076. (WTR::InjectedBundlePage::shouldApplyStyle):
  3077. (WTR::InjectedBundlePage::didBeginEditing):
  3078. (WTR::InjectedBundlePage::didEndEditing):
  3079. (WTR::InjectedBundlePage::didChange):
  3080. (WTR::InjectedBundlePage::didChangeSelection):
  3081. (WTR::InjectedBundlePage::supportsFullScreen):
  3082. (WTR::InjectedBundlePage::enterFullScreenForElement):
  3083. (WTR::InjectedBundlePage::exitFullScreenForElement):
  3084. (WTR::InjectedBundlePage::beganEnterFullScreen):
  3085. (WTR::InjectedBundlePage::beganExitFullScreen):
  3086. (WTR::InjectedBundlePage::closeFullScreen):
  3087. (WTR::dumpBackForwardListItem):
  3088. (WTR::InjectedBundlePage::dumpBackForwardList):
  3089. 2012-09-13 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  3090. [Qt][WK2] Memory leaks in Qt's TestRunner
  3091. https://bugs.webkit.org/show_bug.cgi?id=96603
  3092. Reviewed by Csaba Osztrogonác.
  3093. Fix memory leaks in Qt's TestRunner code by adopting WKString
  3094. created with WKStringCreateWithUTF8CString().
  3095. * WebKitTestRunner/qt/TestControllerQt.cpp:
  3096. (WTR::TestController::initializeInjectedBundlePath):
  3097. (WTR::TestController::initializeTestPluginDirectory):
  3098. 2012-09-13 Zan Dobersek <zandobersek@gmail.com>
  3099. [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
  3100. https://bugs.webkit.org/show_bug.cgi?id=96506
  3101. Reviewed by Dirk Pranke.
  3102. Lower the timeout value to 6 seconds for release configuration and 12 seconds
  3103. for debug configuration. These are the same values the Chromium port uses.
  3104. Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
  3105. the layout tests under WebKit2 generally) requires more attention and gardening
  3106. than what the current effort produces.
  3107. The unit test is updated as well to test these changes.
  3108. * Scripts/webkitpy/layout_tests/port/gtk.py:
  3109. (GtkPort.default_timeout_ms):
  3110. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  3111. (GtkPortTest.test_default_timeout_ms):
  3112. (GtkPortTest.assertLinesEqual):
  3113. 2012-09-12 Csaba Osztrogonác <ossy@webkit.org>
  3114. Add SVN mirror handling feature to build.webkit.org
  3115. https://bugs.webkit.org/show_bug.cgi?id=85887
  3116. Reviewed by Dirk Pranke.
  3117. * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
  3118. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  3119. (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
  3120. (ConfigureBuild.start):
  3121. (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
  3122. (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
  3123. (Factory.__init__):
  3124. (BuildFactory.__init__):
  3125. (TestFactory.__init__):
  3126. (BuildAndTestFactory.__init__):
  3127. (BuildAndPerfTestFactory.__init__):
  3128. (BuildAndPerfTestWebKit2Factory.__init__):
  3129. (DownloadAndPerfTestFactory.__init__):
  3130. (DownloadAndPerfTestWebKit2Factory.__init__):
  3131. (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
  3132. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  3133. (SVNMirrorTest):
  3134. (SVNMirrorTest.setUp): Load config.json once at startup.
  3135. (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
  3136. (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
  3137. * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
  3138. (getLatestSVNRevision): Get the latest SVN revison from the given server.
  3139. (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
  3140. SVN revision is empty (force build triggered without revision) or the server is unavailable.
  3141. 2012-09-12 Kangil Han <kangil.han@samsung.com>
  3142. [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
  3143. https://bugs.webkit.org/show_bug.cgi?id=81606
  3144. Reviewed by Tim Horton.
  3145. 6 seconds is harsh for some jquery test cases.
  3146. Therefore, adjust the value to match DumpRenderTree.
  3147. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3148. (WTR):
  3149. 2012-09-12 KyungTae Kim <ktf.kim@samsung.com>
  3150. [EFL] Support download attribute feature
  3151. https://bugs.webkit.org/show_bug.cgi?id=96462
  3152. Reviewed by Gyuyoung Kim.
  3153. Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
  3154. and add "download,request" callback to the DumpRenderTree for EFL.
  3155. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  3156. (DumpRenderTreeChrome::createView):
  3157. (DumpRenderTreeChrome::onDownloadRequest):
  3158. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  3159. (DumpRenderTreeChrome):
  3160. * Scripts/webkitperl/FeatureList.pm:
  3161. 2012-09-12 Stephanie Lewis <slewis@apple.com>
  3162. Reduce parallism on the wk2 testers.
  3163. https://bugs.webkit.org/show_bug.cgi?id=95906
  3164. Reviewed by Dirk Pranke.
  3165. The wk2 testers on Mountain Lion are getting stuck and timing out. The problem appears to be due to
  3166. resource contention. Reducing the number of processes alleviates the issue.
  3167. Starting by reducing 25%.
  3168. * Scripts/webkitpy/layout_tests/port/mac.py:
  3169. (MacPort.default_child_processes):
  3170. 2012-09-12 Brady Eidson <beidson@apple.com>
  3171. Assert in NetscapePlugin::destroy() with async plugin init
  3172. <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
  3173. Reviewed by Anders Carlsson.
  3174. Expose NPN_Invoke to plug-in tests:
  3175. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  3176. (PluginTest::NPN_Invoke):
  3177. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  3178. (PluginTest):
  3179. Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
  3180. * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
  3181. (InvokeDestroysPluginWithinNPP_New):
  3182. (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
  3183. (InvokeDestroysPluginWithinNPP_New::NPP_New):
  3184. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  3185. 2012-09-12 Dirk Pranke <dpranke@chromium.org>
  3186. refactor TestExpectations tokenization slightly in preparation for the new syntax
  3187. https://bugs.webkit.org/show_bug.cgi?id=96564
  3188. Reviewed by Ojan Vafai.
  3189. This change changes how we will tokenize/lex the
  3190. TestExpectations files, in preparation for supporting both the
  3191. old syntax and the new one. This change by itself should be a
  3192. no-op.
  3193. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  3194. (TestExpectationParser._tokenize_line):
  3195. (TestExpectationParser):
  3196. (TestExpectationParser._tokenize_line_using_old_format):
  3197. (TestExpectationParser._tokenize_line_using_new_format):
  3198. 2012-09-12 Dirk Pranke <dpranke@chromium.org>
  3199. remove unused testexpectations editing code from webkitpy, garden-o-matic
  3200. https://bugs.webkit.org/show_bug.cgi?id=96562
  3201. Reviewed by Adam Barth.
  3202. This code was prototyped but never fully realized. Removing
  3203. until it reanimates :).
  3204. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  3205. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  3206. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
  3207. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
  3208. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  3209. (BuildCoverageExtrapolator.extrapolate_test_configurations):
  3210. (GardeningHTTPRequestHandler._run_webkit_patch):
  3211. (GardeningHTTPRequestHandler.ping):
  3212. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  3213. (BuildCoverageExtrapolatorTest.test_extrapolate):
  3214. (GardeningServerTest.test_rebaseline_new_port):
  3215. 2012-09-12 Lucas Forschler <lforschler@apple.com>
  3216. Remove unused bot, apple-xserve-1.
  3217. https://bugs.webkit.org/show_bug.cgi?id=96570
  3218. Reviewed by Stephanie Lewis.
  3219. * BuildSlaveSupport/build.webkit.org-config/config.json:
  3220. 2012-09-12 Xan Lopez <xlopez@igalia.com>
  3221. [GTK] We attempt to rebase documentation even if it's not present
  3222. https://bugs.webkit.org/show_bug.cgi?id=96553
  3223. Reviewed by Martin Robinson.
  3224. Do not make the documentation rebase step fatal. This allows make
  3225. install to succeed when there's no documentation generated.
  3226. * gtk/generate-gtkdoc:
  3227. 2012-09-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
  3228. Respect WEBKITOUTPUTDIR when running EFL tests
  3229. https://bugs.webkit.org/show_bug.cgi?id=96528
  3230. Reviewed by Dirk Pranke.
  3231. Expose user set WEBKITOUTPUTDIR to the web process.
  3232. * Scripts/webkitpy/layout_tests/port/driver.py:
  3233. (Driver._start): Add WEBKITOUTPUTDIR to the environment
  3234. of the web process and its potential jhbuild wrapper.
  3235. 2012-09-12 Dirk Pranke <dpranke@chromium.org>
  3236. webkitdirs: fix uname version handling for cygwin
  3237. https://bugs.webkit.org/show_bug.cgi?id=96436
  3238. Reviewed by Jon Honeycutt.
  3239. Newer versions of cygwin embed an additional version string
  3240. inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
  3241. Update the code to handle that.
  3242. * Scripts/webkitdirs.pm:
  3243. (setupAppleWinEnv):
  3244. 2012-09-12 Christophe Dumez <christophe.dumez@intel.com>
  3245. Regression(r128338): Broke Windows build
  3246. https://bugs.webkit.org/show_bug.cgi?id=96537
  3247. Unreviewed build fix.
  3248. Fix Apple-Win build by allocating array dynamically
  3249. since its size is not constant.
  3250. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3251. (WTR::stringArrayToJS):
  3252. 2012-09-12 Alex Sakhartchouk <alexst@chromium.org>
  3253. [chromium] Add a virtual test suite for fast/hidpi
  3254. https://bugs.webkit.org/show_bug.cgi?id=90192
  3255. Reviewed by Dirk Pranke.
  3256. Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
  3257. on the hardware accelerated path as the software path.
  3258. * DumpRenderTree/chromium/WebPreferences.cpp:
  3259. (WebPreferences::applyTo):
  3260. * Scripts/webkitpy/layout_tests/port/chromium.py:
  3261. (ChromiumPort.virtual_test_suites):
  3262. 2012-09-12 Adam Klein <adamk@chromium.org>
  3263. [chromium] Add content_browsertests to the flakiness dashboard
  3264. https://bugs.webkit.org/show_bug.cgi?id=96535
  3265. Reviewed by Ojan Vafai.
  3266. * TestResultServer/static-dashboards/dashboard_base.js:
  3267. 2012-09-12 Christophe Dumez <christophe.dumez@intel.com>
  3268. [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
  3269. https://bugs.webkit.org/show_bug.cgi?id=96496
  3270. Reviewed by Kenneth Rohde Christiansen.
  3271. Add implementation for originsWithApplicationCache to
  3272. WebKitTestRunner.
  3273. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3274. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3275. (WTR::stringArrayToJS):
  3276. (WTR):
  3277. (WTR::TestRunner::originsWithApplicationCache):
  3278. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3279. (TestRunner):
  3280. 2012-09-12 Simon Hausmann <simon.hausmann@nokia.com>
  3281. Fix Qt/Windows build with Python3
  3282. https://bugs.webkit.org/show_bug.cgi?id=96473
  3283. Reviewed by Csaba Osztrogonác.
  3284. In Python 3 print is a real function, so we must use parentheses around
  3285. the function parameters. This is backwards compatible with Python 2.
  3286. * Scripts/generate-win32-export-forwards:
  3287. 2012-09-12 Simon Hausmann <simon.hausmann@nokia.com>
  3288. Unreviewed trivial build fix for Qt/Windows after bug #96358.
  3289. As pointed out by Kevin, we should inject the "set PATH=..." statement
  3290. to add the GnuWin32 directory only if that directory actually exists.
  3291. * qmake/mkspecs/features/default_post.prf:
  3292. 2012-09-12 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  3293. [EFL] [WK2] Memory leaks in TestControllerEfl
  3294. https://bugs.webkit.org/show_bug.cgi?id=96525
  3295. Reviewed by Kenneth Rohde Christiansen.
  3296. Fix memory leaks in EFL's TestRunner code by adopting an allocation
  3297. of WKString created with WKStringCreateWithUTF8CString().
  3298. * WebKitTestRunner/efl/TestControllerEfl.cpp:
  3299. (WTR::TestController::initializeInjectedBundlePath):
  3300. (WTR::TestController::initializeTestPluginDirectory):
  3301. 2012-09-12 Christophe Dumez <christophe.dumez@intel.com>
  3302. [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
  3303. https://bugs.webkit.org/show_bug.cgi?id=96374
  3304. Reviewed by Kenneth Rohde Christiansen.
  3305. Implement support for dumpApplicationCacheDelegateCallbacks
  3306. and disallowIncreaseForApplicationCacheQuota in
  3307. WebKitTestRunner and properly dump the information
  3308. expected by the tests.
  3309. If the application cache quota is reached for a given
  3310. security origin, WebKitTestRunner will reset the quota
  3311. to its default value, unless intructed not to via
  3312. disallowIncreaseForApplicationCacheQuota().
  3313. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3314. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  3315. (WTR::InjectedBundlePage::InjectedBundlePage):
  3316. (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
  3317. (WTR):
  3318. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  3319. (InjectedBundlePage):
  3320. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3321. (WTR::TestRunner::TestRunner):
  3322. (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
  3323. (WTR):
  3324. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3325. (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
  3326. (TestRunner):
  3327. (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
  3328. (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
  3329. 2012-09-12 Jochen Eisinger <jochen@chromium.org>
  3330. [chromium] remove deprecated and unused sets import from chromium_android driver
  3331. https://bugs.webkit.org/show_bug.cgi?id=96485
  3332. Reviewed by Dirk Pranke.
  3333. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  3334. 2012-09-12 Zan Dobersek <zandobersek@gmail.com>
  3335. Flakiness dashboard doesn't recognize new Chromium Android test builder
  3336. https://bugs.webkit.org/show_bug.cgi?id=96523
  3337. Reviewed by Ojan Vafai.
  3338. Properly return 'ANDROID' as the Chromium platform for Android builders.
  3339. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  3340. (chromiumPlatform):
  3341. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  3342. (test):
  3343. 2012-09-12 Simon Hausmann <simon.hausmann@nokia.com>
  3344. [Qt] Build on Windows requires bison/flex in PATH
  3345. https://bugs.webkit.org/show_bug.cgi?id=96358
  3346. Reviewed by Tor Arne Vestbø.
  3347. The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
  3348. and Linux that is rarely a problem given how easily available the tools are. On Windows however
  3349. a separate installation of various GNU tools is required as the operating system doesn't come with
  3350. them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
  3351. the gnuwin32 directory of the qt5.git top-level repository.
  3352. This patch tries to detect the presence of those tools and prepends them to the PATH if found.
  3353. This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
  3354. PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
  3355. as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
  3356. updated with the new tool.
  3357. * Scripts/webkitdirs.pm:
  3358. (checkRequiredSystemConfig):
  3359. * qmake/mkspecs/features/default_post.prf:
  3360. 2012-09-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  3361. [Qt] Update build-jsc after r128174
  3362. Reviewed by Ossy.
  3363. * Scripts/build-jsc:
  3364. 2012-09-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  3365. [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
  3366. By hard-coding the names of the targets we defined we ended up just
  3367. redefining the previous target when using addStrictSubdirOrderBetween
  3368. more than once in a single project file.
  3369. We now embed the two base targets into the target names.
  3370. Reviewed by Simon Hausmann.
  3371. * qmake/mkspecs/features/functions.prf:
  3372. 2012-09-12 Philippe Liard <pliard@google.com>
  3373. Depend on {base,net} GYP targets rather than {base,net}_java.
  3374. https://bugs.webkit.org/show_bug.cgi?id=95690
  3375. Reviewed by Adam Barth.
  3376. {base,net}_java became 'private' targets on the Chromium side that
  3377. clients should not depend on (see
  3378. https://chromiumcodereview.appspot.com/10913083/).
  3379. This removes a bunch of trailing white spaces additionally in
  3380. TestWebkitAPI.gyp (which includes non-trailing white space changes).
  3381. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  3382. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  3383. 2012-09-12 Simon Hausmann <simon.hausmann@nokia.com>
  3384. [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
  3385. https://bugs.webkit.org/show_bug.cgi?id=96494
  3386. Reviewed by Tor Arne Vestbø.
  3387. WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
  3388. plugin process feature if we don't have NPAPI.
  3389. * qmake/mkspecs/features/features.prf:
  3390. 2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
  3391. Unreviewed, rolling out r128280.
  3392. http://trac.webkit.org/changeset/128280
  3393. https://bugs.webkit.org/show_bug.cgi?id=96498
  3394. it broke compilation on windows debug bot (Requested by loislo
  3395. on #webkit).
  3396. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3397. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  3398. (WTR::InjectedBundlePage::InjectedBundlePage):
  3399. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  3400. (InjectedBundlePage):
  3401. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3402. (WTR::TestRunner::TestRunner):
  3403. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3404. (TestRunner):
  3405. 2012-09-12 Simon Hausmann <simon.hausmann@nokia.com>
  3406. [Qt] Make it possible to build with "make release" and "make debug" on Windows
  3407. https://bugs.webkit.org/show_bug.cgi?id=96488
  3408. Reviewed by Tor Arne Vestbø.
  3409. A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
  3410. because there are no such targets. We want the generated sources to be independent from release
  3411. or debug build configurations, so it is sufficient to provide fake debug and release targets that
  3412. redirect to the same general-purpose target (first) of creating the derived sources.
  3413. * qmake/mkspecs/features/default_post.prf:
  3414. 2012-09-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
  3415. [EFL] Make DumpRenderTree smarter at finding the fonts
  3416. http://webkit.org/b/96281
  3417. Reviewed by Gyuyoung Kim.
  3418. Respect WEBKITOUTPUTDIR and expand the font dir from it.
  3419. Use CString consistently.
  3420. * DumpRenderTree/efl/FontManagement.cpp:
  3421. (buildPath):
  3422. (getCoreFontFiles):
  3423. (addFontDirectory):
  3424. (addFontFiles):
  3425. (getCustomBuildDir):
  3426. (getPlatformFontsPath):
  3427. (addFontsToEnvironment):
  3428. 2012-09-12 Christophe Dumez <christophe.dumez@intel.com>
  3429. [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
  3430. https://bugs.webkit.org/show_bug.cgi?id=96374
  3431. Reviewed by Kenneth Rohde Christiansen.
  3432. Implement support for dumpApplicationCacheDelegateCallbacks
  3433. and disallowIncreaseForApplicationCacheQuota in
  3434. WebKitTestRunner and properly dump the information
  3435. expected by the tests.
  3436. If the application cache quota is reached for a given
  3437. security origin, WebKitTestRunner will reset the quota
  3438. to its default value, unless intructed not to via
  3439. disallowIncreaseForApplicationCacheQuota().
  3440. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3441. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  3442. (WTR::InjectedBundlePage::InjectedBundlePage):
  3443. (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
  3444. (WTR):
  3445. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  3446. (InjectedBundlePage):
  3447. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3448. (WTR::TestRunner::TestRunner):
  3449. (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
  3450. (WTR):
  3451. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3452. (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
  3453. (TestRunner):
  3454. (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
  3455. (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
  3456. 2012-09-12 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  3457. [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
  3458. https://bugs.webkit.org/show_bug.cgi?id=96388
  3459. Reviewed by Kenneth Rohde Christiansen.
  3460. Exported TestRunner.workerThreadCount as readonly attribute.
  3461. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3462. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
  3463. (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
  3464. (WTR):
  3465. * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method.
  3466. (TestRunner):
  3467. 2012-09-12 Jochen Eisinger <jochen@chromium.org>
  3468. [chromium] Consume a user gesture when creating a new view.
  3469. https://bugs.webkit.org/show_bug.cgi?id=96373
  3470. Reviewed by Adam Barth.
  3471. * DumpRenderTree/chromium/WebViewHost.cpp:
  3472. (WebViewHost::createView):
  3473. 2012-09-12 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  3474. [WK2][WTR] Some of TestRunner special options are not reset before testing
  3475. https://bugs.webkit.org/show_bug.cgi?id=96384
  3476. Reviewed by Kenneth Rohde Christiansen.
  3477. Now values of the following special options are reset:
  3478. void setAcceptsEditing(in boolean value);
  3479. void setCloseRemainingWindowsWhenComplete(in boolean value);
  3480. void setXSSAuditorEnabled(in boolean value);
  3481. void setAllowFileAccessFromFileURLs(in boolean value);
  3482. void setPluginsEnabled(in boolean value);
  3483. void setPopupBlockingEnabled(in boolean value);
  3484. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  3485. (WTR::InjectedBundle::beginTesting):
  3486. 2012-09-11 Ryuan Choi <ryuan.choi@samsung.com>
  3487. [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
  3488. https://bugs.webkit.org/show_bug.cgi?id=96273
  3489. Reviewed by Gyuyoung Kim.
  3490. Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
  3491. in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
  3492. * WebKitTestRunner/CMakeLists.txt:
  3493. 2012-09-11 Dirk Pranke <dpranke@chromium.org>
  3494. [chromium] rename webkit_resources
  3495. https://bugs.webkit.org/show_bug.cgi?id=95874
  3496. Reviewed by James Robinson.
  3497. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  3498. 2012-09-11 Jochen Eisinger <jochen@chromium.org>
  3499. [chromium] don't include content shell builders in the garden-o-matic view
  3500. https://bugs.webkit.org/show_bug.cgi?id=96418
  3501. Reviewed by James Robinson.
  3502. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  3503. 2012-09-11 Adam Klein <adamk@chromium.org>
  3504. Garden-o-matic should ignore a wider variety of warnings in buildbot json
  3505. https://bugs.webkit.org/show_bug.cgi?id=96411
  3506. Reviewed by Adam Barth.
  3507. Previously only the exact string "warning" was treated as a warning
  3508. result. This patch treats any string with "warning" as a substring
  3509. as a warning (e.g., "warnings", as seen on the cr-win buildbots).
  3510. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  3511. (.):
  3512. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  3513. 2012-09-11 Marcelo Lira <marcelo.lira@openbossa.org>
  3514. Restore original value of mock scrollbars enabled in InternalSettings
  3515. https://bugs.webkit.org/show_bug.cgi?id=87680
  3516. Reviewed by Adam Barth.
  3517. Added backup support for mock scrollbars state in
  3518. InternalSettings::Backup, and removed support for these
  3519. from Qt's DumpRenderTree.
  3520. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  3521. (WebCore::WebPage::resetSettings):
  3522. * DumpRenderTree/qt/TestRunnerQt.cpp:
  3523. (TestRunner::setFrameFlatteningEnabled):
  3524. * DumpRenderTree/qt/TestRunnerQt.h:
  3525. (TestRunner):
  3526. 2012-09-11 Dan Bernstein <mitz@apple.com>
  3527. Fixed a bug where kill-old-processes failed to kill clang++.
  3528. Rubber-stamped by Alexey Proskuryakov.
  3529. * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
  3530. where it is passed as a regular expression to killall.
  3531. 2012-09-11 Philippe Liard <pliard@google.com>
  3532. Make sure that md5sum is not setup on non-Chromium Android platforms.
  3533. https://bugs.webkit.org/show_bug.cgi?id=96393
  3534. Reviewed by Adam Barth.
  3535. Previously md5sum was setup in ChromiumAndroidDriver's constructor
  3536. which is also invoked on non-Chromium Android platforms. The following patch
  3537. moves this logic to _startup_test() which is guaranteed to be invoked
  3538. only on Android.
  3539. This also updates the prompt unit test in chromium_android_unittest.py.
  3540. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  3541. (ChromiumAndroidDriver.__init__):
  3542. (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
  3543. (ChromiumAndroidDriver._setup_test):
  3544. 2012-09-11 Raphael Kubo da Costa <rakuco@webkit.org>
  3545. [EFL] Rewrite the EFL-related Find modules
  3546. https://bugs.webkit.org/show_bug.cgi?id=95237
  3547. Reviewed by Kenneth Rohde Christiansen.
  3548. * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
  3549. property and include all the Enlightenment Foundation Libraries
  3550. required by the target.
  3551. * EWebLauncher/CMakeLists.txt: Ditto.
  3552. * MiniBrowser/efl/CMakeLists.txt: Ditto.
  3553. * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
  3554. now that they are not added implicitly.
  3555. * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
  3556. property.
  3557. * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
  3558. property and include all the Enlightenment Foundation Libraries
  3559. required by the target.
  3560. 2012-09-11 Christophe Dumez <christophe.dumez@intel.com>
  3561. [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
  3562. https://bugs.webkit.org/show_bug.cgi?id=96379
  3563. Reviewed by Kenneth Rohde Christiansen.
  3564. Add implementation for setApplicationCacheOriginQuota
  3565. to WebKitTestRunner.
  3566. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3567. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3568. (WTR::TestRunner::setApplicationCacheOriginQuota):
  3569. (WTR):
  3570. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3571. (TestRunner):
  3572. 2012-09-11 Luciano Wolf <luciano.wolf@openbossa.org>
  3573. [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
  3574. https://bugs.webkit.org/show_bug.cgi?id=91988
  3575. Reviewed by Kenneth Rohde Christiansen.
  3576. Regular key events generated by Qt for the tab key fill both
  3577. keyCode and keyText, so we should do the same for our fake events.
  3578. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  3579. (WTR::EventSenderProxy::keyDown):
  3580. 2012-09-11 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  3581. [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
  3582. https://bugs.webkit.org/show_bug.cgi?id=96269
  3583. Reviewed by Kenneth Rohde Christiansen.
  3584. Exported missing testRunner.setSpatialNavigationEnabled() method.
  3585. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3586. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  3587. (WTR::InjectedBundle::beginTesting):
  3588. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3589. (WTR::TestRunner::setSpatialNavigationEnabled):
  3590. (WTR):
  3591. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3592. (TestRunner):
  3593. 2012-09-11 Philippe Liard <pliard@chromium.org>
  3594. Support LayoutTests on non-rooted devices for Chromium Android.
  3595. https://bugs.webkit.org/show_bug.cgi?id=95346
  3596. Reviewed by Dirk Pranke.
  3597. We were requiring root permissions to sync resource files with the
  3598. device by comparing host and device files' timestamp after we
  3599. synchronized the device and host clocks.
  3600. We now rely on md5sum provided by Chromium to handle data files
  3601. synchronization.
  3602. * Scripts/webkitpy/layout_tests/port/chromium.py:
  3603. (ChromiumPort._check_driver_build_up_to_date):
  3604. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  3605. (ChromiumAndroidDriver.__init__):
  3606. (ChromiumAndroidDriver._setup_test):
  3607. (ChromiumAndroidDriver._push_executable):
  3608. (ChromiumAndroidDriver._push_test_resources):
  3609. (ChromiumAndroidDriver._read_prompt):
  3610. 2012-09-11 Simon Hausmann <simon.hausmann@nokia.com>
  3611. [Qt] Fix output paths on Windows
  3612. Reviewed by Tor Arne Vestbø.
  3613. BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
  3614. DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
  3615. paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
  3616. incorrect here and instead for the calculation we should use forward slashes.
  3617. * qmake/mkspecs/features/default_pre.prf:
  3618. 2012-09-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  3619. [Qt] Fix passing of defines from the build system
  3620. We explicitly have to pass -DENABLE_FOO=0 for every single feature
  3621. that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
  3622. will add it's own defaults if the features are not defined.
  3623. At some point we might want to run a configure-test to inspect what
  3624. Platform.h will do, so we can sync up the build system's view of
  3625. the feature-defines with the compile-time situation.
  3626. Reviewed by Simon Hausmann.
  3627. * qmake/mkspecs/features/functions.prf:
  3628. 2012-09-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  3629. [Qt] Fix --qt option to build-webkit
  3630. Reviewed by Ossy.
  3631. * Scripts/webkitdirs.pm:
  3632. (buildQMakeProjects):
  3633. 2012-09-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  3634. [Qt] Add a configure step to the Qt build system
  3635. This allows building the Qt port using just 'qmake WebKit.pro'. Using
  3636. the build-webkit script is still supported, and will add slightly more
  3637. logic to the build, such as detecting the need for clean or incremental
  3638. builds.
  3639. Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
  3640. all things related to configuring the build, such as use/have/enable flags,
  3641. and these are translated to defines in default_post. Project files should
  3642. no longer check contains(DEFINES,...) to detect features, but use the new
  3643. enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
  3644. options have been translated into WEBKIT_CONFIG options as well, and can
  3645. be checked using build?().
  3646. Reviewed by Simon Hausmann.
  3647. * DumpRenderTree/qt/DumpRenderTree.pro:
  3648. * MiniBrowser/qt/MiniBrowser.pro:
  3649. * QtTestBrowser/QtTestBrowser.pro:
  3650. * Scripts/build-webkit:
  3651. * Scripts/webkitdirs.pm:
  3652. (qtFeatureDefaults):
  3653. (buildQMakeProjects):
  3654. * Tools.pro:
  3655. * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  3656. * WebKitTestRunner/InjectedBundle/Target.pri:
  3657. * WebKitTestRunner/Target.pri:
  3658. * qmake/.qmake.cache: Added.
  3659. * qmake/configure.pri: Removed.
  3660. * qmake/configure.pro: Removed.
  3661. * qmake/dump-features: Added.
  3662. * qmake/mkspecs/features/configure.prf: Added.
  3663. * qmake/mkspecs/features/default_post.prf:
  3664. * qmake/mkspecs/features/default_pre.prf:
  3665. * qmake/mkspecs/features/features.prf:
  3666. * qmake/mkspecs/features/features.pri:
  3667. * qmake/mkspecs/features/functions.prf:
  3668. * qmake/mkspecs/features/gprof.prf:
  3669. * qmake/mkspecs/features/mac/default_pre.prf:
  3670. * qmake/mkspecs/features/win32/default_pre.prf:
  3671. 2012-09-11 Christophe Dumez <christophe.dumez@intel.com>
  3672. [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
  3673. https://bugs.webkit.org/show_bug.cgi?id=96372
  3674. Reviewed by Kenneth Rohde Christiansen.
  3675. Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
  3676. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3677. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3678. (WTR::TestRunner::clearApplicationCacheForOrigin):
  3679. (WTR):
  3680. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3681. (TestRunner):
  3682. 2012-09-11 Peter Beverloo <peter@chromium.org>
  3683. Don't ignore .pak files when making an archive for Android
  3684. https://bugs.webkit.org/show_bug.cgi?id=96375
  3685. Reviewed by Jochen Eisinger.
  3686. The .pak files do need to be pushed to the device, which is currently
  3687. preventing the layout test runner from correctly pushing all files.
  3688. * BuildSlaveSupport/built-product-archive:
  3689. (archiveBuiltProduct):
  3690. 2012-09-11 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  3691. [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
  3692. https://bugs.webkit.org/show_bug.cgi?id=96256
  3693. Reviewed by Kenneth Rohde Christiansen.
  3694. Exported TestRunner::setMinimumTimerInterval() method.
  3695. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3696. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  3697. (WTR::InjectedBundle::beginTesting):
  3698. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3699. (WTR::TestRunner::setMinimumTimerInterval):
  3700. (WTR):
  3701. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3702. (TestRunner):
  3703. 2012-09-11 Tommy Widenflycht <tommyw@google.com>
  3704. MediaStream API: add RTCPeerConnection::onnegotiationneeded
  3705. https://bugs.webkit.org/show_bug.cgi?id=96097
  3706. Reviewed by Adam Barth.
  3707. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  3708. (MockWebRTCPeerConnectionHandler::addStream):
  3709. (MockWebRTCPeerConnectionHandler::removeStream):
  3710. 2012-09-11 Peter Beverloo <peter@chromium.org>
  3711. Recognize the "--chromium-android" argument in run-webkit-tests
  3712. https://bugs.webkit.org/show_bug.cgi?id=96369
  3713. Reviewed by Jochen Eisinger.
  3714. Chromium for the Android platform cannot determine the platform based on
  3715. the host itself, so we'll use the --chromium-android argument as the build
  3716. master passes to run-webkit-tests. Make sure the layout test runner
  3717. can pick the right port when doing so.
  3718. * Scripts/run-webkit-tests:
  3719. * Scripts/webkitpy/layout_tests/port/factory.py:
  3720. (port_options):
  3721. 2012-09-11 Simon Hausmann <simon.hausmann@nokia.com>
  3722. [QT] Fix build with newer qmake from Qt 5
  3723. Rubber-stamped by Tor Arne Vestbø.
  3724. Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
  3725. it with the use of QT_HOST_DATA/mkspecs.
  3726. Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
  3727. * Scripts/webkitdirs.pm:
  3728. (builtDylibPathForName):
  3729. (qtMakeCommand):
  3730. 2012-09-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  3731. [Qt] Remove Qt 4 syncqt, no longer needed
  3732. Reviewed by Simon Hausmann.
  3733. * qmake/syncqt-4.8: Removed.
  3734. 2012-09-11 Andras Becsi <andras.becsi@nokia.com>
  3735. [Qt][WK2] Fix the build with recent Qt5
  3736. https://bugs.webkit.org/show_bug.cgi?id=96283
  3737. Reviewed by Simon Hausmann.
  3738. We should not use deprecated Qt API because doing that results
  3739. in build failure since all the deprecated API was disabled
  3740. in qtbase (https://codereview.qt-project.org/#change,24890).
  3741. * DumpRenderTree/qt/main.cpp:
  3742. (main):
  3743. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  3744. (MiniBrowserApplication::notify):
  3745. * MiniBrowser/qt/raw/View.cpp:
  3746. (View::exposeEvent):
  3747. (main):
  3748. 2012-09-11 Christophe Dumez <christophe.dumez@intel.com>
  3749. WTR needs an implementation of applicationCacheDiskUsageForOrigin
  3750. https://bugs.webkit.org/show_bug.cgi?id=87188
  3751. Reviewed by Kenneth Rohde Christiansen.
  3752. Add implementation for applicationCacheDiskUsageForOrigin()
  3753. in WebKitTestRunner.
  3754. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3755. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3756. (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
  3757. (WTR):
  3758. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3759. (TestRunner):
  3760. 2012-09-10 Joanmarie Diggs <jdiggs@igalia.com>
  3761. Properly expose <legend> elements to ATs
  3762. https://bugs.webkit.org/show_bug.cgi?id=84137
  3763. Reviewed by Chris Fleizach.
  3764. Created a new WebCore Accessibility Role, LegendRole. Used it to map to
  3765. the expected platform role, ATK_ROLE_LABEL. Also established the needed
  3766. AtkRelation pair, label-for/labelled-by between the legend and fieldset.
  3767. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  3768. (roleToString): added "Legend" string for WebAccessibilityRoleLegend
  3769. 2012-09-10 Jer Noble <jer.noble@apple.com>
  3770. Unreviewed; rolling out r128081.
  3771. http://trac.webkit.org/changeset/128081
  3772. https://bugs.webkit.org/show_bug.cgi?id=96134
  3773. New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
  3774. * DumpRenderTree/TestRunner.cpp:
  3775. (TestRunner::TestRunner):
  3776. (TestRunner::staticFunctions):
  3777. * DumpRenderTree/TestRunner.h:
  3778. (TestRunner):
  3779. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  3780. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3781. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  3782. (WTR::InjectedBundlePage::InjectedBundlePage):
  3783. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  3784. (InjectedBundlePage):
  3785. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3786. (WTR::TestRunner::TestRunner):
  3787. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3788. (TestRunner):
  3789. 2012-09-10 Christophe Dumez <christophe.dumez@intel.com>
  3790. TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
  3791. https://bugs.webkit.org/show_bug.cgi?id=96205
  3792. Reviewed by Tony Chang.
  3793. _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
  3794. internally, which means that it would support only 1 TestExpectations file per port. This
  3795. is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
  3796. and efl-wk1 -> efl).
  3797. This patch makes _determine_port_from_expectations_path() call port.expectations_files()
  3798. instead so that all the ports TestExpectations are recognized. The ports are also
  3799. constructed twice, with "webkit_test_runner" option set to True and False so that we
  3800. retrieve the TestExpectations paths for both WebKit1 and WebKit2.
  3801. * Scripts/webkitpy/style/checkers/test_expectations.py:
  3802. (TestExpectationsChecker._determine_port_from_expectations_path):
  3803. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
  3804. (TestExpectationsTestCase.test_determine_port_from_expectations_path):
  3805. 2012-09-10 Ryuan Choi <ryuan.choi@samsung.com>
  3806. [WTR] Generated source files should include config.h
  3807. https://bugs.webkit.org/show_bug.cgi?id=96254
  3808. Reviewed by Benjamin Poulain.
  3809. Current coding style has encouraged to include config.h at the first position,
  3810. But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
  3811. this rule.
  3812. Therefore, this patch added it.
  3813. * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
  3814. (_generateImplementationFile):
  3815. 2012-09-10 Rick Byers <rbyers@chromium.org>
  3816. Add handling of new GestureTapCancel in DRT
  3817. https://bugs.webkit.org/show_bug.cgi?id=96183
  3818. Reviewed by Adam Barth.
  3819. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  3820. (TestWebPlugin::handleInputEvent):
  3821. 2012-09-10 Brady Eidson <beidson@apple.com>
  3822. Javascript in foreground tabs should not wait synchronously for plug-ins to load
  3823. <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
  3824. Reviewed by Geoff Garen.
  3825. Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
  3826. * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
  3827. (PluginObject):
  3828. (SlowNPPNew::PluginObject::PluginObject):
  3829. (SlowNPPNew::PluginObject::~PluginObject):
  3830. (SlowNPPNew::PluginObject::hasProperty):
  3831. (SlowNPPNew::PluginObject::getProperty):
  3832. (SlowNPPNew::NPP_GetValue):
  3833. (SlowNPPNew):
  3834. 2012-09-10 Tim Horton <timothy_horton@apple.com>
  3835. WKTR often reports an unresponsive WebProcess on Mac bots
  3836. https://bugs.webkit.org/show_bug.cgi?id=95906
  3837. Reviewed by Dan Bernstein.
  3838. Attempt to work around resource contention issues by increasing the NRWT
  3839. timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
  3840. * Scripts/webkitpy/layout_tests/port/base.py:
  3841. (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
  3842. * WebKitTestRunner/TestController.cpp:
  3843. (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
  3844. 2012-09-07 Jer Noble <jer.noble@apple.com>
  3845. <audio> and <video> should send Do Not Track when appropriate
  3846. https://bugs.webkit.org/show_bug.cgi?id=96134
  3847. Reviewed by Eric Carlson.
  3848. Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and
  3849. WTR. Add FrameLoaderClient client methods for retrieving that value.
  3850. * DumpRenderTree/TestRunner.cpp:
  3851. (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
  3852. (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
  3853. * DumpRenderTree/TestRunner.h:
  3854. (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
  3855. (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
  3856. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  3857. (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]):
  3858. Pass the question on to the TestRunner.
  3859. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  3860. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  3861. (WTR::InjectedBundlePage::InjectedBundlePage):
  3862. Add the setShouldSendDoNotTrackHTTPHeader client function.
  3863. (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
  3864. Pass the question on to the TestRunner.
  3865. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  3866. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  3867. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  3868. (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
  3869. (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
  3870. 2012-09-10 Ojan Vafai <ojan@chromium.org>
  3871. Make EFL bots work on the flakiness dashboard
  3872. https://bugs.webkit.org/show_bug.cgi?id=96164
  3873. Reviewed by Tony Chang.
  3874. Also, update outdated unittests that had started failing.
  3875. * TestResultServer/static-dashboards/builders.js:
  3876. (isWebkitTestRunner):
  3877. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  3878. (nonChromiumPlatform):
  3879. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  3880. (test):
  3881. 2012-09-10 Tommy Widenflycht <tommyw@google.com>
  3882. [chromium] MediaStream API: Remove the Descriptor postfix
  3883. https://bugs.webkit.org/show_bug.cgi?id=96268
  3884. Reviewed by Adam Barth.
  3885. After consideration I realized that there is no need whatsoever in using the Descriptor prefix
  3886. in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
  3887. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  3888. (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
  3889. (MockWebRTCPeerConnectionHandler::createOffer):
  3890. (MockWebRTCPeerConnectionHandler::createAnswer):
  3891. (MockWebRTCPeerConnectionHandler::setLocalDescription):
  3892. (MockWebRTCPeerConnectionHandler::setRemoteDescription):
  3893. (MockWebRTCPeerConnectionHandler::localDescription):
  3894. (MockWebRTCPeerConnectionHandler::remoteDescription):
  3895. (MockWebRTCPeerConnectionHandler::addICECandidate):
  3896. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  3897. (MockWebRTCPeerConnectionHandler):
  3898. 2012-09-10 Arnaud Renevier <a.renevier@sisa.samsung.com>
  3899. [Gtk] failure to build jhbuild dependencies with cups 1.6
  3900. https://bugs.webkit.org/show_bug.cgi?id=95991
  3901. Reviewed by Gustavo Noronha Silva.
  3902. Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
  3903. building with cups >= 1.6 [GNOME #670373].
  3904. * gtk/jhbuild.modules:
  3905. 2012-09-10 Christophe Dumez <christophe.dumez@intel.com>
  3906. [EFL][DRT] Encoding issue in printed console messages
  3907. https://bugs.webkit.org/show_bug.cgi?id=96263
  3908. Reviewed by Kenneth Rohde Christiansen.
  3909. Correctly handle CONSOLE messages that contain non-ascii
  3910. characters in EFL's DRT. We need to use String::fromUTF8()
  3911. to construct a WTF::String from a raw string.
  3912. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  3913. (onConsoleMessage):
  3914. 2012-09-10 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  3915. [WK2][WTR] User style sheet location should be reset before each test
  3916. https://bugs.webkit.org/show_bug.cgi?id=96262
  3917. Reviewed by Kenneth Rohde Christiansen.
  3918. User style sheet location is reset before each test now.
  3919. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  3920. (WTR::InjectedBundle::beginTesting):
  3921. 2012-09-10 Simon Hausmann <simon.hausmann@nokia.com>
  3922. Fix build of WTR with Qt on Windows
  3923. https://bugs.webkit.org/show_bug.cgi?id=96249
  3924. Reviewed by Kenneth Rohde Christiansen.
  3925. Windows loves to define min and max as macros, which beautifully
  3926. clashes in many places where min and max are used as variable or method
  3927. names. It can be convinced not to do this when min and max are already
  3928. define as macros (expanding to themselves). We have this kind of
  3929. workaround in config.h files all over WebKit and as it turns out when
  3930. building WTR with Qt on Windows we do end up with such a clash. Therefore
  3931. we need the same workaround.
  3932. * WebKitTestRunner/config.h:
  3933. 2012-09-10 Christophe Dumez <christophe.dumez@intel.com>
  3934. [WK2] New fast/forms/number/number-interactive-validation-required.html fails
  3935. https://bugs.webkit.org/show_bug.cgi?id=95936
  3936. Reviewed by Kenneth Rohde Christiansen.
  3937. Enable interactive form validation setting in WebKitTestRunner as
  3938. we are currently doing in DumpRenderTree. This is needed for some
  3939. tests to pass.
  3940. * WebKitTestRunner/TestController.cpp:
  3941. (WTR::TestController::resetStateToConsistentValues):
  3942. 2012-09-09 Zan Dobersek <zandobersek@gmail.com>
  3943. Clean up the code in XvfbDriver
  3944. https://bugs.webkit.org/show_bug.cgi?id=96202
  3945. Reviewed by Philippe Normand.
  3946. Changes:
  3947. - Remove unneeded imports,
  3948. - assign the _lock_file member variable when the display number is determined,
  3949. - no need for parentheses around a single string format argument,
  3950. - use FileSystem.exists method when checking if lock file is present as it
  3951. makes the intention much more clearer.
  3952. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  3953. (XvfbDriver._start):
  3954. (XvfbDriver.stop):
  3955. 2012-09-09 Patrick Gansterer <paroga@webkit.org>
  3956. Make the String initialization on the function side of String::number()
  3957. https://bugs.webkit.org/show_bug.cgi?id=95940
  3958. Reviewed by Benjamin Poulain.
  3959. * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
  3960. (testBoundaries):
  3961. (testNumbers):
  3962. 2012-09-09 Pierre Rossi <pierre.rossi@gmail.com>
  3963. [WK2] expose element rect for color input type
  3964. https://bugs.webkit.org/show_bug.cgi?id=91664
  3965. Reviewed by Simon Hausmann.
  3966. Update the QML logic in MiniBrowser to take advantage of this.
  3967. The picker size is now hardcoded and we try to place it below the
  3968. input element if possible.
  3969. * MiniBrowser/qt/qml/ColorChooser.qml:
  3970. 2012-09-08 Christophe Dumez <christophe.dumez@intel.com>
  3971. [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
  3972. https://bugs.webkit.org/show_bug.cgi?id=95329
  3973. Reviewed by Kenneth Rohde Christiansen.
  3974. Explicitely disable TabToLinks setting in WebKitTestRunner.
  3975. Tests override the "WebKitTabToLinksPreferenceKey" preference
  3976. to enable it.
  3977. * WebKitTestRunner/TestController.cpp:
  3978. (WTR::TestController::resetStateToConsistentValues):
  3979. 2012-09-08 Kenichi Ishibashi <bashi@chromium.org>
  3980. webkit.py gdb pretty printer can't print CString
  3981. https://bugs.webkit.org/show_bug.cgi?id=96068
  3982. Reviewed by Tony Chang.
  3983. Update WTFCStringPrinter to follow r126191.
  3984. * gdb/webkit.py:
  3985. (WTFCStringPrinter.to_string):
  3986. 2012-09-07 Benjamin Poulain <bpoulain@apple.com>
  3987. Rename the ustring() accessor to string()
  3988. https://bugs.webkit.org/show_bug.cgi?id=95919
  3989. Reviewed by Geoffrey Garen.
  3990. Update EFL's DRT.
  3991. Fix some string conversion that have been made useless
  3992. with recent changes.
  3993. * DumpRenderTree/efl/EventSender.cpp:
  3994. (keyPadNameFromJSValue):
  3995. (keyNameFromJSValue):
  3996. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  3997. (TestRunner::queueLoad):
  3998. (TestRunner::addOriginAccessWhitelistEntry):
  3999. (TestRunner::removeOriginAccessWhitelistEntry):
  4000. (TestRunner::setUserStyleSheetLocation):
  4001. (TestRunner::setValueForUser):
  4002. (TestRunner::elementDoesAutoCompleteForElementWithId):
  4003. (TestRunner::execCommand):
  4004. (TestRunner::findString):
  4005. (TestRunner::isCommandEnabled):
  4006. (TestRunner::clearApplicationCacheForOrigin):
  4007. (TestRunner::setDomainRelaxationForbiddenForURLScheme):
  4008. (TestRunner::pauseAnimationAtTimeOnElementWithId):
  4009. (TestRunner::pauseTransitionAtTimeOnElementWithId):
  4010. (toInt):
  4011. (TestRunner::overridePreference):
  4012. (TestRunner::addUserScript):
  4013. (TestRunner::addUserStyleSheet):
  4014. (TestRunner::evaluateInWebInspector):
  4015. (TestRunner::evaluateScriptInIsolatedWorld):
  4016. (TestRunner::setTextDirection):
  4017. * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
  4018. (LoadItem::invoke):
  4019. (LoadHTMLStringItem::invoke):
  4020. (ScriptItem::invoke):
  4021. 2012-09-06 Jeffrey Pfau <jpfau@apple.com>
  4022. Extend third-party storage blocking API to optionally allow blocking all storage
  4023. https://bugs.webkit.org/show_bug.cgi?id=95915
  4024. Reviewed by Brady Eidson.
  4025. Modified API test to use new revised API.
  4026. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  4027. (TestWebKitAPI::TEST):
  4028. 2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
  4029. AX: WebCore accessibility roles should be cross-platform
  4030. https://bugs.webkit.org/show_bug.cgi?id=94870
  4031. Reviewed by Chris Fleizach.
  4032. Add debug strings to Chromium for new accessibility roles.
  4033. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  4034. (roleToString):
  4035. 2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
  4036. AX: Chromium needs access to canvasHasFallbackContent
  4037. https://bugs.webkit.org/show_bug.cgi?id=96124
  4038. Reviewed by Chris Fleizach.
  4039. Distinguish between canvas roles with and without fallback
  4040. content on Chromium.
  4041. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  4042. (getRole):
  4043. 2012-09-07 Ojan Vafai <ojan@chromium.org>
  4044. Handle non-existant TestExpectations files gracefully
  4045. https://bugs.webkit.org/show_bug.cgi?id=96149
  4046. Reviewed by Eric Seidel.
  4047. Even when we get rid of Skipped files, we shouldn't have each port
  4048. require a TestExpectations file for each platform if it doesn't
  4049. need one.
  4050. * Scripts/webkitpy/layout_tests/port/base.py:
  4051. (Port.expectations_dict):
  4052. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  4053. (PortTest.test_nonexistant_expectations):
  4054. 2012-09-07 Tony Chang <tony@chromium.org>
  4055. Regression: check-webkit-style no longer checks TestExpectations for syntax errors
  4056. https://bugs.webkit.org/show_bug.cgi?id=96136
  4057. Reviewed by Ojan Vafai.
  4058. When we renamed the file to TestExpectations, it was no longer considered a text file so
  4059. it was no longer being checked. Since then, test_expectations_overrides() has been removed
  4060. from the port object, so I've removed that from the check. I'm not sure what it was
  4061. supposed to do.
  4062. * Scripts/webkitpy/style/checker.py:
  4063. (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
  4064. * Scripts/webkitpy/style/checkers/test_expectations.py:
  4065. (TestExpectationsChecker.check_test_expectations): Remove overrides param.
  4066. (TestExpectationsChecker.check): Remove overrides param.
  4067. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  4068. (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
  4069. 2012-09-07 Christophe Dumez <christophe.dumez@intel.com>
  4070. [EFL] Use same default minimum logical font size in DRT and WTR
  4071. https://bugs.webkit.org/show_bug.cgi?id=96116
  4072. Reviewed by Martin Robinson.
  4073. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4074. (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
  4075. logical font size to 9 to match the value used in WTR.
  4076. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  4077. (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
  4078. logical font size to 9 (default value in WK2)
  4079. 2012-09-07 Tommy Widenflycht <tommyw@google.com>
  4080. MediaStream API: add RTCPeerConnection::createAnswer
  4081. https://bugs.webkit.org/show_bug.cgi?id=96092
  4082. Reviewed by Adam Barth.
  4083. Expanding and enhancing MockWebRTCPeerConnectionHandler.
  4084. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  4085. (MockWebRTCPeerConnectionHandler::createOffer):
  4086. (MockWebRTCPeerConnectionHandler::createAnswer):
  4087. (MockWebRTCPeerConnectionHandler::setLocalDescription):
  4088. (MockWebRTCPeerConnectionHandler::setRemoteDescription):
  4089. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  4090. (MockWebRTCPeerConnectionHandler):
  4091. 2012-09-07 Dean Jackson <dino@apple.com>
  4092. Unreviewed changes to watchlist.
  4093. - Add new WebGL and Filters definitions
  4094. - Add myself to OpenGL bugs
  4095. * Scripts/webkitpy/common/config/watchlist:
  4096. 2012-09-07 Peter Beverloo <peter@chromium.org>
  4097. Actually trigger the Android Tester
  4098. https://bugs.webkit.org/show_bug.cgi?id=96118
  4099. Reviewed by Adam Barth.
  4100. * BuildSlaveSupport/build.webkit.org-config/config.json:
  4101. 2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
  4102. New time input needs accessibility
  4103. https://bugs.webkit.org/show_bug.cgi?id=96032
  4104. Reviewed by Chris Fleizach.
  4105. Add support for valueDescription for testing.
  4106. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  4107. (getValueDescription):
  4108. (AccessibilityUIElement::AccessibilityUIElement):
  4109. (AccessibilityUIElement::valueDescriptionGetterCallback):
  4110. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
  4111. (AccessibilityUIElement):
  4112. 2012-09-07 Peter Beverloo <peter@chromium.org>
  4113. Add the google-android-tests build slave to the master's config
  4114. https://bugs.webkit.org/show_bug.cgi?id=96113
  4115. Reviewed by Csaba Osztrogonác.
  4116. * BuildSlaveSupport/build.webkit.org-config/config.json:
  4117. 2012-09-07 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  4118. [WK2] [EFL] Set theme for WebKit2 API test runner
  4119. https://bugs.webkit.org/show_bug.cgi?id=96100
  4120. Reviewed by Kenneth Rohde Christiansen.
  4121. Set the theme generated by the build for the WebKit2 API test runner.
  4122. * TestWebKitAPI/PlatformEfl.cmake:
  4123. * TestWebKitAPI/efl/PlatformWebView.cpp:
  4124. (TestWebKitAPI::PlatformWebView::PlatformWebView):
  4125. 2012-09-07 Csaba Osztrogonác <ossy@webkit.org>
  4126. Unreviewed. Add Gábor Ballabás as contributor.
  4127. * Scripts/webkitpy/common/config/committers.py:
  4128. 2012-09-07 Zoltan Arvai <zarvai@inf.u-szeged.hu>
  4129. [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
  4130. https://bugs.webkit.org/show_bug.cgi?id=96078
  4131. Reviewed by Tor Arne Vestbø.
  4132. Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
  4133. * qmake/mkspecs/features/default_pre.prf:
  4134. 2012-09-07 Christophe Dumez <christophe.dumez@intel.com>
  4135. [EFL] Add TestExpectations file for efl-wk1
  4136. https://bugs.webkit.org/show_bug.cgi?id=96019
  4137. Reviewed by Gyuyoung Kim.
  4138. Update TestExpectations cascading for EFL port
  4139. so that we use efl-wk1 -> efl search paths
  4140. for WebKit1 EFL.
  4141. * Scripts/webkitpy/layout_tests/port/efl.py:
  4142. (EflPort._search_paths):
  4143. 2012-09-07 Zan Dobersek <zandobersek@gmail.com>
  4144. [NRWT] XvfbDriver should stop the Xvfb more aggressively
  4145. https://bugs.webkit.org/show_bug.cgi?id=95097
  4146. Reviewed by Dirk Pranke.
  4147. The Xvfb process is now killed when the XvfbDriver is stopping. Simply
  4148. terminating the process does not always work as expected, leading to timeouts
  4149. in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
  4150. as it's not removed by the killed Xvfb process.
  4151. Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
  4152. is tested in different circumstances - whether pixel tests are enabled or not,
  4153. with an arbitrary worker number or with an Xorg process already running on the system.
  4154. The stopping of the driver is tested by checking that the Xvfb process is truly killed
  4155. and then set to None.
  4156. * BuildSlaveSupport/kill-old-processes:
  4157. Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
  4158. is left running, potentially clogging up a display at a certain position.
  4159. * Scripts/webkitpy/common/system/executive_mock.py:
  4160. (MockExecutive.__init__):
  4161. The _running_pids is now a dictionary with process names as keys and pids
  4162. as values.
  4163. (MockExecutive.check_running_pid):
  4164. Check whether the passed-in pid is in the _running_pids dictionary's values.
  4165. (MockExecutive):
  4166. (MockExecutive.running_pids):
  4167. This method returns the list of all the process pids of which the name passes
  4168. through the process_name_filter.
  4169. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  4170. Use the Executive object of the port's host to check for running pids and open
  4171. new subprocesses or kill them throughout the class.
  4172. (XvfbDriver._start):
  4173. Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
  4174. start the server process after it's created.
  4175. (XvfbDriver.stop):
  4176. Now kills the Xvfb process instead of terminating it and waiting for it to close.
  4177. * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
  4178. (XvfbDriverTest):
  4179. (XvfbDriverTest.make_driver):
  4180. (XvfbDriverTest.assertDriverStartSuccessful):
  4181. (XvfbDriverTest.test_start_no_pixel_tests):
  4182. (XvfbDriverTest.test_start_pixel_tests):
  4183. (XvfbDriverTest.test_start_arbitrary_worker_number):
  4184. (XvfbDriverTest.test_start_existing_xorg_process):
  4185. (XvfbDriverTest.test_stop):
  4186. (XvfbDriverTest.test_stop.FakeXvfbProcess):
  4187. 2012-09-06 Peter Beverloo <peter@chromium.org>
  4188. Introduce the Chromium Android Release (Tests) bot
  4189. https://bugs.webkit.org/show_bug.cgi?id=95980
  4190. Reviewed by Adam Barth.
  4191. This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
  4192. which will be running layout tests on actual Android devices. Right now,
  4193. four Galaxy Nexus phones are attached.
  4194. * BuildSlaveSupport/build.webkit.org-config/config.json:
  4195. 2012-09-06 James Robinson <jamesr@chromium.org>
  4196. [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
  4197. https://bugs.webkit.org/show_bug.cgi?id=96007
  4198. Reviewed by Adrienne Walker.
  4199. Fixes initialization / settings code to use WebCompositorSupport.
  4200. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  4201. (main):
  4202. * DumpRenderTree/chromium/TestShell.cpp:
  4203. (TestShell::initialize):
  4204. (TestShell::setPerTilePaintingEnabled):
  4205. 2012-09-06 Christophe Dumez <christophe.dumez@intel.com>
  4206. [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
  4207. https://bugs.webkit.org/show_bug.cgi?id=95995
  4208. Reviewed by Kenneth Rohde Christiansen.
  4209. Provide proper implementation for PlatformWebView::windowFrame()
  4210. in EFL's WebKitTestRunner.
  4211. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
  4212. (WTR::PlatformWebView::windowFrame):
  4213. 2012-09-06 Fady Samuel <fsamuel@chromium.org>
  4214. Fix WTF.Lrint on 32-bit platforms
  4215. https://bugs.webkit.org/show_bug.cgi?id=96003
  4216. Reviewed by Benjamin Poulain.
  4217. Fixed failing WTF.Lrint test on 32-bit platforms.
  4218. * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
  4219. (TestWebKitAPI::TEST):
  4220. 2012-09-06 Tommy Widenflycht <tommyw@google.com>
  4221. MediaStream API: Add the local and remote description functionality to RTCPeerConnection
  4222. https://bugs.webkit.org/show_bug.cgi?id=95839
  4223. Reviewed by Adam Barth.
  4224. In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
  4225. up the task definitions a bit. There was no need to have them in the header file.
  4226. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  4227. (RTCSessionDescriptionRequestSuccededTask):
  4228. (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
  4229. (RTCSessionDescriptionRequestFailedTask):
  4230. (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
  4231. (RTCVoidRequestTask):
  4232. (RTCVoidRequestTask::RTCVoidRequestTask):
  4233. (MockWebRTCPeerConnectionHandler::createOffer):
  4234. (MockWebRTCPeerConnectionHandler::setLocalDescription):
  4235. (MockWebRTCPeerConnectionHandler::setRemoteDescription):
  4236. (MockWebRTCPeerConnectionHandler::localDescription):
  4237. (MockWebRTCPeerConnectionHandler::remoteDescription):
  4238. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  4239. (MockWebRTCPeerConnectionHandler):
  4240. 2012-09-06 Simon Hausmann <simon.hausmann@nokia.com>
  4241. [Qt] Fix build on Mac OS X 10.6
  4242. https://bugs.webkit.org/show_bug.cgi?id=95200
  4243. Reviewed by Tor Arne Vestbø.
  4244. The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
  4245. 10.7 and newer.
  4246. * qmake/mkspecs/features/features.prf:
  4247. 2012-09-06 Christophe Dumez <christophe.dumez@intel.com>
  4248. [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
  4249. https://bugs.webkit.org/show_bug.cgi?id=95973
  4250. Reviewed by Kenneth Rohde Christiansen.
  4251. Correctly map "addSelectionKey" to "Control" modifier
  4252. in WKTR's EventSender on other OSes than Mac OS X,
  4253. instead of mapping it to the "Meta" modifier.
  4254. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  4255. (WTR::parseModifier):
  4256. 2012-09-06 Balazs Kelemen <kbalazs@webkit.org>
  4257. [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
  4258. https://bugs.webkit.org/show_bug.cgi?id=95710
  4259. Reviewed by Dirk Pranke.
  4260. The stdout / stderr output can be None so make sure
  4261. we won't raise an exception in this case.
  4262. * Scripts/webkitpy/layout_tests/port/driver.py:
  4263. (Driver.run_test):
  4264. 2012-09-06 Christophe Dumez <christophe.dumez@intel.com>
  4265. [EFL] Sanitize URLs in EWebLauncher / Minibrowser
  4266. https://bugs.webkit.org/show_bug.cgi?id=95849
  4267. Reviewed by Kenneth Rohde Christiansen.
  4268. Sanitize URLs passed by the user as program
  4269. argument or typed in the URL bar in order to
  4270. be more tolerant.
  4271. * EWebLauncher/CMakeLists.txt:
  4272. * EWebLauncher/main.c:
  4273. (main):
  4274. * EWebLauncher/url_bar.c:
  4275. (_url_bar_url_get_with_protocol):
  4276. (on_urlbar_key_down):
  4277. * EWebLauncher/url_utils.c: Added.
  4278. (has_scheme):
  4279. (url_from_user_input): Add utility function to construct a
  4280. URL from user input.
  4281. * EWebLauncher/url_utils.h: Added.
  4282. * MiniBrowser/efl/CMakeLists.txt:
  4283. * MiniBrowser/efl/main.c:
  4284. (main):
  4285. 2012-09-06 Simon Hausmann <simon.hausmann@nokia.com>
  4286. [Qt] Various small Windows / MSVC build fixes
  4287. https://bugs.webkit.org/show_bug.cgi?id=95934
  4288. Reviewed by Kenneth Rohde Christiansen.
  4289. setFocus takes a boolean as argument: Don't try to implicitly convert
  4290. an enum to a boolean, MSVC doesn't like that. The intent here is to
  4291. enable focus, so just pass true.
  4292. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  4293. (WTR::PlatformWebView::focus):
  4294. 2012-09-06 Simon Hausmann <simon.hausmann@nokia.com>
  4295. [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
  4296. https://bugs.webkit.org/show_bug.cgi?id=95965
  4297. Reviewed by Tor Arne Vestbø.
  4298. Add ANGLE as a static library module to the Qt WebKit build system.
  4299. * qmake/mkspecs/features/default_post.prf:
  4300. * qmake/mkspecs/modules/angle.prf: Added.
  4301. 2012-09-06 Andras Becsi <andras.becsi@nokia.com>
  4302. [WK2] Make [Qt]ViewportHandler cross platform
  4303. https://bugs.webkit.org/show_bug.cgi?id=91257
  4304. Reviewed by Kenneth Rohde Christiansen.
  4305. Remove initial scale from viewport info item since it is
  4306. set to -1 after applied thus it does not hold any valuable
  4307. information.
  4308. * MiniBrowser/qt/qml/ViewportInfoItem.qml:
  4309. 2012-09-05 Tony Chang <tony@chromium.org>
  4310. [chromium] Remove dependency on webkit_user_agent
  4311. https://bugs.webkit.org/show_bug.cgi?id=95886
  4312. Reviewed by Adam Barth.
  4313. The code isn't used by DumpRenderTree.
  4314. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  4315. 2012-09-05 Rick Byers <rbyers@chromium.org>
  4316. Update chromium DumpRenderTree for new WebGestureEvent fields
  4317. https://bugs.webkit.org/show_bug.cgi?id=95573
  4318. Reviewed by James Robinson.
  4319. Update EventSender to write gesture details into the appropriate
  4320. type-specific WebGestureEvent fields.
  4321. * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
  4322. (EventSender::gestureEvent):
  4323. (EventSender::gestureFlingStart):
  4324. 2012-09-05 Dirk Pranke <dpranke@chromium.org>
  4325. NRWT lies about the number of tests that it's skipping when used with --repeat-each
  4326. https://bugs.webkit.org/show_bug.cgi?id=95789
  4327. Reviewed by Ojan Vafai.
  4328. Fix miscalculation in log message.
  4329. * Scripts/webkitpy/layout_tests/views/printing.py:
  4330. (Printer.print_found):
  4331. 2012-09-05 Kenichi Ishibashi <bashi@chromium.org>
  4332. Unreviewed, rolling out r127612, r127660, and r127664.
  4333. http://trac.webkit.org/changeset/127612
  4334. http://trac.webkit.org/changeset/127660
  4335. http://trac.webkit.org/changeset/127664
  4336. https://bugs.webkit.org/show_bug.cgi?id=95920
  4337. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  4338. (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
  4339. (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
  4340. (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
  4341. (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
  4342. (MockWebRTCPeerConnectionHandler::createOffer):
  4343. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  4344. (MockWebRTCPeerConnectionHandler):
  4345. (SuccessCallbackTask):
  4346. (FailureCallbackTask):
  4347. 2012-09-05 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  4348. Ignore-metrics includes scroll offsets.
  4349. https://bugs.webkit.org/show_bug.cgi?id=95845
  4350. Reviewed by Dirk Pranke.
  4351. Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
  4352. * Scripts/old-run-webkit-tests:
  4353. (stripMetrics):
  4354. * Scripts/webkitpy/layout_tests/port/driver.py:
  4355. (DriverOutput):
  4356. 2012-09-05 Zan Dobersek <zandobersek@gmail.com>
  4357. Unreviewed test fix.
  4358. Including a plugin source file into the build that was added in r127595.
  4359. * GNUmakefile.am:
  4360. 2012-09-05 Tommy Widenflycht <tommyw@google.com>
  4361. MediaStream API: Add the local and remote description functionality to RTCPeerConnection
  4362. https://bugs.webkit.org/show_bug.cgi?id=95839
  4363. Reviewed by Adam Barth.
  4364. In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
  4365. up the task definitions a bit. There was no need to have them in the header file.
  4366. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  4367. (RTCSessionDescriptionRequestSuccededTask):
  4368. (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
  4369. (RTCSessionDescriptionRequestFailedTask):
  4370. (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
  4371. (RTCVoidRequestTask):
  4372. (RTCVoidRequestTask::RTCVoidRequestTask):
  4373. (MockWebRTCPeerConnectionHandler::createOffer):
  4374. (MockWebRTCPeerConnectionHandler::setLocalDescription):
  4375. (MockWebRTCPeerConnectionHandler::setRemoteDescription):
  4376. (MockWebRTCPeerConnectionHandler::localDescription):
  4377. (MockWebRTCPeerConnectionHandler::remoteDescription):
  4378. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  4379. (MockWebRTCPeerConnectionHandler):
  4380. 2012-09-05 Kangil Han <kangil.han@samsung.com>
  4381. [EFL] Remove '+=' usage in String
  4382. https://bugs.webkit.org/show_bug.cgi?id=95808
  4383. Reviewed by Benjamin Poulain.
  4384. Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
  4385. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4386. (descriptionSuitableForTestResult):
  4387. 2012-09-05 Christophe Dumez <christophe.dumez@intel.com>
  4388. [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
  4389. https://bugs.webkit.org/show_bug.cgi?id=95842
  4390. Reviewed by Kenneth Rohde Christiansen.
  4391. Provide proper implementation for TestRunner::pathToLocalResource()
  4392. in EFL WKTR, identical to the one for DumpRenderTree.
  4393. Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
  4394. /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
  4395. are found my WebKitTestRunner.
  4396. * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
  4397. (WTR::TestRunner::pathToLocalResource):
  4398. 2012-09-05 Brady Eidson <beidson@apple.com>
  4399. Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
  4400. <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
  4401. Reviewed by Andy Estes.
  4402. Add a plug-in that always fails to initialize:
  4403. * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
  4404. (NPPNewFails):
  4405. (NPPNewFails::NPPNewFails):
  4406. (NPPNewFails::NPP_New):
  4407. Add it to all the project files:
  4408. * DumpRenderTree/DumpRenderTree.gypi:
  4409. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  4410. * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
  4411. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  4412. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  4413. 2012-09-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  4414. [Qt] Fix makefile race condition between derived sources and target
  4415. r121966 removed too much of the old qmake logic, including the rule
  4416. that ensured that qmake_all would not trigger dual runs of qmake --
  4417. one of the derived sources -qmake-all rule, and one for making the
  4418. derived sources.
  4419. We now follow a similar pattern as before, by introducing a custom
  4420. target that explicitly depends on the derived sources' qmake-all before
  4421. doing a manual run of make. That ensures a single qmake run for the derived
  4422. sources.
  4423. https://bugs.webkit.org/show_bug.cgi?id=93847
  4424. Reviewed by Csaba Osztrogonác.
  4425. * qmake/mkspecs/features/functions.prf:
  4426. 2012-09-05 Christophe Dumez <christophe.dumez@intel.com>
  4427. WKTR doesn't implement dumpWillCacheResponse()
  4428. https://bugs.webkit.org/show_bug.cgi?id=94607
  4429. Reviewed by Kenneth Rohde Christiansen.
  4430. Define shouldCacheResponse() callback in resource
  4431. load client and provide implementation for
  4432. dumpWillCacheResponse() in WebKitTestRunner.
  4433. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  4434. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  4435. (WTR::InjectedBundlePage::InjectedBundlePage):
  4436. (WTR::InjectedBundlePage::shouldCacheResponse):
  4437. (WTR):
  4438. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  4439. (InjectedBundlePage):
  4440. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  4441. (WTR::TestRunner::TestRunner):
  4442. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  4443. (WTR::TestRunner::dumpWillCacheResponse):
  4444. (WTR::TestRunner::shouldDumpWillCacheResponse):
  4445. (TestRunner):
  4446. 2012-09-05 Kaustubh Atrawalkar <kaustubh@motorola.com>
  4447. [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
  4448. https://bugs.webkit.org/show_bug.cgi?id=92735
  4449. Reviewed by Hajime Morita.
  4450. Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
  4451. * DumpRenderTree/TestRunner.cpp:
  4452. (TestRunner::staticFunctions):
  4453. * DumpRenderTree/TestRunner.h:
  4454. (TestRunner):
  4455. * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  4456. (TestRunner::addUserStyleSheet):
  4457. * DumpRenderTree/chromium/DRTTestRunner.cpp:
  4458. (DRTTestRunner::DRTTestRunner):
  4459. (DRTTestRunner::hasCustomPageSizeStyle):
  4460. * DumpRenderTree/chromium/DRTTestRunner.h:
  4461. (DRTTestRunner):
  4462. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  4463. * DumpRenderTree/gtk/TestRunnerGtk.cpp:
  4464. * DumpRenderTree/mac/TestRunnerMac.mm:
  4465. * DumpRenderTree/qt/TestRunnerQt.cpp:
  4466. (TestRunner::evaluateScriptInIsolatedWorld):
  4467. * DumpRenderTree/qt/TestRunnerQt.h:
  4468. (TestRunner):
  4469. * DumpRenderTree/win/TestRunnerWin.cpp:
  4470. * DumpRenderTree/wx/TestRunnerWx.cpp:
  4471. (TestRunner::abortModal):
  4472. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  4473. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  4474. (WTR):
  4475. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  4476. (TestRunner):
  4477. 2012-09-05 Simon Hausmann <simon.hausmann@nokia.com>
  4478. [Qt] Automate the use of AllInOne files in the Qt build
  4479. https://bugs.webkit.org/show_bug.cgi?id=95837
  4480. Reviewed by Tor Arne Vestbø.
  4481. New feature file that implements the all-in-one file automation by
  4482. adding the requested all-in-one files to SOURCES and removing the files
  4483. it includes from SOURCES.
  4484. * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
  4485. 2012-09-04 Tim Horton <timothy_horton@apple.com>
  4486. Have NRWT log more output when crash logs are missing
  4487. https://bugs.webkit.org/show_bug.cgi?id=95814
  4488. Reviewed by Dan Bernstein.
  4489. Log the stderr and stdout of the test, in order to provide slightly more
  4490. context when the WebProcess times out while running tests.
  4491. * Scripts/webkitpy/layout_tests/port/driver.py:
  4492. (Driver.run_test):
  4493. 2012-09-04 Xianzhu Wang <wangxianzhu@chromium.org>
  4494. [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
  4495. https://bugs.webkit.org/show_bug.cgi?id=95770
  4496. Reviewed by Adam Barth.
  4497. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  4498. (ChromiumAndroidDriver.__init__):
  4499. (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
  4500. (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
  4501. (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
  4502. (ChromiumAndroidDriver._push_executable):
  4503. (ChromiumAndroidDriver._push_fonts):
  4504. (ChromiumAndroidDriver._push_test_resources):
  4505. (ChromiumAndroidDriver._run_adb_command):
  4506. (ChromiumAndroidDriver._get_last_stacktrace):
  4507. (ChromiumAndroidDriver._get_crash_log):
  4508. (ChromiumAndroidDriver._start):
  4509. (ChromiumAndroidDriver._start_once):
  4510. (ChromiumAndroidDriver._start_once.deadlock_detector):
  4511. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  4512. (ChromiumAndroidDriverTest.test_get_crash_log):
  4513. 2012-09-04 Satish Sampath <satish@chromium.org>
  4514. Run git commands within the checkout directory
  4515. https://bugs.webkit.org/show_bug.cgi?id=95742
  4516. Reviewed by Eric Seidel.
  4517. git commands run from scm/git.py are sometimes run with cwd set to the
  4518. checkout_root and other times with whatever directory was the default cwd.
  4519. Instead all these should run with the checkout root set as the cwd
  4520. (except where we explicitly need a different path)
  4521. * Scripts/webkitpy/common/checkout/scm/git.py:
  4522. (Git._run_git):
  4523. (Git.find_checkout_root):
  4524. (Git.discard_local_commits):
  4525. (Git.local_commits):
  4526. (Git.working_directory_is_clean):
  4527. (Git.clean_working_directory):
  4528. (Git.add_list):
  4529. (Git.delete_list):
  4530. (Git.exists):
  4531. (Git._current_branch):
  4532. (Git._changes_files_for_commit):
  4533. (Git.revisions_changing_file):
  4534. (Git.svn_revision):
  4535. (Git._run_git_svn_find_rev):
  4536. (Git.contents_at_revision):
  4537. (Git.diff_for_file):
  4538. (Git.show_head):
  4539. (Git.committer_email_for_revision):
  4540. (Git.apply_reverse_diff):
  4541. (Git.revert_files):
  4542. (Git.commit_with_message):
  4543. (Git._commit_on_branch):
  4544. (Git.svn_commit_log):
  4545. (Git.last_svn_commit_log):
  4546. (Git.svn_blame):
  4547. (Git._branch_ref_exists):
  4548. (Git.delete_branch):
  4549. (Git.remote_merge_base):
  4550. (Git.commit_locally_with_message):
  4551. (Git.push_local_commits_to_server):
  4552. (Git.commit_ids_from_commitish_arguments):
  4553. (Git.commit_message_for_local_commit):
  4554. (Git.files_changed_summary_for_commit):
  4555. 2012-09-04 Tommy Widenflycht <tommyw@google.com>
  4556. MediaStream API: Add the async createOffer functionality to RTCPeerConnection
  4557. https://bugs.webkit.org/show_bug.cgi?id=95734
  4558. Reviewed by Adam Barth.
  4559. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  4560. (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
  4561. (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
  4562. (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
  4563. (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
  4564. (MockWebRTCPeerConnectionHandler::createOffer):
  4565. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  4566. (MockWebRTCPeerConnectionHandler):
  4567. (MockWebRTCPeerConnectionHandler::taskList):
  4568. (SuccessCallbackTask):
  4569. (FailureCallbackTask):
  4570. 2012-09-04 Xianzhu Wang <wangxianzhu@chromium.org>
  4571. [Chromium-Android] Output time and thread info in crash log
  4572. https://bugs.webkit.org/show_bug.cgi?id=95768
  4573. Reviewed by Adam Barth.
  4574. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  4575. (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
  4576. 2012-09-04 Tommy Widenflycht <tommyw@google.com>
  4577. MediaStream API: Change the MediaStreamTrackList track added/removed signaling
  4578. https://bugs.webkit.org/show_bug.cgi?id=95721
  4579. Reviewed by Adam Barth.
  4580. * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
  4581. (MockWebMediaStreamCenter::didAddMediaStreamTrack):
  4582. (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
  4583. * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
  4584. (MockWebMediaStreamCenter):
  4585. 2012-09-04 Tony Chang <tony@chromium.org>
  4586. Elide test names when running new-run-webkit-tests
  4587. https://bugs.webkit.org/show_bug.cgi?id=95626
  4588. Reviewed by Dirk Pranke.
  4589. When the test name exceeds the number of terminal columns, it leaves
  4590. text on the screen. Avoid this by eliding the test name when running
  4591. tests. This is similar to what ninja does when compiling.
  4592. * Scripts/webkitpy/layout_tests/views/metered_stream.py:
  4593. (MeteredStream):
  4594. (MeteredStream.number_of_columns): Helper method to get number of
  4595. terminal columns. Won't work on Win32 python, but meh.
  4596. * Scripts/webkitpy/layout_tests/views/printing.py:
  4597. (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
  4598. because stderr appears to be ascii only.
  4599. (Printer.print_started_test): Route through _test_status_line.
  4600. (Printer.print_finished_test): Route through _test_status_line.
  4601. (Printer._print_test_trace): Route through _test_status_line.
  4602. (Printer._print_baseline): Route through _test_status_line.
  4603. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  4604. (test_test_status_line): Test for _test_status_line.
  4605. 2012-09-04 Martin Robinson <mrobinson@igalia.com>
  4606. [GTK] Print API missing documentation when generating gtkdoc
  4607. https://bugs.webkit.org/show_bug.cgi?id=95703
  4608. Reviewed by Carlos Garcia Campos.
  4609. Print out API missing documentation when generating gtkdoc. This makes it
  4610. easier to fix documentation errors.
  4611. * gtk/generate-gtkdoc:
  4612. (print_missing_api): Added.
  4613. (generate_doc): Inline the rebase step, since it now reports an error
  4614. when you try to rebase without generating documentation first.
  4615. * gtk/gtkdoc.py:
  4616. (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
  4617. generating documentation first to enable a small cleanup at the caller.
  4618. (GTKDoc.api_missing_documentation): Added.
  4619. 2012-09-04 Vincent Scheib <scheib@chromium.org>
  4620. [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
  4621. https://bugs.webkit.org/show_bug.cgi?id=95628
  4622. Reviewed by James Robinson.
  4623. Future tests need the ability to respond asynchronously that
  4624. pointer lock requests have been accepted or rejected. This patch
  4625. adds the following:
  4626. testRunner.setPointerLockWillRespondAsynchronously();
  4627. testRunner.didAcquirePointerLock();
  4628. testRunner.didNotAcquirePointerLock();
  4629. Tested in existing test:
  4630. pointerlockchange-pointerlockerror-events.html
  4631. * DumpRenderTree/chromium/DRTTestRunner.cpp:
  4632. (DRTTestRunner::DRTTestRunner):
  4633. (DRTTestRunner::didAcquirePointerLock):
  4634. (DRTTestRunner::didNotAcquirePointerLock):
  4635. (DRTTestRunner::setPointerLockWillRespondAsynchronously):
  4636. * DumpRenderTree/chromium/DRTTestRunner.h:
  4637. (DRTTestRunner):
  4638. * DumpRenderTree/chromium/WebViewHost.cpp:
  4639. (WebViewHost::requestPointerLock):
  4640. (WebViewHost::didAcquirePointerLock):
  4641. (WebViewHost::didNotAcquirePointerLock):
  4642. * DumpRenderTree/chromium/WebViewHost.h:
  4643. (WebViewHost):
  4644. (WebViewHost::setPointerLockWillRespondAsynchronously):
  4645. 2012-09-04 Ojan Vafai <ojan@chromium.org>
  4646. Move content shell bots to their own builder group
  4647. https://bugs.webkit.org/show_bug.cgi?id=95765
  4648. Reviewed by Adam Barth.
  4649. In their current state of instability, they add too much noise. Once they get more stable,
  4650. we can add them back to the regular group or just have them replace the other bots.
  4651. Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
  4652. * TestResultServer/static-dashboards/builders.js:
  4653. (isWebkitTestRunner):
  4654. (isChromiumContentShellTestRunner):
  4655. (isChromiumWebkitTipOfTreeTestRunner):
  4656. (loadBuildersList):
  4657. 2012-09-03 Ryuan Choi <ryuan.choi@samsung.com>
  4658. [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
  4659. https://bugs.webkit.org/show_bug.cgi?id=95689
  4660. Reviewed by Kenneth Rohde Christiansen.
  4661. In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
  4662. So, there are bugs that key events are always generated in url bar although
  4663. the user clicked the web view.
  4664. This patch recovers the focus of the web view when left button is pressed and
  4665. adds for MiniBrowser to toggle the focus when middle button is pressed
  4666. like EWebLauncher already did.
  4667. * EWebLauncher/main.c:
  4668. (on_mouse_down):
  4669. * MiniBrowser/efl/main.c:
  4670. (on_mouse_down):
  4671. (browserCreate):
  4672. 2012-09-03 Tao Bai <michaelbai@chromium.org>
  4673. Added ANDROID_GDBSERVER definition for Ant
  4674. https://bugs.webkit.org/show_bug.cgi?id=95265
  4675. Reviewed by Adam Barth.
  4676. ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
  4677. is only used for finding the gdbserver.
  4678. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  4679. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  4680. 2012-09-03 Tommy Widenflycht <tommyw@google.com>
  4681. MediaStream API: Add Ice-related functionality to RTCPeerConnection
  4682. https://bugs.webkit.org/show_bug.cgi?id=95565
  4683. Reviewed by Adam Barth.
  4684. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  4685. (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
  4686. (MockWebRTCPeerConnectionHandler::updateICE):
  4687. (MockWebRTCPeerConnectionHandler::addICECandidate):
  4688. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  4689. (MockWebRTCPeerConnectionHandler):
  4690. 2012-09-03 Christophe Dumez <christophe.dumez@intel.com>
  4691. [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
  4692. https://bugs.webkit.org/show_bug.cgi?id=95670
  4693. Reviewed by Kenneth Rohde Christiansen.
  4694. Fix layout issues related to the URL bar in Minibrowser
  4695. and EWebLauncher when the window is resized.
  4696. The URL bar was not resized accordingly and the Web
  4697. page was moved behing the URL bar, hiding part of it.
  4698. * EWebLauncher/main.c:
  4699. (on_ecore_evas_resize):
  4700. (closeWindow):
  4701. * EWebLauncher/url_bar.c:
  4702. (url_bar_width_set):
  4703. (url_bar_add):
  4704. * EWebLauncher/url_bar.h:
  4705. * MiniBrowser/efl/main.c:
  4706. (on_ecore_evas_resize):
  4707. (main):
  4708. 2012-09-01 Xianzhu Wang <wangxianzhu@chromium.org>
  4709. [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
  4710. https://bugs.webkit.org/show_bug.cgi?id=95605
  4711. Reviewed by Dirk Pranke.
  4712. Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
  4713. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  4714. (ChromiumAndroidPort.check_sys_deps):
  4715. (ChromiumAndroidPort.expectations_files):
  4716. (ChromiumAndroidPort.clean_up_test_run):
  4717. 2012-09-01 Joanmarie Diggs <jdiggs@igalia.com>
  4718. [Gtk] Incorrect/unexpected characters in the text of certain accessibles
  4719. https://bugs.webkit.org/show_bug.cgi?id=95180
  4720. Reviewed by Chris Fleizach.
  4721. The bug that was fixed stood in the way of fully implementing stringValue().
  4722. Testing that the bug is fixed requires stringValue() to be fully implemented
  4723. and object replacement characters to be printable.
  4724. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  4725. (replaceCharactersForResults): New method which turns object replacement
  4726. characters into "<obj>" so that the characters can be properly shown in
  4727. Layout Test results. Also turns "\n" into "<\\n>" so that printing the
  4728. accessible text of a single object in the accessible tree doesn't mess up
  4729. the readibility of the results.
  4730. (AccessibilityUIElement::stringValue): Remove the code that immediately
  4731. returned upon encountering an object of ATK_ROLE_PANEL and call the new
  4732. replaceCharactersForResults() prior to returning the accessible string
  4733. value.
  4734. 2012-09-01 Tommy Widenflycht <tommyw@google.com>
  4735. MediaStream API: Add MediaStream management to RTCPeerConnection
  4736. https://bugs.webkit.org/show_bug.cgi?id=95543
  4737. Reviewed by Adam Barth.
  4738. Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
  4739. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  4740. (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
  4741. (MockWebRTCPeerConnectionHandler::addStream):
  4742. (MockWebRTCPeerConnectionHandler::removeStream):
  4743. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  4744. (MockWebRTCPeerConnectionHandler):
  4745. 2012-08-31 Tony Chang <tony@chromium.org>
  4746. Remove ENABLE_CSS3_FLEXBOX compile time flag
  4747. https://bugs.webkit.org/show_bug.cgi?id=95382
  4748. Reviewed by Ojan Vafai.
  4749. Everyone is already enabling this by default and the spec has stablized.
  4750. * Scripts/webkitperl/FeatureList.pm:
  4751. * qmake/mkspecs/features/features.pri:
  4752. 2012-08-31 Pratik Solanki <psolanki@apple.com>
  4753. objc_msgSend and IMP should be cast appropriately before using
  4754. https://bugs.webkit.org/show_bug.cgi?id=95242
  4755. Reviewed by Benjamin Poulain.
  4756. Fix for older compilers. Pass id as the return type to the template
  4757. instead of relying on default type.
  4758. * DumpRenderTree/mac/DumpRenderTree.mm:
  4759. (drt_NSFontManager_availableFontFamilies):
  4760. * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  4761. (WTR::wtr_NSFontManager_availableFontFamilies):
  4762. 2012-08-31 Zan Dobersek <zandobersek@gmail.com>
  4763. nrwt: use scm instead of calling svn directly to get the revision in json results generator
  4764. https://bugs.webkit.org/show_bug.cgi?id=89616
  4765. Reviewed by Eric Seidel.
  4766. Add the new 'executive' optional function argument to the SCM.in_working_directory
  4767. class method. This way we get to reuse an Executive instance which is necessary in testing
  4768. when we're operating with a mock version of the object.
  4769. In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
  4770. the SCMDetector with the generator's FileSystem and Executive instances.
  4771. * Scripts/webkitpy/common/checkout/scm/detection.py:
  4772. (SCMDetector.detect_scm_system):
  4773. * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
  4774. (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
  4775. Executive output and test it against expected output.
  4776. * Scripts/webkitpy/common/checkout/scm/git.py:
  4777. (Git.in_working_directory):
  4778. * Scripts/webkitpy/common/checkout/scm/scm.py:
  4779. (SCM.in_working_directory):
  4780. * Scripts/webkitpy/common/checkout/scm/svn.py:
  4781. (SVN.in_working_directory):
  4782. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  4783. (JSONResultsGeneratorBase.__init__):
  4784. (JSONResultsGeneratorBase._get_svn_revision):
  4785. 2012-08-31 Jon Lee <jonlee@apple.com>
  4786. [Tests] Add basic tests to http/tests/notifications
  4787. https://bugs.webkit.org/show_bug.cgi?id=95493
  4788. <rdar://problem/12209303>
  4789. Reviewed by Alexey Proskuryakov.
  4790. Add permission request support for WTR.
  4791. * WebKitTestRunner/TestController.cpp:
  4792. (WTR::TestController::initialize):
  4793. (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
  4794. * WebKitTestRunner/TestController.h:
  4795. (TestController):
  4796. 2012-08-31 Jon Lee <jonlee@apple.com>
  4797. [DRT] Make simulating a web click on a notification a queued task
  4798. https://bugs.webkit.org/show_bug.cgi?id=95546
  4799. <rdar://problem/12214170>
  4800. Reviewed by Alexey Proskuryakov.
  4801. Making the web click happen asynchronously better mimics user interaction with the platform.
  4802. * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
  4803. (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
  4804. not set.
  4805. * DumpRenderTree/mac/DumpRenderTree.mm:
  4806. (dump): Assert that the flag is not set.
  4807. * DumpRenderTree/mac/TestRunnerMac.mm:
  4808. (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
  4809. notification. In the case where the block gets executed after the flag has been unset, we avoid
  4810. performing the click.
  4811. 2012-08-31 Balazs Kelemen <kbalazs@webkit.org>
  4812. [Qt] ImageDiff output is not in the expected form if image dimensions differ
  4813. https://bugs.webkit.org/show_bug.cgi?id=95575
  4814. Reviewed by Csaba Osztrogonác.
  4815. Output 100% difference in the case of differing image dimensions so
  4816. the test harness knows that we won't produce any output further.
  4817. This matches the behavior of other ports.
  4818. * DumpRenderTree/qt/ImageDiff.cpp:
  4819. (main):
  4820. 2012-08-31 Sheriff Bot <webkit.review.bot@gmail.com>
  4821. Unreviewed, rolling out r127261.
  4822. http://trac.webkit.org/changeset/127261
  4823. https://bugs.webkit.org/show_bug.cgi?id=95572
  4824. This patch depends on other build fixes (see blockers of bug
  4825. 95466) which should land first (Requested by milian on
  4826. #webkit).
  4827. * qmake/mkspecs/features/features.prf:
  4828. 2012-08-31 Milian Wolff <milian.wolff@kdab.com>
  4829. [Qt] Support WebKit2/QML on QNX
  4830. https://bugs.webkit.org/show_bug.cgi?id=95466
  4831. Reviewed by Noam Rosenthal.
  4832. Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
  4833. this should finally work now.
  4834. * qmake/mkspecs/features/features.prf:
  4835. 2012-08-30 Xianzhu Wang <wangxianzhu@chromium.org>
  4836. [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
  4837. https://bugs.webkit.org/show_bug.cgi?id=95400
  4838. Reviewed by Dirk Pranke.
  4839. WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
  4840. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  4841. (ChromiumAndroidPort.skipped_layout_tests):
  4842. 2012-08-30 Gustavo Noronha Silva <gns@gnome.org>
  4843. [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
  4844. https://bugs.webkit.org/show_bug.cgi?id=95499
  4845. Unreviewed. One more fix to avoid trying to run the empty string.
  4846. * Scripts/webkitdirs.pm:
  4847. (buildAutotoolsProject):
  4848. 2012-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
  4849. Unreviewed, rolling out r127171.
  4850. http://trac.webkit.org/changeset/127171
  4851. https://bugs.webkit.org/show_bug.cgi?id=95505
  4852. testRunner does not need dumpWebNotificationCallbacks().
  4853. (Requested by jonlee on #webkit).
  4854. * DumpRenderTree/TestRunner.cpp:
  4855. (TestRunner::TestRunner):
  4856. (TestRunner::staticFunctions):
  4857. * DumpRenderTree/TestRunner.h:
  4858. (TestRunner):
  4859. * DumpRenderTree/mac/MockWebNotificationProvider.mm:
  4860. (-[MockWebNotificationProvider webView:didShowNotification:]):
  4861. (-[MockWebNotificationProvider webView:didClickNotification:]):
  4862. (-[MockWebNotificationProvider webView:didCloseNotifications:]):
  4863. * DumpRenderTree/mac/UIDelegate.mm:
  4864. (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
  4865. 2012-08-30 Pratik Solanki <psolanki@apple.com>
  4866. objc_msgSend and IMP should be cast appropriately before using
  4867. https://bugs.webkit.org/show_bug.cgi?id=95242
  4868. Reviewed by Benjamin Poulain.
  4869. Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
  4870. to a function pointer with right types when calling objc_msgSend and an
  4871. IMP method directly.
  4872. * DumpRenderTree/mac/DumpRenderTree.mm:
  4873. (drt_NSFontManager_availableFontFamilies):
  4874. * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  4875. (WTR::wtr_NSFontManager_availableFontFamilies):
  4876. 2012-08-30 Benjamin Poulain <bpoulain@apple.com>
  4877. Replace JSC::UString by WTF::String
  4878. https://bugs.webkit.org/show_bug.cgi?id=95271
  4879. Reviewed by Geoffrey Garen.
  4880. Get rid of UString.
  4881. * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
  4882. * gdb/webkit.py:
  4883. (WTFStringPrinter.to_string):
  4884. (JSCIdentifierPrinter.to_string):
  4885. (JSCJSStringPrinter.to_string):
  4886. (add_pretty_printers):
  4887. 2012-08-30 Dirk Pranke <dpranke@chromium.org>
  4888. nrwt should have TestExpectations everywhere we have Skipped files for apple ports
  4889. https://bugs.webkit.org/show_bug.cgi?id=95495
  4890. Reviewed by Ojan Vafai.
  4891. This is a follow-on to bug 95370 that adds in support for
  4892. platform/wk2/TestExpectations and
  4893. platform/{mac,win}-$version/TestExpectations.
  4894. * Scripts/webkitpy/layout_tests/port/apple.py:
  4895. (ApplePort.expectations_files):
  4896. * Scripts/webkitpy/layout_tests/port/base.py:
  4897. (Port._skipped_file_search_paths):
  4898. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  4899. (MacTest.test_expectations_files):
  4900. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  4901. (MockDRTPortTest.make_port):
  4902. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  4903. (WinPortTest.test_expectations_files):
  4904. 2012-08-30 Dirk Pranke <dpranke@chromium.org>
  4905. executive.run_in_parallel() hangs if given nothing to do
  4906. https://bugs.webkit.org/show_bug.cgi?id=95387
  4907. Reviewed by Ojan Vafai.
  4908. Check to make sure that Executive.run_in_parallel() requires
  4909. a non-empty list of commands to execute; passing an empty list
  4910. seems surely like a programming error.
  4911. * Scripts/webkitpy/common/system/executive.py:
  4912. (Executive.run_in_parallel):
  4913. * Scripts/webkitpy/common/system/executive_unittest.py:
  4914. (ExecutiveTest.test_run_in_parallel_assert_nonempty):
  4915. 2012-08-30 Dirk Pranke <dpranke@chromium.org>
  4916. decide what (and how) we should set the tolerance for ref test pixel compares and test for that
  4917. https://bugs.webkit.org/show_bug.cgi?id=94746
  4918. Reviewed by Ojan Vafai.
  4919. Add an assertion to diff_image() to check that we are passing
  4920. tolerance=0 explicitly when diffing ref test results.
  4921. * Scripts/webkitpy/layout_tests/port/test.py:
  4922. (TestPort.diff_image):
  4923. 2012-08-30 Dirk Pranke <dpranke@chromium.org>
  4924. NRWT should look in mac-wk2 for a TestExpecations file
  4925. https://bugs.webkit.org/show_bug.cgi?id=95370
  4926. Reviewed by Ojan Vafai.
  4927. Adds support for mac-wk2 and win-wk2 to expectations_files()
  4928. for the apple mac and apple win ports.
  4929. * Scripts/webkitpy/layout_tests/port/apple.py:
  4930. (ApplePort.expectations_files):
  4931. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  4932. (MacTest.test_expectations_files):
  4933. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  4934. (WinTest.test_expectations_files):
  4935. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  4936. (PortTestCase.test_expectations_files):
  4937. 2012-08-30 Jon Lee <jonlee@apple.com>
  4938. [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
  4939. https://bugs.webkit.org/show_bug.cgi?id=95232
  4940. <rdar://problem/12190776>
  4941. Reviewed by Alexey Proskuryakov.
  4942. Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
  4943. * DumpRenderTree/TestRunner.cpp:
  4944. (TestRunner::TestRunner):
  4945. (dumpWebNotificationCallbacksCallback):
  4946. (TestRunner::staticFunctions):
  4947. * DumpRenderTree/TestRunner.h:
  4948. (TestRunner):
  4949. (TestRunner::dumpWebNotificationCallbacks):
  4950. (TestRunner::setDumpWebNotificationCallbacks):
  4951. * DumpRenderTree/mac/MockWebNotificationProvider.mm:
  4952. (-[WebNotification _drt_descriptionSuitableForTestResult]):
  4953. (-[MockWebNotificationProvider webView:didShowNotification:]):
  4954. (-[MockWebNotificationProvider webView:didClickNotification:]):
  4955. (-[MockWebNotificationProvider webView:didCloseNotifications:]):
  4956. * DumpRenderTree/mac/UIDelegate.mm:
  4957. (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
  4958. 2012-08-30 Tommy Widenflycht <tommyw@google.com>
  4959. MediaStream API: Introduce MediaConstraints
  4960. https://bugs.webkit.org/show_bug.cgi?id=95198
  4961. Reviewed by Adam Barth.
  4962. Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
  4963. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  4964. (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
  4965. (isSupportedConstraint):
  4966. (isValidConstraint):
  4967. (MockWebRTCPeerConnectionHandler::initialize):
  4968. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  4969. (MockWebRTCPeerConnectionHandler):
  4970. 2012-08-30 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  4971. [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
  4972. https://bugs.webkit.org/show_bug.cgi?id=95454
  4973. Reviewed by Kenneth Rohde Christiansen.
  4974. Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
  4975. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  4976. (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
  4977. 2012-08-30 Leo Yang <leoyang@rim.com>
  4978. Update my email address.
  4979. Not reviewed.
  4980. * Scripts/webkitpy/common/config/committers.py:
  4981. 2012-08-30 Jochen Eisinger <jochen@chromium.org>
  4982. [NRWT] Add support for recognizing arbitrary process names in crash lines
  4983. https://bugs.webkit.org/show_bug.cgi?id=95435
  4984. Reviewed by Adam Barth.
  4985. When running layout tests in the chromium port using the content shell,
  4986. we want to be able to report sub-process crashes as well.
  4987. * Scripts/webkitpy/layout_tests/port/driver.py:
  4988. (Driver._check_for_driver_crash):
  4989. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  4990. (DriverTest.test_check_for_driver_crash):
  4991. 2012-08-29 Zan Dobersek <zandobersek@gmail.com>
  4992. Random test-webkitpy failures on the buildbot
  4993. https://bugs.webkit.org/show_bug.cgi?id=95096
  4994. Reviewed by Dirk Pranke.
  4995. Suppress occasional errors when running test-webkitpy on GTK builders
  4996. by running these tests serially. The 64-bit Release builder is especially
  4997. prone to these as it can run up to 24 tests in parallel.
  4998. Despite the tests not being run in parallel, the testing only lasts a handful
  4999. of seconds more, so this is a worthy trade-off to avoid unnecessary
  5000. false-alarm redness on the GTK builders.
  5001. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  5002. (RunPythonTests.start):
  5003. 2012-08-29 Benjamin Poulain <bpoulain@apple.com>
  5004. REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
  5005. https://bugs.webkit.org/show_bug.cgi?id=95380
  5006. Reviewed by Michael Saboff.
  5007. * TestWebKitAPI/Tests/WTF/WTFString.cpp:
  5008. Add very basic tests for String::ascii(). This covers the case of null strings that caused
  5009. the crash.
  5010. 2012-08-29 Dominic Mazzoni <dmazzoni@google.com>
  5011. AX: Canvas should have a distinct role
  5012. https://bugs.webkit.org/show_bug.cgi?id=95248
  5013. Reviewed by Chris Fleizach.
  5014. Add support for canvas accessibility role.
  5015. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  5016. (roleToString):
  5017. 2012-08-29 José Dapena Paz <jdapena@igalia.com>
  5018. [Gtk] Process Gtk 3.4 smooth scroll events properly
  5019. https://bugs.webkit.org/show_bug.cgi?id=88070
  5020. Added continousMouseScrollBy support in WebKitTestRunner, and added
  5021. implementation for gtk, and stub for Qt, mac and EFL.
  5022. Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
  5023. scroll for emulating multi-tick mouseScrollBy events.
  5024. Reviewed by Martin Robinson.
  5025. * DumpRenderTree/gtk/EventSender.cpp:
  5026. (mouseScrollByCallback):
  5027. (continuousMouseScrollByCallback):
  5028. * WebKitTestRunner/EventSenderProxy.h:
  5029. (EventSenderProxy):
  5030. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  5031. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  5032. (WTR::EventSendingController::mouseScrollBy):
  5033. (WTR):
  5034. (WTR::EventSendingController::continuousMouseScrollBy):
  5035. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  5036. (EventSendingController):
  5037. * WebKitTestRunner/TestController.cpp:
  5038. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  5039. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
  5040. (WTR):
  5041. (WTR::EventSenderProxy::mouseScrollBy):
  5042. (WTR::EventSenderProxy::continuousMouseScrollBy):
  5043. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
  5044. (WTR):
  5045. (WTR::EventSenderProxy::continuousMouseScrollBy):
  5046. * WebKitTestRunner/mac/EventSenderProxy.mm:
  5047. (WTR::EventSenderProxy::continuousScrollBy):
  5048. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  5049. (WTR::EventSenderProxy::continuousMouseScrollBy):
  5050. (WTR):
  5051. 2012-08-29 Alex Sakhartchouk <alexst@chromium.org>
  5052. [chromium] Support high DIP pixel tests with DumpRenderTree
  5053. https://bugs.webkit.org/show_bug.cgi?id=94935
  5054. Reviewed by James Robinson.
  5055. Adding device scale factor into the drt image dumping code
  5056. * DumpRenderTree/chromium/DRTTestRunner.cpp:
  5057. (DRTTestRunner::reset):
  5058. (DRTTestRunner::setBackingScaleFactor):
  5059. * DumpRenderTree/chromium/WebViewHost.cpp:
  5060. (WebViewHost::setDeviceScaleFactor):
  5061. (WebViewHost::paintInvalidatedRegion):
  5062. (WebViewHost::canvas):
  5063. * DumpRenderTree/chromium/WebViewHost.h:
  5064. (WebViewHost):
  5065. 2012-08-29 Kevin Funk <kevin.funk@kdab.com>
  5066. Fix check-webkit-style (and probably others) when WebKit is in a git submodule
  5067. https://bugs.webkit.org/show_bug.cgi?id=95177
  5068. Reviewed by Dirk Pranke.
  5069. Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
  5070. * Scripts/webkitpy/common/checkout/scm/git.py:
  5071. 2012-08-29 Dirk Pranke <dpranke@chromium.org>
  5072. webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
  5073. https://bugs.webkit.org/show_bug.cgi?id=95222
  5074. Reviewed by Adam Barth.
  5075. The code we had to remove REBASELINE lines from the
  5076. TestExpectations files did not handle multiple files (in a
  5077. cascade) correctly; we weren't limiting lines to a particular
  5078. file correctly in without_rebaseline_modifier(). This patch
  5079. fixes that and corrects the tests (which weren't correct and
  5080. didn't cover things very well).
  5081. Note also that the webkit-patch rebaseline-commands are still
  5082. using the include_overrides=False option in a couple places;
  5083. this is never correct or needed at this point. This patch fixes
  5084. the usage for webkit-patch rebaseline-expectations, but I still
  5085. need to fix rebaseline-test-internal, which I will do in a
  5086. separate patch (see bug 95268).
  5087. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  5088. (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
  5089. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  5090. (RebaseliningTest.assertRemove):
  5091. (RebaseliningTest.test_remove):
  5092. * Scripts/webkitpy/tool/commands/rebaseline.py:
  5093. (RebaselineExpectations._update_expectations_files):
  5094. 2012-08-29 Dirk Pranke <dpranke@chromium.org>
  5095. webkit-patch rebaseline-expectations hangs
  5096. https://bugs.webkit.org/show_bug.cgi?id=95243
  5097. Reviewed by Tony Chang.
  5098. Don't try to run no commands in parallel; report an error
  5099. instead that we didn't find any tests to rebaseline.
  5100. Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
  5101. * Scripts/webkitpy/tool/commands/rebaseline.py:
  5102. (RebaselineExpectations.execute):
  5103. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  5104. (_assert_command):
  5105. (test_rebaseline_expectations_noop):
  5106. 2012-08-29 Brady Eidson <beidson@apple.com>
  5107. REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
  5108. <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
  5109. Reviewed by Sam Weinig.
  5110. Add a test plug-in that calls back into the page with info on the NPWindow passed
  5111. in to NPP_SetWindow.
  5112. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  5113. * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
  5114. (LogNPPSetWindow):
  5115. (LogNPPSetWindow::LogNPPSetWindow):
  5116. (LogNPPSetWindow::NPP_SetWindow):
  5117. 2012-08-29 Jon Lee <jonlee@apple.com>
  5118. [Mac] Basic DRT support for web notifications
  5119. https://bugs.webkit.org/show_bug.cgi?id=79492
  5120. <rdar://problem/10357639>
  5121. Reviewed by Alexey Proskuryakov.
  5122. This patch implements the stubs for web notification support on DRT. Assume that when
  5123. Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
  5124. overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
  5125. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
  5126. * DumpRenderTree/mac/DumpRenderTree.mm:
  5127. (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
  5128. web view.
  5129. (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
  5130. * DumpRenderTree/mac/TestRunnerMac.mm:
  5131. (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
  5132. (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
  5133. (TestRunner::removeAllWebNotificationPermissions):
  5134. (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
  5135. simulate the click. This is similar to how WTR performs the click.
  5136. * DumpRenderTree/mac/UIDelegate.mm:
  5137. (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
  5138. user allows web notifications.
  5139. * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
  5140. a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
  5141. * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
  5142. (+[MockWebNotificationProvider shared]): The provider is a singleton.
  5143. (-[MockWebNotificationProvider init]): Instantiate the permissions map.
  5144. (-[MockWebNotificationProvider registerWebView:]):
  5145. (-[MockWebNotificationProvider unregisterWebView:]):
  5146. (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
  5147. notification did show.
  5148. (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
  5149. (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
  5150. (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
  5151. (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
  5152. (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
  5153. (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
  5154. (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
  5155. (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
  5156. (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
  5157. (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
  5158. (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
  5159. 2012-08-29 Rob Buis <rbuis@rim.com>
  5160. [BlackBerry] Adjust wtf include header style
  5161. https://bugs.webkit.org/show_bug.cgi?id=95368
  5162. Reviewed by Yong Li.
  5163. Switch to #include <wtf/...> like the other ports.
  5164. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  5165. * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
  5166. * DumpRenderTree/blackberry/PNGImageEncoder.h:
  5167. * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
  5168. * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
  5169. * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
  5170. 2012-08-29 Roger Fong <roger_fong@apple.com>
  5171. Update cygwin-downloader.zip to match modified downloader script.
  5172. https://bugs.webkit.org/show_bug.cgi?id=76936
  5173. Rubber Stamped by Jon Honeycutt.
  5174. cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
  5175. Updating zip to reflect changes.
  5176. * CygwinDownloader/cygwin-downloader.zip:
  5177. 2012-08-29 Dominik Röttsches <dominik.rottsches@intel.com>
  5178. Stylechecker warns about comparison to zero when comparing to 0.5
  5179. https://bugs.webkit.org/show_bug.cgi?id=94913
  5180. Reviewed by Dirk Pranke.
  5181. According to the python documentation, \W is the character group with all
  5182. non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
  5183. to [^\w]. We need to exclude the dot "." as well, so that floating point
  5184. values do not trigger this warning. Adding a unit test that shows the problem.
  5185. * Scripts/webkitpy/style/checkers/cpp.py:
  5186. (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
  5187. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  5188. (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
  5189. 2012-08-29 Jon Lee <jonlee@apple.com>
  5190. WTR build fixes.
  5191. * WebKitTestRunner/CMakeLists.txt:
  5192. * WebKitTestRunner/GNUmakefile.am:
  5193. * WebKitTestRunner/Target.pri:
  5194. * WebKitTestRunner/WebNotificationProvider.cpp:
  5195. (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
  5196. * WebKitTestRunner/win/WebKitTestRunner.vcproj:
  5197. 2012-08-29 Jon Lee <jonlee@apple.com>
  5198. [WK2] Basic WTR support for web notifications
  5199. https://bugs.webkit.org/show_bug.cgi?id=95154
  5200. <rdar://problem/12184492>
  5201. Reviewed by Alexey Proskuryakov.
  5202. Implement WTR support, without platform event output (bug 95233).
  5203. Legacy APIs will not be supported, since many of the tests are skipped
  5204. on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
  5205. tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
  5206. the tests to http/tests/notifications.
  5207. Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
  5208. require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
  5209. be invoked from the UIProcess.
  5210. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  5211. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  5212. (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
  5213. (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
  5214. notification's internal ID.
  5215. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  5216. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  5217. (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
  5218. (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
  5219. (WTR::TestRunner::removeAllWebNotificationPermissions):
  5220. (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
  5221. * WebKitTestRunner/InjectedBundle/TestRunner.h:
  5222. Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
  5223. class.
  5224. * WebKitTestRunner/TestInvocation.cpp:
  5225. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
  5226. TestInvocation forwards that request to the TestController.
  5227. * WebKitTestRunner/TestController.cpp:
  5228. (WTR::TestController::initialize): Set the provider.
  5229. (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
  5230. (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
  5231. * WebKitTestRunner/TestController.h: Holds an instance to the provider.
  5232. The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
  5233. of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
  5234. * WebKitTestRunner/WebNotificationProvider.h: Added.
  5235. * WebKitTestRunner/WebNotificationProvider.cpp: Added.
  5236. (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
  5237. the notification got shown.
  5238. (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
  5239. got closed.
  5240. (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
  5241. (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
  5242. (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
  5243. permissions. For testing purposes, we always want this set to be empty.
  5244. (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
  5245. (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
  5246. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
  5247. 2012-08-29 Kamil Blank <k.blank@samsung.com>
  5248. [EFL] Add setting API for allow universal/file access from file URLs.
  5249. https://bugs.webkit.org/show_bug.cgi?id=83121
  5250. Reviewed by Eric Seidel.
  5251. Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
  5252. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  5253. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  5254. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  5255. (TestRunner::setAllowUniversalAccessFromFileURLs):
  5256. (TestRunner::setAllowFileAccessFromFileURLs):
  5257. 2012-08-29 Jon Lee <jonlee@apple.com>
  5258. Update TestRunner API for web notifications
  5259. https://bugs.webkit.org/show_bug.cgi?id=95093
  5260. <rdar://problem/12179649>
  5261. Reviewed by Alexey Proskuryakov.
  5262. As it turns out the patch for this accidentally got squashed into the commit for
  5263. bug 95099 (r126909). This amendment patch adds some comments about the renaming
  5264. of the older TestRunner API for web notifications.
  5265. * DumpRenderTree/TestRunner.h:
  5266. (TestRunner):
  5267. 2012-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
  5268. Unreviewed, rolling out r126972.
  5269. http://trac.webkit.org/changeset/126972
  5270. https://bugs.webkit.org/show_bug.cgi?id=95349
  5271. accessibility/canvas-description-and-role.html has been
  5272. failing consistently on several bots and Dominic needs some
  5273. time to investigate why (Requested by jchaffraix on #webkit).
  5274. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  5275. (roleToString):
  5276. 2012-08-29 Raphael Kubo da Costa <rakuco@webkit.org>
  5277. [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
  5278. https://bugs.webkit.org/show_bug.cgi?id=84707
  5279. Reviewed by Gustavo Noronha Silva.
  5280. Most of the warnings have been fixed now that FindCairo.cmake and
  5281. FindGLIB.cmake have been rewritten. The remaining one, related to
  5282. FindFontconfig.cmake, shows up when building on a 64-bit
  5283. Debian-based systems.
  5284. jhbuild installs libraries into lib64/ by default on 64-bit Linux
  5285. installations, while CMake does not look for libraries in lib64/
  5286. when /etc/debian_version exists on the system. The FIND_LIBRARY()
  5287. would then sometimes end up using the system installation instead of
  5288. the jhbuild one, causing mismatches and, when pkg-config is not used
  5289. at all, failing to find libraries altogether.
  5290. * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
  5291. when use_lib64 is set to force CMake to look into lib64/ regardless
  5292. of the presence of /etc/debian_version.
  5293. 2012-08-29 Dominik Röttsches <dominik.rottsches@intel.com>
  5294. The 2d.imageData.object.round canvas test is failing
  5295. https://bugs.webkit.org/show_bug.cgi?id=40272
  5296. Reviewed by Benjamin Poulain.
  5297. Updating patch to address Benjamin's review comments.
  5298. Adding a WTF test to test lrint implementation.
  5299. * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
  5300. * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
  5301. * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
  5302. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
  5303. * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
  5304. (TestWebKitAPI):
  5305. (TestWebKitAPI::TEST):
  5306. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
  5307. 2012-08-29 Florin Malita <fmalita@chromium.org>
  5308. Unreviewed, updating Kelly Norton's email address at his request.
  5309. * Scripts/webkitpy/common/config/committers.py:
  5310. 2012-08-29 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  5311. [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
  5312. https://bugs.webkit.org/show_bug.cgi?id=93723
  5313. Reviewed by Dirk Pranke.
  5314. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  5315. (TestExpectationParser.expectation_for_skipped_test):
  5316. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  5317. (SkippedTests.test_skipped_entry_dont_exist):
  5318. 2012-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
  5319. Unreviewed, rolling out r120113.
  5320. http://trac.webkit.org/changeset/120113
  5321. https://bugs.webkit.org/show_bug.cgi?id=95320
  5322. Wrong fix for the problem, experimentally rolling it out for
  5323. bug 95237. (Requested by rakuco on #webkit).
  5324. * efl/jhbuildrc:
  5325. 2012-08-29 Dominic Mazzoni <dmazzoni@google.com>
  5326. AX: Canvas should have a distinct role
  5327. https://bugs.webkit.org/show_bug.cgi?id=95248
  5328. Reviewed by Chris Fleizach.
  5329. Add support for canvas accessibility role.
  5330. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  5331. (roleToString):
  5332. 2012-08-28 Eric Seidel <eric@webkit.org>
  5333. cr-ews bot doesn't set CWD correctly when zipping layout test results
  5334. https://bugs.webkit.org/show_bug.cgi?id=91265
  5335. Reviewed by Kenneth Russell.
  5336. This should make the zips slightly less cumbersome to deal with.
  5337. * Scripts/webkitpy/common/system/workspace.py:
  5338. (Workspace.create_zip):
  5339. * Scripts/webkitpy/common/system/workspace_unittest.py:
  5340. (WorkspaceTest.test_create_zip):
  5341. (WorkspaceTest.test_create_zip_exception):
  5342. 2012-08-28 Benjamin Poulain <benjamin@webkit.org>
  5343. Fix the Commiters script
  5344. Unreviewed.
  5345. Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
  5346. * Scripts/webkitpy/common/config/committers.py:
  5347. 2012-08-28 Roger Fong <roger_fong@apple.com>
  5348. Unreviewed. Adding myself to committers list.
  5349. * Scripts/webkitpy/common/config/committers.py:
  5350. 2012-08-28 Roger Fong <roger_fong@apple.com>
  5351. Add minires to list of required cygwin install packages.
  5352. https://bugs.webkit.org/show_bug.cgi?id=76936
  5353. Reviewed by Tim Horton.
  5354. * CygwinDownloader/cygwin-downloader.py:
  5355. 2012-08-28 Xianzhu Wang <wangxianzhu@chromium.org>
  5356. [Chromium-Android] Upstream layout test expectations (Part 2)
  5357. https://bugs.webkit.org/show_bug.cgi?id=95212
  5358. Reviewed by Adam Barth.
  5359. - Now run both gpu path and non-gpu path of 2d canvas layout tests
  5360. because both are used in chromium-android.
  5361. - Exclude all webgl tests because webgl is not enabled yet.
  5362. - Removed 'win' from the baseline fallback list. This was a mistake.
  5363. - Moved some small directories to TestExpectations from skipped_layout_tests().
  5364. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  5365. (ChromiumAndroidPort):
  5366. (ChromiumAndroidPort.skipped_layout_tests):
  5367. 2012-08-28 Joanmarie Diggs <jdiggs@igalia.com>
  5368. Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
  5369. https://bugs.webkit.org/show_bug.cgi?id=95185
  5370. Reviewed by Chris Fleizach.
  5371. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  5372. (AccessibilityUIElement::titleUIElement): Implemented
  5373. Gets the ATK_RELATION_LABELLED_BY target.
  5374. (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
  5375. Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
  5376. bug 95180 is fixed.
  5377. 2012-08-28 Dominic Mazzoni <dmazzoni@google.com>
  5378. AX: Crash due to object getting deleted inside updateBackingStore
  5379. https://bugs.webkit.org/show_bug.cgi?id=94619
  5380. Reviewed by Chris Fleizach.
  5381. Change isValid to !isDetached after deleting isValid from
  5382. chromium WebAccessibilityObject as being redundant.
  5383. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  5384. (AccessibilityUIElement::isValidGetterCallback):
  5385. 2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
  5386. Unreviewed, rolling out r126914.
  5387. http://trac.webkit.org/changeset/126914
  5388. https://bugs.webkit.org/show_bug.cgi?id=95239
  5389. it breaks everything and fixes nothing (Requested by pizlo on
  5390. #webkit).
  5391. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
  5392. (MockWebSpeechInputController::addMockRecognitionResult):
  5393. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  5394. (NotificationPresenter::simulateClick):
  5395. (NotificationPresenter::show):
  5396. * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
  5397. (CppBoundClass::~CppBoundClass):
  5398. (CppBoundClass::invoke):
  5399. (CppBoundClass::getProperty):
  5400. (CppBoundClass::setProperty):
  5401. (CppBoundClass::bindCallback):
  5402. (CppBoundClass::bindProperty):
  5403. * DumpRenderTree/chromium/WebPreferences.cpp:
  5404. (applyFontMap):
  5405. * DumpRenderTree/chromium/WebViewHost.cpp:
  5406. (WebViewHost::printResourceDescription):
  5407. * DumpRenderTree/mac/TestRunnerMac.mm:
  5408. (worldIDForWorld):
  5409. (TestRunner::evaluateScriptInIsolatedWorld):
  5410. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  5411. (AccessibilityController::~AccessibilityController):
  5412. (AccessibilityController::winNotificationReceived):
  5413. * DumpRenderTree/win/ResourceLoadDelegate.cpp:
  5414. (ResourceLoadDelegate::descriptionSuitableForTestResult):
  5415. * DumpRenderTree/win/TestRunnerWin.cpp:
  5416. (worldIDForWorld):
  5417. (TestRunner::evaluateScriptInIsolatedWorld):
  5418. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
  5419. (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
  5420. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
  5421. (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
  5422. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  5423. (WTR::TestRunner::worldIDForWorld):
  5424. (WTR::TestRunner::evaluateScriptInIsolatedWorld):
  5425. 2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  5426. Rename first/second to key/value in HashMap iterators
  5427. https://bugs.webkit.org/show_bug.cgi?id=82784
  5428. Reviewed by Eric Seidel.
  5429. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
  5430. (MockWebSpeechInputController::addMockRecognitionResult):
  5431. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  5432. (NotificationPresenter::simulateClick):
  5433. (NotificationPresenter::show):
  5434. * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
  5435. (CppBoundClass::~CppBoundClass):
  5436. (CppBoundClass::invoke):
  5437. (CppBoundClass::getProperty):
  5438. (CppBoundClass::setProperty):
  5439. (CppBoundClass::bindCallback):
  5440. (CppBoundClass::bindProperty):
  5441. * DumpRenderTree/chromium/WebPreferences.cpp:
  5442. (applyFontMap):
  5443. * DumpRenderTree/chromium/WebViewHost.cpp:
  5444. (WebViewHost::printResourceDescription):
  5445. * DumpRenderTree/mac/TestRunnerMac.mm:
  5446. (worldIDForWorld):
  5447. (TestRunner::evaluateScriptInIsolatedWorld):
  5448. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  5449. (AccessibilityController::~AccessibilityController):
  5450. (AccessibilityController::winNotificationReceived):
  5451. * DumpRenderTree/win/ResourceLoadDelegate.cpp:
  5452. (ResourceLoadDelegate::descriptionSuitableForTestResult):
  5453. * DumpRenderTree/win/TestRunnerWin.cpp:
  5454. (worldIDForWorld):
  5455. (TestRunner::evaluateScriptInIsolatedWorld):
  5456. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
  5457. (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
  5458. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
  5459. (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
  5460. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  5461. (WTR::TestRunner::worldIDForWorld):
  5462. (WTR::TestRunner::evaluateScriptInIsolatedWorld):
  5463. 2012-08-27 Jon Lee <jonlee@apple.com>
  5464. Update TestRunner API for web notifications
  5465. https://bugs.webkit.org/show_bug.cgi?id=95093
  5466. <rdar://problem/12179649>
  5467. Reviewed by Jessie Berlin.
  5468. This is work toward providing Mac support for web notifications in DRT and WTR (77969).
  5469. Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
  5470. This first patch renames the TestRunner calls to use the term "web notifications" instead of
  5471. "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
  5472. additional calls that will be used in the tests that test the standard API.
  5473. * DumpRenderTree/TestRunner.h:
  5474. (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
  5475. and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
  5476. * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
  5477. (TestRunner::TestRunner):
  5478. (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
  5479. (simulateLegacyWebNotificationClickCallback): Renamed.
  5480. (grantWebNotificationPermissionCallback): Renamed.
  5481. (denyWebNotificationPermissionCallback): Added.
  5482. (removeAllWebNotificationPermissionsCallback): Added.
  5483. (simulateWebNotificationClickCallback): Added.
  5484. (TestRunner::staticFunctions):
  5485. (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
  5486. * DumpRenderTree/chromium/DRTTestRunner.cpp:
  5487. (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
  5488. (DRTTestRunner::grantWebNotificationPermission):
  5489. (DRTTestRunner::denyWebNotificationPermission): Stub.
  5490. (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
  5491. (DRTTestRunner::simulateWebNotificationClick): Stub.
  5492. (DRTTestRunner::simulateLegacyWebNotificationClick):
  5493. * DumpRenderTree/chromium/DRTTestRunner.h:
  5494. (DRTTestRunner):
  5495. Added stubs.
  5496. * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  5497. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  5498. * DumpRenderTree/gtk/TestRunnerGtk.cpp:
  5499. * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
  5500. * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
  5501. * DumpRenderTree/win/TestRunnerWin.cpp:
  5502. 2012-08-28 Szilard Ledan <szledan@inf.u-szeged.hu>
  5503. [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
  5504. https://bugs.webkit.org/show_bug.cgi?id=94700
  5505. Reviewed by Eric Seidel.
  5506. Interrupting download with a timeout would be a possible solution.
  5507. I imported the socket module and used the setdefaulttimeout() method.
  5508. Fixing it is important, because EWS bots need to be restarted regularly
  5509. because of this bug.
  5510. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  5511. (Bugzilla._get_browser):
  5512. (Bugzilla.setdefaulttimeout):
  5513. 2012-08-28 Gabor Rapcsanyi <rgabor@webkit.org>
  5514. [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
  5515. https://bugs.webkit.org/show_bug.cgi?id=95194
  5516. Reviewed by Simon Hausmann.
  5517. * Scripts/webkitpy/layout_tests/port/qt.py:
  5518. (QtPort.setup_environ_for_server):
  5519. 2012-08-28 Andras Becsi <andras.becsi@nokia.com>
  5520. [watchlist] Unreviewed, subscribe to Qt bugs.
  5521. * Scripts/webkitpy/common/config/watchlist:
  5522. 2012-08-28 Simon Hausmann <simon.hausmann@nokia.com>
  5523. [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
  5524. https://bugs.webkit.org/show_bug.cgi?id=95054
  5525. Reviewed by Eric Seidel.
  5526. Enable CSS_IMAGE_SET for the Qt build.
  5527. * qmake/mkspecs/features/features.pri:
  5528. 2012-08-27 Csaba Osztrogonác <ossy@webkit.org>
  5529. [Qt] Enable CSS sticky position
  5530. https://bugs.webkit.org/show_bug.cgi?id=95172
  5531. Reviewed by Simon Hausmann.
  5532. * qmake/mkspecs/features/features.pri:
  5533. 2012-08-27 Zan Dobersek <zandobersek@gmail.com>
  5534. [GTK] Memory cache should be cleared in between test runs
  5535. https://bugs.webkit.org/show_bug.cgi?id=95105
  5536. Reviewed by Martin Robinson.
  5537. Call the new DumpRenderTreeSupportGtk helper method after every test
  5538. to clear the memory cache.
  5539. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  5540. (runTest):
  5541. 2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
  5542. Unreviewed, rolling out r126836.
  5543. http://trac.webkit.org/changeset/126836
  5544. https://bugs.webkit.org/show_bug.cgi?id=95163
  5545. Broke all Apple ports, EFL, and Qt. (Requested by tkent on
  5546. #webkit).
  5547. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
  5548. (MockWebSpeechInputController::addMockRecognitionResult):
  5549. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  5550. (NotificationPresenter::simulateClick):
  5551. (NotificationPresenter::show):
  5552. * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
  5553. (CppBoundClass::~CppBoundClass):
  5554. (CppBoundClass::invoke):
  5555. (CppBoundClass::getProperty):
  5556. (CppBoundClass::setProperty):
  5557. (CppBoundClass::bindCallback):
  5558. (CppBoundClass::bindProperty):
  5559. * DumpRenderTree/chromium/WebPreferences.cpp:
  5560. (applyFontMap):
  5561. * DumpRenderTree/chromium/WebViewHost.cpp:
  5562. (WebViewHost::printResourceDescription):
  5563. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  5564. (AccessibilityController::~AccessibilityController):
  5565. (AccessibilityController::winNotificationReceived):
  5566. * DumpRenderTree/win/ResourceLoadDelegate.cpp:
  5567. (ResourceLoadDelegate::descriptionSuitableForTestResult):
  5568. * DumpRenderTree/win/TestRunnerWin.cpp:
  5569. (worldIDForWorld):
  5570. (TestRunner::evaluateScriptInIsolatedWorld):
  5571. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
  5572. (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
  5573. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
  5574. (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
  5575. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  5576. (WTR::TestRunner::worldIDForWorld):
  5577. (WTR::TestRunner::evaluateScriptInIsolatedWorld):
  5578. 2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  5579. Rename first/second to key/value in HashMap iterators
  5580. https://bugs.webkit.org/show_bug.cgi?id=82784
  5581. Reviewed by Eric Seidel.
  5582. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
  5583. (MockWebSpeechInputController::addMockRecognitionResult):
  5584. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  5585. (NotificationPresenter::simulateClick):
  5586. (NotificationPresenter::show):
  5587. * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
  5588. (CppBoundClass::~CppBoundClass):
  5589. (CppBoundClass::invoke):
  5590. (CppBoundClass::getProperty):
  5591. (CppBoundClass::setProperty):
  5592. (CppBoundClass::bindCallback):
  5593. (CppBoundClass::bindProperty):
  5594. * DumpRenderTree/chromium/WebPreferences.cpp:
  5595. (applyFontMap):
  5596. * DumpRenderTree/chromium/WebViewHost.cpp:
  5597. (WebViewHost::printResourceDescription):
  5598. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  5599. (AccessibilityController::~AccessibilityController):
  5600. (AccessibilityController::winNotificationReceived):
  5601. * DumpRenderTree/win/ResourceLoadDelegate.cpp:
  5602. (ResourceLoadDelegate::descriptionSuitableForTestResult):
  5603. * DumpRenderTree/win/TestRunnerWin.cpp:
  5604. (worldIDForWorld):
  5605. (TestRunner::evaluateScriptInIsolatedWorld):
  5606. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
  5607. (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
  5608. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
  5609. (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
  5610. * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  5611. (WTR::TestRunner::worldIDForWorld):
  5612. (WTR::TestRunner::evaluateScriptInIsolatedWorld):
  5613. 2012-08-24 James Robinson <jamesr@chromium.org>
  5614. WebGL should not flip textures on presentation if contents are unchanged
  5615. https://bugs.webkit.org/show_bug.cgi?id=94961
  5616. Reviewed by Kenneth Russell.
  5617. Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.
  5618. * Scripts/webkitpy/layout_tests/port/chromium.py:
  5619. (ChromiumPort.virtual_test_suites):
  5620. 2012-08-27 Gavin Peters <gavinp@chromium.org>
  5621. [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
  5622. https://bugs.webkit.org/show_bug.cgi?id=95104
  5623. Reviewed by Adam Barth.
  5624. Today I found out this command was broken by the new iOS platform showing up on omahaproxy. Now the webkit-patch chrome-channels command gracefully handles new, previously unknown platforms. Also, it prints iOS in the proper mixed case.
  5625. * Scripts/webkitpy/common/net/omahaproxy.py:
  5626. (OmahaProxy):
  5627. (OmahaProxy.get_revisions):
  5628. * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
  5629. (OmahaProxyTest):
  5630. (OmahaProxyTest.test_get_revisions):
  5631. 2012-08-27 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  5632. [EFL][WK2] Free Url_Bar on program exit
  5633. https://bugs.webkit.org/show_bug.cgi?id=95086
  5634. Reviewed by Eric Seidel.
  5635. Fix a memory leak by freeing the Url_Bar on program exit.
  5636. * MiniBrowser/efl/main.c:
  5637. (main): Call url_bar_del() to free the Url_Bar.
  5638. 2012-08-27 James Robinson <jamesr@chromium.org>
  5639. [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
  5640. https://bugs.webkit.org/show_bug.cgi?id=95115
  5641. Reviewed by Adam Barth.
  5642. Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
  5643. code if the unit tests crash.
  5644. * Scripts/run-chromium-webkit-unit-tests:
  5645. 2012-08-27 Benjamin Poulain <benjamin@webkit.org>
  5646. Add ECMAScript Number to String conversion to WTF::String
  5647. https://bugs.webkit.org/show_bug.cgi?id=95016
  5648. Reviewed by Geoffrey Garen.
  5649. * TestWebKitAPI/Tests/WTF/WTFString.cpp:
  5650. (TestWebKitAPI::testNumberToStringECMAScript):
  5651. (TestWebKitAPI): Add tests for String's ECMAString number conversion.
  5652. 2012-08-27 Philippe Normand <pnormand@igalia.com>
  5653. [GStreamer][Qt] WebAudio support
  5654. https://bugs.webkit.org/show_bug.cgi?id=94806
  5655. Reviewed by Simon Hausmann.
  5656. * MiniBrowser/qt/qml/BrowserWindow.qml: Enable WebAudio support.
  5657. 2012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  5658. Rename RegisterProtocolHandler API to NavigatorContentUtils
  5659. https://bugs.webkit.org/show_bug.cgi?id=94920
  5660. Reviewed by Adam Barth.
  5661. Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.
  5662. * Scripts/webkitperl/FeatureList.pm:
  5663. * qmake/mkspecs/features/features.pri:
  5664. 2012-08-24 Benjamin Poulain <bpoulain@apple.com>
  5665. Unify Number to StringImpl conversion
  5666. https://bugs.webkit.org/show_bug.cgi?id=94879
  5667. Reviewed by Geoffrey Garen.
  5668. Add testing for the new IntegerToStringConversion.
  5669. * TestWebKitAPI/CMakeLists.txt:
  5670. * TestWebKitAPI/GNUmakefile.am:
  5671. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  5672. * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.
  5673. 2012-08-23 James Robinson <jamesr@chromium.org>
  5674. [chromium] Convert WebLayerTreeView interface into pure virtual
  5675. https://bugs.webkit.org/show_bug.cgi?id=94866
  5676. Reviewed by Adrienne Walker.
  5677. Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
  5678. tests.
  5679. * DumpRenderTree/DumpRenderTree.gypi:
  5680. * DumpRenderTree/chromium/WebViewHost.cpp:
  5681. (WebViewHost::createOutputSurface):
  5682. * DumpRenderTree/chromium/WebViewHost.h:
  5683. (WebViewHost):
  5684. * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
  5685. (WebKit):
  5686. (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
  5687. (WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
  5688. (WebKit::WebViewHostOutputSurface::bindToClient):
  5689. (WebKit::WebViewHostOutputSurface::capabilities):
  5690. (WebKit::WebViewHostOutputSurface::context3D):
  5691. (WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):
  5692. * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
  5693. (WebKit):
  5694. (WebViewHostOutputSurface):
  5695. 2012-08-24 Xianzhu Wang <wangxianzhu@chromium.org>
  5696. [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
  5697. https://bugs.webkit.org/show_bug.cgi?id=94865
  5698. Reviewed by Dirk Pranke.
  5699. Android detects crash of test by checking if the return value of read() is None.
  5700. Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
  5701. If set, ServerProcess will set _crashed unconditionaly when there is no data.
  5702. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  5703. (ChromiumAndroidPort.__init__):
  5704. (ChromiumAndroidPort):
  5705. (ChromiumAndroidPort._android_server_process_constructor):
  5706. (ChromiumAndroidDriver._start_once):
  5707. * Scripts/webkitpy/layout_tests/port/server_process.py:
  5708. (ServerProcess.__init__):
  5709. (ServerProcess._wait_for_data_and_update_buffers_using_select):
  5710. 2012-08-24 Arnaud Renevier <a.renevier@sisa.samsung.com>
  5711. build-webkit --gtk fails with Can't exec ""
  5712. https://bugs.webkit.org/show_bug.cgi?id=94944
  5713. Reviewed by Martin Robinson.
  5714. When jhbuild wrapper is not needed, do unshift a blank string to build
  5715. arguments.
  5716. * Scripts/webkitdirs.pm:
  5717. (runAutogenForAutotoolsProjectIfNecessary):
  5718. 2012-08-24 Tommy Widenflycht <tommyw@google.com>
  5719. MediaStream API: Add readyState functionality to RTCPeerConnection
  5720. https://bugs.webkit.org/show_bug.cgi?id=94813
  5721. Reviewed by Adam Barth.
  5722. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  5723. (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
  5724. (MockWebRTCPeerConnectionHandler::stop):
  5725. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  5726. (MockWebRTCPeerConnectionHandler):
  5727. 2012-08-24 Michael Brüning <michaelbruening@gmail.com>
  5728. Unreviewed. Adding myself to committers list.
  5729. Also updated email information.
  5730. * Scripts/webkitpy/common/config/committers.py:
  5731. 2012-08-24 Michael Brüning <michaelbruening@gmail.com>
  5732. [Qt][WK2] Make viewport related experimental.test properties encapsulated.
  5733. https://bugs.webkit.org/show_bug.cgi?id=88320
  5734. Reviewed by Kenneth Rohde Christiansen.
  5735. Changed the access to the viewport attributes to use the viewport object that is introduced by this change.
  5736. * MiniBrowser/qt/qml/ViewportInfoItem.qml:
  5737. 2012-08-23 Dirk Pranke <dpranke@chromium.org>
  5738. leak detection broken after r126247 on mac
  5739. https://bugs.webkit.org/show_bug.cgi?id=94893
  5740. Unreviewed, build fix.
  5741. Adds is_snowleopard(), is_lion back() in for the mac port. We'll
  5742. probably need an is_mountainlion() or equivalent at some point,
  5743. I'm guessing (but I've deleted the leopard code).
  5744. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  5745. (LeakDetector._callstacks_to_exclude_from_leaks):
  5746. * Scripts/webkitpy/layout_tests/port/mac.py:
  5747. (MacPort):
  5748. (MacPort.is_snowleopard):
  5749. (MacPort.is_lion):
  5750. 2012-08-23 Julien Chaffraix <jchaffraix@webkit.org>
  5751. [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
  5752. https://bugs.webkit.org/show_bug.cgi?id=94871
  5753. Reviewed by Benjamin Poulain.
  5754. * TestWebKitAPI/TestWebKitAPI.gypi:
  5755. Added the missing files to Chromium's build system.
  5756. 2012-08-23 Raphael Kubo da Costa <rakuco@webkit.org>
  5757. [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
  5758. * Scripts/webkitpy/common/config/watchlist:
  5759. 2012-08-23 Ryosuke Niwa <rniwa@webkit.org>
  5760. Replay tests take forever to load
  5761. https://bugs.webkit.org/show_bug.cgi?id=94764
  5762. Reviewed by Adam Barth.
  5763. Don't load about:blank at the beginning. This appears to clog the DRT.
  5764. * Scripts/webkitpy/performance_tests/perftest.py:
  5765. (ReplayPerfTest.run_single):
  5766. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  5767. (TestReplayPerfTest.test_run_single):
  5768. (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
  5769. 2012-08-23 Kenneth Russell <kbr@google.com>
  5770. Unreviewed, rolling out r126497.
  5771. http://trac.webkit.org/changeset/126497
  5772. https://bugs.webkit.org/show_bug.cgi?id=94764
  5773. Caused webkitpy-test step to start failing.
  5774. * Scripts/webkitpy/performance_tests/perftest.py:
  5775. (ReplayPerfTest.run_single):
  5776. 2012-08-23 Emil A Eklund <eae@chromium.org>
  5777. Add saturation arithmetic support to FractionalLayoutUnit
  5778. https://bugs.webkit.org/show_bug.cgi?id=94364
  5779. Reviewed by Benjamin Poulain.
  5780. Add test for new saturatedArithmetic functions.
  5781. * TestWebKitAPI/CMakeLists.txt:
  5782. * TestWebKitAPI/GNUmakefile.am:
  5783. * TestWebKitAPI/TestWebKitAPI.gypi:
  5784. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  5785. * TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.
  5786. (TestWebKitAPI):
  5787. (TestWebKitAPI::TEST):
  5788. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  5789. 2012-08-23 Ryosuke Niwa <rniwa@webkit.org>
  5790. Replay tests take forever to load
  5791. https://bugs.webkit.org/show_bug.cgi?id=94764
  5792. Reviewed by Adam Barth.
  5793. Don't load about:blank at the beginning. This appears to clog the DRT.
  5794. * Scripts/webkitpy/performance_tests/perftest.py:
  5795. (ReplayPerfTest.run_single):
  5796. 2012-08-23 Wei Jia <wjia@chromium.org>
  5797. create different WebKit::WebMediaPlayer based on URL
  5798. https://bugs.webkit.org/show_bug.cgi?id=91301
  5799. Reviewed by Adam Barth.
  5800. Pass URL to createMediaPlayer. This corresponds to change in base
  5801. class WebKit::WebFrameClient.
  5802. * DumpRenderTree/chromium/WebViewHost.cpp:
  5803. (WebViewHost::createMediaPlayer): add URL as additional argument.
  5804. * DumpRenderTree/chromium/WebViewHost.h:
  5805. (WebViewHost):
  5806. 2012-08-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  5807. Unreviewed, upgrade gyuyoung to reviewer.
  5808. http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html
  5809. * Scripts/webkitpy/common/config/committers.py:
  5810. 2012-08-23 Carlos Garcia Campos <cgarcia@igalia.com>
  5811. REGRESSION(r126306): it broke the plugin process
  5812. https://bugs.webkit.org/show_bug.cgi?id=94797
  5813. Reviewed by Xan Lopez.
  5814. * GNUmakefile.am:
  5815. 2012-08-23 Ryuan Choi <ryuan.choi@samsung.com>
  5816. [EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
  5817. https://bugs.webkit.org/show_bug.cgi?id=63966
  5818. Reviewed by Kenneth Rohde Christiansen.
  5819. EWebLauncher and MiniBrowser/Efl did not have functionality that users
  5820. navigates the site which they want.
  5821. This patch adds the urlbar and functionality to load url which users want.
  5822. * CMakeLists.txt:
  5823. Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.
  5824. * EWebLauncher/CMakeLists.txt:
  5825. Added urlbar.c and dependency of urlbar theme.
  5826. In addition, changed macro name to THEME_DIR to share the code easily.
  5827. * EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
  5828. * EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
  5829. * EWebLauncher/main.c:
  5830. Implemented to use the urlbar.
  5831. In addition, remove unnecessary border of webview to control webview and urlbar easily.
  5832. (_ELauncher):
  5833. (on_url_changed):
  5834. (browserCreate):
  5835. (closeWindow):
  5836. (findThemePath):
  5837. * EWebLauncher/url_bar.c: Implemented functionality of the urlbar.
  5838. (_url_bar_url_get_with_protocol):
  5839. (on_urlbar_key_down):
  5840. (on_urlbar_mouse_down):
  5841. (on_urlbar_focus_out):
  5842. (url_bar_add):
  5843. (url_bar_del):
  5844. (url_bar_url_set):
  5845. * EWebLauncher/url_bar.h: Added.
  5846. * MiniBrowser/efl/CMakeLists.txt:
  5847. * MiniBrowser/efl/main.c: Implemented to use the urlbar.
  5848. (_MiniBrowser):
  5849. (on_url_changed):
  5850. (browserCreate):
  5851. 2012-08-23 Balazs Kelemen <kbalazs@webkit.org>
  5852. [nrwt, WTR] Remove workaround for timeout handing from r126062
  5853. https://bugs.webkit.org/show_bug.cgi?id=94609
  5854. Reviewed by Dirk Pranke.
  5855. Don't try to reset state if a timeout occured but inform
  5856. the harness that the web process is no longer reliable.
  5857. * Scripts/webkitpy/layout_tests/port/driver.py:
  5858. (Driver.run_test): Remove the workaround. Furthermore, handle the case when
  5859. the pid is unknown.
  5860. * WebKitTestRunner/TestController.cpp:
  5861. (WTR::TestController::run):
  5862. * WebKitTestRunner/TestInvocation.cpp:
  5863. (WTR::TestInvocation::invoke):
  5864. (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
  5865. * WebKitTestRunner/TestInvocation.h:
  5866. (TestInvocation):
  5867. 2012-08-23 Ádám Kallai <kadam@inf.u-szeged.hu>
  5868. Unreviewed. Adding myself to committers list.
  5869. * Scripts/webkitpy/common/config/committers.py:
  5870. 2012-08-22 Alexis Menard <alexis@webkit.org>
  5871. Unreviewed update of my email.
  5872. * Scripts/webkitpy/common/config/committers.py:
  5873. * Scripts/webkitpy/common/config/watchlist:
  5874. 2012-08-22 Dirk Pranke <dpranke@chromium.org>
  5875. Fix typos in r126374
  5876. https://bugs.webkit.org/show_bug.cgi?id=94665
  5877. Unreviewed, build fix.
  5878. Fix two issues that snuck in, one that caused a crash if there
  5879. were no baselines to optimize and one that occurred as a result
  5880. of failing to rename a variable when I changed the recursion to
  5881. a loop in the previous patch.
  5882. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  5883. (BaselineOptimizer._optimize_by_pushing_results_up):
  5884. 2012-08-22 Dirk Pranke <dpranke@chromium.org>
  5885. Baseline optimizer should try to optimize per-port if global optimization fails
  5886. https://bugs.webkit.org/show_bug.cgi?id=94665
  5887. Reviewed by Adam Barth.
  5888. Add a fallback strategy for optimizing baselines if the default
  5889. one fails; this one simply attempts to shift baselines up in the
  5890. tree and consolidates them if a parent and child in the fallback
  5891. path have the same result. This strategy is somewhat flawed in
  5892. that we will always put something in a parent dir even if we
  5893. "shouldn't"; for example, if chromium-mac produces a different
  5894. result from chromium-win and chromium-linux, then the new
  5895. algorithm will move the mac result into platform/chromium,
  5896. leaving chromium-mac empty. This result is still correct, but
  5897. perhaps confusing.
  5898. I haven't done much testing of this algorithm yet, so it's not
  5899. clear how many cases where this does a better job than the
  5900. default algorithm and how many it'll do a worse job.
  5901. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  5902. (BaselineOptimizer._find_optimal_result_placement):
  5903. (BaselineOptimizer._optimize_by_most_specific_common_directory):
  5904. (BaselineOptimizer):
  5905. (BaselineOptimizer._optimize_by_pushing_results_up):
  5906. (BaselineOptimizer._find_in_fallbackpath):
  5907. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  5908. (BaselineOptimizerTest.test_platform_mac_different):
  5909. 2012-08-22 Dirk Pranke <dpranke@chromium.org>
  5910. add debug info, another test to webkit-patch optimize-baselines
  5911. https://bugs.webkit.org/show_bug.cgi?id=94762
  5912. Reviewed by Adam Barth.
  5913. This patch adds more debug logging for optimize-baselines so
  5914. that you can tell the before and after states and figure out
  5915. what the command is actually deciding to do.
  5916. Also, this command adds a (disabled) test for the problem in bug
  5917. 94665. It's disabled because we don't have the fix yet (that
  5918. will be posted in a patch to that bug).
  5919. There should be no functional changes in this patch apart from
  5920. the additional logging.
  5921. Note that adding the debug logging exposed a bug in
  5922. filesystem_mock.relpath() (that would return None if the path
  5923. wasn't a subpath of the start); the real relpath computes a
  5924. relpath with parent dirs. Fixing this revealed a bad check in
  5925. the style checker's change_directory() call which was checking
  5926. for None.
  5927. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  5928. (BaselineOptimizer._find_optimal_result_placement):
  5929. (BaselineOptimizer):
  5930. (BaselineOptimizer._optimize_by_most_specific_common_directory):
  5931. (BaselineOptimizer._move_baselines):
  5932. (BaselineOptimizer.optimize):
  5933. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  5934. (BaselineOptimizerTest.disabled_test_platform_mac_different):
  5935. * Scripts/webkitpy/common/system/filesystem.py:
  5936. (FileSystem):
  5937. * Scripts/webkitpy/common/system/filesystem_mock.py:
  5938. (MockFileSystem):
  5939. (MockFileSystem.__init__):
  5940. (MockFileSystem.relpath):
  5941. * Scripts/webkitpy/common/system/filesystem_unittest.py:
  5942. (RealFileSystemTest.test_sep):
  5943. * Scripts/webkitpy/style/main.py:
  5944. (change_directory):
  5945. 2012-08-22 Alejandro Piñeiro <apinheiro@igalia.com>
  5946. Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
  5947. https://bugs.webkit.org/show_bug.cgi?id=73819
  5948. Reviewed by Chris Fleizach.
  5949. Added a new role, Toggle Button, based on whether aria-pressed is present.
  5950. http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
  5951. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
  5952. (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
  5953. 2012-08-23 Victor Carbune <victor@rosedu.org>
  5954. Add myself to the committer list
  5955. https://bugs.webkit.org/show_bug.cgi?id=94659
  5956. Reviewed by James Robinson.
  5957. Added my email and IRC handle.
  5958. * Scripts/webkitpy/common/config/committers.py:
  5959. 2012-08-22 Scott Graham <scottmg@chromium.org>
  5960. Don't unconditionally define NOMINMAX on Windows
  5961. https://bugs.webkit.org/show_bug.cgi?id=94742
  5962. Reviewed by Adrienne Walker.
  5963. Avoids a warning when building on Windows when NOMINMAX is defined
  5964. elsewhere or on the command line.
  5965. * TestWebKitAPI/config.h:
  5966. 2012-08-22 Zan Dobersek <zandobersek@gmail.com>
  5967. REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
  5968. https://bugs.webkit.org/show_bug.cgi?id=94704
  5969. Reviewed by Dirk Pranke.
  5970. Use tolerance=0 when acquiring diff image of reftest output.
  5971. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  5972. (SingleTestRunner._compare_output_with_reference):
  5973. 2012-08-22 Tommy Widenflycht <tommyw@google.com>
  5974. [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
  5975. https://bugs.webkit.org/show_bug.cgi?id=93091
  5976. Reviewed by Adam Barth.
  5977. Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
  5978. to complete the infrastructure for RTCPeerConnection.
  5979. * DumpRenderTree/DumpRenderTree.gypi:
  5980. * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
  5981. (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
  5982. * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
  5983. (MockWebKitPlatformSupport):
  5984. * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
  5985. * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
  5986. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
  5987. (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
  5988. (MockWebRTCPeerConnectionHandler::initialize):
  5989. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
  5990. (WebKit):
  5991. (MockWebRTCPeerConnectionHandler):
  5992. (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
  5993. 2012-08-21 Ryosuke Niwa <rniwa@webkit.org>
  5994. Merge TestExpectationSerializer into TestExpectationLine
  5995. https://bugs.webkit.org/show_bug.cgi?id=94638
  5996. Reviewed by Dimitri Glazkov.
  5997. Moved all methods except, list_to_string which was moved to TestExpectations
  5998. from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.
  5999. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  6000. (TestExpectationEditorTests.assert_remove_roundtrip):
  6001. (TestExpectationEditorTests.assert_update_roundtrip):
  6002. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  6003. (ParseError.__repr__):
  6004. (TestExpectationLine):
  6005. (TestExpectationLine.create_passing_expectation):
  6006. (TestExpectationLine.to_string): Moved from TestExpectationSerializer.
  6007. (TestExpectationLine.to_csv): Ditto.
  6008. (TestExpectationLine._serialize_parsed_expectations): Ditto.
  6009. (TestExpectationLine._serialize_parsed_modifiers): Ditto.
  6010. (TestExpectationLine._format_line):
  6011. (TestExpectations.remove_configuration_from_test):
  6012. (TestExpectations.remove_rebaselined_tests):
  6013. (TestExpectations.add_skipped_tests):
  6014. (TestExpectations):
  6015. (TestExpectations.list_to_string): Moved from TestExpectationSerializer.
  6016. (TestExpectations.list_to_string.serialize):
  6017. (TestExpectations.list_to_string.nones_out):
  6018. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  6019. (TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
  6020. (TestExpectationSerializationTests.__init__):
  6021. (TestExpectationSerializationTests.assert_round_trip):
  6022. (TestExpectationSerializationTests.assert_list_round_trip):
  6023. (TestExpectationSerializationTests.test_unparsed_to_string):
  6024. (TestExpectationSerializationTests.test_unparsed_list_to_string):
  6025. (TestExpectationSerializationTests.test_parsed_to_string):
  6026. (TestExpectationSerializationTests.test_serialize_parsed_expectations):
  6027. (TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
  6028. (TestExpectationSerializationTests.test_format_line):
  6029. (TestExpectationSerializationTests.test_reconstitute_only_these):
  6030. * Scripts/webkitpy/tool/commands/expectations.py:
  6031. (OptimizeExpectations.execute):
  6032. * Scripts/webkitpy/tool/commands/queries.py:
  6033. (PrintExpectations.execute):
  6034. (PrintExpectations._format_lines):
  6035. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  6036. (GardeningExpectationsUpdater.update_expectations):
  6037. 2012-08-22 Alexandre Elias <aelias@chromium.org>
  6038. Unreviewed, add aelias@chromium.org to committers
  6039. I (aelias@chromium.org) have been approved for commit access and Apple
  6040. has confirmed receipt of my committer agreement.
  6041. * Scripts/webkitpy/common/config/committers.py:
  6042. 2012-08-22 Alexey Proskuryakov <ap@apple.com>
  6043. [WK2] Support posting injected bundle messages to a page
  6044. https://bugs.webkit.org/show_bug.cgi?id=94630
  6045. Reviewed by Sam Weinig.
  6046. * MiniBrowser/mac/WebBundle/WebBundleMain.m:
  6047. * TestWebKitAPI/InjectedBundleController.cpp:
  6048. (TestWebKitAPI::InjectedBundleController::initialize):
  6049. (TestWebKitAPI::InjectedBundleController::didReceiveMessageToPage):
  6050. * TestWebKitAPI/InjectedBundleController.h:
  6051. * TestWebKitAPI/InjectedBundleTest.h:
  6052. (TestWebKitAPI::InjectedBundleTest::didReceiveMessageToPage):
  6053. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  6054. (WTR::InjectedBundle::didReceiveMessage):
  6055. (WTR::InjectedBundle::didReceiveMessageToPage):
  6056. (WTR::InjectedBundle::initialize):
  6057. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  6058. Updated for new client API call.
  6059. 2012-08-22 Dominic Mazzoni <dmazzoni@google.com>
  6060. REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
  6061. https://bugs.webkit.org/show_bug.cgi?id=94200
  6062. Reviewed by Chris Fleizach.
  6063. Adds reference counting for AtkObjects referenced by
  6064. AccessibilityUIElementGtk. This prevents bogus results and
  6065. assertion failures on AccessibilityUIElements whose underlying
  6066. object has been deleted (as opposed to just made defunct).
  6067. This fixes two tests that were previously failing because of this bug.
  6068. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  6069. (AccessibilityUIElement::AccessibilityUIElement):
  6070. (AccessibilityUIElement::~AccessibilityUIElement):
  6071. 2012-08-22 Gustavo Noronha Silva <gns@gnome.org>
  6072. [GTK] Split WebCore/platform into a separate library
  6073. https://bugs.webkit.org/show_bug.cgi?id=94435
  6074. Reviewed by Martin Robinson.
  6075. More people have been reporting problems when linking WebCore because
  6076. the command line limit is being exceeded. Splitting WebCore a bit more
  6077. is in order.
  6078. * GNUmakefile.am: link libWebCorePlatform into DRT
  6079. 2012-08-22 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  6080. Unreviewed buildfix for Qt-minimal after r126291
  6081. Disable smooth scrolling when request-animation-frame has been disabled either
  6082. explicitly or as part of --minimal.
  6083. * qmake/mkspecs/features/features.prf:
  6084. 2012-08-22 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  6085. [Qt] Optionally support smooth-scrolling on all platforms
  6086. https://bugs.webkit.org/show_bug.cgi?id=74926
  6087. Reviewed by Simon Hausmann.
  6088. Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
  6089. setting in QtTestBrowser so it can be tested.
  6090. * QtTestBrowser/launcherwindow.cpp:
  6091. (LauncherWindow::createChrome):
  6092. (LauncherWindow::toggleScrollAnimator):
  6093. * QtTestBrowser/launcherwindow.h:
  6094. (WindowOptions::WindowOptions):
  6095. (WindowOptions):
  6096. (LauncherWindow):
  6097. * qmake/mkspecs/features/features.pri:
  6098. 2012-08-22 Dominik Röttsches <dominik.rottsches@intel.com>
  6099. Unreviewed, adding myself to committers.py.
  6100. * Scripts/webkitpy/common/config/committers.py:
  6101. 2012-08-21 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  6102. [GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
  6103. https://bugs.webkit.org/show_bug.cgi?id=94669
  6104. Reviewed by Carlos Garcia Campos.
  6105. Fix memory leaks in DRT's EventSender code.
  6106. * DumpRenderTree/gtk/EventSender.cpp:
  6107. (getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
  6108. (contextClickCallback): Use GOwnPtr to manage memory of a
  6109. newly-allocated list automatically.
  6110. 2012-08-21 Dirk Pranke <dpranke@chromium.org>
  6111. Add mountain lion to perf-tests, layout tests
  6112. https://bugs.webkit.org/show_bug.cgi?id=94553
  6113. Reviewed by Adam Barth.
  6114. This patch adds support for the 'mac-mountainlion' platform and
  6115. stamps out the last references to 'mac-leopard' as a supported
  6116. name.
  6117. This patch does a small amount of refactoring to try and make
  6118. things a little clearer how we treat the "most recent version"
  6119. specially for baselines and skipped files, and so you only
  6120. should have to touch the VERSION_FALLBACK_ORDER constants on the
  6121. ports, but unfortunately changing this list changes a bunch of
  6122. the unit tests which are doing exact matches for correctness, so
  6123. you have to touch more than a couple files :(. There's probably
  6124. still more refactoring that can be done so that we don't have to
  6125. do all of this functional testing to feel completely correct.
  6126. * Scripts/webkitpy/common/system/platforminfo.py:
  6127. (PlatformInfo._determine_mac_version):
  6128. * Scripts/webkitpy/common/system/platforminfo_unittest.py:
  6129. (TestPlatformInfo.test_os_version):
  6130. * Scripts/webkitpy/layout_tests/port/apple.py:
  6131. (ApplePort.__init__):
  6132. (ApplePort):
  6133. (ApplePort._skipped_file_search_paths):
  6134. (ApplePort._generate_all_test_configurations):
  6135. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  6136. (ChromiumMacPort):
  6137. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  6138. (FactoryTest.test_mac):
  6139. * Scripts/webkitpy/layout_tests/port/mac.py:
  6140. (MacPort):
  6141. (MacPort._build_driver_flags):
  6142. (MacPort.should_retry_crashes):
  6143. (MacPort.default_baseline_search_path):
  6144. (MacPort.operating_system):
  6145. (MacPort.default_child_processes):
  6146. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  6147. (MacTest):
  6148. (MacTest.test_skipped_file_search_paths):
  6149. (test_versions):
  6150. (test_baseline_search_path):
  6151. * Scripts/webkitpy/layout_tests/port/win.py:
  6152. (WinPort):
  6153. (WinPort.default_baseline_search_path):
  6154. 2012-08-21 Zan Dobersek <zandobersek@gmail.com>
  6155. [GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
  6156. https://bugs.webkit.org/show_bug.cgi?id=94617
  6157. Reviewed by Martin Robinson.
  6158. Set the 'enable-file-access-from-file-uris' setting to true when
  6159. resetting default values. The other ports do this as well, giving
  6160. documents with local security origin permission to load other
  6161. local resources.
  6162. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  6163. (resetDefaultsToConsistentValues):
  6164. 2012-08-21 Kent Tamura <tkent@chromium.org>
  6165. [Chromium] DRT produces wrong back-forward list
  6166. https://bugs.webkit.org/show_bug.cgi?id=94575
  6167. Reviewed by Adam Barth.
  6168. DRT clears its history state before running every tests. However
  6169. HistoryController in WebCore isn't reset. So, it is possible that
  6170. 'isNewNavigation' flag is false even though the navigation should be
  6171. handled as "new" for DRT.
  6172. This change might fix a problem of
  6173. fast/forms/select/select-state-restore.html (Bug 90207).
  6174. * DumpRenderTree/chromium/WebViewHost.cpp:
  6175. (WebViewHost::updateForCommittedLoad):
  6176. Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
  6177. Without this change, a navigation entry for this loading won't be recorded.
  6178. 2012-08-21 Thiago Marcos P. Santos <thiago.santos@intel.com>
  6179. [EFL] Enable CSS Text Decoration by default
  6180. https://bugs.webkit.org/show_bug.cgi?id=94483
  6181. Reviewed by Kenneth Rohde Christiansen.
  6182. * Scripts/webkitperl/FeatureList.pm:
  6183. 2012-08-21 Benjamin Poulain <bpoulain@apple.com>
  6184. Store CString data in the CStringBuffer to avoid the double indirection
  6185. https://bugs.webkit.org/show_bug.cgi?id=94562
  6186. Reviewed by Darin Adler.
  6187. Add test coverage for WTF::CString.
  6188. * TestWebKitAPI/CMakeLists.txt:
  6189. * TestWebKitAPI/GNUmakefile.am:
  6190. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  6191. * TestWebKitAPI/Tests/WTF/CString.cpp:
  6192. 2012-08-21 Dirk Pranke <dpranke@chromium.org>
  6193. Text Autosizing: ::first-letter pseudo-element is incorrectly sized
  6194. https://bugs.webkit.org/show_bug.cgi?id=94540
  6195. Reviewed by Ojan Vafai.
  6196. Revert the changes in bugs 94517 and 94396 so that we are
  6197. actually looking for stderr output from ImageDiff and doing
  6198. image compares on ref tests on the wk2 ports again.
  6199. Also, do an actual diff_image() call if the hash checks fail on
  6200. reftests, and only fail the test if we get real diffs (or don't,
  6201. for mismatches).
  6202. Lastly, clean up the log messages to be more helpful.
  6203. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  6204. (SingleTestRunner._compare_image):
  6205. (SingleTestRunner._compare_output_with_reference):
  6206. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  6207. (write_test_result):
  6208. 2012-08-21 Dirk Pranke <dpranke@chromium.org>
  6209. _compare_image() swaps actual and expected images by mistake
  6210. https://bugs.webkit.org/show_bug.cgi?id=94567
  6211. Reviewed by Ojan Vafai.
  6212. Re-work the code so that we consistently pass (expected, actual)
  6213. across all of the compare/diff routines.
  6214. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  6215. (SingleTestRunner._run_compare_test):
  6216. (SingleTestRunner._compare_output):
  6217. (SingleTestRunner._compare_text):
  6218. (SingleTestRunner._compare_audio):
  6219. (SingleTestRunner._compare_image):
  6220. (SingleTestRunner._run_reftest):
  6221. (SingleTestRunner._compare_output_with_reference):
  6222. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  6223. (write_test_result):
  6224. 2012-08-21 Adam Barth <abarth@webkit.org>
  6225. Unreviewed. Move the commit-queue to building release only. Previously,
  6226. we built debug too, but for some reason the debug build doesn't work on
  6227. the bots. We can re-enable debug builds once we fix the underlying
  6228. problem.
  6229. * Scripts/webkitpy/tool/commands/queues.py:
  6230. (CommitQueue.build_style):
  6231. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  6232. 2012-08-21 Ryosuke Niwa <rniwa@webkit.org>
  6233. TestExpectationsParser doesn't warn about test files that don't exist.
  6234. https://bugs.webkit.org/show_bug.cgi?id=94632
  6235. Reviewed by Dirk Pranke.
  6236. Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.
  6237. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  6238. (TestExpectationParser._parse_line):
  6239. (TestExpectationParser._check_test_exists):
  6240. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  6241. (test_parse_warning):
  6242. 2012-08-20 Ryosuke Niwa <rniwa@webkit.org>
  6243. Move free functions in test_expectations to TestExpectations class
  6244. https://bugs.webkit.org/show_bug.cgi?id=94557
  6245. Reviewed by Dirk Pranke.
  6246. Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
  6247. to allow further refactoring.
  6248. * Scripts/webkitpy/common/net/resultsjsonparser.py:
  6249. (JSONTestResult.did_run_as_expected):
  6250. (JSONTestResult._tokenize):
  6251. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  6252. (TestExpectations):
  6253. (TestExpectations.result_was_expected):
  6254. (TestExpectations.remove_pixel_failures):
  6255. (TestExpectations.has_pixel_failures):
  6256. (TestExpectations.suffixes_for_expectations):
  6257. (TestExpectations.matches_an_expected_result):
  6258. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  6259. (MockBugManager.create_bug):
  6260. (test_result_was_expected):
  6261. (test_remove_pixel_failures):
  6262. (test_suffixes_for_expectations):
  6263. * Scripts/webkitpy/tool/commands/rebaseline.py:
  6264. (RebaselineExpectations._tests_to_rebaseline):
  6265. 2012-08-21 Simon Hausmann <simon.hausmann@nokia.com>
  6266. Unreviewed build fix for newer Qt 5: The meaning of private_includes changed to be fully
  6267. self-contained. The module name is not appended automatically anymore.
  6268. * qmake/qt_webkit.pri:
  6269. 2012-08-20 Xianzhu Wang <wangxianzhu@chromium.org>
  6270. [Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
  6271. https://bugs.webkit.org/show_bug.cgi?id=94558
  6272. Reviewed by Dirk Pranke.
  6273. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  6274. (ChromiumAndroidDriver.run_test):
  6275. 2012-08-20 Ryosuke Niwa <rniwa@webkit.org>
  6276. Cleanup TestExpectationParser.parse
  6277. https://bugs.webkit.org/show_bug.cgi?id=94545
  6278. Reviewed by Dirk Pranke.
  6279. Refactor TestExpectations to simplify the code.
  6280. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  6281. (TestExpectationParser.parse): Merged _tokenize_list.
  6282. (TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
  6283. since the check is now done in _parser_modifiers.
  6284. (TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
  6285. (TestExpectationParser._tokenize_line): Renamed from _tokenize.
  6286. (TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
  6287. This is done on a local variable in _parse_modifiers, preserving the original case.
  6288. (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
  6289. of 'rebaseline' against parsed modifiers.
  6290. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  6291. (TestExpectationParserTests._tokenize):
  6292. (TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
  6293. (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
  6294. (TestExpectationSerializerTests._tokenize):
  6295. (TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
  6296. been merged into parse.
  6297. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  6298. (PrintExpectationsTest.test_csv): Preserves the case.
  6299. 2012-08-20 Gustavo Noronha Silva <gns@gnome.org>
  6300. [jhbuild] EFL now runs jhbuild update for every build
  6301. https://bugs.webkit.org/show_bug.cgi?id=94267
  6302. Reviewed by Martin Robinson.
  6303. Try to fix WinCE build by returning the empty string instead of
  6304. env when no jhbuild infrastructure is found.
  6305. * Scripts/webkitdirs.pm:
  6306. (jhbuildWrapperPrefixIfNeeded):
  6307. 2012-08-20 Benjamin Poulain <benjamin@webkit.org>
  6308. Add a watcher for WTF changes
  6309. Unreviewed.
  6310. Add myself as a watcher for changes in WTF.
  6311. * Scripts/webkitpy/common/config/watchlist:
  6312. 2012-08-20 Thiago Marcos P. Santos <thiago.santos@intel.com>
  6313. [EFL] Move jhbuild dependencies based on SVN to tarballs
  6314. https://bugs.webkit.org/show_bug.cgi?id=90374
  6315. Reviewed by Kenneth Rohde Christiansen.
  6316. Moved all the dependencies based on SVN to tarballs taken from a
  6317. equivalent snapshot from the official git mirror. This will make
  6318. update-webkitefl not dependent on network connection after the first
  6319. run. The bots will not fail if EFL SVN server in unreachable.
  6320. The reason why git mirror is not used directly is to minimize the
  6321. total size of source code we need to download.
  6322. * efl/jhbuild.modules:
  6323. 2012-08-20 Simon Fraser <simon.fraser@apple.com>
  6324. Lots of "error, test and reference image have different properties" in pixel test output
  6325. https://bugs.webkit.org/show_bug.cgi?id=92578
  6326. Reviewed by Dirk Pranke.
  6327. Improve ImageDiff's error reporting when test result image and expected image
  6328. differ in their properties.
  6329. * DumpRenderTree/cg/ImageDiffCG.cpp:
  6330. 2012-08-20 Nate Chapin <japhet@chromium.org>
  6331. Unsafe vsprintf usage in TestNetscapePlugin
  6332. https://bugs.webkit.org/show_bug.cgi?id=94522
  6333. Reviewed by Adam Barth.
  6334. * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  6335. (pluginLogWithArguments): Using vsnprintf instead of vsprintf to ensure we don't overflow
  6336. the message buffer.
  6337. (testDocumentOpen):
  6338. (testWindowOpen):
  6339. 2012-08-20 George Staikos <staikos@webkit.org>
  6340. [BlackBerry] Enable XHR Response BLOB
  6341. https://bugs.webkit.org/show_bug.cgi?id=94525
  6342. Reviewed by Rob Buis.
  6343. Turn on the XHR response blob feature for the BlackBerry port.
  6344. * Scripts/webkitperl/FeatureList.pm: Add the feature and enable it.
  6345. 2012-08-20 Dirk Pranke <dpranke@chromium.org>
  6346. Fix change for timeout detection to not crash if we have no output :)
  6347. https://bugs.webkit.org/show_bug.cgi?id=94505
  6348. Unreviewed, build fix.
  6349. * Scripts/webkitpy/layout_tests/port/driver.py:
  6350. (Driver.run_test):
  6351. 2012-08-20 Dirk Pranke <dpranke@chromium.org>
  6352. temporarily disable ImageDiff on WK2 ports for ref tests
  6353. https://bugs.webkit.org/show_bug.cgi?id=94517
  6354. Reviewed by Brady Eidson.
  6355. ImageDiff appears to be unable to handle the pngs returned from
  6356. WebKitTestRunner, so we disable checking images by default
  6357. for ref tests on wk2 ports (unless pixel tests is explicitly enabled).
  6358. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  6359. (SingleTestRunner._compare_output_with_reference):
  6360. 2012-08-20 Dirk Pranke <dpranke@chromium.org>
  6361. Add missing FIXME: to previous change.
  6362. https://bugs.webkit.org/show_bug.cgi?id=94505
  6363. Reviewed by Ojan Vafai.
  6364. * Scripts/webkitpy/layout_tests/port/driver.py:
  6365. (Driver.run_test):
  6366. 2012-08-20 Dirk Pranke <dpranke@chromium.org>
  6367. Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
  6368. https://bugs.webkit.org/show_bug.cgi?id=94505
  6369. Reviewed by Ojan Vafai.
  6370. It looks like if the webprocess times out, WTR may tell NRWT
  6371. that the test completed, but not properly reset its internal
  6372. state, and then return stale output for subsequent tests.
  6373. This patch modifies NRWT temporarily to check for
  6374. "Timed out waiting for final message from web process" in stdout
  6375. and treat that as a timeout (and thus kill WTR); this seems
  6376. to solve the cascade of failures, but of course there's probably
  6377. still a bug in WTR that needs to be fixed.
  6378. * Scripts/webkitpy/layout_tests/port/driver.py:
  6379. (Driver.run_test):
  6380. 2012-08-20 Dirk Pranke <dpranke@chromium.org>
  6381. NRWT reports unexpected EOF
  6382. https://bugs.webkit.org/show_bug.cgi?id=94387
  6383. Reviewed by Adam Barth.
  6384. Stop logging "Unexpected EOF" when we are reading the last few
  6385. bytes from stdout/stderr after stopping the subprocess.
  6386. * Scripts/webkitpy/layout_tests/port/server_process.py:
  6387. (ServerProcess._wait_for_data_and_update_buffers_using_select):
  6388. (ServerProcess.stop):
  6389. 2012-08-20 Brady Eidson <beidson@apple.com>
  6390. Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
  6391. https://bugs.webkit.org/show_bug.cgi?id=94506
  6392. Reviewed by Dirk Pranke.
  6393. When running WK2 tests, don't add the "abort early" command line options.
  6394. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  6395. (ConfigureBuild.start):
  6396. (RunWebKitTests):
  6397. (RunWebKitTests.start):
  6398. (RunWebKit2Tests.start):
  6399. 2012-08-19 Stephanie Lewis <slewis@apple.com>
  6400. Add mountain lion to build config.
  6401. https://bugs.webkit.org/show_bug.cgi?id=94441
  6402. Reviewed by Adam Barth.
  6403. Add Mountain Lion to the build trigger configurations.
  6404. * Scripts/webkitpy/common/config/build.py:
  6405. (_should_file_trigger_build):
  6406. * Scripts/webkitpy/common/config/build_unittest.py:
  6407. (ShouldBuildTest):
  6408. (ShouldBuildTest.test_should_build):
  6409. 2012-08-17 Kiran Muppala <cmuppala@apple.com>
  6410. Add self to webkit contributors list
  6411. https://bugs.webkit.org/show_bug.cgi?id=94409
  6412. Reviewed by Dirk Pranke.
  6413. Add name, email and irc handle to webkit contributors list.
  6414. * Scripts/webkitpy/common/config/committers.py:
  6415. 2012-08-17 Ryosuke Niwa <rniwa@webkit.org>
  6416. Perfalizer should differentiate results with and without the patch
  6417. https://bugs.webkit.org/show_bug.cgi?id=94399
  6418. Reviewed by Dirk Pranke.
  6419. Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
  6420. the results page are labled accordingly.
  6421. Also use _build_without_patch when building without a patch so that we get the right error message.
  6422. * Scripts/webkitpy/tool/commands/perfalizer.py:
  6423. (PerfalizerTask.run):
  6424. (PerfalizerTask._run_perf_test):
  6425. * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
  6426. (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
  6427. 2012-08-17 Dirk Pranke <dpranke@chromium.org>
  6428. nrwt: don't fail tests if ImageDiff fails on the wk2 ports
  6429. https://bugs.webkit.org/show_bug.cgi?id=94396
  6430. Reviewed by Ryosuke Niwa.
  6431. It appears that WTR is generating PNGs that ImageDiff doesn't
  6432. like, and so we're getting lots of "can not get ImageDiff"
  6433. errors (see bug 81962). The change in r124581 made this a test
  6434. failure, and this is causing the WK2 bots to frequently abort
  6435. with 500+ failures.
  6436. This change makes ImageDiff errors not be test failures just for
  6437. WK2 for now until we can better triage what's going on.
  6438. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  6439. (SingleTestRunner._compare_image):
  6440. 2012-08-17 James Robinson <jamesr@chromium.org>
  6441. [chromium] Add a style check for #include "cc/..." in chromium files
  6442. https://bugs.webkit.org/show_bug.cgi?id=94382
  6443. Reviewed by Adam Barth.
  6444. Adds a style check to make sure new chromium code follows the correct convention for including cc files.
  6445. * Scripts/webkitpy/style/checkers/cpp.py:
  6446. (check_include_line):
  6447. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  6448. (OrderOfIncludesTest.test_check_cc_includes):
  6449. 2012-08-17 Ojan Vafai <ojan@chromium.org>
  6450. Delete some dead code from the flakiness dashboard
  6451. https://bugs.webkit.org/show_bug.cgi?id=94380
  6452. Reviewed by Dirk Pranke.
  6453. This code became dead in one of the refactors of how we handle BuilderGroups.
  6454. There's no bug here, it's just dead code.
  6455. * TestResultServer/static-dashboards/builders.js:
  6456. (requestBuilderList):
  6457. (loadBuildersList):
  6458. 2012-08-17 Jochen Eisinger <jochen@chromium.org>
  6459. [chromium] Add content shell bots to the flakiness dashboard
  6460. https://bugs.webkit.org/show_bug.cgi?id=94369
  6461. Reviewed by Ojan Vafai.
  6462. The bots are named $OS (Content Shell).
  6463. * TestResultServer/static-dashboards/builders.js:
  6464. (isChromiumWebkitTipOfTreeTestRunner):
  6465. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  6466. 2012-08-17 Shadi Khalek <shadi@chromium.org>
  6467. Add AV perf layout tests to webkit flakiness dashboard
  6468. https://bugs.webkit.org/show_bug.cgi?id=94255
  6469. Reviewed by Ojan Vafai.
  6470. Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
  6471. The isChromiumDepsAVTestRunner() filter does not work on current builder names.
  6472. It assumes the new names they are getting renamed to (AV Linux, AV Win7).
  6473. * TestResultServer/static-dashboards/builders.js:
  6474. (isChromiumTipOfTreeAVTestRunner):
  6475. (loadBuildersList):
  6476. 2012-08-17 Milian Wolff <milian.wolff@kdab.com>
  6477. [Qt] QtWebKit fails to build with OpenGL support on QNX
  6478. https://bugs.webkit.org/show_bug.cgi?id=93278
  6479. Reviewed by Noam Rosenthal.
  6480. Change the order in which we define WTF_USE_3D_GRAPHICS and ENABLE_WEBGL.
  6481. First, we now defined WTF_USE_3D_GRAPHICS=1, but only if QT_CONFIG
  6482. contains opengl. Furthermore, we disable this feature on win32-* as usual,
  6483. but now also disable it on QNX.
  6484. Then, we set ENABLE_WEBGL=1 but only if we previously set WTF_USE_3D_GRAPHICS=1.
  6485. * qmake/mkspecs/features/features.prf:
  6486. 2012-08-16 Gustavo Noronha Silva <gns@gnome.org>
  6487. [jhbuild] EFL now runs jhbuild update for every build
  6488. https://bugs.webkit.org/show_bug.cgi?id=94267
  6489. Reviewed by Dirk Pranke.
  6490. This change makes EFL's approach to jhbuild more in line with the one
  6491. used by WebKitGTK+. update-webkitefl-libs will only be called by build-
  6492. webkit if --update-efl is given explicitly. The EWS bot will do that
  6493. from now on.
  6494. * Scripts/webkitdirs.pm:
  6495. (jhbuildWrapperPrefixIfNeeded): return jhbuild wrapper only if the
  6496. Dependencies directory exists also for EFL
  6497. (generateBuildSystemFromCMakeProject): no longer run update-webkitefl-libs
  6498. (buildCMakeProjectOrExit): build update-webkitefl-libs if --update-efl is
  6499. given
  6500. * Scripts/webkitpy/common/config/ports.py:
  6501. (EflPort.build_webkit_command): make EWS bots pass --update-efl to build-webkit
  6502. * Scripts/webkitpy/common/config/ports_unittest.py:
  6503. (DeprecatedPortTest.test_efl_port): add unit testing for EFL port
  6504. 2012-08-16 Kent Tamura <tkent@chromium.org>
  6505. Add forms-bugs@chromium.org as a contributor.
  6506. * Scripts/webkitpy/common/config/committers.py:
  6507. 2012-08-16 Gustavo Noronha Silva <gns@gnome.org>
  6508. Unreviewed warning fix, sys.argv is a python construct.
  6509. * Scripts/update-webkitefl-libs:
  6510. 2012-08-16 Dirk Pranke <dpranke@chromium.org>
  6511. NRWT cutting off the output from LayoutTest run under Valgrind
  6512. https://bugs.webkit.org/show_bug.cgi?id=94011
  6513. Reviewed by Ojan Vafai.
  6514. Make NRWT work with valgrind again ... I needed to rework the
  6515. driver infrastructure so that we could get the stderr written
  6516. between a test completing and a process being stopped and
  6517. associate it with the DriverOutput for the test; this meant that
  6518. run_test() needed to stop the driver at the end of the test
  6519. directly if/when appropriate. This also entailed reworking
  6520. run_test() so that we would gather stderr and stdout
  6521. consistently regardless of whether this was a normal test, or
  6522. stop_when_done, or a crash or timeout.
  6523. Also, I had to rework the process_stop_time() (and renamed it to
  6524. driver_stop_timeout) so that it would be longer if --time-out-ms
  6525. was long as well (so that valgrind would get enough time to
  6526. run), and I reworked driver.stop(kill_directly=True) to just
  6527. driver.stop(timeout=0.0).
  6528. Lastly, adding the new stop_when_done parameter entailed
  6529. touching a lot of test mock functions :(.
  6530. This change appeared to be well-covered by existing tests.
  6531. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  6532. (Worker._run_test):
  6533. (Worker._run_test_with_timeout):
  6534. (Worker._run_test_in_another_thread):
  6535. (Worker._run_test_in_another_thread.SingleTestThread.run):
  6536. (Worker._run_test_in_this_thread):
  6537. (Worker._run_single_test):
  6538. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  6539. (run_single_test):
  6540. (SingleTestRunner.__init__):
  6541. (SingleTestRunner._run_compare_test):
  6542. (SingleTestRunner._run_rebaseline):
  6543. (SingleTestRunner._run_reftest):
  6544. * Scripts/webkitpy/layout_tests/port/base.py:
  6545. (Port.driver_stop_timeout):
  6546. (Port.variable.default_configuration):
  6547. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  6548. (ChromiumAndroidPort.driver_stop_timeout):
  6549. (ChromiumAndroidDriver.stop):
  6550. * Scripts/webkitpy/layout_tests/port/driver.py:
  6551. (Driver.run_test):
  6552. (Driver.stop):
  6553. (DriverProxy.run_test):
  6554. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  6555. (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
  6556. * Scripts/webkitpy/layout_tests/port/server_process.py:
  6557. (ServerProcess.write):
  6558. (ServerProcess._wait_for_data_and_update_buffers_using_select):
  6559. (ServerProcess.stop):
  6560. (ServerProcess.kill):
  6561. (ServerProcess):
  6562. (ServerProcess._kill):
  6563. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  6564. (TrivialMockPort.__init__):
  6565. (MockProc.wait):
  6566. (TestServerProcess.test_basic):
  6567. * Scripts/webkitpy/layout_tests/port/test.py:
  6568. (TestDriver.run_test):
  6569. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  6570. (get_tests_run.RecordingTestDriver.run_test):
  6571. * Scripts/webkitpy/performance_tests/perftest.py:
  6572. (PerfTest.run_single):
  6573. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  6574. (TestPageLoadingPerfTest.MockDriver.run_test):
  6575. (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
  6576. (TestReplayPerfTest.test_run_single.run_test):
  6577. (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
  6578. (TestReplayPerfTest.test_prepare.run_test):
  6579. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  6580. (MainTest.TestDriver.run_test):
  6581. 2012-08-16 Roger Fong <roger_fong@apple.com>
  6582. Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
  6583. https://bugs.webkit.org/show_bug.cgi?id=94228
  6584. Reviewed by Tim Horton.
  6585. I previously made the change but made a typo that causes the script not ignore mismatch ref tests.
  6586. * Scripts/old-run-webkit-tests:
  6587. (isUsedInReftest):
  6588. 2012-08-16 Peter Beverloo <peter@chromium.org>
  6589. [Chromium] Pass the --strip-binary argument to the apk test generator
  6590. https://bugs.webkit.org/show_bug.cgi?id=94224
  6591. Reviewed by Adam Barth.
  6592. The native test generator currently relies on the $STRIP environment
  6593. variable to be available, which it shouldn't do. Instead, pass it as an
  6594. argument to the script. The $STRIP variable is being deprecated.
  6595. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  6596. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  6597. 2012-08-16 Xiaobo Wang <xbwang@torchmobile.com.cn>
  6598. [BlackBerry] Update format of JS console message to keep consistent with other ports.
  6599. https://bugs.webkit.org/show_bug.cgi?id=94058
  6600. Reviewed by Yong Li.
  6601. Reviewed internally by George Staikos.
  6602. 1. Remove line number if it's zero.
  6603. 2. Print only file name for "file://" URL.
  6604. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  6605. (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
  6606. 2012-08-16 Simon Hausmann <simon.hausmann@nokia.com>
  6607. [Qt] Make DRT results more reliable on X11
  6608. Reviewed by Jocelyn Turcotte.
  6609. Disable desktop setting awareness, to prevent QApplication on X11 from reading palette settings from
  6610. the running desktop environment.
  6611. * DumpRenderTree/qt/main.cpp:
  6612. (main):
  6613. 2012-08-16 Pierre Rossi <pierre.rossi@gmail.com>
  6614. [Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
  6615. https://bugs.webkit.org/show_bug.cgi?id=93960
  6616. Reviewed by Simon Hausmann.
  6617. Following the removal of Qt 4 support from trunk in r124879.
  6618. * qmake/mkspecs/features/features.prf:
  6619. 2012-08-16 Taiju Tsuiki <tzik@chromium.org>
  6620. Add deleteFileSystem support to DumpRenderTree for chromium
  6621. https://bugs.webkit.org/show_bug.cgi?id=94071
  6622. Reviewed by Kent Tamura.
  6623. * DumpRenderTree/chromium/WebViewHost.cpp:
  6624. (WebViewHost::deleteFileSystem): Added
  6625. * DumpRenderTree/chromium/WebViewHost.h:
  6626. (WebViewHost):
  6627. 2012-08-15 Ryosuke Niwa <rniwa@webkit.org>
  6628. Rename LayoutTestController to TestRunner in WebKitTestRunner
  6629. https://bugs.webkit.org/show_bug.cgi?id=93942
  6630. Reviewed by Simon Fraser.
  6631. Renamed the class and relevant files.
  6632. * WebKitTestRunner/CMakeLists.txt:
  6633. * WebKitTestRunner/DerivedSources.make:
  6634. * WebKitTestRunner/GNUmakefile.am:
  6635. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
  6636. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
  6637. * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  6638. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  6639. (WTR::InjectedBundle::didReceiveMessage):
  6640. (WTR::InjectedBundle::beginTesting):
  6641. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  6642. (WTR::InjectedBundle::testRunner):
  6643. (InjectedBundle):
  6644. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  6645. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
  6646. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
  6647. * WebKitTestRunner/InjectedBundle/Target.pri:
  6648. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
  6649. * WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.
  6650. (TestRunner):
  6651. * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
  6652. * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.
  6653. (WTR::waitToDumpWatchdogTimerCallback):
  6654. (WTR::TestRunner::platformInitialize):
  6655. (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
  6656. (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
  6657. (WTR::TestRunner::pathToLocalResource):
  6658. (WTR::TestRunner::platformName):
  6659. * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
  6660. * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.
  6661. (WTR::waitToDumpWatchdogTimerCallback):
  6662. (WTR::TestRunner::platformInitialize):
  6663. (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
  6664. (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
  6665. (WTR::TestRunner::pathToLocalResource):
  6666. (WTR::TestRunner::platformName):
  6667. * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
  6668. * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.
  6669. (WTR::TestRunner::platformInitialize):
  6670. (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
  6671. (WTR::waitUntilDoneWatchdogTimerFired):
  6672. (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
  6673. (WTR::TestRunner::pathToLocalResource):
  6674. (WTR::TestRunner::platformName):
  6675. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
  6676. * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.
  6677. (WTR::WatchdogTimerHelper::timerFired):
  6678. (WTR::TestRunner::platformInitialize):
  6679. (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
  6680. (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
  6681. (WTR::TestRunner::pathToLocalResource):
  6682. (WTR::TestRunner::platformName):
  6683. * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
  6684. * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.
  6685. (WTR::TestRunner::platformInitialize):
  6686. (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
  6687. (WTR::waitToDumpWatchdogTimerFired):
  6688. (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
  6689. (WTR::TestRunner::pathToLocalResource):
  6690. (WTR::TestRunner::platformName):
  6691. * WebKitTestRunner/PlatformEfl.cmake:
  6692. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  6693. * WebKitTestRunner/win/InjectedBundle.vcproj:
  6694. 2012-08-15 Xianzhu Wang <wangxianzhu@chromium.org>
  6695. [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
  6696. https://bugs.webkit.org/show_bug.cgi?id=94155
  6697. Reviewed by Dirk Pranke.
  6698. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  6699. (ChromiumAndroidPort.create_driver): Force no_timeout=True
  6700. 2012-08-15 Ryosuke Niwa <rniwa@webkit.org>
  6701. Add a hyperlink to perf-o-matic from build.webkit.org/root.html
  6702. https://bugs.webkit.org/show_bug.cgi?id=93749
  6703. Reviewed by Csaba Osztrogonác.
  6704. Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
  6705. of performance tests.
  6706. * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  6707. 2012-08-15 Bruno de Oliveira Abinader <bruno.abinader@basyskom.com>
  6708. [css3-text] Add CSS3 Text decoration compile flag
  6709. https://bugs.webkit.org/show_bug.cgi?id=93863
  6710. Reviewed by Julien Chaffraix.
  6711. This patch handles the compile flag implementation, which will come disabled by
  6712. default, thus not exposing the CSS3 text decoration features to the web, unless
  6713. when explicitly enabling it with "--css3-text-decoration" build parameter.
  6714. * Scripts/webkitperl/FeatureList.pm:
  6715. * qmake/mkspecs/features/features.pri:
  6716. 2012-08-15 Beth Dakin <bdakin@apple.com>
  6717. https://bugs.webkit.org/show_bug.cgi?id=93693
  6718. [WK2] REGRESSION(125091): pixel results don't sow scrollbars
  6719. anymore
  6720. Reviewed by Sam Weinig.
  6721. Use new API WKBundlePageCreateSnapshotWithOptions().
  6722. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  6723. (WTR::InjectedBundlePage::dump):
  6724. 2012-08-15 Alexey Proskuryakov <ap@apple.com>
  6725. Add rfong to Bugzilla CC "contributor" list.
  6726. * Scripts/webkitpy/common/config/committers.py:
  6727. 2012-08-15 Scott Graham <scottmg@chromium.org>
  6728. Rename window.internals.fastMallocStatistics to mallocStatistics
  6729. https://bugs.webkit.org/show_bug.cgi?id=94033
  6730. Reviewed by Adam Barth.
  6731. * GNUmakefile.am:
  6732. * Scripts/webkitpy/performance_tests/perftest.py:
  6733. (PerfTest):
  6734. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  6735. (test_run_memory_test):
  6736. 2012-08-15 Peter Beverloo <peter@chromium.org>
  6737. Fix a warning in TestWebKitAPI's MediaTime test-suite
  6738. https://bugs.webkit.org/show_bug.cgi?id=94096
  6739. Reviewed by Adam Barth.
  6740. This warning is visible when building the file with certain GCC versions,
  6741. including the one used by Chromium for Android. The warning is visible in
  6742. the cr-android build bot output:
  6743. MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90
  6744. * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
  6745. (TestWebKitAPI::TEST):
  6746. 2012-08-15 Kevin Funk <kevin.funk@kdab.com>
  6747. Fix the 'git log' call in VCSUtils.pm for Windows
  6748. https://bugs.webkit.org/show_bug.cgi?id=94113
  6749. Reviewed by Kenneth Rohde Christiansen.
  6750. Failed because of invalid enquoting characters.
  6751. * Scripts/VCSUtils.pm:
  6752. 2012-08-14 Gustavo Noronha Silva <gns@gnome.org>
  6753. [jhbuild] move md5sum checking to update-webkit-libs-jhbuild
  6754. https://bugs.webkit.org/show_bug.cgi?id=93208
  6755. Reviewed by Martin Robinson.
  6756. This change makes the md5sum check and saving be done by the script
  6757. that performs the dependencies update. build-webkit no longer prefixes
  6758. calls to commands with jhbuild-wrapper if jhbuild has not been
  6759. bootstrapped by the developer and --update-gtk is not given.
  6760. * Scripts/update-webkit-libs-jhbuild:
  6761. (getMD5HashForFile): moved from webkitdirs.
  6762. (jhbuildConfigurationChanged): ditto.
  6763. (saveJhbuildMd5): ditto.
  6764. (cleanJhbuild): ditto, and changed to run jhbuild clean before removing
  6765. jhbuild.
  6766. * Scripts/webkitdirs.pm:
  6767. (runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
  6768. (buildAutotoolsProject): ditto.
  6769. (jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
  6770. (generateBuildSystemFromCMakeProject): call update-webkitefl-libs
  6771. unconditionally for EFL.
  6772. * jhbuild/jhbuild-wrapper:
  6773. (update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
  6774. update script itself
  6775. (ensure_jhbuild): remove update call.
  6776. 2012-08-15 Christophe Dumez <christophe.dumez@intel.com>
  6777. [WK2] Add support for Web Intents MessagePorts
  6778. https://bugs.webkit.org/show_bug.cgi?id=89072
  6779. Reviewed by Kenneth Rohde Christiansen.
  6780. Use WKBundleIntent instead of WebIntentData in
  6781. WebKitTestRunner. WTR now prints the number of
  6782. MessagePorts in received Web intents as
  6783. expected by the following layout tests:
  6784. webintents/web-intents-invoke-port.html
  6785. webintents/web-intents-obj-constructor.html
  6786. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  6787. (WTR::InjectedBundlePage::didReceiveIntentForFrame):
  6788. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  6789. (WTR::LayoutTestController::deliverWebIntent):
  6790. 2012-08-14 Ryosuke Niwa <rniwa@webkit.org>
  6791. Build fix after r125516. Revert the erroneous rename since we need to keep exposing
  6792. layoutTestController in Chromium port as explained r124785.
  6793. * DumpRenderTree/chromium/TestShell.cpp:
  6794. (TestShell::bindJSObjectsToWindow):
  6795. 2012-08-14 Dan Bernstein <mitz@apple.com>
  6796. fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
  6797. https://bugs.webkit.org/show_bug.cgi?id=94045
  6798. Reviewed by Geoff Garen.
  6799. * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  6800. (-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
  6801. needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.
  6802. 2012-08-14 Alexey Proskuryakov <ap@apple.com>
  6803. [WK2] Fix some typos in MiniBrowser
  6804. https://bugs.webkit.org/show_bug.cgi?id=94047
  6805. Reviewed by Jon Honeycutt.
  6806. * MiniBrowser/mac/AppDelegate.m:
  6807. (didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):
  6808. * MiniBrowser/mac/WebBundle/WebBundleMain.m:
  6809. (didReceiveMessage):
  6810. (WKBundleInitialize):
  6811. 2012-08-14 Roger Fong <roger_fong@apple.com>
  6812. old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
  6813. https://bugs.webkit.org/show_bug.cgi?id=93904
  6814. Reviewed by Tim Horton.
  6815. old-run-webkit-tests ref test only skipped .html test.
  6816. They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.
  6817. * Scripts/old-run-webkit-tests:
  6818. (isUsedInReftest): Skip all extensions for ref tests.
  6819. 2012-08-14 Lauro Neto <lauro.neto@openbossa.org>
  6820. Convert signals/slots to Q_* macros.
  6821. [Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
  6822. https://bugs.webkit.org/show_bug.cgi?id=93996
  6823. Reviewed by Kenneth Rohde Christiansen.
  6824. Change usage of keyword-conflicting 'signals' and 'slots' for
  6825. Q_SIGNALS and Q_SLOTS macro.
  6826. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  6827. (NetworkAccessManager):
  6828. (WebPage):
  6829. * DumpRenderTree/qt/EventSenderQt.h:
  6830. (EventSender):
  6831. * DumpRenderTree/qt/GCControllerQt.h:
  6832. (GCController):
  6833. * DumpRenderTree/qt/TestRunnerQt.h:
  6834. (TestRunner):
  6835. * DumpRenderTree/qt/TextInputControllerQt.h:
  6836. (TextInputController):
  6837. * MiniBrowser/qt/BrowserWindow.h:
  6838. (BrowserWindow):
  6839. * MiniBrowser/qt/MiniBrowserApplication.h:
  6840. (WindowOptions):
  6841. * MiniBrowser/qt/UrlLoader.h:
  6842. (UrlLoader):
  6843. * QtTestBrowser/cookiejar.h:
  6844. (TestBrowserCookieJar):
  6845. * QtTestBrowser/fpstimer.h:
  6846. (FpsTimer):
  6847. * QtTestBrowser/launcherwindow.h:
  6848. (LauncherWindow):
  6849. * QtTestBrowser/locationedit.h:
  6850. (LocationEdit):
  6851. * QtTestBrowser/mainwindow.h:
  6852. (MainWindow):
  6853. * QtTestBrowser/urlloader.h:
  6854. (UrlLoader):
  6855. * QtTestBrowser/webinspector.h:
  6856. (WebInspector):
  6857. * QtTestBrowser/webpage.h:
  6858. (WebPage):
  6859. * QtTestBrowser/webview.h:
  6860. (WebViewGraphicsBased):
  6861. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  6862. (WatchdogTimerHelper):
  6863. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  6864. (WrapperWindow):
  6865. * WebKitTestRunner/qt/main.cpp:
  6866. (Launcher):
  6867. 2012-08-14 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  6868. WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
  6869. https://bugs.webkit.org/show_bug.cgi?id=42332
  6870. Reviewed by Kenneth Rohde Christiansen.
  6871. Added Resource Callbacks logging. Several aux dumping functions are added.
  6872. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  6873. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  6874. (WTR::isFileScheme):
  6875. (WTR):
  6876. (WTR::pathSuitableForTestResult):
  6877. (WTR::urlSuitableForTestResult):
  6878. (WTR::InjectedBundlePage::resetAfterTest):
  6879. (WTR::dumpRequestDescriptionSuitableForTestResult):
  6880. (WTR::dumpResponseDescriptionSuitableForTestResult):
  6881. (WTR::dumpErrorDescriptionSuitableForTestResult):
  6882. (WTR::InjectedBundlePage::didInitiateLoadForResource):
  6883. (WTR::InjectedBundlePage::willSendRequestForFrame):
  6884. (WTR::InjectedBundlePage::didReceiveResponseForResource):
  6885. (WTR::InjectedBundlePage::didFinishLoadForResource):
  6886. (WTR::InjectedBundlePage::didFailLoadForResource):
  6887. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  6888. (WTR::LayoutTestController::LayoutTestController):
  6889. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  6890. (WTR::LayoutTestController::dumpResourceLoadCallbacks):
  6891. (WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
  6892. (LayoutTestController):
  6893. 2012-08-14 Alexis Menard <alexis.menard@openbossa.org>
  6894. Update INdT build bot to Mountain Lion.
  6895. https://bugs.webkit.org/show_bug.cgi?id=93963
  6896. Reviewed by Csaba Osztrogonác.
  6897. We updated the machine as well as the OS as the Qt port is now running
  6898. on top of Qt5.
  6899. * BuildSlaveSupport/build.webkit.org-config/config.json:
  6900. 2012-08-14 Peter Beverloo <peter@chromium.org>
  6901. [Chromium] Remove unneeded build logic for Android
  6902. https://bugs.webkit.org/show_bug.cgi?id=93962
  6903. Reviewed by Dimitri Glazkov.
  6904. The Android SDK and NDK have been checked in to the Chromium tree, which
  6905. allows WebKit to leverage those as well. They will already be pulled in
  6906. through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
  6907. environment variable, the envsetup.sh will set the project files up
  6908. appropriately for us.
  6909. * Scripts/webkitdirs.pm:
  6910. 2012-08-14 Sergio Villar Senin <svillar@igalia.com>
  6911. [WK2] [GTK] Plugin tests failing in WK2 bot
  6912. https://bugs.webkit.org/show_bug.cgi?id=93954
  6913. Reviewed by Carlos Garcia Campos.
  6914. Plugin tests are failing in the WK2 bot because we aren't exporting
  6915. the Netscape plugin when creating the product archive.
  6916. * BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
  6917. to the list of directories to export.
  6918. (archiveBuiltProduct):
  6919. 2012-08-14 Peter Beverloo <peter@chromium.org>
  6920. [Chromium] Fix apk generation for the Android platform
  6921. https://bugs.webkit.org/show_bug.cgi?id=93841
  6922. Unreviewed build fix.
  6923. APK generation was broken as the configuration file assumed compilation
  6924. would only occur in the Chromium tree. Pass the path to Chromium's source
  6925. base directory as a property to ant.
  6926. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  6927. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  6928. 2012-08-14 Sergio Villar Senin <svillar@igalia.com>
  6929. [GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
  6930. https://bugs.webkit.org/show_bug.cgi?id=91083
  6931. Reviewed by Carlos Garcia Campos.
  6932. Unskipped a couple of API tests that should work fine from now on.
  6933. * Scripts/run-gtk-tests:
  6934. (TestRunner):
  6935. 2012-08-14 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  6936. [NRWT] Compare results between different platforms
  6937. https://bugs.webkit.org/show_bug.cgi?id=90555
  6938. Reviewed by Dirk Pranke.
  6939. * Scripts/webkitpy/layout_tests/port/base.py:
  6940. (Port.baseline_search_path):
  6941. (Port):
  6942. (Port.compare_baseline):
  6943. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  6944. (parse_args):
  6945. 2012-08-13 Ryosuke Niwa <rniwa@webkit.org>
  6946. Rename LayoutTestController to TestRunner in DumpRenderTree
  6947. https://bugs.webkit.org/show_bug.cgi?id=93758
  6948. Reviewed by Tony Chang.
  6949. Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
  6950. since it already has TestRunner class shared between DumpRenderTree and content_shell.
  6951. * DumpRenderTree/DumpRenderTree.h:
  6952. * DumpRenderTree/PixelDumpSupport.cpp:
  6953. * DumpRenderTree/StorageTrackerDelegate.h:
  6954. * DumpRenderTree/StorageTrackerDelegate.mm:
  6955. * DumpRenderTree/TestRunner.cpp:
  6956. * DumpRenderTree/TestRunner.h:
  6957. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  6958. * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  6959. * DumpRenderTree/chromium/DRTTestRunner.cpp:
  6960. * DumpRenderTree/chromium/DRTTestRunner.h:
  6961. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  6962. * DumpRenderTree/chromium/NotificationPresenter.h:
  6963. * DumpRenderTree/chromium/TestShell.cpp:
  6964. * DumpRenderTree/chromium/TestShell.h:
  6965. * DumpRenderTree/chromium/WebPermissions.cpp:
  6966. * DumpRenderTree/chromium/WebPermissions.h:
  6967. * DumpRenderTree/chromium/WebViewHost.cpp:
  6968. * DumpRenderTree/chromium/WebViewHost.h:
  6969. * DumpRenderTree/efl/DumpRenderTree.cpp:
  6970. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  6971. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  6972. * DumpRenderTree/efl/EditingCallbacks.cpp:
  6973. * DumpRenderTree/efl/TestRunnerEfl.cpp:
  6974. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  6975. * DumpRenderTree/gtk/EditingCallbacks.cpp:
  6976. * DumpRenderTree/gtk/TestRunnerGtk.cpp:
  6977. * DumpRenderTree/mac/DumpRenderTree.mm:
  6978. * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  6979. * DumpRenderTree/mac/EditingDelegate.mm:
  6980. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  6981. * DumpRenderTree/mac/HistoryDelegate.mm:
  6982. * DumpRenderTree/mac/PixelDumpSupportMac.mm:
  6983. * DumpRenderTree/mac/PolicyDelegate.h:
  6984. * DumpRenderTree/mac/PolicyDelegate.mm:
  6985. * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  6986. * DumpRenderTree/mac/TestRunnerMac.mm:
  6987. * DumpRenderTree/mac/UIDelegate.mm:
  6988. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  6989. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  6990. * DumpRenderTree/qt/TestRunnerQt.cpp:
  6991. * DumpRenderTree/qt/TestRunnerQt.h:
  6992. * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  6993. * DumpRenderTree/win/DumpRenderTree.cpp:
  6994. * DumpRenderTree/win/EditingDelegate.cpp:
  6995. * DumpRenderTree/win/FrameLoadDelegate.cpp:
  6996. * DumpRenderTree/win/HistoryDelegate.cpp:
  6997. * DumpRenderTree/win/PolicyDelegate.h:
  6998. * DumpRenderTree/win/ResourceLoadDelegate.cpp:
  6999. * DumpRenderTree/win/TestRunnerWin.cpp:
  7000. * DumpRenderTree/win/UIDelegate.cpp:
  7001. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  7002. * DumpRenderTree/wx/TestRunnerWx.cpp:
  7003. 2012-08-14 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  7004. [GTK] String returned by g_path_get_dirname() must be freed
  7005. https://bugs.webkit.org/show_bug.cgi?id=93885
  7006. Reviewed by Philippe Normand.
  7007. Fix a memory leak in GTK's DRT code.
  7008. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  7009. (pathFromSoupURI): Free the string returned by g_path_get_dirname().
  7010. 2012-08-14 Zan Dobersek <zandobersek@gmail.com>
  7011. Unreviewed GTK build fix after r125508.
  7012. Do the renaming in GNUmakefile.am as well, LayoutTestController -> TestRunner.
  7013. * GNUmakefile.am:
  7014. 2012-08-13 Ryosuke Niwa <rniwa@webkit.org>
  7015. Rename files that declare and define LayoutTestController in DumpRenderTree
  7016. https://bugs.webkit.org/show_bug.cgi?id=93899
  7017. Reviewed by Tony Chang.
  7018. Renamed files and fixed style errors.
  7019. * DumpRenderTree/DumpRenderTree.gypi:
  7020. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  7021. * DumpRenderTree/LayoutTestController.cpp: Removed.
  7022. * DumpRenderTree/LayoutTestController.h: Removed.
  7023. * DumpRenderTree/PixelDumpSupport.cpp:
  7024. * DumpRenderTree/StorageTrackerDelegate.mm:
  7025. * DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
  7026. * DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.
  7027. (LayoutTestController):
  7028. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  7029. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
  7030. * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
  7031. * DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
  7032. * DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
  7033. * DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
  7034. * DumpRenderTree/chromium/LayoutTestController.h: Removed.
  7035. * DumpRenderTree/chromium/TestShell.cpp:
  7036. * DumpRenderTree/chromium/TestShell.h:
  7037. * DumpRenderTree/chromium/WebPermissions.cpp:
  7038. * DumpRenderTree/chromium/WebViewHost.cpp:
  7039. * DumpRenderTree/efl/CMakeLists.txt:
  7040. * DumpRenderTree/efl/DumpRenderTree.cpp:
  7041. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  7042. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  7043. * DumpRenderTree/efl/EditingCallbacks.cpp:
  7044. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
  7045. * DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
  7046. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  7047. * DumpRenderTree/gtk/EditingCallbacks.cpp:
  7048. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
  7049. * DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
  7050. * DumpRenderTree/mac/DumpRenderTree.mm:
  7051. * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  7052. * DumpRenderTree/mac/EditingDelegate.mm:
  7053. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  7054. * DumpRenderTree/mac/HistoryDelegate.mm:
  7055. * DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
  7056. * DumpRenderTree/mac/PixelDumpSupportMac.mm:
  7057. * DumpRenderTree/mac/PolicyDelegate.mm:
  7058. * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  7059. * DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
  7060. * DumpRenderTree/mac/UIDelegate.mm:
  7061. * DumpRenderTree/qt/DumpRenderTree.pro:
  7062. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  7063. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
  7064. * DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
  7065. * DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
  7066. * DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.
  7067. (WebCore):
  7068. (LayoutTestController):
  7069. (LayoutTestController::setCloseRemainingWindowsWhenComplete):
  7070. (LayoutTestController::dumpSelectionRect):
  7071. (LayoutTestController::setCallCloseOnWebViews):
  7072. (LayoutTestController::addDisallowedURL):
  7073. (LayoutTestController::abortModal):
  7074. * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  7075. * DumpRenderTree/win/DumpRenderTree.cpp:
  7076. * DumpRenderTree/win/DumpRenderTree.vcproj:
  7077. * DumpRenderTree/win/EditingDelegate.cpp:
  7078. * DumpRenderTree/win/FrameLoadDelegate.cpp:
  7079. * DumpRenderTree/win/HistoryDelegate.cpp:
  7080. * DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
  7081. * DumpRenderTree/win/PolicyDelegate.cpp:
  7082. * DumpRenderTree/win/ResourceLoadDelegate.cpp:
  7083. * DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.
  7084. (LayoutTestController::setUserStyleSheetEnabled):
  7085. (resolveCygwinPath):
  7086. * DumpRenderTree/win/UIDelegate.cpp:
  7087. * DumpRenderTree/wscript:
  7088. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  7089. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
  7090. * DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.
  7091. 2012-08-13 Alex Christensen <alex.christensen@flexsim.com>
  7092. Windows 64 bit compliance
  7093. https://bugs.webkit.org/show_bug.cgi?id=93275
  7094. Reviewed by Brent Fulgham.
  7095. Fixed a few compile and link problems for Win64
  7096. * WinLauncher/WinLauncher.cpp:
  7097. * win/DLLLauncher/DLLLauncherMain.cpp:
  7098. 2012-08-13 MORITA Hajime <morrita@google.com>
  7099. Unreviewed update for webcomponents-bugzilla address.
  7100. * Scripts/webkitpy/common/config/committers.py:
  7101. 2012-08-11 Raphael Kubo da Costa <rakuco@webkit.org>
  7102. [CMake] Rewrite FindLibSoup2.cmake.
  7103. https://bugs.webkit.org/show_bug.cgi?id=93191
  7104. Reviewed by Rob Buis.
  7105. * DumpRenderTree/efl/CMakeLists.txt: Use LIBSOUP_FOO instead of
  7106. LIBSOUP24_FOO, and do not use LIBSOUP24_LDFLAGS, as it is not
  7107. needed anymore.
  7108. * EWebLauncher/CMakeLists.txt: Ditto.
  7109. * MiniBrowser/efl/CMakeLists.txt: Ditto.
  7110. * TestWebKitAPI/PlatformEfl.cmake: Ditto.
  7111. * WebKitTestRunner/CMakeLists.txt: Ditto.
  7112. * WebKitTestRunner/PlatformEfl.cmake: Ditto.
  7113. 2012-08-13 Brady Eidson <beidson@apple.com>
  7114. With asynchronous plug-in initialization, WebProcess and PluginProcess can deadlock
  7115. <rdar://problem/12062125> and https://bugs.webkit.org/show_bug.cgi?id=93894
  7116. Reviewed by Alexey Proskuryakov.
  7117. Add a test that calls out to NPP_Evaluate for some JS inside of NPP_New.
  7118. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  7119. * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp: Added.
  7120. (EvaluteJSWithinNPP_New):
  7121. (EvaluteJSWithinNPP_New::EvaluteJSWithinNPP_New):
  7122. (EvaluteJSWithinNPP_New::NPP_New):
  7123. 2012-08-13 Sheriff Bot <webkit.review.bot@gmail.com>
  7124. Unreviewed, rolling out r125422.
  7125. http://trac.webkit.org/changeset/125422
  7126. https://bugs.webkit.org/show_bug.cgi?id=93902
  7127. Broke the Android canary build (Requested by fmalita on
  7128. #webkit).
  7129. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  7130. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  7131. 2012-08-13 Raphael Kubo da Costa <rakuco@webkit.org>
  7132. [CMake] Remove glib-related Find modules and write single new one instead.
  7133. https://bugs.webkit.org/show_bug.cgi?id=93786
  7134. Reviewed by Rob Buis.
  7135. * DumpRenderTree/efl/CMakeLists.txt: Use GLIB_* instead of Glib_*.
  7136. * EWebLauncher/CMakeLists.txt: Ditto.
  7137. * MiniBrowser/efl/CMakeLists.txt: Ditto.
  7138. * WebKitTestRunner/PlatformEfl.cmake: Ditto.
  7139. 2012-08-13 Peter Beverloo <peter@chromium.org>
  7140. [Chromium] Fix apk generation for the Android platform
  7141. https://bugs.webkit.org/show_bug.cgi?id=93841
  7142. Reviewed by Dimitri Glazkov.
  7143. APK generation was broken as the configuration file assumed compilation
  7144. would only occur in the Chromium tree. Pass the path to Chromium's source
  7145. base directory as a property to ant.
  7146. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  7147. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  7148. 2012-08-13 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  7149. [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
  7150. https://bugs.webkit.org/show_bug.cgi?id=93825
  7151. Reviewed by Antonio Gomes.
  7152. Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke.
  7153. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  7154. (WTR::InjectedBundlePage::didFailLoadForResource):
  7155. 2012-08-13 Kwang Yul Seo <skyul@company100.net>
  7156. [Qt] Add gprof.prf to build WebKit with gprof enabled
  7157. https://bugs.webkit.org/show_bug.cgi?id=90283
  7158. Reviewed by Eric Seidel.
  7159. * qmake/mkspecs/features/functions.prf:
  7160. gprof does not support profiling a shared library.
  7161. To profile WebKit, applications must link QtWebKit statically.
  7162. * qmake/mkspecs/features/gprof.prf: Added.
  7163. Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.
  7164. 2012-08-13 KwangYong Choi <ky0.choi@samsung.com>
  7165. [TestNetscapePlugin][X11] Additional key up event handler routine is required
  7166. https://bugs.webkit.org/show_bug.cgi?id=91357
  7167. Reviewed by Eric Seidel.
  7168. Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
  7169. has-focus.html on X11 architecture. The test can not be done without this patch.
  7170. All other ports implemented it already.
  7171. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  7172. (handleEventX11): Modified key up event handler for X11
  7173. 2012-08-13 Christophe Dumez <christophe.dumez@intel.com>
  7174. [EFL][WK2] Replace Skipped list by TestExpectations
  7175. https://bugs.webkit.org/show_bug.cgi?id=93796
  7176. Reviewed by Kenneth Rohde Christiansen.
  7177. Enable cascaded TestExpectations for EFL port so
  7178. that we can use TestExpectations in WK2-EFL.
  7179. * Scripts/webkitpy/layout_tests/port/efl.py:
  7180. (EflPort._search_paths):
  7181. (EflPort):
  7182. (EflPort.expectations_files):
  7183. 2012-08-13 Peter Gal <galpeter@inf.u-szeged.hu>
  7184. REGRESSION(r125153): It broke the 'Unexpected no expected results' case
  7185. https://bugs.webkit.org/show_bug.cgi?id=93789
  7186. Reviewed by Csaba Osztrogonác.
  7187. Fix the regex, so the text won't be a capturing group.
  7188. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  7189. (RunWebKitTests._parseNewRunWebKitTestsOutput):
  7190. 2012-08-12 MORITA Hajime <morrita@google.com>
  7191. Unreviewed, added a proxy address to contributors_who_are_not_committers.
  7192. * Scripts/webkitpy/common/config/committers.py:
  7193. 2012-08-12 Loïc Yhuel <loic.yhuel@softathome.com>
  7194. [Qt] Make it possible to build without QtTest/QtPrintSupport
  7195. https://bugs.webkit.org/show_bug.cgi?id=93492
  7196. Reviewed by Tor Arne Vestbø.
  7197. * DumpRenderTree/qt/DumpRenderTree.pro: Optional printsupport
  7198. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  7199. (WebCore):
  7200. (WebCore::DumpRenderTree::dryRunPrint): Does nothing if no printsupport
  7201. * QtTestBrowser/QtTestBrowser.pro: Optional printsupport
  7202. * QtTestBrowser/launcherwindow.cpp:
  7203. (LauncherWindow::createChrome): No print menu if no printsupport
  7204. (LauncherWindow::print): Does nothing if no printsupport
  7205. * QtTestBrowser/launcherwindow.h:
  7206. * Tools.pro: Disable DRT/WTR if QtTest not present
  7207. * qmake/mkspecs/features/default_pre.prf: printsupport no more mandatory
  7208. * qmake/mkspecs/features/features.prf: Qt module availability tests
  7209. 2012-08-12 Csaba Osztrogonác <ossy@webkit.org>
  7210. master.cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
  7211. https://bugs.webkit.org/show_bug.cgi?id=90161
  7212. Reviewed by Eric Seidel.
  7213. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  7214. 2012-08-12 Simon Hausmann <simon.hausmann@nokia.com>
  7215. [Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindowsysteminterface.h
  7216. through the QTestLib headers anymore.
  7217. * DumpRenderTree/qt/EventSenderQt.cpp:
  7218. * WebKitTestRunner/Target.pri:
  7219. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  7220. 2012-08-11 Sam Weinig <sam@webkit.org>
  7221. Remove ability to run MiniBrowser in threaded mode, it hasn't worked for a long time
  7222. https://bugs.webkit.org/show_bug.cgi?id=93774
  7223. Reviewed by Dan Bernstein.
  7224. Remove support for opening windows using the shared thread WKContextRef. WKContextGetSharedThreadContext()
  7225. is going away, due to not working for a long time, and the first step is removing all the callers.
  7226. While here, remove the BrowserStatisticsWindow, which was not providing interesting information.
  7227. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  7228. * MiniBrowser/mac/AppDelegate.h:
  7229. * MiniBrowser/mac/AppDelegate.m:
  7230. (-[BrowserAppDelegate init]):
  7231. (-[BrowserAppDelegate newWindow:]):
  7232. (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
  7233. * MiniBrowser/mac/BrowserStatisticsWindow.xib: Removed.
  7234. * MiniBrowser/mac/BrowserStatisticsWindowController.h: Removed.
  7235. * MiniBrowser/mac/BrowserStatisticsWindowController.m: Removed.
  7236. * MiniBrowser/mac/MainMenu.xib:
  7237. * MiniBrowser/win/BrowserView.cpp:
  7238. (BrowserView::create):
  7239. 2012-08-11 Sam Weinig <sam@webkit.org>
  7240. Enable XPC Service based WebProcess with runtime flag
  7241. https://bugs.webkit.org/show_bug.cgi?id=93773
  7242. Reviewed by Dan Bernstein.
  7243. Convert --use-web-process-xpc-service passed to run-safari (and similar scripts)
  7244. to setting WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS=YES in the environment and setting
  7245. up __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_INSERT_LIBRARIES variables. NOTE: using
  7246. the XPC service is not the default code path.
  7247. * Scripts/webkitdirs.pm:
  7248. (shouldUseXPCServiceForWebProcess):
  7249. (determineShouldUseXPCServiceForWebProcess):
  7250. Add functions to extract --use-web-process-xpc-service from ARGV and set a
  7251. global variable.
  7252. (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
  7253. Add help text for --use-web-process-xpc-service.
  7254. (runMacWebKitApp):
  7255. Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
  7256. if --use-web-process-xpc-service was passed on the command line.
  7257. (execMacWebKitAppForDebugging):
  7258. Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
  7259. if --use-web-process-xpc-service was passed on the command line. Also, bail
  7260. if both --use-web-process-xpc-service and --target-web-process are passed on
  7261. the command line, as we don't currently support using both.
  7262. 2012-08-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  7263. [EFL] Bump harfbuzz dependency to v0.9.2
  7264. https://bugs.webkit.org/show_bug.cgi?id=93762
  7265. Reviewed by Eric Seidel.
  7266. EFL port has used harfbuzz 0.9.0 ver. However, the 0.9.2 version was released on 10th Aug 2012.
  7267. In addition, 0.9.0 ver. was disappeared. So, EFL port needs to use 0.9.2 ver. from now on.
  7268. * efl/jhbuild.modules:
  7269. 2012-08-10 Ryosuke Niwa <rniwa@webkit.org>
  7270. run-perf-tests should upload memory statistics to perf-o-matic
  7271. https://bugs.webkit.org/show_bug.cgi?id=93690
  7272. Reviewed by Dirk Pranke.
  7273. Upload JS Heap and FastMalloc results for a test X/Y as: X/Y:JSHeap and X/Y:FastMalloc.
  7274. Note "JS Heap" is converted to the CamelCase JSHeap.
  7275. Also did some refactoring in PerfTest.parse_output and PerfTestRunnerTest and updated
  7276. some helps in PerfTest.parse_output per arv's comments.
  7277. * Scripts/webkitpy/performance_tests/perftest.py:
  7278. (PerfTest):
  7279. (PerfTest.parse_output): Include JSHeap and FastMalloc statistics in results as well as of Time.
  7280. Also refactored it to avoid hard-coding indices in _result_classes and moved complied regular
  7281. exressions out of the function to avoid re-compiling them every time the method runs.
  7282. (PerfTest.output_statistics): Convert ':' to ': ' as well as '/'.
  7283. (ChromiumStylePerfTest.parse_output): Removed an unused variable.
  7284. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  7285. (PerfTestsRunner._parse_args): Uploaded some helps per arv's feedback.
  7286. (PerfTestsRunner._output_json_path): Extracted from _generate_and_show_results to be used in
  7287. PerfTestRunnerTest.create_runner.
  7288. (PerfTestsRunner._generate_and_show_results):
  7289. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  7290. (create_runner): Extracted runner.load_output_json from various tests.
  7291. (test_run_memory_test): Added.
  7292. (PerfTestRunner): Extracted _event_target_wrapper_and_inspector_results from various tests.
  7293. (test_run_with_json_output):
  7294. (test_run_with_description):
  7295. (test_run_generates_json_by_default):
  7296. (test_run_generates_and_show_results_page):
  7297. (test_run_with_json_source):
  7298. (test_run_with_multiple_repositories):
  7299. 2012-08-10 Benjamin Poulain <bpoulain@apple.com>
  7300. Add support for String initialization from literal to WTFString
  7301. https://bugs.webkit.org/show_bug.cgi?id=93426
  7302. Reviewed by Anders Carlsson.
  7303. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  7304. * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
  7305. (TestWebKitAPI::TEST):
  7306. * TestWebKitAPI/Tests/WTF/WTFString.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp.
  7307. (TestWebKitAPI):
  7308. (TestWebKitAPI::TEST):
  7309. 2012-08-10 Xianzhu Wang <wangxianzhu@chromium.org>
  7310. NRWT crashes when DRT with --encode-binary crashes just before it dumps pixels
  7311. https://bugs.webkit.org/show_bug.cgi?id=93728
  7312. Reviewed by Dirk Pranke.
  7313. * Scripts/webkitpy/layout_tests/port/driver.py:
  7314. (ContentBlock.decode_content): Check self.content is not None before calling base64.b64decode().
  7315. 2012-08-10 Xianzhu Wang <wangxianzhu@chromium.org>
  7316. [Chromium-Android][NRWT] Executable might not be pushed correctly when there are multiple builds
  7317. https://bugs.webkit.org/show_bug.cgi?id=93688
  7318. Reviewed by Dirk Pranke.
  7319. There might be other better methods, but this change is the smallest.
  7320. I think the chance of equal timestamp can be ignored because we flock
  7321. to avoid concurrent linkers.
  7322. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  7323. (ChromiumAndroidDriver._push_executable): Changed '<' to '!=' to compare the timestamp.
  7324. 2012-08-09 Xianzhu Wang <wangxianzhu@chromium.org>
  7325. [Chromium-Android] Skip layout tests directories that are not applicable
  7326. https://bugs.webkit.org/show_bug.cgi?id=93670
  7327. Reviewed by Dirk Pranke.
  7328. Added back ChromiumAndroidPort.skipped_layout_tests to skip some whole directories.
  7329. The method is more convenient to skip whole directories than SKIP in TestExpectations
  7330. because its higher priority. Will still use TestExpectations to skip individual tests.
  7331. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  7332. (ChromiumAndroidPort.skipped_layout_tests):
  7333. 2012-08-09 Elliott Sprehn <esprehn@chromium.org>
  7334. Add myself to the Contributor list.
  7335. https://bugs.webkit.org/show_bug.cgi?id=93653
  7336. Reviewed by Dirk Pranke.
  7337. Add my email to the contributor list.
  7338. * Scripts/webkitpy/common/config/committers.py:
  7339. 2012-08-09 Dirk Pranke <dpranke@chromium.org>
  7340. nrwt: should log progress like ninja does
  7341. https://bugs.webkit.org/show_bug.cgi?id=93563
  7342. Reviewed by Ojan Vafai.
  7343. This change modifies the output of nrwt in the
  7344. non--debug-rwt-logging modes.
  7345. In non-verbose mode, the output changes from:
  7346. "Testing (50%): 96 ran as expected, 4 didn't, 100 left"
  7347. to:
  7348. "[100/200] foo.html (+4)"
  7349. or:
  7350. "[100/200] foo.html failed unexpectedly (text diff)"
  7351. which indicates the earliest test currently running (optionally plus the
  7352. count of other currently-executing tests if we're running tests in parallel)
  7353. or the result of said test.
  7354. If the test produces unexpected results, that line is flushed
  7355. rather than erased (so we no longer need the %d didn't running
  7356. tally).
  7357. In --verbose mode, the output is similar, but every test gets a
  7358. line (and tests are logged in order of them being started, not
  7359. order of them being completed) (and in --details mode, the
  7360. first line of each test matches --verbose but the other lines
  7361. are unchanged).
  7362. The overall result should be easier to read and is simpler to
  7363. implement as well (apart from managing the number of tests that
  7364. have started but not completed, which is slightly annoying).
  7365. This also matches the output style for test-webkitpy, more-or-less.
  7366. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  7367. (LayoutTestRunner.run_tests):
  7368. (LayoutTestRunner._update_summary_with_result):
  7369. (LayoutTestRunner._handle_started_test):
  7370. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
  7371. (FakePrinter):
  7372. (FakePrinter.print_started_test):
  7373. (FakePrinter.print_finished_test):
  7374. * Scripts/webkitpy/layout_tests/views/printing.py:
  7375. (Printer.__init__):
  7376. (Printer.print_started_test):
  7377. (Printer.print_finished_test):
  7378. (Printer._print_test_trace):
  7379. (Printer._print_progress):
  7380. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  7381. (test_details):
  7382. 2012-08-09 Alexey Proskuryakov <ap@apple.com>
  7383. [WK2] Add a process model constant for multiple processes
  7384. https://bugs.webkit.org/show_bug.cgi?id=93642
  7385. Reviewed by Anders Carlsson.
  7386. * MiniBrowser/mac/AppDelegate.h: Updated process model enum to match WebKit.
  7387. 2012-08-09 Ryosuke Niwa <rniwa@webkit.org>
  7388. Build fix after r125178.
  7389. * Scripts/webkitpy/performance_tests/perftest.py:
  7390. (PerfTest.parse_output): Don't include non-time results in the JSON output.
  7391. * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated the test outputs so to match
  7392. actual test outputs.
  7393. (MainTest.test_parse_output):
  7394. (MainTest.test_parse_output_with_failing_line):
  7395. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Ditto.
  7396. 2012-08-09 Zoltan Horvath <zoltan@webkit.org>
  7397. JSHeap and FastMallocStatistics based memory measurement for performance-tests
  7398. https://bugs.webkit.org/show_bug.cgi?id=90858
  7399. Reviewed by Ryosuke Niwa.
  7400. Measure the memory usage of the performancetests with the help of the windows.memory.usedJSHeapSize
  7401. object and the window.internals.fastMallocStatistics() function call.
  7402. * Scripts/webkitpy/performance_tests/perftest.py:
  7403. (PerfTest):
  7404. (PerfTest.parse_output):
  7405. (PerfTest.output_statistics):
  7406. 2012-08-09 Csaba Osztrogonác <ossy@webkit.org>
  7407. [Qt][Win] Build system bug revealed by r124835
  7408. https://bugs.webkit.org/show_bug.cgi?id=93339
  7409. Reviewed by Tor Arne Vestbø.
  7410. Don't add "LC_ALL=c" on Windows in svnRevisionForDirectory() and in pathRelativeToSVNRepositoryRootForPath().
  7411. * Scripts/VCSUtils.pm:
  7412. (isWindows): Copied from webkitdirs.pm.
  7413. (svnRevisionForDirectory):
  7414. (pathRelativeToSVNRepositoryRootForPath):
  7415. 2012-08-08 Dirk Pranke <dpranke@chromium.org>
  7416. update bot parsing of new-run-webkit-tests' output
  7417. https://bugs.webkit.org/show_bug.cgi?id=93537
  7418. Reviewed by Ryosuke Niwa.
  7419. This change updates the way we parse the output from
  7420. new-run-webkit-tests on the bots so that we can show a summary
  7421. of the results properly after I re-land the changes that were
  7422. reverted in r124994 and r124870.
  7423. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  7424. (RunWebKitTests._parseNewRunWebKitTestsOutput):
  7425. 2012-08-08 Shane Stephens <shanestephens@google.com>
  7426. Compile flag for CSS Hierarchies
  7427. https://bugs.webkit.org/show_bug.cgi?id=92433
  7428. Reviewed by Tony Chang.
  7429. * Scripts/webkitperl/FeatureList.pm:
  7430. * qmake/mkspecs/features/features.pri:
  7431. 2012-08-08 Benjamin Poulain <bpoulain@apple.com>
  7432. Use char* instead of LChar* for the public interface of String construction from literals
  7433. https://bugs.webkit.org/show_bug.cgi?id=93402
  7434. Reviewed by Michael Saboff.
  7435. * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
  7436. (TestWebKitAPI::TEST):
  7437. 2012-08-08 Dirk Pranke <dpranke@chromium.org>
  7438. nrwt: rename finder.py to layout_test_finder.py
  7439. https://bugs.webkit.org/show_bug.cgi?id=93557
  7440. Reviewed by Ryosuke Niwa.
  7441. One last cleanup per old review feedback from rniwa.
  7442. * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/finder.py.
  7443. (LayoutTestFinder):
  7444. (LayoutTestFinder.__init__):
  7445. (LayoutTestFinder.find_tests):
  7446. (LayoutTestFinder._strip_test_dir_prefixes):
  7447. (LayoutTestFinder._strip_test_dir_prefix):
  7448. (LayoutTestFinder._read_test_names_from_file):
  7449. (LayoutTestFinder._strip_comments):
  7450. (LayoutTestFinder.skip_tests):
  7451. (LayoutTestFinder.split_into_chunks):
  7452. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  7453. 2012-08-08 Ryosuke Niwa <rniwa@webkit.org>
  7454. Add Perf EWS IRC bot
  7455. https://bugs.webkit.org/show_bug.cgi?id=92913
  7456. Reviewed by Dirk Pranke.
  7457. Adds the preliminary implementation of perfalizer, a IRC bot that runs performance tests
  7458. based on IRC requests.
  7459. * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
  7460. (MockSCM.head_svn_revision): The actual implementation returns string, so match that.
  7461. (MockSCM.svn_revision): Ditto.
  7462. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  7463. (Bugzilla.add_attachment_to_bug): Added mimetype.
  7464. * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
  7465. (MockBugzilla.add_attachment_to_bug): Ditto.
  7466. * Scripts/webkitpy/common/system/filesystem.py:
  7467. (FileSystem.copytree): Added.
  7468. * Scripts/webkitpy/common/system/filesystem_mock.py:
  7469. (MockFileSystem.copytree): Added.
  7470. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Rebaselined tests
  7471. that had assumed revision numbers were integers.
  7472. (test_run_with_json_output):
  7473. (test_run_with_description):
  7474. (test_run_generates_json_by_default):
  7475. (test_run_generates_and_show_results_page):
  7476. (test_run_with_json_source):
  7477. (test_run_with_multiple_repositories):
  7478. * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  7479. * Scripts/webkitpy/tool/commands/__init__.py:
  7480. * Scripts/webkitpy/tool/commands/perfalizer.py: Added.
  7481. (PerfalizerTask):
  7482. (PerfalizerTask.__init__):
  7483. (PerfalizerTask._copy_build_product_without_patch):
  7484. (PerfalizerTask.run):
  7485. (PerfalizerTask.parent_command):
  7486. (PerfalizerTask.run_webkit_patch):
  7487. (PerfalizerTask._json_path):
  7488. (PerfalizerTask._results_page_path):
  7489. (PerfalizerTask._run_perf_test):
  7490. (PerfalizerTask.run_command):
  7491. (PerfalizerTask.command_passed):
  7492. (PerfalizerTask.command_failed):
  7493. (PerfalizerTask.refetch_patch):
  7494. (PerfalizerTask.expected_failures):
  7495. (PerfalizerTask.build_style):
  7496. (PerfTest): IRC command.
  7497. (PerfTest.execute):
  7498. (Perfalizer): IRC bot.
  7499. (Perfalizer.begin_work_queue):
  7500. (Perfalizer.work_item_log_path):
  7501. (Perfalizer._is_old_failure):
  7502. (Perfalizer.next_work_item):
  7503. (Perfalizer.process_work_item):
  7504. (Perfalizer.handle_unexpected_error):
  7505. (Perfalizer.handle_script_error):
  7506. * Scripts/webkitpy/tool/commands/perfalizer_unittest.py: Added.
  7507. (PerfalizerTaskTest):
  7508. (PerfalizerTaskTest._create_and_run_perfalizer):
  7509. (PerfalizerTaskTest._create_and_run_perfalizer.logger):
  7510. (PerfalizerTaskTest._create_and_run_perfalizer.run_webkit_patch):
  7511. (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
  7512. (PerfalizerTaskTest.test_run):
  7513. (PerfalizerTaskTest.test_run_with_clean_fails):
  7514. (PerfalizerTaskTest.test_run_with_update_fails):
  7515. (PerfalizerTaskTest.test_run_with_build_fails):
  7516. (PerfalizerTaskTest.test_run_with_perf_test_fails):
  7517. (PerfalizerTaskTest.test_run_without_results_page):
  7518. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  7519. (AbstractPatchQueueTest.test_upload_results_archive_for_patch): Rebaselined.
  7520. * Scripts/webkitpy/tool/commands/upload_unittest.py:
  7521. (test_attach_to_bug): Ditto.
  7522. (test_attach_to_bug_no_description_or_comment): Ditto.
  7523. 2012-08-08 Dirk Pranke <dpranke@chromium.org>
  7524. webkit-patch rebaseline-expectations needs to support multiple expectations files
  7525. https://bugs.webkit.org/show_bug.cgi?id=89051
  7526. Reviewed by Adam Barth.
  7527. fixed the bug described above, added unit test in
  7528. test_expectations_unittest, and updated the tool tests
  7529. to not contain all of the "missing skia expectations" warnings.
  7530. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  7531. (TestExpectations.remove_rebaselined_tests):
  7532. (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
  7533. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  7534. (RebaseliningTest.assertRemove):
  7535. (RebaseliningTest.test_remove):
  7536. * Scripts/webkitpy/tool/commands/rebaseline.py:
  7537. (RebaselineExpectations._update_expectations_files):
  7538. (RebaselineExpectations.execute):
  7539. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  7540. (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
  7541. (test_rebaseline_expectations):
  7542. 2012-08-08 Alexey Proskuryakov <ap@apple.com>
  7543. [WK2] MiniBrowser crashes on quit if any windows were previously closed
  7544. https://bugs.webkit.org/show_bug.cgi?id=93529
  7545. Reviewed by John Sullivan.
  7546. * MiniBrowser/mac/AppDelegate.h:
  7547. * MiniBrowser/mac/AppDelegate.m:
  7548. (-[BrowserAppDelegate init]):
  7549. (-[BrowserAppDelegate newWindow:]):
  7550. (-[BrowserAppDelegate browserWindowWillClose:]):
  7551. (-[BrowserAppDelegate applicationWillTerminate:]):
  7552. (-[BrowserAppDelegate frontmostBrowserWindowController]):
  7553. Track browser windows explicitly, not relying on [NSApp windows]. Closed windows
  7554. are not automatically removed from the list until deallocated, so a refcounting
  7555. error can result in working on a closed window.
  7556. * MiniBrowser/mac/BrowserWindowController.m:
  7557. (-[BrowserWindowController dealloc]): Moved code from -windowWillClose: here.
  7558. Releasing data members is -dealloc's job.
  7559. (-[BrowserWindowController windowWillClose:]): Notify BrowserAppDelegate that
  7560. the window is no longer open. Autorelease self, making sure that WKView and
  7561. then WebPageProxy get released.
  7562. (-[BrowserWindowController applicationTerminating]): Don't release _webView.pageRef.
  7563. WKView is responsible for its lifetime.
  7564. (closePage): Ditto.
  7565. 2012-08-08 Xianzhu Wang <wangxianzhu@chromium.org>
  7566. [Chromium-Android] Apply all Linux layout test expectations
  7567. https://bugs.webkit.org/show_bug.cgi?id=92653
  7568. Reviewed by Adam Barth.
  7569. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  7570. (ChromiumAndroidPort.skipped_layout_tests): Removed. Skip these tests in TestExpectations instead.
  7571. 2012-08-08 Josh Hawn <jhawn@apple.com>
  7572. Add MountainLion WebKit Bots.
  7573. https://bugs.webkit.org/show_bug.cgi?id=93417
  7574. Reviewed by Stephanie Lewis.
  7575. Mountain Lion is now available, so we've added the appropriate Apple bots,
  7576. mirroring the configuration of the Lion bots.
  7577. * BuildSlaveSupport/build.webkit.org-config/config.json:
  7578. Added 10 "apple-mini-###" slaves.
  7579. Added MountainLion Builders and Schedulers.
  7580. 2012-08-08 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  7581. [WK2] Coding style violation was brought with r125031
  7582. https://bugs.webkit.org/show_bug.cgi?id=93503
  7583. Reviewed by Alexey Proskuryakov.
  7584. WKURLResponseCopyMimeType is corrected to WKURLResponseCopyMIMEType.
  7585. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  7586. (WTR::InjectedBundlePage::didReceiveResponseForResource):
  7587. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  7588. (WTR::LayoutTestController::dumpProgressFinishedCallback): Removed trailing whitespace that was brought with the same revision.
  7589. 2012-08-08 Peter Beverloo <peter@chromium.org>
  7590. Buildmaster changes in preparation of a Chromium Android tester
  7591. https://bugs.webkit.org/show_bug.cgi?id=92251
  7592. Reviewed by Adam Barth.
  7593. Slightly update the build master's configuration in preparation of adding
  7594. a Chromium Android tester.
  7595. The change in built-product-archive is required as the out/ directory
  7596. for Android has a number of unstripped .so binaries and unaligned APKs,
  7597. causing the default release.zip file to be 2.7 gigabytes. By excluding
  7598. these file types, the file is only 59.7 megabytes. We can't disable
  7599. them for all of Chromium, as Mac and Linux do use their .so files.
  7600. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  7601. (ArchiveBuiltProduct): Pass the full platform name instead of just the
  7602. generic type, i.e. chromium-android instead of chromium.
  7603. (ExtractBuiltProduct): Dito, stay consistent for this script.
  7604. (RunUnitTests): Pass --chromium-android as well as --chromium. Since we
  7605. now read the full platform name, stay on the safe side with 'win'
  7606. even though there (as far as I know) is no win-* platform.
  7607. (RunChromiumWebKitUnitTests): Dito. The platform wasn't being passed
  7608. at all, but we'll be needing different handling here.
  7609. (unitTestsSupported): Next to refactoring work required, as we'll be
  7610. running this test on a device, there is no reason to disable this
  7611. in the master's configuration.
  7612. * BuildSlaveSupport/built-product-archive:
  7613. (main): Determine the generic platform.
  7614. (archiveBuiltProduct): Use an identical set of ignorePatterns, but
  7615. extend the list with .so, .pak and -unaligned.apk for Android.
  7616. 2012-08-08 Adam Barth <abarth@webkit.org>
  7617. Unreviewed. Stop running tests on the mac-ews while we wait for more
  7618. hardware. As requested by lforschler.
  7619. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  7620. 2012-08-08 Peter Beverloo <peter@chromium.org>
  7621. The cr-android EWS should actually be building Chromium for Android
  7622. https://bugs.webkit.org/show_bug.cgi?id=93489
  7623. Reviewed by Adam Barth.
  7624. The cr-android EWS bots should be building Chromium for Android, which
  7625. requires some additional flags to Chromium's default configuration.
  7626. * Scripts/webkitdirs.pm:
  7627. (buildChromium):
  7628. * Scripts/webkitpy/common/config/ports.py:
  7629. (DeprecatedPort.port):
  7630. (ChromiumAndroidPort):
  7631. (ChromiumAndroidPort.update_webkit_command):
  7632. (ChromiumAndroidPort.build_webkit_command):
  7633. * Scripts/webkitpy/common/config/ports_unittest.py:
  7634. (DeprecatedPortTest.test_chromium_android_port):
  7635. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  7636. (ChromiumAndroidEWS):
  7637. * Scripts/webkitpy/tool/steps/update_unittest.py:
  7638. (UpdateTest.test_update_command_non_interactive):
  7639. (UpdateTest.test_update_command_interactive):
  7640. 2012-08-08 Alexey Proskuryakov <ap@apple.com>
  7641. [WK2] MiniBrowser crashes on window.open()
  7642. https://bugs.webkit.org/show_bug.cgi?id=93413
  7643. Reviewed by Dan Bernstein.
  7644. * MiniBrowser/mac/BrowserWindowController.m: (createNewPage): This is a "create"
  7645. API, so it needs to return a retained result.
  7646. * MiniBrowser/mac/WebBundle/WebBundleMain.m: (didClearWindowObjectForFrame):
  7647. When this function is called, URL appears to be poorly defined. Sometimes, it's
  7648. the new URL, other times it's the old one. An "old" URL is null in a new page.
  7649. 2012-08-08 Loïc Yhuel <loic.yhuel@softathome.com>
  7650. [Qt] Compile errors with OpenGLES2
  7651. https://bugs.webkit.org/show_bug.cgi?id=93206
  7652. Reviewed by Noam Rosenthal.
  7653. Fix build with OpenGLES2 on Linux desktop
  7654. * qmake/mkspecs/features/features.prf: Don't use GLX with OpenGLES2
  7655. 2012-08-08 Peter Beverloo <peter@chromium.org>
  7656. Introduce cr-android bots in the EWS system
  7657. https://bugs.webkit.org/show_bug.cgi?id=93472
  7658. Reviewed by Adam Barth.
  7659. This adds the queue to the EWS scripts. Two builders are ready to be
  7660. attached to the queue. All webkitpy tests pass with this change applied.
  7661. * QueueStatusServer/model/queues.py:
  7662. (Queue):
  7663. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  7664. (ChromiumAndroidEWS):
  7665. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  7666. (EarlyWarningSytemTest.test_builder_ewses):
  7667. 2012-08-08 Carlos Garcia Campos <cgarcia@igalia.com>
  7668. Unreviewed. Fix GTK+ build with GTK2 after r121475.
  7669. * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Add missing
  7670. include required when building with GTK2.
  7671. 2012-08-08 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  7672. [WK2] [WTR] Provide Resource Response dumping.
  7673. https://bugs.webkit.org/show_bug.cgi?id=93454
  7674. Reviewed by Kenneth Rohde Christiansen.
  7675. Added missing dumpResourceResponseMIMETypes() method to testRunner. Provided resource response dumping.
  7676. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  7677. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  7678. (WTR::InjectedBundlePage::didReceiveResponseForResource):
  7679. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  7680. (WTR::LayoutTestController::LayoutTestController):
  7681. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  7682. (WTR::LayoutTestController::dumpProgressFinishedCallback):
  7683. (WTR::LayoutTestController::dumpResourceResponseMIMETypes):
  7684. (WTR::LayoutTestController::shouldDumpResourceResponseMIMETypes):
  7685. (LayoutTestController):
  7686. 2012-08-08 Simon Hausmann <simon.hausmann@nokia.com>
  7687. [Qt][Win] Fix compilation of DumpRenderTree
  7688. https://bugs.webkit.org/show_bug.cgi?id=93461
  7689. Reviewed by Tor Arne Vestbø.
  7690. DRT includes stdint.h, for which we have wrappers in Source/JavaScriptCore/os-win32. Use these not only
  7691. for libraries but any building template.
  7692. * qmake/mkspecs/features/default_post.prf:
  7693. 2012-08-08 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  7694. [WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCallback() should be const
  7695. https://bugs.webkit.org/show_bug.cgi?id=93457
  7696. Reviewed by Csaba Osztrogonác.
  7697. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  7698. (WTR::LayoutTestController::shouldDumpProgressFinishedCallback): Added constness.
  7699. 2012-08-07 Csaba Osztrogonác <ossy@webkit.org>
  7700. Unreviewed typo fix after r124988.
  7701. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  7702. (TestExpectations):
  7703. 2012-08-07 YoungTaeck Song <youngtaeck.song@samsung.com>
  7704. [WK2][EFL] Implement accelerated compositing on WK2 Efl port
  7705. https://bugs.webkit.org/show_bug.cgi?id=89840
  7706. Reviewed by Noam Rosenthal.
  7707. Implement accelerated composition with TiledBackingStore on WK2 Efl port.
  7708. Add OPENGL_LIBRARIES in CMakeList.txt.
  7709. * MiniBrowser/efl/CMakeLists.txt:
  7710. * WebKitTestRunner/PlatformEfl.cmake:
  7711. 2012-08-07 Csaba Osztrogonác <ossy@webkit.org>
  7712. [NRWT] REGRESSION(r124967): New tests without expected results handled as failures
  7713. https://bugs.webkit.org/show_bug.cgi?id=93434
  7714. Reviewed by Tony Chang.
  7715. Change back "missing results" to "no expected result found", because master.cfg's results parser expects it.
  7716. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  7717. (TestExpectations):
  7718. 2012-08-07 Csaba Osztrogonác <ossy@webkit.org>
  7719. buildbot: Remove the configuration of hfreyther*
  7720. https://bugs.webkit.org/show_bug.cgi?id=91849
  7721. Unreviewed typo fix after r123757.
  7722. * BuildSlaveSupport/build.webkit.org-config/config.json:
  7723. 2012-08-07 Dirk Pranke <dpranke@chromium.org>
  7724. REGRESSION: PrettyPatchTest.test_pretty_diff_encodings has been failing on Chromium Windows
  7725. https://bugs.webkit.org/show_bug.cgi?id=93192
  7726. Unreviewed, build fix.
  7727. Disabling the test for now as PrettyPatch is just broken on win32.
  7728. * Scripts/webkitpy/common/prettypatch_unittest.py:
  7729. (test_pretty_diff_encodings):
  7730. 2012-08-07 Dirk Pranke <dpranke@chromium.org>
  7731. [NRWT] Would like an output mode similar to ORWT verbose one
  7732. https://bugs.webkit.org/show_bug.cgi?id=88702
  7733. Reviewed by Ryosuke Niwa.
  7734. Change the --verbose logging for new-run-webkit-tests so that
  7735. it matches ORWT more; we just print one line per test. Use
  7736. --debug-rwt-logging to get the full debug stream (aka old ORWT
  7737. --verbose).
  7738. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  7739. (TestExpectations):
  7740. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  7741. (_set_up_derived_options):
  7742. (parse_args):
  7743. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  7744. (MainTest.test_retrying_and_flaky_tests):
  7745. * Scripts/webkitpy/layout_tests/views/printing.py:
  7746. (print_options):
  7747. (Printer._print_result_summary_entry):
  7748. (Printer._print_one_line_summary):
  7749. (Printer._print_test_result):
  7750. (Printer._print_baseline):
  7751. (Printer._print_unexpected_results):
  7752. 2012-08-07 Dirk Pranke <dpranke@chromium.org>
  7753. nrwt: handle errors from image diff better
  7754. https://bugs.webkit.org/show_bug.cgi?id=92934
  7755. Reviewed by Ojan Vafai.
  7756. Re-land the change in r124801 with a fix ... in the case where
  7757. the ImageDiff is passed a tolerance and passes the fuzzy check,
  7758. we were returning the wrong value (missing an empty error
  7759. string) and crashing; this patch fixes that and adds a test for
  7760. that case (TestImageDiffer.test_image_diff_passed).
  7761. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  7762. (SingleTestRunner._compare_image):
  7763. (SingleTestRunner._compare_output_with_reference):
  7764. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  7765. (write_test_result):
  7766. * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
  7767. (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
  7768. (TestResultWriterTest):
  7769. * Scripts/webkitpy/layout_tests/port/base.py:
  7770. (Port.diff_image):
  7771. * Scripts/webkitpy/layout_tests/port/chromium.py:
  7772. (ChromiumPort.diff_image):
  7773. * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
  7774. (ChromiumPortTestCase.test_diff_image_crashed):
  7775. * Scripts/webkitpy/layout_tests/port/image_diff.py:
  7776. (ImageDiffer.diff_image):
  7777. (ImageDiffer._read):
  7778. * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
  7779. (TestImageDiffer.test_diff_image):
  7780. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  7781. (MockDRTPortTest.test_diff_image_crashed):
  7782. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  7783. (PortTestCase.test_diff_image):
  7784. (PortTestCase.test_diff_image_crashed):
  7785. (PortTestCase.test_diff_image_crashed.make_proc):
  7786. * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
  7787. (MockServerProcess.__init__):
  7788. * Scripts/webkitpy/layout_tests/port/test.py:
  7789. (TestPort.diff_image):
  7790. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  7791. (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
  7792. 2012-08-07 Dirk Pranke <dpranke@chromium.org>
  7793. nrwt: --no-build isn't working
  7794. https://bugs.webkit.org/show_bug.cgi?id=93415
  7795. Reviewed by Ryosuke Niwa.
  7796. Turns out our optimization to avoid calling
  7797. webkit-build-directory N times for each worker broke --no-build.
  7798. Fixing, and adding a test.
  7799. Also, the gtk port wasn't using the default check_build() logic,
  7800. but I don't know why not. Removing their custom hook and will
  7801. verify that this is okay in the review ...
  7802. * Scripts/webkitpy/layout_tests/port/base.py:
  7803. (Port.__init__):
  7804. (Port.check_build):
  7805. (Port._build_path):
  7806. * Scripts/webkitpy/layout_tests/port/gtk.py:
  7807. (GtkPort._path_to_image_diff):
  7808. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  7809. (MockDRTPortTest.test_check_build):
  7810. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  7811. (test_path_to_apache_config_file):
  7812. (test_check_build):
  7813. (test_check_build.build_driver_called):
  7814. 2012-08-07 Ryosuke Niwa <rniwa@webkit.org>
  7815. run-perf-tests should support --no-show-results
  7816. https://bugs.webkit.org/show_bug.cgi?id=93409
  7817. Reviewed by Dirk Pranke.
  7818. Add the support for --no-show-results.
  7819. Also replace only local paths to jquery and flot instead of embedding them.
  7820. The results page is still standalone in that it tries to load scripts
  7821. from both webkit.org and local filesystem.
  7822. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  7823. (PerfTestsRunner._parse_args):
  7824. (PerfTestsRunner.run):
  7825. (PerfTestsRunner._generate_and_show_results):
  7826. (PerfTestsRunner._generate_output_files):
  7827. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  7828. (create_runner_and_setup_results_template):
  7829. (test_run_generates_and_show_results_page):
  7830. (test_run_respects_no_show_results):
  7831. 2012-08-07 Dirk Pranke <dpranke@chromium.org>
  7832. test-webkitpy hangs in a new checkout on snow leopard
  7833. https://bugs.webkit.org/show_bug.cgi?id=93301
  7834. Reviewed by Ryosuke Niwa.
  7835. This change works around what appears to be a bug in Python
  7836. 2.6.1 (the version that ships on Mac Snow Leopard) that causes
  7837. the multiprocessing module to hang after we use the
  7838. autoinstaller; I'm guessing it's some sort of python sockets
  7839. issue. I was unable to reproduce this with 2.6.5 or newer
  7840. versions of Python.
  7841. * Scripts/webkitpy/common/system/autoinstall.py:
  7842. (AutoInstaller.install):
  7843. * Scripts/webkitpy/test/main.py:
  7844. (Tester._run_tests):
  7845. * Scripts/webkitpy/thirdparty/__init__.py:
  7846. (AutoinstallImportHook._install_mechanize):
  7847. (AutoinstallImportHook._install_pep8):
  7848. (AutoinstallImportHook._install_pylint):
  7849. (AutoinstallImportHook._install_buildbot):
  7850. (AutoinstallImportHook._install_coverage):
  7851. (AutoinstallImportHook._install_eliza):
  7852. (AutoinstallImportHook._install_irc):
  7853. (AutoinstallImportHook._install_webpagereplay):
  7854. (AutoinstallImportHook._install):
  7855. (autoinstall_everything):
  7856. 2012-08-07 Xianzhu Wang <wangxianzhu@chromium.org>
  7857. [Chromium-Android][NRWT] Fix 2 FIXMEs in chromium_android.py
  7858. https://bugs.webkit.org/show_bug.cgi?id=93381
  7859. Reviewed by Adam Barth.
  7860. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  7861. (ChromiumAndroidDriver.__init__):
  7862. (ChromiumAndroidDriver._push_executable): Remove temporary lines as the chromium change has been landed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150371
  7863. (ChromiumAndroidDriver._setup_performance): Update all scaling governor files.
  7864. (ChromiumAndroidDriver._teardown_performance): Update all scaling governor files.
  7865. 2012-08-07 W. James MacLean <wjmaclean@chromium.org>
  7866. [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
  7867. https://bugs.webkit.org/show_bug.cgi?id=93286
  7868. Reviewed by James Robinson.
  7869. Adds support to generate GestureTapDown events from EventSender, to facilitate
  7870. link highlighting layout tests.
  7871. Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.
  7872. * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
  7873. (EventSender::EventSender):
  7874. (EventSender::gestureTapDown):
  7875. (EventSender::gestureEvent):
  7876. * DumpRenderTree/chromium/TestRunner/EventSender.h:
  7877. (EventSender):
  7878. 2012-08-07 Marcelo Lira <marcelo.lira@openbossa.org>
  7879. [Qt] Add support for the Gamepad API
  7880. https://bugs.webkit.org/show_bug.cgi?id=90637
  7881. Reviewed by Alexis Menard.
  7882. If the libudev library is present, the GAMEPAD flag is
  7883. turned on by default for the Qt port.
  7884. * Scripts/webkitperl/FeatureList.pm:
  7885. * qmake/mkspecs/features/features.prf:
  7886. 2012-08-07 Rob Buis <rbuis@rim.com>
  7887. [BlackBerry] Turn on CSS Variables
  7888. https://bugs.webkit.org/show_bug.cgi?id=93376
  7889. Reviewed by Antonio Gomes.
  7890. Turn on CSS Variables for BlackBerry port.
  7891. * Scripts/webkitperl/FeatureList.pm:
  7892. 2012-08-07 No'am Rosenthal <noam.rosenthal@nokia.com>
  7893. [Qt] Make it possible to build without QtQuick
  7894. Reviewed by Simon Hausmann.
  7895. * Tools.pro:
  7896. * qmake/mkspecs/features/features.prf:
  7897. 2012-08-02 Simon Hausmann <simon.hausmann@nokia.com>
  7898. [Qt] Remove Qt 4 specific code paths
  7899. https://bugs.webkit.org/show_bug.cgi?id=88161
  7900. Reviewed by Kenneth Rohde Christiansen.
  7901. * DumpRenderTree/qt/DumpRenderTree.pro:
  7902. * DumpRenderTree/qt/EventSenderQt.cpp:
  7903. (EventSender::touchCancel):
  7904. (EventSender::sendTouchEvent):
  7905. * DumpRenderTree/qt/EventSenderQt.h:
  7906. (EventSender):
  7907. * DumpRenderTree/qt/ImageDiff.pro:
  7908. * DumpRenderTree/qt/main.cpp:
  7909. (main):
  7910. * QtTestBrowser/QtTestBrowser.pro:
  7911. * QtTestBrowser/cookiejar.cpp:
  7912. (TestBrowserCookieJar::TestBrowserCookieJar):
  7913. * QtTestBrowser/launcherwindow.cpp:
  7914. (LauncherWindow::setDiskCache):
  7915. * qmake/configure.pri:
  7916. * qmake/mkspecs/features/default_post.prf:
  7917. * qmake/mkspecs/features/default_pre.prf:
  7918. * qmake/mkspecs/features/features.prf:
  7919. * qmake/mkspecs/features/functions.prf:
  7920. * qmake/mkspecs/features/qtwebkit.prf: Removed.
  7921. * qmake/mkspecs/features/unix/default_pre.prf:
  7922. 2012-08-07 Andras Becsi <andras.becsi@nokia.com>
  7923. [Qt][WK2] MiniBrowser should only synthesize multiple touch points if Ctrl is pressed
  7924. https://bugs.webkit.org/show_bug.cgi?id=93277
  7925. Reviewed by Jocelyn Turcotte.
  7926. MiniBrowser's multi-touch mocking does not check if Ctrl is pressed
  7927. when registering multiple touch points based on pressed mouse buttons
  7928. and sends inconsistent touch events to the WebView which triggers an
  7929. assert in the pinch gesture recognizer.
  7930. MiniBrowserApplication::updateTouchPoint should only register multiple
  7931. touch points if the Ctrl button is pressed else it should ignore the
  7932. update request.
  7933. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  7934. (MiniBrowserApplication::updateTouchPoint):
  7935. 2012-08-07 Csaba Osztrogonác <ossy@webkit.org>
  7936. REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
  7937. https://bugs.webkit.org/show_bug.cgi?id=93346
  7938. Rubber-stamped by Simon Hausmann.
  7939. Change back "unexpected" to "Unexpected", because master.cfg's results parser expects it.
  7940. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  7941. (MainTest.test_retrying_and_flaky_tests):
  7942. * Scripts/webkitpy/layout_tests/views/printing.py:
  7943. (Printer._print_unexpected_results):
  7944. 2012-08-06 Balazs Kelemen <kbalazs@webkit.org>
  7945. [NRWT] runs platform specific tests that it shouldn't with --force
  7946. https://bugs.webkit.org/show_bug.cgi?id=91089
  7947. Reviewed by Dirk Pranke.
  7948. Ignore other platform's directories from platform/.
  7949. * Scripts/webkitpy/layout_tests/port/base.py:
  7950. (Port._expanded_paths):
  7951. * Scripts/webkitpy/layout_tests/port/test.py:
  7952. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  7953. (MainTest.test_platform_tests_are_found):
  7954. Updated integration test in accordance to the new behavior.
  7955. 2012-08-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  7956. [EFL] Enable link prefetch
  7957. https://bugs.webkit.org/show_bug.cgi?id=93281
  7958. Reviewed by Kentaro Hara.
  7959. * Scripts/webkitperl/FeatureList.pm: Enable LINK_PREFETCH feature.
  7960. 2012-08-06 Sheriff Bot <webkit.review.bot@gmail.com>
  7961. Unreviewed, rolling out r124801.
  7962. http://trac.webkit.org/changeset/124801
  7963. https://bugs.webkit.org/show_bug.cgi?id=93338
  7964. It broke NRWT (Requested by Ossy on #webkit).
  7965. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  7966. (SingleTestRunner._compare_image):
  7967. (SingleTestRunner._compare_output_with_reference):
  7968. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  7969. (write_test_result):
  7970. * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
  7971. (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
  7972. (TestResultWriterTest):
  7973. * Scripts/webkitpy/layout_tests/port/base.py:
  7974. (Port.diff_image):
  7975. * Scripts/webkitpy/layout_tests/port/chromium.py:
  7976. (ChromiumPort.diff_image):
  7977. * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
  7978. (ChromiumPortTestCase.test_diff_image):
  7979. * Scripts/webkitpy/layout_tests/port/image_diff.py:
  7980. (ImageDiffer.diff_image):
  7981. (ImageDiffer._read):
  7982. * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
  7983. (TestImageDiffer.test_diff_image):
  7984. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  7985. (MockDRTPortTest.test_diff_image):
  7986. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  7987. (PortTestCase.test_diff_image):
  7988. * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
  7989. (MockServerProcess.__init__):
  7990. * Scripts/webkitpy/layout_tests/port/test.py:
  7991. (TestPort.diff_image):
  7992. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  7993. (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
  7994. 2012-08-06 Wei James <james.wei@intel.com>
  7995. [Chromium]duplicated command line options in Android LayoutTest
  7996. https://bugs.webkit.org/show_bug.cgi?id=93233
  7997. Reviewed by Tony Chang.
  7998. Duplicated options found in Android layout test command line:
  7999. --encode-binary and --enable-hardware-gpu.
  8000. If there are multiple ChromiumAndroidPort instances,
  8001. these two options will be appended for multiple times.
  8002. * Scripts/webkitpy/layout_tests/port/base.py:
  8003. (Port.additional_drt_flag):
  8004. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  8005. (ChromiumAndroidPort.__init__):
  8006. (ChromiumAndroidPort.additional_drt_flag):
  8007. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  8008. (ChromiumAndroidTwoPortsTest):
  8009. (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
  8010. * Scripts/webkitpy/layout_tests/port/driver.py:
  8011. (Driver.cmd_line):
  8012. 2012-08-03 Brady Eidson <beidson@apple.com>
  8013. Out-of-process plug-ins should support asynchronous initialization
  8014. <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
  8015. Reviewed by Anders Carlsson.
  8016. Add a plug-in with an NPP_New that takes 550ms (a reasonable trade-off between a solid test and a slow running test)
  8017. for testing asynchronous plug-in initialization.
  8018. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  8019. * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp: Copied from Source/WebKit2/Shared/Plugins/PluginProcessCreationParameters.h.
  8020. (SlowNPPNew):
  8021. (SlowNPPNew::SlowNPPNew):
  8022. (SlowNPPNew::NPP_New):
  8023. 2012-08-06 Xianzhu Wang <wangxianzhu@chromium.org>
  8024. [Chromium-Android] Virtual test suites fail
  8025. https://bugs.webkit.org/show_bug.cgi?id=92515
  8026. Reviewed by Dirk Pranke.
  8027. The failure is because our bypassing of DriverProxy.
  8028. Repeat the logic of virtual tests in DriverProxy in ChromiumAndroidDriver
  8029. and restart DRT when the command line changes.
  8030. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  8031. (ChromiumAndroidDriver.__init__):
  8032. (ChromiumAndroidDriver.cmd_line): Added comments about why we override this and have _drt_cmd_line().
  8033. (ChromiumAndroidDriver.run_test): Repeat the logic of virtual tests in DriverProxy.
  8034. (ChromiumAndroidDriver.start): Restart DRT when the command line changes.
  8035. (ChromiumAndroidDriver._start_once):
  8036. 2012-08-06 Xianzhu Wang <wangxianzhu@chromium.org>
  8037. Remove NRWT --shard-ref-tests
  8038. https://bugs.webkit.org/show_bug.cgi?id=91539
  8039. This is basically a revert of "[Chromium-Android] Run ref tests together to avoid expensive driver restarts"
  8040. (https://bugs.webkit.org/show_bug.cgi?id=91533, http://trac.webkit.org/changeset/122914),
  8041. with some conflicts resolved (because of refactory of Manager/LayoutTestRunner/Sharder classes).
  8042. Reviewed by Dirk Pranke.
  8043. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  8044. (LayoutTestRunner.run_tests):
  8045. (Sharder.shard_tests):
  8046. (Sharder._shard_in_two):
  8047. (Sharder._shard_by_directory):
  8048. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
  8049. (SharderTests):
  8050. (SharderTests.get_test_input):
  8051. (SharderTests.get_shards):
  8052. (SharderTests.test_shard_by_dir):
  8053. (SharderTests.test_shard_in_two):
  8054. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  8055. (Manager._test_input_for_file):
  8056. (Manager._test_is_slow):
  8057. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  8058. (ChromiumAndroidPort.__init__):
  8059. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  8060. (parse_args):
  8061. 2012-08-06 Luciano Wolf <luciano.wolf@openbossa.org>
  8062. [Qt] Default sizes for input-text and text-area are different when running DRT/WTR
  8063. https://bugs.webkit.org/show_bug.cgi?id=91990
  8064. Reviewed by Kenneth Rohde Christiansen.
  8065. Initializing TestFonts information into WTR binary. Doing it
  8066. later leads to wrong font names usage (Dejavu Serif instead
  8067. of Liberation Serif).
  8068. * WebKitTestRunner/Target.pri:
  8069. * WebKitTestRunner/qt/main.cpp:
  8070. (main):
  8071. 2012-08-06 Jeff Timanus <twiz@chromium.org>
  8072. Add twiz@{chromium|google}.org to the set of non-committer contributors.
  8073. https://bugs.webkit.org/show_bug.cgi?id=93288
  8074. Reviewed by Adam Barth.
  8075. * Scripts/webkitpy/common/config/committers.py:
  8076. 2012-08-06 Adam Barth <abarth@webkit.org>
  8077. REGRESSION(124789): EWS errors out because --print option is missing
  8078. https://bugs.webkit.org/show_bug.cgi?id=93299
  8079. Unreviewed.
  8080. The --print option doesn't exist anymore. Let's try --quiet instead.
  8081. * Scripts/webkitpy/tool/steps/runtests.py:
  8082. (RunTests.run):
  8083. * Scripts/webkitpy/tool/steps/runtests_unittest.py:
  8084. 2012-08-06 Ryosuke Niwa <rniwa@webkit.org>
  8085. run-webkit-tests should have ability to add description to its JSON output
  8086. https://bugs.webkit.org/show_bug.cgi?id=93296
  8087. Reviewed by Dirk Pranke.
  8088. Add --description option.
  8089. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  8090. (PerfTestsRunner._parse_args):
  8091. (PerfTestsRunner._generate_and_show_results):
  8092. (PerfTestsRunner._generate_results_dict):
  8093. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  8094. (test_run_with_description):
  8095. 2012-08-06 Dirk Pranke <dpranke@chromium.org>
  8096. nrwt: handle errors from image diff better
  8097. https://bugs.webkit.org/show_bug.cgi?id=92934
  8098. Reviewed by Ojan Vafai.
  8099. Currently if ImageDiff crashes, returns a weird exit code, or
  8100. produces any stderr output, it's basically swallowed. This
  8101. change ensures that we log errors to stderr, and also appends
  8102. the error to the stderr for the test (so it'll show up in
  8103. results.html).
  8104. Most importantly, it'll cause diff_image() to fail and we'll
  8105. report ImageHashMismatch ... this may be kinda untrue, but I
  8106. think it's better than ignoring the error.
  8107. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  8108. (SingleTestRunner._compare_image):
  8109. (SingleTestRunner._compare_output_with_reference):
  8110. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  8111. (write_test_result):
  8112. * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
  8113. (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
  8114. (TestResultWriterTest):
  8115. * Scripts/webkitpy/layout_tests/port/base.py:
  8116. (Port.diff_image):
  8117. * Scripts/webkitpy/layout_tests/port/chromium.py:
  8118. (ChromiumPort.diff_image):
  8119. * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
  8120. (ChromiumPortTestCase.test_diff_image_crashed):
  8121. * Scripts/webkitpy/layout_tests/port/driver.py:
  8122. (Driver.run_test):
  8123. * Scripts/webkitpy/layout_tests/port/image_diff.py:
  8124. (ImageDiffer.diff_image):
  8125. (ImageDiffer._read):
  8126. * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
  8127. (TestImageDiffer.test_diff_image):
  8128. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  8129. (MockDRTPortTest.test_diff_image_crashed):
  8130. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  8131. (PortTestCase.test_diff_image):
  8132. (PortTestCase):
  8133. (PortTestCase.test_diff_image_crashed):
  8134. (PortTestCase.test_diff_image_crashed.make_proc):
  8135. * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
  8136. (MockServerProcess.__init__):
  8137. * Scripts/webkitpy/layout_tests/port/test.py:
  8138. (TestPort.diff_image):
  8139. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  8140. (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
  8141. 2012-08-06 Dirk Pranke <dpranke@chromium.org>
  8142. nrwt: clean up printing.py
  8143. https://bugs.webkit.org/show_bug.cgi?id=93026
  8144. Reviewed by Dirk Pranke.
  8145. This patch cleans up the implementation of printing.py now
  8146. that we're not using all the original complexity.
  8147. There should be no changes in functionality and everything
  8148. should be covered by the existing tests.
  8149. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  8150. (LayoutTestRunner.run_tests):
  8151. * Scripts/webkitpy/layout_tests/views/printing.py:
  8152. (Printer.__init__):
  8153. (Printer.__del__):
  8154. (Printer.print_config):
  8155. (Printer.print_found):
  8156. (Printer.print_expected):
  8157. (Printer.print_workers_and_shards):
  8158. (Printer):
  8159. (Printer._print_expected_results_of_type):
  8160. (Printer.print_results):
  8161. (Printer._print_timing_statistics):
  8162. (Printer._print_aggregate_test_statistics):
  8163. (Printer._print_individual_test_times):
  8164. (Printer._print_test_list_timing):
  8165. (Printer._print_directory_timings):
  8166. (Printer._print_statistics_for_test_timings):
  8167. (Printer._print_result_summary):
  8168. (Printer._print_result_summary_entry):
  8169. (Printer._print_one_line_summary):
  8170. (Printer.print_finished_test):
  8171. (Printer._print_test_result):
  8172. (Printer._print_test_trace):
  8173. (Printer._print_baseline):
  8174. (Printer._print_unexpected_test_result):
  8175. (Printer._print_progress):
  8176. (Printer._print_unexpected_results):
  8177. (Printer._print_unexpected_results.add_result):
  8178. (Printer._print_quiet):
  8179. (Printer._print_default):
  8180. (Printer._print_debug):
  8181. (Printer._print_for_bot):
  8182. (Printer.write_update):
  8183. (Printer.writeln):
  8184. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  8185. (Testprinter.get_printer):
  8186. (Testprinter.test_print_config):
  8187. (Testprinter.test_print_one_line_summary):
  8188. (Testprinter.test_print_unexpected_results):
  8189. (test_details):
  8190. 2012-08-06 Dirk Pranke <dpranke@chromium.org>
  8191. change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
  8192. https://bugs.webkit.org/show_bug.cgi?id=93043
  8193. Reviewed by Ryosuke Niwa.
  8194. in preparation for the cleanup of the logging flags in new-run-webkit-tests.
  8195. * Scripts/run-webkit-tests:
  8196. 2012-08-06 Dirk Pranke <dpranke@chromium.org>
  8197. nrwt: clean up logging, part 1
  8198. https://bugs.webkit.org/show_bug.cgi?id=93018
  8199. Reviewed by Ojan Vafai.
  8200. remove --print, --help-printing from nrwt, add three new options:
  8201. --quiet, which just logs warnings,errors, and unexpected results
  8202. --debug-rwt-logging, a new name for --verbose
  8203. --details, to get the old --print trace-everything behavior
  8204. This patch does not implement the new "one line per test"
  8205. --verbose behavior specified in bug 88702, and there's a bunch
  8206. of internal cleanup I can do in printing.py that I'll defer to
  8207. a later patch to make things easier to review.
  8208. This patch deletes a lot of unit tests that are no longer
  8209. necessary since there aren't so many logging combinations.
  8210. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  8211. (run):
  8212. (main):
  8213. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  8214. (parse_args):
  8215. (passing_run):
  8216. (StreamTestingMixin.assertContains):
  8217. (MainTest.test_child_processes_2):
  8218. (MainTest.test_child_processes_min):
  8219. (MainTest.test_full_results_html):
  8220. (MainTest.test_no_tests_found):
  8221. (MainTest.test_no_tests_found_2):
  8222. (MainTest.test_repeat_each_iterations_num_tests):
  8223. (MainTest.test_additional_platform_directory):
  8224. (RebaselineTest.assertBaselines):
  8225. * Scripts/webkitpy/layout_tests/views/printing.py:
  8226. (print_options):
  8227. (Printer.__init__):
  8228. (Printer.enabled):
  8229. (Printer.print_unexpected_results):
  8230. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  8231. (TestUtilityFunctions.test_print_options):
  8232. (Testprinter.get_result_summary):
  8233. (Testprinter.test_configure_and_cleanup):
  8234. (Testprinter.test_print_config):
  8235. (Testprinter.test_print_one_line_summary):
  8236. (Testprinter.test_print_unexpected_results):
  8237. (test_details):
  8238. (test_default):
  8239. (test_quiet):
  8240. (test_verbose):
  8241. 2012-08-06 Xianzhu Wang <wangxianzhu@chromium.org>
  8242. [Chromium-Android] Store test executable, data and fonts in /data/local/tmp
  8243. https://bugs.webkit.org/show_bug.cgi?id=91910
  8244. /data/local/tmp is a directory with permission 0777 by default.
  8245. Place DumpRenderTree resources here so that both the native test app and
  8246. the NRWT script can access them even if adb shell isn't running as root.
  8247. Reviewed by Adam Barth.
  8248. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  8249. (createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
  8250. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  8251. (ChromiumAndroidPort.driver_cmd_line):
  8252. (ChromiumAndroidDriver.__init__):
  8253. (ChromiumAndroidDriver._setup_test):
  8254. (ChromiumAndroidDriver._push_executable):
  8255. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  8256. (ChromiumAndroidPortTest.make_port):
  8257. (ChromiumAndroidPortTest.test_expectations_files):
  8258. (ChromiumAndroidDriverTest.test_drt_cmd_line):
  8259. 2012-08-06 Abhishek Arya <inferno@chromium.org>
  8260. [Chromium] Re-expose layoutTestController as various fuzzers depend on it
  8261. https://bugs.webkit.org/show_bug.cgi?id=93282
  8262. Reviewed by Ryosuke Niwa.
  8263. Unfortunately, various fuzzers used in the Chromium project still depends on
  8264. window.layoutTestController. Re-expose the object while they're making the transition.
  8265. * DumpRenderTree/chromium/TestShell.cpp:
  8266. (TestShell::bindJSObjectsToWindow):
  8267. 2012-08-06 Balazs Kelemen <kbalazs@webkit.org>
  8268. WTR should be able to load external resources
  8269. https://bugs.webkit.org/show_bug.cgi?id=89382
  8270. Reviewed by Ryosuke Niwa.
  8271. Allow to load an external resource as the main frame
  8272. and allow all subsequent external loads for such a main
  8273. frame. This behavior is necessary for being able to run
  8274. performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).
  8275. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  8276. (WTR::isLocalHost):
  8277. (WTR):
  8278. (WTR::isHTTPOrHTTPSScheme):
  8279. (WTR::InjectedBundlePage::willSendRequestForFrame):
  8280. 2012-08-06 Balazs Kelemen <kbalazs@webkit.org>
  8281. [WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
  8282. https://bugs.webkit.org/show_bug.cgi?id=93120
  8283. Reviewed by Csaba Osztrogonác.
  8284. Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
  8285. so it will be able to detect an unresponsive web process.
  8286. * Scripts/webkitpy/layout_tests/port/base.py:
  8287. (Port.default_timeout_ms):
  8288. * WebKitTestRunner/TestController.cpp:
  8289. (WTR):
  8290. 2012-08-06 Carlos Garcia Campos <cgarcia@igalia.com>
  8291. Unreviewed. Fix make distcheck.
  8292. * GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.
  8293. 2012-08-06 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  8294. [EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
  8295. https://bugs.webkit.org/show_bug.cgi?id=82724
  8296. Reviewed by Csaba Osztrogonác.
  8297. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  8298. (LayoutTestController::removeAllVisitedLinks):
  8299. 2012-08-06 Mario Sanchez Prada <msanchez@igalia.com>
  8300. [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
  8301. https://bugs.webkit.org/show_bug.cgi?id=90268
  8302. Reviewed by Martin Robinson.
  8303. Ignore WebKitTextChecker.* private files for gtk-doc.
  8304. * gtk/generate-gtkdoc:
  8305. (get_webkit2_options):
  8306. 2012-08-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  8307. Unreviewed. Roll out r124728 because of build bot test fail.
  8308. * Scripts/webkitpy/common/config/watchlist:
  8309. 2012-08-05 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  8310. Unreviewed. Change my email address for watch list.
  8311. * Scripts/webkitpy/common/config/watchlist:
  8312. 2012-08-04 Nico Weber <thakis@chromium.org>
  8313. [Chromium Mac] Tests are exiting early due to failures to load missingImage.png
  8314. https://bugs.webkit.org/show_bug.cgi?id=93186
  8315. Reviewed by Ryosuke Niwa.
  8316. Add missingImage.png to DumpRenderTree.app's Resource folder.
  8317. Depends on http://crrev.com/150037 rolling into webkit first.
  8318. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  8319. 2012-08-03 Ryosuke Niwa <rniwa@webkit.org>
  8320. Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
  8321. https://bugs.webkit.org/show_bug.cgi?id=93173
  8322. Reviewed by Adam Barth.
  8323. Don't expose window.layoutTestController since all layout tests use window.testRunner
  8324. instead of window.layoutTestController as of r124685.
  8325. We can safely rename classes and files to use TestRunner once this patch is landed.
  8326. * DumpRenderTree/LayoutTestController.cpp:
  8327. (LayoutTestController::makeWindowObject):
  8328. * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  8329. (notifyTestCompletion):
  8330. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  8331. (PluginTest::waitUntilDone):
  8332. (PluginTest::notifyDone):
  8333. * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
  8334. (ConvertPoint::NPP_SetWindow):
  8335. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  8336. (handleEventCarbon):
  8337. (handleEventCocoa):
  8338. (handleEventWin):
  8339. * DumpRenderTree/chromium/TestShell.cpp:
  8340. (TestShell::bindJSObjectsToWindow):
  8341. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  8342. (WebCore::DumpRenderTree::initJSObjects):
  8343. * Scripts/bencher:
  8344. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  8345. (WTR::LayoutTestController::makeWindowObject):
  8346. 2012-08-04 Ilya Tikhonovsky <loislo@chromium.org>
  8347. Unreviewed: Web Inspector: extend instrumenting methods set in ReportMemoryUsage clang plugin
  8348. Three methods addString, addVectorPtr and addInstrumentedVectorPtr were added to the list of instrumentation methods.
  8349. * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
  8350. (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
  8351. 2012-08-03 Yaron Friedman <yfriedman@chromium.org>
  8352. [Chrome-Android] - Prepare apk tests for switch to checked in SDK.
  8353. https://bugs.webkit.org/show_bug.cgi?id=92931
  8354. Reviewed by Adam Barth.
  8355. Pass Android-specific gyp variables to the native test generator,
  8356. avoiding any dependencies on environment variables during build time.
  8357. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  8358. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  8359. 2012-08-03 Rick Byers <rbyers@chromium.org>
  8360. Double tap gesture should send dblclick event
  8361. https://bugs.webkit.org/show_bug.cgi?id=92412
  8362. Reviewed by Adam Barth.
  8363. Enable EventSender to set the tap count on tap gesture events. The
  8364. delta X/Y parameters were not actually being used anymore (used to be
  8365. used for radius information).
  8366. * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
  8367. (EventSender::gestureEvent):
  8368. 2012-08-03 Ryosuke Niwa <rniwa@webkit.org>
  8369. run-perf-tests should generate JSON output and results page by default
  8370. https://bugs.webkit.org/show_bug.cgi?id=93042
  8371. Reviewed by Eric Seidel.
  8372. Generate results JSON and page named PerfTestResults.json and PerfTestResults.html by default.
  8373. * Scripts/webkitpy/layout_tests/port/base.py:
  8374. (Port.perf_results_directory): Added.
  8375. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  8376. (PerfTestsRunner): Added _DEFAULT_JSON_FILENAME.
  8377. (PerfTestsRunner._parse_args): Added --no-results option in the case a user doens't want to generate
  8378. results JSON or results page.
  8379. (PerfTestsRunner.run):
  8380. (PerfTestsRunner._generate_and_show_results): Extracted from run. Set the default json file path using
  8381. port's perf_results_directory and call show_results_html_file at the end if the results page is generated.
  8382. (PerfTestsRunner._generate_results_dict): Renamed from _generate_output to disambiguate it from
  8383. _generate_and_show_results.
  8384. (PerfTestsRunner._generate_output_files): Takes results page's path instead of a boolean indicating
  8385. whether results page should be generated or not.
  8386. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  8387. (create_runner_and_setup_results_template):
  8388. (test_run_respects_results_output): Added.
  8389. (test_run_generates_json_by_default): Added.
  8390. (test_run_generates_and_show_results_page): Added a check to ensure show_results_html_file is called.
  8391. 2012-08-03 Sheriff Bot <webkit.review.bot@gmail.com>
  8392. Unreviewed, rolling out r124628.
  8393. http://trac.webkit.org/changeset/124628
  8394. https://bugs.webkit.org/show_bug.cgi?id=93155
  8395. Causes random crashes of DRT on Chromium bots (Requested by
  8396. dimich on #webkit).
  8397. * DumpRenderTree/DumpRenderTree.gypi:
  8398. * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
  8399. (MockWebKitPlatformSupport::createMediaStreamCenter):
  8400. * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
  8401. (MockWebKitPlatformSupport):
  8402. * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
  8403. * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
  8404. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Removed.
  8405. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Removed.
  8406. 2012-08-03 Brady Eidson <beidson@apple.com>
  8407. Small part of "Out-of-process plug-ins should support asynchronous initialization."
  8408. <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
  8409. Reviewed by Anders Carlsson.
  8410. * WebKitTestRunner/TestController.cpp:
  8411. (WTR::TestController::resetStateToConsistentValues): Reset all preferences related to asynchronous plugin initialization.
  8412. 2012-08-02 Jeffrey Pfau <jpfau@apple.com>
  8413. Add API for enabling blanket third-party data blocking
  8414. https://bugs.webkit.org/show_bug.cgi?id=93022
  8415. Reviewed by Anders Carlsson.
  8416. Added test for default setting of new third-party storage blocking API.
  8417. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  8418. (TestWebKitAPI::TEST):
  8419. 2012-08-03 Arvid Nilsson <anilsson@rim.com>
  8420. Unreviewed, adding self to committers.py after becoming committer.
  8421. * Scripts/webkitpy/common/config/committers.py:
  8422. 2012-08-03 Ádám Kallai <kadam@inf.u-szeged.hu>
  8423. Limited the number of queried cached build infos in URLs used by Garden-o-matic.
  8424. https://bugs.webkit.org/show_bug.cgi?id=92992.
  8425. Reviewed by Adam Barth.
  8426. I added a limit to the cached builds that are included in the URL to avoid too long URLs in Garden-o-matic.
  8427. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  8428. (.):
  8429. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  8430. 2012-08-03 Tommy Widenflycht <tommyw@google.com>
  8431. [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
  8432. https://bugs.webkit.org/show_bug.cgi?id=93091
  8433. Reviewed by Adam Barth.
  8434. Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
  8435. to complete the infrastructure for RTCPeerConnection.
  8436. * DumpRenderTree/DumpRenderTree.gypi:
  8437. * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
  8438. (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
  8439. * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
  8440. (MockWebKitPlatformSupport):
  8441. * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
  8442. * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
  8443. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
  8444. (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
  8445. (MockWebRTCPeerConnectionHandler::initialize):
  8446. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
  8447. (WebKit):
  8448. (MockWebRTCPeerConnectionHandler):
  8449. (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
  8450. 2012-08-03 Hugo Parente Lima <hugo.lima@openbossa.org>
  8451. [Qt][WK2] There's no way to test the gesture tap on WTR
  8452. https://bugs.webkit.org/show_bug.cgi?id=92895
  8453. Reviewed by Kenneth Rohde Christiansen.
  8454. WTR doesn't create the QQuickItem from C++, not from QML, so a call
  8455. to componentComplete() was added to mimic the QML behaviour.
  8456. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  8457. (WTR::PlatformWebView::PlatformWebView):
  8458. 2012-08-03 Balazs Kelemen <kbalazs@webkit.org>
  8459. Unreviewed, rolling out r124567.
  8460. http://trac.webkit.org/changeset/124567
  8461. https://bugs.webkit.org/show_bug.cgi?id=89382
  8462. Broke some tests with external resources
  8463. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  8464. (WTR::InjectedBundlePage::willSendRequestForFrame):
  8465. 2012-08-03 Philippe Normand <pnormand@igalia.com>
  8466. Unreviewed, rolling out r124614.
  8467. http://trac.webkit.org/changeset/124614
  8468. https://bugs.webkit.org/show_bug.cgi?id=91727
  8469. gstreamer core .po files mess up the build again
  8470. * Scripts/webkitdirs.pm:
  8471. (buildAutotoolsProject):
  8472. * gtk/jhbuild.modules:
  8473. 2012-08-03 Philippe Normand <pnormand@igalia.com>
  8474. [GTK][jhbuild] Switch to GStreamer 0.11 build
  8475. https://bugs.webkit.org/show_bug.cgi?id=91727
  8476. Reviewed by Gustavo Noronha Silva.
  8477. Switch build-webkit --gtk to GStreamer 0.11 support and build the
  8478. necessary GStreamer git modules from JHBuild.
  8479. * Scripts/webkitdirs.pm:
  8480. (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
  8481. * gtk/jhbuild.modules: GStreamer build support.
  8482. 2012-08-03 Nico Weber <thakis@chromium.org>
  8483. [chromium mac] DumpRenderTree compile fails with warning/error in LayoutTestHelper.mm with 10.7sdk
  8484. https://bugs.webkit.org/show_bug.cgi?id=92820
  8485. Reviewed by Jochen Eisinger.
  8486. When building with the 10.7 SDK, use newer functions to switch color
  8487. profiles. Note that these newer functions aren't available on 10.6,
  8488. but we don't intend to ship DRT to users, and no bots that currently
  8489. build with the 10.7 SDK ship their binaries to 10.6 testers.
  8490. The new code was copied from Apple's DRT/mac/LayoutTestHelper.m.
  8491. * DumpRenderTree/chromium/LayoutTestHelper.mm:
  8492. (installLayoutTestColorProfile):
  8493. (restoreUserColorProfile):
  8494. (saveCurrentColorProfile):
  8495. 2012-08-03 Benjamin Poulain <benjamin@webkit.org>
  8496. StringImpl created from literal should be BufferInternal
  8497. https://bugs.webkit.org/show_bug.cgi?id=92940
  8498. Reviewed by Anders Carlsson.
  8499. Add tests for the contruction of strings from literal.
  8500. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  8501. * TestWebKitAPI/Tests/WTF/AtomicString.cpp: Added.
  8502. (TestWebKitAPI):
  8503. (TestWebKitAPI::TEST):
  8504. * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Added.
  8505. (TestWebKitAPI):
  8506. (TestWebKitAPI::TEST):
  8507. 2012-08-03 Balazs Kelemen <kbalazs@webkit.org>
  8508. [nrwt] fix unit tests after turned pixel testing to be a per test setting
  8509. https://bugs.webkit.org/show_bug.cgi?id=93112
  8510. Reviewed by Csaba Osztrogonác.
  8511. Change unit tests in accordance of per test switching of pixel testing.
  8512. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  8513. (ChromiumAndroidDriverTest.test_command_from_driver_input):
  8514. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  8515. (DriverTest.test_no_timeout):
  8516. 2012-08-03 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  8517. [Qt] Populate .qmake.cache from the top-level project file
  8518. This makes it possible to build webkit without using the perl build
  8519. script. The duplicated logic in build-webkit will be removed when we
  8520. remove the Qt4 code paths. The build-webkit script will then simply
  8521. call 'qmake WebKit.pro' from WEBKITOUTPUTDIR.
  8522. Reviewed by Tor Arne Vestbø.
  8523. * qmake/mkspecs/features/win32/default_pre.prf:
  8524. 2012-08-03 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  8525. [Qt] Move build config default to build-webkit instead of default_pre
  8526. Allows the qmake buildsystem have its own default.
  8527. Reviewed by Tor Arne Vestbø.
  8528. * Scripts/webkitdirs.pm:
  8529. (buildQMakeProjects):
  8530. * qmake/mkspecs/features/default_pre.prf:
  8531. 2012-08-03 Mario Sanchez Prada <msanchez@igalia.com>
  8532. Unreviewed build fix for GTK after r124581.
  8533. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  8534. (runTest): Fix wrong variable name in ASSERT.
  8535. 2012-08-03 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  8536. [Qt] Always save CONFIG & DEFINES in default_pre
  8537. Always doing it is cheaper than checking whether it needs to be done.
  8538. apart from that, it would break configuration initiated from another
  8539. project.
  8540. Reviewed by Tor Arne Vestbø.
  8541. * qmake/mkspecs/features/default_pre.prf:
  8542. 2012-08-03 Joone Hur <joone.hur@intel.com>
  8543. [EFL][DRT] fast/loader/stop-provisional-loads.html fails
  8544. https://bugs.webkit.org/show_bug.cgi?id=92219
  8545. Reviewed by Kenneth Rohde Christiansen.
  8546. This patch adds the ability to tell DRT to call ewk_frame_stop
  8547. inside of a didStartProvisionalLoadForFrame signal handler.
  8548. It allows to pass fast/loader/stop-provisional-loads.html.
  8549. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  8550. (DumpRenderTreeChrome::onFrameProvisionalLoad):
  8551. 2012-08-03 Balazs Kelemen <kbalazs@webkit.org>
  8552. [WTR] process unresponsiveness is reported to the wrong test
  8553. https://bugs.webkit.org/show_bug.cgi?id=88404
  8554. 2nd unreviewed buildfix.
  8555. * WebKitTestRunner/TestInvocation.cpp:
  8556. 2012-08-03 Balazs Kelemen <kbalazs@webkit.org>
  8557. [WTR] process unresponsiveness is reported to the wrong test
  8558. https://bugs.webkit.org/show_bug.cgi?id=88404
  8559. Unreviewed buildfix. Also made the change on the array size
  8560. suggested on review because I forgot it when landed.
  8561. * WebKitTestRunner/TestInvocation.cpp:
  8562. (WTR::TestInvocation::invoke):
  8563. 2012-08-03 Balazs Kelemen <kbalazs@webkit.org>
  8564. [WTR] process unresponsiveness is reported to the wrong test
  8565. https://bugs.webkit.org/show_bug.cgi?id=88404
  8566. Reviewed by Zoltan Herczeg.
  8567. Do resetting to consistent state after the finished test,
  8568. not before the next. This way we can report unresponsiveness
  8569. to the test that triggered it, and we do a restart before the
  8570. next test so it will start in a functional state.
  8571. * Scripts/webkitpy/layout_tests/port/webkit.py:
  8572. (WebKitDriver._check_for_driver_crash):
  8573. Print the error line for unresponsive web process, otherwise
  8574. it's hard to tell what happened.
  8575. * WebKitTestRunner/TestController.cpp:
  8576. (WTR):
  8577. Decreased the default short timeout so we can detect unresponsiveness
  8578. before the timer of the test harness times out. It was unnecessarily
  8579. high anyway, we should get answer from the web process in those cases
  8580. when the short timeout is used in less than a second.
  8581. (WTR::TestController::runTest):
  8582. (WTR::TestController::run):
  8583. * WebKitTestRunner/TestController.h:
  8584. (TestController):
  8585. * WebKitTestRunner/TestInvocation.cpp:
  8586. (WTR::TestInvocation::invoke):
  8587. (WTR::TestInvocation::dump):
  8588. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  8589. * WebKitTestRunner/TestInvocation.h:
  8590. (TestInvocation): Make the dump function static as it doesn't need an object.
  8591. 2012-08-03 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  8592. [EFL] (REGRESSION 124581) : EFL 64-bit Debug bot is red and build is exiting early after 20 test crashes
  8593. https://bugs.webkit.org/show_bug.cgi?id=93084
  8594. Reviewed by Csaba Osztrogonác.
  8595. Fix regression introduced in r124581.
  8596. * DumpRenderTree/efl/DumpRenderTree.cpp:
  8597. (getFinalTestURL): Convert the path into a full file URL.
  8598. (runTest):
  8599. 2012-08-03 Balazs Kelemen <kbalazs@webkit.org>
  8600. All ports should support per test switching of pixel testing
  8601. https://bugs.webkit.org/show_bug.cgi?id=92398
  8602. Reviewed by Dirk Pranke.
  8603. Teach all test drivers to accept a per test control of whether
  8604. to dump pixels. Drivers now accept a -p/--pixel-test argument
  8605. on the standart input that means that running the current
  8606. test as pixel test is allowed (even if the expected hash is
  8607. missing). Removed the --pixel-tests command line option since
  8608. there is no need for it anymore.
  8609. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  8610. * DumpRenderTree/DumpRenderTree.gypi:
  8611. * DumpRenderTree/DumpRenderTree.h:
  8612. (TestCommand::TestCommand):
  8613. (TestCommand):
  8614. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  8615. * DumpRenderTree/DumpRenderTreeCommon.cpp: Added.
  8616. (CommandTokenizer):
  8617. (CommandTokenizer::CommandTokenizer):
  8618. (CommandTokenizer::pump):
  8619. (CommandTokenizer::next):
  8620. (CommandTokenizer::hasNext):
  8621. (die):
  8622. (parseInputLine):
  8623. Common logic to parse the input line from the standard input (or from the command line
  8624. in standalone mode). Made it somewhat general so we can easily add more arguments if
  8625. there is a need.
  8626. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  8627. (runTest):
  8628. (main):
  8629. * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp.
  8630. * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityController.h.
  8631. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp.
  8632. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h.
  8633. Renamed these files with a Chromium suffix because they were clashing with the common ones used by other ports after adding the root
  8634. DumpRenderTree directory to the include path.
  8635. * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
  8636. * DumpRenderTree/chromium/TestShell.cpp:
  8637. (TestShell::TestShell):
  8638. (TestShell::runFileTest):
  8639. (TestShell::dump):
  8640. * DumpRenderTree/chromium/TestShell.h:
  8641. (TestParams::TestParams):
  8642. (TestShell):
  8643. * DumpRenderTree/efl/CMakeLists.txt:
  8644. * DumpRenderTree/efl/DumpRenderTree.cpp:
  8645. (parseCommandLineOptions):
  8646. (runTest):
  8647. (shouldDumpPixelsAndCompareWithExpected):
  8648. (main):
  8649. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  8650. (initializeGlobalsFromCommandLineOptions):
  8651. (dump):
  8652. (runTest):
  8653. (main):
  8654. * DumpRenderTree/mac/DumpRenderTree.mm:
  8655. (initializeGlobalsFromCommandLineOptions):
  8656. (dumpRenderTree):
  8657. (dump):
  8658. (runTest):
  8659. * DumpRenderTree/qt/DumpRenderTree.pro:
  8660. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  8661. (WebCore::DumpRenderTree::DumpRenderTree):
  8662. (WebCore::DumpRenderTree::open):
  8663. (WebCore::DumpRenderTree::processLine):
  8664. (WebCore::DumpRenderTree::dump):
  8665. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  8666. (DumpRenderTree):
  8667. * DumpRenderTree/qt/main.cpp:
  8668. (isOption):
  8669. (printUsage):
  8670. (main):
  8671. * DumpRenderTree/win/DumpRenderTree.cpp:
  8672. (dump):
  8673. (runTest):
  8674. (dllLauncherEntryPoint):
  8675. * DumpRenderTree/win/DumpRenderTree.vcproj:
  8676. * DumpRenderTree/wscript:
  8677. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  8678. (dump):
  8679. (runTest):
  8680. (MyApp::OnInit):
  8681. * GNUmakefile.am:
  8682. * Scripts/old-run-webkit-tests:
  8683. * Scripts/old-run-webkit-tests:
  8684. Pass --pixel-test before the hash.
  8685. * Scripts/webkitpy/layout_tests/port/base.py:
  8686. (Port.should_run_as_pixel_test): Removed now that all ports supports it.
  8687. * Scripts/webkitpy/layout_tests/port/driver.py:
  8688. (Driver.cmd_line): Don't pass --pixel-tests anymore.
  8689. (Driver._command_from_driver_input):
  8690. * Scripts/webkitpy/layout_tests/port/qt.py:
  8691. (QtPort.should_run_as_pixel_test):
  8692. * Scripts/webkitpy/layout_tests/port/test.py:
  8693. (TestPort.should_run_as_pixel_test):
  8694. * WebKitTestRunner/TestController.cpp:
  8695. (WTR::TestController::TestController):
  8696. (WTR::TestController::initialize):
  8697. (WTR::TestCommand::TestCommand):
  8698. (TestCommand):
  8699. (WTR):
  8700. (CommandTokenizer):
  8701. (WTR::CommandTokenizer::CommandTokenizer):
  8702. (WTR::CommandTokenizer::pump):
  8703. (WTR::CommandTokenizer::next):
  8704. (WTR::CommandTokenizer::hasNext):
  8705. (WTR::die):
  8706. (WTR::parseInputLine):
  8707. (WTR::TestController::runTest):
  8708. * WebKitTestRunner/TestController.h:
  8709. (TestController):
  8710. Duplicate the logic for parsing the command line because
  8711. unfortunately there is no way to share code between
  8712. WebKitTestRunner and DumpRenderTree.
  8713. 2012-08-03 Ilya Tikhonovsky <loislo@chromium.org>
  8714. Web Inspector: clang plugin for checking native memory instrumentation coverage.
  8715. https://bugs.webkit.org/show_bug.cgi?id=92650
  8716. Reviewed by Yury Semikhatsky.
  8717. This is the clang plugin for checking native memory instrumentation coverage.
  8718. The idea: InspectorMemoryAgent traverses through instrumented objects and collects pointers and their sizes and types.
  8719. It is doing that with help of reportMemoryUsage function that needs to be implemented in each, significant
  8720. from native memory footprint point of view, WebCore class.
  8721. This plugin checks that the list of class members is matching with the list of members reported in reportMemoryUsage function
  8722. and makes a warning for the each member that needs to be reported.
  8723. * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Added.
  8724. * clang/ReportMemoryUsagePlugin/Makefile: Added.
  8725. * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Added.
  8726. (clang):
  8727. (AddMemberCallVisitor):
  8728. (clang::AddMemberCallVisitor::VisitCallExpr):
  8729. (clang::AddMemberCallVisitor::instrumentedMembers):
  8730. (ReportMemoryUsageVisitor):
  8731. (clang::ReportMemoryUsageVisitor::ReportMemoryUsageVisitor):
  8732. (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
  8733. (clang::ReportMemoryUsageVisitor::emitWarning):
  8734. (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
  8735. (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
  8736. (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
  8737. (ReportMemoryUsageConsumer):
  8738. (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
  8739. (clang::ReportMemoryUsageConsumer::HandleTranslationUnit):
  8740. (ReportMemoryUsageAction):
  8741. (clang::ReportMemoryUsageAction::CreateASTConsumer):
  8742. (clang::ReportMemoryUsageAction::ParseArgs):
  8743. * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Added.
  8744. (aNamespace):
  8745. (MemoryInstrumentation):
  8746. (MemoryClassInfo):
  8747. (aNamespace::MemoryClassInfo::MemoryClassInfo):
  8748. (aNamespace::MemoryClassInfo::addMember):
  8749. (aNamespace::MemoryClassInfo::addInstrumentedMember):
  8750. (OwnPtr):
  8751. (aNamespace::OwnPtr::OwnPtr):
  8752. (RefPtr):
  8753. (aNamespace::RefPtr::RefPtr):
  8754. (Vector):
  8755. (String):
  8756. (NotInstrumentedClass):
  8757. (InstrumentedClass):
  8758. (aNamespace::InstrumentedClass::reportMemoryUsage):
  8759. (InstrumentedChildClass):
  8760. (aNamespace::InstrumentedChildClass::reportMemoryUsage):
  8761. (InstrumentedChildChildClass):
  8762. (InstrumentedChildChildClass::reportMemoryUsage):
  8763. (main):
  8764. 2012-08-03 Joone Hur <joone.hur@intel.com>
  8765. [EFL][DRT] WebKitAnimation API compile-time disabled
  8766. https://bugs.webkit.org/show_bug.cgi?id=84593
  8767. Reviewed by Laszlo Gombos.
  8768. Enable ENABLE_ANIMATION_API by default on the Efl port.
  8769. * Scripts/webkitperl/FeatureList.pm:
  8770. 2012-08-03 Balazs Kelemen <kbalazs@webkit.org>
  8771. WTR should be able to load external resources
  8772. https://bugs.webkit.org/show_bug.cgi?id=89382
  8773. Reviewed by Ryosuke Niwa.
  8774. Allow to load an external resource as the main frame
  8775. and allow all subsequent external loads for such a main
  8776. frame. This behavior is necessary for being able to run
  8777. performance tests (wkb.ug/84008).
  8778. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  8779. (WTR::isLocalHost):
  8780. (WTR):
  8781. (WTR::isHTTPOrHTTPSScheme):
  8782. (WTR::InjectedBundlePage::willSendRequestForFrame):
  8783. 2012-08-02 Joone Hur <joone.hur@intel.com>
  8784. [GTK] Build break when building DumpRenderTree/gtk/EditingCallbacks.cpp
  8785. https://bugs.webkit.org/show_bug.cgi?id=93061
  8786. Unreviewed, Fix build break for WebKitGtk+.
  8787. Use webkit_dom_element_get_class_name instead of webkit_dom_html_element_get_class_name.
  8788. * DumpRenderTree/gtk/EditingCallbacks.cpp:
  8789. (shouldShowDeleteInterfaceForElement):
  8790. 2012-08-02 Dirk Pranke <dpranke@chromium.org>
  8791. test-webkitpy can fail on a clean checkout
  8792. https://bugs.webkit.org/show_bug.cgi?id=93039
  8793. Reviewed by Adam Barth.
  8794. Now that we run tests in parallel that can cause the installer
  8795. to try and install packages in parallel (even the same package),
  8796. and that probably won't work. We fix this by autoinstalling
  8797. everything up front (serially).
  8798. * Scripts/webkitpy/test/main.py:
  8799. (Tester._run_tests):
  8800. * Scripts/webkitpy/thirdparty/__init__.py:
  8801. (autoinstall_everything):
  8802. 2012-06-15 David Barton <dbarton@mathscribe.com>
  8803. MathML: nested square root symbols have varying descenders
  8804. https://bugs.webkit.org/show_bug.cgi?id=43819
  8805. Reviewed by Eric Seidel.
  8806. Allow the STIXGeneral font to be used during layout tests, especially for MathML.
  8807. * DumpRenderTree/mac/DumpRenderTree.mm:
  8808. (allowedFontFamilySet):
  8809. * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  8810. (WTR::allowedFontFamilySet):
  8811. 2012-08-02 Dirk Pranke <dpranke@chromium.org>
  8812. test-webkitpy: some tests need to run by themselves
  8813. https://bugs.webkit.org/show_bug.cgi?id=92926
  8814. Reviewed by Ojan Vafai.
  8815. Due to timing issues some of the executive tests will collide
  8816. and fail if they're run concurrently. This patch adds support
  8817. for writing tests that will be executed one at a time
  8818. (serially); to get them, add "serial_" to the front of the test
  8819. method name.
  8820. * Scripts/webkitpy/common/system/executive_unittest.py:
  8821. (ExecutiveTest.serial_test_kill_process):
  8822. (ExecutiveTest.serial_test_kill_all):
  8823. (ExecutiveTest.serial_test_check_running_pid):
  8824. (ExecutiveTest.serial_test_running_pids):
  8825. (ExecutiveTest.serial_test_run_in_parallel):
  8826. * Scripts/webkitpy/test/main.py:
  8827. (Tester._run_tests):
  8828. (Tester._test_names):
  8829. 2012-08-02 Dirk Pranke <dpranke@chromium.org>
  8830. test-webkitpy: integrate proper support for integration tests
  8831. https://bugs.webkit.org/show_bug.cgi?id=92925
  8832. Reviewed by Ojan Vafai.
  8833. This patch merges the custom loader I used for integration tests
  8834. into the main test-webkitpy code. Integration tests are not run
  8835. by default yet, but at least they can be run.
  8836. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  8837. (MockTestShellTest.test_test_shell_parse_options):
  8838. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  8839. (test_path_to_apache_config_file):
  8840. * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
  8841. (WebsocketserverTest):
  8842. * Scripts/webkitpy/test/main.py:
  8843. (Tester._parse_args):
  8844. (Tester._run_tests):
  8845. (Tester._test_names):
  8846. (Tester._log_exception):
  8847. (_Loader):
  8848. (_Loader.getTestCaseNames):
  8849. (_Loader.getTestCaseNames.isTestMethod):
  8850. 2012-08-02 Dirk Pranke <dpranke@chromium.org>
  8851. test-webkitpy: clean up runner in preparation for running tests serially as necessary
  8852. https://bugs.webkit.org/show_bug.cgi?id=92922
  8853. Reviewed by Ojan Vafai.
  8854. In order to run some tests by themselves (serially, rather than
  8855. in parallel with other tests), we will need to be able to run
  8856. multiple test suites; this causes us to move loading the logic
  8857. for finding test method names out of the runner and into main.
  8858. I'm taking advantage of this to simplify some other stuff from
  8859. the runner as well; it is now very simple and doesn't expose its
  8860. dependency on unittest.TestResult at all (nor will the Printer
  8861. use TestResult).
  8862. Subsequent patches will move the custom loader from
  8863. port_testcase so that we can properly choose whether to run
  8864. integration tests and/or serial tests, and then update the
  8865. appropriate tests to run only serially.
  8866. * Scripts/webkitpy/test/main.py:
  8867. (Tester._run_tests):
  8868. (Tester):
  8869. (Tester._check_imports):
  8870. (Tester._test_names):
  8871. (Tester._all_test_names):
  8872. * Scripts/webkitpy/test/printer.py:
  8873. (Printer.__init__):
  8874. (Printer.write_update):
  8875. (Printer):
  8876. (Printer.print_finished_test):
  8877. (Printer.print_result):
  8878. * Scripts/webkitpy/test/runner.py:
  8879. (unit_test_name):
  8880. (Runner.__init__):
  8881. (Runner.run):
  8882. (Runner.handle):
  8883. (_Worker.handle):
  8884. * Scripts/webkitpy/test/runner_unittest.py:
  8885. (FakeLoader.loadTestsFromName):
  8886. (RunnerTest.test_run):
  8887. 2012-08-02 Adam Barth <abarth@webkit.org>
  8888. Turn on tests for the mac-ews, for realz this time.
  8889. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  8890. (MacEWS):
  8891. 2012-08-02 Xianzhu Wang <wangxianzhu@chromium.org>
  8892. [Chromium-Android] Run layout tests on multiple devices in parallel
  8893. https://bugs.webkit.org/show_bug.cgi?id=92877
  8894. Reviewed by Dirk Pranke.
  8895. Moved methods that run command on a particular device from ChromiumAndroidPort to ChromiumAndroidDriver.
  8896. The drivers run adb commands with the '-s serial_number' parameter which specifies the device according to the work_number.
  8897. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  8898. (ChromiumAndroidPort.__init__):
  8899. (ChromiumAndroidPort.default_child_processes): Default to the number of attached devices.
  8900. (ChromiumAndroidPort.test_expectations): Removed because it is unused.
  8901. (ChromiumAndroidPort.setup_test_run): Most contents moved into ChromiumAndroidDriver._setup_test()
  8902. (ChromiumAndroidPort.clean_up_test_run): Now the http server is stopped here.
  8903. (ChromiumAndroidPort._get_devices):
  8904. (ChromiumAndroidPort._get_device_serial):
  8905. (ChromiumAndroidDriver):
  8906. (ChromiumAndroidDriver.__init__):
  8907. (ChromiumAndroidDriver.__del__):
  8908. (ChromiumAndroidDriver._setup_test): Original contents of ChromiumAndroidPort.setup_test_run().
  8909. (ChromiumAndroidDriver._push_executable): Moved from ChromiumAndroidPort.
  8910. (ChromiumAndroidDriver._push_fonts): Moved from ChromiumAndroidPort.
  8911. (ChromiumAndroidDriver._push_test_resources): Moved from ChromiumAndroidPort.
  8912. (ChromiumAndroidDriver._synchronize_datetime): Moved from ChromiumAndroidPort.
  8913. (ChromiumAndroidDriver._run_adb_command): Moved from ChromiumAndroidPort.
  8914. (ChromiumAndroidDriver._teardown_performance): Moved from ChromiumAndroidPort.
  8915. (ChromiumAndroidDriver._get_crash_log): Moved from ChromiumAndroidPort.
  8916. (ChromiumAndroidDriver.cmd_line):
  8917. (ChromiumAndroidDriver._file_exists_on_device):
  8918. (ChromiumAndroidDriver._remove_all_pipes):
  8919. (ChromiumAndroidDriver._start):
  8920. (ChromiumAndroidDriver._start_once):
  8921. (ChromiumAndroidDriver.stop):
  8922. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  8923. (MockRunCommand):
  8924. (MockRunCommand.__init__):
  8925. (MockRunCommand.mock_run_command_fn):
  8926. (MockRunCommand.mock_no_device):
  8927. (MockRunCommand.mock_one_device):
  8928. (MockRunCommand.mock_two_devices):
  8929. (MockRunCommand.mock_no_tombstone_dir):
  8930. (MockRunCommand.mock_no_tombstone_file):
  8931. (MockRunCommand.mock_ten_tombstones):
  8932. (MockRunCommand.mock_logcat):
  8933. (ChromiumAndroidPortTest):
  8934. (ChromiumAndroidPortTest.make_port):
  8935. (ChromiumAndroidPortTest.test_driver_cmd_line):
  8936. (ChromiumAndroidPortTest.test_get_devices_no_device):
  8937. (ChromiumAndroidPortTest.test_get_devices_one_device):
  8938. (ChromiumAndroidPortTest.test_get_devices_two_devices):
  8939. (ChromiumAndroidPortTest.test_get_device_serial_no_device):
  8940. (ChromiumAndroidPortTest.test_get_device_serial_one_device):
  8941. (ChromiumAndroidPortTest.test_get_device_serial_two_devices):
  8942. (ChromiumAndroidDriverTest):
  8943. (ChromiumAndroidDriverTest.setUp):
  8944. (ChromiumAndroidDriverTest.test_get_last_stacktrace):
  8945. (ChromiumAndroidDriverTest.test_get_crash_log):
  8946. (ChromiumAndroidDriverTest.test_cmd_line):
  8947. (ChromiumAndroidDriverTwoDriversTest):
  8948. (ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
  8949. * Scripts/webkitpy/layout_tests/port/driver.py:
  8950. (Driver.run_test):
  8951. (Driver._get_crash_log): Added to allow subclasses to override.
  8952. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  8953. (parse_args): Removed the --adb-args command-line parameter because now we select device automatically. Added --adb-device to specify devices.
  8954. 2012-08-02 Dinu Jacob <dinu.jacob@nokia.com>
  8955. WebKitTestRunner needs layoutTestController.setUserStyleSheetEnabled
  8956. https://bugs.webkit.org/show_bug.cgi?id=42679
  8957. Reviewed by Eric Seidel.
  8958. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
  8959. setUserStyleSheetEnabled and setUserStyleSheetLocation.
  8960. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  8961. (WTR::LayoutTestController::LayoutTestController): Initialize new members added.
  8962. (WTR::LayoutTestController::setUserStyleSheetEnabled): Added.
  8963. (WTR::LayoutTestController::setUserStyleSheetLocation): Added.
  8964. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added members
  8965. userStyleSheetEnabled, and m_userStyleSheetLocation and methods
  8966. setUserStyleSheetEnabled, and setUserStyleSheetLocation.
  8967. 2012-08-02 Hans Wennborg <hans@chromium.org>
  8968. Speech JavaScript API: Fire speech start event at the same time as sound start event
  8969. https://bugs.webkit.org/show_bug.cgi?id=92971
  8970. Reviewed by Adam Barth.
  8971. Update the MockWebSpeechRecognizer to not fire "speech started" events
  8972. separately.
  8973. * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
  8974. (MockWebSpeechRecognizer::start):
  8975. 2012-08-02 Philippe Normand <pnormand@igalia.com>
  8976. [GTK] make sometimes using a single core
  8977. https://bugs.webkit.org/show_bug.cgi?id=92998
  8978. Reviewed by Martin Robinson.
  8979. In the GTK 64-bit Release buildbot some builds use a single core
  8980. for the make process. I suspect this is because in those cases
  8981. nproc reports a single core available. The proposed solution is to
  8982. always rely on all the cores available in the machine.
  8983. * Scripts/webkitdirs.pm:
  8984. (determineNumberOfCPUs):
  8985. 2012-08-02 Adam Barth <abarth@webkit.org>
  8986. Re-land http://trac.webkit.org/changeset/94441 now that lforschler is ready.
  8987. This patch enables testing on the mac-ews bots.
  8988. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  8989. 2012-08-02 Adam Barth <abarth@webkit.org>
  8990. [Chromium] Merge final nits to DumpRenderTree.gyp for Android
  8991. https://bugs.webkit.org/show_bug.cgi?id=90920
  8992. Reviewed by Tony Chang.
  8993. This patch contains the last few small changes to DumpRenderTree.gyp
  8994. from the chromium-android branch. After this change, this file will be
  8995. fully merged.
  8996. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  8997. 2012-08-02 Peter Beverloo <peter@chromium.org>
  8998. [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI
  8999. https://bugs.webkit.org/show_bug.cgi?id=92858
  9000. Reviewed by Adam Barth.
  9001. Now that the sdk_build variable is available, we can remove these two differences
  9002. as well. This goes together with Adam's bug 90920.
  9003. After this patch, the whole Tools/ directory will be unforked :-).
  9004. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  9005. 2012-08-02 Zoltan Arvai <zarvai@inf.u-szeged.hu>
  9006. [Qt] MSVC specific buildfix for DRT.
  9007. https://bugs.webkit.org/show_bug.cgi?id=92978
  9008. Reviewed by Simon Hausmann.
  9009. DumpRenderTree/qt subdirectory is missing from generated makefile under MSVC build, need to be added to the pro file.
  9010. * DumpRenderTree/qt/DumpRenderTree.pro:
  9011. 2012-08-02 Alexander Shalamov <alexander.shalamov@intel.com>
  9012. [EFL][WK2] WTR is failing when X server is not running
  9013. https://bugs.webkit.org/show_bug.cgi?id=92719
  9014. Reviewed by Hajime Morita.
  9015. EFL's WebKitTestRunner doesn't execute tests when X server is not running.
  9016. This patch fixes the problem by checking environment variable before ecore x initialization.
  9017. * Scripts/webkitpy/layout_tests/port/efl.py:
  9018. (EflPort.setup_environ_for_server):
  9019. * WebKitTestRunner/efl/main.cpp:
  9020. (main):
  9021. 2012-08-01 Dirk Pranke <dpranke@chromium.org>
  9022. REGRESSION(r123893): Reftest mismatches are run through ImageDiff with 0.1 tolerance
  9023. https://bugs.webkit.org/show_bug.cgi?id=92847
  9024. Reviewed by Ojan Vafai.
  9025. I was failing to distinguish between 'None' and 0 :(. Fixed and added tests.
  9026. * Scripts/webkitpy/layout_tests/port/base.py:
  9027. (Port.diff_image):
  9028. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  9029. (PortTestCase.test_diff_image.make_proc):
  9030. (PortTestCase.test_diff_image):
  9031. 2012-08-01 Dirk Pranke <dpranke@chromium.org>
  9032. test-webkitpy: clean up handling of tests to skip
  9033. https://bugs.webkit.org/show_bug.cgi?id=92909
  9034. Reviewed by Ryosuke Niwa.
  9035. This change moves the handling of tests to skip into main.py
  9036. where it is at least slightly more findable and generic.
  9037. Also fix a couple of lint nits.
  9038. * Scripts/webkitpy/test/finder.py:
  9039. (Finder.__init__):
  9040. (Finder.skip):
  9041. (Finder._default_names):
  9042. * Scripts/webkitpy/test/main.py:
  9043. (main):
  9044. (Tester.skip):
  9045. * Scripts/webkitpy/test/main_unittest.py:
  9046. (TesterTest.test_no_tests_found):
  9047. * Scripts/webkitpy/test/runner_unittest.py:
  9048. 2012-08-01 Dirk Pranke <dpranke@chromium.org>
  9049. test-webkitpy: remove --skip-integrationtests flag
  9050. https://bugs.webkit.org/show_bug.cgi?id=92907
  9051. Reviewed by Ryosuke Niwa.
  9052. This flag is no longer used since the tests complete quickly.
  9053. Also clean up the unused skip_if_parallel arg in finder, and
  9054. make a couple of lint fixes.
  9055. * Scripts/webkitpy/test/finder.py:
  9056. (Finder.find_names):
  9057. (Finder._default_names):
  9058. * Scripts/webkitpy/test/finder_unittest.py:
  9059. (FinderTest.check_names):
  9060. (FinderTest.test_default_names):
  9061. * Scripts/webkitpy/test/main.py:
  9062. (Tester._parse_args):
  9063. (Tester.run):
  9064. * Scripts/webkitpy/test/main_unittest.py:
  9065. (TesterTest.test_no_tests_found):
  9066. 2012-08-01 Ryosuke Niwa <rniwa@webkit.org>
  9067. Generalize SheriffIRCBot to prepare for PerfBot
  9068. https://bugs.webkit.org/show_bug.cgi?id=92912
  9069. Reviewed by Adam Barth.
  9070. Renamed SheriffIRCBot to IRCBot and generalized to support non-sheriffbot IRC bot in the future.
  9071. This will be useful when I add an experimental perf EWS IRC bot.
  9072. * Scripts/webkitpy/tool/bot/irc_command.py:
  9073. (Whois.execute):
  9074. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  9075. (IRCCommandTest):
  9076. * Scripts/webkitpy/tool/bot/ircbot.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py.
  9077. (Eliza): Moved from irc_command.
  9078. (Eliza.__init__):
  9079. (Eliza.execute):
  9080. (IRCBot):
  9081. (IRCBot.__init__):
  9082. (IRCBot.irc_delegate):
  9083. (IRCBot._parse_command_and_args):
  9084. (IRCBot.process_message):
  9085. * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py.
  9086. (run):
  9087. (IRCBotTest):
  9088. (IRCBotTest.test_eliza): Moved from IRCCommandTest.
  9089. (IRCBotTest.test_parse_command_and_args):
  9090. (IRCBotTest.test_exception_during_command):
  9091. * Scripts/webkitpy/tool/bot/sheriffircbot.py: Removed.
  9092. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Removed.
  9093. * Scripts/webkitpy/tool/commands/sheriffbot.py:
  9094. (SheriffBot.begin_work_queue):
  9095. * Scripts/webkitpy/webkitpy.pyproj:
  9096. 2012-08-01 Dirk Pranke <dpranke@chromium.org>
  9097. nrwt: reenable the test for --verbose working in child processes
  9098. https://bugs.webkit.org/show_bug.cgi?id=92894
  9099. Reviewed by Ryosuke Niwa.
  9100. This change rewrites the test to not use outputcapture, meaning
  9101. that the MockHost can propagate to Worker properly and things
  9102. work again :).
  9103. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  9104. (MainTest.test_verbose_in_child_processes):
  9105. 2012-08-01 Ryosuke Niwa <rniwa@webkit.org>
  9106. run-perf-tests --build-directory doesn't work
  9107. https://bugs.webkit.org/show_bug.cgi?id=92051
  9108. Reviewed by Dirk Pranke.
  9109. The bug was caused by not prepending build_directory even when one is defined.
  9110. Fixed that.
  9111. * Scripts/webkitpy/layout_tests/port/base.py:
  9112. (Port._build_path):
  9113. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  9114. (PortTest.test_build_path):
  9115. 2012-08-01 Sheriff Bot <webkit.review.bot@gmail.com>
  9116. Unreviewed, rolling out r123865.
  9117. http://trac.webkit.org/changeset/123865
  9118. https://bugs.webkit.org/show_bug.cgi?id=92891
  9119. This patch is causing the style-queue to fall behind
  9120. (Requested by abarth on #webkit).
  9121. * Scripts/webkitpy/tool/commands/queues.py:
  9122. (AbstractReviewQueue.begin_work_queue):
  9123. (StyleQueue.__init__):
  9124. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  9125. (StyleQueueTest.test_style_queue_with_style_exception):
  9126. (test_style_queue_with_watch_list_exception):
  9127. 2012-08-01 Ryosuke Niwa <rniwa@webkit.org>
  9128. run-perf-tests throws an exception when the output json is malformed
  9129. https://bugs.webkit.org/show_bug.cgi?id=92887
  9130. Reviewed by Dirk Pranke.
  9131. Catch exceptions and gracefully fail. Also split _generate_json into smaller methods.
  9132. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  9133. (PerfTestsRunner):
  9134. (PerfTestsRunner.run):
  9135. (PerfTestsRunner._generate_output): Extracted from _generate_json.
  9136. (PerfTestsRunner._merge_source_json): Ditto; catch all exceptions since they are too many
  9137. exceptions to consder here.
  9138. (PerfTestsRunner._merge_outputs): Ditto.
  9139. (PerfTestsRunner._generate_output_files): Extracted from _generate_json.
  9140. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  9141. (_test_run_with_json_output): Don't assert logs when we except an non-zero exit code.
  9142. (create_runner_and_setup_results_template): Extracted from test_run_generates_results_page.
  9143. (test_run_generates_results_page):
  9144. (test_run_with_bad_output_json): Added.
  9145. (test_run_with_bad_json_source): Added.
  9146. (test_run_with_upload_json):
  9147. 2012-08-01 Thiago Marcos P. Santos <thiago.santos@intel.com>
  9148. Regression(r124135): nrwt: --verbose logging does not work right on windows
  9149. https://bugs.webkit.org/show_bug.cgi?id=92845
  9150. Reviewed by Dirk Pranke.
  9151. Disabled the failing test. The Workers spawned by this test are using Host()
  9152. instead of MockHost() and trying to access the real filesystem instead of the
  9153. MockFilesytem.
  9154. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  9155. (MainTest.disabled_test_verbose):
  9156. 2012-08-01 Arnaud Renevier <a.renevier@sisa.samsung.com>
  9157. keyring.get_password may raise an exception.
  9158. https://bugs.webkit.org/show_bug.cgi?id=92876
  9159. Reviewed by Dirk Pranke.
  9160. keyring.get_password sometimes raises an exception. We wrap this call,
  9161. and also set_password to avoid breaking webkit-patch in that case.
  9162. * Scripts/webkitpy/common/net/credentials.py:
  9163. (Credentials._offer_to_store_credentials_in_keyring):
  9164. (Credentials.read_credentials):
  9165. 2012-08-01 Xianzhu Wang <wangxianzhu@chromium.org>
  9166. Layout Test fast/text/descent-clip-in-scaled-page.html is failing on linux since it was added
  9167. https://bugs.webkit.org/show_bug.cgi?id=91386
  9168. Reviewed by Tony Chang.
  9169. Added font mapping from SubpixelPositioningAhem to Ahem on Linux and Android
  9170. (used in layout test fast/text/descent-clip-in-scaled-page.html).
  9171. Added font mapping from SubpixelPositioning to Times New Roman on Android to match Linux
  9172. (used in platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html)
  9173. * DumpRenderTree/chromium/android_main_fonts.xml:
  9174. * DumpRenderTree/chromium/fonts.conf:
  9175. 2012-08-01 Sheriff Bot <webkit.review.bot@gmail.com>
  9176. Unreviewed, rolling out r124325.
  9177. http://trac.webkit.org/changeset/124325
  9178. https://bugs.webkit.org/show_bug.cgi?id=92865
  9179. broke android build (Requested by mnaganov on #webkit).
  9180. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  9181. 2012-08-01 Thiago Marcos P. Santos <thiago.santos@intel.com>
  9182. [EFL] Dump a backtrace in case of a crash on the UIProcess
  9183. https://bugs.webkit.org/show_bug.cgi?id=92843
  9184. Reviewed by Csaba Osztrogonác.
  9185. We are already dumping the backtraces when automated tests are
  9186. crashing, but only for the WebProcess. This patch adds the same
  9187. hooks for the UIProcess.
  9188. * TestWebKitAPI/efl/main.cpp:
  9189. (main):
  9190. * WebKitTestRunner/efl/main.cpp:
  9191. (main):
  9192. 2012-08-01 Adam Barth <abarth@webkit.org>
  9193. [Chromium] Merge final nits to DumpRenderTree.gyp for Android
  9194. https://bugs.webkit.org/show_bug.cgi?id=90920
  9195. Reviewed by Tony Chang.
  9196. This patch contains the last few small changes to DumpRenderTree.gyp
  9197. from the chromium-android branch. After this change, this file will be
  9198. fully merged.
  9199. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  9200. 2012-08-01 Csaba Osztrogonác <ossy@webkit.org>
  9201. [Qt] ImageDiff should use float division instead of integer
  9202. https://bugs.webkit.org/show_bug.cgi?id=92859
  9203. Reviewed by Zoltan Herczeg.
  9204. * DumpRenderTree/qt/ImageDiff.cpp:
  9205. (main):
  9206. 2012-08-01 Sheriff Bot <webkit.review.bot@gmail.com>
  9207. Unreviewed, rolling out r124313.
  9208. http://trac.webkit.org/changeset/124313
  9209. https://bugs.webkit.org/show_bug.cgi?id=92855
  9210. Compilation failed on Chromium ports (Requested by yosin on
  9211. #webkit).
  9212. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  9213. * DumpRenderTree/DumpRenderTree.gypi:
  9214. * DumpRenderTree/DumpRenderTree.h:
  9215. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  9216. * DumpRenderTree/DumpRenderTreeCommon.cpp: Removed.
  9217. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  9218. (runTest):
  9219. (main):
  9220. * DumpRenderTree/chromium/TestShell.cpp:
  9221. (TestShell::TestShell):
  9222. (TestShell::runFileTest):
  9223. (TestShell::dump):
  9224. * DumpRenderTree/chromium/TestShell.h:
  9225. (TestParams):
  9226. (TestParams::TestParams):
  9227. (TestShell):
  9228. * DumpRenderTree/efl/CMakeLists.txt:
  9229. * DumpRenderTree/efl/DumpRenderTree.cpp:
  9230. (parseCommandLineOptions):
  9231. (getFinalTestURL):
  9232. (getExpectedPixelHash):
  9233. (runTest):
  9234. (shouldDumpPixelsAndCompareWithExpected):
  9235. (main):
  9236. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  9237. (initializeGlobalsFromCommandLineOptions):
  9238. (dump):
  9239. (runTest):
  9240. (main):
  9241. * DumpRenderTree/mac/DumpRenderTree.mm:
  9242. (initializeGlobalsFromCommandLineOptions):
  9243. (dumpRenderTree):
  9244. (dump):
  9245. (runTest):
  9246. * DumpRenderTree/qt/DumpRenderTree.pro:
  9247. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  9248. (WebCore::DumpRenderTree::processLine):
  9249. * DumpRenderTree/win/DumpRenderTree.cpp:
  9250. (dump):
  9251. (runTest):
  9252. (dllLauncherEntryPoint):
  9253. * DumpRenderTree/win/DumpRenderTree.vcproj:
  9254. * DumpRenderTree/wscript:
  9255. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  9256. (dump):
  9257. (runTest):
  9258. (MyApp::OnInit):
  9259. * GNUmakefile.am:
  9260. * Scripts/old-run-webkit-tests:
  9261. * Scripts/webkitpy/layout_tests/port/base.py:
  9262. (Port.supports_switching_pixel_tests_per_test):
  9263. (Port):
  9264. (Port._supports_switching_pixel_tests_per_test):
  9265. (Port.should_run_as_pixel_test):
  9266. * Scripts/webkitpy/layout_tests/port/driver.py:
  9267. (Driver.cmd_line):
  9268. (Driver._command_from_driver_input):
  9269. * Scripts/webkitpy/layout_tests/port/qt.py:
  9270. (QtPort._supports_switching_pixel_tests_per_test):
  9271. * Scripts/webkitpy/layout_tests/port/test.py:
  9272. (TestPort.supports_switching_pixel_tests_per_test):
  9273. * WebKitTestRunner/TestController.cpp:
  9274. (WTR::TestController::TestController):
  9275. (WTR::TestController::initialize):
  9276. (WTR::TestController::runTest):
  9277. * WebKitTestRunner/TestController.h:
  9278. (TestController):
  9279. 2012-08-01 Balazs Kelemen <kbalazs@webkit.org>
  9280. All ports should support per test switching of pixel testing
  9281. https://bugs.webkit.org/show_bug.cgi?id=92398
  9282. Reviewed by Dirk Pranke.
  9283. Teach all test drivers to accept a per test control of whether
  9284. to dump pixels. Drivers now accept a -p/--pixel-test argument
  9285. on the standart input that means that running the current
  9286. test as pixel test is allowed (even if the expected hash is
  9287. missing). Removed the --pixel-tests command line option since
  9288. there is no need for it anymore.
  9289. * DumpRenderTree/DumpRenderTree.gypi:
  9290. * DumpRenderTree/DumpRenderTree.h:
  9291. (TestCommand::TestCommand):
  9292. (TestCommand):
  9293. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  9294. * DumpRenderTree/DumpRenderTreeCommon.cpp: Added.
  9295. (CommandTokenizer):
  9296. (CommandTokenizer::CommandTokenizer):
  9297. (CommandTokenizer::pump):
  9298. (CommandTokenizer::next):
  9299. (CommandTokenizer::hasNext):
  9300. (die):
  9301. (parseInputLine):
  9302. Common logic to parse the input line from the standard input (or from the command line
  9303. in standalone mode). Made it somewhat general so we can easily add more arguments if
  9304. there is a need.
  9305. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  9306. (runTest):
  9307. (main):
  9308. * DumpRenderTree/chromium/TestShell.cpp:
  9309. (TestShell::TestShell):
  9310. (TestShell::runFileTest):
  9311. (TestShell::dump):
  9312. * DumpRenderTree/chromium/TestShell.h:
  9313. (TestParams::TestParams):
  9314. (TestShell):
  9315. * DumpRenderTree/efl/CMakeLists.txt:
  9316. * DumpRenderTree/efl/DumpRenderTree.cpp:
  9317. (parseCommandLineOptions):
  9318. (runTest):
  9319. (shouldDumpPixelsAndCompareWithExpected):
  9320. (main):
  9321. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  9322. (initializeGlobalsFromCommandLineOptions):
  9323. (dump):
  9324. * DumpRenderTree/mac/DumpRenderTree.mm:
  9325. (initializeGlobalsFromCommandLineOptions):
  9326. (dumpRenderTree):
  9327. * DumpRenderTree/qt/DumpRenderTree.pro:
  9328. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  9329. (WebCore::DumpRenderTree::processLine):
  9330. * DumpRenderTree/win/DumpRenderTree.cpp:
  9331. (dump):
  9332. (runTest):
  9333. (dllLauncherEntryPoint):
  9334. * DumpRenderTree/win/DumpRenderTree.vcproj:
  9335. * DumpRenderTree/wscript:
  9336. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  9337. (dump):
  9338. (runTest):
  9339. (MyApp::OnInit):
  9340. * Scripts/old-run-webkit-tests: Pass --pixel-test before the hash.
  9341. Changed the separator form ' to : because it don't need to be escaped
  9342. when passing manually on the comand line.
  9343. * Scripts/webkitpy/layout_tests/port/base.py:
  9344. (Port.should_run_as_pixel_test): Removed now that all ports supports it.
  9345. * Scripts/webkitpy/layout_tests/port/driver.py:
  9346. (Driver.cmd_line): Don't pass --pixel-tests anymore.
  9347. (Driver._command_from_driver_input):
  9348. * WebKitTestRunner/TestController.cpp:
  9349. (WTR::TestController::TestController):
  9350. (WTR::TestController::initialize):
  9351. (WTR::TestCommand::TestCommand):
  9352. (TestCommand):
  9353. (WTR):
  9354. (CommandTokenizer):
  9355. (WTR::CommandTokenizer::CommandTokenizer):
  9356. (WTR::CommandTokenizer::pump):
  9357. (WTR::CommandTokenizer::next):
  9358. (WTR::CommandTokenizer::hasNext):
  9359. (WTR::die):
  9360. (WTR::parseInputLine):
  9361. (WTR::TestController::runTest):
  9362. * WebKitTestRunner/TestController.h:
  9363. (TestController):
  9364. Duplicate the logic for parsing the command line because
  9365. unfortunately there is no way to share code between
  9366. WebKitTestRunner and DumpRenderTree.
  9367. 2012-08-01 Martin Robinson <mrobinson@igalia.com>
  9368. Add the jhbuild source directory to the __builtin__ object
  9369. Reviewed by Philippe Normand.
  9370. It seems that the jhbuild script explicitly looks for the SRCDIR __builtin__ when
  9371. initializing. This is necessary for loading the jhbuild from the checkout directory.
  9372. * jhbuild/jhbuildutils.py:
  9373. (enter_jhbuild_environment_if_available): Set SRCDIR to the source directory.
  9374. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9375. nrwt: move actual test-running code into layout_test_runner.py
  9376. https://bugs.webkit.org/show_bug.cgi?id=92806
  9377. Reviewed by Ryosuke Niwa.
  9378. This is the final patch in manager-refactoring series (for now).
  9379. This moves all of the logic to actually run the tests into
  9380. layout_test_runner (in a new LayoutTestRunner) class. Now
  9381. the mechanics of actually executing all of the tests are
  9382. contained in one file (of course the actual work of talking to
  9383. DRT/WTR and diff'ing the results is still in single_test_runner).
  9384. Now manager is left with setting up and tearing down the test
  9385. environment, finding the tests to run, and processing the
  9386. results of the tests, which is a pretty managable amount of code
  9387. (no pun intended).
  9388. The unit tests for manager were split in two and all of the
  9389. runner-specific tests moved into layout_test_runner_unittest.
  9390. They were significantly cleaned up to be easier to read and
  9391. maintain as a part of this.
  9392. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  9393. (TestRunInterruptedException):
  9394. (TestRunInterruptedException.__init__):
  9395. (TestRunInterruptedException.__reduce__):
  9396. (LayoutTestRunner):
  9397. (LayoutTestRunner.__init__):
  9398. (LayoutTestRunner.test_key):
  9399. (LayoutTestRunner.run_tests):
  9400. (LayoutTestRunner.run_tests.worker_factory):
  9401. (LayoutTestRunner.run_tests.instead):
  9402. (LayoutTestRunner._mark_interrupted_tests_as_skipped):
  9403. (LayoutTestRunner._interrupt_if_at_failure_limits):
  9404. (LayoutTestRunner._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
  9405. (LayoutTestRunner._update_summary_with_result):
  9406. (LayoutTestRunner.start_servers_with_lock):
  9407. (LayoutTestRunner.stop_servers_with_lock):
  9408. (LayoutTestRunner.handle):
  9409. (LayoutTestRunner._handle_started_test):
  9410. (LayoutTestRunner._handle_finished_test_list):
  9411. (LayoutTestRunner._handle_finished_test_list.find):
  9412. (LayoutTestRunner._handle_finished_test):
  9413. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
  9414. (FakePrinter):
  9415. (FakePrinter.print_workers_and_shards):
  9416. (FakePrinter.print_finished_test):
  9417. (FakePrinter.write):
  9418. (FakePrinter.write_update):
  9419. (FakePrinter.flush):
  9420. (LockCheckingRunner):
  9421. (LockCheckingRunner.__init__):
  9422. (LockCheckingRunner.handle_finished_list):
  9423. (LayoutTestRunnerTests):
  9424. (LayoutTestRunnerTests._runner):
  9425. (LayoutTestRunnerTests._result_summary):
  9426. (LayoutTestRunnerTests._run_tests):
  9427. (LayoutTestRunnerTests.test_http_locking):
  9428. (LayoutTestRunnerTests.test_perf_locking):
  9429. (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
  9430. (LayoutTestRunnerTests.test_update_summary_with_result):
  9431. (LayoutTestRunnerTests.test_servers_started):
  9432. (LayoutTestRunnerTests.test_servers_started.start_http_server):
  9433. (LayoutTestRunnerTests.test_servers_started.start_websocket_server):
  9434. (LayoutTestRunnerTests.test_servers_started.stop_http_server):
  9435. (LayoutTestRunnerTests.test_servers_started.stop_websocket_server):
  9436. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9437. (summarize_results):
  9438. (Manager.__init__):
  9439. (Manager._is_http_test):
  9440. (Manager):
  9441. (Manager._is_websocket_test):
  9442. (Manager._websocket_tests):
  9443. (Manager._prepare_lists):
  9444. (Manager._is_ref_test):
  9445. (Manager.run):
  9446. (Manager._run_tests):
  9447. (Manager._look_for_new_crash_logs):
  9448. (Manager._show_results_html_file):
  9449. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  9450. (ManagerTest.test_look_for_new_crash_logs):
  9451. (ResultSummaryTest.summarized_results):
  9452. (ResultSummaryTest.test_summarized_results_wontfix):
  9453. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9454. nrwt: move sharding logic into layout_test_runner.py
  9455. https://bugs.webkit.org/show_bug.cgi?id=92805
  9456. Reviewed by Ryosuke Niwa.
  9457. The sharding logic is specific to how we actually run the tests,
  9458. so it belongs in this file instead of manager.py or finder.py.
  9459. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  9460. (Worker._run_single_test):
  9461. (TestShard):
  9462. (TestShard.__init__):
  9463. (TestShard.__repr__):
  9464. (TestShard.__eq__):
  9465. (Sharder):
  9466. (Sharder.__init__):
  9467. (Sharder.shard_tests):
  9468. (Sharder.shard_tests.or):
  9469. (Sharder._shard_in_two):
  9470. (Sharder._shard_every_file):
  9471. (Sharder._shard_by_directory):
  9472. (Sharder._resize_shards):
  9473. (Sharder._resize_shards.divide_and_round_up):
  9474. (Sharder._resize_shards.extract_and_flatten):
  9475. (Sharder._resize_shards.split_at):
  9476. (Sharder._dir_for_test_input):
  9477. (Sharder.test_key):
  9478. (Sharder.natural_sort_key):
  9479. (Sharder.natural_sort_key.tryint):
  9480. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Added.
  9481. (SharderTests):
  9482. (SharderTests.get_test_input):
  9483. (SharderTests.get_shards):
  9484. (SharderTests.get_shards.split):
  9485. (SharderTests.assert_shards):
  9486. (SharderTests.test_shard_by_dir):
  9487. (SharderTests.test_shard_by_dir_sharding_ref_tests):
  9488. (SharderTests.test_shard_every_file):
  9489. (SharderTests.test_shard_in_two):
  9490. (SharderTests.test_shard_in_two_sharding_ref_tests):
  9491. (SharderTests.test_shard_in_two_has_no_locked_shards):
  9492. (SharderTests.test_shard_in_two_has_no_unlocked_shards):
  9493. (SharderTests.test_multiple_locked_shards):
  9494. (NaturalCompareTest):
  9495. (NaturalCompareTest.assert_cmp):
  9496. (NaturalCompareTest.test_natural_compare):
  9497. (KeyCompareTest):
  9498. (KeyCompareTest.setUp):
  9499. (KeyCompareTest.setUp.split):
  9500. (KeyCompareTest.assert_cmp):
  9501. (KeyCompareTest.test_test_key):
  9502. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9503. (Manager.__init__):
  9504. (Manager._prepare_lists):
  9505. (Manager._is_ref_test):
  9506. (Manager._run_tests):
  9507. (Manager._handle_finished_test):
  9508. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  9509. (ManagerTest.get_options):
  9510. (ManagerTest.test_interrupt_if_at_failure_limits):
  9511. (ManagerTest.test_update_summary_with_result):
  9512. (ManagerTest.test_needs_servers.get_manager_with_tests):
  9513. (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
  9514. (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
  9515. (ManagerTest.test_servers_started):
  9516. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  9517. (parse_args):
  9518. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9519. nrwt: rename worker.py to layout_test_runner.py
  9520. https://bugs.webkit.org/show_bug.cgi?id=92804
  9521. Reviewed by Ojan Vafai.
  9522. Home stretch of this round of manager refactoring ... I will be
  9523. moving all of the actual test-running code (which includes the
  9524. code that shards the tests for the workers) into a different
  9525. module, and it makes sense for that module to contain the actual
  9526. worker code, so I'm renaming worker.py to layout_test_runner.py.
  9527. * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/worker.py.
  9528. (Worker):
  9529. (Worker.__init__):
  9530. (Worker.__del__):
  9531. (Worker.start):
  9532. (Worker.handle):
  9533. (Worker._update_test_input):
  9534. (Worker._run_test):
  9535. (Worker.stop):
  9536. (Worker._timeout):
  9537. (Worker._kill_driver):
  9538. (Worker._run_test_with_timeout):
  9539. (Worker._clean_up_after_test):
  9540. (Worker._run_test_in_another_thread):
  9541. (Worker._run_test_in_another_thread.SingleTestThread):
  9542. (Worker._run_test_in_another_thread.SingleTestThread.__init__):
  9543. (Worker._run_test_in_another_thread.SingleTestThread.run):
  9544. (Worker._run_test_in_this_thread):
  9545. (Worker._run_single_test):
  9546. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9547. (Manager._run_tests.worker_factory):
  9548. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9549. nrwt: clean up names in sharding code
  9550. https://bugs.webkit.org/show_bug.cgi?id=92785
  9551. Reviewed by Ryosuke Niwa.
  9552. More refactoring ... this makes the methods use TestInputs
  9553. consistently (and updates the names accordingly) and improves
  9554. encapsulation a bit. The sharding code is now pretty
  9555. self-contained.
  9556. This change adds no new functionality and is covered by the
  9557. existing (updated) tests.
  9558. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9559. (TestShard.visible.__init__):
  9560. (TestShard.visible.__repr__):
  9561. (Manager._dir_for_test_input):
  9562. (Manager._shard_tests):
  9563. (Manager._shard_in_two):
  9564. (Manager._shard_every_file):
  9565. (Manager._shard_by_directory):
  9566. (Manager._run_tests):
  9567. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  9568. (ManagerWrapper._test_input_for_file):
  9569. (ShardingTests.get_shards):
  9570. * Scripts/webkitpy/layout_tests/models/test_input.py:
  9571. (TestInput.__init__):
  9572. (TestInput.__repr__):
  9573. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9574. nrwt: clean up TestInputs in preparation for cleaning up sharding
  9575. https://bugs.webkit.org/show_bug.cgi?id=92784
  9576. Reviewed by Ryosuke Niwa.
  9577. Currently, in order to shard the tests you need to refer to
  9578. state in the manager as well as the state in the TestInputs;
  9579. this change embeds the necessary state into the TestInputs so
  9580. sharding them can be a standalone operation.
  9581. The actual clean up of the sharding will follow in a subsequent patch.
  9582. Covered by existing tests; no new functionality. However, I did
  9583. rework the sharding tests to be less dependent on the test
  9584. scaffolding and easier to follow.
  9585. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9586. (Manager._test_input_for_file):
  9587. (Manager._shard_in_two):
  9588. (Manager._shard_every_file):
  9589. (Manager._shard_by_directory):
  9590. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  9591. (ManagerWrapper._test_input_for_file):
  9592. (ShardingTests.assert_shards):
  9593. (ShardingTests.test_shard_by_dir):
  9594. (ShardingTests.test_shard_by_dir_sharding_ref_tests):
  9595. (ShardingTests.test_shard_every_file):
  9596. (ShardingTests.test_shard_in_two):
  9597. (ShardingTests.test_shard_in_two_sharding_ref_tests):
  9598. (ShardingTests.test_shard_in_two_has_no_unlocked_shards):
  9599. (ShardingTests.test_multiple_locked_shards):
  9600. * Scripts/webkitpy/layout_tests/models/test_input.py:
  9601. (TestInput.__init__):
  9602. (TestInput.__repr__):
  9603. 2012-07-31 Thiago Marcos P. Santos <thiago.santos@intel.com>
  9604. [EFL] Dump a backtrace in case of a crash
  9605. https://bugs.webkit.org/show_bug.cgi?id=92489
  9606. Reviewed by Csaba Osztrogonác.
  9607. Dump a stack trace in case of a unexpected signal. This should
  9608. provide a better report at the build bots when WTR crashes.
  9609. * DumpRenderTree/efl/DumpRenderTree.cpp:
  9610. (main):
  9611. * TestWebKitAPI/efl/InjectedBundleController.cpp:
  9612. (TestWebKitAPI::InjectedBundleController::platformInitialize):
  9613. * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp:
  9614. (WTR::InjectedBundle::platformInitialize):
  9615. 2012-07-31 Joshua Netterfield <jnetterfield@rim.com>
  9616. [BlackBerry] Enable CSS Filter Effects
  9617. https://bugs.webkit.org/show_bug.cgi?id=92685
  9618. Reviewed by Rob Buis.
  9619. Enable CSS filter effects, with the exception of custom effects (CSS shaders) and reference effects (SVG effects)
  9620. Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.
  9621. * Scripts/webkitperl/FeatureList.pm: Acknowledge CSS filter effects.
  9622. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9623. nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
  9624. https://bugs.webkit.org/show_bug.cgi?id=92781
  9625. Reviewed by Ryosuke Niwa.
  9626. More refactoring ... rename prepare_lists_and_print_output to
  9627. just prepare_lists so that it only has a single purpose, and
  9628. clean up the surrounding code a bit as well.
  9629. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9630. (Manager._collect_tests):
  9631. (Manager._prepare_lists):
  9632. (Manager._set_up_run):
  9633. (Manager.run):
  9634. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9635. nrwt: clean up self._test_files_list vs. self._test_files, other nits
  9636. https://bugs.webkit.org/show_bug.cgi?id=92702
  9637. Reviewed by Ojan Vafai.
  9638. Get rid of self._test_files, rename self._test_files_list to
  9639. self._test_names (removing the confusion between the two fields).
  9640. Also inline the one call to _parse_expectations, remove the one
  9641. use of more_tests_to_skip, and fix a couple of minor nits.
  9642. * Scripts/webkitpy/layout_tests/controllers/finder.py:
  9643. (LayoutTestFinder.split_into_chunks):
  9644. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9645. (Manager.__init__):
  9646. (Manager._collect_tests):
  9647. (Manager._http_tests):
  9648. (Manager._websocket_tests):
  9649. (Manager._is_perf_test):
  9650. (Manager.prepare_lists_and_print_output):
  9651. (Manager.needs_servers):
  9652. (Manager.run):
  9653. (Manager._mark_interrupted_tests_as_skipped):
  9654. (Manager._update_summary_with_result):
  9655. (Manager._upload_json_files):
  9656. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  9657. (ManagerTest.test_interrupt_if_at_failure_limits):
  9658. (ManagerTest.test_needs_servers.get_manager_with_tests):
  9659. (ManagerTest.test_servers_started):
  9660. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9661. nrwt: --verbose logging does not work right on windows
  9662. https://bugs.webkit.org/show_bug.cgi?id=92673
  9663. Reviewed by Ojan Vafai.
  9664. Add a test for r124090.
  9665. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  9666. (MainTest.test_verbose):
  9667. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9668. REGRESSION(124116): Number of skipped tests isn't printed anymore
  9669. https://bugs.webkit.org/show_bug.cgi?id=92736
  9670. Reviewed by Tony Chang.
  9671. Add the skipped number back in; it was useful ... also clean up
  9672. the formatting a little bit.
  9673. * Scripts/webkitpy/layout_tests/views/printing.py:
  9674. (Printer.print_found):
  9675. 2012-07-31 Hans Wennborg <hans@chromium.org>
  9676. Speech JavaScript API: Throw exception for start() when already started
  9677. https://bugs.webkit.org/show_bug.cgi?id=92756
  9678. Reviewed by Adam Barth.
  9679. Fix the task queue in MockWebSpeechRecognizer.
  9680. It's important that we remove the task from the queue before we run
  9681. it, as running the task could alter the queue's state.
  9682. * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
  9683. (MockWebSpeechRecognizer::abort):
  9684. (MockWebSpeechRecognizer::setError):
  9685. (MockWebSpeechRecognizer::clearTaskQueue):
  9686. (MockWebSpeechRecognizer::StepTask::runIfValid):
  9687. * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
  9688. (MockWebSpeechRecognizer):
  9689. 2012-07-31 Dirk Pranke <dpranke@chromium.org>
  9690. nrwt: move handling the initial list of tests to skip to finder
  9691. https://bugs.webkit.org/show_bug.cgi?id=92701
  9692. Reviewed by Ryosuke Niwa.
  9693. More refactoring of manager ...
  9694. * Scripts/webkitpy/layout_tests/controllers/finder.py:
  9695. (LayoutTestFinder.skip_tests):
  9696. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9697. (Manager._collect_tests):
  9698. (Manager.prepare_lists_and_print_output):
  9699. 2012-07-31 Alexey Proskuryakov <ap@apple.com>
  9700. [WK2] Kill the concept of secondary shared process
  9701. https://bugs.webkit.org/show_bug.cgi?id=92676
  9702. Reviewed by Sam Weinig.
  9703. * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Update Windows build fix.
  9704. Don't create a new context for every view.
  9705. 2012-07-31 Peter Beverloo <peter@chromium.org>
  9706. [Chromium] Don't use ninja for building Chromium for Android
  9707. https://bugs.webkit.org/show_bug.cgi?id=92764
  9708. Reviewed by Adam Barth.
  9709. When Ninja projects files are generated (which will be done for Android),
  9710. make sure that the Android builder doesn't unintentionally switch to
  9711. using Ninja. We should make that switch at a predetermined time.
  9712. * Scripts/webkitdirs.pm:
  9713. (buildChromium):
  9714. 2012-07-31 Thiago Marcos P. Santos <thiago.santos@intel.com>
  9715. Add a mechanism to dump the stack trace in case of a crash
  9716. https://bugs.webkit.org/show_bug.cgi?id=92666
  9717. Reviewed by Csaba Osztrogonác.
  9718. Move crash signal handlers to WTFInstallReportBacktraceOnCrashHook()
  9719. and eliminate some duplicated code.
  9720. * DumpRenderTree/qt/main.cpp:
  9721. (main):
  9722. * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
  9723. (WTR::InjectedBundle::platformInitialize):
  9724. 2012-07-31 Jochen Eisinger <jochen@chromium.org>
  9725. [chromium] move EventSender into TestRunner.a
  9726. https://bugs.webkit.org/show_bug.cgi?id=92277
  9727. Reviewed by Adam Barth.
  9728. * DumpRenderTree/DumpRenderTree.gypi:
  9729. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  9730. * DumpRenderTree/chromium/TestRunner/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/EventSender.cpp.
  9731. * DumpRenderTree/chromium/TestRunner/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/EventSender.h.
  9732. * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
  9733. (TestInterfaces::Internal::eventSender):
  9734. (TestInterfaces::Internal):
  9735. (TestInterfaces::Internal::Internal):
  9736. (TestInterfaces::Internal::~Internal):
  9737. (TestInterfaces::Internal::setWebView):
  9738. (TestInterfaces::Internal::setDelegate):
  9739. (TestInterfaces::Internal::bindTo):
  9740. (TestInterfaces::Internal::resetAll):
  9741. (TestInterfaces::eventSender):
  9742. * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
  9743. (TestInterfaces):
  9744. * DumpRenderTree/chromium/TestShell.cpp:
  9745. (TestShell::initialize):
  9746. (TestShell::createMainWindow):
  9747. (TestShell::~TestShell):
  9748. (TestShell::resetTestController):
  9749. (TestShell::bindJSObjectsToWindow):
  9750. * DumpRenderTree/chromium/TestShell.h:
  9751. (TestShell::eventSender):
  9752. (TestShell):
  9753. * DumpRenderTree/chromium/WebViewHost.cpp:
  9754. 2012-07-31 Jochen Eisinger <jochen@chromium.org>
  9755. Unreviewed. Update watchlist
  9756. * Scripts/webkitpy/common/config/watchlist: Turned out to be less useful than I had hoped
  9757. 2012-07-31 Kent Tamura <tkent@chromium.org>
  9758. Unreviewed, update watchlist
  9759. * Scripts/webkitpy/common/config/watchlist:
  9760. - Improve "Forms" filename pattern.
  9761. - tkent stops watching Chromium DRT. It was not so helpful.
  9762. 2012-07-31 Martin Robinson <mrobinson@igalia.com>
  9763. [jhbuild] Also try to load jhbuild Python module from the source checkout
  9764. Reviewed by Philippe Normand.
  9765. JHBuild also seems to have an installation mode where it prefers to load its
  9766. Python modules from the source checkout. This seems to be used particularly
  9767. on the GTK+ 64-bit release bot. We should fall back to this mode.
  9768. * jhbuild/jhbuildutils.py:
  9769. (enter_jhbuild_environment_if_available): Use the source checkout if there
  9770. is no installation path.
  9771. 2012-07-30 Ryosuke Niwa <rniwa@webkit.org>
  9772. Revert r124153 and land the "right" build fix per ap's comment on the bug 92676.
  9773. * MiniBrowser/win/BrowserView.cpp:
  9774. (BrowserView::create):
  9775. 2012-07-30 Sam Weinig <sam@webkit.org>
  9776. Rename WebKit2.h to WebKit2_C.h
  9777. https://bugs.webkit.org/show_bug.cgi?id=92704
  9778. Reviewed by Dan Bernstein.
  9779. * MiniBrowser/mac/MiniBrowser_Prefix.pch:
  9780. * MiniBrowser/win/BrowserView.h:
  9781. * TestWebKitAPI/config.h:
  9782. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  9783. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  9784. * WebKitTestRunner/WebKitTestRunnerPrefix.h:
  9785. * WebKitTestRunner/config.h:
  9786. Update for changed header file name.
  9787. 2012-07-30 Dirk Pranke <dpranke@chromium.org>
  9788. chromium win compile broken after removing webkit.py
  9789. https://bugs.webkit.org/show_bug.cgi?id=92549
  9790. Reviewed by Ryosuke Niwa.
  9791. Remove the stub file for webkit.py now that it's no longer
  9792. necessary.
  9793. * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
  9794. 2012-07-30 Ryosuke Niwa <rniwa@webkit.org>
  9795. Windows build fix attempt after r124092.
  9796. * MiniBrowser/win/BrowserView.cpp:
  9797. (BrowserView::create):
  9798. 2012-07-30 Ryosuke Niwa <rniwa@webkit.org>
  9799. Remove erroneously committed debugging print call from a test.
  9800. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  9801. (test_run_generates_results_page):
  9802. 2012-07-30 Arnaud Renevier <a.renevier@sisa.samsung.com>
  9803. webkit-patch: system keyring is not used to read my password
  9804. https://bugs.webkit.org/show_bug.cgi?id=92532
  9805. Reviewed by Dirk Pranke.
  9806. In case no username can be fetched from environment, git or keychain,
  9807. prompt for username, and try to get password from keyring associated
  9808. with that username.
  9809. * Scripts/webkitpy/common/net/credentials.py:
  9810. (Credentials.read_credentials):
  9811. * Scripts/webkitpy/common/net/credentials_unittest.py:
  9812. (test_keyring_without_git_repo_nor_keychain):
  9813. (test_keyring_without_git_repo_nor_keychain.MockKeyring):
  9814. (test_keyring_without_git_repo_nor_keychain.MockKeyring.get_password):
  9815. (test_keyring_without_git_repo_nor_keychain.FakeCredentials):
  9816. (test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_keychain):
  9817. (test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_environment):
  9818. (test_keyring_without_git_repo_nor_keychain.FakeUser):
  9819. (test_keyring_without_git_repo_nor_keychain.FakeUser.prompt):
  9820. (test_keyring_without_git_repo_nor_keychain.FakeUser.prompt_password):
  9821. 2012-07-30 Dirk Pranke <dpranke@chromium.org>
  9822. nrwt: move the code that identifies the chunk of tests to run into finder
  9823. https://bugs.webkit.org/show_bug.cgi?id=92694
  9824. Reviewed by Ryosuke Niwa.
  9825. Another patch to make manager.py smaller and clearer; this patch moves
  9826. the handling of breaking the list of tests into chunks (--run-part,
  9827. --run-chunk) from manager.py to finder.py.
  9828. There are no functional changes and this is covered by existing tests.
  9829. * Scripts/webkitpy/layout_tests/controllers/finder.py:
  9830. (Finder.__init__):
  9831. (Finder._read_test_files):
  9832. (Finder):
  9833. (Finder.split_into_chunks_if_necessary):
  9834. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9835. (Manager.__init__):
  9836. (Manager._collect_tests):
  9837. (Manager._parse_expectations):
  9838. (Manager.prepare_lists_and_print_output):
  9839. 2012-07-30 Dirk Pranke <dpranke@chromium.org>
  9840. nrwt: split test-finding code out from manager.py
  9841. https://bugs.webkit.org/show_bug.cgi?id=92693
  9842. Reviewed by Ryosuke Niwa.
  9843. In the interest of making manager.py smaller, this patch moves
  9844. the code that actually takes the command line arguments and
  9845. --test-file lists of tests to run and expands them into an
  9846. actual list of tests out into a separate module.
  9847. * Scripts/webkitpy/layout_tests/controllers/finder.py: Added.
  9848. (LayoutTestFinder):
  9849. (LayoutTestFinder.__init__):
  9850. (LayoutTestFinder.find_tests):
  9851. (LayoutTestFinder._strip_test_dir_prefixes):
  9852. (LayoutTestFinder._strip_test_dir_prefix):
  9853. (LayoutTestFinder._read_test_names_from_file):
  9854. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9855. (Manager._collect_tests):
  9856. (Manager._handle_finished_test):
  9857. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  9858. (strip_comments):
  9859. 2012-07-30 Adam Barth <abarth@webkit.org>
  9860. commit-queue is corrupting ChangeLogs
  9861. https://bugs.webkit.org/show_bug.cgi?id=92681
  9862. Reviewed by Tony Chang.
  9863. Some commits made with the commit-queue are ending up with duplicate
  9864. ChangeLog entries. I've hot-patched the servers to not use a special
  9865. merge driver for ChangeLogs, which should fix this issue. This patch
  9866. removes the merge driver from our cold-boot.sh script so that we won't
  9867. use it on new commit-queue instances.
  9868. * EWSTools/cold-boot.sh:
  9869. 2012-07-28 Sam Weinig <sam@webkit.org>
  9870. Add ability to load from a string to the ObjC WK API
  9871. https://bugs.webkit.org/show_bug.cgi?id=92590
  9872. Reviewed by Dan Bernstein.
  9873. Add tests for [WKBrowsingContextController loadHTMLString:baseURL:]. We will be able
  9874. to greatly improve these tests (to test more than just not crashing) when methods to
  9875. access page content are added (soon!).
  9876. Adds:
  9877. Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString
  9878. Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilBaseURL
  9879. Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL
  9880. * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
  9881. Adds tests and refactors delegates to not use global state.
  9882. 2012-07-30 Thiago Marcos P. Santos <thiago.santos@intel.com>
  9883. [CMake] TestWebKitAPI bundle should link with WTF
  9884. https://bugs.webkit.org/show_bug.cgi?id=92616
  9885. Reviewed by Antonio Gomes.
  9886. Fixes build when shared core is disabled.
  9887. * TestWebKitAPI/CMakeLists.txt:
  9888. 2012-07-30 Dirk Pranke <dpranke@chromium.org>
  9889. nrwt: clean up handling of 'expected' stats
  9890. https://bugs.webkit.org/show_bug.cgi?id=92527
  9891. Reviewed by Tony Chang.
  9892. This patch alters the way we compute and log the "expected"
  9893. results and how we treat skipped tests; we will now log the
  9894. number of skipped tests separately from the categories, e.g.:
  9895. Found 31607 tests; running 24464.
  9896. Expect: 23496 passes (23496 now, 0 wontfix)
  9897. Expect: 548 failures ( 543 now, 5 wontfix)
  9898. Expect: 420 flaky ( 245 now, 175 wontfix)
  9899. (so that the "expect" totals add up to the "running" totals);
  9900. in addition, the totals in the one-line-progress reflect the
  9901. number of tests we will actually run. If --iterations or
  9902. --repeat-each are specified, the number of tests we run are
  9903. multiplied as appropriate, but the "expect" numbers are
  9904. unchanged, since we don't count multiple invocations of the same
  9905. test multiple times. In addition, if we are using --run-part or
  9906. --run-chunk, the tests we don't run are treated as skipped
  9907. for consistency. We will also log the values for --iterations
  9908. and --repeat each as part of the found/running line.
  9909. Previously the code had parsed and re-parsed the
  9910. TestExpectations files several times in an attempt to come up
  9911. with some sane statistics, but this was expensive and lead to
  9912. confusing layer; treating files as skipped in the way described
  9913. above is more consistent and cleaner.
  9914. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9915. (Manager._split_into_chunks_if_necessary):
  9916. (Manager.prepare_lists_and_print_output):
  9917. (Manager.run):
  9918. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  9919. (ManagerTest.test_interrupt_if_at_failure_limits):
  9920. (ManagerTest.test_update_summary_with_result):
  9921. (ManagerTest.test_look_for_new_crash_logs):
  9922. (ResultSummaryTest.get_result_summary):
  9923. * Scripts/webkitpy/layout_tests/models/result_summary.py:
  9924. (ResultSummary.__init__):
  9925. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  9926. (TestExpectationParser.expectation_for_skipped_test):
  9927. (TestExpectations.__init__):
  9928. (TestExpectations.add_skipped_tests):
  9929. Here we make add_skipped_tests() public, so that we can update
  9930. the expectations for tests that we are skipping due to
  9931. --run-part or --run-chunk; we use the wontfix flag so that
  9932. the tests that are intentionally skipped aren't considered
  9933. "fixable".
  9934. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  9935. (SkippedTests.check):
  9936. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  9937. (parse_args):
  9938. * Scripts/webkitpy/layout_tests/views/printing.py:
  9939. (Printer.print_found):
  9940. (Printer):
  9941. (Printer.print_expected):
  9942. (Printer._print_result_summary):
  9943. (Printer._print_result_summary_entry):
  9944. Here we split out printing the number of tests found and run
  9945. from the expected results, to be clearer and so that we don't
  9946. have to reparse the expectations to update the stats.
  9947. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  9948. (Testprinter.get_result_summary):
  9949. 2012-07-30 Sadrul Habib Chowdhury <sadrul@chromium.org>
  9950. Propagate gesture events to plugins.
  9951. https://bugs.webkit.org/show_bug.cgi?id=92281
  9952. Reviewed by Adam Barth.
  9953. Update TestWebPlugin to receive events, and output logs for the events.
  9954. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  9955. (TestWebPlugin::handleInputEvent):
  9956. * DumpRenderTree/chromium/TestWebPlugin.h:
  9957. (TestWebPlugin::acceptsInputEvents):
  9958. (TestWebPlugin):
  9959. 2012-07-30 Raphael Kubo da Costa <rakuco@webkit.org>
  9960. [jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0
  9961. https://bugs.webkit.org/show_bug.cgi?id=90643
  9962. Reviewed by Gustavo Noronha Silva.
  9963. The 2.x series of gnutls has a version of Gnulib that is
  9964. incompatible with glibc 2.16.0, which now does not define gets()
  9965. by default.
  9966. After talking to kov, mrobinson and philn, it looks like it makes
  9967. sense to simply remove gnutls from jhbuild.modules and rely on the
  9968. version installed on the system being recent enough.
  9969. This means at least version 2.12.8 for PKCS11 support, or at the
  9970. very least 2.11.0 (these are the minimum versions enforced by
  9971. glib-networking's configure.ac).
  9972. * efl/jhbuild.modules: Do not build gnutls anymore, make
  9973. glib-networking depend on glib instead, and move the libgcrypt
  9974. dependency to eet, which is what currently needs it.
  9975. * gtk/jhbuild.modules: Do not build gnutls anymore.
  9976. 2012-07-30 Dirk Pranke <dpranke@chromium.org>
  9977. nrwt: --verbose logging does not work right on windows
  9978. https://bugs.webkit.org/show_bug.cgi?id=92673
  9979. Unreviewed, build fix.
  9980. The --verbose log level is not being propagated to the worker
  9981. processes on windows properly; this has been broken ever since I
  9982. refactored logging into the message pool directly :(.
  9983. Also, fixing this revealed that outputcapture wasn't saving and
  9984. restoring log levels correctly, so I had to fix that as well.
  9985. * Scripts/webkitpy/common/message_pool.py:
  9986. (_MessagePool._start_workers):
  9987. (_MessagePool._worker_log_level):
  9988. (_Worker.__init__):
  9989. (_Worker._set_up_logging):
  9990. (_WorkerLogHandler.__init__):
  9991. * Scripts/webkitpy/common/system/outputcapture.py:
  9992. (OutputCapture.capture_output):
  9993. (OutputCapture.restore_output):
  9994. 2012-07-30 Dirk Pranke <dpranke@chromium.org>
  9995. After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
  9996. https://bugs.webkit.org/show_bug.cgi?id=92664
  9997. Reviewed by Michael Saboff.
  9998. Updated to handle crash_logs being returned as a tuple of (stderr, crash_log).
  9999. * Scripts/webkitpy/layout_tests/port/mac.py:
  10000. (MacPort.look_for_new_crash_logs):
  10001. 2012-07-30 Stephen White <senorblanco@chromium.org>
  10002. Added a SkiaGraphics definition to the watchlist file; cc'ed myself
  10003. to that group. Unreviewed.
  10004. * Scripts/webkitpy/common/config/watchlist:
  10005. 2012-07-30 Sheriff Bot <webkit.review.bot@gmail.com>
  10006. Unreviewed, rolling out r123966 and r123967.
  10007. http://trac.webkit.org/changeset/123966
  10008. http://trac.webkit.org/changeset/123967
  10009. https://bugs.webkit.org/show_bug.cgi?id=92656
  10010. This patch is causing assertion failures on the debug bot
  10011. (also rolling out a dependent patch) (Requested by mrobinson
  10012. on #webkit).
  10013. * gtk/generate-gtkdoc:
  10014. (get_webkit2_options):
  10015. 2012-07-30 Martin Robinson <mrobinson@igalia.com>
  10016. [GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
  10017. https://bugs.webkit.org/show_bug.cgi?id=92626
  10018. Reviewed by Gustavo Noronha Silva.
  10019. Instead of always shelling out to enter a jhbuild environment, add a Python
  10020. hook for entering a jhbuild environment directly. This avoids requiring a
  10021. script to be wrapped in jhbuild.
  10022. * GNUmakefile.am: Remove gtk/run-api-tests from the distribution list.
  10023. * Scripts/run-gtk-tests: Move most of the logic from run-api-tests here
  10024. with additional code for entering a jhbuild environment directly.
  10025. * gtk/run-api-tests: Removed.
  10026. * jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py.
  10027. * jhbuild/jhbuildutils.py: Add some new helper methods here including
  10028. a method which can transform the current environment into a jhbuild-ified one.
  10029. 2012-07-30 Alexander Pavlov <apavlov@chromium.org>
  10030. Unreviewed, upgrade apavlov to reviewer.
  10031. http://lists.webkit.org/mailman/private/webkit-committers/2012-July/000184.html
  10032. * Scripts/webkitpy/common/config/committers.py:
  10033. 2012-07-30 Robin Cao <robin.cao@torchmobile.com.cn>
  10034. [BlackBerry] Adapt to changes in the SharedArray platform API
  10035. https://bugs.webkit.org/show_bug.cgi?id=92631
  10036. Reviewed by Rob Buis.
  10037. Adapt to changes in the SharedArray platform API. No behavioural change.
  10038. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  10039. (LayoutTestController::webHistoryItemCount):
  10040. 2012-07-30 Balazs Kelemen <kbalazs@webkit.org>
  10041. [Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
  10042. https://bugs.webkit.org/show_bug.cgi?id=92627
  10043. Reviewed by Noam Rosenthal.
  10044. Remove the default behavior I added in r123729 so that we run all tests as pixel
  10045. test with -p. It was intentional but it seems like we don't have consensus on
  10046. that we want it.
  10047. * Scripts/webkitpy/layout_tests/port/qt.py:
  10048. (QtPort._supports_switching_pixel_tests_per_test):
  10049. 2012-07-30 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  10050. [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
  10051. https://bugs.webkit.org/show_bug.cgi?id=92366
  10052. Reviewed by Antonio Gomes.
  10053. Add SHIFT modifier for capital letters as VK_
  10054. codes do not distinguish between lows and caps and also to be consistent
  10055. with other ports which send caps as lowercase letters with the shift key down.
  10056. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
  10057. (WTR::EventSenderProxy::keyDown):
  10058. 2012-07-29 Raphael Kubo da Costa <rakuco@webkit.org>
  10059. [EFL][jhbuild] Make run-with-jhbuild become the jhbuild process itself.
  10060. https://bugs.webkit.org/show_bug.cgi?id=92592
  10061. Reviewed by Eric Seidel.
  10062. Adapt to the changes made to GTK+'s run-with-jhbuild in r123979
  10063. and make EFL's run-with-jhbuild call os.execve() instead of
  10064. launching a subprocess as well.
  10065. This should make it possible to interrupt execution of jhbuild
  10066. cleanly.
  10067. * efl/run-with-jhbuild:
  10068. 2012-07-28 Ryosuke Niwa <rniwa@webkit.org>
  10069. run-perf-tests should generate a results page
  10070. https://bugs.webkit.org/show_bug.cgi?id=92575
  10071. Reviewed by Eric Seidel.
  10072. Added the ability to generate a results page that summarizes performance test results from
  10073. multiple runs of run-perf-tests when --output-json-path is specified and --test-results-server
  10074. is not specified. We cannot generate a results page when --test-results-server is specified
  10075. because perf-o-matic cannot parse the new JSON format.
  10076. The new JSON format is simply an array of the old JSON output. This JSON is then merged into
  10077. results-template.html along with jQuery and copied as a HTML file of the same filename as
  10078. the output JSON file with a .html extension.
  10079. We merge all scripts and the JSON output into the results page as opposed to including them
  10080. with the src content attribute to make it standalone so that we may post it on Bugzilla or
  10081. e-mail it to someone else without breaking it.
  10082. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  10083. (PerfTestsRunner.run):
  10084. (PerfTestsRunner._generate_json): Merge "contents" with the existing JSON file when generating
  10085. a results page, and generate the results page from results-template.html merged with jQuery and
  10086. the generated JSON output.
  10087. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  10088. (_test_run_with_json_output): Extracted from test_run_with_upload_json to be shared with
  10089. several test cases.
  10090. (_test_run_with_json_output.mock_upload_json): Ditto.
  10091. (test_run_with_json_output): Refactored to use _test_run_with_json_output.
  10092. (test_run_generates_results_page): Added. Tests the new feature.
  10093. (test_run_with_json_source): Refactored to use _test_run_with_json_output.
  10094. (test_run_with_multiple_repositories): Ditto.
  10095. (test_run_with_upload_json): Ditto.
  10096. 2012-07-29 Rik Cabanier <cabanier@adobe.com>
  10097. Add ENABLE_CSS_COMPOSITING flag
  10098. https://bugs.webkit.org/show_bug.cgi?id=92553
  10099. Reviewed by Dirk Schulze.
  10100. Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
  10101. * Scripts/webkitperl/FeatureList.pm:
  10102. 2012-07-29 Gustavo Noronha Silva <gns@gnome.org>
  10103. Reviewed by Martin Robinson.
  10104. Make the jhbuild wrapper scripts become the jhbuild process
  10105. instead of starting it as a child. This should make it possible to
  10106. interrupt execution of jhbuild cleanly.
  10107. * gtk/run-with-jhbuild:
  10108. * jhbuild/jhbuild-wrapper:
  10109. 2012-07-29 Mike West <mkwst@chromium.org>
  10110. Extend `application/x-webkit-test-netscape` plugins to better support multiple frames.
  10111. https://bugs.webkit.org/show_bug.cgi?id=92478
  10112. Reviewed by Adam Barth.
  10113. DumpRenderTree currently understands
  10114. `<object src="data:application/x-webkit-test-netscape,alertwhenloaded">`.
  10115. It would be useful if it understood `logifloaded`, which could give
  10116. more context regarding test expectations, and can be written in such
  10117. as way as to support plugins loaded into multiple iframes in a single
  10118. test.
  10119. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  10120. (NPP_New):
  10121. Adding support for `logifloaded`.
  10122. 2012-07-28 Peter Kasting <pkasting@google.com>
  10123. Fix Chromium/Win compile.
  10124. https://bugs.webkit.org/show_bug.cgi?id=88787
  10125. Unreviewed, build fix.
  10126. Chromium/Win needs _USE_MATH_DEFINES but doesn't define PLATFORM(WIN).
  10127. The other files in WebKit that define this macro (both in
  10128. WebCore/platform/graphics/cg) do it by unconditionally #defining it to 1
  10129. above the #include of "config.h", so copy that pattern here.
  10130. * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
  10131. 2012-07-28 Mario Sanchez Prada <msanchez@igalia.com>
  10132. [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
  10133. https://bugs.webkit.org/show_bug.cgi?id=90268
  10134. Reviewed by Martin Robinson.
  10135. Ignore WebKitTextChecker.* private files for gtk-doc.
  10136. * gtk/generate-gtkdoc:
  10137. (get_webkit2_options):
  10138. 2012-07-28 Philippe Normand <pnormand@igalia.com>
  10139. [GTK] Transparent Media controls timeline and panel
  10140. https://bugs.webkit.org/show_bug.cgi?id=85279
  10141. Reviewed by Martin Robinson.
  10142. * gtk/jhbuild.modules: Provide gnome-themes-standard build
  10143. support, this is necessary so the media controls panel colors are
  10144. properly initialized from the GTK+ theme.
  10145. 2012-07-27 Kihong Kwon <kihong.kwon@samsung.com>
  10146. [EFL] Support for HTML media capture
  10147. https://bugs.webkit.org/show_bug.cgi?id=91842
  10148. Reviewed by Ryosuke Niwa.
  10149. Add HTML media capture feature to the feature list.
  10150. In addition, enable that on the Efl port.
  10151. * Scripts/webkitperl/FeatureList.pm:
  10152. 2012-07-27 Dirk Pranke <dpranke@chromium.org>
  10153. "webkit-patch rebaseline <test>" fails with exit_code 1
  10154. https://bugs.webkit.org/show_bug.cgi?id=91560
  10155. Reviewed by Adam Barth.
  10156. webkit-patch rebaseline-json crashes in an svn checkout if it
  10157. tries to add files and there are no files to add; arguably
  10158. svn.add() should be robust against this, but rebaseline-json
  10159. shouldn't be calling it, either. This patch fixes the latter and
  10160. adds better debugging info to garden-o-matic so we can see what
  10161. caused the crash.
  10162. * Scripts/webkitpy/tool/commands/rebaseline.py:
  10163. (AbstractParallelRebaselineCommand._rebaseline):
  10164. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  10165. (GardeningHTTPRequestHandler.rebaselineall):
  10166. (GardeningHTTPRequestHandler.rebaselineall.error_handler):
  10167. (GardeningHTTPRequestHandler):
  10168. 2012-07-27 Brady Eidson <beidson@apple.com>
  10169. Plugins should not be allowed to override standard properties/attributes in non-standard worlds
  10170. <rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519
  10171. Reviewed by Anders Carlsson.
  10172. Add a test plugin which overrides all properties it is asked about:
  10173. * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.
  10174. (PluginScriptableObjectOverridesAllProperties):
  10175. (PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
  10176. (PluginObject):
  10177. (PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
  10178. (PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
  10179. (PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
  10180. (PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
  10181. (PluginScriptableObjectOverridesAllProperties::NPP_GetValue):
  10182. Expose NPN_MemAlloc to the test plugin:
  10183. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  10184. (PluginTest::NPN_MemAlloc):
  10185. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  10186. (PluginTest):
  10187. * DumpRenderTree/DumpRenderTree.gypi:
  10188. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  10189. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  10190. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  10191. 2012-07-27 Rafael Brandao <rafael.lobo@openbossa.org>
  10192. "webkit-patch upload" should strip colors from patch if necessary
  10193. https://bugs.webkit.org/show_bug.cgi?id=92306
  10194. Reviewed by Adam Barth.
  10195. * Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.
  10196. 2012-07-27 Eric Seidel <eric@webkit.org>
  10197. clean-pending-commit throws exception when encountering Ossy
  10198. https://bugs.webkit.org/show_bug.cgi?id=92534
  10199. Reviewed by Adam Barth.
  10200. Mark a couple strings as unicode so that reviewers with unicode names do not cause
  10201. clean-pending-commit to barf.
  10202. * Scripts/webkitpy/tool/commands/upload.py:
  10203. (CleanPendingCommit._flags_to_clear_on_patch):
  10204. (CleanPendingCommit.execute):
  10205. (AssignToCommitter._assign_bug_to_last_patch_attacher):
  10206. 2012-07-27 Dirk Pranke <dpranke@chromium.org>
  10207. chromium win compile broken after removing webkit.py
  10208. https://bugs.webkit.org/show_bug.cgi?id=92549
  10209. Unreviewed, build fix.
  10210. It turns out that this file is listed in the chromium downstream
  10211. 'browser_tests.isolate' file, and so deleting it broke gyp.
  10212. Adding a stub file back in until we can remove the entry from
  10213. the file.
  10214. * Scripts/webkitpy/layout_tests/port/webkit.py: Added.
  10215. 2012-07-27 Dirk Pranke <dpranke@chromium.org>
  10216. nrwt: remove 'webkit.py' and the 'WebKitPort'
  10217. https://bugs.webkit.org/show_bug.cgi?id=92450
  10218. Reviewed by Ryosuke Niwa.
  10219. This patch finishes the work of merging WebKitPort into Port.
  10220. Now Port is way too big :).
  10221. This is all cutting and pasting; no new functionality and
  10222. no changes in the tests.
  10223. * Scripts/webkitpy/layout_tests/port/apple.py:
  10224. (ApplePort):
  10225. (ApplePort.__init__):
  10226. * Scripts/webkitpy/layout_tests/port/base.py:
  10227. (Port.skipped_layout_tests):
  10228. (Port):
  10229. (Port._port_flag_for_scripts):
  10230. (Port._arguments_for_configuration):
  10231. (Port._run_script):
  10232. (Port._build_driver):
  10233. (Port._build_driver_flags):
  10234. (Port._tests_for_other_platforms):
  10235. (Port._runtime_feature_list):
  10236. (Port.nm_command):
  10237. (Port._modules_to_search_for_symbols):
  10238. (Port._symbols_string):
  10239. (Port._missing_feature_to_skipped_tests):
  10240. (Port._missing_symbol_to_skipped_tests):
  10241. (Port._has_test_in_directories):
  10242. (Port._skipped_tests_for_unsupported_features):
  10243. (Port._wk2_port_name):
  10244. (Port._skipped_file_search_paths):
  10245. * Scripts/webkitpy/layout_tests/port/chromium.py:
  10246. (ChromiumPort):
  10247. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  10248. * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
  10249. (ChromiumPortTestCase.test_check_build):
  10250. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  10251. * Scripts/webkitpy/layout_tests/port/efl.py:
  10252. (EflPort):
  10253. (EflPort.__init__):
  10254. * Scripts/webkitpy/layout_tests/port/gtk.py:
  10255. (GtkPort):
  10256. (GtkPort.setup_environ_for_server):
  10257. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  10258. (TestWebKitPort):
  10259. (TestWebKitPort.__init__):
  10260. (TestWebKitPort.all_test_configurations):
  10261. (TestWebKitPort._symbols_string):
  10262. (TestWebKitPort._tests_for_other_platforms):
  10263. (TestWebKitPort._tests_for_disabled_features):
  10264. (PortTestCase):
  10265. (PortTestCase.test_diff_image):
  10266. (PortTestCase.test_path_to_test_expectations_file):
  10267. (PortTestCase.test_skipped_directories_for_symbols):
  10268. (test_skipped_directories_for_features):
  10269. (test_skipped_directories_for_features_no_matching_tests_in_test_list):
  10270. (test_skipped_tests_for_unsupported_features_empty_test_list):
  10271. (test_skipped_layout_tests):
  10272. (test_skipped_file_search_paths):
  10273. (test_root_option):
  10274. (test_test_expectations):
  10275. (test_build_driver):
  10276. (_assert_config_file_for_platform):
  10277. (test_linux_distro_detection):
  10278. (test_apache_config_file_name_for_platform):
  10279. (test_path_to_apache_config_file):
  10280. * Scripts/webkitpy/layout_tests/port/qt.py:
  10281. (QtPort):
  10282. (QtPort.__init__):
  10283. (QtPort.setup_environ_for_server):
  10284. * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
  10285. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
  10286. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  10287. (get_test_baselines.AllPlatformsPort):
  10288. (get_test_baselines.AllPlatformsPort.__init__):
  10289. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  10290. (get_test_config.TestMacPort):
  10291. 2012-07-27 Christophe Dumez <christophe.dumez@intel.com>
  10292. [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
  10293. https://bugs.webkit.org/show_bug.cgi?id=92228
  10294. Reviewed by Anders Carlsson.
  10295. Implement LayoutTestController.deliverWebIntent() to
  10296. allow test cases to deliver a Web intent and test this
  10297. functionality.
  10298. This functionality is needed by:
  10299. - webintents/web-intents-delivery.html
  10300. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  10301. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  10302. (WTR::LayoutTestController::deliverWebIntent):
  10303. (WTR):
  10304. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  10305. (LayoutTestController):
  10306. 2012-07-27 Jer Noble <jer.noble@apple.com>
  10307. Unreviewed build fix.
  10308. Wrap MSVC-specific fixes is a COMPILER() check, not a PLATFORM() check.
  10309. * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
  10310. 2012-07-27 Xianzhu Wang <wangxianzhu@chromium.org>
  10311. [Chromium-Android] NRWT better handling of DRT deadlocks and crashes
  10312. https://bugs.webkit.org/show_bug.cgi?id=92299
  10313. Reviewed by Dirk Pranke.
  10314. 1. Changed the deadlock detector thread target from a method of driver to a function to avoid its reference to the
  10315. current driver (see the bug for the problem of the reference.
  10316. 2. Let the deadlock detector thread exit early when the normal_startup_event is set to avoid it from blocking the main thread when the main thread is exiting.
  10317. 3. Extracted common loop until timeout logic into ChromiumAndroidDriver._loop_with_timeout().
  10318. 4. Use the "for i in range(n)" style suggested by dpranke in https://bugs.webkit.org/show_bug.cgi?id=89124 in several functions.
  10319. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  10320. (ChromiumAndroidPort.__init__):
  10321. (ChromiumAndroidPort._run_adb_command): Reduced the verbose output.
  10322. (ChromiumAndroidDriver.__init__):
  10323. (ChromiumAndroidDriver._loop_with_timeout): Extracted common loop until timeout logic here.
  10324. (ChromiumAndroidDriver._all_pipes_created):
  10325. (ChromiumAndroidDriver._remove_all_pipes):
  10326. (ChromiumAndroidDriver._start): Changed the retry loop style.
  10327. (ChromiumAndroidDriver._start_once): Changed the loop style and code related to deadlock detector.
  10328. (ChromiumAndroidDriver._start_once.deadlock_detector): Moved the original ChromiumAndroidDriver._deadlock_detector() here.
  10329. (ChromiumAndroidDriver.stop): Changed the loop style.
  10330. 2012-07-27 Dirk Pranke <dpranke@chromium.org>
  10331. nrwt: move collect_tests(), parse_expectations() into manager
  10332. https://bugs.webkit.org/show_bug.cgi?id=92423
  10333. Reviewed by Ojan Vafai.
  10334. This is the first in a series of patches refactoring
  10335. run_webkit_tests.py and manager.py to make them more
  10336. maintainable; all this patch does is move a couple of functions
  10337. into manager.run_tests() so manager's public interface is
  10338. simple.
  10339. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  10340. (Manager._collect_tests):
  10341. (Manager._parse_expectations):
  10342. (Manager._split_into_chunks_if_necessary):
  10343. (Manager.run):
  10344. (read_test_files):
  10345. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  10346. (ManagerTest.test_http_locking):
  10347. (ManagerTest.test_perf_locking):
  10348. (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
  10349. (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
  10350. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  10351. (run):
  10352. 2012-07-27 Dirk Pranke <dpranke@chromium.org>
  10353. nrwt: print filtered stderr after a crash correctly
  10354. https://bugs.webkit.org/show_bug.cgi?id=92428
  10355. Reviewed by Adam Barth.
  10356. Some ports will run the stderr output from DRT/WTR through a
  10357. filter after a crash in order to print a more useful stack
  10358. trace; while that gets written to the crash log correctly, we
  10359. don't log it to the debug output properly. This change fixes
  10360. that and makes it clearer that we're logging stderr, not the
  10361. crash log.
  10362. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  10363. (SingleTestRunner._handle_error):
  10364. * Scripts/webkitpy/layout_tests/port/base.py:
  10365. (Port._get_crash_log):
  10366. * Scripts/webkitpy/layout_tests/port/chromium.py:
  10367. (ChromiumPort._get_crash_log):
  10368. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  10369. (ChromiumAndroidPortTest.test_get_crash_log):
  10370. * Scripts/webkitpy/layout_tests/port/driver.py:
  10371. (Driver.run_test):
  10372. * Scripts/webkitpy/layout_tests/port/gtk.py:
  10373. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  10374. * Scripts/webkitpy/layout_tests/port/mac.py:
  10375. (MacPort._get_crash_log):
  10376. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  10377. (PortTestCase.test_get_crash_log):
  10378. 2012-07-27 Dirk Pranke <dpranke@chromium.org>
  10379. nrwt: move image diffing code to a separate module
  10380. https://bugs.webkit.org/show_bug.cgi?id=92447
  10381. Reviewed by Ryosuke Niwa.
  10382. This patch moves the code to talk to ImageDiff into its own
  10383. module, and adds more tests for it. In addition, the patch
  10384. modifies diff_image() so that we don't automatically stop
  10385. ImageDiff after a single invocation, and thus subsequent
  10386. diffs may be slightly faster. (Note that the chromium ports
  10387. don't use any of this code; that is not changed by this patch).
  10388. The main motivation for this change is to move more "generic"
  10389. code out of the port/* classes, and in particular to move more
  10390. code out of webkit.py so that we can eventually eliminate it by
  10391. merging it into base.py.
  10392. This patch also splits MockServerProcess out from driver_unittest.py
  10393. so that it can be re-used.
  10394. * Scripts/webkitpy/layout_tests/port/base.py:
  10395. (Port.__init__):
  10396. (Port.diff_image):
  10397. (Port.clean_up_test_run):
  10398. * Scripts/webkitpy/layout_tests/port/driver.py:
  10399. (Driver.__init__):
  10400. (Driver._start):
  10401. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  10402. (DriverTest.test_stop_cleans_up_properly):
  10403. (DriverTest.test_two_starts_cleans_up_properly):
  10404. (DriverTest.test_start_actually_starts):
  10405. * Scripts/webkitpy/layout_tests/port/efl.py:
  10406. (EflPort.clean_up_test_run):
  10407. * Scripts/webkitpy/layout_tests/port/gtk.py:
  10408. (GtkPort.clean_up_test_run):
  10409. * Scripts/webkitpy/layout_tests/port/image_diff.py: Added.
  10410. (ImageDiffer):
  10411. (ImageDiffer.__init__):
  10412. (ImageDiffer.diff_image):
  10413. (ImageDiffer._start):
  10414. (ImageDiffer._read):
  10415. (ImageDiffer.stop):
  10416. * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.
  10417. (for):
  10418. (FakePort):
  10419. (FakePort.__init__):
  10420. (FakePort._path_to_image_diff):
  10421. (FakePort.setup_environ_for_server):
  10422. (TestImageDiffer):
  10423. (TestImageDiffer.test_diff_image):
  10424. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  10425. (MockDRTPortTest.test_diff_image):
  10426. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  10427. (PortTestCase.test_diff_image__missing_both):
  10428. (PortTestCase.test_diff_image):
  10429. (PortTestCase.test_diff_image.make_proc):
  10430. * Scripts/webkitpy/layout_tests/port/server_process.py:
  10431. (ServerProcess._start):
  10432. * Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.
  10433. (MockServerProcess):
  10434. (MockServerProcess.__init__):
  10435. (MockServerProcess.write):
  10436. (MockServerProcess.has_crashed):
  10437. (MockServerProcess.read_stdout_line):
  10438. (MockServerProcess.read_stdout):
  10439. (MockServerProcess.pop_all_buffered_stderr):
  10440. (MockServerProcess.read_either_stdout_or_stderr_line):
  10441. (MockServerProcess.start):
  10442. (MockServerProcess.stop):
  10443. (MockServerProcess.kill):
  10444. * Scripts/webkitpy/layout_tests/port/webkit.py:
  10445. (WebKitPort._build_driver_flags):
  10446. (WebKitPort._symbols_string):
  10447. 2012-07-27 Tom Hudson <hudson@google.com>
  10448. Activate committer bit granted April 6th so I can garden.
  10449. https://bugs.webkit.org/show_bug.cgi?id=92500
  10450. Reviewed by Jochen Eisinger.
  10451. * Scripts/webkitpy/common/config/committers.py:
  10452. 2012-07-27 Jer Noble <jer.noble@apple.com>
  10453. Support a rational time class for use by media elements.
  10454. https://bugs.webkit.org/show_bug.cgi?id=88787
  10455. Add unit tests for the WTF::MediaTime class.
  10456. Reviewed by Eric Carlson.
  10457. * TestWebKitAPI/GNUmakefile.am:
  10458. * TestWebKitAPI/TestWebKitAPI.gypi:
  10459. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  10460. * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Added.
  10461. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  10462. (WTF::operator<<):
  10463. (TestWebKitAPI):
  10464. (TestWebKitAPI::TEST):
  10465. 2012-07-27 Balazs Kelemen <kbalazs@webkit.org>
  10466. [NRWT] should have a way to restrict pixel tests for individual directories
  10467. https://bugs.webkit.org/show_bug.cgi?id=91754
  10468. Unreviewed attempt to fix the chaos I introduced.
  10469. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  10470. (WebCore::DumpRenderTree::processLine):
  10471. 2012-07-27 YoungTaeck Song <youngtaeck.song@samsung.com>
  10472. [WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
  10473. https://bugs.webkit.org/show_bug.cgi?id=91581
  10474. Reviewed by Noam Rosenthal.
  10475. Add a MiniBrowser's option for selecting evas engine.
  10476. * MiniBrowser/efl/main.c:
  10477. (browserCreate):
  10478. (main):
  10479. 2012-07-27 Sheriff Bot <webkit.review.bot@gmail.com>
  10480. Unreviewed, rolling out r123869.
  10481. http://trac.webkit.org/changeset/123869
  10482. https://bugs.webkit.org/show_bug.cgi?id=92501
  10483. "it did not fix anything but made things even worst"
  10484. (Requested by kbalazs on #webkit).
  10485. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  10486. (WebCore::DumpRenderTree::DumpRenderTree):
  10487. (WebCore::DumpRenderTree::open):
  10488. (WebCore::DumpRenderTree::processLine):
  10489. (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
  10490. (WebCore::DumpRenderTree::dump):
  10491. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  10492. (DumpRenderTree):
  10493. * DumpRenderTree/qt/main.cpp:
  10494. (main):
  10495. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  10496. (SingleTestRunner._should_fetch_expected_checksum):
  10497. (SingleTestRunner._overwrite_baselines):
  10498. (SingleTestRunner._compare_output):
  10499. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  10500. (Worker._update_test_input):
  10501. * Scripts/webkitpy/layout_tests/port/base.py:
  10502. (Port.supports_switching_pixel_tests_per_test):
  10503. (Port):
  10504. (Port._supports_switching_pixel_tests_per_test):
  10505. (Port.should_run_as_pixel_test):
  10506. (Port._should_run_as_pixel_test):
  10507. * Scripts/webkitpy/layout_tests/port/driver.py:
  10508. (Driver.cmd_line):
  10509. (Driver._command_from_driver_input):
  10510. * Scripts/webkitpy/layout_tests/port/qt.py:
  10511. (QtPort.check_sys_deps):
  10512. (QtPort):
  10513. (QtPort._supports_switching_pixel_tests_per_test):
  10514. (QtPort._should_run_as_pixel_test):
  10515. (QtPort._default_pixel_test_directories):
  10516. * Scripts/webkitpy/layout_tests/port/test.py:
  10517. (TestPort.supports_switching_pixel_tests_per_test):
  10518. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  10519. (_set_up_derived_options):
  10520. (parse_args):
  10521. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  10522. (MainTest.test_run_singly_actually_runs_tests):
  10523. (MainTest.test_pixel_test_directories):
  10524. * WebKitTestRunner/TestController.cpp:
  10525. (WTR::TestController::TestController):
  10526. (WTR::TestController::initialize):
  10527. (WTR::TestController::runTest):
  10528. * WebKitTestRunner/TestController.h:
  10529. (TestController):
  10530. 2012-07-27 Balazs Kelemen <kbalazs@webkit.org>
  10531. [NRWT] should have a way to restrict pixel tests for individual directories
  10532. https://bugs.webkit.org/show_bug.cgi?id=91754
  10533. Reviewed by Zoltan Herczeg.
  10534. Rollout r123729 because it made Qt debug bots crasy.
  10535. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  10536. (WebCore::DumpRenderTree::DumpRenderTree):
  10537. (WebCore::DumpRenderTree::open):
  10538. (WebCore::DumpRenderTree::processLine):
  10539. (WebCore::DumpRenderTree::setDumpPixels):
  10540. (WebCore::DumpRenderTree::dump):
  10541. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  10542. (DumpRenderTree):
  10543. * DumpRenderTree/qt/main.cpp:
  10544. (main):
  10545. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  10546. (SingleTestRunner._should_fetch_expected_checksum):
  10547. (SingleTestRunner._overwrite_baselines):
  10548. (SingleTestRunner._compare_output):
  10549. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  10550. (Worker._update_test_input):
  10551. * Scripts/webkitpy/layout_tests/port/base.py:
  10552. (Port.lookup_virtual_test_args):
  10553. * Scripts/webkitpy/layout_tests/port/driver.py:
  10554. (Driver.cmd_line):
  10555. (Driver._command_from_driver_input):
  10556. * Scripts/webkitpy/layout_tests/port/qt.py:
  10557. (QtPort.check_sys_deps):
  10558. * Scripts/webkitpy/layout_tests/port/test.py:
  10559. (TestPort.virtual_test_suites):
  10560. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  10561. (_set_up_derived_options):
  10562. (parse_args):
  10563. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  10564. (MainTest.test_run_singly_actually_runs_tests):
  10565. (MainTest.test_missing_and_unexpected_results):
  10566. * WebKitTestRunner/TestController.cpp:
  10567. (WTR::TestController::TestController):
  10568. (WTR::TestController::initialize):
  10569. (WTR::TestController::runTest):
  10570. * WebKitTestRunner/TestController.h:
  10571. (TestController):
  10572. 2012-07-27 Adam Barth <abarth@webkit.org>
  10573. webkit.review.bot should run clean-review-queue and clean-pending-commit periodically
  10574. https://bugs.webkit.org/show_bug.cgi?id=92472
  10575. Reviewed by Eric Seidel.
  10576. We need to run these command periodically to keep cruft from
  10577. accumulating in bugs.webkit.org. Rather than running them manually, we
  10578. should just have a bot run them. This patch has the style-queue run the
  10579. commands, which admittedly is a bit odd but it doesn't seem worthwhile
  10580. to create another bot specifically for this purposes.
  10581. * Scripts/webkitpy/tool/commands/queues.py:
  10582. (AbstractReviewQueue):
  10583. (StyleQueue.begin_work_queue):
  10584. (StyleQueue):
  10585. (StyleQueue.clean_bugzilla):
  10586. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  10587. (StyleQueueTest.test_style_queue_with_style_exception):
  10588. (test_style_queue_with_watch_list_exception):
  10589. 2012-07-27 Dominik Röttsches <dominik.rottsches@intel.com>
  10590. [Cairo] Add complex font drawing using HarfbuzzNG
  10591. https://bugs.webkit.org/show_bug.cgi?id=91864
  10592. Reviewed by Simon Hausmann and Martin Robinson.
  10593. Bringing Harfbuzz support to EFL with this patch, so we need HarfBuzz in the pulled in jhbuild dependencies.
  10594. * WebKitTestRunner/CMakeLists.txt: Adding additional header include directories.
  10595. * efl/jhbuild.modules: Adding source for HarfBuzz release version 0.9.0.
  10596. 2012-07-27 KwangYong Choi <ky0.choi@samsung.com>
  10597. [WK2][EFL][WTR] TestNetscapePlugin is required.
  10598. https://bugs.webkit.org/show_bug.cgi?id=88756
  10599. Reviewed by Simon Hausmann.
  10600. libTestNetscapePlugin.so should be required for DRT/WTR/EFL.
  10601. * CMakeLists.txt:
  10602. * DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
  10603. 2012-07-27 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  10604. [EFL] Memory leaks in EFL DRT
  10605. https://bugs.webkit.org/show_bug.cgi?id=92347
  10606. Reviewed by Simon Hausmann.
  10607. Fix a memory leak in EFL's DRT code by adopting an allocation
  10608. of JSString created with JSStringCreateWithUTF8CString.
  10609. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  10610. (DumpRenderTreeChrome::onWindowObjectCleared):
  10611. 2012-07-27 Adam Barth <abarth@webkit.org>
  10612. Simplify ExpectedFailures
  10613. https://bugs.webkit.org/show_bug.cgi?id=92216
  10614. Reviewed by Eric Seidel.
  10615. This patch simplifies the ExpectedFailures class we use to remember
  10616. which tests are currently failing on the bots. When we wrote this code
  10617. originally, we weren't entirely sure how it would work. Now that we
  10618. understand it more clearly, we can write the code more clearly.
  10619. * Scripts/webkitpy/tool/bot/expectedfailures.py:
  10620. (_has_failures):
  10621. (_is_trustworthy):
  10622. (ExpectedFailures.__init__):
  10623. (ExpectedFailures.failures_were_expected):
  10624. (ExpectedFailures.unexpected_failures_observed):
  10625. (ExpectedFailures.update):
  10626. * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
  10627. (ExpectedFailuresTest._assert_can_trust):
  10628. (ExpectedFailuresTest.test_failures_were_expected):
  10629. (ExpectedFailuresTest.test_unexpected_failures_observed):
  10630. (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
  10631. * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  10632. (PatchAnalysisTask._test):
  10633. (PatchAnalysisTask._build_and_test_without_patch):
  10634. (PatchAnalysisTask._test_patch):
  10635. 2012-07-27 Csaba Osztrogonác <ossy@webkit.org>
  10636. [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
  10637. https://bugs.webkit.org/show_bug.cgi?id=88064
  10638. Reviewed by Zoltan Herczeg.
  10639. Use resetInternalsObject() instead of injectInternalsObject().
  10640. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  10641. (WTR::InjectedBundlePage::resetAfterTest):
  10642. 2012-07-26 Ryuan Choi <ryuan.choi@samsung.com>
  10643. [EFL] Remove forwarding headers from MiniBrowser/Efl.
  10644. https://bugs.webkit.org/show_bug.cgi?id=91627
  10645. Reviewed by Kentaro Hara.
  10646. * MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.
  10647. 2012-07-26 Yoshifumi Inoue <yosin@chromium.org>
  10648. [Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
  10649. https://bugs.webkit.org/show_bug.cgi?id=92339
  10650. Reviewed by Kent Tamura.
  10651. This patch enables runtime features for input type datetime, datetime-local,
  10652. month, time and week for Chromium DRT.
  10653. * DumpRenderTree/chromium/TestShell.cpp:
  10654. (TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.
  10655. 2012-07-26 Jeffrey Pfau <jpfau@apple.com>
  10656. Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
  10657. https://bugs.webkit.org/show_bug.cgi?id=84041
  10658. Reviewed by Brady Eidson.
  10659. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  10660. * TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
  10661. (-[BackForwardListTest webView:didFinishLoadForFrame:]):
  10662. (-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
  10663. (TestWebKitAPI):
  10664. (TestWebKitAPI::TEST):
  10665. 2012-07-26 Sheriff Bot <webkit.review.bot@gmail.com>
  10666. Unreviewed, rolling out r123799.
  10667. http://trac.webkit.org/changeset/123799
  10668. https://bugs.webkit.org/show_bug.cgi?id=92431
  10669. broke the Apple Mac build (Requested by bweinstein on
  10670. #webkit).
  10671. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  10672. * DumpRenderTree/chromium/TestWebPlugin.h:
  10673. (TestWebPlugin::acceptsInputEvents):
  10674. (TestWebPlugin::handleInputEvent):
  10675. 2012-07-26 Dirk Pranke <dpranke@chromium.org>
  10676. nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
  10677. https://bugs.webkit.org/show_bug.cgi?id=92172
  10678. Reviewed by Tony Chang.
  10679. Right now new-run-webkit-tests --verbose prints out too much
  10680. information (it's like --verbose + debugging). I plan to fix
  10681. this in bug 88702, and also clean up and simplify all of the
  10682. --print options, but in preparation for these changes I need to
  10683. pass --verbose twice to get the same level of output
  10684. temporarily (for compatibility).
  10685. * Scripts/run-webkit-tests:
  10686. 2012-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org>
  10687. Propagate gesture events to plugins.
  10688. https://bugs.webkit.org/show_bug.cgi?id=92281
  10689. Reviewed by Adam Barth.
  10690. Update TestWebPlugin to receive events, and output logs for the events.
  10691. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  10692. (TestWebPlugin::handleInputEvent):
  10693. * DumpRenderTree/chromium/TestWebPlugin.h:
  10694. (TestWebPlugin::acceptsInputEvents):
  10695. (TestWebPlugin):
  10696. 2012-07-26 Balazs Kelemen <kbalazs@webkit.org>
  10697. [nrwt] get rid of --skip-pixel-test-if-no-baseline
  10698. https://bugs.webkit.org/show_bug.cgi?id=92377
  10699. Reviewed by Adam Barth.
  10700. Remove the option and all code paths that handled it.
  10701. * Scripts/webkitpy/layout_tests/port/base.py:
  10702. (Port.should_run_as_pixel_test):
  10703. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  10704. (_set_up_derived_options):
  10705. (parse_args):
  10706. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  10707. (MainTest.test_repeat_each):
  10708. 2012-07-26 Olivier Blin <olivier.blin@softathome.com>
  10709. Add FastMalloc statistics in window.internals
  10710. https://bugs.webkit.org/show_bug.cgi?id=91274
  10711. Reviewed by Ryosuke Niwa.
  10712. * GNUmakefile.am:
  10713. 2012-07-26 Olivier Blin <olivier.blin@softathome.com>
  10714. Add FastMalloc statistics in window.internals
  10715. https://bugs.webkit.org/show_bug.cgi?id=91274
  10716. Reviewed by Ryosuke Niwa.
  10717. * GNUmakefile.am:
  10718. 2012-07-20 Holger Hans Peter Freyther <holger@moiji-mobile.com>
  10719. buildbot: Remove the configuration of hfreyther*
  10720. https://bugs.webkit.org/show_bug.cgi?id=91849
  10721. Reviewed by Adam Roben.
  10722. The machine running these configs was decommissioned and
  10723. there is no replacement at this point. Remove them from the
  10724. configuration.
  10725. * BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from
  10726. the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
  10727. them too.
  10728. 2012-07-26 Balazs Kelemen <kbalazs@webkit.org>
  10729. Unreviewed speculative Mac buildfix after r123729 - 2nd attempt.
  10730. * WebKitTestRunner/TestController.cpp:
  10731. (WTR::TestController::runTest):
  10732. 2012-07-26 Balazs Kelemen <kbalazs@webkit.org>
  10733. Unreviewed speculative buildfix after r123729.
  10734. * WebKitTestRunner/TestController.cpp:
  10735. (WTR::TestController::runTest): Fix sign errors.
  10736. 2012-07-26 Zoltan Nyul <zoltan.nyul@intel.com>
  10737. [EFL] EFL port should use XDG paths
  10738. https://bugs.webkit.org/show_bug.cgi?id=91719
  10739. Reviewed by Kenneth Rohde Christiansen.
  10740. The appcache/localstorage/webdatabase path should be set in the
  10741. ewk_main.cpp instead of the DumpRenderTree, and the XDG_DATA_HOME and
  10742. XDG_CACHE_HOME should be set to different directory for each processes
  10743. for the layout-tests.
  10744. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  10745. (DumpRenderTreeChrome::initialize):
  10746. * Scripts/webkitpy/layout_tests/port/efl.py:
  10747. (EflPort.setup_environ_for_server):
  10748. * efl/jhbuild.modules:
  10749. 2012-07-26 Balazs Kelemen <kbalazs@webkit.org>
  10750. [NRWT] should have a way to restrict pixel tests for individual directories
  10751. https://bugs.webkit.org/show_bug.cgi?id=91754
  10752. Reviewed by Dirk Pranke.
  10753. Added --pixel-test-directories option to nrwt. It implies --pixel-tests.
  10754. If the platform supports this option only tests from these directories will
  10755. be executed as pixel tests. Furthermore, platforms can have a default set of
  10756. pixel test directories. To support the feature the test harness have to be
  10757. able to inform the driver whether to dump pixels for each tests. For this
  10758. purpose I changed WTR and the Qt DRT to handle a --pixel-test argument from
  10759. the standard output and made NRWT use this argument with these drivers.
  10760. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  10761. (WebCore::DumpRenderTree::DumpRenderTree):
  10762. (WebCore::DumpRenderTree::open):
  10763. (WebCore::DumpRenderTree::processLine):
  10764. (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
  10765. (WebCore::DumpRenderTree::dump):
  10766. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  10767. (DumpRenderTree):
  10768. * DumpRenderTree/qt/main.cpp:
  10769. (main):
  10770. Handle the --pixel-test argument.
  10771. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  10772. (SingleTestRunner._should_fetch_expected_checksum):
  10773. (SingleTestRunner._overwrite_baselines):
  10774. (SingleTestRunner._compare_output):
  10775. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  10776. (Worker._update_test_input):
  10777. * Scripts/webkitpy/layout_tests/port/base.py:
  10778. (Port.supports_switching_pixel_tests_per_test): Ports can override this to inform
  10779. the harness that --pixel-test argument is supported. True for WTR, otherwise calls
  10780. private version that can be overridden by the actual platform. Only true with WTR
  10781. and Qt DRT currently. This supposed to exist only temporary until there are ports
  10782. that doesn't support the feature in their DRT's.
  10783. (Port):
  10784. (Port._supports_switching_pixel_tests_per_test):
  10785. (Port.should_run_as_pixel_test):
  10786. (Port._should_run_as_pixel_test): Ports can override this to define their
  10787. default set of pixel tests directories.
  10788. * Scripts/webkitpy/layout_tests/port/driver.py:
  10789. (Driver.cmd_line): Don't pass --pixel-tests if the platform supports per test
  10790. --pixel-test.
  10791. (Driver._command_from_driver_input): Pass --pixel-test if it is supported and pixel
  10792. tests are enabled.
  10793. * Scripts/webkitpy/layout_tests/port/qt.py:
  10794. (QtPort.check_sys_deps):
  10795. (QtPort):
  10796. (QtPort._supports_switching_pixel_tests_per_test):
  10797. (QtPort._should_run_as_pixel_test):
  10798. (QtPort._default_pixel_test_directories): Only compositing will be our default pixel
  10799. test directory for the time being.
  10800. * Scripts/webkitpy/layout_tests/port/test.py:
  10801. (TestPort.supports_switching_pixel_tests_per_test):
  10802. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  10803. (_set_up_derived_options):
  10804. (parse_args):
  10805. Handle the --pixel-test-directory option. It expect a directory below LayoutTests
  10806. and can be specified multiple times. Added fixme's that we should improve how we
  10807. handle these arguments.
  10808. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  10809. (MainTest.test_run_singly_actually_runs_tests):
  10810. (MainTest.test_pixel_test_directories):
  10811. Added an integration test for the feature.
  10812. * WebKitTestRunner/TestController.cpp:
  10813. (WTR::TestController::TestController):
  10814. (WTR::TestController::initialize):
  10815. (WTR::TestController::runTest):
  10816. * WebKitTestRunner/TestController.h:
  10817. (TestController):
  10818. Handle the --pixel-test argument.
  10819. 2012-07-26 Christophe Dumez <christophe.dumez@intel.com>
  10820. [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
  10821. https://bugs.webkit.org/show_bug.cgi?id=92349
  10822. Reviewed by Kentaro Hara.
  10823. Fix crash occurring after r123604, which replaced strdup()
  10824. usage with eina_stringshare_add(). Unfortunately, the DRT
  10825. was not updated accordingly to use eina_stringshare_del()
  10826. instead of free() on the values returned by Ewk_Intent
  10827. getters and it was causing
  10828. webintents/web-intents-obj-constructor.html to crash.
  10829. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  10830. (DumpRenderTreeChrome::onFrameIntentNew):
  10831. 2012-07-26 Adam Barth <abarth@webkit.org>
  10832. Unreviewed attempt to fix the chromium-win build.
  10833. * DumpRenderTree/chromium/TestRunner/TestRunner.cpp:
  10834. 2012-07-26 Kaustubh Atrawalkar <kaustubh@motorola.com>
  10835. [DRT] LTC:: pageNumberForElementById() could be moved to Internals
  10836. https://bugs.webkit.org/show_bug.cgi?id=92091
  10837. Reviewed by Adam Barth.
  10838. Move the pageNumberForElementById from LayoutTestCotroller to Internals and
  10839. remove the old platform specific implementations as it exclusively tests WebCore functionality.
  10840. * DumpRenderTree/LayoutTestController.cpp:
  10841. (LayoutTestController::staticFunctions):
  10842. * DumpRenderTree/LayoutTestController.h:
  10843. (LayoutTestController):
  10844. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  10845. * DumpRenderTree/chromium/LayoutTestController.cpp:
  10846. (LayoutTestController::LayoutTestController):
  10847. (LayoutTestController::setPrinting):
  10848. * DumpRenderTree/chromium/LayoutTestController.h:
  10849. (LayoutTestController):
  10850. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  10851. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  10852. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  10853. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  10854. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  10855. (LayoutTestController):
  10856. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  10857. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  10858. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  10859. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  10860. (WTR):
  10861. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  10862. (LayoutTestController):
  10863. 2012-07-25 Adam Barth <abarth@webkit.org>
  10864. TestRunner.a should contain a TestRunner object
  10865. https://bugs.webkit.org/show_bug.cgi?id=92313
  10866. Reviewed by Kent Tamura.
  10867. This patch adds a stub implementation of TestRunner, which is the new
  10868. home for our implementation of window.testRunner. A future patch will
  10869. migrate functions from LayoutTestController to TestRunner.
  10870. * DumpRenderTree/DumpRenderTree.gypi:
  10871. * DumpRenderTree/chromium/LayoutTestController.h:
  10872. * DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
  10873. * DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.
  10874. 2012-07-25 Wei James <james.wei@intel.com>
  10875. [Chromium] Fix infinite loop issue for chromium android layout test
  10876. https://bugs.webkit.org/show_bug.cgi?id=92197
  10877. Reviewed by Adam Barth.
  10878. The change brought in by r123530 will cause infinite loop when running
  10879. Chromium Android Layout Test.
  10880. Revert the change for this line only.
  10881. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  10882. (ChromiumAndroidPort._build_path):
  10883. 2012-07-25 Adam Barth <abarth@webkit.org>
  10884. Jochen is our a newest reviewer!
  10885. * Scripts/webkitpy/common/config/committers.py:
  10886. 2012-07-25 Jochen Eisinger <jochen@chromium.org>
  10887. [chromium] don't use webkit_support methods directly from test runners but through the test delegate
  10888. https://bugs.webkit.org/show_bug.cgi?id=92256
  10889. Reviewed by Adam Barth.
  10890. This will allow for the content_shell to provide its own implementation
  10891. for setting the Gamepad data instead.
  10892. * DumpRenderTree/chromium/TestRunner/GamepadController.cpp:
  10893. (GamepadController::setDelegate):
  10894. (GamepadController::reset):
  10895. (GamepadController::connect):
  10896. (GamepadController::disconnect):
  10897. (GamepadController::setId):
  10898. (GamepadController::setButtonCount):
  10899. (GamepadController::setButtonData):
  10900. (GamepadController::setAxisCount):
  10901. (GamepadController::setAxisData):
  10902. * DumpRenderTree/chromium/TestRunner/GamepadController.h:
  10903. (GamepadController):
  10904. * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
  10905. (WebKit):
  10906. (TestDelegate):
  10907. * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
  10908. (TestInterfaces::Internal):
  10909. (TestInterfaces::Internal::~Internal):
  10910. (TestInterfaces::Internal::setDelegate):
  10911. (TestInterfaces::setDelegate):
  10912. * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
  10913. (TestInterfaces):
  10914. * DumpRenderTree/chromium/TestShell.cpp:
  10915. (TestShell::createMainWindow):
  10916. (TestShell::~TestShell):
  10917. * DumpRenderTree/chromium/WebViewHost.cpp:
  10918. (WebViewHost::setGamepadData):
  10919. * DumpRenderTree/chromium/WebViewHost.h:
  10920. (WebViewHost):
  10921. 2012-07-25 Christophe Dumez <christophe.dumez@intel.com>
  10922. [WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented
  10923. https://bugs.webkit.org/show_bug.cgi?id=92227
  10924. Reviewed by Kenneth Rohde Christiansen.
  10925. Implement LayoutTestController.sendWebIntentResponse() so
  10926. that a test case can reply to a Web intent request and
  10927. test this functionality.
  10928. In order to support this functionality, we need to keep
  10929. a pointer to the current intent request in
  10930. InjectedBundlePage::didReceiveIntentForFrame() so that
  10931. we can reuse it later in
  10932. LayoutTestController::sendWebIntentResponse().
  10933. The following tests need this functionality:
  10934. - webintents/web-intents-failure.html
  10935. - webintents/web-intents-reply.html
  10936. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  10937. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  10938. (WTR::InjectedBundlePage::didReceiveIntentForFrame):
  10939. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  10940. (InjectedBundlePage):
  10941. (WTR::InjectedBundlePage::currentIntentRequest):
  10942. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  10943. (WTR::LayoutTestController::sendWebIntentResponse):
  10944. (WTR):
  10945. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  10946. (LayoutTestController):
  10947. 2012-07-25 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  10948. [EFL][WK2][WTR] Alt, Shift and Ctrl keys are not handled by EventSenderProxy.
  10949. https://bugs.webkit.org/show_bug.cgi?id=92241
  10950. Reviewed by Kenneth Rohde Christiansen.
  10951. Alt, Shift and Ctrl keys were not handled by EventSenderProxy.
  10952. It caused failure of fast/events/keydown-leftright-keys.html test.
  10953. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added handling of Alt, Shift and Ctrl keys.
  10954. (WTR::keyName):
  10955. 2012-07-25 Christophe Dumez <christophe.dumez@intel.com>
  10956. [EFL][WK2] Fix timeout issues when debugging WebProcess.
  10957. https://bugs.webkit.org/show_bug.cgi?id=92245
  10958. Reviewed by Dirk Pranke.
  10959. Fix timeout issues when debugging the WebProcess
  10960. under valgrind or gdb.
  10961. * Scripts/webkitpy/layout_tests/port/efl.py:
  10962. (EflPort.default_timeout_ms):
  10963. * WebKitTestRunner/efl/TestControllerEfl.cpp:
  10964. (WTR::TestController::platformInitialize):
  10965. 2012-07-25 Xianzhu Wang <wangxianzhu@chromium.org>
  10966. [Chromium-Android] NRWT driver should not restart between reftests
  10967. https://bugs.webkit.org/show_bug.cgi?id=92267
  10968. Reviewed by Dirk Pranke.
  10969. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  10970. (ChromiumAndroidDriver.start): Resets self._pixel_tests when the pixel_tests parameter changes.
  10971. 2012-07-25 Tommy Widenflycht <tommyw@google.com>
  10972. MediaStream API: Update MediaStreamTrack to match the specification
  10973. https://bugs.webkit.org/show_bug.cgi?id=90180
  10974. Reviewed by Adam Barth.
  10975. Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
  10976. * DumpRenderTree/DumpRenderTree.gypi:
  10977. * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
  10978. (MockWebKitPlatformSupport::createMediaStreamCenter):
  10979. * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
  10980. (WebKit):
  10981. (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
  10982. (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
  10983. (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
  10984. (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
  10985. (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
  10986. (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
  10987. (WebKit::MockWebMediaStreamCenter::constructSDP):
  10988. * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
  10989. (WebKit):
  10990. (MockWebMediaStreamCenter):
  10991. (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
  10992. 2012-07-25 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  10993. [NRWT] Rename baseline_search_path() to default_baseline_search_path()
  10994. https://bugs.webkit.org/show_bug.cgi?id=92122
  10995. Reviewed by Dirk Pranke.
  10996. * Scripts/webkitpy/layout_tests/port/base.py:
  10997. (Port.baseline_version_dir):
  10998. (Port.baseline_search_path):
  10999. (Port):
  11000. (Port.default_baseline_search_path):
  11001. (Port.expected_baselines):
  11002. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  11003. (PortTest.test_additional_platform_directory):
  11004. * Scripts/webkitpy/layout_tests/port/mac.py:
  11005. (MacPort.default_baseline_search_path):
  11006. * Scripts/webkitpy/layout_tests/port/qt.py:
  11007. (QtPort.default_baseline_search_path):
  11008. * Scripts/webkitpy/layout_tests/port/win.py:
  11009. (WinPort.default_baseline_search_path):
  11010. 2012-07-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  11011. [EFL] Use eina_stringshare_add instead of strdup.
  11012. https://bugs.webkit.org/show_bug.cgi?id=92072
  11013. Reviewed by Kentaro Hara.
  11014. Eina of EFL libraries supports a string functionality that replaces strdup. So, EFL port needs
  11015. to replace strdup with eina_stringshare_add function.
  11016. DumpRenderTree also needs to be modified according to ewk APIs's parameter change.
  11017. * DumpRenderTree/efl/DumpRenderTree.cpp:
  11018. (dumpFramesAsText):
  11019. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  11020. (DumpRenderTreeChrome::onFrameIntentNew):
  11021. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  11022. (onJavaScriptPrompt):
  11023. 2012-07-25 Alexander Shalamov <alexander.shalamov@intel.com>
  11024. [WTR][EFL] Wheel events are not emitted
  11025. https://bugs.webkit.org/show_bug.cgi?id=92094
  11026. Reviewed by Csaba Osztrogonác.
  11027. Wheel events are not emitted, therefore, layout tests that use mouseScrollBy method are failing.
  11028. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
  11029. (WTR::dispatchMouseScrollByEvent):
  11030. (WTR::EventSenderProxy::mouseScrollBy):
  11031. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
  11032. (WTR::PlatformWebView::PlatformWebView):
  11033. (WTR::PlatformWebView::focus):
  11034. 2012-07-25 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  11035. [EFL][WK2] Add ewk_main.{cpp,h} to EFL WK2
  11036. https://bugs.webkit.org/show_bug.cgi?id=92101
  11037. Reviewed by Kenneth Rohde Christiansen.
  11038. Added a centralized place for general initialization in UI process for EFL WK2.
  11039. * MiniBrowser/efl/main.c: Added using of newly added ewk_init() and ewk_shutdown() functions.
  11040. (main):
  11041. * WebKitTestRunner/efl/main.cpp: Ditto.
  11042. (main):
  11043. 2012-07-24 Benjamin Poulain <bpoulain@apple.com> && Joseph Pecoraro <pecoraro@apple.com>
  11044. QualifiedName's HashSet should be big enough to hold at least all the static names
  11045. https://bugs.webkit.org/show_bug.cgi?id=91891
  11046. Reviewed by Darin Adler.
  11047. Add a test for WTF::hashTableCapacityForSize.
  11048. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  11049. * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added.
  11050. (InitialCapacityTestHashTraits):
  11051. (TestWebKitAPI::testInitialCapacity):
  11052. (TestWebKitAPI::generateTestCapacityUpToSize):
  11053. (TestWebKitAPI::TEST):
  11054. 2012-07-24 Adam Barth <abarth@webkit.org>
  11055. The EWS bots get flaky when we hit the failure limit
  11056. https://bugs.webkit.org/show_bug.cgi?id=92212
  11057. Reviewed by Eric Seidel.
  11058. Previously we were missing some failure types, which means we didn't
  11059. notice that the bots were hitting the failure limit.
  11060. * Scripts/webkitpy/common/net/layouttestresults.py:
  11061. (LayoutTestResults.failing_test_results):
  11062. * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  11063. (LayoutTestResultsTest.test_results_from_string):
  11064. (LayoutTestResultsTest.test_tests_matching_failure_types):
  11065. 2012-07-24 Raphael Kubo da Costa <rakuco@webkit.org>
  11066. [EFL] Unreviewed build fix.
  11067. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h
  11068. for usleep(3).
  11069. 2012-07-24 Dirk Pranke <dpranke@chromium.org>
  11070. make test-webkitpy at least kinda work in parallel on win32
  11071. https://bugs.webkit.org/show_bug.cgi?id=91700
  11072. Reviewed by Adam Barth.
  11073. This change makes the hoop-jumping we have to do to make running
  11074. new-run-webkit-tests in parallel on win32 generic so that we can
  11075. re-use it for test-webkitpy as well.
  11076. * Scripts/new-run-webkit-tests:
  11077. * Scripts/test-webkitpy:
  11078. * Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.
  11079. (run):
  11080. * Scripts/webkitpy/test/main.py:
  11081. (main):
  11082. (Tester._log_exception):
  11083. 2012-07-24 Sheriff Bot <webkit.review.bot@gmail.com>
  11084. Unreviewed, rolling out r123499.
  11085. http://trac.webkit.org/changeset/123499
  11086. https://bugs.webkit.org/show_bug.cgi?id=92161
  11087. Android fails to compile (Requested by zhenyao on #webkit).
  11088. * DumpRenderTree/DumpRenderTree.gypi:
  11089. * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
  11090. (MockWebKitPlatformSupport::createMediaStreamCenter):
  11091. * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
  11092. (MockWebKitPlatformSupport):
  11093. * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
  11094. * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.
  11095. 2012-07-24 Dirk Pranke <dpranke@chromium.org>
  11096. nrwt: never finds binaries in the 'out' dir on chromium win
  11097. https://bugs.webkit.org/show_bug.cgi?id=91890
  11098. Reviewed by Tony Chang.
  11099. Attempt to fix this bug yet again; it turns out that --root and
  11100. --build-directory don't have the same meaning (--root should
  11101. include the configuration, --build-directory should not).
  11102. * Scripts/webkitpy/layout_tests/port/base.py:
  11103. (Port._build_path):
  11104. * Scripts/webkitpy/layout_tests/port/chromium.py:
  11105. (ChromiumPort._static_build_path):
  11106. (ChromiumPort.default_results_directory):
  11107. (ChromiumPort._build_path):
  11108. (ChromiumPort):
  11109. (ChromiumPort._build_path_with_configuration):
  11110. (ChromiumPort._build_path_with_configuration.does):
  11111. (ChromiumPort._path_to_image_diff):
  11112. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11113. (ChromiumAndroidPort._build_path):
  11114. (ChromiumAndroidPort):
  11115. (ChromiumAndroidPort._build_path_with_configuration):
  11116. (ChromiumAndroidPort._path_to_driver):
  11117. (ChromiumAndroidPort._path_to_forwarder):
  11118. (ChromiumAndroidPort._push_executable):
  11119. (ChromiumAndroidPort._push_fonts):
  11120. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  11121. (ChromiumLinuxPort._determine_driver_path_statically):
  11122. (ChromiumLinuxPort._modules_to_search_for_symbols):
  11123. (ChromiumLinuxPort._path_to_driver):
  11124. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  11125. (ChromiumLinuxPortTest.test_build_path):
  11126. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  11127. (ChromiumMacPort._modules_to_search_for_symbols):
  11128. (ChromiumMacPort._path_to_driver):
  11129. (ChromiumMacPort._path_to_helper):
  11130. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  11131. (ChromiumMacPortTest.test_build_path):
  11132. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  11133. (ChromiumWinPort._path_to_driver):
  11134. (ChromiumWinPort._path_to_helper):
  11135. (ChromiumWinPort._path_to_image_diff):
  11136. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  11137. (ChromiumWinTest.test_build_path):
  11138. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  11139. (parse_args):
  11140. 2012-07-24 Peter Beverloo <peter@chromium.org>
  11141. Android-chromium layout tests failing with GPU related crash
  11142. https://bugs.webkit.org/show_bug.cgi?id=92126
  11143. Reviewed by Adam Barth.
  11144. Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
  11145. as it's not being used by any port anymore, and neither is being passed
  11146. on to the test runner. Instead, append the flag directly to DRT for the
  11147. Chromium Android port, which does rely on this functionality.
  11148. The ChromiumAndroidUnitTest tests didn't catch this as the property was
  11149. set to True, but it's unable to detect whether they'll actually be used.
  11150. No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
  11151. or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
  11152. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11153. (ChromiumAndroidPort.__init__):
  11154. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  11155. (ChromiumAndroidPortTest.test_attributes):
  11156. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  11157. (parse_args):
  11158. 2012-07-24 Alexander Shalamov <alexander.shalamov@intel.com>
  11159. [WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
  11160. https://bugs.webkit.org/show_bug.cgi?id=92107
  11161. Reviewed by Kenneth Rohde Christiansen.
  11162. Fixes mouse click events in EventSenderProxyEfl.
  11163. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
  11164. (WTR::dispatchMouseDownEvent):
  11165. (WTR::EventSenderProxy::dispatchEvent):
  11166. 2012-07-24 Tommy Widenflycht <tommyw@google.com>
  11167. MediaStream API: Update MediaStreamTrack to match the specification
  11168. https://bugs.webkit.org/show_bug.cgi?id=90180
  11169. Reviewed by Adam Barth.
  11170. Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
  11171. * DumpRenderTree/DumpRenderTree.gypi:
  11172. * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
  11173. (MockWebKitPlatformSupport::createMediaStreamCenter):
  11174. * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
  11175. (WebKit):
  11176. (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
  11177. (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
  11178. (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
  11179. (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
  11180. (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
  11181. (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
  11182. (WebKit::MockWebMediaStreamCenter::constructSDP):
  11183. * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
  11184. (WebKit):
  11185. (MockWebMediaStreamCenter):
  11186. (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
  11187. 2012-07-23 Ryosuke Niwa <rniwa@webkit.org>
  11188. Fix regressions in replay performance tests
  11189. https://bugs.webkit.org/show_bug.cgi?id=92052
  11190. Reviewed by Dirk Pranke.
  11191. Fix regression that accumulated over time to make replay tests work again.
  11192. * DumpRenderTree/chromium/WebViewHost.cpp:
  11193. (WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
  11194. URL hadn't been updated yet When requesting a new URL on the main frame.
  11195. * Scripts/webkitpy/performance_tests/perftest.py:
  11196. (ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
  11197. (ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
  11198. (ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.
  11199. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  11200. (TestReplayPerfTest.test_run_single):
  11201. (TestReplayPerfTest.test_prepare):
  11202. (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
  11203. (TestReplayPerfTest):
  11204. 2012-07-24 Simon Hausmann <simon.hausmann@nokia.com>
  11205. [Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
  11206. https://bugs.webkit.org/show_bug.cgi?id=91229
  11207. Reviewed by Jocelyn Turcotte.
  11208. In order to successfully link a DLL on Windows we need to have at least
  11209. one object file (or compilation unit). The forward export header files were
  11210. supposed to be that, but unfortunately the rule in win32/default_post.prf for
  11211. creating the header files had some bugs, among others that it did an exists()
  11212. check on the depending static library. At the time qmake is ran those libraries
  11213. do not exist yet and therefore the corresponding extra compiler rules were never
  11214. created, resulting in empty OBJECTS/SOURCES.
  11215. Even without such an exists() check, qmake extra compilers require the files
  11216. referred to in the .input variable to exist at qmake time. In this case the input
  11217. files were the static libraries, which do not exist yet.
  11218. This patch solves this by using a qmake extra target instead of extra
  11219. compiler, which does not have this limitation. The target is referenced
  11220. through the extension of GENERATED_SOURCES.
  11221. The patch also adds a d/_debug suffix for debug builds, do allow for separate
  11222. symbol exports if necessary.
  11223. * Scripts/generate-win32-export-forwards: Support multiple input files, i.e.
  11224. consider the last argument to be the output file and everything else input.
  11225. * qmake/mkspecs/features/win32/default_post.prf:
  11226. 2012-07-24 Balazs Kelemen <kbalazs@webkit.org>
  11227. [Qt] Add quirks for running the web process in a profiler shell, like valgrind
  11228. https://bugs.webkit.org/show_bug.cgi?id=87672
  11229. Reviewed by Jocelyn Turcotte.
  11230. Add --no-timeout-at-all command line switch to not time out no matter how
  11231. long the web process does it's job. --no-timeout is not enough for profiling
  11232. purposes because it only affects the timeout when we are waiting for the end
  11233. of the test. We use another timeout to control how much we wait for the web
  11234. process to initialize before and reset after the test and it could also easily
  11235. expire when running under valgrind. We should keep the behavior of --no-timeout
  11236. to not disable this timout check because --no-timeout is used by performace tests
  11237. and those should not wait for the web process to initialize and reset more than
  11238. normal tests.
  11239. * WebKitTestRunner/TestController.cpp:
  11240. (WTR::TestController::TestController):
  11241. (WTR::TestController::initialize):
  11242. (WTR::TestController::runUntil):
  11243. * WebKitTestRunner/TestController.h:
  11244. 2012-07-24 Peter Beverloo <peter@chromium.org>
  11245. [Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
  11246. https://bugs.webkit.org/show_bug.cgi?id=92097
  11247. Unreviewed build fix.
  11248. WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
  11249. but TestDelegate.h forward declares it as a class.
  11250. * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
  11251. (WebKit):
  11252. 2012-07-23 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  11253. [Qt] Fix compilation against namespaced Qt
  11254. Reviewed by Simon Hausmann.
  11255. * QtTestBrowser/launcherwindow.h:
  11256. * WebKitTestRunner/PlatformWebView.h:
  11257. 2012-07-24 Peter Beverloo <peter@chromium.org>
  11258. Update a few Chromium Android contributors in committers.py
  11259. https://bugs.webkit.org/show_bug.cgi?id=92090
  11260. Reviewed by Kent Tamura.
  11261. Add Sami Kyostila, who has been doing significant work on Chromium's
  11262. compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
  11263. remove John Grabowski who changed projects, and add my webkit.org alias.
  11264. * Scripts/webkitpy/common/config/committers.py:
  11265. 2012-07-24 Pierre Rossi <pierre.rossi@gmail.com>
  11266. [Qt] Enable touch slider when touch events are enabled
  11267. https://bugs.webkit.org/show_bug.cgi?id=91013
  11268. Reviewed by Kenneth Rohde Christiansen.
  11269. TOUCH_SLIDER guards are used in WebCore, so we should really
  11270. be setting the corresponding ENABLE define in features.prf.
  11271. * qmake/mkspecs/features/features.prf:
  11272. 2012-07-24 Ryuan Choi <ryuan.choi@samsung.com>
  11273. [EFL] EWebLauncher should not require config.h in the style check
  11274. https://bugs.webkit.org/show_bug.cgi?id=92070
  11275. Reviewed by Kentaro Hara.
  11276. * Scripts/webkitpy/style/checker.py:
  11277. Remove the include rules from the style-check for EWebLauncher because
  11278. EWebLauncher is simple EFL application.
  11279. 2012-07-24 Jochen Eisinger <jochen@chromium.or>
  11280. [Chromium] EventSender shouldn't know about TestShell
  11281. https://bugs.webkit.org/show_bug.cgi?id=91449
  11282. Reviewed by Adam Barth.
  11283. Original patch by Adam Barth.
  11284. This patch removes the dependency from EventSender to TestShell. Most
  11285. of EventSender works directly with a WebView, but there are a handful
  11286. of references to WebViewHost. We don't want to re-use WebViewHost in
  11287. ContentShell because we want to use the multi-process embedding
  11288. environment for WebViews.
  11289. To avoid the dependency on WebViewHost, this patch introduces
  11290. TestDelegate, which is an abstract base class for WebViewHost. In
  11291. ContentShell, we'll need another object to implement these functions.
  11292. * DumpRenderTree/chromium/EventSender.cpp:
  11293. (EventSender::EventSender):
  11294. (EventSender::keyDown):
  11295. (makeMenuItemStringsFor):
  11296. (EventSender::contextClick):
  11297. * DumpRenderTree/chromium/EventSender.h:
  11298. (EventSender):
  11299. (EventSender::setDelegate):
  11300. (EventSender::setWebView):
  11301. (EventSender::webview):
  11302. * DumpRenderTree/chromium/TestRunner/TestDelegate.h: Added.
  11303. (WebKit):
  11304. (TestDelegate):
  11305. * DumpRenderTree/chromium/TestShell.cpp:
  11306. (TestShell::initialize):
  11307. (TestShell::createMainWindow):
  11308. (TestShell::~TestShell):
  11309. * DumpRenderTree/chromium/WebViewHost.cpp:
  11310. (WebViewHost::fillSpellingSuggestionList):
  11311. * DumpRenderTree/chromium/WebViewHost.h:
  11312. (WebViewHost):
  11313. 2012-07-24 Thiago Marcos P. Santos <thiago.santos@intel.com>
  11314. Make WebIntents and WebIntentsTag a build option for the build-webkit script
  11315. https://bugs.webkit.org/show_bug.cgi?id=91841
  11316. Reviewed by Philippe Normand.
  11317. And it will also be disabled when building with --minimal.
  11318. * Scripts/webkitperl/FeatureList.pm:
  11319. 2012-07-23 Dirk Pranke <dpranke@chromium.org>
  11320. Unreviewed, rolling out r123360.
  11321. http://trac.webkit.org/changeset/123360
  11322. https://bugs.webkit.org/show_bug.cgi?id=91890
  11323. broke the chromium bots
  11324. * Scripts/webkitpy/layout_tests/port/chromium.py:
  11325. (ChromiumPort._static_build_path):
  11326. (ChromiumPort.default_results_directory):
  11327. (ChromiumPort._build_path):
  11328. (ChromiumPort._path_to_image_diff):
  11329. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11330. (ChromiumAndroidPort._build_path):
  11331. (ChromiumAndroidPort._path_to_driver):
  11332. (ChromiumAndroidPort._path_to_forwarder):
  11333. (ChromiumAndroidPort._push_executable):
  11334. (ChromiumAndroidPort._push_fonts):
  11335. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  11336. (ChromiumLinuxPort._determine_driver_path_statically):
  11337. (ChromiumLinuxPort._modules_to_search_for_symbols):
  11338. (ChromiumLinuxPort._path_to_driver):
  11339. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  11340. (ChromiumLinuxPortTest.test_build_path):
  11341. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  11342. (ChromiumMacPort._modules_to_search_for_symbols):
  11343. (ChromiumMacPort._path_to_driver):
  11344. (ChromiumMacPort._path_to_helper):
  11345. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  11346. (ChromiumMacPortTest.test_build_path):
  11347. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  11348. (ChromiumWinPort._path_to_driver):
  11349. (ChromiumWinPort._path_to_helper):
  11350. (ChromiumWinPort._path_to_image_diff):
  11351. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  11352. (ChromiumWinTest.test_build_path):
  11353. 2012-07-23 Adam Barth <abarth@webkit.org>
  11354. [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
  11355. https://bugs.webkit.org/show_bug.cgi?id=91459
  11356. Reviewed by Ryosuke Niwa.
  11357. Rather than having TestShell own and bind each of these JavaScript APIs
  11358. individually, TestShell should delegate that work to TestInterfaces.
  11359. This patch moves AccessibilityController and TextInputController to be
  11360. the responsibility of TestInterfaces.
  11361. * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
  11362. (TestInterfaces::TestInterfaces):
  11363. (TestInterfaces::~TestInterfaces):
  11364. (TestInterfaces::setWebView):
  11365. (TestInterfaces::bindTo):
  11366. (TestInterfaces::resetAll):
  11367. * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
  11368. (WebKit):
  11369. (TestInterfaces):
  11370. (TestInterfaces::accessibilityController):
  11371. * DumpRenderTree/chromium/TestShell.cpp:
  11372. (TestShell::initialize):
  11373. (TestShell::createMainWindow):
  11374. (TestShell::~TestShell):
  11375. (TestShell::resetTestController):
  11376. (TestShell::bindJSObjectsToWindow):
  11377. * DumpRenderTree/chromium/TestShell.h:
  11378. (TestShell::accessibilityController):
  11379. (TestShell):
  11380. 2012-07-23 Balazs Kelemen <kbalazs@webkit.org>
  11381. nrwt swallows early exceptions
  11382. https://bugs.webkit.org/show_bug.cgi?id=91884
  11383. Reviewed by Dirk Pranke.
  11384. Put everything in a try block so we won't miss any error.
  11385. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  11386. (run):
  11387. (main):
  11388. 2012-07-23 Christophe Dumez <christophe.dumez@intel.com>
  11389. [WK2] WebKitTestRunner needs to print information about Web intents
  11390. https://bugs.webkit.org/show_bug.cgi?id=90873
  11391. Reviewed by Anders Carlsson.
  11392. Print out information about new intents requests and intent
  11393. services registrations in WebKitTestRunner. This is expected
  11394. by tests under webintents/*.
  11395. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  11396. (WTR::InjectedBundlePage::InjectedBundlePage):
  11397. (WTR::InjectedBundlePage::didReceiveIntentForFrame):
  11398. (WTR):
  11399. (WTR::InjectedBundlePage::registerIntentServiceForFrame):
  11400. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  11401. (InjectedBundlePage):
  11402. 2012-07-23 Dirk Pranke <dpranke@chromium.org>
  11403. nrwt: never finds binaries in the 'out' dir on chromium win
  11404. https://bugs.webkit.org/show_bug.cgi?id=91890
  11405. Reviewed by Tony Chang.
  11406. We were figuring out which directory look in for binaries by
  11407. testing for the base directory (the directory above
  11408. Debug/Release). In chromium-win's case, we look in src/build,
  11409. which always exists because there are checked-in files in it,
  11410. which means we'd always pick that directory over src/out. All of
  11411. the other ports' build_path() implementation was including
  11412. Debug/Release. If we matched that, we wouldn't have a problem,
  11413. so this change fixes that and updates all of the callers of the
  11414. chromium ports' implementation to not pass configuration as part
  11415. of the path to look up; we still need to pass configuration in
  11416. some cases (to test if the build is out of date between debug
  11417. and release) so the implementation gets slightly more
  11418. complicated.
  11419. * Scripts/webkitpy/layout_tests/port/chromium.py:
  11420. (ChromiumPort._static_build_path):
  11421. (ChromiumPort.default_results_directory):
  11422. (ChromiumPort._build_path):
  11423. (ChromiumPort._path_to_image_diff):
  11424. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11425. (ChromiumAndroidPort._build_path):
  11426. (ChromiumAndroidPort._path_to_driver):
  11427. (ChromiumAndroidPort._path_to_forwarder):
  11428. (ChromiumAndroidPort._push_executable):
  11429. (ChromiumAndroidPort._push_fonts):
  11430. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  11431. (ChromiumLinuxPort._determine_driver_path_statically):
  11432. (ChromiumLinuxPort._modules_to_search_for_symbols):
  11433. (ChromiumLinuxPort._path_to_driver):
  11434. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  11435. (ChromiumLinuxPortTest.test_build_path):
  11436. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  11437. (ChromiumMacPort._modules_to_search_for_symbols):
  11438. (ChromiumMacPort._path_to_driver):
  11439. (ChromiumMacPort._path_to_helper):
  11440. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  11441. (ChromiumMacPortTest.test_build_path):
  11442. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  11443. (ChromiumWinPort._path_to_driver):
  11444. (ChromiumWinPort._path_to_helper):
  11445. (ChromiumWinPort._path_to_image_diff):
  11446. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  11447. (ChromiumWinTest.test_build_path):
  11448. 2012-07-23 Sheriff Bot <webkit.review.bot@gmail.com>
  11449. Unreviewed, rolling out r123339.
  11450. http://trac.webkit.org/changeset/123339
  11451. https://bugs.webkit.org/show_bug.cgi?id=92006
  11452. massive media tests failure (Requested by philn on #webkit).
  11453. * Scripts/webkitdirs.pm:
  11454. (buildAutotoolsProject):
  11455. * gtk/jhbuild.modules:
  11456. 2012-07-23 Tommy Widenflycht <tommyw@google.com>
  11457. [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
  11458. https://bugs.webkit.org/show_bug.cgi?id=91857
  11459. Reviewed by Adam Barth.
  11460. Made a few changes so that the destructor could be called at shutdown.
  11461. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  11462. (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
  11463. (WebKitSupportTestEnvironment):
  11464. * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
  11465. (MockWebKitPlatformSupport::create):
  11466. * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
  11467. (MockWebKitPlatformSupport):
  11468. (MockWebKitPlatformSupport::~MockWebKitPlatformSupport):
  11469. 2012-07-23 Philippe Normand <pnormand@igalia.com>
  11470. [GTK][jhbuild] Switch to GStreamer 0.11 build
  11471. https://bugs.webkit.org/show_bug.cgi?id=91727
  11472. Reviewed by Gustavo Noronha Silva.
  11473. Switch build-webkit --gtk to GStreamer 0.11 support and build the
  11474. necessary GStreamer git modules from JHBuild.
  11475. * Scripts/webkitdirs.pm:
  11476. (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
  11477. * gtk/jhbuild.modules: GStreamer build support.
  11478. 2012-07-23 Christophe Dumez <christophe.dumez@intel.com>
  11479. WebKit2 needs layoutTestController.setAlwaysAcceptCookies
  11480. https://bugs.webkit.org/show_bug.cgi?id=42778
  11481. Reviewed by Kenneth Rohde Christiansen.
  11482. Add support for layoutTestController.setAlwaysAcceptCookies()
  11483. since it is required by some tests.
  11484. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  11485. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  11486. (WTR::LayoutTestController::setAlwaysAcceptCookies):
  11487. (WTR):
  11488. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  11489. (LayoutTestController):
  11490. 2012-07-23 Kent Tamura <tkent@chromium.org>
  11491. Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
  11492. https://bugs.webkit.org/show_bug.cgi?id=91941
  11493. Reviewed by Kentaro Hara.
  11494. A flag name for an elmement should be ENABLE_*_ELEMENT.
  11495. * Scripts/webkitperl/FeatureList.pm:
  11496. * qmake/mkspecs/features/features.pri:
  11497. 2012-07-22 Kent Tamura <tkent@chromium.org>
  11498. Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
  11499. https://bugs.webkit.org/show_bug.cgi?id=91928
  11500. Reviewed by Kentaro Hara.
  11501. A flag name for an elmement should be ENABLE_*_ELEMENT.
  11502. * Scripts/webkitperl/FeatureList.pm:
  11503. * qmake/mkspecs/features/features.pri:
  11504. 2012-07-20 Kent Tamura <tkent@chromium.org>
  11505. Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT
  11506. https://bugs.webkit.org/show_bug.cgi?id=91846
  11507. Reviewed by Kentaro Hara.
  11508. A flag name for an elmement should be ENABLE_*_ELEMENT.
  11509. * Scripts/webkitperl/FeatureList.pm:
  11510. * qmake/mkspecs/features/features.pri:
  11511. 2012-07-20 Xianzhu Wang <wangxianzhu@chromium.org>
  11512. [Chromium-Android] Store test pipes in /data/local/tmp
  11513. https://bugs.webkit.org/show_bug.cgi?id=91909
  11514. In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
  11515. However after tests we found some devices don't allow the app to create pipes there.
  11516. So /data/local/tmp is a better place for the pipes.
  11517. Reviewed by Adam Barth.
  11518. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11519. 2012-07-20 Xianzhu Wang <wangxianzhu@chromium.org>
  11520. [Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
  11521. https://bugs.webkit.org/show_bug.cgi?id=91873
  11522. Reviewed by Adam Barth.
  11523. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11524. 2012-07-20 Han Shen <shenhan@google.com>
  11525. [Chromium] Compilation fails under gcc 4.7
  11526. https://bugs.webkit.org/show_bug.cgi?id=90227
  11527. Reviewed by Tony Chang.
  11528. Disable warnings about c++0x compatibility in gcc newer than 4.6.
  11529. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  11530. 2012-07-20 Dirk Pranke <dpranke@chromium.org>
  11531. REGRESSION: run-perf-tests --pause-before-testing is broken
  11532. https://bugs.webkit.org/show_bug.cgi?id=91789
  11533. Reviewed by Ryosuke Niwa.
  11534. Turns out start() wasn't actually starting things :(. Fixed, and
  11535. added tests.
  11536. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  11537. (ChromiumAndroidDriverTest.test_read_prompt):
  11538. * Scripts/webkitpy/layout_tests/port/driver.py:
  11539. (Driver.__init__):
  11540. (Driver._start):
  11541. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  11542. (DriverTest.test_read_block):
  11543. (DriverTest.test_read_binary_block):
  11544. (DriverTest.test_read_base64_block):
  11545. (DriverTest.test_stop_cleans_up_properly):
  11546. (DriverTest.test_two_starts_cleans_up_properly):
  11547. (DriverTest.test_start_actually_starts):
  11548. (MockServerProcess.__init__):
  11549. (MockServerProcess.start):
  11550. 2012-07-20 Jochen Eisinger <jochen@chromium.org>
  11551. [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
  11552. https://bugs.webkit.org/show_bug.cgi?id=91847
  11553. Reviewed by Adam Barth.
  11554. This allows for including the TestIntefaces.h from content shell
  11555. without introducing a dependency to WebCore/wtf
  11556. * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
  11557. (TestInterfaces::Internal):
  11558. (TestInterfaces::Internal::Internal):
  11559. (TestInterfaces::Internal::~Internal):
  11560. (TestInterfaces::Internal::bindTo):
  11561. (TestInterfaces::Internal::resetAll):
  11562. (TestInterfaces::TestInterfaces):
  11563. (TestInterfaces::~TestInterfaces):
  11564. (TestInterfaces::bindTo):
  11565. (TestInterfaces::resetAll):
  11566. * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
  11567. (TestInterfaces):
  11568. 2012-07-20 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  11569. [Qt] Make WTR use the same color palette as DRT
  11570. https://bugs.webkit.org/show_bug.cgi?id=91870
  11571. Reviewed by Noam Rosenthal.
  11572. Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
  11573. standard from QWindowsStyle.
  11574. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  11575. (WTR::activateFonts): Moved code to platformInitialize since setting style is not
  11576. exactly font related.
  11577. * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
  11578. (WTR::InjectedBundle::platformInitialize): Force the usage of the style's
  11579. palette. Because at this point QApplication was already instantiated, the
  11580. default palette was already initialized to be the system one, so we need to
  11581. explicitly set the palette to be the standard from style. This is not needed in
  11582. DRT because there we set the style before instantiating QApplication.
  11583. 2012-07-20 Tony Chang <tony@chromium.org>
  11584. Baseline align text in the flakiness dashboard toolbar
  11585. https://bugs.webkit.org/show_bug.cgi?id=91784
  11586. Reviewed by Ojan Vafai.
  11587. Baseline align the flex items.
  11588. * TestResultServer/static-dashboards/flakiness_dashboard.css:
  11589. (.forms): Add box-align: baseline
  11590. (.forms > *): Use block display to force flex items rather than box.
  11591. (#tests-form): Add box-align: baseline
  11592. (#tests-form > *): Use block display to force flex items rather than box.
  11593. 2012-07-20 Sheriff Bot <webkit.review.bot@gmail.com>
  11594. Unreviewed, rolling out r123220.
  11595. http://trac.webkit.org/changeset/123220
  11596. https://bugs.webkit.org/show_bug.cgi?id=91880
  11597. broke Debug build (Requested by philn on #webkit).
  11598. * Scripts/webkitdirs.pm:
  11599. (buildAutotoolsProject):
  11600. * gtk/jhbuild.modules:
  11601. 2012-07-20 Philippe Normand <pnormand@igalia.com>
  11602. [GTK][jhbuild] Switch to GStreamer 0.11 build
  11603. https://bugs.webkit.org/show_bug.cgi?id=91727
  11604. Reviewed by Gustavo Noronha Silva.
  11605. Switch build-webkit --gtk to GStreamer 0.11 support and build the
  11606. necessary GStreamer git modules from JHBuild.
  11607. * Scripts/webkitdirs.pm:
  11608. (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
  11609. * gtk/jhbuild.modules: GStreamer build support.
  11610. 2012-07-20 Christophe Dumez <christophe.dumez@intel.com>
  11611. [EFL] Proxy configuration should honor the no_proxy environment variable
  11612. https://bugs.webkit.org/show_bug.cgi?id=91747
  11613. Reviewed by Kenneth Rohde Christiansen.
  11614. Add ProxyResolverSoup to the list of classes that contain GObjects
  11615. in style checker script so that it does not complain about naming
  11616. convention issues that are mandated by GObject.
  11617. * Scripts/webkitpy/style/checker.py:
  11618. 2012-07-20 Zeno Albisser <zeno@webkit.org>
  11619. [Qt][WK2] Add configure tests for Xrender and GLX.
  11620. https://bugs.webkit.org/show_bug.cgi?id=91845
  11621. GraphicsSurface on linux requires Xcomposite, Xrender
  11622. and GLX. If any of these requirements is not met,
  11623. we should disable GraphicsSurface.
  11624. Reviewed by Kenneth Rohde Christiansen.
  11625. * qmake/config.tests/glx/glx.cpp: Added.
  11626. (main):
  11627. * qmake/config.tests/glx/glx.pro: Added.
  11628. * qmake/config.tests/libXrender/libXrender.cpp: Added.
  11629. (main):
  11630. * qmake/config.tests/libXrender/libXrender.pro: Added.
  11631. * qmake/configure.pri:
  11632. * qmake/mkspecs/features/features.prf:
  11633. 2012-07-20 Kangil Han <kangil.han@samsung.com>
  11634. [EFL][WK2][WTR] Implement EventSenderProxy
  11635. https://bugs.webkit.org/show_bug.cgi?id=91731
  11636. Reviewed by Kentaro Hara.
  11637. This is an initial EFL port implementation of EventSenderProxy.
  11638. * WebKitTestRunner/EventSenderProxy.h:
  11639. (WTR):
  11640. (EventSenderProxy):
  11641. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  11642. * WebKitTestRunner/PlatformEfl.cmake:
  11643. * WebKitTestRunner/TestController.cpp:
  11644. (WTR::TestController::TestController):
  11645. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  11646. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added.
  11647. (WTR):
  11648. (WTREvent):
  11649. (WTR::WTREvent::WTREvent):
  11650. (WTR::KeyEventInfo::KeyEventInfo):
  11651. (KeyEventInfo):
  11652. (WTR::evasMouseButton):
  11653. (WTR::setEvasModifiers):
  11654. (WTR::dispatchMouseDownEvent):
  11655. (WTR::dispatchMouseUpEvent):
  11656. (WTR::dispatchMouseMoveEvent):
  11657. (WTR::dispatchMouseScrollByEvent):
  11658. (WTR::keyPadName):
  11659. (WTR::keyName):
  11660. (WTR::EventSenderProxy::EventSenderProxy):
  11661. (WTR::EventSenderProxy::updateClickCountForButton):
  11662. (WTR::EventSenderProxy::dispatchEvent):
  11663. (WTR::EventSenderProxy::replaySavedEvents):
  11664. (WTR::EventSenderProxy::sendOrQueueEvent):
  11665. (WTR::EventSenderProxy::mouseDown):
  11666. (WTR::EventSenderProxy::mouseUp):
  11667. (WTR::EventSenderProxy::mouseMoveTo):
  11668. (WTR::EventSenderProxy::mouseScrollBy):
  11669. (WTR::EventSenderProxy::leapForward):
  11670. (WTR::EventSenderProxy::keyDown):
  11671. (WTR::EventSenderProxy::addTouchPoint):
  11672. (WTR::EventSenderProxy::updateTouchPoint):
  11673. (WTR::EventSenderProxy::setTouchModifier):
  11674. (WTR::EventSenderProxy::touchStart):
  11675. (WTR::EventSenderProxy::touchMove):
  11676. (WTR::EventSenderProxy::touchEnd):
  11677. (WTR::EventSenderProxy::touchCancel):
  11678. (WTR::EventSenderProxy::clearTouchPoints):
  11679. (WTR::EventSenderProxy::releaseTouchPoint):
  11680. (WTR::EventSenderProxy::cancelTouchPoint):
  11681. (WTR::EventSenderProxy::setTouchPointRadius):
  11682. 2012-07-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  11683. Unreviewed, rolling out r123085.
  11684. http://trac.webkit.org/changeset/123085
  11685. https://bugs.webkit.org/show_bug.cgi?id=91719
  11686. r123085 causes crashes on EFL layout test bot.
  11687. * WebKitTestRunner/CMakeLists.txt:
  11688. * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
  11689. (WTR::LayoutTestController::platformInitialize):
  11690. 2012-07-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  11691. [WTR] Add *explicit* keyword to constructor which has a parameter
  11692. https://bugs.webkit.org/show_bug.cgi?id=91745
  11693. Reviewed by Adam Barth.
  11694. Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
  11695. * WebKitTestRunner/EventSenderProxy.h:
  11696. (EventSenderProxy):
  11697. * WebKitTestRunner/TestInvocation.h:
  11698. (TestInvocation):
  11699. 2012-07-19 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  11700. [EFL] [WK2] Add methods to get/set a custom text encoding
  11701. https://bugs.webkit.org/show_bug.cgi?id=90604
  11702. Reviewed by Kenneth Rohde Christiansen.
  11703. Added support for setting custom character encoding in MiniBrowser.
  11704. Use 'F3' to set the custom character encoding.
  11705. * MiniBrowser/efl/main.c:
  11706. (on_key_down):
  11707. 2012-07-19 Dirk Pranke <dpranke@chromium.org>
  11708. webkitpy: executive_unittest still failing when run in parallel
  11709. https://bugs.webkit.org/show_bug.cgi?id=91795
  11710. Reviewed by Adam Barth.
  11711. It turns out that test_kill_process and test_kill_all are both
  11712. launching the same process, and so if they're run at the same
  11713. time, test_kill_all interferes w/ test_kill_process.
  11714. Merging the two tests solves the issue :).
  11715. * Scripts/webkitpy/common/system/executive_unittest.py:
  11716. (ExecutiveTest.test_kill_process):
  11717. (ExecutiveTest._assert_windows_image_name):
  11718. (ExecutiveTest):
  11719. (ExecutiveTest.test_windows_image_name):
  11720. 2012-07-19 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  11721. [EFL] [WK2] Add a callback to handle delete request in MiniBrowser
  11722. https://bugs.webkit.org/show_bug.cgi?id=91483
  11723. Reviewed by Dirk Pranke.
  11724. Add a callback to handle delete request and quit the main loop when
  11725. window is asked to be deleted so that all the resources allocated
  11726. for the window will be freed properly.
  11727. * MiniBrowser/efl/main.c:
  11728. (closeWindow):
  11729. (browserCreate):
  11730. 2012-07-19 No'am Rosenthal <noam.rosenthal@nokia.com>
  11731. [Qt] Enable CSS shaders in Qt (software mode)
  11732. https://bugs.webkit.org/show_bug.cgi?id=85140
  11733. Reviewed by Simon Hausmann.
  11734. Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
  11735. * qmake/mkspecs/features/features.prf:
  11736. 2012-07-19 No'am Rosenthal <noam.rosenthal@nokia.com>
  11737. [Qt] Enable CSS shaders in Qt (software mode)
  11738. https://bugs.webkit.org/show_bug.cgi?id=85140
  11739. Reviewed by Simon Hausmann.
  11740. Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
  11741. * qmake/mkspecs/features/features.prf:
  11742. 2012-07-19 Dirk Pranke <dpranke@chromium.org>
  11743. test-webkitpy: fix executive_unittest nits, including a missing 'errno' import
  11744. https://bugs.webkit.org/show_bug.cgi?id=91770
  11745. Reviewed by Adam Barth.
  11746. The missing errno import is causing a flaky failure when run in
  11747. parallel on the bots.
  11748. * Scripts/webkitpy/common/system/executive_unittest.py:
  11749. (ExecutiveTest.assert_interpreter_for_content):
  11750. 2012-07-19 Oliver Hunt <oliver@apple.com>
  11751. Make style bot handle underscores in names more reasonably
  11752. https://bugs.webkit.org/show_bug.cgi?id=91777
  11753. Reviewed by Gavin Barraclough.
  11754. This patch adds a naming/readability/underscores category for style errors.
  11755. That allows us to use underscores in those portions of JSC (and potentially
  11756. gtk?) without turning off all naming checks for the effected directories.
  11757. We also filter out the DFG_OPERATION warning, and a few other minor changes
  11758. to make the style bot less noisy when running over JSC at least.
  11759. * Scripts/webkitpy/style/checker.py:
  11760. * Scripts/webkitpy/style/checkers/cpp.py:
  11761. (check_identifier_name_in_declaration):
  11762. (CppChecker):
  11763. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  11764. (WebKitStyleTest.test_names):
  11765. 2012-07-19 Dirk Pranke <dpranke@chromium.org>
  11766. config_standalone.py is crashing on apple win's cygwin port
  11767. https://bugs.webkit.org/show_bug.cgi?id=91682
  11768. Reviewed by Adam Roben.
  11769. Work around a weird interaction of ctypes and cygwin that
  11770. is causing unit tests to crash for me locally.
  11771. * Scripts/webkitpy/common/system/executive.py:
  11772. (Executive._win32_check_running_pid):
  11773. 2012-07-19 Xabier Rodriguez Calvar <calvaris@igalia.com>
  11774. [GTK] WebKit test runner ignores all system environment variables
  11775. https://bugs.webkit.org/show_bug.cgi?id=90284
  11776. Reviewed by Dirk Pranke.
  11777. Added support in unit test framework to pass a custom environment
  11778. variable to the tests by using the --additional-env-var parameter.
  11779. * Scripts/webkitpy/layout_tests/port/base.py:
  11780. (Port.to.setup_environ_for_server): Adding environment variables
  11781. that come through the additional_env_var option.
  11782. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  11783. (PortTest.test_additional_env_var): Added unit test for the
  11784. additional_env_var option
  11785. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  11786. (parse_args): Added the --additional-env-var parameter.
  11787. 2012-07-19 Joshua Bell <jsbell@chromium.org>
  11788. Roll out r121610 and r122487 which may have been causing flaky crashes
  11789. https://bugs.webkit.org/show_bug.cgi?id=91637
  11790. Reviewed by Kentaro Hara.
  11791. Flaky crashes started in random tests following r121610. It's not clear
  11792. that r121610 is to blame, but we'd like to prove or disprove it.
  11793. If this doesn't resolve the crashes, this patch should be rolled out.
  11794. * DumpRenderTree/DumpRenderTree.gypi:
  11795. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  11796. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  11797. (PluginTest):
  11798. * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Removed.
  11799. 2012-07-19 Pierre Rossi <pierre.rossi@gmail.com>
  11800. [Qt][WK2] Map the elementRect exposed in QML to the view for popup menu
  11801. https://bugs.webkit.org/show_bug.cgi?id=91645
  11802. Reviewed by Simon Hausmann.
  11803. Also improved the logic slightly for edge cases.
  11804. * MiniBrowser/qt/qml/ItemSelector.qml:
  11805. 2012-07-19 Christophe Dumez <christophe.dumez@intel.com>
  11806. [EFL] Bump libsoup dependency to v2.39.4.1 to fix cookie issues
  11807. https://bugs.webkit.org/show_bug.cgi?id=91741
  11808. Reviewed by Kenneth Rohde Christiansen.
  11809. Bump libsoup dependency in jhbuild to v2.39.4.1 to fix issues
  11810. with cookies in non-suffixed/private domains [GNOME #679230].
  11811. * efl/jhbuild.modules:
  11812. 2012-07-19 Simon Hausmann <simon.hausmann@nokia.com>
  11813. [Qt] Remove support for Qt versions before 4.8.0
  11814. https://bugs.webkit.org/show_bug.cgi?id=91730
  11815. Reviewed by Kenneth Rohde Christiansen.
  11816. Remove Qt version check #ifdefs for Qt versions before 4.8.0.
  11817. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  11818. (LayoutTestController::reset):
  11819. (LayoutTestController::setAlwaysBlockCookies):
  11820. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  11821. (LayoutTestController):
  11822. 2012-07-19 Mario Sanchez Prada <msanchez@igalia.com>
  11823. [GTK] Enable MHTML support by default at build time
  11824. https://bugs.webkit.org/show_bug.cgi?id=89987
  11825. Reviewed by Carlos Garcia Campos.
  11826. Enable MHTML support by default for GTK in build-webkit.
  11827. * Scripts/webkitperl/FeatureList.pm:
  11828. 2012-07-19 Zoltan Nyul <zoltan.nyul@intel.com>
  11829. [EFL][WK2] Using different cache directory for each WTR process
  11830. https://bugs.webkit.org/show_bug.cgi?id=91719
  11831. Reviewed by Kenneth Rohde Christiansen.
  11832. The testrunner script may be running multiple processes in
  11833. parallel, and it makes appcache tests fail if they are using the same
  11834. directory. I modified the EFL's LayoutTestController to use the
  11835. DUMPRENDERTREE_TEMP for application cache directory because it's
  11836. different for each process.
  11837. * WebKitTestRunner/CMakeLists.txt:
  11838. * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
  11839. (WTR::LayoutTestController::platformInitialize):
  11840. 2012-07-19 Mario Sanchez Prada <msanchez@igalia.com>
  11841. [WK2][GTK] Complete implementation of AccessibilityController in WKTR for GTK
  11842. https://bugs.webkit.org/show_bug.cgi?id=89224
  11843. Reviewed by Chris Fleizach.
  11844. Implement logAccessibilityEvents() and resetToConsistentState(),
  11845. so we can ask WKTR from the layout tests for logging all the
  11846. accessibility related events into the result.
  11847. * WebKitTestRunner/GNUmakefile.am:
  11848. * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
  11849. (WTR::AccessibilityController::AccessibilityController):
  11850. (WTR):
  11851. (WTR::AccessibilityController::logAccessibilityEvents):
  11852. (WTR::AccessibilityController::resetToConsistentState):
  11853. * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
  11854. (AccessibilityController):
  11855. * WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp: Added.
  11856. (WTR):
  11857. (WTR::printAccessibilityEvent):
  11858. (WTR::axObjectEventListener):
  11859. (WTR::AccessibilityController::logAccessibilityEvents):
  11860. (WTR::AccessibilityController::resetToConsistentState):
  11861. Ensure we reset the accessibility controller to a consistent
  11862. whenever a test has finished running.
  11863. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  11864. (WTR::InjectedBundle::done):
  11865. 2012-07-19 Dominik Röttsches <dominik.rottsches@intel.com>
  11866. [EFL][Wk2] Add a bot that runs WTR / WebKit2 tests
  11867. https://bugs.webkit.org/show_bug.cgi?id=90788
  11868. Reviewed by Kentaro Hara.
  11869. Adding EFL 64bit WK2 BuildAndTest bot. At this point, we cannot transfer
  11870. the build product from one bot to the other due to link path issues with jhbuild,
  11871. so we do a full build and test cycle for WebKit2 on this bot.
  11872. * BuildSlaveSupport/build.webkit.org-config/config.json: Adding the new slave.
  11873. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Adding a new factory for building and testing WebKit2.
  11874. (BuildAndTestWebKit2Factory):
  11875. 2012-07-18 Mihnea Ovidenie <mihnea@adobe.com>
  11876. Unreviewed. Adding Andrei Bucur, Mihai Balan and Raul Hudea to the contributors list.
  11877. They are Adobe contributors working on CSSRegions.
  11878. * Scripts/webkitpy/common/config/committers.py:
  11879. 2012-07-18 Christophe Dumez <christophe.dumez@intel.com>
  11880. [CMake][EFL] Should try to find the same libsoup version pulled by jhbuild
  11881. https://bugs.webkit.org/show_bug.cgi?id=91626
  11882. Reviewed by Kenneth Rohde Christiansen.
  11883. Update jhbuild to pull libsoup 2.39.3 tarball from Gnome FTP instead
  11884. of fetching a tag from Gnome GIT. We need to do this to map the version
  11885. of libsoup that is required by our CMake config.
  11886. * efl/jhbuild.modules:
  11887. 2012-07-18 MORITA Hajime <morrita@google.com>
  11888. Add window resize benchmark
  11889. https://bugs.webkit.org/show_bug.cgi?id=91070
  11890. Reviewed by Ryosuke Niwa.
  11891. Added some more output filters to take care of html5.html output.
  11892. * Scripts/webkitpy/performance_tests/perftest.py:
  11893. (PerfTest):
  11894. 2012-07-18 Dirk Pranke <dpranke@chromium.org>
  11895. nrwt: merge WebKitDriver into Driver
  11896. https://bugs.webkit.org/show_bug.cgi?id=91696
  11897. Reviewed by Adam Barth.
  11898. As part of merging WebKitPort into Port, we also should merge
  11899. WebKitDriver into Driver, since all of the non-test Drivers now
  11900. inherit from WebKitDriver.
  11901. There are no functional changes in this patch, and all the changes should
  11902. be covered by the existing tests.
  11903. * Scripts/webkitpy/layout_tests/port/base.py:
  11904. (Port._driver_class):
  11905. * Scripts/webkitpy/layout_tests/port/chromium.py:
  11906. (ChromiumPort._check_file_exists):
  11907. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11908. (ChromiumAndroidDriver):
  11909. (ChromiumAndroidDriver.__init__):
  11910. (ChromiumAndroidDriver._drt_cmd_line):
  11911. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  11912. (ChromiumAndroidDriverTest.test_read_prompt):
  11913. * Scripts/webkitpy/layout_tests/port/driver.py:
  11914. (Driver):
  11915. (Driver.__init__):
  11916. (Driver.__del__):
  11917. (Driver.run_test):
  11918. (Driver.has_crashed):
  11919. (Driver.start):
  11920. (Driver._start):
  11921. (Driver.stop):
  11922. (Driver.cmd_line):
  11923. (Driver._check_for_driver_crash):
  11924. (Driver._command_from_driver_input):
  11925. (Driver._read_first_block):
  11926. (Driver._read_optional_image_block):
  11927. (Driver._read_header):
  11928. (Driver._process_stdout_line):
  11929. (Driver._strip_eof):
  11930. (Driver._read_block):
  11931. (ContentBlock):
  11932. (ContentBlock.__init__):
  11933. (ContentBlock.decode_content):
  11934. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  11935. (DriverTest.make_port):
  11936. (DriverTest._assert_wrapper):
  11937. (DriverTest.test_read_block):
  11938. (DriverTest):
  11939. (DriverTest.test_read_binary_block):
  11940. (DriverTest.test_read_base64_block):
  11941. (DriverTest.test_no_timeout):
  11942. (DriverTest.test_check_for_driver_crash):
  11943. (DriverTest.test_check_for_driver_crash.FakeServerProcess):
  11944. (DriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
  11945. (DriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
  11946. (DriverTest.test_check_for_driver_crash.FakeServerProcess.name):
  11947. (DriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
  11948. (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
  11949. (DriverTest.test_check_for_driver_crash.assert_crash):
  11950. (DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
  11951. (DriverTest.test_stop_cleans_up_properly):
  11952. (DriverTest.test_two_starts_cleans_up_properly):
  11953. (MockServerProcess):
  11954. (MockServerProcess.__init__):
  11955. (MockServerProcess.has_crashed):
  11956. (MockServerProcess.read_stdout_line):
  11957. (MockServerProcess.read_stdout):
  11958. (MockServerProcess.read_either_stdout_or_stderr_line):
  11959. (MockServerProcess.start):
  11960. (MockServerProcess.stop):
  11961. (MockServerProcess.kill):
  11962. * Scripts/webkitpy/layout_tests/port/gtk.py:
  11963. * Scripts/webkitpy/layout_tests/port/webkit.py:
  11964. (WebKitPort._read_image_diff):
  11965. (WebKitPort.skipped_layout_tests):
  11966. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  11967. (test_path_to_apache_config_file):
  11968. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  11969. (XvfbDriver):
  11970. (XvfbDriver.stop):
  11971. 2012-07-18 Dirk Pranke <dpranke@chromium.org>
  11972. webkitpy.common.system.executive_unittest.ExecutiveTest.test_kill_process is flaky
  11973. https://bugs.webkit.org/show_bug.cgi?id=91698
  11974. Unreviewed, build fix.
  11975. This is a workaround for the test failing (apparently mostly?)
  11976. when run in parallel with other tests. The underlying bug still
  11977. needs to be diagnosed as we shouldn't be getting ECHILD from
  11978. process.wait().
  11979. * Scripts/webkitpy/common/system/executive_unittest.py:
  11980. (ExecutiveTest.test_kill_process):
  11981. 2012-07-18 Dirk Pranke <dpranke@chromium.org>
  11982. Disable running python unit tests in parallel on win32 for now.
  11983. https://bugs.webkit.org/show_bug.cgi?id=91697
  11984. Unreviewed, build fix.
  11985. * Scripts/webkitpy/test/main.py:
  11986. (Tester._parse_args):
  11987. 2012-07-18 Dave Tu <dtu@chromium.org>
  11988. [chromium] Add gl_tests to flakiness dashboard.
  11989. https://bugs.webkit.org/show_bug.cgi?id=91680
  11990. Reviewed by Dirk Pranke.
  11991. * TestResultServer/static-dashboards/builders.js:
  11992. (loadBuildersList):
  11993. * TestResultServer/static-dashboards/dashboard_base.js:
  11994. (currentBuilderGroupCategory):
  11995. 2012-07-18 Dirk Pranke <dpranke@chromium.org>
  11996. fix python unit tests failing under cygwin
  11997. https://bugs.webkit.org/show_bug.cgi?id=91678
  11998. Reviewed by Adam Barth.
  11999. Fix a case where executive.kill_process was failing under cygwin
  12000. (apple win port) in an unexpected way.
  12001. * Scripts/webkitpy/common/system/executive.py:
  12002. (Executive.kill_process):
  12003. 2012-07-18 Dirk Pranke <dpranke@chromium.org>
  12004. test-webkitpy: run tests in parallel by default
  12005. https://bugs.webkit.org/show_bug.cgi?id=91422
  12006. Reviewed by Adam Barth.
  12007. We use multiprocessing.cpu_count() for the default number of
  12008. jobs to run; memory overhead should be very low, so this should
  12009. be fine.
  12010. * Scripts/webkitpy/test/main.py:
  12011. (Tester._parse_args):
  12012. 2012-07-18 Ryosuke Niwa <rniwa@webkit.org>
  12013. Add Pravin D to the list of contributors.
  12014. * Scripts/webkitpy/common/config/committers.py:
  12015. 2012-07-18 Balazs Kelemen <kbalazs@webkit.org>
  12016. [Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
  12017. https://bugs.webkit.org/show_bug.cgi?id=91514
  12018. Reviewed by Dirk Pranke.
  12019. Analyzing libQtWebKit.so is not enough in the case of force_static_libs_as_shared.
  12020. We need to analyze all the shared library or at least the WebCore one.
  12021. * Scripts/webkitdirs.pm:
  12022. (builtDylibPathForName):
  12023. In orwt it is hard coded to search for symbols in the WebCore library.
  12024. While in theory it is possible that symbols for a given feature are not
  12025. located in that, it doesn't happen in practice, so returning the path of
  12026. the WebCore library for a force_static_libs_as_shared build is enough to
  12027. fix the bug and it doesn't require a bigger refactoring. For a default
  12028. build we still return the path of the QtWebKit lib.
  12029. * Scripts/webkitpy/layout_tests/port/qt.py:
  12030. (QtPort._modules_to_search_for_symbols):
  12031. Enumerate all dynamic libraries, not just the QtWebKit one.
  12032. 2012-07-18 Tony Chang <tony@chromium.org>
  12033. [chromium] Unreviewed, more compile fixes on Chromium Win.
  12034. * DumpRenderTree/chromium/TestShellWin.cpp:
  12035. (TestShell::waitTestFinished):
  12036. * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
  12037. 2012-07-18 Christophe Dumez <christophe.dumez@intel.com>
  12038. [EFL] Add central error management to EFL port
  12039. https://bugs.webkit.org/show_bug.cgi?id=91598
  12040. Reviewed by Kenneth Rohde Christiansen.
  12041. Map WebKitNetworkError to NSURLErrorDomain when
  12042. printing in DumpRenderTree so that the output
  12043. matches the expected one.
  12044. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  12045. (descriptionSuitableForTestResult):
  12046. 2012-07-18 Dirk Pranke <dpranke@chromium.org>
  12047. nrwt: start merging port/webkit.py into port/base.py
  12048. https://bugs.webkit.org/show_bug.cgi?id=91559
  12049. Reviewed by Ojan Vafai.
  12050. Since all the non-test port implementations now derive from
  12051. WebKitPort, there's no real point in keeping WebKitPort distinct
  12052. from Port. This patch starts merging the two by moving nearly
  12053. all of the webkit implementations of routines with no default
  12054. behavior into base.py. The few that didn't move rely on
  12055. additional infrastructure that should be refactored differently
  12056. (like the image diffing, which should probably be its own
  12057. class) and deserve their own patches.
  12058. This patch should just be moving code around, and require no
  12059. additional tests; in fact, we can delete the tests that were
  12060. asserting virtual methods in the base class.
  12061. * Scripts/webkitpy/layout_tests/port/base.py:
  12062. (Port.baseline_search_path):
  12063. (Port.check_build):
  12064. (Port):
  12065. (Port._check_driver):
  12066. (Port._check_port_build):
  12067. (Port.check_image_diff):
  12068. (Port.driver_name):
  12069. (Port.default_results_directory):
  12070. (Port.to.setup_environ_for_server):
  12071. (Port._path_to_apache):
  12072. (Port._is_redhat_based):
  12073. (Port._is_debian_based):
  12074. (Port._apache_config_file_name_for_platform):
  12075. (Port._path_to_apache_config_file):
  12076. (Port._build_path):
  12077. (Port._path_to_driver):
  12078. (Port._path_to_webcore_library):
  12079. (Port._path_to_helper):
  12080. (Port._path_to_image_diff):
  12081. (Port._path_to_wdiff):
  12082. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  12083. (PortTest.test_httpd_returns_error_code):
  12084. * Scripts/webkitpy/layout_tests/port/webkit.py:
  12085. (WebKitPort):
  12086. (WebKitPort._build_driver_flags):
  12087. (WebKitPort._read_image_diff):
  12088. (WebKitPort.skipped_layout_tests):
  12089. 2012-07-18 Tommy Widenflycht <tommyw@google.com>
  12090. [chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
  12091. https://bugs.webkit.org/show_bug.cgi?id=86215
  12092. Reviewed by Adam Barth.
  12093. Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
  12094. instead create mock objects. No actual mock objects created yet.
  12095. * DumpRenderTree/DumpRenderTree.gypi:
  12096. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  12097. (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
  12098. * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.
  12099. (MockWebKitPlatformSupport::create):
  12100. (MockWebKitPlatformSupport::MockWebKitPlatformSupport):
  12101. (MockWebKitPlatformSupport::cryptographicallyRandomValues):
  12102. (MockWebKitPlatformSupport::createMediaStreamCenter):
  12103. * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.
  12104. (MockWebKitPlatformSupport):
  12105. * DumpRenderTree/chromium/config.h:
  12106. 2012-07-18 Thiago Marcos P. Santos <thiago.santos@intel.com>
  12107. [CMake][EFL] Build and run TestWebKitAPI unit tests
  12108. https://bugs.webkit.org/show_bug.cgi?id=90671
  12109. Reviewed by Daniel Bates.
  12110. This patch enables almost for free a significant amount of test for the
  12111. WebKit C API, WTF and KURL. It makes easy for CMake based ports to
  12112. enable TestWebKitAPI since the missing bits to implement are
  12113. relatively simple.
  12114. * CMakeLists.txt:
  12115. * TestWebKitAPI/CMakeLists.txt: Added.
  12116. * TestWebKitAPI/PlatformEfl.cmake: Added.
  12117. * TestWebKitAPI/PlatformWebView.h:
  12118. * TestWebKitAPI/config.h:
  12119. * TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
  12120. (TestWebKitAPI):
  12121. (TestWebKitAPI::InjectedBundleController::platformInitialize):
  12122. * TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
  12123. (TestWebKitAPI):
  12124. (Util):
  12125. (TestWebKitAPI::Util::run):
  12126. (TestWebKitAPI::Util::sleep):
  12127. (TestWebKitAPI::Util::createURLForResource):
  12128. (TestWebKitAPI::Util::createInjectedBundlePath):
  12129. (TestWebKitAPI::Util::URLForNonExistentResource):
  12130. * TestWebKitAPI/efl/PlatformWebView.cpp: Added.
  12131. (TestWebKitAPI):
  12132. (TestWebKitAPI::initEcoreEvas):
  12133. (TestWebKitAPI::PlatformWebView::PlatformWebView):
  12134. (TestWebKitAPI::PlatformWebView::~PlatformWebView):
  12135. (TestWebKitAPI::PlatformWebView::page):
  12136. * TestWebKitAPI/efl/main.cpp: Added.
  12137. (checkForUseX11WindowArgument):
  12138. (main):
  12139. 2012-07-18 Thiago Marcos P. Santos <thiago.santos@intel.com>
  12140. [CMake][EFL] Building jsc causes reconfiguration
  12141. https://bugs.webkit.org/show_bug.cgi?id=91387
  12142. Reviewed by Daniel Bates.
  12143. We should remove CMakeCache only when running build-webkit script,
  12144. otherwise it will cause a reconfiguration every time someone calls
  12145. generateBuildSystemFromCMakeProject(). We were re-building "jsc" and
  12146. not running WebKit2 unit tests on the bots because the project was
  12147. reconfigured with default values by the scripts that run these tests.
  12148. * Scripts/build-webkit:
  12149. * Scripts/webkitdirs.pm:
  12150. (removeCMakeCache):
  12151. (generateBuildSystemFromCMakeProject):
  12152. 2012-07-18 Seokju Kwon <seokju.kwon@samsung.com>
  12153. [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
  12154. https://bugs.webkit.org/show_bug.cgi?id=87935
  12155. Reviewed by Andreas Kling.
  12156. Web Inspector will be shown when path or url contains "inspector/".
  12157. Dumprendertree should wait util web inspector resources are loaded totally
  12158. and handle the signals for creating or removing a view of web inspector.
  12159. ("inspector,view,create" and "inspector,view,close")
  12160. * DumpRenderTree/efl/DumpRenderTree.cpp:
  12161. (shouldOpenWebInspector):
  12162. (createLayoutTestController):
  12163. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  12164. (DumpRenderTreeChrome::createView):
  12165. (DumpRenderTreeChrome::createWebInspectorView):
  12166. (DumpRenderTreeChrome::removeWebInspectorView):
  12167. (DumpRenderTreeChrome::waitInspectorLoadFinished):
  12168. (DumpRenderTreeChrome::onInspectorViewCreate):
  12169. (DumpRenderTreeChrome::onInspectorViewClose):
  12170. (DumpRenderTreeChrome::onInspectorFrameLoadFinished):
  12171. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  12172. (DumpRenderTreeChrome):
  12173. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  12174. (onConsoleMessage):
  12175. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  12176. (LayoutTestController::showWebInspector):
  12177. (LayoutTestController::closeWebInspector):
  12178. (LayoutTestController::evaluateInWebInspector):
  12179. 2012-07-18 Simon Hausmann <simon.hausmann@nokia.com>
  12180. [ANGLE] On QT, use Bison and Flex during ANGLE build
  12181. https://bugs.webkit.org/show_bug.cgi?id=91108
  12182. Reviewed by Kenneth Rohde Christiansen.
  12183. * qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow
  12184. generating not only for SOURCES but also ANGLE_SOURCES (in this bug)
  12185. 2012-07-18 Balazs Kelemen <kbalazs@webkit.org>
  12186. [Qt] plugin tests should not be disabled for WebKit1
  12187. https://bugs.webkit.org/show_bug.cgi?id=91604
  12188. Reviewed by Simon Hausmann.
  12189. Instead of not building TestNetscapePlugIn, we could programatically
  12190. disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
  12191. has been solved, so we can still test plugins on WebKit1.
  12192. * Tools.pro:
  12193. * WebKitTestRunner/TestController.cpp:
  12194. (WTR::TestController::initialize):
  12195. * WebKitTestRunner/qt/TestControllerQt.cpp:
  12196. (WTR::TestController::initializeTestPluginDirectory):
  12197. 2012-07-18 Mario Sanchez Prada <msanchez@igalia.com>
  12198. [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
  12199. https://bugs.webkit.org/show_bug.cgi?id=89223
  12200. Reviewed by Chris Fleizach.
  12201. Implemented AccessibilityUIElement in WKTR for GTK, based in the
  12202. implementation present in DumpRenderTree.
  12203. Added new files in gtk/ and updated the cross-platform ones.
  12204. * WebKitTestRunner/GNUmakefile.am:
  12205. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
  12206. (WTR):
  12207. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  12208. (AccessibilityUIElement):
  12209. * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp: Added.
  12210. (WTR):
  12211. (WTR::attributeSetToString):
  12212. (WTR::checkElementState):
  12213. (WTR::indexRangeInTable):
  12214. (WTR::alterCurrentValue):
  12215. (WTR::AccessibilityUIElement::AccessibilityUIElement):
  12216. (WTR::AccessibilityUIElement::~AccessibilityUIElement):
  12217. (WTR::AccessibilityUIElement::isEqual):
  12218. (WTR::AccessibilityUIElement::getChildren):
  12219. (WTR::AccessibilityUIElement::getChildrenWithRange):
  12220. (WTR::AccessibilityUIElement::childrenCount):
  12221. (WTR::AccessibilityUIElement::elementAtPoint):
  12222. (WTR::AccessibilityUIElement::indexOfChild):
  12223. (WTR::AccessibilityUIElement::childAtIndex):
  12224. (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
  12225. (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
  12226. (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
  12227. (WTR::AccessibilityUIElement::disclosedRowAtIndex):
  12228. (WTR::AccessibilityUIElement::rowAtIndex):
  12229. (WTR::AccessibilityUIElement::selectedChildAtIndex):
  12230. (WTR::AccessibilityUIElement::selectedChildrenCount):
  12231. (WTR::AccessibilityUIElement::selectedRowAtIndex):
  12232. (WTR::AccessibilityUIElement::titleUIElement):
  12233. (WTR::AccessibilityUIElement::parentElement):
  12234. (WTR::AccessibilityUIElement::disclosedByRow):
  12235. (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
  12236. (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
  12237. (WTR::AccessibilityUIElement::attributesOfChildren):
  12238. (WTR::AccessibilityUIElement::allAttributes):
  12239. (WTR::AccessibilityUIElement::stringAttributeValue):
  12240. (WTR::AccessibilityUIElement::numberAttributeValue):
  12241. (WTR::AccessibilityUIElement::uiElementAttributeValue):
  12242. (WTR::AccessibilityUIElement::boolAttributeValue):
  12243. (WTR::AccessibilityUIElement::isAttributeSettable):
  12244. (WTR::AccessibilityUIElement::isAttributeSupported):
  12245. (WTR::AccessibilityUIElement::parameterizedAttributeNames):
  12246. (WTR::AccessibilityUIElement::role):
  12247. (WTR::AccessibilityUIElement::subrole):
  12248. (WTR::AccessibilityUIElement::roleDescription):
  12249. (WTR::AccessibilityUIElement::title):
  12250. (WTR::AccessibilityUIElement::description):
  12251. (WTR::AccessibilityUIElement::orientation):
  12252. (WTR::AccessibilityUIElement::stringValue):
  12253. (WTR::AccessibilityUIElement::language):
  12254. (WTR::AccessibilityUIElement::helpText):
  12255. (WTR::AccessibilityUIElement::x):
  12256. (WTR::AccessibilityUIElement::y):
  12257. (WTR::AccessibilityUIElement::width):
  12258. (WTR::AccessibilityUIElement::height):
  12259. (WTR::AccessibilityUIElement::clickPointX):
  12260. (WTR::AccessibilityUIElement::clickPointY):
  12261. (WTR::AccessibilityUIElement::intValue):
  12262. (WTR::AccessibilityUIElement::minValue):
  12263. (WTR::AccessibilityUIElement::maxValue):
  12264. (WTR::AccessibilityUIElement::valueDescription):
  12265. (WTR::AccessibilityUIElement::insertionPointLineNumber):
  12266. (WTR::AccessibilityUIElement::isActionSupported):
  12267. (WTR::AccessibilityUIElement::isEnabled):
  12268. (WTR::AccessibilityUIElement::isRequired):
  12269. (WTR::AccessibilityUIElement::isFocused):
  12270. (WTR::AccessibilityUIElement::isSelected):
  12271. (WTR::AccessibilityUIElement::isExpanded):
  12272. (WTR::AccessibilityUIElement::isChecked):
  12273. (WTR::AccessibilityUIElement::hierarchicalLevel):
  12274. (WTR::AccessibilityUIElement::speak):
  12275. (WTR::AccessibilityUIElement::ariaIsGrabbed):
  12276. (WTR::AccessibilityUIElement::ariaDropEffects):
  12277. (WTR::AccessibilityUIElement::lineForIndex):
  12278. (WTR::AccessibilityUIElement::rangeForLine):
  12279. (WTR::AccessibilityUIElement::rangeForPosition):
  12280. (WTR::AccessibilityUIElement::boundsForRange):
  12281. (WTR::AccessibilityUIElement::stringForRange):
  12282. (WTR::AccessibilityUIElement::attributedStringForRange):
  12283. (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
  12284. (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
  12285. (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
  12286. (WTR::AccessibilityUIElement::attributesOfRowHeaders):
  12287. (WTR::AccessibilityUIElement::attributesOfColumns):
  12288. (WTR::AccessibilityUIElement::attributesOfRows):
  12289. (WTR::AccessibilityUIElement::attributesOfVisibleCells):
  12290. (WTR::AccessibilityUIElement::attributesOfHeader):
  12291. (WTR::AccessibilityUIElement::rowCount):
  12292. (WTR::AccessibilityUIElement::columnCount):
  12293. (WTR::AccessibilityUIElement::indexInTable):
  12294. (WTR::AccessibilityUIElement::rowIndexRange):
  12295. (WTR::AccessibilityUIElement::columnIndexRange):
  12296. (WTR::AccessibilityUIElement::cellForColumnAndRow):
  12297. (WTR::AccessibilityUIElement::horizontalScrollbar):
  12298. (WTR::AccessibilityUIElement::verticalScrollbar):
  12299. (WTR::AccessibilityUIElement::selectedTextRange):
  12300. (WTR::AccessibilityUIElement::setSelectedTextRange):
  12301. (WTR::AccessibilityUIElement::increment):
  12302. (WTR::AccessibilityUIElement::decrement):
  12303. (WTR::AccessibilityUIElement::showMenu):
  12304. (WTR::AccessibilityUIElement::press):
  12305. (WTR::AccessibilityUIElement::setSelectedChild):
  12306. (WTR::AccessibilityUIElement::accessibilityValue):
  12307. (WTR::AccessibilityUIElement::documentEncoding):
  12308. (WTR::AccessibilityUIElement::documentURI):
  12309. (WTR::AccessibilityUIElement::url):
  12310. (WTR::AccessibilityUIElement::addNotificationListener):
  12311. (WTR::AccessibilityUIElement::removeNotificationListener):
  12312. (WTR::AccessibilityUIElement::isFocusable):
  12313. (WTR::AccessibilityUIElement::isSelectable):
  12314. (WTR::AccessibilityUIElement::isMultiSelectable):
  12315. (WTR::AccessibilityUIElement::isVisible):
  12316. (WTR::AccessibilityUIElement::isOffScreen):
  12317. (WTR::AccessibilityUIElement::isCollapsed):
  12318. (WTR::AccessibilityUIElement::isIgnored):
  12319. (WTR::AccessibilityUIElement::hasPopup):
  12320. (WTR::AccessibilityUIElement::takeFocus):
  12321. (WTR::AccessibilityUIElement::takeSelection):
  12322. (WTR::AccessibilityUIElement::addSelection):
  12323. (WTR::AccessibilityUIElement::removeSelection):
  12324. (WTR::AccessibilityUIElement::textMarkerRangeForElement):
  12325. (WTR::AccessibilityUIElement::textMarkerRangeLength):
  12326. (WTR::AccessibilityUIElement::previousTextMarker):
  12327. (WTR::AccessibilityUIElement::nextTextMarker):
  12328. (WTR::AccessibilityUIElement::stringForTextMarkerRange):
  12329. (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
  12330. (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
  12331. (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
  12332. (WTR::AccessibilityUIElement::textMarkerForPoint):
  12333. (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
  12334. (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
  12335. (WTR::AccessibilityUIElement::indexForTextMarker):
  12336. (WTR::AccessibilityUIElement::isTextMarkerValid):
  12337. (WTR::AccessibilityUIElement::textMarkerForIndex):
  12338. Add documentEncoding and documentURI to AccessibilityUIElement.idl.
  12339. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  12340. 2012-07-18 Alexis Menard <alexis.menard@openbossa.org>
  12341. [EFL] Build fix in WebKitTestRunner.
  12342. https://bugs.webkit.org/show_bug.cgi?id=91567
  12343. Reviewed by Kentaro Hara.
  12344. sleep() is defined in unistd.h, we need to include it.
  12345. * WebKitTestRunner/efl/TestControllerEfl.cpp:
  12346. 2012-07-18 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  12347. [NRWT] Unreviewed gardening after r122913
  12348. https://bugs.webkit.org/show_bug.cgi?id=91601
  12349. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  12350. (TrivialMockPort.process_kill_time):
  12351. 2012-07-17 Xianzhu Wang <wangxianzhu@chromium.org>
  12352. [Chromium-Android] Run ref tests together to avoid expensive driver restarts
  12353. https://bugs.webkit.org/show_bug.cgi?id=91533
  12354. Reviewed by Dirk Pranke.
  12355. Though DriverProxy maintains two drivers to support pixel tests and non-pixel tests,
  12356. chromium-android uses another way because it can't support multiple drivers.
  12357. It restarts the driver when pixel-test mode changes (e.g. when running a ref test after
  12358. a normal test in --no-pixel-tests mode). However restarting driver is expensive on
  12359. Android (several seconds each time). To reduce the cost, a command line option
  12360. '--shard-ref-tests' is added to group ref tests in dedicated shards.
  12361. The option is by default enabled on Android.
  12362. Will remove the option once DRT supports switching pixel test mode during one run.
  12363. (https://bugs.webkit.org/show_bug.cgi?id=91538, https://bugs.webkit.org/show_bug.cgi?id=91539)
  12364. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12365. (Manager._shard_tests):
  12366. (Manager._shard_in_two):
  12367. (Manager._shard_by_directory):
  12368. (Manager._run_tests):
  12369. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  12370. (Worker._update_test_input):
  12371. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  12372. (ChromiumAndroidPort.__init__):
  12373. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  12374. (parse_args):
  12375. 2012-07-17 Don Olmstead <don.olmstead@am.sony.com>
  12376. NRWT The time before server_process kills DRT should be variable
  12377. https://bugs.webkit.org/show_bug.cgi?id=91542
  12378. Reviewed by Dirk Pranke.
  12379. Added the ability to configure the amount of time
  12380. server_process waits before killing the DRT process
  12381. during the call to stop.
  12382. * Scripts/webkitpy/layout_tests/port/base.py:
  12383. (Port.variable.process_kill_time):
  12384. * Scripts/webkitpy/layout_tests/port/server_process.py:
  12385. (ServerProcess.stop):
  12386. 2012-07-17 Alexis Menard <alexis.menard@openbossa.org>
  12387. webkitdirs.pm should fallback to uname -m if arch is not present.
  12388. https://bugs.webkit.org/show_bug.cgi?id=91543
  12389. Reviewed by Martin Robinson.
  12390. It seems that coreutils is moving away from the 'arch' command. Archlinux
  12391. for example doesn't ship it anymore (coreutils 8.17). We can then fallback
  12392. to 'uname -m' to find out the architecture.
  12393. * Scripts/webkitdirs.pm:
  12394. (determineArchitecture):
  12395. 2012-07-17 Dirk Pranke <dpranke@chromium.org>
  12396. nrwt: rename printer.print_update to printer.write_update to match metered_stream
  12397. https://bugs.webkit.org/show_bug.cgi?id=91557
  12398. Reviewed by Ojan Vafai.
  12399. Now that all of the printing logic is in printer.py, I want the
  12400. public interface to printer to follow the meteredstream
  12401. interface where possible. renaming write_update() gets us close.
  12402. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12403. (Manager._run_tests):
  12404. (Manager._set_up_run):
  12405. (Manager.start_servers_with_lock):
  12406. (Manager.stop_servers_with_lock):
  12407. (Manager._clobber_old_results):
  12408. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  12409. (run):
  12410. * Scripts/webkitpy/layout_tests/views/printing.py:
  12411. (Printer.write_update):
  12412. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  12413. (Testprinter.test_write_update):
  12414. 2012-07-17 Tony Chang <tony@chromium.org>
  12415. Fix a bug where optimize-baselines would incorrectly fail to optimize
  12416. https://bugs.webkit.org/show_bug.cgi?id=91551
  12417. Reviewed by Adam Barth.
  12418. In some cases, optimize-baseline would correctly optimize the results, but because
  12419. we weren't filtering the virtual ports out of _results_by_port_name, we thought
  12420. that we had failed to optimize.
  12421. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  12422. (BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
  12423. (BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
  12424. (BaselineOptimizer.optimize): Filter out virtual ports.
  12425. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  12426. (TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
  12427. (BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
  12428. (BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
  12429. (BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
  12430. (BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.
  12431. 2012-07-17 Xianzhu Wang <wangxianzhu@chromium.org>
  12432. [Chromium] Add --encode-binary command line option for DRT
  12433. https://bugs.webkit.org/show_bug.cgi?id=91532
  12434. Reviewed by Adam Barth.
  12435. When the option presents, DRT will encode binary output data in base64.
  12436. ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
  12437. binary data output.
  12438. This change is a refactoring to replace the original hard-coded code for Android.
  12439. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  12440. (main):
  12441. * DumpRenderTree/chromium/TestEventPrinter.cpp:
  12442. (TestEventPrinter::TestEventPrinter):
  12443. (TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
  12444. (TestEventPrinter::handleImage):
  12445. (TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage
  12446. * DumpRenderTree/chromium/TestEventPrinter.h:
  12447. (TestEventPrinter):
  12448. * DumpRenderTree/chromium/TestShell.cpp:
  12449. (TestShell::TestShell):
  12450. (TestShell::initialize):
  12451. (TestShell::dump):
  12452. * DumpRenderTree/chromium/TestShell.h:
  12453. (TestShell):
  12454. (TestShell::setEncodeBinary):
  12455. * Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags
  12456. (ChromiumAndroidPort.__init__):
  12457. 2012-07-17 Dirk Pranke <dpranke@chromium.org>
  12458. nrwt: move per-test result output into printing.py
  12459. https://bugs.webkit.org/show_bug.cgi?id=91465
  12460. Reviewed by Ojan Vafai.
  12461. This moves the last substantive logging/printing code from the
  12462. manager into printing.py. Subsequent patches in this thread can
  12463. largely focus on cleaning up printing.py and will leave the rest
  12464. of the code alone.
  12465. This patch also removes manager.update() and
  12466. manager.update_summary(), two routines that were no longer being
  12467. used or needed (they have been dead for a long time but I didn't
  12468. notice them until now).
  12469. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12470. (Manager.results_directory):
  12471. (Manager._look_for_new_crash_logs):
  12472. (Manager._update_summary_with_result):
  12473. * Scripts/webkitpy/layout_tests/views/printing.py:
  12474. (Printer.print_finished_test):
  12475. 2012-07-17 Dirk Pranke <dpranke@chromium.org>
  12476. nrwt: move config-specific logging to printing.py
  12477. https://bugs.webkit.org/show_bug.cgi?id=91450
  12478. Reviewed by Ojan Vafai.
  12479. More refactoring ... this moves the 'config' output to
  12480. printing.py.
  12481. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12482. (Manager._resize_shards):
  12483. (Manager._run_tests):
  12484. (Manager._upload_json_files):
  12485. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  12486. (ManagerTest.get_options):
  12487. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  12488. (run):
  12489. * Scripts/webkitpy/layout_tests/views/printing.py:
  12490. (Printer.print_config):
  12491. (Printer.print_workers_and_shards):
  12492. (Printer._print_config):
  12493. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  12494. (Testprinter.test_fallback_path_in_config):
  12495. (Testprinter.test_print_config):
  12496. 2012-07-17 Dirk Pranke <dpranke@chromium.org>
  12497. nrwt: clean up logging when we're only running one chunk of the tests
  12498. https://bugs.webkit.org/show_bug.cgi?id=91447
  12499. Reviewed by Ojan Vafai.
  12500. Apparently we were creating a 'tests_run.txt' in the results
  12501. directory if we were only running one chunk of the tests; after
  12502. 3+ years of hacking on this code, that was news to me, so I'm
  12503. guessing no one uses this. I'm removing this, and changing the
  12504. _print_expected calls to debug messages to simplify the
  12505. layering.
  12506. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12507. (Manager._split_into_chunks_if_necessary):
  12508. 2012-07-17 Dirk Pranke <dpranke@chromium.org>
  12509. Fix regression in style checker introduced in r122868.
  12510. https://bugs.webkit.org/show_bug.cgi?id=91470
  12511. Unreviewed, build fix.
  12512. * Scripts/webkitpy/style/checkers/cpp.py:
  12513. (_FileState.__init__):
  12514. 2012-07-17 Dirk Pranke <dpranke@chromium.org>
  12515. nrwt: move the bulk of the "expected" output to printing.py
  12516. https://bugs.webkit.org/show_bug.cgi?id=91442
  12517. Reviewed by Ojan Vafai.
  12518. More printing-related refactoring. This moves all of the code
  12519. that prints the results we expect to get, but doesn't move a few
  12520. dangling printfs (those'll get hit in a later patch).
  12521. No functional changes; covered by existing tests.
  12522. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12523. (Manager._split_into_chunks_if_necessary):
  12524. (Manager.prepare_lists_and_print_output):
  12525. (Manager.print_config):
  12526. * Scripts/webkitpy/layout_tests/views/printing.py:
  12527. (Printer.print_expected):
  12528. (Printer):
  12529. (Printer._print_expected_results_of_type):
  12530. (Printer._num_digits):
  12531. (Printer._print_expected):
  12532. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  12533. (Testprinter.test_print_expected):
  12534. 2012-07-17 Christophe Dumez <christophe.dumez@intel.com>
  12535. [EFL] Replace 0 by NULL in public headers documentation
  12536. https://bugs.webkit.org/show_bug.cgi?id=91470
  12537. Reviewed by Dirk Pranke.
  12538. Fix style checking to properly detect C headers as C
  12539. files. Without this change, the style script would
  12540. complain if we use NULL (instead of 0 / null) in C
  12541. headers.
  12542. * Scripts/webkitpy/style/checkers/cpp.py:
  12543. (_FileState.__init__):
  12544. (_FileState.is_c):
  12545. (_FileState.is_c_or_objective_c):
  12546. 2012-07-17 Xianzhu Wang <wangxianzhu@chromium.org>
  12547. [chromium] remove --test-shell support from DRT
  12548. https://bugs.webkit.org/show_bug.cgi?id=86927
  12549. Reviewed by Adam Barth.
  12550. Now no one use --test-shell. All of us use the standard DRT mode.
  12551. * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed support of --test-shell and --pixel-tests=filename options. (--pixel-tests without '=' is kept for DRT mode.)
  12552. (runTest):
  12553. (main):
  12554. * DumpRenderTree/chromium/TestEventPrinter.cpp:
  12555. (TestEventPrinter::TestEventPrinter):
  12556. (TestEventPrinter::~TestEventPrinter):
  12557. (TestEventPrinter::handleTestHeader):
  12558. (TestEventPrinter::handleTimedOut):
  12559. (TestEventPrinter::handleTextHeader):
  12560. (TestEventPrinter::handleTextFooter):
  12561. (TestEventPrinter::handleAudioHeader):
  12562. (TestEventPrinter::handleAudioFooter):
  12563. (TestEventPrinter::handleImage): Removed the unused filename parameter.
  12564. (TestEventPrinter::handleTestFooter):
  12565. * DumpRenderTree/chromium/TestEventPrinter.h:
  12566. (TestEventPrinter): Made it a concrete class because we have only one implementation.
  12567. * DumpRenderTree/chromium/TestShell.cpp:
  12568. (TestShell::TestShell):
  12569. (TestShell::initialize):
  12570. (TestShell::dumpImage):
  12571. * DumpRenderTree/chromium/TestShell.h:
  12572. (TestParams): Removed pixelFileName field.
  12573. (TestShell):
  12574. 2012-07-17 Xianzhu Wang <wangxianzhu@chromium.org>
  12575. remove ChromiumDriver from NRWT
  12576. https://bugs.webkit.org/show_bug.cgi?id=88478
  12577. Now WebKitDriver has replaced ChromiumDriver since test_shell mode is deperecated.
  12578. Reviewed by Dirk Pranke.
  12579. * Scripts/webkitpy/layout_tests/port/chromium.py: Removed ChromiumDriver code.
  12580. (ChromiumPort._driver_class): Removed. WebKitPort._driver_class() will be used.
  12581. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  12582. 2012-07-17 No'am Rosenthal <noam.rosenthal@nokia.com>
  12583. Unreviewed. Add QtGraphics, TextureMapper and OpenGL to watchlist.
  12584. * Scripts/webkitpy/common/config/watchlist:
  12585. 2012-07-17 Sheriff Bot <webkit.review.bot@gmail.com>
  12586. Unreviewed, rolling out r122828.
  12587. http://trac.webkit.org/changeset/122828
  12588. https://bugs.webkit.org/show_bug.cgi?id=91516
  12589. DumpRenderTree crashes after printing test results. (Requested
  12590. by vsevik on #webkit).
  12591. * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
  12592. (TestInterfaces::TestInterfaces):
  12593. (TestInterfaces::~TestInterfaces):
  12594. (TestInterfaces::bindTo):
  12595. (TestInterfaces::resetAll):
  12596. * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
  12597. (TestInterfaces):
  12598. * DumpRenderTree/chromium/TestShell.cpp:
  12599. (TestShell::initialize):
  12600. (TestShell::createMainWindow):
  12601. (TestShell::~TestShell):
  12602. (TestShell::resetTestController):
  12603. (TestShell::bindJSObjectsToWindow):
  12604. * DumpRenderTree/chromium/TestShell.h:
  12605. (TestShell::accessibilityController):
  12606. (TestShell):
  12607. 2012-07-17 Gabor Ballabas <gaborb@inf.u-szeged.hu>
  12608. [Qt][V8] Remove the V8 related codepaths and configuration
  12609. https://bugs.webkit.org/show_bug.cgi?id=90863
  12610. Reviewed by Simon Hausmann.
  12611. * Scripts/build-webkit: Remove --v8 option.
  12612. 2012-07-17 Sheriff Bot <webkit.review.bot@gmail.com>
  12613. Unreviewed, rolling out r122834.
  12614. http://trac.webkit.org/changeset/122834
  12615. https://bugs.webkit.org/show_bug.cgi?id=91492
  12616. it broke the chromium (Requested by kkristof on #webkit).
  12617. * Scripts/build-webkit:
  12618. 2012-07-17 Gabor Ballabas <gaborb@inf.u-szeged.hu>
  12619. [Qt][V8] Remove the V8 related codepaths and configuration
  12620. https://bugs.webkit.org/show_bug.cgi?id=90863
  12621. Reviewed by Simon Hausmann.
  12622. * Scripts/build-webkit: Remove --v8 option.
  12623. 2012-07-17 Balazs Kelemen <kbalazs@webkit.org>
  12624. [Qt] Add --use-test-fonts option to Minibrowser
  12625. https://bugs.webkit.org/show_bug.cgi?id=91402
  12626. Reviewed by Tor Arne Vestbø.
  12627. Same stuff that already exists for QtTestBrowser.
  12628. * MiniBrowser/qt/MiniBrowser.pro:
  12629. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  12630. (MiniBrowserApplication::handleUserOptions):
  12631. 2012-07-17 Adam Barth <abarth@webkit.org>
  12632. [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
  12633. https://bugs.webkit.org/show_bug.cgi?id=91459
  12634. Reviewed by Ryosuke Niwa.
  12635. Rather than having TestShell own and bind each of these JavaScript APIs
  12636. individually, TestShell should delegate that work to TestInterfaces.
  12637. This patch moves AccessibilityController and TextInputController to be
  12638. the responsibility of TestInterfaces.
  12639. * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
  12640. (TestInterfaces::TestInterfaces):
  12641. (TestInterfaces::~TestInterfaces):
  12642. (TestInterfaces::setWebView):
  12643. (TestInterfaces::bindTo):
  12644. (TestInterfaces::resetAll):
  12645. * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
  12646. (WebKit):
  12647. (TestInterfaces):
  12648. (TestInterfaces::accessibilityController):
  12649. * DumpRenderTree/chromium/TestShell.cpp:
  12650. (TestShell::initialize):
  12651. (TestShell::createMainWindow):
  12652. (TestShell::~TestShell):
  12653. (TestShell::resetTestController):
  12654. (TestShell::bindJSObjectsToWindow):
  12655. * DumpRenderTree/chromium/TestShell.h:
  12656. (TestShell::accessibilityController):
  12657. (TestShell):
  12658. 2012-07-17 Adam Barth <abarth@webkit.org>
  12659. [Chromium] Move TextInputController into TestRunner.a
  12660. https://bugs.webkit.org/show_bug.cgi?id=91457
  12661. Reviewed by Ryosuke Niwa.
  12662. This patch is purely moving code. TextInputController is one of the
  12663. objects exposed to JavaScript and so should be in the TestRunner
  12664. library.
  12665. * DumpRenderTree/DumpRenderTree.gypi:
  12666. * DumpRenderTree/chromium/TestRunner/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TextInputController.cpp.
  12667. * DumpRenderTree/chromium/TestRunner/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TextInputController.h.
  12668. 2012-07-17 Adam Barth <abarth@webkit.org>
  12669. [Chromium] TextInputController shouldn't know about TestShell
  12670. https://bugs.webkit.org/show_bug.cgi?id=91455
  12671. Reviewed by Kent Tamura.
  12672. This patch uses the same pattern we used for the
  12673. AccessibilityController to remove the dependency on TestShell.
  12674. * DumpRenderTree/chromium/TestShell.cpp:
  12675. (TestShell::initialize):
  12676. (TestShell::createMainWindow):
  12677. (TestShell::~TestShell):
  12678. * DumpRenderTree/chromium/TextInputController.cpp:
  12679. (TextInputController::TextInputController):
  12680. (TextInputController::insertText):
  12681. (TextInputController::doCommand):
  12682. (TextInputController::setMarkedText):
  12683. (TextInputController::unmarkText):
  12684. (TextInputController::hasMarkedText):
  12685. (TextInputController::markedRange):
  12686. (TextInputController::selectedRange):
  12687. (TextInputController::firstRectForCharacterRange):
  12688. (TextInputController::validAttributesForMarkedText):
  12689. (TextInputController::setComposition):
  12690. * DumpRenderTree/chromium/TextInputController.h:
  12691. (WebKit):
  12692. (TextInputController):
  12693. (TextInputController::setWebView):
  12694. 2012-07-17 David Barr <davidbarr@chromium.org>
  12695. Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
  12696. https://bugs.webkit.org/show_bug.cgi?id=89055
  12697. Reviewed by Kent Tamura.
  12698. The css3-images module is at candidate recommendation.
  12699. http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
  12700. Add a configuration option for CSS image-orientation support, disabling it by default.
  12701. * Scripts/webkitperl/FeatureList.pm:
  12702. * qmake/mkspecs/features/features.pri:
  12703. 2012-07-16 Adam Barth <abarth@webkit.org>
  12704. [Chromium] Move Task.(cpp|h) into TestRunner.a
  12705. https://bugs.webkit.org/show_bug.cgi?id=91446
  12706. Reviewed by Ryosuke Niwa.
  12707. Task is a dependency of EventSender, which needs to move into TestRunner.a.
  12708. * DumpRenderTree/DumpRenderTree.gypi:
  12709. * DumpRenderTree/chromium/TestRunner/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/Task.cpp.
  12710. * DumpRenderTree/chromium/TestRunner/Task.h: Renamed from Tools/DumpRenderTree/chromium/Task.h.
  12711. 2012-07-16 Adam Barth <abarth@webkit.org>
  12712. [Chromium] Move AccessibilityController and AccessibilityUIElement into TestRunner.a
  12713. https://bugs.webkit.org/show_bug.cgi?id=91443
  12714. Reviewed by Tony Chang.
  12715. Purely a file move (and a sorting of #includes).
  12716. * DumpRenderTree/DumpRenderTree.gypi:
  12717. * DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.cpp.
  12718. * DumpRenderTree/chromium/TestRunner/AccessibilityController.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.h.
  12719. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.cpp.
  12720. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.h.
  12721. 2012-07-16 Adam Barth <abarth@webkit.org>
  12722. [Chromium] AccessibilityController shouldn't know anything about TestShell
  12723. https://bugs.webkit.org/show_bug.cgi?id=91441
  12724. Reviewed by Tony Chang.
  12725. This patch is a precursor to moving AccessibilityController.cpp into TestRunner.a.
  12726. * DumpRenderTree/chromium/AccessibilityController.cpp:
  12727. (AccessibilityController::AccessibilityController):
  12728. (AccessibilityController::getFocusedElement):
  12729. (AccessibilityController::getRootElement):
  12730. * DumpRenderTree/chromium/AccessibilityController.h:
  12731. (WebKit):
  12732. (AccessibilityController):
  12733. (AccessibilityController::setWebView):
  12734. * DumpRenderTree/chromium/TestShell.cpp:
  12735. (TestShell::initialize):
  12736. (TestShell::createMainWindow):
  12737. (TestShell::~TestShell):
  12738. 2012-07-16 Adam Barth <abarth@webkit.org>
  12739. [Chromium] Introduce TestInterfaces to hold all the JavaScript interfaces needed for LayoutTests
  12740. https://bugs.webkit.org/show_bug.cgi?id=91312
  12741. Reviewed by Ryosuke Niwa.
  12742. Looking forward to moving more objects into TestRunner.a, we're going
  12743. to need an object to own all the interfaces and to put them through
  12744. their lifecycle.
  12745. * DumpRenderTree/DumpRenderTree.gypi:
  12746. * DumpRenderTree/chromium/TestShell.cpp:
  12747. (TestShell::initialize):
  12748. (TestShell::resetTestController):
  12749. (TestShell::bindJSObjectsToWindow):
  12750. * DumpRenderTree/chromium/TestShell.h:
  12751. (TestShell):
  12752. * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: Added.
  12753. * DumpRenderTree/chromium/TestRunner/TestInterfaces.h: Added.
  12754. 2012-07-16 Ryuan Choi <ryuan.choi@samsung.com>
  12755. [EFL][WK2] Add APIs to support theme.
  12756. https://bugs.webkit.org/show_bug.cgi?id=90107
  12757. Reviewed by Hajime Morita.
  12758. Override default theme path for MiniBrowser and WebKitTestRunner.
  12759. * MiniBrowser/efl/CMakeLists.txt:
  12760. * MiniBrowser/efl/main.c:
  12761. (browserCreate):
  12762. * WebKitTestRunner/PlatformEfl.cmake:
  12763. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
  12764. (WTR::PlatformWebView::PlatformWebView):
  12765. 2012-07-16 Ryuan Choi <ryuan.choi@samsung.com>
  12766. [EFL][DRT] Implement dumpFrameScrollPosition
  12767. https://bugs.webkit.org/show_bug.cgi?id=87638
  12768. Reviewed by Hajime Morita.
  12769. * DumpRenderTree/efl/DumpRenderTree.cpp:
  12770. (dumpFrameScrollPosition): Implemented.
  12771. (shouldDumpFrameScrollPosition): Fixed wrong condition like other ports.
  12772. 2012-07-16 Don Olmstead <don.olmstead@am.sony.com>
  12773. NRWRT Should provide a VS project to work on
  12774. https://bugs.webkit.org/show_bug.cgi?id=91436
  12775. Reviewed by Dirk Pranke.
  12776. Adding VS2010 project for modifying webkitpy. Uses pytools
  12777. <http://pytools.codeplex.com> which integrates python into
  12778. Visual Studio.
  12779. * Scripts/webkitpy/webkitpy.pyproj: Added.
  12780. * Scripts/webkitpy/webkitpy.sln: Added.
  12781. 2012-07-16 Adam Barth <abarth@webkit.org>
  12782. [Chromium] Move GamepadController into TestRunner.a
  12783. https://bugs.webkit.org/show_bug.cgi?id=91311
  12784. Reviewed by Tony Chang.
  12785. GamepadController looks like a simple class to move into TestRunner.a
  12786. because it has almost zero dependence on TestShell.
  12787. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  12788. * DumpRenderTree/DumpRenderTree.gypi:
  12789. * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.cpp.
  12790. * DumpRenderTree/chromium/TestRunner/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.h.
  12791. * DumpRenderTree/chromium/TestRunner/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/CppVariant.cpp.
  12792. * DumpRenderTree/chromium/TestRunner/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/CppVariant.h.
  12793. - GamepadController depends on these bindings helpers.
  12794. * DumpRenderTree/chromium/TestRunner/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/GamepadController.cpp.
  12795. * DumpRenderTree/chromium/TestRunner/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/GamepadController.h.
  12796. - Just moved these files and removed the unused TestShell
  12797. references.
  12798. * DumpRenderTree/chromium/TestRunner/Stub.cpp: Removed.
  12799. - No longer needed.
  12800. * DumpRenderTree/chromium/TestShell.cpp:
  12801. - Update call to constructor to avoid passing in this.
  12802. 2012-07-16 Xianzhu Wang <wangxianzhu@chromium.org>
  12803. [Chromium-android] Don't use test_shell mode of DRT
  12804. https://bugs.webkit.org/show_bug.cgi?id=88542
  12805. Reviewed by Dirk Pranke.
  12806. Test shell mode is about to be removed.
  12807. Switch to use DRT mode for chromium-android.
  12808. Summary of changes:
  12809. 1. ChromiumAndroidDriver now inherits from WebKitDriver instead of ChromiumDriver (to be deprecated).
  12810. 2. Conforms to the DRT mode protocol for input/output of DumpRenderTree.
  12811. 3. Added support for Android 'adb shell' input/output (base64, newline mode, etc.)
  12812. * DumpRenderTree/chromium/TestEventPrinter.cpp:
  12813. (DRTPrinter::handleImage): Outputs base64 on Android.
  12814. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  12815. (platformInit): Changed err_file to err_fifo, required by python ServerProcess.
  12816. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  12817. (ChromiumAndroidPort.__init__):
  12818. (ChromiumAndroidPort.create_driver): Override to create driver without DriverProxy to ensure 1 Driver per run.
  12819. (ChromiumAndroidDriver):
  12820. (ChromiumAndroidDriver.__init__):
  12821. (ChromiumAndroidDriver.cmd_line):
  12822. (ChromiumAndroidDriver._deadlock_detector):
  12823. (ChromiumAndroidDriver._drt_cmd_line):
  12824. (ChromiumAndroidDriver.start):
  12825. (ChromiumAndroidDriver._start):
  12826. (ChromiumAndroidDriver._start_once):
  12827. (ChromiumAndroidDriver.run_test):
  12828. (ChromiumAndroidDriver.stop):
  12829. (ChromiumAndroidDriver._command_from_driver_input):
  12830. (ChromiumAndroidDriver._read_prompt):
  12831. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  12832. (ChromiumAndroidPortTest.test_driver_cmd_line):
  12833. (ChromiumAndroidDriverTest.test_cmd_line):
  12834. (ChromiumAndroidDriverTest):
  12835. (ChromiumAndroidDriverTest.test_drt_cmd_line):
  12836. (ChromiumAndroidDriverTest.test_read_prompt):
  12837. (ChromiumAndroidDriverTest.test_command_from_driver_input):
  12838. (ChromiumAndroidDriverTest.test_write_command_and_read_line):
  12839. * Scripts/webkitpy/layout_tests/port/server_process.py:
  12840. (ServerProcess.__init__): Added universal_newlines to handle Android 'adb shell' line ends.
  12841. (ServerProcess._start):
  12842. (ServerProcess._wait_for_data_and_update_buffers_using_select): Handles unexpected EOF which indicates crash on Android.
  12843. (ServerProcess.stop): Added kill_directly parameter to kill the process without waiting it (which always timeouts for Android).
  12844. (ServerProcess.replace_outputs): Added to combine different input/output pipes into one ServerProcess.
  12845. * Scripts/webkitpy/layout_tests/port/webkit.py:
  12846. (WebKitDriver._command_from_driver_input):
  12847. (WebKitDriver.run_test): Changed timeout origin so that slow start() on Android won't cause timeout of layout test case.
  12848. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  12849. (MockServerProcess.read_stdout):
  12850. (MockServerProcess.start):
  12851. (MockServerProcess):
  12852. (MockServerProcess.stop):
  12853. (MockServerProcess.kill):
  12854. (WebKitDriverTest.test_read_block):
  12855. (WebKitDriverTest.test_read_binary_block):
  12856. (WebKitDriverTest.test_read_base64_block):
  12857. 2012-07-16 Dirk Pranke <dpranke@chromium.org>
  12858. nrwt: move a bunch of printing code from manager.py to printing.py
  12859. https://bugs.webkit.org/show_bug.cgi?id=91439
  12860. Reviewed by Ojan Vafai.
  12861. All of the logic that handles what gets logged should eventually
  12862. live in printing.py; this patch moves a large chunk of code that
  12863. prints all of the stuff after the run completes.
  12864. There are no functional changes, this is just moving code
  12865. around. Covered by existing tests (updated as necessary).
  12866. This code is all pretty messy and most of it should be deleted
  12867. (or extracted after the fact from results.json), but I'm saving
  12868. that for further patches. My goal is just to manager.py to a
  12869. more manageable state.
  12870. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12871. (Manager.prepare_lists_and_print_output):
  12872. (Manager.run):
  12873. (Manager._mark_interrupted_tests_as_skipped):
  12874. (Manager._update_summary_with_result):
  12875. (Manager._num_digits):
  12876. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  12877. (ManagerTest.test_interrupt_if_at_failure_limits):
  12878. (ResultSummaryTest.summarized_results):
  12879. * Scripts/webkitpy/layout_tests/models/result_summary.py:
  12880. (ResultSummary.__init__):
  12881. (ResultSummary.add):
  12882. Here we had to add a list of the slow tests to the result
  12883. summary so that we didn't need to call back into the manager and
  12884. the test expectations object to figure out if a test is SLOW.
  12885. * Scripts/webkitpy/layout_tests/views/printing.py:
  12886. (Printer.print_results):
  12887. (Printer):
  12888. (Printer._print_timing_statistics):
  12889. (Printer._print_aggregate_test_statistics):
  12890. (Printer._print_individual_test_times):
  12891. (Printer._print_test_list_timing):
  12892. (Printer._print_directory_timings):
  12893. (Printer._print_statistics_for_test_timings):
  12894. (Printer._print_result_summary):
  12895. (Printer._print_result_summary_entry):
  12896. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  12897. (Testprinter.test_print_unexpected_results.get_unexpected_results):
  12898. (Testprinter):
  12899. 2012-07-16 Adam Barth <abarth@webkit.org>
  12900. [Chromium] Create a stub TestRunner.a target
  12901. https://bugs.webkit.org/show_bug.cgi?id=91309
  12902. Reviewed by Ryosuke Niwa.
  12903. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  12904. * DumpRenderTree/DumpRenderTree.gypi:
  12905. * DumpRenderTree/chromium/TestRunner/Stub.cpp: Added.
  12906. 2012-07-16 Dirk Pranke <dpranke@chromium.org>
  12907. test-webkitpy: clean up logging to make it ninja-esque
  12908. https://bugs.webkit.org/show_bug.cgi?id=91297
  12909. Reviewed by Adam Barth.
  12910. This patch changes the output of test-webkitpy to be closer to
  12911. what ninja produces. Namely:
  12912. If you are running with stderr writing to a tty (and not -v), we
  12913. will no longer print '...' as tests complete. Instead, we use a
  12914. metered stream and print entries of the form:
  12915. '[X/Y] test_name passed/failed/erred'
  12916. where X is the current test # and Y is the total number of tests.
  12917. If you are running with stderr piped to a file or other non-tty
  12918. object (or with -v), you get the same output, one per line for
  12919. every test.
  12920. In addition, if tests fail or err out, you get the stack trace
  12921. immediately; you don't have to wait until the end of the run.
  12922. Lastly, this change cleans up the unit tests for test-webkitpy
  12923. itself to not confuse the logger and to work cleanly w/ multiple
  12924. processes. It looks like between this and all the clean up in
  12925. MessagePool that happened as it landed, we can now run
  12926. multiprocessing tests in parallel.
  12927. * Scripts/webkitpy/test/finder.py:
  12928. (Finder._default_names):
  12929. * Scripts/webkitpy/test/finder_unittest.py:
  12930. (FinderTest.setUp):
  12931. (FinderTest.tearDown):
  12932. * Scripts/webkitpy/test/printer.py:
  12933. (Printer.__init__):
  12934. (Printer.configure):
  12935. (Printer.print_started_test):
  12936. (Printer.print_finished_test):
  12937. (Printer._test_line):
  12938. (Printer.print_result):
  12939. * Scripts/webkitpy/test/runner.py:
  12940. (Runner.run):
  12941. * Scripts/webkitpy/test/runner_unittest.py:
  12942. (RunnerTest.setUp):
  12943. (RunnerTest):
  12944. (RunnerTest.tearDown):
  12945. (RunnerTest.assert_run):
  12946. (RunnerTest.test_regular):
  12947. (RunnerTest.test_verbose):
  12948. (RunnerTest.test_timing):
  12949. 2012-07-16 Dirk Pranke <dpranke@chromium.org>
  12950. test-webkitpy: handle failures properly when running in parallel
  12951. https://bugs.webkit.org/show_bug.cgi?id=91416
  12952. Reviewed by Adam Barth.
  12953. It turns out that unittest.TestResults contain a handle to the
  12954. test method itself, which isn't picklable; it's sufficient to just
  12955. store the test name instead of the actual method. By doing so
  12956. we can move the test_name() method from the printer to the
  12957. runner where it belongs (so the printer is less dependent on the
  12958. unittest framework's data structures).
  12959. This change should really have a test but I don't know how to
  12960. write one that properly captures the behavior and won't cause
  12961. test-webkitpy itself to fail. I've verified the fix by hand, at
  12962. least, in the meantime.
  12963. * Scripts/webkitpy/test/printer.py:
  12964. (Printer.__init__):
  12965. (Printer.print_result):
  12966. * Scripts/webkitpy/test/runner.py:
  12967. (_test_name):
  12968. (Runner.all_test_names):
  12969. (_Worker.handle):
  12970. 2012-07-16 Dirk Pranke <dpranke@chromium.org>
  12971. test-webkitpy: handle failures properly when running in parallel
  12972. https://bugs.webkit.org/show_bug.cgi?id=91416
  12973. Reviewed by Tony Chang.
  12974. It turns out that unittest.TestResults contain a handle to the
  12975. test method itself, which isn't picklable; it's sufficient to just
  12976. store the test name instead of the actual method. By doing so
  12977. we can move the test_name() method from the printer to the
  12978. runner where it belongs (so the printer is less dependent on the
  12979. unittest framework's data structures).
  12980. This change should really have a test but I don't know how to
  12981. write one that properly captures the behavior and won't cause
  12982. test-webkitpy itself to fail. I've verified the fix by hand, at
  12983. least, in the meantime.
  12984. * Scripts/webkitpy/test/printer.py:
  12985. (Printer.__init__):
  12986. (Printer.print_result):
  12987. * Scripts/webkitpy/test/runner.py:
  12988. (_test_name):
  12989. (Runner.all_test_names):
  12990. (_Worker.handle):
  12991. 2012-07-16 Dirk Pranke <dpranke@chromium.org>
  12992. test-webkitpy: run tests in parallel
  12993. https://bugs.webkit.org/show_bug.cgi?id=91294
  12994. Reviewed by Ojan Vafai.
  12995. This change adds support for running tests in parallel. This is
  12996. not yet on by default, since the logging isn't very pretty w/
  12997. parallel tests.
  12998. Also, there are some (multiprocessing-related) tests that can't be
  12999. run in parallel and so we skip them in that situation; I need to
  13000. come up with a mechanism for dealing with this, since you
  13001. apparently can't use multiprocessing as both a parent and a
  13002. child process.
  13003. * Scripts/webkitpy/test/finder.py:
  13004. (Finder.find_names):
  13005. (Finder._default_names):
  13006. * Scripts/webkitpy/test/main.py:
  13007. (Tester._parse_args):
  13008. (Tester.run):
  13009. * Scripts/webkitpy/test/main_unittest.py:
  13010. (TesterTest.test_no_tests_found):
  13011. * Scripts/webkitpy/test/runner.py:
  13012. (Runner.run):
  13013. * Scripts/webkitpy/test/runner_unittest.py:
  13014. (RunnerTest.test_regular):
  13015. (RunnerTest.test_verbose):
  13016. (RunnerTest.test_timing):
  13017. 2012-07-16 Dirk Pranke <dpranke@chromium.org>
  13018. test-webkitpy: use message pools
  13019. https://bugs.webkit.org/show_bug.cgi?id=91292
  13020. Reviewed by Ojan Vafai.
  13021. Restructure the test-running code to be message-driven and
  13022. use a MessagePool; note that this does not yet actually run the
  13023. tests in parallel.
  13024. Also clean up the unit tests so that the fake loader is passed
  13025. to the _Worker properly, and reduce a lot of the cut&pasted code
  13026. in the tests.
  13027. No functional changes; covered by existing tests.
  13028. * Scripts/webkitpy/test/printer.py:
  13029. (Printer.print_started_test):
  13030. (Printer.print_finished_test):
  13031. * Scripts/webkitpy/test/runner.py:
  13032. (Runner.__init__):
  13033. (Runner.run):
  13034. (Runner.handle):
  13035. (_Worker):
  13036. (_Worker.__init__):
  13037. (_Worker.handle):
  13038. * Scripts/webkitpy/test/runner_unittest.py:
  13039. (RunnerTest.assert_run):
  13040. (RunnerTest.test_regular):
  13041. (RunnerTest.test_verbose):
  13042. (RunnerTest.test_timing):
  13043. 2012-07-16 Simon Hausmann <simon.hausmann@nokia.com>
  13044. [Qt] Fix Qt5 module dependencies
  13045. https://bugs.webkit.org/show_bug.cgi?id=91388
  13046. Reviewed by Laszlo Gombos.
  13047. Removed ancient qtscript and qtxmlpatterns module dependencies.
  13048. * qmake/qt_webkit.pri:
  13049. 2012-07-16 Thiago Marcos P. Santos <thiago.santos@intel.com>
  13050. run-webkit-test returns 254 at exit even when it succeeds
  13051. https://bugs.webkit.org/show_bug.cgi?id=91370
  13052. Reviewed by Simon Hausmann.
  13053. sys.exit() is implemented by raising SystemExit which inherits from
  13054. BaseException. Since we are catching BaseException, run_webkit_tests.py
  13055. was always returning an error code.
  13056. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  13057. 2012-07-15 Carlos Garcia Campos <cgarcia@igalia.com>
  13058. Unreviewed. Fix make distcheck.
  13059. * GNUmakefile.am: Add missing file to compilation.
  13060. 2012-07-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  13061. Unreviewed. Add EFLWebKit2PublicAPI, EFLWebKit2PlatformSpecific to watch list.
  13062. * Scripts/webkitpy/common/config/watchlist:
  13063. 2012-07-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  13064. Unreviewed. Add gyuyoung.kim@samsung.com to watch list.
  13065. * Scripts/webkitpy/common/config/watchlist:
  13066. 2012-07-15 Joseph Pecoraro <pecoraro@apple.com>
  13067. Windowless WebView not firing JavaScript load event if there is a media element
  13068. https://bugs.webkit.org/show_bug.cgi?id=91331
  13069. Reviewed by Eric Carlson.
  13070. Test a windowless WebView loading a page with a media element. The load
  13071. event should happen on the next spin of the run loop, but we spin check
  13072. the page, with a timeout of 250ms.
  13073. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  13074. * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.html: Added.
  13075. * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm: Added.
  13076. (-[WindowlessWebViewWithMediaFrameLoadDelegate webView:didFinishLoadForFrame:]):
  13077. (TestWebKitAPI::spinLoop): Spin check with timeout. Runs a block each spin to early bail.
  13078. (TestWebKitAPI::TEST):
  13079. 2012-07-14 Benjamin Poulain <bpoulain@apple.com>
  13080. [Mac] Do not try to update the cache model for every WebPreferences change
  13081. https://bugs.webkit.org/show_bug.cgi?id=91302
  13082. Reviewed by Joseph Pecoraro.
  13083. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  13084. * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
  13085. (TestWebKitAPI):
  13086. (TestWebKitAPI::TEST):
  13087. 2012-07-14 Sheriff Bot <webkit.review.bot@gmail.com>
  13088. Unreviewed, rolling out r122665.
  13089. http://trac.webkit.org/changeset/122665
  13090. https://bugs.webkit.org/show_bug.cgi?id=91321
  13091. Broke Mac builds (Requested by rniwa on #webkit).
  13092. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  13093. * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Removed.
  13094. 2012-07-13 Benjamin Poulain <bpoulain@apple.com>
  13095. [Mac] Do not try to update the cache model for every WebPreferences change
  13096. https://bugs.webkit.org/show_bug.cgi?id=91302
  13097. Reviewed by Joseph Pecoraro.
  13098. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  13099. * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
  13100. (TestWebKitAPI):
  13101. (TestWebKitAPI::TEST):
  13102. 2012-07-13 Dirk Pranke <dpranke@chromium.org>
  13103. run-webkit-test outputs the wrong number of tests executed when some are skipped.
  13104. https://bugs.webkit.org/show_bug.cgi?id=89894
  13105. Reviewed by Ojan Vafai.
  13106. Fix the logging of the actual number of tests run so that tests
  13107. that are skipped aren't included.
  13108. Also revamp the 'expected' output so we distinguish the number
  13109. of tests found from the number of tests run (to account for
  13110. --repeat-each and --iterations).
  13111. Covered by existing tests.
  13112. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  13113. (Manager.prepare_lists_and_print_output):
  13114. (Manager._log_num_workers):
  13115. (Manager.run):
  13116. (Manager._print_result_summary):
  13117. * Scripts/webkitpy/layout_tests/models/result_summary.py:
  13118. (ResultSummary.__init__):
  13119. (ResultSummary.add):
  13120. * Scripts/webkitpy/layout_tests/views/printing.py:
  13121. (Printer.print_one_line_summary):
  13122. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  13123. (Testprinter.test_print_one_line_summary):
  13124. 2012-07-13 Dirk Pranke <dpranke@chromium.org>
  13125. nrwt: actually print the exception name and message for otherwise unhandled exceptions
  13126. https://bugs.webkit.org/show_bug.cgi?id=91305
  13127. Reviewed by Adam Barth.
  13128. Two more places where I was printing the stack trace but not the
  13129. exception itself :(. These two spots can't easily be
  13130. unit-tested, but I tested them by hand.
  13131. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  13132. (run):
  13133. (main):
  13134. 2012-07-13 Josh Hawn <jhawn@apple.com>
  13135. Fix for WebContext::getWebCoreStatistics() causes crash if no m_process
  13136. https://bugs.webkit.org/show_bug.cgi?id=91116
  13137. Reviewed by Simon Fraser.
  13138. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  13139. Added new test file.
  13140. * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Added.
  13141. (TestWebKitAPI::wkContextGetStatisticsCallback):
  13142. Tests that callback function receives an error.
  13143. (TestWebKitAPI::TEST):
  13144. Creates a dummy web context object (no web process).
  13145. Calls WKContextGetStatistics with the web context and test callback.
  13146. The test callback should get an expected error.
  13147. 2012-07-13 Dirk Pranke <dpranke@chromium.org>
  13148. test-webkitpy: move printing-related code out of the runner
  13149. https://bugs.webkit.org/show_bug.cgi?id=91289
  13150. Reviewed by Ryosuke Niwa.
  13151. More refactoring ... this moves all printing-related stuff out
  13152. of runner.py and into printer.py.
  13153. No functional changes; covered by existing tests.
  13154. * Scripts/webkitpy/test/main.py:
  13155. (Tester._run_tests):
  13156. * Scripts/webkitpy/test/printer.py:
  13157. (Printer.__init__):
  13158. (Printer):
  13159. (Printer.test_name):
  13160. (Printer.print_started_test):
  13161. (Printer.print_finished_test):
  13162. (Printer.print_result):
  13163. * Scripts/webkitpy/test/runner.py:
  13164. (Runner.__init__):
  13165. (Runner.all_test_names):
  13166. (Runner.run):
  13167. * Scripts/webkitpy/test/runner_unittest.py:
  13168. (RunnerTest.test_regular):
  13169. (RunnerTest.test_verbose):
  13170. (RunnerTest.test_timing):
  13171. 2012-07-13 Dirk Pranke <dpranke@chromium.org>
  13172. webkitpy: split printing/logging code for test-webkitpy out into a new class
  13173. https://bugs.webkit.org/show_bug.cgi?id=91282
  13174. Reviewed by Ojan Vafai.
  13175. This patch is the first step at splitting all of the
  13176. printing/logging code out separately from the actual
  13177. test-running code.
  13178. This is just moving stuff around; no new functionality and no
  13179. new tests needed.
  13180. * Scripts/webkitpy/test/finder_unittest.py:
  13181. (FinderTest.setUp):
  13182. * Scripts/webkitpy/test/main.py:
  13183. (Tester.__init__):
  13184. (Tester._parse_args):
  13185. (Tester.run):
  13186. (Tester._run_tests):
  13187. (Tester._log_exception):
  13188. * Scripts/webkitpy/test/main_unittest.py:
  13189. (TesterTest.test_no_tests_found):
  13190. * Scripts/webkitpy/test/printer.py: Added.
  13191. (Printer):
  13192. (Printer.__init__):
  13193. (Printer.configure):
  13194. (Printer.configure.filter):
  13195. (_CaptureAndPassThroughStream):
  13196. (_CaptureAndPassThroughStream.__init__):
  13197. (_CaptureAndPassThroughStream.write):
  13198. (_CaptureAndPassThroughStream._message_is_from_pdb):
  13199. (_CaptureAndPassThroughStream.flush):
  13200. (_CaptureAndPassThroughStream.getvalue):
  13201. 2012-07-13 James Simonsen <simonjam@chromium.org>
  13202. [Navigation Timing] Imported W3C tests contain duplicates and are DOS formatted
  13203. https://bugs.webkit.org/show_bug.cgi?id=91184
  13204. Reviewed by Adam Barth.
  13205. The upstream 'html5' tests are just duplicates of the 'html' tests.
  13206. * Scripts/import-w3c-performance-wg-tests:
  13207. 2012-07-13 Dirk Pranke <dpranke@chromium.org>
  13208. webkitpy: hide yield_to_caller from callers in MessagePool :)
  13209. https://bugs.webkit.org/show_bug.cgi?id=91269
  13210. Reviewed by Adam Barth.
  13211. yield_to_caller() was an optimization/hack to allow us to run
  13212. both manager and worker in a single process/loop without
  13213. starving the manager while the worker is running tests. The
  13214. worker was required to call yield_to_caller() periodically. It
  13215. turns out that I can get equivalent responsiveness by yielding
  13216. inside the MessagePool every time the worker posts a message, and this
  13217. allows me to no longer need the worker to call the routine. Thus
  13218. I rename yield_to_caller() to _yield_to_manager() to be a little
  13219. clearer about its purpose.
  13220. Tested by existing tests.
  13221. * Scripts/webkitpy/common/message_pool.py:
  13222. (_Worker.run):
  13223. (_Worker.post):
  13224. (_Worker._yield_to_manager):
  13225. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  13226. (Worker.handle):
  13227. 2012-07-13 Adam Barth <abarth@webkit.org>
  13228. EWSTools should be able to build a commit-queue instance from scratch
  13229. https://bugs.webkit.org/show_bug.cgi?id=91264
  13230. Reviewed by Eric Seidel.
  13231. I've been using this script to build commit-queue instances on Google
  13232. Compute Engine and it seems to work.
  13233. * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Added.
  13234. 2012-07-13 Dirk Pranke <dpranke@chromium.org>
  13235. webkitpy: make worker.start() and worker.stop() optional in the messagepool
  13236. https://bugs.webkit.org/show_bug.cgi?id=91170
  13237. Reviewed by Ojan Vafai.
  13238. test-webkitpy will use messagepool workers that don't actually
  13239. have any per-worker state, so they don't need start() and stop()
  13240. methods. Now we will only call the methods if they exist; this
  13241. means that workers only need to expose a handle() method.
  13242. * Scripts/webkitpy/common/message_pool.py:
  13243. (_Worker.terminate):
  13244. (_Worker.run):
  13245. 2012-07-13 Dirk Pranke <dpranke@chromium.org>
  13246. NRWT doesn't print exceptions
  13247. https://bugs.webkit.org/show_bug.cgi?id=91129
  13248. Reviewed by Ojan Vafai.
  13249. Although we printed exceptions in most cases, if an unexpected
  13250. exception (like a runtime error) was raised when creating a
  13251. port, we wouldn't. This patch fixes that, and also cleans up
  13252. how we were logging exceptions from the workers to be less
  13253. verbose.
  13254. Because of the corner cases where these errors are occurring,
  13255. it's difficult to write automated unit tests for them. I've
  13256. tested it quite a bit by hand, though.
  13257. * Scripts/webkitpy/common/message_pool.py:
  13258. (_MessagePool._close):
  13259. (_MessagePool._handle_worker_exception):
  13260. (_Worker.run):
  13261. (_Worker._raise):
  13262. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  13263. (Manager._run_tests):
  13264. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  13265. (main):
  13266. 2012-07-13 Wei James <james.wei@intel.com>
  13267. enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
  13268. https://bugs.webkit.org/show_bug.cgi?id=91194
  13269. Reviewed by Adam Barth.
  13270. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  13271. 2012-07-13 Simon Pena <spena@igalia.com>
  13272. [GTK] Gardening: update API tests skipped list
  13273. https://bugs.webkit.org/show_bug.cgi?id=91224
  13274. Unreviewed gardening.
  13275. Skip "next" and "previous" tests of FindController until bug #91083
  13276. is fixed.
  13277. * gtk/run-api-tests:
  13278. (TestRunner):
  13279. 2012-07-13 Zeno Albisser <zeno@webkit.org>
  13280. [Qt][WK2] Implement GraphicsSurface for Linux/GLX.
  13281. https://bugs.webkit.org/show_bug.cgi?id=90881
  13282. Enable GraphicsSurface for Linux based platforms
  13283. whenever the Xcomposite extension is available.
  13284. Reviewed by Noam Rosenthal.
  13285. * qmake/config.tests/libXcomposite/libXcomposite.cpp: Added.
  13286. (main):
  13287. * qmake/config.tests/libXcomposite/libXcomposite.pro: Added.
  13288. Add a configure test to detect Xcomposite extension and
  13289. activate GraphicsSurface on linux in case the extension is available.
  13290. * qmake/configure.pri:
  13291. * qmake/mkspecs/features/features.prf:
  13292. 2012-07-13 David Grogan <dgrogan@chromium.org>
  13293. nrwt: don't choke when printing invalid utf-8 to stderr
  13294. https://bugs.webkit.org/show_bug.cgi?id=91181
  13295. Reviewed by Dirk Pranke.
  13296. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  13297. (TestResultWriter.write_stderr):
  13298. 2012-07-13 Dirk Pranke <dpranke@chromium.org>
  13299. test-webkitpy: more class renaming cleanup
  13300. https://bugs.webkit.org/show_bug.cgi?id=91182
  13301. Reviewed by Adam Barth.
  13302. More removing of the unnecessary "Test" prefix.
  13303. * Scripts/webkitpy/test/finder.py:
  13304. (_DirectoryTree):
  13305. (Finder.add_tree):
  13306. * Scripts/webkitpy/test/main.py:
  13307. (Tester._run_tests):
  13308. * Scripts/webkitpy/test/runner.py:
  13309. (Runner):
  13310. * Scripts/webkitpy/test/runner_unittest.py:
  13311. (RunnerTest.test_regular):
  13312. (RunnerTest.test_verbose):
  13313. (RunnerTest.test_timing):
  13314. 2012-07-12 Christophe Dumez <christophe.dumez@intel.com>
  13315. [WK2][EFL] Facilitate debugging of the Web Process
  13316. https://bugs.webkit.org/show_bug.cgi?id=90768
  13317. Reviewed by Kenneth Rohde Christiansen.
  13318. Add a new --webprocess-cmd-prefix argument to
  13319. run-webkit-tests script for EFL port. If provided,
  13320. the prefix will be prepended to the command used
  13321. to spawn the Web process. This can be used for
  13322. debugging purposes with prefixes such as:
  13323. "xterm -title renderer -e gdb --args".
  13324. * Scripts/webkitpy/layout_tests/port/efl.py:
  13325. (EflPort.__init__):
  13326. (EflPort.setup_environ_for_server):
  13327. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  13328. (parse_args):
  13329. * WebKitTestRunner/efl/TestControllerEfl.cpp:
  13330. (WTR::TestController::platformRunUntil): Implement support for
  13331. m_noTimeout timeout value.
  13332. 2012-07-12 Adam Barth <abarth@webkit.org>
  13333. Fix crash in the commit-queue. We need to initialize self.port during __init__.
  13334. * Scripts/webkitpy/tool/commands/queues.py:
  13335. (CommitQueue.__init__):
  13336. (CommitQueue.begin_work_queue):
  13337. 2012-07-12 Dirk Pranke <dpranke@chromium.org>
  13338. test-webkitpy: rename test_finder to finder
  13339. https://bugs.webkit.org/show_bug.cgi?id=91175
  13340. Reviewed by Adam Barth.
  13341. Rename test_finder -> finder, TestFinder -> Finder to remove
  13342. some of the stutter in the names.
  13343. * Scripts/webkitpy/test/finder.py: Renamed from Tools/Scripts/webkitpy/test/test_finder.py.
  13344. * Scripts/webkitpy/test/finder_unittest.py: Renamed from Tools/Scripts/webkitpy/test/test_finder_unittest.py.
  13345. * Scripts/webkitpy/test/main.py:
  13346. (Tester.__init__):
  13347. 2012-07-12 Adam Barth <abarth@webkit.org>
  13348. CommitQueue is confused about what port it is using
  13349. https://bugs.webkit.org/show_bug.cgi?id=91040
  13350. Reviewed by Dirk Pranke.
  13351. On EC2, we explicitly pass --port to the commit-queue, but that
  13352. requires editing the start-queue.sh script locally on each bot. In
  13353. moving to Google Compute Engine, we're try to avoid any local edits to
  13354. the EWSTools.
  13355. Rather than passing --port to the commit-queue, this patch teaches the
  13356. CommitQueue which port its running, which is the approach we use for
  13357. the EWS bots.
  13358. Mutating tool._deprecated_port is a bit ugly, but it's what we're doing
  13359. currently for the EWS bots.
  13360. * Scripts/webkitpy/tool/commands/queues.py:
  13361. (CommitQueue):
  13362. (CommitQueue.begin_work_queue):
  13363. (CommitQueue.run_command):
  13364. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  13365. (CommitQueueTest.test_commit_queue):
  13366. (mock_run_webkit_patch):
  13367. (test_rollout):
  13368. (test_rollout_lands):
  13369. (test_manual_reject_during_processing):
  13370. 2012-07-12 James Simonsen <simonjam@chromium.org>
  13371. [Navigation Timing] Import the W3C Navigation Timing test suite
  13372. https://bugs.webkit.org/show_bug.cgi?id=84887
  13373. Reviewed by Tony Gentilcore.
  13374. * Scripts/import-w3c-performance-wg-tests: Added.
  13375. 2012-07-12 Adam Barth <abarth@webkit.org>
  13376. Unreviewed. Nit: git config files use tabs, not spaces.
  13377. * EWSTools/cold-boot.sh:
  13378. 2012-07-12 Kwang Yul Seo <skyul@company100.net>
  13379. Unreviewed. Add Dongsung Huang to the list of contributors. He
  13380. has submitted over 30 patches on texture mapper, canvas and image decoders.
  13381. * Scripts/webkitpy/common/config/committers.py:
  13382. 2012-07-12 Kwang Yul Seo <skyul@company100.net>
  13383. Unreviewed. Change my irc nickname to kseo.
  13384. * Scripts/webkitpy/common/config/committers.py:
  13385. 2012-07-12 Dirk Pranke <dpranke@chromium.org>
  13386. webkitpy: clean up logging handlers, lint common.message_pool
  13387. https://bugs.webkit.org/show_bug.cgi?id=91152
  13388. Reviewed by Ojan Vafai.
  13389. The unix implementation of multiprocessing clones any logging
  13390. handlers from the parent process into the child; we currently
  13391. don't want this behavior in our code, so I was hand-removing the
  13392. installed handlers in the child process I knew about. After thinking
  13393. about it further, I think it was simpler and safe enough to just
  13394. remove all handlers in the child, since the message pool
  13395. propagates any message from the child back into the parent.
  13396. We can always change this in the future if it turns out to be an issue.
  13397. I'm also fixing a couple of other lint warnings while I'm at it.
  13398. * Scripts/webkitpy/common/message_pool.py:
  13399. (_MessagePool.__exit__):
  13400. (_MessagePool._handle_worker_exception):
  13401. (_Worker._set_up_logging):
  13402. 2012-07-12 Dirk Pranke <dpranke@chromium.org>
  13403. webkitpy: rename manager_worker_broker to message_pool
  13404. https://bugs.webkit.org/show_bug.cgi?id=91145
  13405. Reviewed by Ojan Vafai.
  13406. Since the MessagePool interface is more generic (and simpler)
  13407. now and will be reused by test-webkitpy, I'm renaming it and
  13408. moving it to webkitpy.common.
  13409. * Scripts/webkitpy/common/message_pool.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py.
  13410. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  13411. (TestRunInterruptedException.__reduce__):
  13412. (Manager._run_tests.worker_factory):
  13413. (Manager._run_tests):
  13414. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  13415. 2012-07-12 Dirk Pranke <dpranke@chromium.org>
  13416. nrwt crashes saving the output for a platform-specific expected test reference
  13417. https://bugs.webkit.org/show_bug.cgi?id=90872
  13418. Reviewed by Ojan Vafai.
  13419. The expected output for a test is copied alongside the test
  13420. itself in the layout-test-results directory; in other words, for
  13421. foo/bar-expected.txt sits alongside foo/bar.html even if we're
  13422. actually using platform/mac/foo/bar-expected.txt.
  13423. Unless the test is a reftest, in which case we would copy the
  13424. output to platform/mac/foo/bar-expected.html and set a
  13425. 'ref_file' parameter in results.json to indicate the path. This
  13426. can be useful in the cases where we have multiple references for
  13427. a single test or when multiple tests share the same reference.
  13428. We found a bug where we weren't creating platform/mac/foo under
  13429. the results directory, and so this wasn't actually working.
  13430. However, treating reftests differently seems like a bad thing,
  13431. so we should probably be consistent. This change puts the
  13432. -expected.html next to the test, and reworks test_result_writer
  13433. so that we create directories uniformly and consistently.
  13434. Note that we weren't catching this problem in unit tests because
  13435. the MockFileSystem creates a directory automatically if it
  13436. doesn't exist; this was done intentionally for convenience, but
  13437. is really a bug and should be fixed; see https://bugs.webkit.org/show_bug.cgi?id=91028.
  13438. I have not added additional tests here since fixing that bug
  13439. should be sufficient.
  13440. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  13441. (interpret_test_failures):
  13442. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  13443. (ResultSummaryTest.test_interpret_test_failures):
  13444. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  13445. (write_test_result):
  13446. (TestResultWriter._write_binary_file):
  13447. (TestResultWriter):
  13448. (TestResultWriter._write_text_file):
  13449. (TestResultWriter.write_output_files):
  13450. (TestResultWriter.write_stderr):
  13451. (TestResultWriter.write_crash_log):
  13452. (TestResultWriter.create_text_diff_and_write_result):
  13453. (TestResultWriter.write_image_diff_files):
  13454. (write_reftest):
  13455. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  13456. (EndToEndTest.test_reftest_with_two_notrefs):
  13457. 2012-07-12 Dirk Pranke <dpranke@chromium.org>
  13458. nrwt: reimplement manager_worker_broker in a much simpler form
  13459. https://bugs.webkit.org/show_bug.cgi?id=90513
  13460. Reviewed by Ojan Vafai.
  13461. This is a wholesale replacement of the MessagePool() implementation
  13462. and the other classes in manager_worker_broker.py. All of the
  13463. BrokerConnection*, Broker*, etc. classes are gone, and there are now
  13464. just a MessagePool class and a _Worker class. Happiness ensues.
  13465. I'm removing manager_worker_broker_unittest.py as well; we get
  13466. nearly complete coverage from the integration tests, and will
  13467. get more coverage when test-webkitpy moves to use this as well,
  13468. so having unit tests seems like unnecessary overhead. (running
  13469. coverage numbers with test-webkitpy shows that pretty much the only
  13470. uncovered lines are lines that are only run in the child processes,
  13471. which coverage doesn't handle at the moment).
  13472. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  13473. (_MessagePool.__init__):
  13474. (_MessagePool.run):
  13475. (_MessagePool._start_workers):
  13476. (_MessagePool):
  13477. (_MessagePool.wait):
  13478. (_MessagePool._close):
  13479. (_MessagePool._handle_done):
  13480. (_MessagePool._can_pickle):
  13481. (_MessagePool._loop):
  13482. (WorkerException):
  13483. (_Message.__init__):
  13484. (_Message.__repr__):
  13485. (_Worker):
  13486. (_Worker.__init__):
  13487. (_Worker.terminate):
  13488. (_Worker._close):
  13489. (_Worker.run):
  13490. (_Worker.post):
  13491. (_Worker.yield_to_caller):
  13492. (_Worker._post):
  13493. (_Worker._raise):
  13494. (_Worker._set_up_logging):
  13495. (_WorkerLogHandler.__init__):
  13496. (_WorkerLogHandler.emit):
  13497. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Removed.
  13498. 2012-07-12 Tony Chang <tony@chromium.org>
  13499. [chromium] Remove drag and drop API methods that are no longer used
  13500. https://bugs.webkit.org/show_bug.cgi?id=90996
  13501. Reviewed by Adam Barth.
  13502. Migrate DRT to use the methods that take modifier keys.
  13503. * DumpRenderTree/chromium/EventSender.cpp:
  13504. (EventSender::doDragDrop):
  13505. (EventSender::doMouseUp):
  13506. (EventSender::doMouseMove):
  13507. (EventSender::beginDragWithFiles):
  13508. 2012-07-12 Ojan Vafai <ojan@chromium.org>
  13509. Allow putting ranges in user.py list prompts
  13510. https://bugs.webkit.org/show_bug.cgi?id=91115
  13511. Reviewed by Adam Barth.
  13512. Ranges are inclusive and denoted by a dash. This is useful for rebaselining a whole port
  13513. since the items are listed with each port's builders being contiguous.
  13514. * Scripts/webkitpy/common/system/user.py:
  13515. (User._wait_on_list_response):
  13516. * Scripts/webkitpy/common/system/user_unittest.py:
  13517. (UserTest.test_prompt_with_multiple_lists.run_prompt_test):
  13518. (UserTest.test_prompt_with_multiple_lists):
  13519. 2012-07-12 Arnaud Renevier <arno@renevier.net>
  13520. [GTK] Implement disableImageLoading in DRT
  13521. https://bugs.webkit.org/show_bug.cgi?id=87973
  13522. Reviewed by Martin Robinson.
  13523. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  13524. (resetDefaultsToConsistentValues):
  13525. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  13526. (LayoutTestController::disableImageLoading):
  13527. 2012-07-12 Simon Hausmann <simon.hausmann@nokia.com>
  13528. [Qt] Internal symbols are exported on Linux
  13529. https://bugs.webkit.org/show_bug.cgi?id=90981
  13530. Reviewed by Jocelyn Turcotte.
  13531. I should've re-enabled ELF symbol visibility when removing the symbol map in
  13532. r106650.
  13533. * qmake/mkspecs/features/default_post.prf:
  13534. 2012-07-11 Mark Rowe <mrowe@apple.com>
  13535. <http://webkit.org/b/91024> Build against the latest SDK when targeting older OS X versions.
  13536. Reviewed by Dan Bernstein.
  13537. The deployment target is already set to the version that we're targeting, and it's that setting
  13538. which determines which functionality from the SDK is available to us.
  13539. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  13540. * TestWebKitAPI/Configurations/Base.xcconfig:
  13541. * WebKitTestRunner/Configurations/Base.xcconfig:
  13542. 2012-07-11 Mark Rowe <mrowe@apple.com>
  13543. Replace definitions of BUILDING_ON / TARGETING macros with macros that will error when used.
  13544. Part of <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros.
  13545. Reviewed by Anders Carlsson.
  13546. * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Remove the macros completely from here since
  13547. they're completely unused in TestNetscapePlugIn.
  13548. * DumpRenderTree/config.h:
  13549. 2012-07-11 Mark Rowe <mrowe@apple.com>
  13550. <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros
  13551. This removal was handled by a script that translates the relevant macros in to the equivalent checks
  13552. using the system availability macros.
  13553. Reviewed by Filip Pizlo.
  13554. * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
  13555. * DumpRenderTree/mac/CheckedMalloc.cpp:
  13556. * DumpRenderTree/mac/DumpRenderTree.mm:
  13557. * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  13558. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  13559. * DumpRenderTree/mac/TextInputController.m:
  13560. * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
  13561. * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  13562. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  13563. 2012-07-11 Robert Kroeger <rjkroege@chromium.org>
  13564. Suppress horizontal conversion of PlatformWheelEvents when hasPreciseScrollingDeltas is true
  13565. https://bugs.webkit.org/show_bug.cgi?id=89580
  13566. WebKit GTK and Chromium Linux force vertical wheel events to
  13567. scroll horizontally when over horizontal scroll bars. This is
  13568. undesirable for touchpad scrolling with
  13569. hasPreciseScrollingDeltas() == true. Modified DumpRenderTree to
  13570. let a layout test specify this attribute so that the change's impact
  13571. on scrolling can be tested in a layout test.
  13572. Reviewed by Adam Barth.
  13573. * DumpRenderTree/chromium/EventSender.cpp:
  13574. (EventSender::handleMouseWheel):
  13575. 2012-07-11 Simon Fraser <simon.fraser@apple.com>
  13576. Fix the build by declaring -isPaginated before use.
  13577. * MiniBrowser/mac/BrowserWindowController.m:
  13578. 2012-07-11 Sheriff Bot <webkit.review.bot@gmail.com>
  13579. Unreviewed, rolling out r122358.
  13580. http://trac.webkit.org/changeset/122358
  13581. https://bugs.webkit.org/show_bug.cgi?id=91037
  13582. Build break on WebKit Win (Requested by hayato on #webkit).
  13583. * DumpRenderTree/chromium/EventSender.cpp:
  13584. (EventSender::doDragDrop):
  13585. (EventSender::doMouseUp):
  13586. (EventSender::doMouseMove):
  13587. (EventSender::beginDragWithFiles):
  13588. 2012-07-03 Dirk Pranke <dpranke@chromium.org>
  13589. nrwt: add a MessagePool abstraction that the manager will call to replace the broker
  13590. https://bugs.webkit.org/show_bug.cgi?id=90511
  13591. Reviewed by Ojan Vafai.
  13592. This change introduces the new MessagePool abstraction that will
  13593. replace the classes in manager_worker_broker. It is a minimal
  13594. interface that tries to follow the conventions in
  13595. multiprocessing.Pool and concurrency.futures ... it provides a
  13596. context manager and a run() method that sends N messages to M
  13597. workers processes (starting workers as necessary) and waits for
  13598. them all to complete, handling cleanup as necessary. The caller
  13599. is responsible for providing a handle() method to handle
  13600. messages received from the workers.
  13601. This interface basically hides all of the multiprocessing logic from
  13602. the manager class.
  13603. The initial implementation of MessagePool is a simple shim
  13604. around the existing broker classes; a subsequent change will
  13605. replace all the other classes with a much simpler
  13606. implementation.
  13607. No additional tests are provided for now; existing tests should
  13608. provide adequate coverage, and I will add new unit tests for the
  13609. MessagePool class when I replace the existing implementation.
  13610. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  13611. (TestRunInterruptedException.__reduce__):
  13612. (Manager.__init__):
  13613. (Manager._run_tests):
  13614. (Manager._run_tests.instead):
  13615. (Manager.handle):
  13616. (Manager._handle_started_test):
  13617. (Manager._handle_finished_test_list):
  13618. (Manager._handle_finished_test):
  13619. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  13620. (get):
  13621. (_MessagePool):
  13622. (_MessagePool.__init__):
  13623. (_MessagePool.__enter__):
  13624. (_MessagePool.__exit__):
  13625. (_MessagePool.run):
  13626. (_MessagePool.wait):
  13627. (_MessagePool.is_done):
  13628. (_MessagePool._worker_is_done):
  13629. (_MessagePool._close):
  13630. (_MessagePool.handle_done):
  13631. (_MessagePool.handle_started_test):
  13632. (_MessagePool.handle_finished_test):
  13633. (_MessagePool.handle_finished_test_list):
  13634. (_MessagePool.handle_exception):
  13635. (_MessagePool._log_messages):
  13636. (_MessagePool._handle_worker_exception):
  13637. (_WorkerState):
  13638. (_WorkerState.for):
  13639. (_WorkerState.__init__):
  13640. (_WorkerState.__repr__):
  13641. (_get_broker):
  13642. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  13643. (make_broker):
  13644. 2012-07-11 Simon Fraser <simon.fraser@apple.com>
  13645. Add an option to enter paginated mode in MiniBrowser
  13646. https://bugs.webkit.org/show_bug.cgi?id=91035
  13647. Reviewed by Dan Bernstein.
  13648. Add an item to the Debug menu for MiniBrowser that puts
  13649. the web view into paginated mode. For now, we only
  13650. do left-to-right pagination, with a fixed column width.
  13651. * MiniBrowser/mac/BrowserWindowController.h:
  13652. * MiniBrowser/mac/BrowserWindowController.m:
  13653. (-[BrowserWindowController validateMenuItem:]): Update the checked
  13654. state of the menu item.
  13655. (-[BrowserWindowController isPaginated]): Return YES if paginated.
  13656. (-[BrowserWindowController togglePaginationMode:]): Toggle in
  13657. and out of pagination mode.
  13658. * MiniBrowser/mac/MainMenu.xib: Add the debug menu item.
  13659. 2012-07-11 Adam Barth <abarth@webkit.org>
  13660. commit-queue instances on Compute Engine are missing git-svn
  13661. https://bugs.webkit.org/show_bug.cgi?id=91034
  13662. Reviewed by Eric Seidel.
  13663. git-svn is needed to actually commit to SVN from a git working copy.
  13664. * EWSTools/cold-boot.sh:
  13665. 2012-07-11 Dirk Pranke <dpranke@chromium.org>
  13666. webkitpy: lint code in webkitpy.layout_tests.models
  13667. https://bugs.webkit.org/show_bug.cgi?id=90416
  13668. Reviewed by Ojan Vafai.
  13669. Cleaning up errors reported from lint-webkitpy.
  13670. Also, suppress the warnings about wildcard imports in pylintrc;
  13671. we have nothing particularly against them.
  13672. * Scripts/webkitpy/layout_tests/models/test_configuration.py:
  13673. (TestConfigurationConverter.combinations):
  13674. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
  13675. (TestConfigurationTest.test_hash.query_unknown_key):
  13676. (TestConfigurationTest.test_eq):
  13677. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  13678. (ParseError.__init__):
  13679. (TestExpectationLine.__init__):
  13680. (TestExpectationsModel.get_expectations_string):
  13681. (TestExpectationsModel):
  13682. (TestExpectationsModel.expectation_to_string):
  13683. (TestExpectationsModel.add_expectation_line):
  13684. (TestExpectationsModel._clear_expectations_for_test):
  13685. (TestExpectationsModel._remove_from_sets):
  13686. (TestExpectations.get_expectations_string):
  13687. (TestExpectations.expectation_to_string):
  13688. (TestExpectations._report_warnings):
  13689. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  13690. (Base.__init__):
  13691. (parse_exp):
  13692. (SkippedTests.check):
  13693. (TestExpectationParserTests.test_parse_empty_string):
  13694. * Scripts/webkitpy/layout_tests/models/test_failures.py:
  13695. (FailureTimeout.__init__):
  13696. (FailureCrash.__init__):
  13697. (FailureImageHashMismatch.__init__):
  13698. (FailureReftestMismatch.__init__):
  13699. (FailureReftestMismatchDidNotOccur.__init__):
  13700. (FailureReftestNoImagesGenerated.__init__):
  13701. * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
  13702. (TestFailuresTest.test_unknown_failure_type.UnknownFailure.message):
  13703. (TestFailuresTest.test_unknown_failure_type):
  13704. (TestFailuresTest):
  13705. (TestFailuresTest.test_message_is_virtual):
  13706. * Scripts/webkitpy/layout_tests/models/test_results.py:
  13707. (TestResult.loads):
  13708. (TestResult.has_failure_matching_types):
  13709. * Scripts/webkitpy/pylintrc:
  13710. 2012-07-11 Dirk Pranke <dpranke@chromium.org>
  13711. nrwt: clean up names in worker.py
  13712. https://bugs.webkit.org/show_bug.cgi?id=90510
  13713. Reviewed by Ojan Vafai.
  13714. This is the last patch in the series of refactoring worker.py;
  13715. all this does is change some names of methods, instance
  13716. variables, and method parameters to be clearer (it also changes
  13717. some code in manager.py and manager_worker.py to be consistent).
  13718. There are no functional changes in this patch and the existing
  13719. tests should cover everything.
  13720. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  13721. (Manager.__init__):
  13722. (Manager.prepare_lists_and_print_output):
  13723. (Manager._run_tests.worker_factory):
  13724. (Manager._run_tests):
  13725. (Manager._show_results_html_file):
  13726. (Manager.handle_finished_test_list):
  13727. (_WorkerState.__init__):
  13728. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  13729. (_Broker.post_message):
  13730. (_Broker._dispatch_message):
  13731. (AbstractWorker.__init__):
  13732. (AbstractWorker.run):
  13733. (AbstractWorker.yield_to_caller):
  13734. (AbstractWorker.post):
  13735. (_WorkerConnection.__init__):
  13736. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  13737. (_TestWorker.__init__):
  13738. (_TestWorker.start):
  13739. (_TestWorker.handle):
  13740. (_TestWorker.stop):
  13741. (_TestsMixin):
  13742. (_TestsMixin.test_name):
  13743. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  13744. (Worker.__init__):
  13745. (Worker.__del__):
  13746. (Worker.start):
  13747. (Worker.handle):
  13748. (Worker._run_test):
  13749. (Worker.stop):
  13750. (Worker._timeout):
  13751. (Worker._kill_driver):
  13752. (Worker._run_test_with_timeout):
  13753. (Worker._clean_up_after_test):
  13754. (Worker._run_test_in_another_thread.SingleTestThread.run):
  13755. (Worker._run_test_in_this_thread):
  13756. (Worker._run_single_test):
  13757. 2012-07-11 Adam Barth <abarth@webkit.org>
  13758. The commit-queue needs some extra git config to be able to commit
  13759. https://bugs.webkit.org/show_bug.cgi?id=91025
  13760. Reviewed by Eric Seidel.
  13761. In order for the commit-queue to actually commit, it needs to know the
  13762. location of the SVN server.
  13763. * EWSTools/cold-boot.sh:
  13764. 2012-07-11 Adam Barth <abarth@webkit.org>
  13765. Teach EWSTools how to configure SVN auth credentials
  13766. https://bugs.webkit.org/show_bug.cgi?id=91021
  13767. Reviewed by Eric Seidel.
  13768. To move the commit-queue over to Google Compute Engine, we need a way
  13769. to configure the commit-queue's credentials during the machine build
  13770. process. There doesn't seem to be a nice command line way of
  13771. configuring SVN auth credentials. I tried doing a bogus commit and
  13772. supplying the credentials that way, but that's super hacky.
  13773. The approach in this patch is to write the config file directly. The
  13774. format of these configurations files is documented in the SVN book, so
  13775. this approach doesn't see too sketchy.
  13776. * EWSTools/configure-svn-auth.sh: Added.
  13777. 2012-07-11 Ojan Vafai <ojan@chromium.org>
  13778. Dedupe suffixes passed to webkit-patch rebaseline
  13779. https://bugs.webkit.org/show_bug.cgi?id=91017
  13780. Reviewed by Dirk Pranke.
  13781. * Scripts/webkitpy/tool/commands/rebaseline.py:
  13782. (Rebaseline._suffixes_to_update):
  13783. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  13784. (test_rebaseline_multiple_builders_and_tests_command_line):
  13785. 2012-07-11 Kevin Ollivier <kevino@theolliviers.com>
  13786. [wx] Unreviewed build fix. Add new directories and a new LayoutTestController method.
  13787. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  13788. (LayoutTestController::setStorageDatabaseIdleInterval):
  13789. * waf/build/settings.py:
  13790. 2012-07-11 Tony Chang <tony@chromium.org>
  13791. [chromium] Remove drag and drop API methods that are no longer used
  13792. https://bugs.webkit.org/show_bug.cgi?id=90996
  13793. Reviewed by Adam Barth.
  13794. Migrate DRT to use the methods that take modifier keys.
  13795. * DumpRenderTree/chromium/EventSender.cpp:
  13796. (EventSender::doDragDrop):
  13797. (EventSender::doMouseUp):
  13798. (EventSender::doMouseMove):
  13799. (EventSender::beginDragWithFiles):
  13800. 2012-07-11 Mark Rowe <mrowe@apple.com>
  13801. Add a Mountain Lion version of libWebKitSystemInterface.a.
  13802. Reviewed by John Sullivan.
  13803. * Scripts/copy-webkitlibraries-to-product-directory: Include libWebKitSystemInterfaceMountainLion.a in the list of libraries to copy.
  13804. 2012-07-09 Mark Rowe <mrowe@apple.com>
  13805. <http://webkit.org/b/90835> Teach bisect-builds to work with a Safari.app that has entitlements.
  13806. Reviewed by Dan Bernstein.
  13807. * Scripts/bisect-builds: Use safariPathFromSafariBundle to determine which binary within the application
  13808. should be invoked.
  13809. 2012-07-11 Zan Dobersek <zandobersek@gmail.com>
  13810. [Gtk] fast/events/keydown-function-keys.html is failing
  13811. https://bugs.webkit.org/show_bug.cgi?id=90891
  13812. Reviewed by Martin Robinson.
  13813. Work around the context menu being shown on F10 key being pressed by
  13814. unbiding the key when running tests in DumpRenderTree. The problem
  13815. appears when using a recent version of the xkeyboard-config package.
  13816. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  13817. (setDefaultsToConsistentStateValuesForTesting):
  13818. 2012-07-11 No'am Rosenthal <noam.rosenthal@nokia.com>
  13819. [Qt] QRawWebView should notify when rendering is done, so that pixel results can be grabbed at the appropriate moment.
  13820. https://bugs.webkit.org/show_bug.cgi?id=90641
  13821. Reviewed by Jocelyn Turcotte.
  13822. * MiniBrowser/qt/raw/View.h: Comment used old class name (WKView).
  13823. (View):
  13824. 2012-07-11 Min Qin <qinmin@chromium.org>
  13825. [Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
  13826. https://bugs.webkit.org/show_bug.cgi?id=90831
  13827. Reviewed by Adam Barth.
  13828. On android, DRT needs to run in a background thread to avoid ANR.
  13829. However, the java tests are running on UI thread by default.
  13830. We need to send an intent extra to the apk so that it can run on a sub thread.
  13831. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  13832. (ChromiumAndroidDriver._start_once):
  13833. 2012-07-11 Csaba Osztrogonác <ossy@webkit.org>
  13834. [Qt] REGRESSION(r107171): Fix --timeout option of Qt's DRT
  13835. https://bugs.webkit.org/show_bug.cgi?id=90966
  13836. Reviewed by Ryosuke Niwa.
  13837. * DumpRenderTree/qt/main.cpp:
  13838. (main): Don't remove the argument, because takeOptionValue() did it before.
  13839. 2012-07-11 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  13840. First commit; moving myself to commiters.
  13841. Unreviewed.
  13842. * Scripts/webkitpy/common/config/committers.py:
  13843. 2012-07-11 Balazs Ankes <bank@inf.u-szeged.hu>
  13844. webkit-patch land should automatically add svn:mime-type for .png files
  13845. https://bugs.webkit.org/show_bug.cgi?id=75825
  13846. Reviewed by Dirk Pranke.
  13847. Refactor the png.py to avoid code duplication.
  13848. * Scripts/webkitpy/common/checksvnconfigfile.py: Added.
  13849. (check):
  13850. (config_file_path):
  13851. (errorstr_autoprop):
  13852. (errorstr_png):
  13853. * Scripts/webkitpy/style/checkers/png.py:
  13854. (PNGChecker.check):
  13855. * Scripts/webkitpy/tool/commands/download.py:
  13856. (Land):
  13857. * Scripts/webkitpy/tool/steps/__init__.py:
  13858. * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
  13859. (AddSvnMimetypeForPng):
  13860. (AddSvnMimetypeForPng.__init__):
  13861. (AddSvnMimetypeForPng.run):
  13862. (AddSvnMimetypeForPng._check_pngs):
  13863. * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
  13864. (MockSCMDetector):
  13865. (MockSCMDetector.__init__):
  13866. (MockSCMDetector.display_name):
  13867. (AddSvnMimetypeForPngTest):
  13868. (AddSvnMimetypeForPngTest.test_run):
  13869. 2012-07-11 Hayato Ito <hayato@chromium.org>
  13870. Unreviewed gardening.
  13871. One more fix for r122292.
  13872. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  13873. 2012-07-11 Sheriff Bot <webkit.review.bot@gmail.com>
  13874. Unreviewed, rolling out r122301.
  13875. http://trac.webkit.org/changeset/122301
  13876. https://bugs.webkit.org/show_bug.cgi?id=90947
  13877. Android builder started to fail (Requested by hayato on
  13878. #webkit).
  13879. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  13880. 2012-07-10 Adam Barth <abarth@webkit.org>
  13881. [Chromium] Merge final nits to DumpRenderTree.gyp for Android
  13882. https://bugs.webkit.org/show_bug.cgi?id=90920
  13883. Reviewed by Tony Chang.
  13884. This patch contains the last few small changes to DumpRenderTree.gyp
  13885. from the chromium-android branch. After this change, this file will be
  13886. fully merged.
  13887. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  13888. 2012-07-10 Adam Barth <abarth@webkit.org>
  13889. [Chromium-Android] Add apk test targets for webkit_unit_tests and TestWebKitAPI
  13890. https://bugs.webkit.org/show_bug.cgi?id=90918
  13891. Reviewed by Tony Chang.
  13892. The rules are similar to what we have added for DumpRenderTree apk.
  13893. All references to gtest_target_type can be removed once we enable APK
  13894. tests on the all bots.
  13895. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  13896. 2012-07-10 Kenneth Russell <kbr@google.com>
  13897. Add --no-build option to perf test runner
  13898. https://bugs.webkit.org/show_bug.cgi?id=90916
  13899. Reviewed by Ryosuke Niwa.
  13900. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  13901. (PerfTestsRunner._parse_args):
  13902. Support --no-build option to perf tests, as in layout tests.
  13903. 2012-07-10 Adam Barth <abarth@webkit.org>
  13904. EWSTools should be able to build a chromium-ews bot from scratch
  13905. https://bugs.webkit.org/show_bug.cgi?id=90912
  13906. Reviewed by Eric Seidel.
  13907. I've been using this script to kick off the build process for the
  13908. chromium-ews bots on Google Compute Engine.
  13909. * EWSTools/GoogleComputeEngine: Added.
  13910. * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Added.
  13911. 2012-07-10 Alec Flett <alecflett@chromium.org>
  13912. Add alecflett to the list of committers
  13913. https://bugs.webkit.org/show_bug.cgi?id=90903
  13914. Reviewed by Ojan Vafai.
  13915. * Scripts/webkitpy/common/config/committers.py:
  13916. 2012-07-10 Xianzhu Wang <wangxianzhu@chromium.org>
  13917. Unreviewed fix of webkitpy unittest break about chromium_android.py
  13918. caused by r122251.
  13919. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  13920. (ChromiumAndroidDriverTest.test_cmd_line):
  13921. 2012-07-10 Ojan Vafai <ojan@chromium.org>
  13922. webkit-patch rebaseline doesn't work for audio/pixel tests
  13923. https://bugs.webkit.org/show_bug.cgi?id=90905
  13924. Reviewed by Adam Barth.
  13925. We just need to pass the correct suffix list to rebaseline-test-internal
  13926. and optimize-baselines. By default, pass all suffixes.
  13927. * Scripts/webkitpy/tool/commands/rebaseline.py:
  13928. (Rebaseline):
  13929. (Rebaseline.__init__):
  13930. (Rebaseline._suffixes_to_update):
  13931. (Rebaseline.execute):
  13932. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  13933. (test_rebaseline_multiple_builders_and_tests_command_line):
  13934. 2012-07-10 Adam Barth <abarth@webkit.org>
  13935. Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
  13936. https://bugs.webkit.org/show_bug.cgi?id=90853
  13937. Reviewed by Eric Seidel.
  13938. WebKit no longer implements the Hixie76 version of the WebSocket
  13939. protocol. We don't need to support it in our test framework.
  13940. * DumpRenderTree/chromium/LayoutTestController.cpp:
  13941. (LayoutTestController::overridePreference):
  13942. * DumpRenderTree/chromium/WebPreferences.cpp:
  13943. (WebPreferences::reset):
  13944. (WebPreferences::applyTo):
  13945. * DumpRenderTree/chromium/WebPreferences.h:
  13946. (WebPreferences):
  13947. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  13948. (resetDefaultsToConsistentValues):
  13949. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  13950. (LayoutTestController::overridePreference):
  13951. * DumpRenderTree/mac/DumpRenderTree.mm:
  13952. (resetDefaultsToConsistentValues):
  13953. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  13954. (WebCore::WebPage::resetSettings):
  13955. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  13956. (LayoutTestController::overridePreference):
  13957. * DumpRenderTree/win/DumpRenderTree.cpp:
  13958. (resetDefaultsToConsistentValues):
  13959. 2012-07-10 Xianzhu Wang <wangxianzhu@chromium.org>
  13960. [Chromium-Android] Fix typos in chromium_android.py in r151492
  13961. https://bugs.webkit.org/show_bug.cgi?id=90904
  13962. Reviewed by Ojan Vafai.
  13963. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  13964. (ChromiumAndroidPort.setup_test_run):
  13965. 2012-07-10 Xianzhu Wang <wangxianzhu@chromium.org>
  13966. [Chromium-Android] Use setup_test_runner() instead of start_helper() to setup test environment
  13967. https://bugs.webkit.org/show_bug.cgi?id=90894
  13968. Reviewed by Adam Barth.
  13969. start_helper() is actually start_pixel_test_helper() since r115601 (bug 81729).
  13970. Should use setup_test_runner() to setup test environment for chromium-android.
  13971. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  13972. (ChromiumAndroidPort.setup_test_run): Renamed from start_helper(). Added cache cleanup code.
  13973. (ChromiumAndroidPort.clean_up_test_run): Renamed from stop_helper().
  13974. (ChromiumAndroidPort._path_to_helper): Returns None as we don't have a helper now.
  13975. (ChromiumAndroidPort):
  13976. (ChromiumAndroidPort._path_to_forwarder): Original _path_to_helper().
  13977. (ChromiumAndroidPort._push_executable):
  13978. (ChromiumAndroidDriver.__init__):
  13979. (ChromiumAndroidDriver.cmd_line):
  13980. 2012-07-09 Ojan Vafai <ojan@chromium.org>
  13981. Improve webkit-patch rebaseline to work for more cases
  13982. https://bugs.webkit.org/show_bug.cgi?id=90504
  13983. Reviewed by Adam Barth.
  13984. -Makes it work for the build.chromium.org bots.
  13985. -Lets you rebaseline all builders instead of just one.
  13986. -Lets you pass in the builders or tests to rebaseline.
  13987. * Scripts/webkitpy/common/host.py:
  13988. (Host.buildbot_for_builder_name):
  13989. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  13990. (Builder.__init__):
  13991. (Builder.latest_layout_test_results):
  13992. Provide a way to get to the LayoutTestResults of the latest build.
  13993. Most of the time we only need to get the latest one and the Chromium bots
  13994. only expose the full_results.json file for the latest build.
  13995. (Builder):
  13996. (Builder._fetch_file_from_results):
  13997. (Builder.fetch_layout_test_results):
  13998. Move these functions into Builder so that Builder and Build can both
  13999. fetch layout test results.
  14000. (Build.results_zip_url):
  14001. (Build.layout_test_results):
  14002. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  14003. (BuilderTest.test_latest_layout_test_results):
  14004. (BuildTest.test_layout_test_results):
  14005. * Scripts/webkitpy/common/system/user.py:
  14006. (User.prompt_with_multiple_lists):
  14007. Prompt with multiple sublists, but still have a global numbering.
  14008. This lets the build.chromium.org bots be clearly separated from the
  14009. build.webkit.org bots, which helps understand the builder names.
  14010. (User):
  14011. (User._wait_on_list_response):
  14012. (User.prompt_with_list):
  14013. * Scripts/webkitpy/common/system/user_unittest.py:
  14014. (UserTest.test_prompt_with_multiple_lists):
  14015. (UserTest.test_prompt_with_multiple_lists.run_prompt_test):
  14016. (UserTest.test_prompt_with_multiple_lists.run_prompt_test.mock_raw_input):
  14017. * Scripts/webkitpy/layout_tests/port/base.py:
  14018. (Port.is_chromium):
  14019. Provide a way to tell if a port is a Chromium port that doesn't involve string
  14020. manipulation on the port name or builder name.
  14021. * Scripts/webkitpy/layout_tests/port/builders.py:
  14022. (builder_path_from_name):
  14023. (all_builder_names):
  14024. Memoizing here is incorrect because the test override _exact_matches,
  14025. so these can return different values. In either case, I'm pretty sure these
  14026. are not remotely hot codepaths. I manually inspected all call sites and they're
  14027. all in high-level calls (e.g. execute calls for webkit-patch commands) and not
  14028. called in a loop.
  14029. * Scripts/webkitpy/layout_tests/port/chromium.py:
  14030. (ChromiumPort.is_chromium):
  14031. * Scripts/webkitpy/tool/commands/rebaseline.py:
  14032. (RebaselineTest._results_url):
  14033. (AbstractParallelRebaselineCommand.__init__):
  14034. (Rebaseline.__init__):
  14035. (Rebaseline):
  14036. (Rebaseline._builders_to_pull_from):
  14037. (Rebaseline._tests_to_update):
  14038. (Rebaseline.execute):
  14039. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  14040. (test_rebaseline.mock_builders_to_pull_from):
  14041. (test_rebaseline):
  14042. (test_rebaseline_command_line_flags):
  14043. (test_rebaseline_multiple_builders):
  14044. (test_rebaseline_multiple_builders.mock_builders_to_pull_from):
  14045. (test_rebaseline_multiple_builders.mock_tests_to_update):
  14046. (test_rebaseline_multiple_builders_and_tests_command_line):
  14047. * Scripts/webkitpy/tool/mocktool.py:
  14048. (MockTool.irc):
  14049. (MockTool):
  14050. (MockTool.buildbot_for_builder_name):
  14051. 2012-07-10 Alice Cheng <alice_cheng@apple.com>
  14052. Editing: Reproducible crasher when pasting a 0x0 image into Mail
  14053. https://bugs.webkit.org/show_bug.cgi?id=90640
  14054. <rdar://problem/11141920>
  14055. Reviewed by Brady Eidson.
  14056. Test cases for the patch. 0x0 images don't get a resource representation in the WebArchive, so we need a null check.
  14057. * TestWebKitAPI/Tests/mac/0.png: Added.
  14058. * TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm: Added.
  14059. (TestWebKitAPI):
  14060. (TestWebKitAPI::TEST):
  14061. 2012-07-10 Leandro Gracia Gil <leandrogracia@chromium.org>
  14062. WebSurroundingText layout tests should use the same code path as the rest of the feature.
  14063. https://bugs.webkit.org/show_bug.cgi?id=90807
  14064. Reviewed by Adam Barth.
  14065. Make the textSurroundingNode method take a pair of point coordinates
  14066. instead of a node offset.
  14067. * DumpRenderTree/chromium/LayoutTestController.cpp:
  14068. (LayoutTestController::textSurroundingNode):
  14069. * DumpRenderTree/chromium/LayoutTestController.h:
  14070. (LayoutTestController):
  14071. 2012-07-10 Csaba Osztrogonác <ossy@webkit.org>
  14072. [Qt] REGRESSION(r122175): It broke the Windows build
  14073. https://bugs.webkit.org/show_bug.cgi?id=90850
  14074. Reviewed by Noam Rosenthal.
  14075. * qmake/mkspecs/features/features.prf: Disable USE(3D_GRAPHICS) on Windows temporarily until proper fix.
  14076. 2012-07-10 János Badics <jbadics@inf.u-szeged.hu>
  14077. [Qt][NRWT] Enable cascaded TestExpectations
  14078. https://bugs.webkit.org/show_bug.cgi?id=89108
  14079. Reviewed by Dirk Pranke.
  14080. * Scripts/webkitpy/layout_tests/port/qt.py:
  14081. (QtPort.expectations_files):
  14082. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  14083. (QtPortTest._assert_expectations_files):
  14084. (QtPortTest.test_expectations_files):
  14085. 2012-07-10 Christophe Dumez <christophe.dumez@intel.com>
  14086. [EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::*
  14087. https://bugs.webkit.org/show_bug.cgi?id=90868
  14088. Unreviewed EFL build fix.
  14089. Correct CMake configuration to have EFL's DRT and WebKitTestRunner link
  14090. WTF library. This is needed to resolve undefined reference to WTF::MD5::*.
  14091. * DumpRenderTree/efl/CMakeLists.txt:
  14092. * WebKitTestRunner/PlatformEfl.cmake:
  14093. 2012-07-10 Adam Barth <abarth@webkit.org>
  14094. LayoutTestController.dumpConfigurationForViewport should move to Internals
  14095. https://bugs.webkit.org/show_bug.cgi?id=45652
  14096. Reviewed by Eric Seidel.
  14097. Remove dumpConfigurationForViewport from LayoutTestController. This API
  14098. has been replaced by an API on Internals that does the same thing in a
  14099. port-agnostic way.
  14100. * DumpRenderTree/LayoutTestController.cpp:
  14101. (LayoutTestController::staticFunctions):
  14102. * DumpRenderTree/LayoutTestController.h:
  14103. (LayoutTestController):
  14104. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  14105. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  14106. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  14107. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  14108. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  14109. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  14110. (LayoutTestController):
  14111. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  14112. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  14113. 2012-07-09 Matt Falkenhagen <falken@chromium.org>
  14114. Add ENABLE_DIALOG_ELEMENT and skeleton files
  14115. https://bugs.webkit.org/show_bug.cgi?id=90521
  14116. Reviewed by Kent Tamura.
  14117. * Scripts/webkitperl/FeatureList.pm:
  14118. 2012-07-09 Kent Tamura <tkent@chromium.org>
  14119. Improve the boilerplate generated by prepare-ChangeLog
  14120. https://bugs.webkit.org/show_bug.cgi?id=89560
  14121. Reviewed by Ryosuke Niwa.
  14122. Produce the following boilerplate:
  14123. > 2012-06-20 Kent Tamura <tkent@chromium.org>
  14124. >
  14125. > Need a short description (Oops!).
  14126. > Need the bug URL (Oops!).
  14127. >
  14128. > Reviewed by NOBODY (Oops!).
  14129. >
  14130. > Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
  14131. >
  14132. > No new tests (Oops!).
  14133. * Scripts/prepare-ChangeLog:
  14134. (generateNewChangeLogs): Generate the updated template.
  14135. * Scripts/webkitpy/common/checkout/changelog.py:
  14136. (ChangeLog.update_with_unreviewed_message):
  14137. Update the pattern for the beginning of the boilerplate.
  14138. (ChangeLog.set_short_description_and_bug_url):
  14139. - Use self._changelog_indent
  14140. - Update the pattern for the description line
  14141. - Skip the bug boilerplate.
  14142. We substitute the specified bug URL to the description boilerplate
  14143. because we need to add it even if the bug URL boilerplate is missing.
  14144. * Scripts/webkitpy/common/checkout/changelog_unittest.py: Update the boilerplate data.
  14145. (test_set_short_description_and_bug_url):
  14146. - Update the description boilerplate.
  14147. - Add a test for a case with both of the description boilerplace and the
  14148. bug URL boilerplate.
  14149. * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
  14150. (PrepareChangeLogTest.test_ensure_bug_url): Update the expected boilerplate.
  14151. 2012-07-09 No'am Rosenthal <noam.rosenthal@nokia.com>
  14152. Shared code that is guarded with ENABLE(WEBGL) should be guarded with USE()
  14153. https://bugs.webkit.org/show_bug.cgi?id=90506
  14154. Reviewed by Martin Robinson.
  14155. Always enable the WTF_USE_3D_GRAPHICS flag in features.prf if we're compiling with Qt5
  14156. or if the OpenGL module is enabled.
  14157. * qmake/mkspecs/features/features.prf:
  14158. 2012-07-09 Yongjun Zhang <yongjun_zhang@apple.com>
  14159. Consider closing unused localStorage database after a timeout.
  14160. https://bugs.webkit.org/show_bug.cgi?id=90713
  14161. For a localStorage, if there is no active document referencing to it for certain amount of time (300 seconds),
  14162. we can close the underlying sqlite database.
  14163. Reviewed by Brady Eidson.
  14164. * DumpRenderTree/LayoutTestController.cpp: add a JS method setStorageDatabaseIdleInterval to testRunner
  14165. to set a different timeout value for closing localStorage database.
  14166. (setStorageDatabaseIdleIntervalCallback):
  14167. (LayoutTestController::staticFunctions):
  14168. * DumpRenderTree/LayoutTestController.h:
  14169. (LayoutTestController):
  14170. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  14171. (LayoutTestController::setStorageDatabaseIdleInterval): add empty method.
  14172. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  14173. (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
  14174. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  14175. (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
  14176. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  14177. (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
  14178. 2012-07-09 Adam Klein <adamk@chromium.org>
  14179. Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver
  14180. https://bugs.webkit.org/show_bug.cgi?id=90810
  14181. Reviewed by Ojan Vafai.
  14182. * DumpRenderTree/gtk/EventSender.cpp:
  14183. 2012-07-09 Mihai Parparita <mihaip@chromium.org>
  14184. Handle missing results in TestResultsServer better
  14185. https://bugs.webkit.org/show_bug.cgi?id=90816
  14186. Reviewed by Ojan Vafai.
  14187. If we can't load the results JSON, don't try to wrap it with the JSONP
  14188. callback invocation.
  14189. * TestResultServer/handlers/testfilehandler.py:
  14190. (GetFile.get):
  14191. 2012-07-09 Sheriff Bot <webkit.review.bot@gmail.com>
  14192. Unreviewed, rolling out r122124.
  14193. http://trac.webkit.org/changeset/122124
  14194. https://bugs.webkit.org/show_bug.cgi?id=90815
  14195. It broke NRWT on Qt (Requested by Ossy_HOME on #webkit).
  14196. * Scripts/webkitpy/layout_tests/port/qt.py:
  14197. (QtPort._skipped_file_search_paths):
  14198. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  14199. (QtPortTest._assert_skipped_path):
  14200. (QtPortTest.test_skipped_file_search_path):
  14201. 2012-07-09 Zan Dobersek <zandobersek@gmail.com>
  14202. [Gtk] Implement dumpFrameScrollPosition in DumpRenderTree
  14203. https://bugs.webkit.org/show_bug.cgi?id=89356
  14204. Reviewed by Martin Robinson.
  14205. Implement dumpFrameScrollPosition, acquiring the scroll position
  14206. through WebKitDOMDOMWindow of the WebKitDOMDocument loaded in the frame
  14207. whose scroll position is being dumped.
  14208. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  14209. (dumpFrameScrollPosition):
  14210. 2012-07-09 János Badics <jbadics@inf.u-szeged.hu>
  14211. [Qt][NRWT] Enable cascaded TestExpectations
  14212. https://bugs.webkit.org/show_bug.cgi?id=89108
  14213. Reviewed by Dirk Pranke.
  14214. * Scripts/webkitpy/layout_tests/port/qt.py:
  14215. (QtPort.expectations_files):
  14216. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  14217. (QtPortTest._assert_expectations_files):
  14218. (QtPortTest.test_expectations_files):
  14219. 2012-07-09 Dan Bernstein <mitz@apple.com>
  14220. Fixed clean builds of the All target in the DumpRenderTree project.
  14221. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode know that the
  14222. DumpRenderTree Perl Support target depends on the DumpRenderTree target.
  14223. 2012-07-09 Zan Dobersek <zandobersek@gmail.com>
  14224. [Gtk] Unskip the CSS Regions layout tests
  14225. https://bugs.webkit.org/show_bug.cgi?id=90771
  14226. Reviewed by Martin Robinson.
  14227. Use the DumpRenderTreeSupportGtk method for enabling the CSS Regions,
  14228. calling it when resetting the defaults in DumpRenderTree or when the
  14229. settings value is overriden through the testRunner.
  14230. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  14231. (resetDefaultsToConsistentValues):
  14232. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  14233. (LayoutTestController::overridePreference):
  14234. 2012-07-09 Sheriff Bot <webkit.review.bot@gmail.com>
  14235. Unreviewed, rolling out r122107.
  14236. http://trac.webkit.org/changeset/122107
  14237. https://bugs.webkit.org/show_bug.cgi?id=90794
  14238. Build failure on Mac debug bots (Requested by falken_ on
  14239. #webkit).
  14240. * Scripts/webkitperl/FeatureList.pm:
  14241. 2012-07-09 Matt Falkenhagen <falken@chromium.org>
  14242. Add ENABLE_DIALOG_ELEMENT and skeleton files
  14243. https://bugs.webkit.org/show_bug.cgi?id=90521
  14244. Reviewed by Kent Tamura.
  14245. * Scripts/webkitperl/FeatureList.pm:
  14246. 2012-07-08 Kent Tamura <tkent@chromium.org>
  14247. Unreviewed, rolling out r122076.
  14248. http://trac.webkit.org/changeset/122076
  14249. https://bugs.webkit.org/show_bug.cgi?id=89560
  14250. Broke sheriffbot rollout
  14251. * Scripts/prepare-ChangeLog:
  14252. (generateNewChangeLogs):
  14253. 2012-07-08 Leandro Gracia Gil <leandrogracia@chromium.org>
  14254. Update the description of LayoutTestController::textSurroundingElement
  14255. https://bugs.webkit.org/show_bug.cgi?id=90620
  14256. Reviewed by Adam Barth.
  14257. Rename and fix the description of the method as its behaviour changed
  14258. during the review of https://bugs.webkit.org/show_bug.cgi?id=82461
  14259. * DumpRenderTree/chromium/LayoutTestController.cpp:
  14260. (LayoutTestController::LayoutTestController):
  14261. (LayoutTestController::textSurroundingNode):
  14262. * DumpRenderTree/chromium/LayoutTestController.h:
  14263. (LayoutTestController):
  14264. 2012-07-08 Kent Tamura <tkent@chromium.org>
  14265. Improve the template generated by prepare-ChangeLog
  14266. https://bugs.webkit.org/show_bug.cgi?id=89560
  14267. Reviewed by Ryosuke Niwa.
  14268. Produce the following template:
  14269. > 2012-06-20 Kent Tamura <tkent@chromium.org>
  14270. >
  14271. > Need a short description (Oops!).
  14272. > Need the bug URL (Oops!).
  14273. >
  14274. > Reviewed by Ryosuke Niwa.
  14275. >
  14276. > Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
  14277. >
  14278. > No new tests (Oops!).
  14279. * Scripts/prepare-ChangeLog:
  14280. (generateNewChangeLogs):
  14281. 2012-07-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  14282. [wx] Unreviewed. Fix notificaitons directory path after notifications move.
  14283. * waf/build/settings.py:
  14284. 2012-07-07 Nuno Lopes <nlopes@apple.com>
  14285. Fix build with recent clang.
  14286. https://bugs.webkit.org/show_bug.cgi?id=90712
  14287. Reviewed by Alexey Proskuryakov.
  14288. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
  14289. (DOMWindowExtensionBasic):
  14290. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
  14291. (DOMWindowExtensionNoCache):
  14292. * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
  14293. (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
  14294. 2012-07-06 Zan Dobersek <zandobersek@gmail.com>
  14295. [Gtk] Add a configuration option for disabling unstable features in releases
  14296. https://bugs.webkit.org/show_bug.cgi?id=87995
  14297. Reviewed by Martin Robinson.
  14298. Pass the --enable-unstable-features flag when building the Gtk port through build-webkit.
  14299. * Scripts/webkitdirs.pm:
  14300. (buildAutotoolsProject):
  14301. 2012-07-06 Jessie Berlin <jberlin@apple.com>
  14302. WKContext should ask for its initialization data when it needs it so the client doesn't have
  14303. to keep it up to date.
  14304. https://bugs.webkit.org/show_bug.cgi?id=90627
  14305. Reviewed by Anders Carlsson.
  14306. Add tests and update other WKContextInjectedBundleClients.
  14307. * MiniBrowser/mac/AppDelegate.m:
  14308. (-[BrowserAppDelegate init]):
  14309. Updated for the change to WKContextInjectedBundleClient.
  14310. * WebKitTestRunner/TestController.cpp:
  14311. (WTR::TestController::initialize):
  14312. Ditto.
  14313. * TestWebKitAPI/PlatformUtilities.cpp:
  14314. (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
  14315. Moved the logic to create the initialization dictionary here ...
  14316. (TestWebKitAPI::Util::createContextForInjectedBundleTest):
  14317. ... from here so that it can be used without automatically using
  14318. WKContextSetInitializationUserDataForInjectedBundle.
  14319. * TestWebKitAPI/PlatformUtilities.h:
  14320. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  14321. Add the new test files.
  14322. * TestWebKitAPI/GNUmakefile.am:
  14323. Ditto.
  14324. * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Added.
  14325. (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
  14326. Check that the message received from the injected bundle matches the user data it was
  14327. initialized with.
  14328. (TestWebKitAPI::getInjectedBundleInitializationUserData):
  14329. Return the user data that the injected bundle should be initialized with.
  14330. (TestWebKitAPI::TEST):
  14331. Set up WKContextInjectedBundleClient and load a page.
  14332. * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Added.
  14333. (TestWebKitAPI::GetInjectedBundleInitializationUserDataCallbackTest::initialize):
  14334. Send the initialization user data back up to the UI Process.
  14335. * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Added.
  14336. (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
  14337. Check that the message received from the injected bundle matches the user data it was
  14338. initialized with in the callback.
  14339. (TestWebKitAPI::getInjectedBundleInitializationUserData):
  14340. Return the user data that the injected bundle should be initialized with.
  14341. (TestWebKitAPI::TEST):
  14342. Set up the context and use WKContextSetInitializationUserDataForInjectedBundle to set the
  14343. initialization user data (which should be overridden by the user data returned in
  14344. getInjectedBundleInitializationUserData).
  14345. * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Added.
  14346. (TestWebKitAPI::InjectedBundleInitializationUserDataCallbackWinsTest::initialize):
  14347. Send the initialization user data back up to the UI Process.
  14348. 2012-07-06 Dongwoo Im <dw.im@samsung.com>
  14349. [EFL][GTK] jhbuild : Disable pixman demos build depending on GTK+
  14350. https://bugs.webkit.org/show_bug.cgi?id=90593
  14351. Reviewed by Philippe Normand.
  14352. * efl/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
  14353. * gtk/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
  14354. 2012-07-06 Luciano Wolf <luciano.wolf@openbossa.org>
  14355. [Qt] DumpRenderTree does not use 'monospace' font when directed
  14356. https://bugs.webkit.org/show_bug.cgi?id=85203
  14357. The test fonts used for Qt tests were moved to the Liberation font family.
  14358. Due to this change we are skipping tons of tests. They will be gradually
  14359. unskipped in batches, ASAP.
  14360. Also, the now unneeded special font configuration for Qt5 WK1 was removed.
  14361. Reviewed by Tor Arne Vestbø.
  14362. * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
  14363. (WebKit::initializeTestFonts):
  14364. 2012-07-06 Csaba Osztrogonác <ossy@webkit.org>
  14365. [Qt] Buildfix for newer Qt5
  14366. https://bugs.webkit.org/show_bug.cgi?id=90519
  14367. Reviewed by Tor Arne Vestbø.
  14368. * MiniBrowser/qt/MiniBrowser.pro: We also need to depend on gui-private in the MiniBrowser to get access to these headers.
  14369. * MiniBrowser/qt/MiniBrowserApplication.h: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
  14370. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
  14371. 2012-07-06 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  14372. [Qt] Make use of Qt5 qmake's changed makefile recursion behavior
  14373. When not using the -r option, qmake now interleaves qmake and make calls,
  14374. so we don't need custom logic for this. There's also an option to supress
  14375. the effect of the -r option, which we use to make WebKit.pro the only
  14376. project file parsed in a recursive qmake-run.
  14377. https://bugs.webkit.org/show_bug.cgi?id=90461
  14378. Reviewed by Tor Arne Vestbø.
  14379. * qmake/mkspecs/features/default_post.prf:
  14380. * qmake/mkspecs/features/functions.prf:
  14381. 2012-07-06 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  14382. [Qt] Remove custom qmake logic for module creation
  14383. Qmake now has the necessary hooks to cleanly override the build locations.
  14384. https://bugs.webkit.org/show_bug.cgi?id=90461
  14385. Reviewed by Tor Arne Vestbø.
  14386. * qmake/mkspecs/features/default_pre.prf:
  14387. 2012-07-06 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  14388. [Qt] Add top-level .qmake.conf
  14389. With Qt5, this makes setting $QMAKEPATH externally unnecessary.
  14390. The magic in the perl scripts to set QMAKEPATH is still there, as it doesn't
  14391. hurt, and is still required for Qt4.
  14392. https://bugs.webkit.org/show_bug.cgi?id=90461
  14393. Reviewed by Tor Arne Vestbø.
  14394. * qmake/mkspecs/features/default_pre.prf:
  14395. 2012-07-06 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  14396. [Qt] Unify qtFeatureDefaults code paths
  14397. There's no reason to run qmake on features.prf directly anymore, as we
  14398. can selectivly run configure tests in the project file now.
  14399. https://bugs.webkit.org/show_bug.cgi?id=90461
  14400. Reviewed by Tor Arne Vestbø.
  14401. * Scripts/webkitdirs.pm:
  14402. (qtFeatureDefaults):
  14403. * qmake/configure.pri:
  14404. * qmake/mkspecs/features/features.prf:
  14405. 2012-07-06 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  14406. [Qt] Don't let qt_webkit.pri proclaim its own location
  14407. This won't work any more with recent Qt5 versions, as the forwarding
  14408. pri is created by qt_module_config, which needs MODULE_PRI to be set
  14409. up already.
  14410. We also need to load build_config, not qt_module.
  14411. https://bugs.webkit.org/show_bug.cgi?id=90461
  14412. Reviewed by Tor Arne Vestbø.
  14413. * qmake/qt_webkit.pri:
  14414. 2012-07-06 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  14415. [Qt] Remove redundant CONFIG+=module
  14416. qt_module_config takes care of that.
  14417. In api.pri we are actually testing the flag ourselves, so now we need to
  14418. test a related flag qt_module_config sets instead.
  14419. Reviewed by Tor Arne Vestbø.
  14420. * qmake/mkspecs/features/default_post.prf:
  14421. 2012-07-06 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  14422. [Qt] Switch to new-style Qt 5 configure tests
  14423. Use explicit project file action instead of syncqt magic.
  14424. https://bugs.webkit.org/show_bug.cgi?id=90461
  14425. Reviewed by Tor Arne Vestbø.
  14426. * Scripts/webkitdirs.pm:
  14427. (buildQMakeProjects):
  14428. * qmake/configure.pri: Copied from Tools/qmake/configure.pro.
  14429. * qmake/configure.pro:
  14430. * qmake/mkspecs/features/default_pre.prf:
  14431. * qmake/mkspecs/features/features.prf:
  14432. * qmake/sync.profile: Removed.
  14433. 2012-07-05 Jason Liu <jason.liu@torchmobile.com.cn>
  14434. Add Jason Liu to committers.py.
  14435. https://bugs.webkit.org/show_bug.cgi?id=90654
  14436. Unreviewed.
  14437. * Scripts/webkitpy/common/config/committers.py:
  14438. 2012-07-05 Benjamin Poulain <bpoulain@apple.com>
  14439. Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
  14440. https://bugs.webkit.org/show_bug.cgi?id=90431
  14441. Reviewed by Anders Carlsson.
  14442. Add a Mac API test.
  14443. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  14444. * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html: Added.
  14445. * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm: Added.
  14446. (-[CancelLoadFromResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
  14447. (-[CancelLoadFromResourceLoadDelegateFrameLoadDelegate webView:didFinishLoadForFrame:]):
  14448. (TestWebKitAPI):
  14449. (TestWebKitAPI::TEST):
  14450. 2012-07-05 Dave Tharp <dtharp@codeaurora.org>
  14451. Adding myself as committer to committers.py
  14452. Unreviewed.
  14453. * Scripts/webkitpy/common/config/committers.py:
  14454. 2012-07-05 Alexey Proskuryakov <ap@apple.com>
  14455. [Mac][WK2] Enable HTTPS tests
  14456. https://bugs.webkit.org/show_bug.cgi?id=90600
  14457. Reviewed by Brady Eidson.
  14458. * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.
  14459. It explained why we were doing this here instead of a frame load delegate, but that's
  14460. just history, not an explanation of why we need this code.
  14461. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
  14462. Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
  14463. for tests, it seems appropriate to have platform specific solutions in every WTR,
  14464. and not add a WebKit2 API.
  14465. 2012-07-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  14466. [Qt] Remove rpath-hacks in qt_webkit.pri
  14467. Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
  14468. even if they were not using QtWebKit.
  14469. This is a regression for people who build client apps against a non-installed
  14470. QtWebKit, as the client app will be missing a rpath to the standalone WebKit
  14471. build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
  14472. logic, until the real issue is fixed in Qt.
  14473. Reviewed by Csaba Osztrogonác.
  14474. * qmake/mkspecs/features/rpath.prf:
  14475. * qmake/qt_webkit.pri:
  14476. 2012-07-05 Dongwoo Im <dw.im@samsung.com>
  14477. [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
  14478. https://bugs.webkit.org/show_bug.cgi?id=88608
  14479. Reviewed by Hajime Morita.
  14480. * Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.
  14481. 2012-07-05 Ryuan Choi <ryuan.choi@samsung.com>
  14482. [Wk2][EFL] EFL needs a WebKitTestRunner
  14483. https://bugs.webkit.org/show_bug.cgi?id=87659
  14484. Reviewed by Kenneth Rohde Christiansen.
  14485. Add an implementation of WebKitTestRunner for Efl port.
  14486. * CMakeLists.txt: Includes WebKitTestRunner build script.
  14487. * Scripts/build-webkittestrunner: Added knowledge of WebKitTestRunner/Efl.
  14488. * Scripts/webkitpy/layout_tests/port/efl.py: Ditto.
  14489. (EflPort.setup_environ_for_server):
  14490. * WebKitTestRunner/CMakeLists.txt: Added.
  14491. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  14492. * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Added.
  14493. * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
  14494. * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Added.
  14495. * WebKitTestRunner/PlatformEfl.cmake: Added.
  14496. * WebKitTestRunner/PlatformWebView.h:
  14497. * WebKitTestRunner/TestController.cpp:
  14498. * WebKitTestRunner/config.h: Added knowledge of WebKitTestRunner/Efl.
  14499. * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Added.
  14500. * WebKitTestRunner/efl/TestControllerEfl.cpp: Added.
  14501. * WebKitTestRunner/efl/main.cpp: Added.
  14502. (main):
  14503. 2012-07-05 Christophe Dumez <christophe.dumez@intel.com>
  14504. [WK2][EFL] Ewk_View needs API to load HTML data
  14505. https://bugs.webkit.org/show_bug.cgi?id=90540
  14506. Reviewed by Kenneth Rohde Christiansen.
  14507. Update EFL MiniBrowser to catch the "load,error" signal
  14508. on the view and display an error page.
  14509. * MiniBrowser/efl/main.c:
  14510. (on_error):
  14511. (browserCreate):
  14512. 2012-07-05 Sergio Villar Senin <svillar@igalia.com>
  14513. Hidden dirs are not copied when creating the built product archive
  14514. https://bugs.webkit.org/show_bug.cgi?id=90559
  14515. Reviewed by Carlos Garcia Campos.
  14516. Hidden dirs are not copied inside the built product archive
  14517. because the recursive copy command was ignoring them. We need those
  14518. hidden directories for the GTK WebKit2 testing bot to work fine.
  14519. * BuildSlaveSupport/built-product-archive:
  14520. (archiveBuiltProduct): replaced "*" by "." to include hidden
  14521. dirs/files.
  14522. 2012-07-04 Yoshifumi Inoue <yosin@chromium.org>
  14523. Unreviewed Chromium gardening, Disable always failed python tests on Windows.
  14524. https://bugs.webkit.org/show_bug.cgi?id=90587
  14525. PortTest.qt_linux and mac_lion are always failed on Chromium Windows at
  14526. creating child process.
  14527. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  14528. (PortTest.disabled_test_qt_linux):
  14529. (PortTest.disabled_test_mac_lion):
  14530. 2012-07-04 Yoshifumi Inoue <yosin@chromium.org>
  14531. [Tools] webkit_unittest.py got assertion
  14532. https://bugs.webkit.org/show_bug.cgi?id=90579
  14533. Reviewed by Hajime Morita.
  14534. This patch updates expectation of assertion in test_skipped_directories_for_symbols().
  14535. r121874 added new (exclude) directory (inspector/styles/variables), however it didn't
  14536. update one of two assertions.
  14537. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  14538. 2012-07-04 Balazs Ankes <bank@inf.u-szeged.hu>
  14539. webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
  14540. https://bugs.webkit.org/show_bug.cgi?id=67935
  14541. Reviewed by Ryosuke Niwa.
  14542. * Scripts/webkitpy/common/checkout/changelog.py:
  14543. (ChangeLog.set_reviewer):
  14544. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  14545. (test_set_reviewer):
  14546. (test_set_short_description_and_bug_url):
  14547. 2012-07-04 Sheriff Bot <webkit.review.bot@gmail.com>
  14548. Unreviewed, rolling out r121862.
  14549. http://trac.webkit.org/changeset/121862
  14550. https://bugs.webkit.org/show_bug.cgi?id=90569
  14551. It broke built-product-archive for GTK, Qt and EFL (Requested
  14552. by svillar on #webkit).
  14553. * BuildSlaveSupport/built-product-archive:
  14554. (archiveBuiltProduct):
  14555. 2012-07-04 Sergio Villar Senin <svillar@igalia.com>
  14556. Hidden dirs are not copied when creating the built product archive
  14557. https://bugs.webkit.org/show_bug.cgi?id=90559
  14558. Reviewed by Carlos Garcia Campos.
  14559. Hidden dirs are not copied inside the built product archive because
  14560. the recursive copy command was ignoring them. We need those hidden
  14561. directories for the GTK WebKit2 testing bot to work fine.
  14562. * BuildSlaveSupport/built-product-archive:
  14563. (archiveBuiltProduct): removed the trailing "*" from the copy
  14564. command.
  14565. 2012-07-04 John Mellor <johnme@chromium.org>
  14566. Text Autosizing: Add compile flag and runtime setting
  14567. https://bugs.webkit.org/show_bug.cgi?id=87394
  14568. This patch renames Font Boosting to Text Autosizing.
  14569. Reviewed by Adam Barth.
  14570. * Scripts/webkitperl/FeatureList.pm:
  14571. * qmake/mkspecs/features/features.pri:
  14572. 2012-07-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  14573. [Qt] Replace deprecated IN_PWD with PWD
  14574. Reviewed by Csaba Osztrogonác.
  14575. * qmake/mkspecs/features/default_pre.prf:
  14576. 2012-07-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  14577. [Qt] Don't try to build WTR twice
  14578. Reviewed by Csaba Osztrogonác.
  14579. * Tools.pro:
  14580. 2012-07-04 Sheriff Bot <webkit.review.bot@gmail.com>
  14581. Unreviewed, rolling out r121821.
  14582. http://trac.webkit.org/changeset/121821
  14583. https://bugs.webkit.org/show_bug.cgi?id=90551
  14584. This patch did not receive a high-quality review and has a
  14585. number of errors (Requested by abarth on #webkit).
  14586. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  14587. (Build.results_url):
  14588. * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
  14589. (ChromiumBuilder.accumulated_results_url):
  14590. * Scripts/webkitpy/layout_tests/port/builders.py:
  14591. * Scripts/webkitpy/tool/commands/rebaseline.py:
  14592. (AbstractParallelRebaselineCommand.__init__):
  14593. (Rebaseline):
  14594. (Rebaseline._builder_to_pull_from):
  14595. (Rebaseline._tests_to_update):
  14596. (Rebaseline.execute):
  14597. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  14598. (test_rebaseline.mock_builder_to_pull_from):
  14599. (test_rebaseline):
  14600. 2012-07-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  14601. [Qt] Get rid of un-needed QT += declarative for Qt 5
  14602. The declarative module has been renamed to quick1 in Qt 5, and the
  14603. engine-only module for Qt 5 is named 'qml'. For many of the instances
  14604. we could just remove 'declarative', since the project file was only
  14605. used for Qt5/WebKit2 builds. In the other cases the module was wrapped
  14606. in a haveQt(4) scope.
  14607. Reviewed by Csaba Osztrogonác.
  14608. * MiniBrowser/qt/MiniBrowser.pro:
  14609. * WebKitTestRunner/InjectedBundle/Target.pri:
  14610. * WebKitTestRunner/Target.pri:
  14611. 2012-07-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  14612. [Qt] Remove a few un-needed load(features) after r121777
  14613. The features are computed by configure.pro and cached in .qmake.cache.
  14614. Reviewed by Jocelyn Turcotte..
  14615. * MiniBrowser/qt/raw/Target.pri:
  14616. 2012-07-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  14617. [Qt] Use haveQtModule() in project files instead of manual checks
  14618. Reviewed by Jocelyn Turcotte.
  14619. * qmake/mkspecs/features/default_pre.prf:
  14620. * qmake/mkspecs/features/features.prf:
  14621. 2012-07-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  14622. [Qt] Fix haveQtModule() check
  14623. Without {} brackets we were pulling out the value of the module.name variable.
  14624. Reviewed by Jocelyn Turcotte.
  14625. * qmake/mkspecs/features/functions.prf:
  14626. 2012-07-04 Sergio Villar Senin <svillar@igalia.com>
  14627. [WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
  14628. https://bugs.webkit.org/show_bug.cgi?id=90541
  14629. Reviewed by Carlos Garcia Campos.
  14630. We must add the contents of WebKitBuild/*/Libraries/ directory to
  14631. the file to be uploaded to b.w.o to successfully run WebKit2 tests
  14632. in the WebKit2 testing bot.
  14633. * BuildSlaveSupport/built-product-archive:
  14634. (archiveBuiltProduct): appended Libraries to the list of
  14635. neededDirectories.
  14636. 2012-07-04 Sergio Villar Senin <svillar@igalia.com>
  14637. [GTK] WebKit2 testing bot unable to find the build directory
  14638. https://bugs.webkit.org/show_bug.cgi?id=90523
  14639. Reviewed by Carlos Garcia Campos.
  14640. The presence of GNUmakefile was used to determine whether a given
  14641. directory was a valid build directory or not. That's not correct for
  14642. testing bots as we export only the minimum required stuff to run the
  14643. tests.
  14644. * gtk/common.py:
  14645. (get_build_path.is_valid_build_directory): added an extra check.:
  14646. 2012-07-04 Joe Thomas <joethomas@motorola.com>
  14647. Adding myself to committers list.
  14648. Unreviewed.
  14649. * Scripts/webkitpy/common/config/committers.py:
  14650. 2012-07-03 Christophe Dumez <christophe.dumez@intel.com>
  14651. [WK2][EFL] Ewk_View should report the load progress
  14652. https://bugs.webkit.org/show_bug.cgi?id=90457
  14653. Reviewed by Kenneth Rohde Christiansen.
  14654. Update EFL MiniBrowser so that it listens for the
  14655. "load,progress" on the Ewk_View and updates its
  14656. window title accordingly.
  14657. * MiniBrowser/efl/main.c:
  14658. (title_set):
  14659. (on_title_changed):
  14660. (on_progress):
  14661. (browserCreate):
  14662. 2012-07-03 Dirk Pranke <dpranke@chromium.org>
  14663. disable failing mock-chromium-mac python unit tests
  14664. Unreviewed, build fix.
  14665. Disable these tests until I can figure out why they're failing
  14666. on the bots.
  14667. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  14668. (PortTest.disabled_test_chromium_mac_lion):
  14669. (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
  14670. 2012-07-03 Ian Vollick <vollick@chromium.org>
  14671. Add vollick to the list of committers
  14672. https://bugs.webkit.org/show_bug.cgi?id=90512
  14673. Reviewed by Adrienne Walker.
  14674. * Scripts/webkitpy/common/config/committers.py:
  14675. 2012-07-03 Ojan Vafai <ojan@chromium.org>
  14676. Improve webkit-patch rebaseline to work for more cases
  14677. https://bugs.webkit.org/show_bug.cgi?id=90504
  14678. Reviewed by Dirk Pranke.
  14679. -Makes it work for the build.chromium.org bots.
  14680. -Lets you rebaseline all builders instead of just one.
  14681. -Lets you pass in the builder or test to rebaseline.
  14682. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  14683. (Build.results_url):
  14684. Make this work for build.chromium.org builders as well.
  14685. * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
  14686. (ChromiumBuilder):
  14687. (ChromiumBuilder.latest_cached_build):
  14688. ChromiumBuilder doesn't support large parts of the Builder interface.
  14689. This provides the bare minimum for this patch to work. Eventually,
  14690. we should create a single interface that can be supported for both
  14691. sets of buildbots.
  14692. * Scripts/webkitpy/layout_tests/port/builders.py:
  14693. (builder_path_from_name):
  14694. (all_builder_names):
  14695. memoizing here is incorrect because the test override _exact_matches,
  14696. so these can return different values. In either case, I'm pretty sure these
  14697. are not remotely hot codepaths.
  14698. * Scripts/webkitpy/tool/commands/rebaseline.py:
  14699. (AbstractParallelRebaselineCommand.__init__):
  14700. (Rebaseline):
  14701. (Rebaseline.__init__):
  14702. (Rebaseline._builders_to_pull_from):
  14703. (Rebaseline._builder_with_name):
  14704. (Rebaseline._tests_to_update):
  14705. (Rebaseline.execute):
  14706. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  14707. (test_rebaseline.mock_builders_to_pull_from):
  14708. (test_rebaseline):
  14709. (test_rebaseline_command_line_flags):
  14710. (test_rebaseline_multiple_builders):
  14711. (test_rebaseline_multiple_builders.mock_builders_to_pull_from):
  14712. (test_rebaseline_multiple_builders.mock_tests_to_update):
  14713. 2012-07-03 Christophe Dumez <christophe.dumez@intel.com>
  14714. [EFL] Enable CSS variables support at compile time
  14715. https://bugs.webkit.org/show_bug.cgi?id=90448
  14716. Reviewed by Kenneth Rohde Christiansen.
  14717. Turn on CSS_VARIABLES flag by default on EFL port.
  14718. * Scripts/webkitperl/FeatureList.pm:
  14719. 2012-07-03 Dirk Pranke <dpranke@chromium.org>
  14720. nrwt: clean up exception handling and make sure we log some more failures
  14721. https://bugs.webkit.org/show_bug.cgi?id=90503
  14722. Reviewed by Ojan Vafai.
  14723. There were several places where exceptions weren't getting
  14724. logged, most notably if you passed a bad value to --platform.
  14725. This change tests that and cleans things up a bit; more cleanup
  14726. will be possible when we rework the manager_worker_broker code.
  14727. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  14728. (_BrokerConnection.raise_exception):
  14729. (_InlineWorkerConnection.raise_exception):
  14730. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  14731. (Worker.run):
  14732. (Worker.kill_driver):
  14733. * Scripts/webkitpy/layout_tests/port/factory.py:
  14734. (PortFactory.get):
  14735. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  14736. (run):
  14737. (main):
  14738. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  14739. (MainTest.test_unsupported_platfrom):
  14740. 2012-07-03 Dirk Pranke <dpranke@chromium.org>
  14741. nrwt: fix mock port
  14742. https://bugs.webkit.org/show_bug.cgi?id=90500
  14743. Reviewed by Ojan Vafai.
  14744. The MockDRT code was never updated when we switched the chromium
  14745. ports to using "drt mode" by default. This change updates that
  14746. code, fixes a typo in the chromium port that went undetected
  14747. (default_test_timeout_ms -> default_timeout_ms), and adds tests
  14748. that actually exercise some of the mock ports. These tests are
  14749. useful in that they will exercise the port-specific code in an
  14750. end-to-end-manner, but they are a bit slow for some reason (>1s
  14751. each) that I need to look into.
  14752. * Scripts/webkitpy/layout_tests/port/chromium.py:
  14753. (ChromiumDriver.stop):
  14754. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  14755. (ChromiumAndroidPort.default_timeout_ms):
  14756. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  14757. (TestChromiumAndroidPort.test_default_timeout_ms):
  14758. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  14759. (main):
  14760. (parse_options):
  14761. (MockTestShell):
  14762. (MockTestShell.output_for_test):
  14763. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  14764. (MockDRTTest.assertTest):
  14765. (MockTestShellTest):
  14766. (MockTestShellTest.make_drt):
  14767. (MockTestShellTest.test_test_shell_parse_options):
  14768. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  14769. (PortTest):
  14770. (PortTest.assert_mock_port_works):
  14771. (PortTest.test_chromium_mac_lion):
  14772. (PortTest.test_chromium_mac_lion_in_test_shell_mode):
  14773. (PortTest.test_qt_linux):
  14774. (PortTest.test_mac_lion):
  14775. 2012-07-03 Dirk Pranke <dpranke@chromium.org>
  14776. nrwt: make the worker class stand alone with a cleaner interface
  14777. https://bugs.webkit.org/show_bug.cgi?id=90409
  14778. Reviewed by Ojan Vafai.
  14779. Currently the Worker class derives from AbstractWorker, which is
  14780. kind of crufty and awkward; it would be better if we did not
  14781. rely on shared state.
  14782. This change changes that so that Worker derives from object, and
  14783. exposes the following interface:
  14784. __init__() - called in the manager process
  14785. safe_init() - called in the worker process to initialize
  14786. unpicklable state
  14787. handle() - a single routine to handle all messages
  14788. cleanup() - called so the worker can clean up
  14789. Also, all of the "administrative" messages that are handled by
  14790. the worker (notification of start/stop/etc.) move into
  14791. manager_worker_broker - this reduces worker.py to just handling
  14792. the mechanics of actually running each test.
  14793. For the moment, we do this by creating Yet Another wrapper/proxy
  14794. class in manager_worker_broker, but this will get simpler
  14795. shortly when the rest of m_w_b is cleaned up.
  14796. With this change worker is now in its new form but there will be
  14797. a follow-on change that cleans up some names and other minor
  14798. things.
  14799. This change is again mostly just moving things around and should
  14800. be covered by the (updated) existing tests.
  14801. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  14802. (get):
  14803. (AbstractWorker.__init__):
  14804. (AbstractWorker.run):
  14805. (AbstractWorker):
  14806. (AbstractWorker.handle_stop):
  14807. (AbstractWorker.handle_test_list):
  14808. (AbstractWorker.yield_to_broker):
  14809. (AbstractWorker.post_message):
  14810. (_WorkerConnection.__init__):
  14811. (_Process.run):
  14812. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  14813. (_TestWorker):
  14814. (_TestWorker.__init__):
  14815. (_TestWorker.name):
  14816. (_TestWorker.cleanup):
  14817. (_TestWorker.handle):
  14818. (_TestWorker.safe_init):
  14819. (_TestWorker.stop):
  14820. (_TestsMixin.handle_finished_test):
  14821. (_TestsMixin.setUp):
  14822. (_TestsMixin.test_cancel):
  14823. (_TestsMixin.test_done):
  14824. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  14825. (Worker):
  14826. (Worker.__init__):
  14827. (Worker.safe_init):
  14828. (Worker.handle):
  14829. 2012-07-03 Dirk Pranke <dpranke@chromium.org>
  14830. nrwt: moving child process logging code into manager_worker_broker
  14831. https://bugs.webkit.org/show_bug.cgi?id=90408
  14832. Reviewed by Ojan Vafai.
  14833. Users of manager_worker_broker should not have to be aware of
  14834. whether they're in the same process or different processes and
  14835. configure logging themselves; mwb should hide this complexity.
  14836. We can't quite do this completely/correctly yet, since the
  14837. manager expects to get a list of messages to log, but this
  14838. change fixes the worker side of it, at least.
  14839. This is just moving code around, there is no new functionality
  14840. and this should be covered by existing tests.
  14841. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  14842. (AbstractWorker.__init__):
  14843. (_WorkerConnection.__init__):
  14844. (_WorkerConnection.post_message):
  14845. (_WorkerConnection):
  14846. (_WorkerConnection.set_up_logging):
  14847. (_WorkerConnection.clean_up_logging):
  14848. (_InlineWorkerConnection.run):
  14849. (_MultiProcessWorkerConnection.run):
  14850. (_WorkerLogHandler):
  14851. (_WorkerLogHandler.__init__):
  14852. (_WorkerLogHandler.emit):
  14853. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  14854. (_TestWorker.run):
  14855. (_TestsMixin.handle_done):
  14856. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  14857. (Worker.__init__):
  14858. (Worker.run):
  14859. (Worker._run_test):
  14860. (Worker.cleanup):
  14861. (Worker.run_single_test):
  14862. 2012-07-03 Tony Chang <tony@chromium.org>
  14863. [chromium] Don't archive build files generated by VS2010
  14864. https://bugs.webkit.org/show_bug.cgi?id=90493
  14865. Reviewed by Ojan Vafai.
  14866. In particular, the pch (pre compiled header) files are gigantic, making
  14867. release.zip almost a 1gb in size.
  14868. * BuildSlaveSupport/built-product-archive:
  14869. (archiveBuiltProduct):
  14870. 2012-07-03 Tony Chang <tony@chromium.org>
  14871. [chromium] Unreviewed, update .gitignore to handle VS2010 files.
  14872. * .gitignore:
  14873. * DumpRenderTree/DumpRenderTree.gyp/.gitignore:
  14874. * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore:
  14875. 2012-07-03 Ojan Vafai <ojan@chromium.org>
  14876. Have webkit-patch rebaseline use rebaseline-test-internal
  14877. https://bugs.webkit.org/show_bug.cgi?id=90491
  14878. Reviewed by Dirk Pranke.
  14879. This lets it handle new files, reduces duplicate code and lays the
  14880. groundwork for making rebaseline have a richer interface.
  14881. * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
  14882. (MockBuild):
  14883. (MockBuild.__init__):
  14884. (MockBuilder.build):
  14885. * Scripts/webkitpy/tool/commands/rebaseline.py:
  14886. (AbstractParallelRebaselineCommand._files_to_add):
  14887. (Rebaseline):
  14888. (Rebaseline._builder_to_pull_from):
  14889. (Rebaseline._tests_to_update):
  14890. (Rebaseline.execute):
  14891. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  14892. (test_overrides_are_included_correctly):
  14893. (test_rebaseline):
  14894. (test_rebaseline.mock_builder_to_pull_from):
  14895. (test_rebaseline.mock_tests_to_update):
  14896. 2012-07-03 Ojan Vafai <ojan@chromium.org>
  14897. Rename rebaseline-test to rebaseline-test-internal
  14898. https://bugs.webkit.org/show_bug.cgi?id=90485
  14899. Reviewed by Adam Barth.
  14900. It's now only used by other rebaseline commands. It's still useful to leave it
  14901. as it's own command to aid in debugging when something goes wrong. In a followup
  14902. patch, I'll make webkit-patch rebaseline cover any use-cases that rebaseline-test
  14903. might have covered.
  14904. We no longer need the --print-scm-changes option since the only caller always passes
  14905. that option in.
  14906. Also, make all the arguments command-line flags instead. Simplifies the code
  14907. a bit in my opinion.
  14908. * Scripts/webkitpy/tool/commands/rebaseline.py:
  14909. (RebaselineTest):
  14910. (RebaselineTest.__init__):
  14911. (RebaselineTest.execute):
  14912. (AbstractParallelRebaselineCommand._rebaseline_commands):
  14913. (RebaselineExpectations.execute):
  14914. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  14915. (test_rebaseline_all):
  14916. 2012-07-03 Balazs Kelemen <kbalazs@webkit.org>
  14917. [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
  14918. https://bugs.webkit.org/show_bug.cgi?id=90262
  14919. Unreviewed build fix.
  14920. Reverting r121550 manually because it caused build
  14921. break on ARM and Mac. It turned out that the Qt build
  14922. system is too broken for this change now, first we have
  14923. to address two issues:
  14924. * symbol hiding was forbidden accidentally on x86 Linux
  14925. * Qt lacks a separate library for test support
  14926. * Tools.pro:
  14927. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  14928. (WTR::InjectedBundlePage::resetAfterTest):
  14929. (WTR::InjectedBundlePage::didClearWindowForFrame):
  14930. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  14931. 2012-07-03 Tony Chang <tony@chromium.org>
  14932. [chromium] Handle trailing backslash on %VSINSTALLDIR%
  14933. https://bugs.webkit.org/show_bug.cgi?id=90410
  14934. Reviewed by Ojan Vafai.
  14935. * Scripts/webkitdirs.pm:
  14936. (buildChromiumVisualStudioProject): Handle VSINSTALLDIR ending in a backslash, the backslash escapes the closing double quote.
  14937. 2012-07-02 Ojan Vafai <ojan@chromium.org>
  14938. Make the skia_test_expectations.txt file optional.
  14939. https://bugs.webkit.org/show_bug.cgi?id=90400
  14940. Reviewed by Dirk Pranke.
  14941. It used to be optional. This regressed at some point. It's important that it be
  14942. optional so that webkit-patch commands work in a pure-webkit checkout for chromium bots.
  14943. Specifically, this was breaking webkit-patch rebaseline-test when it would go to update
  14944. TestExpectations.
  14945. * Scripts/webkitpy/layout_tests/port/chromium.py:
  14946. (ChromiumPort.expectations_files):
  14947. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  14948. (ChromiumDriverTest.test_expectations_dict):
  14949. 2012-07-03 Raphael Kubo da Costa <rakuco@webkit.org>
  14950. [jhbuild][EFL] Bump libffi dependency.
  14951. https://bugs.webkit.org/show_bug.cgi?id=85373
  14952. Reviewed by Gustavo Noronha Silva.
  14953. Update libffi to 3.0.11, which fixes the build on some platforms
  14954. where 3.0.10 had problems.
  14955. * efl/jhbuild.modules:
  14956. 2012-07-03 George Staikos <staikos@webkit.org>
  14957. [BlackBerry] Enable microdata support for BlackBerry.
  14958. https://bugs.webkit.org/show_bug.cgi?id=90429
  14959. Reviewed by Rob Buis.
  14960. * Scripts/webkitperl/FeatureList.pm:
  14961. 2012-07-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  14962. [Qt] Make use of .qmake.cache for caching features
  14963. Instead of loading() features from the files that need them (and re-running
  14964. a bunch of checks), we now run feature detection as part of configure.pro,
  14965. and have build-webkit write the computed feature-defines and CONFIG to
  14966. .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
  14967. when building WebKit.pro.
  14968. At some point we'll be able to selectivly prevent running of config tests
  14969. in configure.pro, which means we don't need a separate code-path for
  14970. the build-webkit --help case.
  14971. We should also move the code in build-webkit that now uses .webkit.config
  14972. to detect clean builds, to use .qmake.cache, since we now store the same
  14973. thing there.
  14974. Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  14975. Reviewed by Tor Arne Vestbø.
  14976. * DumpRenderTree/qt/DumpRenderTree.pro:
  14977. * QtTestBrowser/QtTestBrowser.pro:
  14978. * Scripts/webkitdirs.pm:
  14979. (qtFeatureDefaults):
  14980. (buildQMakeProjects):
  14981. * Tools.pro:
  14982. * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  14983. * WebKitTestRunner/InjectedBundle/Target.pri:
  14984. * WebKitTestRunner/Target.pri:
  14985. * qmake/.qmake.conf: Added.
  14986. * qmake/configure.pro:
  14987. * qmake/mkspecs/features/default_post.prf:
  14988. * qmake/mkspecs/features/default_pre.prf:
  14989. * qmake/mkspecs/features/features.prf:
  14990. 2012-07-03 Nico Weber <thakis@chromium.org>
  14991. -Wunused-private-field cleanup, linux edition
  14992. https://bugs.webkit.org/show_bug.cgi?id=90463
  14993. Reviewed by Stephen White.
  14994. * DumpRenderTree/chromium/DRTDevToolsAgent.h:
  14995. * DumpRenderTree/chromium/GamepadController.h:
  14996. (GamepadController):
  14997. * DumpRenderTree/chromium/NotificationPresenter.h:
  14998. (NotificationPresenter::NotificationPresenter):
  14999. (NotificationPresenter):
  15000. 2012-07-03 Sheriff Bot <webkit.review.bot@gmail.com>
  15001. Unreviewed, rolling out r121766.
  15002. http://trac.webkit.org/changeset/121766
  15003. https://bugs.webkit.org/show_bug.cgi?id=90465
  15004. It caused flakey build errors on the bots (Requested by Ossy
  15005. on #webkit).
  15006. * DumpRenderTree/qt/DumpRenderTree.pro:
  15007. * QtTestBrowser/QtTestBrowser.pro:
  15008. * Scripts/webkitdirs.pm:
  15009. (qtFeatureDefaults):
  15010. (buildQMakeProjects):
  15011. * Tools.pro:
  15012. * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  15013. * WebKitTestRunner/InjectedBundle/Target.pri:
  15014. * WebKitTestRunner/Target.pri:
  15015. * qmake/.qmake.conf: Removed.
  15016. * qmake/configure.pro:
  15017. * qmake/mkspecs/features/default_post.prf:
  15018. * qmake/mkspecs/features/default_pre.prf:
  15019. * qmake/mkspecs/features/features.prf:
  15020. 2012-07-03 George Staikos <staikos@webkit.org>
  15021. [BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
  15022. https://bugs.webkit.org/show_bug.cgi?id=90422
  15023. Reviewed by Rob Buis.
  15024. * Scripts/webkitperl/FeatureList.pm:
  15025. 2012-07-03 George Staikos <staikos@webkit.org>
  15026. [BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
  15027. https://bugs.webkit.org/show_bug.cgi?id=90422
  15028. Reviewed by Rob Buis.
  15029. * Scripts/webkitperl/FeatureList.pm:
  15030. 2012-07-03 Thiago Marcos P. Santos <thiago.santos@intel.com>
  15031. [EFL] Add run API tests as a step on the build bots
  15032. https://bugs.webkit.org/show_bug.cgi?id=87252
  15033. Reviewed by Daniel Bates.
  15034. Run EFL API test suite on the build bots.
  15035. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  15036. (RunEflAPITests):
  15037. (TestFactory.__init__):
  15038. (BuildAndTestFactory.__init__):
  15039. * Scripts/run-efl-tests: Added.
  15040. 2012-07-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  15041. [Qt] Make use of .qmake.cache for caching features
  15042. Instead of loading() features from the files that need them (and re-running
  15043. a bunch of checks), we now run feature detection as part of configure.pro,
  15044. and have build-webkit write the computed feature-defines and CONFIG to
  15045. .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
  15046. when building WebKit.pro.
  15047. At some point we'll be able to selectivly prevent running of config tests
  15048. in configure.pro, which means we don't need a separate code-path for
  15049. the build-webkit --help case.
  15050. We should also move the code in build-webkit that now uses .webkit.config
  15051. to detect clean builds, to use .qmake.cache, since we now store the same
  15052. thing there.
  15053. Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  15054. Reviewed by Tor Arne Vestbø.
  15055. * DumpRenderTree/qt/DumpRenderTree.pro:
  15056. * QtTestBrowser/QtTestBrowser.pro:
  15057. * Scripts/webkitdirs.pm:
  15058. (qtFeatureDefaults):
  15059. (buildQMakeProjects):
  15060. * Tools.pro:
  15061. * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  15062. * WebKitTestRunner/InjectedBundle/Target.pri:
  15063. * WebKitTestRunner/Target.pri:
  15064. * qmake/.qmake.conf: Added.
  15065. * qmake/configure.pro:
  15066. * qmake/mkspecs/features/default_post.prf:
  15067. * qmake/mkspecs/features/default_pre.prf:
  15068. * qmake/mkspecs/features/features.prf:
  15069. 2012-07-03 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> Joel Dillon <joel.dillon@codethink.co.uk>
  15070. [Qt][Win] Fix broken QtWebKit5.lib linking
  15071. https://bugs.webkit.org/show_bug.cgi?id=88321
  15072. Reviewed by Kenneth Rohde Christiansen.
  15073. On windows the import/export definition is part of the symbol's signature.
  15074. Define STATICALLY_LINKED_WITH_$$library for each dependend module
  15075. that is being linked statically to make sure that they can be linked together
  15076. later on.
  15077. Also do not compile Assertions.cpp in DumpRenderTree anymore since all the
  15078. used symbols are exported and it would cause a duplicate symbols error.
  15079. * DumpRenderTree/qt/DumpRenderTree.pro:
  15080. * qmake/mkspecs/features/default_post.prf:
  15081. 2012-07-03 Szilard Ledan <szledan@inf.u-szeged.hu>
  15082. master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
  15083. https://bugs.webkit.org/show_bug.cgi?id=89001
  15084. Reviewed by Csaba Osztrogonác.
  15085. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  15086. (UploadBuiltProduct.__init__):
  15087. (UploadTestResults.__init__):
  15088. (ExtractTestResults.__init__):
  15089. (Factory.__init__):
  15090. (BuildFactory.__init__):
  15091. (TestFactory.__init__):
  15092. (BuildAndTestFactory.__init__):
  15093. (BuildAndPerfTestFactory.__init__):
  15094. (BuildAndPerfTestWebKit2Factory.__init__):
  15095. (DownloadAndPerfTestFactory.__init__):
  15096. 2012-07-03 Ádám Kallai <kadam@inf.u-szeged.hu>
  15097. Update unit test after r121724.
  15098. https://bugs.webkit.org/show_bug.cgi?id=90444
  15099. Reviewed by Csaba Osztrogonác.
  15100. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  15101. (GardeningServerTest.test_rebaseline_new_port):
  15102. 2012-07-03 Sheriff Bot <webkit.review.bot@gmail.com>
  15103. Unreviewed, rolling out r121749.
  15104. http://trac.webkit.org/changeset/121749
  15105. https://bugs.webkit.org/show_bug.cgi?id=90441
  15106. Tests crash on the paralel NRWT Qt bot (Requested by Ossy on
  15107. #webkit).
  15108. * Scripts/webkitpy/layout_tests/port/qt.py:
  15109. (QtPort._build_driver):
  15110. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  15111. (XvfbDriver._start):
  15112. (XvfbDriver._start.x_filter):
  15113. (XvfbDriver.stop):
  15114. 2012-07-03 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  15115. [NRWT] XvfbDriver should choose the next free display
  15116. https://bugs.webkit.org/show_bug.cgi?id=88414
  15117. Reviewed by Dirk Pranke.
  15118. * Scripts/webkitpy/layout_tests/port/qt.py:
  15119. (QtPort._driver_class):
  15120. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  15121. (XvfbDriver.__init__):
  15122. (XvfbDriver._start):
  15123. (XvfbDriver._start.next_free_id):
  15124. (XvfbDriver.stop):
  15125. 2012-07-03 Christophe Dumez <christophe.dumez@intel.com>
  15126. [EFL] Enable MICRODATA support
  15127. https://bugs.webkit.org/show_bug.cgi?id=90377
  15128. Reviewed by Kenneth Rohde Christiansen.
  15129. Turn on MICRODATA flag for EFL port by default.
  15130. * Scripts/webkitperl/FeatureList.pm:
  15131. 2012-07-02 George Staikos <staikos@webkit.org>
  15132. [BlackBerry] Enable scoped style for BlackBerry.
  15133. https://bugs.webkit.org/show_bug.cgi?id=90418
  15134. Reviewed by Rob Buis.
  15135. * Scripts/webkitperl/FeatureList.pm:
  15136. 2012-07-02 Xiaobo Wang <xbwang@torchmobile.com.cn>
  15137. [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
  15138. https://bugs.webkit.org/show_bug.cgi?id=90271
  15139. Reviewed by George Staikos.
  15140. RIM PR #154707
  15141. Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
  15142. defined by default.
  15143. We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
  15144. need to rebuild webkit before running DRT.
  15145. * Scripts/webkitdirs.pm:
  15146. (blackberryCMakeArguments):
  15147. 2012-07-02 Ojan Vafai <ojan@chromium.org>
  15148. webkit-patch rebaseline-expectations should share code with rebaseline-all
  15149. https://bugs.webkit.org/show_bug.cgi?id=90413
  15150. Reviewed by Dirk Pranke.
  15151. Make them share code. In addition to reducing code duplication this makes
  15152. rebaseline-expectations considerably faster by rebaselining in parallel.
  15153. * Scripts/webkitpy/tool/commands/rebaseline.py:
  15154. (AbstractParallelRebaselineCommand):
  15155. (AbstractParallelRebaselineCommand._run_webkit_patch):
  15156. (AbstractParallelRebaselineCommand._rebaseline):
  15157. (RebaselineJson):
  15158. (RebaselineJson.execute):
  15159. (RebaselineExpectations):
  15160. (RebaselineExpectations._update_expectations_file):
  15161. (RebaselineExpectations._tests_to_rebaseline):
  15162. (RebaselineExpectations._add_tests_to_rebaseline_for_port):
  15163. (RebaselineExpectations.execute):
  15164. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  15165. (test_rebaseline_all):
  15166. (test_rebaseline_expectations.run_in_parallel):
  15167. (test_rebaseline_expectations):
  15168. 2012-07-02 Xiaobo Wang <xbwang@torchmobile.com.cn>
  15169. [BlackBerry] Update DumpRenderTree to have it work interactively in parallel
  15170. https://bugs.webkit.org/show_bug.cgi?id=88326
  15171. Reviewed by Rob Buis.
  15172. 1. Test name is sent to torch-launcher via PPS message(from host machine).
  15173. So we get test list by monitoring and receiving PPS message instead of
  15174. reading file index.drt.
  15175. 2. Torch-launcher create a <test file>.done file when it finished a test.
  15176. 3. We don't need to search for Ref-tests in DumpRenderTree.cpp any more. NRWT
  15177. will get them for us.
  15178. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  15179. (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
  15180. (BlackBerry::WebKit::DumpRenderTree::doneDrt):
  15181. (BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
  15182. (BlackBerry::WebKit::DumpRenderTree::ensurePPS):
  15183. (WebKit):
  15184. (BlackBerry::WebKit::DumpRenderTree::handlePPSData):
  15185. (BlackBerry::WebKit::DumpRenderTree::waitForTest):
  15186. (BlackBerry::WebKit::DumpRenderTree::runTests):
  15187. (BlackBerry::WebKit::DumpRenderTree::dump):
  15188. * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
  15189. (DumpRenderTree):
  15190. 2012-07-02 Adam Barth <abarth@webkit.org>
  15191. Remove flashplugin-installer from the EWS image because it causes some tests to crash
  15192. https://bugs.webkit.org/show_bug.cgi?id=90403
  15193. Reviewed by Tony Chang.
  15194. * EWSTools/cold-boot.sh:
  15195. 2012-07-02 Leandro Gracia Gil <leandrogracia@chromium.org>
  15196. [Chromium] Implement a Layout Test for editing/SurroundingText
  15197. https://bugs.webkit.org/show_bug.cgi?id=82461
  15198. Reviewed by Ryosuke Niwa.
  15199. Add a new method to the layout test controller in order to retrieve the
  15200. text surrounding a provided element.
  15201. * DumpRenderTree/chromium/LayoutTestController.cpp:
  15202. (LayoutTestController::LayoutTestController):
  15203. (LayoutTestController::textSurroundingElement):
  15204. * DumpRenderTree/chromium/LayoutTestController.h:
  15205. (LayoutTestController):
  15206. 2012-07-02 Ojan Vafai <ojan@chromium.org>
  15207. Delete unused rebaseline method in gardeningserver.py
  15208. https://bugs.webkit.org/show_bug.cgi?id=90396
  15209. Reviewed by Eric Seidel.
  15210. As best I can tell, the only usage was in this unittest.
  15211. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  15212. (GardeningHTTPRequestHandler.updateexpectations):
  15213. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  15214. (GardeningServerTest.test_rebaseline_new_port):
  15215. 2012-07-02 Csaba Osztrogonác <ossy@webkit.org>
  15216. REGRESSION(r121497): It switched off and broke many unittests
  15217. https://bugs.webkit.org/show_bug.cgi?id=90371
  15218. Reviewed by Adam Barth.
  15219. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  15220. (ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
  15221. * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
  15222. (ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
  15223. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  15224. (PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.
  15225. 2012-07-02 Ojan Vafai <ojan@chromium.org>
  15226. Move rebaseline-all command from the gardening-server down into webkit-patch
  15227. https://bugs.webkit.org/show_bug.cgi?id=90395
  15228. Reviewed by Adam Barth.
  15229. This is just moving code. It it in preparation for making rebaseline-expectations
  15230. use the same code in order to get the parallelism benefits and reduces the amount
  15231. of code we have for doing rebaselines.
  15232. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  15233. (CheckoutTest.test_apply_patch):
  15234. Updated due to the change to executive_mock.
  15235. * Scripts/webkitpy/common/system/executive_mock.py:
  15236. (MockExecutive.run_command):
  15237. Update to print out the input passed to stdin.
  15238. * Scripts/webkitpy/tool/commands/download_unittest.py:
  15239. Updated due to executive_mock change.
  15240. * Scripts/webkitpy/tool/commands/rebaseline.py:
  15241. (RebaselineAll):
  15242. (RebaselineAll._run_webkit_patch):
  15243. (RebaselineAll._builders_to_fetch_from):
  15244. (RebaselineAll._rebaseline_commands):
  15245. (RebaselineAll._files_to_add):
  15246. (RebaselineAll._optimize_baselines):
  15247. (RebaselineAll._rebaseline):
  15248. (RebaselineAll.execute):
  15249. All this code is just copy-pasted except for mechanical changes
  15250. (e.g. self.server.tool --> self._tool) and the reading in of the
  15251. JSON from stdin instead of the post body.
  15252. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  15253. (test_rebaseline_all):
  15254. Copied the test-case out of gardeningserver_unittest.py.
  15255. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  15256. (GardeningHTTPRequestHandler):
  15257. (GardeningHTTPRequestHandler.rebaseline):
  15258. (GardeningHTTPRequestHandler.rebaselineall):
  15259. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  15260. (GardeningServerTest.test_rebaselineall):
  15261. (GardeningServerTest.test_rebaselineall.run_command):
  15262. 2012-07-02 Ojan Vafai <ojan@chromium.org>
  15263. Remove Leopard support from the flakiness dashboard
  15264. https://bugs.webkit.org/show_bug.cgi?id=90390
  15265. Reviewed by Adam Barth.
  15266. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  15267. (nonChromiumPlatform):
  15268. (chromiumPlatform):
  15269. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  15270. (test):
  15271. * TestResultServer/static-dashboards/run-embedded-unittests.html:
  15272. * TestResultServer/static-dashboards/run-unittests.html:
  15273. 2012-07-02 Ojan Vafai <ojan@chromium.org>
  15274. Fix posting from garden-o-matic. This broke in moving away from jquery's ajax method
  15275. in http://trac.webkit.org/changeset/121617.
  15276. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
  15277. 2012-07-02 Carlos Garcia Campos <cgarcia@igalia.com>
  15278. [GTK] Read fonts path when running layout tests from alternative fonts dir when main dir doesn't exist
  15279. https://bugs.webkit.org/show_bug.cgi?id=89437
  15280. Reviewed by Martin Robinson.
  15281. If main fonts directory doesn't exist, try with an alternative
  15282. fonts directory at build directory.
  15283. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  15284. (getOutputDir):
  15285. (getFontsPath):
  15286. (initializeFonts):
  15287. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
  15288. (WTR::getOutputDir):
  15289. (WTR):
  15290. (WTR::getFontsPath):
  15291. (WTR::inititializeFontConfigSetting):
  15292. 2012-07-02 Carlos Garcia Campos <cgarcia@igalia.com>
  15293. [GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
  15294. https://bugs.webkit.org/show_bug.cgi?id=89435
  15295. Reviewed by Martin Robinson.
  15296. * Scripts/new-run-webkit-tests: Don't run the tests with the
  15297. jhbuild wrapper if there isn't a Dependencies directory inside the
  15298. build directory.
  15299. 2012-06-29 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  15300. [Qt] Simplify detection of non-installed module file
  15301. Has the additional advantage that we do not rely on additional information.
  15302. Reviewed by Tor Arne Vestbø.
  15303. * qmake/qt_webkit.pri:
  15304. 2012-07-01 Christophe Dumez <christophe.dumez@intel.com>
  15305. [EFL] Add Gamepad support
  15306. https://bugs.webkit.org/show_bug.cgi?id=90170
  15307. Reviewed by Kenneth Rohde Christiansen.
  15308. * Scripts/webkitperl/FeatureList.pm: Turn on GAMEPAD flag
  15309. by default for EFL port.
  15310. * efl/jhbuild.modules: Bump dependency versions of EFL libs
  15311. since the latest Eeze is required for gamepad support.
  15312. 2012-07-01 Adam Barth <abarth@webkit.org>
  15313. Unreviewed.
  15314. Using the default start cylinder for fdisk causes a warning about the
  15315. partition not starting on physical sector boundary. The Ubuntu forums
  15316. recommend using a number that's divisible by 8, which is what we do in
  15317. this patch.
  15318. * EWSTools/cold-boot.sh:
  15319. 2012-07-01 Adam Barth <abarth@webkit.org>
  15320. Unreviewed.
  15321. It turns out we need to use Ubuntu 10.04 to get the right image results
  15322. for chromium-linux. This patch updates our scripts to be compatible
  15323. with Ubuntu 10.04.
  15324. * EWSTools/cold-boot.sh:
  15325. - fdisk doesn't have p and 1 as default commands in 10.04.
  15326. * EWSTools/start-queue.sh:
  15327. - git doesn't understanding the -B argument in 10.04. We've been
  15328. using this change locally on the EC2 bots for a while.
  15329. 2012-07-01 Adam Barth <abarth@webkit.org>
  15330. Unreviewed.
  15331. * EWSTools/boot.sh:
  15332. - We need to start the screen in detached mode so that we can run
  15333. it remotely via ssh.
  15334. 2012-07-01 Adam Barth <abarth@webkit.org>
  15335. Unreviewed.
  15336. * EWSTools/cold-boot.sh:
  15337. - Turns out we need to sudo this command in order for it to
  15338. actually dimiss the EULA screen. :)
  15339. 2012-06-29 Adam Barth <abarth@webkit.org>
  15340. Turns out we need zip too.
  15341. * EWSTools/cold-boot.sh:
  15342. 2012-06-29 Adam Barth <abarth@webkit.org>
  15343. Add a cold-boot.sh script for the EWS
  15344. https://bugs.webkit.org/show_bug.cgi?id=90330
  15345. Unreviewed.
  15346. * EWSTools/cold-boot.sh: Added.
  15347. - This script can take us from a cold GCE instance to a running EWS
  15348. bot in one fell swoop.
  15349. * EWSTools/start-queue.sh:
  15350. - The if-block at the top of this script was causing trouble. I
  15351. removed it from the bots a while ago. Now that we're using SVN to
  15352. cold-boot the EWS bots, we need to make this change in the repo.
  15353. 2012-06-29 Luiz Agostini <luiz.agostini@nokia.com>
  15354. [Qt][WK2] Private non-QtQuick API
  15355. https://bugs.webkit.org/show_bug.cgi?id=84532
  15356. MiniBrowserRaw is an usage example for the QRawWebView API.
  15357. It is only an example and is not fully implemented.
  15358. Reviewed by Noam Rosenthal.
  15359. * MiniBrowser/qt/raw/DerivedSources.pri: Added.
  15360. * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Added.
  15361. * MiniBrowser/qt/raw/Target.pri: Added.
  15362. * MiniBrowser/qt/raw/View.cpp: Added.
  15363. * MiniBrowser/qt/raw/View.h: Added.
  15364. * Scripts/webkitpy/style/checker.py:
  15365. * Tools.pro:
  15366. 2012-06-29 Ojan Vafai <ojan@chromium.org>
  15367. Remove leopard bots from garden-o-matic
  15368. https://bugs.webkit.org/show_bug.cgi?id=90328
  15369. Reviewed by Adam Barth.
  15370. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  15371. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  15372. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  15373. 2012-06-29 Ojan Vafai <ojan@chromium.org>
  15374. garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url')
  15375. https://bugs.webkit.org/show_bug.cgi?id=90243
  15376. Reviewed by Dirk Pranke.
  15377. jQuery was trying to be too smart and parsing the jsonp as json because of it's content-type.
  15378. Excise jQuery and just use XHR directly since it's easier to maintain something where we control it
  15379. all.
  15380. Not really sure how to unittest this. I tested it all manually of course.
  15381. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
  15382. Made net.ajax a drop-in replacement for the features of $.ajax that we were using.
  15383. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  15384. Not related to this patch, but figured I'd update the failing test while I was at it.
  15385. 2012-06-29 Yaron Friedman <yfriedman@chromium.org>
  15386. Fix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id=88134
  15387. https://bugs.webkit.org/show_bug.cgi?id=90309
  15388. Reviewed by Adam Barth.
  15389. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  15390. (ChromiumAndroidPort.start_http_server):
  15391. 2012-06-29 James Weatherall <wez@chromium.org>
  15392. NPObjectWrapper may not address all window script object lifetime issues
  15393. https://bugs.webkit.org/show_bug.cgi?id=85679
  15394. TestNetscapePlugin now has a leak-window-scriptable-object test which takes a reference to the window script object, and a second reference to it via the "self" property, and does not release those references. This is used to simulate a leaky plugin in layout tests of the NPAPI scripting interface glue code.
  15395. Reviewed by Nate Chapin.
  15396. * DumpRenderTree/DumpRenderTree.gypi:
  15397. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  15398. (PluginTest::NPN_GetProperty):
  15399. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  15400. (PluginTest):
  15401. * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Added.
  15402. (LeakWindowScriptableObject):
  15403. (LeakWindowScriptableObject::LeakWindowScriptableObject):
  15404. (LeakWindowScriptableObject::NPP_New):
  15405. 2012-06-29 Dirk Pranke <dpranke@chromium.org>
  15406. webkitpy: add comment about how determine_full_port_name() works for apple ports, fix -wk2 bug
  15407. https://bugs.webkit.org/show_bug.cgi?id=90314
  15408. Reviewed by Ojan Vafai.
  15409. Add comments and fix a bug in how we would handle the mac-wk2
  15410. and win-wk2 port names after confusion around in bug 90312 :).
  15411. * Scripts/webkitpy/layout_tests/port/apple.py:
  15412. (ApplePort.determine_full_port_name):
  15413. 2012-06-29 Dirk Pranke <dpranke@chromium.org>
  15414. webkitpy: remove support for mac leopard from chromium configurations
  15415. https://bugs.webkit.org/show_bug.cgi?id=90313
  15416. Reviewed by Tony Chang.
  15417. Google has shipped the last version of Chrome that will support
  15418. Mac OS 10.5 (Leopard), and we no longer have bots that run this
  15419. configuration, so we're removing support for it.
  15420. A subsequent change will remove the baselines in platform/chromium-mac-leopard.
  15421. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  15422. (BaselineOptimizerTest.test_complex_shadowing):
  15423. * Scripts/webkitpy/layout_tests/port/builders.py:
  15424. * Scripts/webkitpy/layout_tests/port/chromium.py:
  15425. (ChromiumPort):
  15426. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  15427. (ChromiumMacPort):
  15428. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  15429. (ChromiumMacPortTest.test_versions):
  15430. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  15431. (FactoryTest.test_mac):
  15432. (FactoryTest.test_chromium_mac):
  15433. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  15434. (test_rebaseline_and_copy_test_with_lion_result):
  15435. 2012-06-29 Ojan Vafai <ojan@chromium.org>
  15436. Fix optimize-baselines to not move baselines from win to win-7sp0
  15437. https://bugs.webkit.org/show_bug.cgi?id=90312
  15438. Reviewed by Dirk Pranke.
  15439. It used to consider win-7sp0 as the common directory for all the Apple
  15440. windows ports and incorrectly move results out of win.
  15441. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  15442. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  15443. (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
  15444. (BaselineOptimizerTest.test_common_directory_includes_root):
  15445. 2012-06-28 Ojan Vafai <ojan@chromium.org>
  15446. Fix rebaselining for Qt and Apple ports
  15447. https://bugs.webkit.org/show_bug.cgi?id=90204
  15448. Reviewed by Dirk Pranke.
  15449. -Apporpriately put wk2 results in the -wk2 directories.
  15450. -Since Qt and Apple-Win don't have bots that correspond to the
  15451. platform/qt and platform/win directories, we need to fudge it
  15452. and always put the results in those directories for those ports.
  15453. * Scripts/webkitpy/layout_tests/port/builders.py:
  15454. (rebaseline_override_dir):
  15455. * Scripts/webkitpy/layout_tests/port/factory.py:
  15456. (_builder_options):
  15457. Identify webkit2 builders by the WK2 in the builder name.
  15458. * Scripts/webkitpy/tool/commands/rebaseline.py:
  15459. (RebaselineTest._baseline_directory):
  15460. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  15461. (TestRebaseline.test_baseline_directory):
  15462. 2012-06-29 Zoltan Horvath <zoltan@webkit.org>
  15463. Add support for --force parameter to run-performance-tests
  15464. https://bugs.webkit.org/show_bug.cgi?id=90279
  15465. Reviewed by Dirk Pranke.
  15466. It's helpful to be able to run tests from the Skipped list of the performance tests.
  15467. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  15468. (PerfTestsRunner._parse_args):
  15469. (PerfTestsRunner._collect_tests):
  15470. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.
  15471. (test_collect_tests_with_skipped_list):
  15472. 2012-06-29 Tony Chang <tony@chromium.org>
  15473. [GTK] Enable CSS grid layout LayoutTests on GTK+
  15474. https://bugs.webkit.org/show_bug.cgi?id=90226
  15475. Reviewed by Martin Robinson.
  15476. This feature is disabled via Settings by default, but for testing,
  15477. we enable it using layoutTestController.overridePreferences. Add the
  15478. necessary plumbing for DRT.
  15479. WTR already works because support was added for Apple Mac earlier.
  15480. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  15481. (resetDefaultsToConsistentValues): Feature is off by default.
  15482. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  15483. (LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.
  15484. 2012-06-29 Ádám Kallai <kadam@inf.u-szeged.hu>
  15485. [Qt] Added Qt port for garden-o-matic.
  15486. https://bugs.webkit.org/show_bug.cgi?id=82719
  15487. Reviewed by Adam Barth.
  15488. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  15489. (.):
  15490. 2012-06-29 Balazs Kelemen <kbalazs@webkit.org>
  15491. [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
  15492. https://bugs.webkit.org/show_bug.cgi?id=90262
  15493. Reviewed by Alexey Proskuryakov.
  15494. Now that we decided to not support v8 in WebKit2
  15495. we can get rid of using DumpRenderTreeSupportQt
  15496. in WebKitTestRunner.
  15497. * Tools.pro:
  15498. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  15499. (WTR::InjectedBundlePage::resetAfterTest):
  15500. (WTR::InjectedBundlePage::didClearWindowForFrame):
  15501. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  15502. 2012-06-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  15503. Revert r121540, it broke most Qt builds
  15504. * qmake/mkspecs/features/default_post.prf:
  15505. * qmake/mkspecs/features/functions.prf:
  15506. 2012-06-29 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  15507. [Qt] Make build-webkit reject uknown configurations, eg. --profile
  15508. The qmake-based buildsystem doesn't support it.
  15509. Reviewed by Tor Arne Vestbø.
  15510. * Scripts/webkitdirs.pm:
  15511. (buildQMakeProjects):
  15512. 2012-06-29 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  15513. [Qt] Don't add Qt module dependencies in features.prf
  15514. The required dependencies are already added in WebCore.pri.
  15515. Reviewed by Tor Arne Vestbø.
  15516. * qmake/mkspecs/features/features.prf:
  15517. 2012-06-27 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  15518. [Qt] Use LIBS_PRIVATE instead of putting dependencies into LIBS
  15519. Reviewed by Tor Arne Vestbø..
  15520. * qmake/mkspecs/features/default_post.prf:
  15521. * qmake/mkspecs/features/functions.prf:
  15522. 2012-06-28 Ryosuke Niwa <rniwa@webkit.org>
  15523. DOMHTMLCollection::item may return a wrong element after namedItem is called
  15524. https://bugs.webkit.org/show_bug.cgi?id=90240
  15525. Reviewed by Antti Koivisto.
  15526. Add a WebKit API test since namedItem is not used in the JS/V8 binding code.
  15527. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  15528. * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.html: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html.
  15529. * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm.
  15530. (TestWebKitAPI::TEST):
  15531. 2012-06-28 Dirk Pranke <dpranke@chromium.org>
  15532. nrwt: remove the 'google-chrome' port code
  15533. https://bugs.webkit.org/show_bug.cgi?id=88824
  15534. Reviewed by Ojan Vafai.
  15535. NRWT now supports passing additional baseline directories
  15536. and expectations files on the command line, so there's no need
  15537. to support the concept of a 'google-chrome' port directly.
  15538. * Scripts/webkitpy/layout_tests/port/base.py:
  15539. (Port.path_to_test_expectations_file):
  15540. * Scripts/webkitpy/layout_tests/port/builders.py:
  15541. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  15542. (ChromiumMacPort.__init__):
  15543. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  15544. (ChromiumWinPort.__init__):
  15545. * Scripts/webkitpy/layout_tests/port/factory.py:
  15546. (PortFactory):
  15547. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  15548. (FactoryTest.test_win):
  15549. * Scripts/webkitpy/layout_tests/port/google_chrome.py: Removed.
  15550. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: Removed.
  15551. 2012-06-28 Dirk Pranke <dpranke@chromium.org>
  15552. nrwt: clean up how arguments are passed to workers
  15553. https://bugs.webkit.org/show_bug.cgi?id=90126
  15554. Reviewed by Ojan Vafai.
  15555. The way arguments are passed to workers has been crufty. It
  15556. turns out it can be a lot cleaner via two things:
  15557. 1) using a factory method instead of instantiating objects
  15558. directly in manager_worker_broker removes the need for passing
  15559. 'worker arguments' to the broker.
  15560. 2) it turns out that since mock hosts and test ports are purely
  15561. in-memory constructions, they can be pickled and passed to child
  15562. workers, meaning that the worker no longer needs hacky code to
  15563. pass the port in a special case or to guess what to do if we
  15564. don't have a host - all of the test-specific logic can move to
  15565. the test file, where we can stub out the mock host's
  15566. port_factory to return the same already-created port when it
  15567. needs to be shared.
  15568. This change also moves WorkerException to manager_worker_broker.py
  15569. where it belongs, and removes several useless tests that were
  15570. just a maintenance burden (and would've needed rewriting when we
  15571. change the rest of the broker implementation).
  15572. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  15573. (Manager._run_tests.worker_factory):
  15574. (Manager._run_tests):
  15575. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  15576. (get):
  15577. (WorkerException):
  15578. (AbstractWorker.__init__):
  15579. (_ManagerConnection.__init__):
  15580. (_ManagerConnection.start_worker):
  15581. (_InlineManager.__init__):
  15582. (_InlineManager.start_worker):
  15583. (_MultiProcessManager._can_pickle_host):
  15584. (_MultiProcessManager):
  15585. (_MultiProcessManager.start_worker):
  15586. (_WorkerConnection.__init__):
  15587. (_InlineWorkerConnection.__init__):
  15588. (_InlineWorkerConnection.join):
  15589. (_InlineWorkerConnection.run):
  15590. (_Process.run):
  15591. (_MultiProcessWorkerConnection.__init__):
  15592. (_MultiProcessWorkerConnection.start):
  15593. (_MultiProcessWorkerConnection):
  15594. (_MultiProcessWorkerConnection.run):
  15595. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  15596. (_TestWorker.__init__):
  15597. (_TestWorker.run):
  15598. (_TestsMixin.test_name):
  15599. (_TestsMixin.test_cancel):
  15600. (_TestsMixin.test_done):
  15601. (_TestsMixin.test_unknown_message):
  15602. (InlineBrokerTests.setUp):
  15603. (MultiProcessBrokerTests.setUp):
  15604. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  15605. (Worker.__init__):
  15606. (Worker.run):
  15607. * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Removed.
  15608. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  15609. (passing_run):
  15610. (logging_run):
  15611. (run_and_capture):
  15612. (MainTest.test_child_processes_2):
  15613. (MainTest.test_child_processes_min):
  15614. (MainTest.test_exception_raised):
  15615. (MainTest.test_keyboard_interrupt):
  15616. (MainTest.test_retrying_and_flaky_tests):
  15617. (MainTest.test_run_order__inline):
  15618. 2012-06-28 Dirk Pranke <dpranke@chromium.org>
  15619. nrwt: don't try to catch worker exceptions in run_webkit_tests.__main__
  15620. https://bugs.webkit.org/show_bug.cgi?id=90125
  15621. Reviewed by Ojan Vafai.
  15622. It turns out run_webkit_tests.py wasn't really using
  15623. WorkerException and the catch we had for it was pointless. I've
  15624. removed the symbol import and moved it to the integration tests
  15625. where it is needed. Eventually the definition of the exception
  15626. moves to the broker module, and so minimizing the number of
  15627. users of it is a good thing.
  15628. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  15629. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  15630. (MainTest.test_exception_raised):
  15631. 2012-06-28 Dirk Pranke <dpranke@chromium.org>
  15632. nrwt: clean up passing of log messages between processes
  15633. https://bugs.webkit.org/show_bug.cgi?id=90123
  15634. Reviewed by Ojan Vafai.
  15635. It turns out log messages are perfectly picklable by themselves
  15636. and contain the process id of the process that generated the
  15637. message, so if we just pass the record from the worker to the
  15638. manager and call logger.handle() in the manager, everything just
  15639. works :).
  15640. The change is covered by existing tests.
  15641. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  15642. (Manager._log_messages):
  15643. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  15644. (_WorkerLogHandler.emit):
  15645. * Scripts/webkitpy/layout_tests/views/metered_stream.py:
  15646. (MeteredStream.__init__):
  15647. (_LogHandler.emit):
  15648. 2012-06-28 Dirk Pranke <dpranke@chromium.org>
  15649. add a pylint wrapper for linting python code
  15650. https://bugs.webkit.org/show_bug.cgi?id=90232
  15651. Reviewed by Adam Barth.
  15652. Currently we use 'pep8' to check python code in
  15653. check-webkit-style. pep8 is fast but simple; pylint is slower
  15654. but has much more robust linting capabilities and will catch
  15655. variable typos and all sorts of other things. Eventually we
  15656. should switch check-webkit-style to use this, but our code is
  15657. far from linting now so it needs to be cleaned up first.
  15658. This change adds the infrastructure and a wrapper so we can
  15659. start doing that.
  15660. * Scripts/lint-webkitpy: Added.
  15661. * Scripts/webkitpy/pylintrc: Added.
  15662. * Scripts/webkitpy/thirdparty/__init__.py:
  15663. (AutoinstallImportHook.find_module):
  15664. (AutoinstallImportHook._install_pylint):
  15665. 2012-06-28 Tony Chang <tony@chromium.org>
  15666. [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
  15667. https://bugs.webkit.org/show_bug.cgi?id=90215
  15668. Reviewed by Martin Robinson.
  15669. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  15670. (initializeFonts): Check for WEBKITOUTPUTDIR first.
  15671. * Scripts/webkitpy/layout_tests/port/gtk.py:
  15672. (GtkPort.setup_environ_for_server): Copy the environment variable to the child process.
  15673. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
  15674. (WTR::inititializeFontConfigSetting): Check for WEBKITOUTPUTDIR first.
  15675. 2012-06-28 Dirk Pranke <dpranke@chromium.org>
  15676. derive ChromiumPort from WebKitPort in NRWT in order to support skipping tests if symbols are missing
  15677. https://bugs.webkit.org/show_bug.cgi?id=89706
  15678. Reviewed by Ojan Vafai.
  15679. Try again to land the change first landed in r121363. This patch
  15680. adds a bunch more tests and reworks the handling of
  15681. port-specific default values for --pixel-tests and --time-out-ms
  15682. to be more consistent (adding a default_pixel_tests() method,
  15683. pushing the webkit default_timeout_ms() value up into base.py,
  15684. and overriding it properly in the chromium and apple mac ports.
  15685. Also change the logic in
  15686. run_webkit_tests._setup_derived_options() to not second-guess
  15687. what the port wants the timeout value to be for debug builds;
  15688. computing this in two different places led to several bugs.
  15689. This change also changes the Chromium unittest ports to derive
  15690. from ChromiumPortTestCase instead of PortTestCase, so that we
  15691. ensure that we're running the same tests on all port variants
  15692. more easily. There's more cleanup that can be done here, but
  15693. this is good enough for now
  15694. * Scripts/webkitpy/layout_tests/port/base.py:
  15695. (Port.default_pixel_tests):
  15696. (Port):
  15697. (Port.default_timeout_ms):
  15698. * Scripts/webkitpy/layout_tests/port/chromium.py:
  15699. (ChromiumPort):
  15700. (ChromiumPort.__init__):
  15701. (ChromiumPort.default_pixel_tests):
  15702. (ChromiumPort.default_timeout_ms):
  15703. (ChromiumPort.driver_name):
  15704. (ChromiumPort._driver_class):
  15705. (ChromiumPort._missing_symbol_to_skipped_tests):
  15706. (ChromiumPort.skipped_layout_tests):
  15707. (ChromiumPort.setup_test_run):
  15708. (ChromiumPort._path_to_image_diff):
  15709. (ChromiumPort._convert_path):
  15710. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  15711. (ChromiumAndroidPortTest):
  15712. (ChromiumAndroidPortTest.test_expectations_files):
  15713. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  15714. (ChromiumLinuxPort._modules_to_search_for_symbols):
  15715. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  15716. (ChromiumLinuxPortTest):
  15717. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  15718. (ChromiumMacPort._modules_to_search_for_symbols):
  15719. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  15720. (ChromiumMacPortTest):
  15721. * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
  15722. split off from chromium_unittest.
  15723. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  15724. (ChromiumWinPort._modules_to_search_for_symbols):
  15725. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  15726. (ChromiumWinTest):
  15727. * Scripts/webkitpy/layout_tests/port/mac.py:
  15728. (MacPort.default_timeout_ms):
  15729. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  15730. (MacTest.test_default_timeout_ms):
  15731. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  15732. (MockDRTPort.start_http_server):
  15733. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  15734. (PortTestCase.test_default_timeout_ms):
  15735. (PortTestCase):
  15736. (PortTestCase.test_default_pixel_tests):
  15737. * Scripts/webkitpy/layout_tests/port/test.py:
  15738. (TestPort.default_pixel_tests):
  15739. * Scripts/webkitpy/layout_tests/port/webkit.py:
  15740. (WebKitPort._modules_to_search_for_symbols):
  15741. (WebKitPort):
  15742. (WebKitPort._symbols_string):
  15743. (WebKitPort._skipped_tests_for_unsupported_features):
  15744. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  15745. (TestWebKitPort._symbols_string):
  15746. (TestWebKitPort._tests_for_disabled_features):
  15747. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  15748. (_set_up_derived_options):
  15749. 2012-06-28 Joshua Bell <jsbell@chromium.org>
  15750. run-bindings-tests should return non-zero exit code on test failure
  15751. https://bugs.webkit.org/show_bug.cgi?id=90205
  15752. Reviewed by Adam Barth.
  15753. * Scripts/run-bindings-tests:
  15754. (main):
  15755. 2012-06-28 Terry Anderson <tdanderson@chromium.org>
  15756. [chromium] Reset the device scale factor to 1 before each test is run
  15757. https://bugs.webkit.org/show_bug.cgi?id=90212
  15758. Reviewed by Adam Barth.
  15759. Some tests change the device scale factor, so this needs to be reset to
  15760. 1.0 at the start of each test to avoid test flakiness.
  15761. * DumpRenderTree/chromium/LayoutTestController.cpp:
  15762. (LayoutTestController::reset):
  15763. 2012-06-28 Ryosuke Niwa <rniwa@webkit.org>
  15764. Cleanup HTMLFormCollection
  15765. https://bugs.webkit.org/show_bug.cgi?id=90111
  15766. Reviewed by Andreas Kling.
  15767. Add a WebKit API test using copy-paste design pattern per kling's request.
  15768. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  15769. * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html: Added.
  15770. * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm: Added.
  15771. (-[HTMLFormCollectionNamedItemTest webView:didFinishLoadForFrame:]):
  15772. (TestWebKitAPI):
  15773. (TestWebKitAPI::TEST):
  15774. 2012-06-28 Tim Horton <timothy_horton@apple.com>
  15775. [mac] WKTR windows still don't stay off screen sometimes
  15776. https://bugs.webkit.org/show_bug.cgi?id=90214
  15777. <rdar://problem/11760263>
  15778. Reviewed by Simon Fraser.
  15779. In some cases, the system itself will consult [WebKitTestRunnerWindow frame], so we should refrain from
  15780. overriding it and instead provide a different method to use when we want the web-facing "fake" window origin
  15781. (for PlatformWebView::windowFrame()).
  15782. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  15783. (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
  15784. (WTR::PlatformWebView::windowFrame):
  15785. 2012-06-28 Martin Robinson <mrobinson@igalia.com>
  15786. [GTK] Add unit tests for GtkInputMethodFilter
  15787. https://bugs.webkit.org/show_bug.cgi?id=88698
  15788. Reviewed by Carlos Garcia Campos.
  15789. Add unit tests for GtkInputMethodFilter in the WebCore platform layer.
  15790. This change adds the TestGtk test suite which will be used for all non-API
  15791. layer GTK unit tests.
  15792. * TestWebKitAPI/GNUmakefile.am: Update the build to include the new tests.
  15793. * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Added.
  15794. (TestWebKitAPI::PlatformWebView::PlatformWebView): Remove the call to gtk_init here
  15795. as it's now in main.cpp.
  15796. * TestWebKitAPI/gtk/main.cpp: Change the g_type_init call to gtk_init, because now
  15797. a majority of all unit tests depend on GTK+ being initialized.
  15798. 2012-06-28 Christophe Dumez <christophe.dumez@intel.com>
  15799. [EFL] Enable support for HTML5 datalist
  15800. https://bugs.webkit.org/show_bug.cgi?id=90157
  15801. Reviewed by Martin Robinson.
  15802. Turn on DATALIST flag by default on EFL port to
  15803. support HTML5 datalist tag.
  15804. * Scripts/webkitperl/FeatureList.pm:
  15805. 2012-06-28 Tony Chang <tony@chromium.org>
  15806. Enable CSS grid layout LayoutTests on platform Mac
  15807. https://bugs.webkit.org/show_bug.cgi?id=90113
  15808. Reviewed by Ojan Vafai.
  15809. * DumpRenderTree/mac/DumpRenderTree.mm:
  15810. (resetDefaultsToConsistentValues): Reset the value to NO between tests.
  15811. 2012-06-28 Mike Fenton <mifenton@rim.com>
  15812. [BlackBerry] Add watchlist options for Blackberry and editing.
  15813. https://bugs.webkit.org/show_bug.cgi?id=90193
  15814. Unreviewed.
  15815. Add BlackBerry and Editing watchlist and monitor them.
  15816. * Scripts/webkitpy/common/config/watchlist:
  15817. 2012-06-28 Tim Horton <timothy_horton@apple.com>
  15818. Unreviewed, upgrade myself to a reviewer!
  15819. http://www.webkit.org/blog/2082/tim-horton-is-now-a-webkit-reviewer/
  15820. * Scripts/webkitpy/common/config/committers.py:
  15821. 2012-06-28 Terry Anderson <tdanderson@chromium.org>
  15822. [Chromium] Chromium's LayoutTestController is missing setBackingScaleFactor
  15823. https://bugs.webkit.org/show_bug.cgi?id=83635
  15824. Reviewed by Adam Barth.
  15825. Added InvokeCallbackTask, a new derived class of MethodTask. When
  15826. setBackingScaleFactor is called, a call to setDeviceScaleFactor in
  15827. WebView is made and then postTask is used to invoke the callback
  15828. function specified in testRunner.setBackingScaleFactor.
  15829. * DumpRenderTree/chromium/LayoutTestController.cpp:
  15830. (LayoutTestController::LayoutTestController):
  15831. (InvokeCallbackTask):
  15832. (InvokeCallbackTask::InvokeCallbackTask):
  15833. (InvokeCallbackTask::runIfValid):
  15834. (LayoutTestController::setBackingScaleFactor):
  15835. * DumpRenderTree/chromium/LayoutTestController.h:
  15836. (LayoutTestController):
  15837. 2012-06-28 Ojan Vafai <ojan@chromium.org>
  15838. Make rebaseline-test and rebaseline-expectations work for non-Chromium ports
  15839. https://bugs.webkit.org/show_bug.cgi?id=90186
  15840. Reviewed by Adam Barth.
  15841. This makes rebaselining work for all ports that have a TestExpectations file
  15842. in the tree. I didn't test other ports.
  15843. This doesn't address 100% of the problem. The rebaseline code puts the expectations
  15844. in the most specific directory and relies on optimize-baselines to merge baselines
  15845. appropriately. This only works if every platform directory has an equivalent bot
  15846. that runs the tests, which is not true for most ports.
  15847. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  15848. (Builder._revision_and_build_for_filename):
  15849. Some bots have filenames that aren't revision/build number pairs
  15850. e.g. they are random junk like aQhxvx. Handle this gracefully.
  15851. (Builder._fetch_revision_to_build_map):
  15852. (Builder._file_info_list_to_revision_to_build_list):
  15853. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  15854. (BuilderTest.test_build_and_revision_for_filename):
  15855. (BuilderTest.test_file_info_list_to_revision_to_build_list):
  15856. * Scripts/webkitpy/layout_tests/port/builders.py:
  15857. Update the list of builders. This list needs to be kept up
  15858. to date for the rebaseline tool to work.
  15859. * Scripts/webkitpy/tool/commands/rebaseline.py:
  15860. (RebaselineTest._results_url):
  15861. (RebaselineExpectations._run_webkit_patch):
  15862. (RebaselineExpectations._rebaseline_port):
  15863. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  15864. Qt port uses qmake to determine the right version. Systems without qmake correctly fallback
  15865. to a specific version.
  15866. 2012-06-28 Csaba Osztrogonác <ossy@webkit.org>
  15867. [Qt][NRWT] Fix baseline and skipped file search path.
  15868. https://bugs.webkit.org/show_bug.cgi?id=89882
  15869. Unreviewed trivial typo fix after r121430.
  15870. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  15871. (QtPortTest._assert_search_path):
  15872. (QtPortTest._assert_skipped_path):
  15873. 2012-06-28 János Badics <jbadics@inf.u-szeged.hu>
  15874. [Qt][NRWT] Fix baseline and skipped file search path.
  15875. https://bugs.webkit.org/show_bug.cgi?id=89882
  15876. Reviewed by Csaba Osztrogonác.
  15877. * Scripts/webkitpy/layout_tests/port/qt.py:
  15878. (QtPort._search_paths):
  15879. (QtPort):
  15880. (QtPort.baseline_search_path):
  15881. (QtPort._skipped_file_search_paths):
  15882. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  15883. (QtPortTest):
  15884. (QtPortTest._assert_skipped_path):
  15885. (QtPortTest.test_baseline_search_path):
  15886. (QtPortTest.test_skipped_file_search_path):
  15887. 2012-06-28 Alexander Pavlov <apavlov@chromium.org>
  15888. [Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS)
  15889. https://bugs.webkit.org/show_bug.cgi?id=90167
  15890. Reviewed by Csaba Osztrogonác.
  15891. DRT should remove user stylesheets from the page group when resetting before running another test.
  15892. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  15893. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  15894. 2012-06-28 Csaba Osztrogonác <ossy@webkit.org>
  15895. [Qt][DRT] Reset AcceleratedCompositingEnabled between tests
  15896. https://bugs.webkit.org/show_bug.cgi?id=90164
  15897. Reviewed by Simon Hausmann.
  15898. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  15899. (WebCore::WebPage::resetSettings):
  15900. 2012-06-28 Csaba Osztrogonác <ossy@webkit.org>
  15901. [Qt] Restore original value of mock scrollbars between tests
  15902. https://bugs.webkit.org/show_bug.cgi?id=90155
  15903. Reviewed by Simon Hausmann.
  15904. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  15905. (WebCore::WebPage::resetSettings):
  15906. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  15907. (LayoutTestController::setMockScrollbarsEnabled):
  15908. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  15909. (LayoutTestController):
  15910. 2012-06-27 Mark Rowe <mrowe@apple.com>
  15911. <http://webkit.org/b/90096> Building within Xcode sometimes does a full rebuild after building via build-webkit
  15912. We need to ensure that build-webkit uses the same setting for SHARED_PRECOMPS_DIR
  15913. as what Xcode itself will use when building, otherwise switching between the two
  15914. can result in the precompiled headers being rebuilt and thus the entire world
  15915. rebuilding.
  15916. Reviewed by Dan Bernstein.
  15917. * Scripts/webkitdirs.pm:
  15918. (determineBaseProductDir):
  15919. 2012-06-27 Sheriff Bot <webkit.review.bot@gmail.com>
  15920. Unreviewed, rolling out r121363, r121367, r121384, and
  15921. r121390.
  15922. http://trac.webkit.org/changeset/121363
  15923. http://trac.webkit.org/changeset/121367
  15924. http://trac.webkit.org/changeset/121384
  15925. http://trac.webkit.org/changeset/121390
  15926. https://bugs.webkit.org/show_bug.cgi?id=90134
  15927. It broke debug NRWT on GTK and on Qt (Requested by Ossy_NIGHT
  15928. on #webkit).
  15929. * Scripts/webkitpy/layout_tests/port/chromium.py:
  15930. (ChromiumPort):
  15931. (ChromiumPort.__init__):
  15932. (ChromiumPort._check_file_exists):
  15933. (ChromiumPort.default_results_directory):
  15934. (ChromiumPort._driver_class):
  15935. (ChromiumPort._build_path):
  15936. (ChromiumPort._path_to_image_diff):
  15937. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  15938. (ChromiumLinuxPort.baseline_search_path):
  15939. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  15940. (ChromiumMacPort.baseline_search_path):
  15941. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  15942. (ChromiumPortTest):
  15943. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  15944. (ChromiumWinPort.baseline_search_path):
  15945. * Scripts/webkitpy/layout_tests/port/webkit.py:
  15946. (WebKitPort.__init__):
  15947. (WebKitPort._webcore_symbols_string):
  15948. (WebKitPort._skipped_tests_for_unsupported_features):
  15949. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  15950. (TestWebKitPort._webcore_symbols_string):
  15951. (WebKitPortUnitTests.test_default_options):
  15952. 2012-06-27 Dirk Pranke <dpranke@chromium.org>
  15953. Fix typo in r121384 :(
  15954. Unreviewed, build fix.
  15955. * Scripts/webkitpy/layout_tests/port/webkit.py:
  15956. (WebKitPort.default_test_timeout_ms):
  15957. 2012-06-27 Dirk Pranke <dpranke@chromium.org>
  15958. nrwt: default timeout for debug bots broke in r121363
  15959. https://bugs.webkit.org/show_bug.cgi?id=90112
  15960. Unreviewed, build fix.
  15961. I forgot to account for release and debug having different
  15962. default values :(.
  15963. * Scripts/webkitpy/layout_tests/port/chromium.py:
  15964. (ChromiumPort.default_test_timeout_ms):
  15965. * Scripts/webkitpy/layout_tests/port/webkit.py:
  15966. (WebKitPort):
  15967. (WebKitPort.default_test_timeout_ms):
  15968. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  15969. (WebKitPortUnitTests.test_default_options):
  15970. 2012-06-27 Dirk Pranke <dpranke@chromium.org>
  15971. webkitpy: fix a couple of issues running under cygwin
  15972. https://bugs.webkit.org/show_bug.cgi?id=90035
  15973. Reviewed by Eric Seidel.
  15974. These were causing unit tests to fail on cygwin (apple win bot).
  15975. * Scripts/webkitpy/layout_tests/port/chromium.py:
  15976. * Scripts/webkitpy/performance_tests/perftest.py:
  15977. 2012-06-27 Adam Barth <abarth@webkit.org>
  15978. [Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available
  15979. https://bugs.webkit.org/show_bug.cgi?id=89801
  15980. Reviewed by Nate Chapin.
  15981. Let's call SkUseTestFontConfigFile now that it exists.
  15982. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  15983. (platformInit):
  15984. 2012-06-27 Dirk Pranke <dpranke@chromium.org>
  15985. Fix typo introduced in r121363.
  15986. Unreviewed, build fix.
  15987. * Scripts/webkitpy/layout_tests/port/webkit.py:
  15988. (WebKitPort._symbols_string):
  15989. 2012-06-27 Mark Hahnenberg <mhahnenberg@apple.com>
  15990. Moving from committers to reviewers :-)
  15991. Rubber stamped by Filip Pizlo.
  15992. * Scripts/webkitpy/common/config/committers.py:
  15993. 2012-06-27 Dirk Pranke <dpranke@chromium.org>
  15994. Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests
  15995. https://bugs.webkit.org/show_bug.cgi?id=89706
  15996. Reviewed by Adam Barth.
  15997. Based on the original patch by Raymond Toy.
  15998. This patch changes ChromiumPort to derive from webkit.WebKitPort
  15999. instead of base.Port. This is a long-awaited change and a
  16000. precursor to merging base.Port and webkit.WebKitPort, but is
  16001. driven by the desire to dynamically detect whether the MP3 and
  16002. AAC codecs are compiled into DRT on Chromium, for which we
  16003. wanted to re-use the existing logic in WebKit port for determine
  16004. what to skip at compile time.
  16005. Most of the changes are shuffling things around so that we don't
  16006. change any other logic and so we override the necessary methods
  16007. in WebKitPort (and try to follow the same method definition
  16008. order where possible).
  16009. Also, on the Chromium port the mp3 and aac codecs are actually
  16010. defined in a separate library, so scanning webcore isn't
  16011. sufficient. This patch generalizes the symbol lookup to handle
  16012. multiple libraries, and uses different libraries as appropriate
  16013. for Chromium.
  16014. The only functional/visible changes should be in the value
  16015. returned for skipped_layout_tests().
  16016. * Scripts/webkitpy/layout_tests/port/chromium.py:
  16017. (ChromiumPort):
  16018. (ChromiumPort.__init__):
  16019. (ChromiumPort.driver_name):
  16020. (ChromiumPort._driver_class):
  16021. (ChromiumPort._missing_symbol_to_skipped_tests):
  16022. (ChromiumPort.skipped_layout_tests):
  16023. (ChromiumPort.setup_test_run):
  16024. (ChromiumPort._path_to_image_diff):
  16025. (ChromiumPort._convert_path):
  16026. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  16027. (ChromiumPortTest.test_missing_symbol_to_skipped_tests):
  16028. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  16029. (ChromiumLinuxPort._modules_to_search_for_symbols):
  16030. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  16031. (ChromiumLinuxPort._modules_to_search_for_symbols):
  16032. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  16033. (ChromiumLinuxPort._modules_to_search_for_symbols):
  16034. * Scripts/webkitpy/layout_tests/port/webkit.py:
  16035. (WebKitPort):
  16036. (WebKitPort.__init__):
  16037. (WebKitPort._symbols_string):
  16038. (WebKitPort._modules_to_search_for_symbols):
  16039. 2012-06-27 Csaba Osztrogonác <ossy@webkit.org>
  16040. [Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
  16041. https://bugs.webkit.org/show_bug.cgi?id=90081
  16042. Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.
  16043. Reviewed by Noam Rosenthal.
  16044. * qmake/mkspecs/features/features.prf:
  16045. 2012-06-27 Sergio Villar Senin <svillar@igalia.com>
  16046. [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
  16047. https://bugs.webkit.org/show_bug.cgi?id=90061
  16048. Reviewed by Gustavo Noronha Silva.
  16049. Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
  16050. this flag libtool tells the linker to set the rpath for the output
  16051. file to the full path of the .libs directory, instead of using a
  16052. wrapper script to set up the LD_LIBRARY_PATH. This will allow us
  16053. to directly reuse builds in the pure testing bots.
  16054. * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
  16055. 2012-06-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  16056. [Qt] No need to save and restore TEMPLATE in a function
  16057. This was a leftover from when the logic was not in its own function scope.
  16058. QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
  16059. will surprisingly affect the global scope as well, so we have to save and restore it.
  16060. Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
  16061. Reviewed by Tor Arne Vestbø.
  16062. * qmake/mkspecs/features/functions.prf:
  16063. 2012-06-27 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  16064. [Qt] Fix lookup location for sqlite sources
  16065. Don't look in the install dir - we are unlikely to find anything there
  16066. unless we are doing a developer build.
  16067. Reviewed by Tor Arne Vestbø.
  16068. * qmake/mkspecs/features/features.prf:
  16069. 2012-06-27 Zan Dobersek <zandobersek@gmail.com>
  16070. [Gtk] Add support for the Gamepad API
  16071. https://bugs.webkit.org/show_bug.cgi?id=87503
  16072. Reviewed by Carlos Garcia Campos.
  16073. Enable the gamepad support for the GTK port.
  16074. * Scripts/webkitperl/FeatureList.pm:
  16075. 2012-06-27 Ryosuke Niwa <rniwa@webkit.org>
  16076. Fix gcc build after r121302
  16077. https://bugs.webkit.org/show_bug.cgi?id=90055
  16078. Reviewed by Mark Rowe.
  16079. Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
  16080. It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
  16081. * TestWebKitAPI/Configurations/Base.xcconfig:
  16082. * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
  16083. (TestWebKitAPI::AcceptsFirstMouse::runTest):
  16084. 2012-06-27 Csaba Osztrogonác <ossy@webkit.org>
  16085. Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
  16086. https://bugs.webkit.org/show_bug.cgi?id=89564
  16087. Reviewed by Tony Chang.
  16088. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  16089. (BuildStepsConstructorTest):
  16090. (BuildStepsConstructorTest.generateTests):
  16091. (BuildStepsConstructorTest.createTest):
  16092. (BuildStepsConstructorTest.createTest.doTest):
  16093. 2012-06-26 Mark Hahnenberg <mhahnenberg@apple.com>
  16094. Add support for preciseTime() to WebKitTestRunner
  16095. https://bugs.webkit.org/show_bug.cgi?id=90027
  16096. Reviewed by Darin Adler.
  16097. It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
  16098. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  16099. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  16100. (WTR::LayoutTestController::preciseTime):
  16101. (WTR):
  16102. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  16103. (LayoutTestController):
  16104. 2012-06-26 Lucas Forschler <lforschler@apple.com>
  16105. Teach the Apple port how to build the test tools in build-webkit
  16106. https://bugs.webkit.org/show_bug.cgi?id=89540
  16107. Reviewed by Jon Lee & Simon Fraser.
  16108. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  16109. (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
  16110. (RunUnitTests.start): ditto
  16111. * Scripts/build-webkit: add tools to the projects build list
  16112. 2012-06-26 Ojan Vafai <ojan@chromium.org>
  16113. Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
  16114. https://bugs.webkit.org/show_bug.cgi?id=90025
  16115. Reviewed by Simon Fraser.
  16116. Move the chromium-specific filtering code into config.js and replace it with a method on each platform
  16117. config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
  16118. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  16119. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  16120. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  16121. 2012-06-26 Ojan Vafai <ojan@chromium.org>
  16122. Fix failing garden-o-matic unittests
  16123. https://bugs.webkit.org/show_bug.cgi?id=90021
  16124. Reviewed by Adam Barth.
  16125. These had all just fallen out of date.
  16126. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  16127. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  16128. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  16129. 2012-06-26 Ojan Vafai <ojan@chromium.org>
  16130. Fix platform picker change handler in garden-o-matic
  16131. https://bugs.webkit.org/show_bug.cgi?id=90010
  16132. Reviewed by Simon Fraser.
  16133. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  16134. The old code never worked. This is hard to test because change handlers require
  16135. a user-initiated action and the code is changing the window's location, which would
  16136. navigate the test page.
  16137. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
  16138. Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
  16139. due to the large margin-bottom.
  16140. 2012-06-26 Thiago Marcos P. Santos <thiago.santos@intel.com>
  16141. webkitpy: Make webkit-patch patches-to-review useful
  16142. https://bugs.webkit.org/show_bug.cgi?id=89470
  16143. Reviewed by Eric Seidel.
  16144. webkit-patch patches-to-review will now output the list of
  16145. bugs with patches pending for review that has the user on CC,
  16146. excluding patches with cq-, sorted by the age of the patch.
  16147. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  16148. (BugzillaQueries.fetch_bugs_from_review_queue):
  16149. * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
  16150. (MockBugzillaQueries.fetch_bugs_from_review_queue):
  16151. (MockBugzilla.__init__):
  16152. (MockBugzilla.authenticate):
  16153. * Scripts/webkitpy/tool/commands/queries.py:
  16154. (PatchesToReview):
  16155. (PatchesToReview.__init__):
  16156. (PatchesToReview._print_report):
  16157. (PatchesToReview._generate_report):
  16158. (PatchesToReview.execute):
  16159. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  16160. (QueryCommandsTest.test_patches_to_review):
  16161. 2012-06-26 Dirk Pranke <dpranke@chromium.org>
  16162. nrwt: broken for chromium on vista
  16163. https://bugs.webkit.org/show_bug.cgi?id=89988
  16164. Reviewed by Tony Chang.
  16165. r121194 removed support for 'chromium-win-vista' as a separate
  16166. port, but this actually prevented the code from running on vista
  16167. at all, which is unduly harsh and broke the websocket tests on
  16168. the (non-webkit) chromium bots that are still running on vista.
  16169. It's probably good enough to pretend that vista is win7 instead;
  16170. some layout tests will still fail but at least things'll run.
  16171. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  16172. (ChromiumWinPort.determine_full_port_name):
  16173. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  16174. (ChromiumWinTest.test_versions):
  16175. 2012-06-26 Csaba Osztrogonác <ossy@webkit.org>
  16176. master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
  16177. https://bugs.webkit.org/show_bug.cgi?id=89215
  16178. We need it because it is deprecated and will be dropped in buildbot 0.8.7
  16179. Reviewed by Tony Chang.
  16180. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  16181. (CheckOutSource.__init__):
  16182. (Factory.__init__):
  16183. 2012-06-26 Simon Hausmann <simon.hausmann@nokia.com>
  16184. [Qt][Win] Symbols are not exported in QtWebKit5.dll
  16185. https://bugs.webkit.org/show_bug.cgi?id=88873
  16186. Reviewed by Tor Arne Vestbø.
  16187. When linking the target dll make sure to re-export the symbols from
  16188. the static libraries marked as export, with the help of a little python
  16189. script and a qmake extra compiler.
  16190. * Scripts/generate-win32-export-forwards: Added.
  16191. * qmake/mkspecs/features/win32/default_post.prf:
  16192. 2012-06-25 Jocelyn Turcotte <turcotte.j@gmail.com>
  16193. Add a note about hostname completion not working well with --cc completion
  16194. Reviewed by Simon Hausmann.
  16195. Hostname completion tries to resolve anything after an @ sign which is present
  16196. in the completed list of contributor emails to CC.
  16197. * Scripts/webkit-tools-completion.sh:
  16198. 2012-06-26 Sheriff Bot <webkit.review.bot@gmail.com>
  16199. Unreviewed, rolling out r121244.
  16200. http://trac.webkit.org/changeset/121244
  16201. https://bugs.webkit.org/show_bug.cgi?id=89966
  16202. skip list path is incorrect now. (Requested by Ossy on
  16203. #webkit).
  16204. * Scripts/webkitpy/layout_tests/port/qt.py:
  16205. (QtPort.baseline_search_path):
  16206. (QtPort._skipped_file_search_paths):
  16207. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  16208. (QtPortTest.test_baseline_search_path):
  16209. 2012-06-26 János Badics <jbadics@inf.u-szeged.hu>
  16210. [Qt][NRWT] Fix baseline and skipped file search path.
  16211. https://bugs.webkit.org/show_bug.cgi?id=89882
  16212. Reviewed by Csaba Osztrogonác.
  16213. * Scripts/webkitpy/layout_tests/port/qt.py:
  16214. (QtPort.baseline_search_path):
  16215. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  16216. (QtPortTest.test_baseline_search_path):
  16217. 2012-06-26 Tony Chang <tony@chromium.org>
  16218. [Qt] Enable grid layout LayoutTests
  16219. https://bugs.webkit.org/show_bug.cgi?id=89909
  16220. Reviewed by Csaba Osztrogonác.
  16221. These tests pass, we just need to hook up the overridePreference.
  16222. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  16223. (WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
  16224. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  16225. (LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
  16226. 2012-06-26 Sheriff Bot <webkit.review.bot@gmail.com>
  16227. Unreviewed, rolling out r121236.
  16228. http://trac.webkit.org/changeset/121236
  16229. https://bugs.webkit.org/show_bug.cgi?id=89956
  16230. It's broke the nrwt on qt and gtk platform (Requested by
  16231. kkristof on #webkit).
  16232. * Scripts/webkitpy/layout_tests/port/qt.py:
  16233. (QtPort._build_driver):
  16234. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  16235. (XvfbDriver._start):
  16236. (XvfbDriver._start.x_filter):
  16237. (XvfbDriver.stop):
  16238. 2012-06-26 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  16239. [NRWT] XvfbDriver should choose the next free display
  16240. https://bugs.webkit.org/show_bug.cgi?id=88414
  16241. Reviewed by Dirk Pranke.
  16242. * Scripts/webkitpy/layout_tests/port/qt.py:
  16243. (QtPort._driver_class):
  16244. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  16245. (XvfbDriver.__init__):
  16246. (XvfbDriver._start):
  16247. (XvfbDriver._start.next_free_id):
  16248. (XvfbDriver.stop):
  16249. 2012-06-25 Simon Hausmann <simon.hausmann@nokia.com>
  16250. [Qt] Make it possible to build WebKit without QtWidgets
  16251. https://bugs.webkit.org/show_bug.cgi?id=78109
  16252. Reviewed by Tor Arne Vestbø.
  16253. * Tools.pro: Disable various tools that depend on WK1.
  16254. * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
  16255. * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
  16256. * qmake/mkspecs/modules/webkit1.prf: Added.
  16257. 2012-06-25 Dirk Pranke <dpranke@chromium.org>
  16258. put vista back for chromium (non-webkit) bots ...
  16259. https://bugs.webkit.org/show_bug.cgi?id=89929
  16260. Unreviewed, build fix.
  16261. Turns out we've only gotten rid of vista on the webkit tests so
  16262. far. Put vista back for the other chromium bots ...
  16263. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  16264. (chromiumPlatform):
  16265. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  16266. (test):
  16267. 2012-06-25 Dirk Pranke <dpranke@chromium.org>
  16268. update flakiness dashboard after removing chromium-vista bots
  16269. https://bugs.webkit.org/show_bug.cgi?id=89925
  16270. Unreviewed, build fix.
  16271. More changes missed in r121194 :(.
  16272. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  16273. (chromiumPlatform):
  16274. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  16275. (test):
  16276. 2012-06-25 Dirk Pranke <dpranke@chromium.org>
  16277. remove support for chromium vista from tools
  16278. https://bugs.webkit.org/show_bug.cgi?id=89915
  16279. Reviewed by Tony Chang.
  16280. This change is all deleting code and updating tests to handle
  16281. the configuration being gone. All tests now pass except for a
  16282. few unittests for the flakiness dashboard which were failing
  16283. before this patch.
  16284. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  16285. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  16286. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  16287. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  16288. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  16289. (BaselineOptimizerTest.test_complex_shadowing):
  16290. * Scripts/webkitpy/layout_tests/port/builders.py:
  16291. * Scripts/webkitpy/layout_tests/port/chromium.py:
  16292. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  16293. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  16294. (ChromiumWinPort):
  16295. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  16296. (ChromiumWinTest.test_versions):
  16297. (ChromiumWinTest.test_baseline_path):
  16298. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  16299. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  16300. (BuildCoverageExtrapolatorTest.test_extrapolate):
  16301. 2012-06-25 Scott Graham <scottmg@chromium.org>
  16302. [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
  16303. https://bugs.webkit.org/show_bug.cgi?id=89907
  16304. Not reviewed. Fix build in Chromium.
  16305. * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
  16306. (WebThemeEngineDRTWin::getSize):
  16307. * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
  16308. (WebThemeEngineDRTWin):
  16309. 2012-06-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  16310. [EFL] Implement Network Information API
  16311. https://bugs.webkit.org/show_bug.cgi?id=87067
  16312. Reviewed by Kenneth Rohde Christiansen.
  16313. * efl/jhbuild.modules: Add eeze library dependency.
  16314. 2012-06-25 Simon Hausmann <simon.hausmann@nokia.com>
  16315. [Qt] Fix Win32 debug build
  16316. Reviewed by Tor Arne Vestbø.
  16317. Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
  16318. * qmake/mkspecs/features/unix/default_pre.prf:
  16319. * qmake/mkspecs/features/win32/default_pre.prf: Added.
  16320. 2012-06-24 Thiago Marcos P. Santos <thiago.santos@intel.com>
  16321. [Qt] Enable <input type="color"> support by default
  16322. https://bugs.webkit.org/show_bug.cgi?id=89653
  16323. Reviewed by Kenneth Rohde Christiansen.
  16324. This feature is complete for Qt WebKit2. Enabling by default
  16325. will help to mature the implementation.
  16326. * Scripts/webkitperl/FeatureList.pm:
  16327. * qmake/mkspecs/features/features.pri:
  16328. 2012-06-24 Dan Bernstein <mitz@apple.com>
  16329. Made debug-{minibrowser,safari,test-runner} work with LLDB.
  16330. Reviewed by Sam Weinig.
  16331. * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
  16332. printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
  16333. * Scripts/debug-safari: Ditto.
  16334. * Scripts/debug-test-runner: Ditto.
  16335. * Scripts/webkitdirs.pm:
  16336. (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
  16337. (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
  16338. and to "gdb" otherwise.
  16339. (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
  16340. --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
  16341. (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
  16342. 2012-06-24 Adam Barth <abarth@webkit.org>
  16343. [Chromium] Release media resources after each LayoutTest on Android
  16344. https://bugs.webkit.org/show_bug.cgi?id=89720
  16345. Reviewed by Eric Carlson.
  16346. The LayoutTests can hang when run on Android because we sometimes run
  16347. out of media resources. This patch causes us to release our media
  16348. resources after each test in order to avoid running out of this
  16349. resource. In production, there are other mechanisms that manage this
  16350. resource.
  16351. * DumpRenderTree/chromium/TestShell.cpp:
  16352. (TestShell::resetTestController):
  16353. 2012-06-23 Zan Dobersek <zandobersek@gmail.com>
  16354. [Gtk] REGRESSION(r120918): Causes flaky DND tests
  16355. https://bugs.webkit.org/show_bug.cgi?id=89770
  16356. Reviewed by Martin Robinson.
  16357. Connect to the run-file-chooser signal of the WebKitWebView and
  16358. return TRUE so no file chooser dialog is run. This prevents certain
  16359. test failures.
  16360. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  16361. (webViewRunFileChooser):
  16362. (createWebView):
  16363. 2012-06-23 Dan Bernstein <mitz@apple.com>
  16364. debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
  16365. Reviewed by Sam Weinig.
  16366. * Scripts/webkitdirs.pm:
  16367. (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
  16368. 2012-06-23 Carlos Garcia Campos <cgarcia@igalia.com>
  16369. Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
  16370. It fails always when running it in Xvfb.
  16371. * gtk/run-api-tests:
  16372. (TestRunner):
  16373. 2012-06-23 Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com>
  16374. [GTK][WK2]Mis-spelt defaultWindowTitle
  16375. https://bugs.webkit.org/show_bug.cgi?id=89808
  16376. Reviewed by Carlos Garcia Campos.
  16377. * MiniBrowser/gtk/BrowserWindow.c:
  16378. 2012-06-23 Sergio Villar Senin <svillar@igalia.com>
  16379. [GTK] Add a new webkit2 tests slave bot
  16380. https://bugs.webkit.org/show_bug.cgi?id=89336
  16381. Reviewed by Csaba Osztrogonác.
  16382. Slave configuration for a new GTK 64 bit release bot that will run
  16383. WebKit2 tests.
  16384. Also BuildAndTest now accepts the "triggers" parametter,
  16385. this means that apart from building and testing it can trigger
  16386. some other build/test sequences in other slaves.
  16387. * BuildSlaveSupport/build.webkit.org-config/config.json:
  16388. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  16389. (BuildAndTestFactory.__init__):
  16390. 2012-06-23 Kwang Yul Seo <skyul@company100.net>
  16391. Unreviewed. Update my email.
  16392. * Scripts/webkitpy/common/config/committers.py:
  16393. 2012-06-22 Adam Barth <abarth@webkit.org>
  16394. [Chromium] DumpRenderTree on Android needs to configure fonts for testing
  16395. https://bugs.webkit.org/show_bug.cgi?id=89721
  16396. Reviewed by Nate Chapin.
  16397. This patch teaches DumpRenderTree to configure Skia to use the fallback
  16398. fonts that the LayoutTests assume. This patch reduces the number result
  16399. differences between chromium-android and chromium-linux.
  16400. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  16401. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  16402. (platformInit):
  16403. * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
  16404. * DumpRenderTree/chromium/android_main_fonts.xml: Added.
  16405. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  16406. 2012-06-22 Alexandru Chiculita <achicu@adobe.com>
  16407. [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
  16408. https://bugs.webkit.org/show_bug.cgi?id=89781
  16409. Reviewed by Dean Jackson.
  16410. Added CSS Shaders as enabled by default on Safari for Mac.
  16411. * Scripts/webkitperl/FeatureList.pm:
  16412. 2012-06-22 Adam Barth <abarth@webkit.org>
  16413. Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
  16414. https://bugs.webkit.org/show_bug.cgi?id=89791
  16415. Reviewed by Dirk Pranke.
  16416. Downstream, the chromium-android port maintains a test expectations
  16417. file to keep track of which tests pass or fail. That causes them to
  16418. keep a patch in chromium_android.py in their branch.
  16419. This patch teaches chromium_android.py to use test_expectations_android.txt.
  16420. We don't intend to use this file upstream, but having this code patch
  16421. upstream lets us unfork webkitpy.
  16422. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  16423. (ChromiumAndroidPort.expectations_files):
  16424. 2012-06-22 Dirk Pranke <dpranke@chromium.org>
  16425. run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
  16426. https://bugs.webkit.org/show_bug.cgi?id=89734
  16427. Reviewed by Ryosuke Niwa.
  16428. Fix a crash in ServerProcess if you called .pid() after it
  16429. crashed during a write(). We had a test for this case but the
  16430. test wasn't calling pid(), just has_crashed(). Fixed the problem
  16431. and the test.
  16432. * Scripts/webkitpy/layout_tests/port/server_process.py:
  16433. (ServerProcess.__init__):
  16434. (ServerProcess.pid):
  16435. (ServerProcess._start):
  16436. (ServerProcess.stop):
  16437. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  16438. (FakeServerProcess._start):
  16439. (TestServerProcess.test_broken_pipe):
  16440. 2012-06-22 Peter Beverloo <peter@chromium.org>
  16441. [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
  16442. https://bugs.webkit.org/show_bug.cgi?id=88853
  16443. Reviewed by Steve Block.
  16444. The Android exclusions were necessary to fix a gyp generation error, as
  16445. the gcc_version variable wasn't being defined for Android. Remove these
  16446. exceptions when Chromium is able to define the gcc_version variable.
  16447. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  16448. 2012-06-22 Mario Sanchez Prada <msanchez@igalia.com>
  16449. Unreviewed gardening. Unskipping test passing after fixing bug 88419.
  16450. * gtk/run-api-tests:
  16451. (TestRunner): Unskip WTF.HashMap.
  16452. 2012-06-22 Zoltan Horvath <zoltan@webkit.org>
  16453. [Qt] Allow DumpRenderTree to dump about:blank
  16454. https://bugs.webkit.org/show_bug.cgi?id=89685
  16455. Reviewed by Ryosuke Niwa.
  16456. We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
  16457. additionaly this behavior is required for running WTR performance tests.
  16458. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  16459. (WebCore::DumpRenderTree::processLine):
  16460. 2012-06-21 Adam Barth <abarth@webkit.org>
  16461. [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
  16462. https://bugs.webkit.org/show_bug.cgi?id=89718
  16463. Reviewed by Kent Tamura.
  16464. We should reset this WebSetting to its default value so that it behaves
  16465. consistently across tests.
  16466. * DumpRenderTree/chromium/WebPreferences.cpp:
  16467. (WebPreferences::reset):
  16468. (WebPreferences::applyTo):
  16469. * DumpRenderTree/chromium/WebPreferences.h:
  16470. (WebPreferences):
  16471. 2012-06-21 Zoltan Horvath <zoltan@webkit.org>
  16472. DRT/WTR python interface handles about:blank incorrectly
  16473. https://bugs.webkit.org/show_bug.cgi?id=89563
  16474. Reviewed by Dirk Pranke.
  16475. Currently DRT/WTR python interface's _command_from_driver_input function
  16476. puts the test directory path before about:blank. Remove this incorrect behavior.
  16477. * Scripts/webkitpy/layout_tests/port/webkit.py:
  16478. (WebKitDriver._command_from_driver_input):
  16479. 2012-06-21 Dirk Pranke <dpranke@chromium.org>
  16480. reenable perf tests on win
  16481. https://bugs.webkit.org/show_bug.cgi?id=89690
  16482. Reviewed by Ryosuke Niwa.
  16483. Only the replay tests don't work, and those are disabled by
  16484. default. This change also fixes the undefined _log reference
  16485. that was causing a crash.
  16486. * Scripts/run-perf-tests:
  16487. 2012-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
  16488. Unreviewed, rolling out r120937.
  16489. http://trac.webkit.org/changeset/120937
  16490. https://bugs.webkit.org/show_bug.cgi?id=89679
  16491. This patch brought buildbot master down (Requested by svillar
  16492. on #webkit).
  16493. * BuildSlaveSupport/build.webkit.org-config/config.json:
  16494. 2012-06-21 Martin Robinson <mrobinson@igalia.com>
  16495. [GTK] Combine WebKit API tests into fewer binaries
  16496. https://bugs.webkit.org/show_bug.cgi?id=88458
  16497. Reviewed by Carlos Garcia Campos.
  16498. Instead of creating one binary per-test file, create binaries for each
  16499. category of tests. Right now this includes WTF and the WebKit2 C API,
  16500. but later tests can be added for the GTK+ platform layer and the WebKit1
  16501. and WebKit2 API layers.
  16502. * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
  16503. C API and one for WTF. Refresh the source list to ensure that new test are active.
  16504. * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
  16505. concept of skipping a test and skipping a suite (program) of tests. Test cases are
  16506. skipped because of legitimate failures, but entire programs are skipped because of
  16507. problems in the harness. As of right now a test program is only skipped if the
  16508. accessibility bus cannot be started.
  16509. (SkippedTest.__init__): Make the test case a required argument and have one skipped
  16510. test case per SkippedTest instance.
  16511. (SkippedTest.__str__): Ditto.
  16512. (TestRunner): Update the directory list. We only have two gtest binaries now and they are
  16513. in one directory. Reformat the test list to make it slightly easier to read.
  16514. (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
  16515. test programs that are skipped.
  16516. (TestRunner._setup_testing_environment): Use the new member.
  16517. (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
  16518. the first SkippedTest that matches.
  16519. (TestRunner._should_run_test_program): Take a look at the new member to make this
  16520. decision.
  16521. (TestRunner._run_test_command): Use the name test_program instead of test
  16522. to disambiguate between test cases and test suites.
  16523. (TestRunner._run_test_glib): ditto.
  16524. (TestRunner._run_test_google): Ditto.
  16525. (TestRunner._run_test): Ditto.
  16526. (TestRunner.run_tests): Ditto.
  16527. 2012-06-21 Yong Li <yoli@rim.com>
  16528. Unreviewed. Moving myself from committer to reviewer.
  16529. * Scripts/webkitpy/common/config/committers.py:
  16530. 2012-06-21 Sergio Villar Senin <svillar@igalia.com>
  16531. [GTK] Add a new webkit2 tests slave bot
  16532. https://bugs.webkit.org/show_bug.cgi?id=89336
  16533. Reviewed by Philippe Normand.
  16534. Slave configuration for a new GTK bot that will run WebKit2 tests.
  16535. * BuildSlaveSupport/build.webkit.org-config/config.json:
  16536. 2012-06-21 Thiago Marcos P. Santos <thiago.santos@intel.com>
  16537. [Qt] Add a custom Color Chooser widget to MiniBrowser
  16538. https://bugs.webkit.org/show_bug.cgi?id=87988
  16539. Reviewed by Alexis Menard.
  16540. Added custom color chooser example for the MiniBrowser.
  16541. * MiniBrowser/qt/MiniBrowser.qrc:
  16542. * MiniBrowser/qt/qml/BrowserWindow.qml:
  16543. * MiniBrowser/qt/qml/ColorChooser.qml: Added.
  16544. 2012-06-21 Vivek Galatage <vivekgalatage@gmail.com>
  16545. Remove the warning "File not found" in MiniBrowser post-build event
  16546. https://bugs.webkit.org/show_bug.cgi?id=89601
  16547. Reviewed by Adam Roben.
  16548. * MiniBrowser/MiniBrowserPostBuild.cmd:
  16549. 2012-06-21 Balazs Kelemen <kbalazs@webkit.org>
  16550. [Qt] DRT in standalone mode hangs after the first test
  16551. https://bugs.webkit.org/show_bug.cgi?id=89613
  16552. Reviewed by Csaba Osztrogonác.
  16553. Break an inline signal slot chain that ends up in setting
  16554. LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
  16555. we emit done() which starts the chain that finishes in DumpRenderTree::open().
  16556. The next line in maybeDump sets m_hasDumped to true. We could simply reorder
  16557. these two lines but it seems to be wrong in general to start the next load
  16558. from this call chain. The server mode (when DRT is runned by the test harness)
  16559. also uses a queued connection to read the next test from stdin.
  16560. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  16561. (WebCore::DumpRenderTree::processArgsLine):
  16562. 2012-06-20 Hans Wennborg <hans@chromium.org>
  16563. Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
  16564. https://bugs.webkit.org/show_bug.cgi?id=89217
  16565. Reviewed by Adam Barth.
  16566. Add a method for checking whether the mock speech
  16567. recognition was aborted.
  16568. Also redo the way the mock posts tasks. Instead of posting them all at once,
  16569. maintain an internal queue of task objects, and call postTask() for them
  16570. once at the time. This means that for example when the page is navigated
  16571. away and abort() is called, that call doesn't end up after a bunch
  16572. of previously posted events on the event loop.
  16573. * DumpRenderTree/chromium/LayoutTestController.cpp:
  16574. (LayoutTestController::LayoutTestController):
  16575. (LayoutTestController::wasMockSpeechRecognitionAborted):
  16576. * DumpRenderTree/chromium/LayoutTestController.h:
  16577. (LayoutTestController):
  16578. * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
  16579. (WebKit::ClientCallTask::ClientCallTask):
  16580. (WebKit::ResultTask::ResultTask):
  16581. (WebKit::NoMatchTask::NoMatchTask):
  16582. (WebKit::ErrorTask::ErrorTask):
  16583. (MockWebSpeechRecognizer::start):
  16584. (MockWebSpeechRecognizer::abort):
  16585. (MockWebSpeechRecognizer::setError):
  16586. (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
  16587. (MockWebSpeechRecognizer::startTaskQueue):
  16588. (MockWebSpeechRecognizer::StepTask::runIfValid):
  16589. * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
  16590. (MockWebSpeechRecognizer::hasBeenAborted):
  16591. (MockWebSpeechRecognizer):
  16592. (MockWebSpeechRecognizer::taskList):
  16593. (Task):
  16594. (MockWebSpeechRecognizer::Task::Task):
  16595. (MockWebSpeechRecognizer::Task::~Task):
  16596. (StepTask):
  16597. (MockWebSpeechRecognizer::StepTask::StepTask):
  16598. 2012-06-21 Mario Sanchez Prada <msanchez@igalia.com>
  16599. [GTK] Add support for window.showModalDialog in WebKit2GTK+
  16600. https://bugs.webkit.org/show_bug.cgi?id=79500
  16601. Reviewed by Carlos Garcia Campos.
  16602. Add support for modal dialogs in GTK's MiniBrowser.
  16603. * MiniBrowser/gtk/BrowserWindow.c:
  16604. (webViewRunAsModal):
  16605. (webViewCreate):
  16606. (webViewDecidePolicy):
  16607. (browser_window_new):
  16608. * MiniBrowser/gtk/BrowserWindow.h:
  16609. * MiniBrowser/gtk/main.c:
  16610. (createBrowserWindow):
  16611. 2012-06-20 Brent Fulgham <bfulgham@webkit.org>
  16612. [WinCairo] Unreviewed build fix.
  16613. The wrapper script that launched new- and old-run-webkit-tests
  16614. was discarding the --wincairo argument needed to get the proper
  16615. test infrastructure to build under WinCairo.
  16616. * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
  16617. behavior to chain the --wincairo flag through to the new build
  16618. and test scripts.
  16619. 2012-06-20 Mark Rowe <mrowe@apple.com>
  16620. <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
  16621. Reviewed by Dan Bernstein.
  16622. * Scripts/webkitdirs.pm:
  16623. (executableHasEntitlements):
  16624. (safariPathFromSafariBundle):
  16625. 2012-06-20 Sheriff Bot <webkit.review.bot@gmail.com>
  16626. Unreviewed, rolling out r120821.
  16627. http://trac.webkit.org/changeset/120821
  16628. https://bugs.webkit.org/show_bug.cgi?id=89605
  16629. It made duplicated reviewer entries (Requested by Ossy on
  16630. #webkit).
  16631. * Scripts/webkitpy/common/checkout/changelog.py:
  16632. (ChangeLog.set_reviewer):
  16633. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  16634. (test_set_reviewer):
  16635. (test_set_short_description_and_bug_url):
  16636. 2012-06-20 Dirk Pranke <dpranke@chromium.org>
  16637. nrwt outputs empty files for wdiff output if wdiff is not installed
  16638. https://bugs.webkit.org/show_bug.cgi?id=88709
  16639. Reviewed by Tony Chang.
  16640. Reviewed by Tony Chang.
  16641. Don't write -wdiff or -pretty.html files if wdiff or prettypatch
  16642. aren't available, and clean up the handling for them in the port
  16643. code.
  16644. * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
  16645. (MainTest.test_output_diffs):
  16646. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  16647. (TestResultWriter.create_text_diff_and_write_result):
  16648. * Scripts/webkitpy/layout_tests/port/base.py:
  16649. (Port.check_pretty_patch):
  16650. (Port.check_wdiff):
  16651. (Port._wdiff_missing_message):
  16652. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  16653. (ChromiumLinuxPort.check_build):
  16654. (ChromiumLinuxPort._wdiff_missing_message):
  16655. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  16656. (ChromiumMacPort.check_build):
  16657. (ChromiumMacPort):
  16658. (ChromiumMacPort._wdiff_missing_message):
  16659. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  16660. (ChromiumMacPortTest):
  16661. 2012-06-20 Dirk Pranke <dpranke@chromium.org>
  16662. nrwt: fix unit tests for ensuring svn revision is correct
  16663. https://bugs.webkit.org/show_bug.cgi?id=89498
  16664. Reviewed by Eric Seidel.
  16665. Reviewed by Eric Seidel.
  16666. Fix the unit tests for testing that we are embedding the SVN
  16667. revision in the results json for NRWT properly; this was broken
  16668. in r120646 but because the MockHost worked differently than the
  16669. real one (by always initializing the MockSCM object) we didn't
  16670. notice. Unfortunately, just changing the default breaks all
  16671. sorts of unit tests ...
  16672. * Scripts/webkitpy/common/host_mock.py:
  16673. (MockHost.__init__):
  16674. (MockHost._initialize_scm):
  16675. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  16676. (ResultSummaryTest.test_no_svn_revision):
  16677. (ResultSummaryTest.test_svn_revision):
  16678. 2012-06-20 Dirk Pranke <dpranke@chromium.org>
  16679. new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
  16680. https://bugs.webkit.org/show_bug.cgi?id=69360
  16681. Reviewed by Eric Seidel.
  16682. Reviewed by Eric Seidel.
  16683. Propagate the 'port_implementation' part of the platform (i.e.,
  16684. gtk,qt,chromium) to webkit-build-directory so that we can pick
  16685. up the gtk-specific handling of WEBKITOUTPUTDIR ...
  16686. I didn't write any additional tests for this; testing it
  16687. properly is an integration test between the python code and the
  16688. perl code, which I verified by hand.
  16689. * Scripts/webkitpy/layout_tests/port/base.py:
  16690. (Port.__init__):
  16691. * Scripts/webkitpy/layout_tests/port/config.py:
  16692. (Config.__init__):
  16693. (Config.build_directory):
  16694. * Scripts/webkitpy/layout_tests/port/config_mock.py:
  16695. (MockConfig.__init__):
  16696. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  16697. (ConfigTest.test_build_directory_passes_port_implementation):
  16698. 2012-06-20 Dirk Pranke <dpranke@chromium.org>
  16699. Fix import sorting missed in r120846
  16700. Reviewed by Tony Chang.
  16701. * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
  16702. 2012-06-20 Dirk Pranke <dpranke@chromium.org>
  16703. Fix chromium win http servers after breakage introduced in r120846.
  16704. Unreviewed, build fix.
  16705. * Scripts/webkitpy/layout_tests/port/base.py:
  16706. (Port.to.start_http_server):
  16707. * Scripts/webkitpy/layout_tests/servers/http_server.py:
  16708. (Lighttpd.__init__):
  16709. 2012-06-20 Dirk Pranke <dpranke@chromium.org>
  16710. tweak output of webkit-patch print-{baselines,expectations}
  16711. https://bugs.webkit.org/show_bug.cgi?id=89588
  16712. Reviewed by Tony Chang.
  16713. Minor tweaks to the output to make it more readable, including
  16714. turning off csv by default for print-baselines with multiple ports.
  16715. * Scripts/webkitpy/layout_tests/port/test.py:
  16716. (TestPort):
  16717. * Scripts/webkitpy/tool/commands/queries.py:
  16718. (PrintExpectations.execute):
  16719. (PrintBaselines.execute):
  16720. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  16721. (PrintExpectationsTest.run_test):
  16722. (PrintExpectationsTest.test_multiple):
  16723. (PrintBaselinesTest.setUp):
  16724. (PrintBaselinesTest.test_multiple):
  16725. 2012-06-18 Dirk Pranke <dpranke@chromium.org>
  16726. new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
  16727. https://bugs.webkit.org/show_bug.cgi?id=88134
  16728. Reviewed by Tony Chang.
  16729. Change NRWT to spin up 2*min(child_processes, locked_shards)
  16730. http servers by default so that we are less likely to get a
  16731. bunch of http timeouts at the beginning of a test run.
  16732. Note that I had to tweak executive_mock to support mocked stderr
  16733. because the apache_http_server code reads stderr when starting a
  16734. process to ensure it started okay.
  16735. * Scripts/webkitpy/common/system/executive_mock.py:
  16736. (MockProcess.__init__):
  16737. * Scripts/webkitpy/common/system/outputcapture.py:
  16738. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  16739. (Manager._run_tests):
  16740. (Manager.start_servers_with_lock):
  16741. * Scripts/webkitpy/layout_tests/port/base.py:
  16742. (Port.to.start_http_server):
  16743. * Scripts/webkitpy/layout_tests/port/test.py:
  16744. (TestPort.start_http_server):
  16745. (TestPort._path_to_apache):
  16746. (TestPort):
  16747. (TestPort._path_to_apache_config_file):
  16748. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  16749. (LayoutTestApacheHttpd.__init__):
  16750. * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
  16751. (LayoutTestApacheHttpd.__init__):
  16752. * Scripts/webkitpy/layout_tests/servers/http_server.py:
  16753. (Lighttpd.__init__):
  16754. * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
  16755. (HttpServerBase.__init__):
  16756. 2012-06-20 Tom Zakrajsek <tomz@codeaurora.org>
  16757. Unreviewed: Back out accidentally checked in debug print which broke a test
  16758. * Scripts/webkitpy/performance_tests/perftest.py:
  16759. (PerfTest.parse_output):
  16760. 2012-06-20 Tom Zakrajsek <tomz@codeaurora.org>
  16761. Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
  16762. https://bugs.webkit.org/show_bug.cgi?id=78789
  16763. Reviewed by Ryosuke Niwa.
  16764. Updated parser to include fps as a valid unit.
  16765. * Scripts/webkitpy/performance_tests/perftest.py:
  16766. (PerfTest):
  16767. (PerfTest.parse_output):
  16768. 2012-06-20 Balazs Ankes <bank@inf.u-szeged.hu>
  16769. webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
  16770. https://bugs.webkit.org/show_bug.cgi?id=67935
  16771. Reviewed by Ryosuke Niwa.
  16772. * Scripts/webkitpy/common/checkout/changelog.py:
  16773. (ChangeLog.set_reviewer):
  16774. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  16775. (test_set_reviewer):
  16776. (test_set_short_description_and_bug_url):
  16777. 2012-06-20 Simon Hausmann <simon.hausmann@nokia.com>
  16778. Unreviewed trivial permissions fix.
  16779. * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
  16780. 2012-06-19 Ryuan Choi <ryuan.choi@samsung.com>
  16781. [EFL][Regression] Build break after r120786
  16782. https://bugs.webkit.org/show_bug.cgi?id=89549
  16783. Unreviewed build fix for Efl port.
  16784. * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
  16785. 2012-06-19 Dirk Pranke <dpranke@chromium.org>
  16786. NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
  16787. https://bugs.webkit.org/show_bug.cgi?id=64489
  16788. Reviewed by Tony Chang.
  16789. This change changes NRWT so that we don't start the websocket
  16790. server if we aren't running websocket tests and don't start the
  16791. HTTP server if we aren't running http tests.
  16792. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  16793. (Manager._websocket_tests):
  16794. (Manager.start_servers_with_lock):
  16795. (Manager.stop_servers_with_lock):
  16796. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  16797. (ManagerTest.test_servers_started):
  16798. 2012-06-19 Dirk Pranke <dpranke@chromium.org>
  16799. test-webkitpy: add a -p flag to pass through captured output to enable debugging
  16800. https://bugs.webkit.org/show_bug.cgi?id=89158
  16801. Reviewed by Eric Seidel.
  16802. Normally when outputcapture runs it intercepts stdout/stderr,
  16803. which makes running under the debugger difficult and mostly
  16804. pointless (since you can't see any output). This change adds a
  16805. flag to test-webkitpy (-p) that will cause outputcapture to pass
  16806. through the output as well as capture it.
  16807. * Scripts/webkitpy/common/system/outputcapture.py:
  16808. (OutputCapture.stream_wrapper):
  16809. (OutputCapture._capture_output_with_name):
  16810. * Scripts/webkitpy/common/system/outputcapture_unittest.py:
  16811. (OutputCaptureTest.setUp):
  16812. * Scripts/webkitpy/test/main.py:
  16813. (Tester._parse_args):
  16814. (Tester._run_tests):
  16815. (Tester._log_exception):
  16816. (_CaptureAndPassThroughStream):
  16817. (_CaptureAndPassThroughStream.__init__):
  16818. (_CaptureAndPassThroughStream.write):
  16819. (_CaptureAndPassThroughStream._message_is_from_pdb):
  16820. (_CaptureAndPassThroughStream.flush):
  16821. (_CaptureAndPassThroughStream.getvalue):
  16822. 2012-06-19 Adam Barth <abarth@webkit.org>
  16823. garden-o-matic fails to rebaseline tests with MISSING results
  16824. https://bugs.webkit.org/show_bug.cgi?id=89521
  16825. Reviewed by Kenneth Russell.
  16826. If the bots report "MISSING", we should try to find PNG and TXT results on the server.
  16827. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  16828. 2012-06-19 Adam Barth <abarth@webkit.org>
  16829. svn.delete_list fails to delete empty parent directories
  16830. https://bugs.webkit.org/show_bug.cgi?id=89520
  16831. Reviewed by Dirk Pranke.
  16832. These functions were calling scm.delete and scm.add, which already
  16833. delete the parent directory. We'd get an exception when we tried to
  16834. delete the parent directory again.
  16835. * Scripts/webkitpy/common/checkout/scm/svn.py:
  16836. (SVN._add_parent_directories):
  16837. (SVN._delete_parent_directories):
  16838. 2012-06-19 Thiago Marcos P. Santos <thiago.santos@intel.com>
  16839. webkitpy: Simplify fetch_bugs_matching_search()
  16840. https://bugs.webkit.org/show_bug.cgi?id=89497
  16841. Reviewed by Adam Barth.
  16842. Removed parameter with default value. It's not being used
  16843. and the handling of the parameter was wrong. Saves a check.
  16844. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  16845. (BugzillaQueries.fetch_bugs_matching_search):
  16846. * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
  16847. (MockBugzillaQueries.fetch_bugs_matching_search):
  16848. 2012-06-19 Dirk Pranke <dpranke@chromium.org>
  16849. webkitpy: remove unneeded imports in layout_tests/port/chromium.py
  16850. https://bugs.webkit.org/show_bug.cgi?id=89522
  16851. Reviewed by Eric Seidel.
  16852. They were no longer being used. No tests necessary.
  16853. * Scripts/webkitpy/layout_tests/port/chromium.py:
  16854. 2012-06-19 Adam Barth <abarth@webkit.org>
  16855. Missing results aren't shown in garden-o-matic
  16856. Reviewed by Kenneth Russell.
  16857. Previously we didn't know to look for text and image results when the
  16858. bot told us that results were missing.
  16859. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  16860. 2012-06-19 Dirk Pranke <dpranke@chromium.org>
  16861. Fix regression introduced in r120646 where the svn revision isn't saved in results.json
  16862. Unreviewed, build fix.
  16863. It turns out that we store the svn revision two different ways
  16864. in the JSON, and I only caught one of them :(. This should fix
  16865. the other.
  16866. Also, this part of the code is poorly tested. I will investigate
  16867. adding at least a basic test for this in a separate fix.
  16868. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  16869. (summarize_results):
  16870. 2012-06-19 Dirk Pranke <dpranke@chromium.org>
  16871. REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
  16872. https://bugs.webkit.org/show_bug.cgi?id=78127
  16873. Reviewed by Ryosuke Niwa.
  16874. Add the --add-platform-exceptions flag from ORWT, and ensure
  16875. that --new-baseline is equivalent to --reset-results
  16876. --add-platform-exceptions. Also fix the default logic for where to
  16877. put PNGs and render tree dumps if --new-test-results is true:
  16878. if --add-platform-exceptions is False, baselines should go in
  16879. the least-specific platform directory (e.g., platform/mac)
  16880. rather than the most-specific (platform/mac-snowleopard).
  16881. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  16882. (SingleTestRunner):
  16883. (SingleTestRunner.run):
  16884. (SingleTestRunner._run_rebaseline):
  16885. (SingleTestRunner._add_missing_baselines):
  16886. (SingleTestRunner._location_for_new_baseline):
  16887. (SingleTestRunner._overwrite_baselines):
  16888. (SingleTestRunner._save_baseline_data):
  16889. * Scripts/webkitpy/layout_tests/port/base.py:
  16890. (Port.baseline_path):
  16891. (Port):
  16892. (Port.baseline_platform_dir):
  16893. (Port.baseline_version_dir):
  16894. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  16895. (_set_up_derived_options):
  16896. (parse_args):
  16897. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  16898. (RebaselineTest.assertBaselines):
  16899. (RebaselineTest.test_reset_results):
  16900. (RebaselineTest.test_missing_results):
  16901. (RebaselineTest.test_new_baseline):
  16902. 2012-06-19 Dirk Pranke <dpranke@chromium.org>
  16903. NRWT should not take memory used as disk cache into account when deciding how many processes to launch
  16904. https://bugs.webkit.org/show_bug.cgi?id=81379
  16905. Reviewed by Eric Seidel.
  16906. The 'free memory' calculation we were running on the mac seemed
  16907. to underestimate how many children we can run in parallel, and
  16908. it was complex. This patch replaces that calculation with a
  16909. simpler one that reserves 2GB for overhead and assumes 256MB per
  16910. DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
  16911. Also, there was a bug where we were truncating the memory
  16912. installed on the machine to 4GB by casting to an int instead of
  16913. a long; this was probably the source of some of the earlier
  16914. problems when using total memory.
  16915. This patch also removes the no-longer-needed restrictions on the
  16916. number of workers on beefy Lion boxes for both Apple Mac and Chromium
  16917. Mac; we should now use all of the cores by default.
  16918. The memory calculations have only been implemented on the mac;
  16919. having the calculation in base.default_child_processes() was IMO
  16920. misleading, and so this patch also moves the computation into
  16921. the MacPort. I have not heard of the # of workers being an issue
  16922. on any other ports, so this should be fine.
  16923. * Scripts/webkitpy/common/system/platforminfo.py:
  16924. (PlatformInfo.total_bytes_memory):
  16925. * Scripts/webkitpy/common/system/platforminfo_mock.py:
  16926. (PlatformInfo.total_bytes_memory):
  16927. (PlatformInfo.total_bytes_memory):
  16928. (PlatformInfo._win_version_tuple_from_cmd):
  16929. * Scripts/webkitpy/common/system/platforminfo_unittest.py:
  16930. (TestPlatformInfo.test_total_bytes_memory):
  16931. * Scripts/webkitpy/layout_tests/port/base.py:
  16932. (Port.default_child_processes):
  16933. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  16934. (PortTest.test_default_child_processes):
  16935. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  16936. (ChromiumMacPort.operating_system):
  16937. * Scripts/webkitpy/layout_tests/port/mac.py:
  16938. (MacPort.default_child_processes):
  16939. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  16940. (TestMacPort.test_default_child_processes):
  16941. 2012-06-19 Dirk Pranke <dpranke@chromium.org>
  16942. new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
  16943. https://bugs.webkit.org/show_bug.cgi?id=85446
  16944. Reviewed by Simon Fraser.
  16945. Embed whether pixel testing was enabled into the results.json.
  16946. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  16947. (summarize_results):
  16948. 2012-06-19 Zoltan Horvath <zoltan@webkit.org>
  16949. [Qt] Modify HTTPS port to 8443 for performance tests
  16950. https://bugs.webkit.org/show_bug.cgi?id=89442
  16951. Reviewed by Ryosuke Niwa.
  16952. We should be consistent with the default HTTPS port and with the changelog of r119188.
  16953. * Scripts/webkitpy/performance_tests/perftest.py:
  16954. (ReplayServer.__init__):
  16955. 2012-06-19 Mike West <mkwst@chromium.org>
  16956. Introduce ENABLE_CSP_NEXT configuration flag.
  16957. https://bugs.webkit.org/show_bug.cgi?id=89300
  16958. Reviewed by Adam Barth.
  16959. The 1.0 draft of the Content Security Policy spec is just about to
  16960. move to Last Call. We'll hide work on the upcoming 1.1 spec behind
  16961. this ENABLE flag, disabled by default.
  16962. Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
  16963. * Scripts/webkitperl/FeatureList.pm:
  16964. * qmake/mkspecs/features/features.pri:
  16965. 2012-06-19 Christophe Dumez <christophe.dumez@intel.com>
  16966. [EFL] EFL's LayoutTestController does not support setTextDirection
  16967. https://bugs.webkit.org/show_bug.cgi?id=87481
  16968. Reviewed by Hajime Morita.
  16969. Implement setTextDirection in EFL's LayoutTestController and
  16970. properly reset its value between test cases to avoid flakiness.
  16971. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  16972. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  16973. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  16974. (LayoutTestController::setTextDirection):
  16975. 2012-06-19 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  16976. [Qt] Temporarily disable xvfb driver in nrwt
  16977. https://bugs.webkit.org/show_bug.cgi?id=88414
  16978. Reviewed by Csaba Osztrogonác.
  16979. * Scripts/webkitpy/layout_tests/port/qt.py:
  16980. (QtPort._build_driver):
  16981. 2012-06-18 Joone Hur <joone.hur@intel.com>
  16982. [EFL] Fontconfig can't be linked properly
  16983. https://bugs.webkit.org/show_bug.cgi?id=89418
  16984. Unreviewed build fix.
  16985. Make Fontconfig be linked correctly.
  16986. * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
  16987. 2012-06-18 Joone Hur <joone.hur@intel.com>
  16988. Unreviewed. Updating email for committers.py script.
  16989. * Scripts/webkitpy/common/config/committers.py:
  16990. 2012-06-18 Simon Fraser <simon.fraser@apple.com>
  16991. Fix a typo that caused TestFailures to have a syntax error.
  16992. Sadly TestFailures is broken for another reason now too:
  16993. https://bugs.webkit.org/show_bug.cgi?id=89419
  16994. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
  16995. (ViewController.prototype._domForBuildName):
  16996. 2012-06-18 Simon Fraser <simon.fraser@apple.com>
  16997. Provide bug links for suspicious commits
  16998. https://bugs.webkit.org/show_bug.cgi?id=89408
  16999. Reviewed by Adam Barth.
  17000. Add links to bugs for the suspicious commits if we have bug data.
  17001. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
  17002. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  17003. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
  17004. (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
  17005. (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
  17006. 2012-06-18 Amy Ousterhout <aousterh@chromium.org>
  17007. [Chromium] DeviceOrientation Cleanup
  17008. https://bugs.webkit.org/show_bug.cgi?id=89354
  17009. Reviewed by Kent Tamura.
  17010. * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
  17011. (WebViewHost):
  17012. 2012-06-18 James Robinson <jamesr@chromium.org>
  17013. [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
  17014. https://bugs.webkit.org/show_bug.cgi?id=89254
  17015. Reviewed by Adrienne Walker.
  17016. This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
  17017. upstream.
  17018. * DumpRenderTree/chromium/WebViewHost.cpp:
  17019. (WebViewHost::createGraphicsContext3D):
  17020. 2012-06-18 Simon Fraser <simon.fraser@apple.com>
  17021. Minor fix suggested by Adam Barth.
  17022. Use $(this._what).empty(); rather than removing children one at a time.
  17023. For some reason removeAllChildren() is undefined on this node.
  17024. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  17025. 2012-06-18 Simon Fraser <simon.fraser@apple.com>
  17026. Show TOT revision in garden-o-matic, and make the revisions into links
  17027. https://bugs.webkit.org/show_bug.cgi?id=89396
  17028. Reviewed by Adam Barth.
  17029. The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
  17030. where the revisions are links to trac.
  17031. To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
  17032. the knock-on effect of flipping the target and href attributes for anchors in some test output.
  17033. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
  17034. (ViewController.prototype._displayTesters.updateList.list):
  17035. (ViewController.prototype._displayTesters.updateList):
  17036. (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
  17037. (ViewController.prototype._domForRegressionRange):
  17038. (ViewController.prototype._domForAuxiliaryUIElements):
  17039. (ViewController.prototype._domForBuildName):
  17040. (ViewController.prototype):
  17041. (ViewController.prototype.):
  17042. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  17043. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  17044. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  17045. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  17046. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  17047. 2012-06-18 Csaba Osztrogonác <ossy@webkit.org>
  17048. REGRESSION(r100558): NRWT should work without SVN or GIT
  17049. https://bugs.webkit.org/show_bug.cgi?id=76630
  17050. Reviewed by Dirk Pranke.
  17051. NRWT is not supposed to have a requirement that we have an
  17052. actual SVN or Git checkout, and we were unnecessarily
  17053. initializing the checkout. This patch removes that line :).
  17054. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  17055. (main):
  17056. 2012-06-18 Zan Dobersek <zandobersek@gmail.com>
  17057. [garden-o-matic] Add support for the GTK builders
  17058. https://bugs.webkit.org/show_bug.cgi?id=89360
  17059. Reviewed by Adam Barth.
  17060. Add the 'gtk' platform, essentially a copy of the 'apple' platform since
  17061. both get their data from build.webkit.org.
  17062. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  17063. (.):
  17064. 2012-06-18 Nico Weber <thakis@chromium.org>
  17065. [chromium/mac] Unbreak smooth scrolling.
  17066. https://bugs.webkit.org/show_bug.cgi?id=89327
  17067. Reviewed by Dimitri Glazkov.
  17068. Broken by Sam in r115589 / r115591.
  17069. * DumpRenderTree/mac/DumpRenderTree.mm:
  17070. (resetDefaultsToConsistentValues):
  17071. * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
  17072. (TestWebKitAPI::InjectedBundleController::platformInitialize):
  17073. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  17074. (WTR::InjectedBundle::platformInitialize):
  17075. 2012-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
  17076. Unreviewed, rolling out r120541, r120547, and r120548.
  17077. http://trac.webkit.org/changeset/120541
  17078. http://trac.webkit.org/changeset/120547
  17079. http://trac.webkit.org/changeset/120548
  17080. https://bugs.webkit.org/show_bug.cgi?id=89383
  17081. This approach doesn't work for WebKit2 (Requested by abarth on
  17082. #webkit).
  17083. * DumpRenderTree/LayoutTestController.cpp:
  17084. (setBackingScaleFactorCallback):
  17085. (LayoutTestController::staticFunctions):
  17086. * DumpRenderTree/LayoutTestController.h:
  17087. (LayoutTestController):
  17088. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  17089. (LayoutTestController::setBackingScaleFactor):
  17090. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  17091. (LayoutTestController::setBackingScaleFactor):
  17092. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  17093. (LayoutTestController::setBackingScaleFactor):
  17094. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  17095. (LayoutTestController::setBackingScaleFactor):
  17096. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  17097. (LayoutTestController::setBackingScaleFactor):
  17098. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  17099. (LayoutTestController::setBackingScaleFactor):
  17100. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  17101. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  17102. (WTR::InjectedBundle::didReceiveMessage):
  17103. (WTR::InjectedBundle::postSetBackingScaleFactor):
  17104. (WTR):
  17105. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  17106. (InjectedBundle):
  17107. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  17108. (WTR::LayoutTestController::setBackingScaleFactor):
  17109. (WTR):
  17110. (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
  17111. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  17112. (LayoutTestController):
  17113. * WebKitTestRunner/TestInvocation.cpp:
  17114. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  17115. 2012-06-18 Zan Dobersek <zandobersek@gmail.com>
  17116. REGRESSION(r120546): It made 3 webkitpy tests fail
  17117. https://bugs.webkit.org/show_bug.cgi?id=89332
  17118. Reviewed by Adam Barth.
  17119. Update the BaselineOptimizer unittest after r120546.
  17120. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  17121. (BaselineOptimizerTest.test_no_add_mac_future):
  17122. (BaselineOptimizerTest.test_mac_future):
  17123. (BaselineOptimizerTest.test_complex_shadowing):
  17124. 2012-06-18 Dirk Pranke <dpranke@chromium.org>
  17125. new-run-webkit-tests output gets confused when logging
  17126. https://bugs.webkit.org/show_bug.cgi?id=63793
  17127. Reviewed by Adam Barth.
  17128. Ship all of the log messages generated in the worker back
  17129. to the manager; this allows the messages to be properly
  17130. serialized to stderr and for the meter to flush its output correctly.
  17131. Note however that this will likely result in messages to be
  17132. logged out of order between workers; I'm not sure that there's
  17133. an easy way to fix this short of buffering a potentially
  17134. unbounded amount of data. It might be better to just log through
  17135. stderr unless we're in 'metering' mode, but it's also worth
  17136. noting that we already get messages out of order through stderr
  17137. on Windows.
  17138. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  17139. (Manager.handle_done):
  17140. (Manager.handle_finished_test):
  17141. (Manager._log_messages):
  17142. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  17143. (Worker.__init__):
  17144. (Worker._set_up_logging):
  17145. (Worker.run):
  17146. (Worker._run_test):
  17147. (Worker.cleanup):
  17148. (Worker.run_single_test):
  17149. (_WorkerLogHandler):
  17150. (_WorkerLogHandler.__init__):
  17151. (_WorkerLogHandler.emit):
  17152. * Scripts/webkitpy/layout_tests/views/metered_stream.py:
  17153. (MeteredStream.write):
  17154. (MeteredStream.writeln):
  17155. * Scripts/webkitpy/layout_tests/views/printing.py:
  17156. (Printer.writeln):
  17157. 2012-06-18 Zan Dobersek <zandobersek@gmail.com>
  17158. [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
  17159. https://bugs.webkit.org/show_bug.cgi?id=89362
  17160. Reviewed by Simon Fraser.
  17161. Replace white spaces, braces and dots in the builder name with underscores. This
  17162. way the JQuery tabs will be properly matched with the according container.
  17163. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  17164. 2012-06-18 Dirk Pranke <dpranke@chromium.org>
  17165. nrwt: metered output doesn't handle ^C cleanly
  17166. https://bugs.webkit.org/show_bug.cgi?id=89249
  17167. Reviewed by Tony Chang.
  17168. If you ctrl-c a running nrwt (w/o --verbose), then all but
  17169. two characters of the last update are erased, and then we print
  17170. "interrupted, exiting" as an update, which itself then gets
  17171. erased. Fix this so that we flush the meter (making the last
  17172. update persistent, so that we print the ^C for a visual clue),
  17173. print the interrupt message, and move on ...
  17174. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  17175. (Manager._run_tests):
  17176. * Scripts/webkitpy/layout_tests/views/metered_stream.py:
  17177. (MeteredStream.flush):
  17178. * Scripts/webkitpy/layout_tests/views/printing.py:
  17179. (Printer._write):
  17180. (Printer):
  17181. (Printer.flush):
  17182. 2012-06-18 Xianzhu Wang <wangxianzhu@chromium.org>
  17183. [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
  17184. https://bugs.webkit.org/show_bug.cgi?id=89228
  17185. Reviewed by Tony Chang.
  17186. * DumpRenderTree/chromium/LayoutTestController.cpp:
  17187. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  17188. 2012-06-18 Mario Sanchez Prada <msanchez@igalia.com>
  17189. [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
  17190. https://bugs.webkit.org/show_bug.cgi?id=89226
  17191. Reviewed by Martin Robinson.
  17192. Implement increment() and decrement() functions in term of the AtkValue interface,
  17193. instead of using DumpRenderTreeSupportGtk helper class.
  17194. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  17195. (AccessibilityUIElement::intValue):
  17196. (AccessibilityUIElement::minValue):
  17197. (AccessibilityUIElement::maxValue):
  17198. (alterCurrentValue):
  17199. (AccessibilityUIElement::increment):
  17200. (AccessibilityUIElement::decrement):
  17201. 2012-06-17 Simon Fraser <simon.fraser@apple.com>
  17202. garden-o-matic 'Results' panel is broken for the Apple platform
  17203. https://bugs.webkit.org/show_bug.cgi?id=89310
  17204. Reviewed by Adam Barth.
  17205. For platforms that don't use accumulated build directories on the server,
  17206. carry along buildLocation data with buildInfo, so that we know where to
  17207. look for the test results files for a given test.
  17208. Renamed historicalResultsSummaryURLs to historicalResultsLocations because
  17209. it now returns an array of objects with buildNumber, revision and url info.
  17210. Fixed results.fetchResultsURLs() to use this data to find results.
  17211. Fixed the results display to not scroll when you click on a test to see the results.
  17212. Made the h3s look less ugly
  17213. Don't try to show the flakiness dashboard for the Apple platform.
  17214. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  17215. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  17216. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  17217. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  17218. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  17219. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  17220. (.results-view .top-panel):
  17221. (.results-view h3):
  17222. 2012-06-16 Simon Fraser <simon.fraser@apple.com>
  17223. Make garden-o-matic work for the Apple Mac port
  17224. https://bugs.webkit.org/show_bug.cgi?id=84642
  17225. Reviewed by Adam Barth.
  17226. Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
  17227. educating the scripts in various ways:
  17228. * Wrap up platform-related differences in config.kPlatforms[]
  17229. * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
  17230. * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
  17231. so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
  17232. recent build with valid results.
  17233. * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
  17234. try to test a build that has already been deleted). Make walkHistory() more robust here.
  17235. * webkit.org uses differently named test result directories, that include the SVN revision as
  17236. well as the build number. That forces us to fetch more build info before we can get the
  17237. result directory URL.
  17238. * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
  17239. those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
  17240. dirs.
  17241. * Various URLs differ between webkit.org and chromium.org
  17242. * Better UI for the failures info, so that some info is visible even when not hovered.
  17243. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  17244. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
  17245. (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
  17246. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  17247. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  17248. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  17249. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
  17250. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  17251. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  17252. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
  17253. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  17254. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  17255. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  17256. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
  17257. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  17258. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
  17259. (ol.notifications>li table.failures):
  17260. (ol.notifications>li:hover table.failures):
  17261. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
  17262. (#onebar #platform-picker):
  17263. * Scripts/webkitpy/layout_tests/port/builders.py:
  17264. 2012-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
  17265. Unreviewed, rolling out r120536.
  17266. http://trac.webkit.org/changeset/120536
  17267. https://bugs.webkit.org/show_bug.cgi?id=89296
  17268. Does not compile on chromium-linux (Requested by abarth on
  17269. #webkit).
  17270. * DumpRenderTree/chromium/LayoutTestController.cpp:
  17271. (LayoutTestController::reset):
  17272. (LayoutTestController::setTextSubpixelPositioning):
  17273. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  17274. 2012-06-16 Adam Barth <abarth@webkit.org>
  17275. layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
  17276. https://bugs.webkit.org/show_bug.cgi?id=89274
  17277. Reviewed by Levi Weintraub.
  17278. Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
  17279. Note: The WebKit2 API that setBackingScaleFactor exercises is still
  17280. tested by API-level tests.
  17281. * DumpRenderTree/LayoutTestController.cpp:
  17282. (LayoutTestController::staticFunctions):
  17283. * DumpRenderTree/LayoutTestController.h:
  17284. (LayoutTestController):
  17285. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  17286. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  17287. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  17288. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  17289. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  17290. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  17291. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  17292. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  17293. (WTR::InjectedBundle::didReceiveMessage):
  17294. (WTR):
  17295. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  17296. (InjectedBundle):
  17297. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  17298. (WTR):
  17299. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  17300. (LayoutTestController):
  17301. * WebKitTestRunner/TestInvocation.cpp:
  17302. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  17303. 2012-06-16 Xianzhu Wang <wangxianzhu@chromium.org>
  17304. [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
  17305. https://bugs.webkit.org/show_bug.cgi?id=89228
  17306. Reviewed by Tony Chang.
  17307. * DumpRenderTree/chromium/LayoutTestController.cpp:
  17308. (LayoutTestController::reset):
  17309. (LayoutTestController::setTextSubpixelPositioning):
  17310. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  17311. 2012-06-15 Adam Barth <abarth@webkit.org>
  17312. garden-o-matic's results.js should use RequestTracker
  17313. https://bugs.webkit.org/show_bug.cgi?id=89257
  17314. Reviewed by Dimitri Glazkov.
  17315. We wrote results.js before we recognized the RequestTracker pattern.
  17316. This patch replaces the manual implementations of RequestTracker with
  17317. the real deal.
  17318. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  17319. 2012-06-15 Darin Adler <darin@apple.com>
  17320. * Scripts/webkitpy/bindings: Added property svn:ignore.
  17321. 2012-06-15 Sheriff Bot <webkit.review.bot@gmail.com>
  17322. Unreviewed, rolling out r120511.
  17323. http://trac.webkit.org/changeset/120511
  17324. https://bugs.webkit.org/show_bug.cgi?id=89255
  17325. Breaks at least Android builder (Requested by wangxianzhu on
  17326. #webkit).
  17327. * DumpRenderTree/chromium/LayoutTestController.cpp:
  17328. (LayoutTestController::reset):
  17329. (LayoutTestController::setTextSubpixelPositioning):
  17330. 2012-06-15 Xianzhu Wang <wangxianzhu@chromium.org>
  17331. [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
  17332. https://bugs.webkit.org/show_bug.cgi?id=89228
  17333. Reviewed by Tony Chang.
  17334. * DumpRenderTree/chromium/LayoutTestController.cpp:
  17335. (LayoutTestController::reset):
  17336. (LayoutTestController::setTextSubpixelPositioning):
  17337. 2012-06-15 Dirk Pranke <dpranke@chromium.org>
  17338. webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
  17339. https://bugs.webkit.org/show_bug.cgi?id=89135
  17340. Re-land change in r120370 with fix in
  17341. PortFactory.get_from_builder_name() that changes BuilderOptions
  17342. to an actual optparse.Values object.
  17343. * Scripts/webkitpy/layout_tests/port/base.py:
  17344. (Port.__init__):
  17345. (Port.get_option):
  17346. (Port.set_option_default):
  17347. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  17348. (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
  17349. * Scripts/webkitpy/layout_tests/port/factory.py:
  17350. (_builder_options):
  17351. (PortFactory.get_from_builder_name):
  17352. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  17353. (FactoryTest.test_get_from_builder_name):
  17354. * Scripts/webkitpy/style/checkers/test_expectations.py:
  17355. (TestExpectationsChecker._determine_port_from_expectations_path):
  17356. * Scripts/webkitpy/tool/mocktool.py:
  17357. (MockOptions.ensure_value):
  17358. 2012-06-15 Bill Budge <bbudge@chromium.org>
  17359. Add bbudge@chromium.org to committers.py
  17360. Unreviewed.
  17361. * Scripts/webkitpy/common/config/committers.py:
  17362. 2012-06-15 Csaba Osztrogonác <ossy@webkit.org>
  17363. Unreviewed style fix after r120351.
  17364. * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
  17365. (body.interface):
  17366. 2012-06-15 Csaba Osztrogonác <ossy@webkit.org>
  17367. master.cfg cleanup, remove unnecessary workaround
  17368. https://bugs.webkit.org/show_bug.cgi?id=88994
  17369. Reviewed by Lucas Forschler.
  17370. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  17371. (loadBuilderConfig):
  17372. 2012-06-15 Dirk Pranke <dpranke@chromium.org>
  17373. webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
  17374. https://bugs.webkit.org/show_bug.cgi?id=88581
  17375. Reviewed by Adam Barth.
  17376. Make sure we only optimize the suffixes we rebaselined during
  17377. rebaseline-expectations, and not all suffixes for a test.
  17378. While optimizing is somewhere between harmless and good, it's also confusing :)
  17379. * Scripts/webkitpy/tool/commands/rebaseline.py:
  17380. (RebaselineExpectations._rebaseline_port):
  17381. (RebaselineExpectations.execute):
  17382. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  17383. 2012-06-15 Csaba Osztrogonác <ossy@webkit.org>
  17384. Update builder.html template for newer buildmaster
  17385. https://bugs.webkit.org/show_bug.cgi?id=89207
  17386. Rebasing builder.html template from v0.8.3 to v0.8.6p1.
  17387. Reviewed by Zoltan Herczeg.
  17388. * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
  17389. 2012-06-15 Csaba Osztrogonác <ossy@webkit.org>
  17390. Add ForceScheduler to build.webkit.org
  17391. https://bugs.webkit.org/show_bug.cgi?id=88982
  17392. Reviewed by Ryosuke Niwa.
  17393. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  17394. (loadBuilderConfig):
  17395. 2012-06-15 Christophe Dumez <christophe.dumez@intel.com>
  17396. [EFL][WK2] Add title support to Ewk_View
  17397. https://bugs.webkit.org/show_bug.cgi?id=89095
  17398. Reviewed by Kenneth Rohde Christiansen.
  17399. Update the MiniBrowser so it listens for the "title,change"
  17400. signal on the view and keeps the browser window title
  17401. up-to-date.
  17402. * MiniBrowser/efl/main.c:
  17403. (on_title_changed):
  17404. (browserCreate):
  17405. 2012-06-15 Christophe Dumez <christophe.dumez@intel.com>
  17406. [WK2][EFL] Implement navigation back/forward in Ewk_View
  17407. https://bugs.webkit.org/show_bug.cgi?id=89173
  17408. Reviewed by Kenneth Rohde Christiansen.
  17409. Implement navigation back / forward in MiniBrowser. Use
  17410. 'F1' to navigate back and 'F2' to navigate forward.
  17411. * MiniBrowser/efl/main.c:
  17412. (on_key_down):
  17413. 2012-06-15 Christophe Dumez <christophe.dumez@intel.com>
  17414. [EFL] EFL's LayoutTestController does not support titleTextDirection
  17415. https://bugs.webkit.org/show_bug.cgi?id=86475
  17416. Reviewed by Hajime Morita.
  17417. Add titleTextDirection getter and setter to LayoutTestController and
  17418. expose its value to JavaScript.
  17419. Update the titleTextDirection value from EFL's "title,changed"
  17420. callback in DumpRenderTree.
  17421. * DumpRenderTree/LayoutTestController.cpp:
  17422. (LayoutTestController::LayoutTestController):
  17423. (getTitleTextDirectionCallback):
  17424. (LayoutTestController::staticValues):
  17425. * DumpRenderTree/LayoutTestController.h:
  17426. (LayoutTestController::titleTextDirection):
  17427. (LayoutTestController::setTitleTextDirection):
  17428. (LayoutTestController):
  17429. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  17430. (DumpRenderTreeChrome::onFrameTitleChanged):
  17431. 2012-06-15 Christophe Dumez <christophe.dumez@intel.com>
  17432. [EFL][WK2] Implement reload / stop in Ewk_View
  17433. https://bugs.webkit.org/show_bug.cgi?id=89168
  17434. Reviewed by Kenneth Rohde Christiansen.
  17435. Implement view reload / stop loading in MiniBrowser.
  17436. Use 'F5' for reload and 'F6' for stopping the load.
  17437. * MiniBrowser/efl/main.c:
  17438. (on_key_down):
  17439. (browserCreate):
  17440. 2012-06-15 Hironori Bono <hbono@chromium.org>
  17441. Allow platforms to choose whether to remove markers on editing
  17442. https://bugs.webkit.org/show_bug.cgi?id=88838
  17443. Reviewed by Hajime Morita.
  17444. This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
  17445. run grammar tests.
  17446. * DumpRenderTree/chromium/WebViewHost.cpp:
  17447. (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
  17448. * DumpRenderTree/chromium/WebViewHost.h:
  17449. (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
  17450. 2012-06-15 Sheriff Bot <webkit.review.bot@gmail.com>
  17451. Unreviewed, rolling out r120370.
  17452. http://trac.webkit.org/changeset/120370
  17453. https://bugs.webkit.org/show_bug.cgi?id=89183
  17454. Broke webkit-patch rebaseline (Requested by zdobersek on
  17455. #webkit).
  17456. * Scripts/webkitpy/layout_tests/port/base.py:
  17457. (DummyOptions):
  17458. (DummyOptions.__init__):
  17459. (DummyOptions.__init__.this):
  17460. (Port.__init__):
  17461. (Port.get_option):
  17462. (Port.set_option_default):
  17463. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  17464. (ChromiumWinTest.RegisterCygwinOption):
  17465. (ChromiumWinTest.RegisterCygwinOption.__init__):
  17466. (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
  17467. * Scripts/webkitpy/style/checkers/test_expectations.py:
  17468. (TestExpectationsChecker._determine_port_from_expectations_path):
  17469. * Scripts/webkitpy/tool/mocktool.py:
  17470. (MockOptions.update):
  17471. 2012-06-14 Xianzhu Wang <wangxianzhu@chromium.org>
  17472. [Chromium-Android] Initialize font rendering in DumpRenderTree
  17473. https://bugs.webkit.org/show_bug.cgi?id=89133
  17474. Reviewed by Adam Barth.
  17475. * DumpRenderTree/chromium/LayoutTestController.cpp:
  17476. (LayoutTestController::reset):
  17477. (LayoutTestController::setTextSubpixelPositioning):
  17478. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  17479. (platformInit):
  17480. 2012-06-14 Dongwoo Im <dw.im@samsung.com>
  17481. [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
  17482. https://bugs.webkit.org/show_bug.cgi?id=88622
  17483. Reviewed by Philippe Normand.
  17484. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
  17485. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  17486. 2012-06-14 Xianzhu Wang <wangxianzhu@chromium.org>
  17487. [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
  17488. https://bugs.webkit.org/show_bug.cgi?id=89124
  17489. Reviewed by Dirk Pranke.
  17490. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  17491. (ChromiumAndroidDriver._start):
  17492. (ChromiumAndroidDriver):
  17493. (ChromiumAndroidDriver._start_once):
  17494. 2012-06-14 Tony Gentilcore <tonyg@chromium.org>
  17495. Update webpagereplay to 1.1.2
  17496. https://bugs.webkit.org/show_bug.cgi?id=89118
  17497. This includes the following patch which avoids pkg_resources import errors:
  17498. http://code.google.com/p/web-page-replay/source/detail?r=476
  17499. Reviewed by Dirk Pranke.
  17500. * Scripts/webkitpy/thirdparty/__init__.py:
  17501. (AutoinstallImportHook._install_webpagereplay):
  17502. 2012-06-14 Ryosuke Niwa <rniwa@webkit.org>
  17503. Get rid of FAIL test expectation
  17504. https://bugs.webkit.org/show_bug.cgi?id=89137
  17505. Reviewed by Dirk Pranke.
  17506. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  17507. (ResultSummaryTest.test_summarized_results_wontfix):
  17508. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  17509. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  17510. (JSONLayoutResultsGenerator):
  17511. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  17512. (result_was_expected):
  17513. (suffixes_for_expectations):
  17514. (TestExpectationsModel._add_test):
  17515. (TestExpectations):
  17516. (TestExpectations.get_rebaselining_failures):
  17517. (TestExpectations.remove_configuration_from_test):
  17518. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  17519. (FunctionsTest.test_result_was_expected):
  17520. (FunctionsTest.test_suffixes_for_expectations):
  17521. (TestExpectationSerializerTests.test_parsed_expectations_string):
  17522. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  17523. (test_test_expectations):
  17524. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  17525. (TestExpectationsTestCase.test_valid_expectations):
  17526. 2012-06-14 Dirk Pranke <dpranke@chromium.org>
  17527. webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
  17528. https://bugs.webkit.org/show_bug.cgi?id=89135
  17529. Reviewed by Ryosuke Niwa.
  17530. This patch is just some minor cleanup and simplification. There
  17531. should be no functional changes here.
  17532. * Scripts/webkitpy/layout_tests/port/base.py:
  17533. (Port.__init__):
  17534. (Port.get_option):
  17535. (Port.set_option_default):
  17536. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  17537. (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
  17538. * Scripts/webkitpy/style/checkers/test_expectations.py:
  17539. (TestExpectationsChecker._determine_port_from_expectations_path):
  17540. * Scripts/webkitpy/tool/mocktool.py:
  17541. (MockOptions.ensure_value):
  17542. 2012-06-14 Ian Vollick <vollick@chromium.org>
  17543. [chromium] Certain settings in CCSettings could be global
  17544. https://bugs.webkit.org/show_bug.cgi?id=88384
  17545. Reviewed by James Robinson.
  17546. * DumpRenderTree/chromium/TestShell.cpp:
  17547. (TestShell::TestShell):
  17548. (TestShell::resetWebSettings):
  17549. (TestShell::setPerTilePaintingEnabled):
  17550. * DumpRenderTree/chromium/TestShell.h:
  17551. (TestShell):
  17552. * DumpRenderTree/chromium/WebPreferences.cpp:
  17553. (WebPreferences::reset):
  17554. (WebPreferences::applyTo):
  17555. * DumpRenderTree/chromium/WebPreferences.h:
  17556. (WebPreferences):
  17557. 2012-06-14 Sheriff Bot <webkit.review.bot@gmail.com>
  17558. Unreviewed, rolling out r120352.
  17559. http://trac.webkit.org/changeset/120352
  17560. https://bugs.webkit.org/show_bug.cgi?id=89120
  17561. It seems something is still wrong with it :/ (Requested by
  17562. Ossy on #webkit).
  17563. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  17564. (Factory.__init__):
  17565. (BuildFactory.__init__):
  17566. (TestFactory.__init__):
  17567. (BuildAndTestFactory.__init__):
  17568. (BuildAndPerfTestFactory.__init__):
  17569. (BuildAndPerfTestWebKit2Factory.__init__):
  17570. (DownloadAndPerfTestFactory.__init__):
  17571. (DownloadAndPerfTestWebKit2Factory.__init__):
  17572. 2012-06-14 Jia Pu <jpu@apple.com>
  17573. Mark text with text alternative with blue underline.
  17574. https://bugs.webkit.org/show_bug.cgi?id=83047
  17575. Reviewed by NOBODY Enrica Casucci.
  17576. * DumpRenderTree/mac/TextInputController.m:
  17577. (+[TextInputController isSelectorExcludedFromWebScript:]):
  17578. (+[TextInputController webScriptNameForSelector:]):
  17579. (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
  17580. 2012-06-14 Sheriff Bot <webkit.review.bot@gmail.com>
  17581. Unreviewed, rolling out r120353.
  17582. http://trac.webkit.org/changeset/120353
  17583. https://bugs.webkit.org/show_bug.cgi?id=89119
  17584. It seems we still need this workaround (Requested by Ossy on
  17585. #webkit).
  17586. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  17587. (loadBuilderConfig):
  17588. 2012-06-14 Csaba Osztrogonác <ossy@webkit.org>
  17589. master.cfg cleanup, remove unnecessary workaround
  17590. https://bugs.webkit.org/show_bug.cgi?id=88994
  17591. Reviewed by Lucas Forschler.
  17592. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  17593. (loadBuilderConfig):
  17594. 2012-06-14 Csaba Osztrogonác <ossy@webkit.org>
  17595. master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
  17596. https://bugs.webkit.org/show_bug.cgi?id=89001
  17597. Reviewed by Lucas Forschler.
  17598. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  17599. (Factory.__init__):
  17600. (BuildFactory.__init__):
  17601. (TestFactory.__init__):
  17602. (BuildAndTestFactory.__init__):
  17603. (BuildAndPerfTestFactory.__init__):
  17604. (BuildAndPerfTestWebKit2Factory.__init__):
  17605. (DownloadAndPerfTestFactory.__init__):
  17606. (DownloadAndPerfTestWebKit2Factory.__init__):
  17607. 2012-06-14 Csaba Osztrogonác <ossy@webkit.org>
  17608. Unhide login form on the build.webkit.org
  17609. https://bugs.webkit.org/show_bug.cgi?id=88981
  17610. Reviewed by Lucas Forschler.
  17611. * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
  17612. 2012-06-14 Zan Dobersek <zandobersek@gmail.com>
  17613. [Gtk] Add support in DumpRenderTree for tracking repaints
  17614. https://bugs.webkit.org/show_bug.cgi?id=87658
  17615. Reviewed by Martin Robinson.
  17616. Reimplement the displayWebView method in DumpRenderTree - force a
  17617. repaint before starting tracking repaints and resetting them.
  17618. When gathering pixel output from a web view, if tracking repaints,
  17619. paint an overlay over the output with the overlay being clear in the
  17620. areas where the repaints occurred.
  17621. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  17622. (displayWebView):
  17623. (resetDefaultsToConsistentValues):
  17624. * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
  17625. (paintOverlay):
  17626. (fillRepaintOverlayIntoContext):
  17627. (createBitmapContextFromWebView):
  17628. 2012-06-14 Dirk Pranke <dpranke@chromium.org>
  17629. new-run-webkit-tests doesn't find similar platform tests for a keyword
  17630. https://bugs.webkit.org/show_bug.cgi?id=37956
  17631. Reviewed by Ryosuke Niwa.
  17632. This patches adds support for NRWT so that if you type
  17633. "new-run-webkit-tests foo" it will run all the tests in foo as
  17634. well as platform/foo for all of the platforms that are normally
  17635. searched (this only applies to directories, not to individual tests).
  17636. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  17637. (Manager.collect_tests):
  17638. * Scripts/webkitpy/layout_tests/port/base.py:
  17639. (Port.tests):
  17640. (Port):
  17641. (Port._expanded_paths):
  17642. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  17643. (MainTest.test_no_http_tests):
  17644. (MainTest):
  17645. (MainTest.test_platform_tests_are_found):
  17646. 2012-06-14 Dirk Pranke <dpranke@chromium.org>
  17647. NRWT should honor --skipped=[default|ignore|only], like ORWT does
  17648. https://bugs.webkit.org/show_bug.cgi?id=66308
  17649. Reviewed by Ryosuke Niwa.
  17650. This patch adds support for ORWT's --skipped=(default|ignore|only)
  17651. flag and cleans up the interaction between that and --ignore.
  17652. Individual tests (but not directories) explicitly listed on the
  17653. command line will always be run regardless of what is passed
  17654. for --skipped and --ignore.
  17655. This patch also changes the "found" and "running" log messages
  17656. since it wasn't clear how the skipped tests were included in those numbers.
  17657. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  17658. (Manager.__init__):
  17659. (Manager.collect_tests):
  17660. (Manager.prepare_lists_and_print_output):
  17661. * Scripts/webkitpy/layout_tests/port/test.py:
  17662. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  17663. (_set_up_derived_options):
  17664. (parse_args):
  17665. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  17666. (MainTest.test_ignore_flag):
  17667. (MainTest):
  17668. (MainTest.test_skipped_flag):
  17669. 2012-06-14 Takashi Toyoshima <toyoshim@chromium.org>
  17670. new-run-webkit-websocketserver must handle TLS related arguments
  17671. https://bugs.webkit.org/show_bug.cgi?id=89079
  17672. Reviewed by Dirk Pranke.
  17673. PyWebSocket class must accept private_key, certificate, and
  17674. ca_certificate arguments and pass them to launching pywebsocket.
  17675. Also add ca_certificate handling to new-run-webkit-websocketserver.
  17676. * Scripts/new-run-webkit-websocketserver:
  17677. (main):
  17678. * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
  17679. (PyWebSocket.__init__):
  17680. (PyWebSocket._prepare_config):
  17681. 2012-06-14 Qi Zhang <qi.2.zhang@nokia.com>
  17682. Unreviewed. Update my email.
  17683. * Scripts/webkitpy/common/config/committers.py:
  17684. 2012-06-14 Takashi Toyoshima <toyoshim@chromium.org>
  17685. Update pywebsocket to 0.7.6 from 0.7.4
  17686. https://bugs.webkit.org/show_bug.cgi?id=88975
  17687. Reviewed by Kent Tamura.
  17688. This new version of pywebsocket introduce following features.
  17689. - Allow handlers to send a close frame with empty body in response of
  17690. a client initiated closing handshake
  17691. - Implement perframe compression extension
  17692. - Support client certificate authentication
  17693. * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
  17694. * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
  17695. (_create_control_frame):
  17696. (Stream._receive_frame):
  17697. (Stream.send_message):
  17698. (Stream.receive_message):
  17699. (Stream._send_closing_handshake):
  17700. (Stream.close_connection):
  17701. * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
  17702. (ExtensionParsingException):
  17703. (ExtensionParsingException.__init__):
  17704. (_parse_extension_param):
  17705. (_parse_extension):
  17706. (parse_extensions):
  17707. (format_extension):
  17708. (format_extensions):
  17709. * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
  17710. (_parse_compression_method):
  17711. (_create_accepted_method_desc):
  17712. (PerFrameCompressionExtensionProcessor):
  17713. (PerFrameCompressionExtensionProcessor.__init__):
  17714. (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
  17715. (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
  17716. (PerFrameCompressionExtensionProcessor.get_extension_response):
  17717. (PerFrameCompressionExtensionProcessor.setup_stream_options):
  17718. (PerFrameCompressionExtensionProcessor.get_compression_processor):
  17719. * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
  17720. (parse_token_list):
  17721. * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
  17722. (Handshaker._parse_extensions):
  17723. (Handshaker._send_handshake):
  17724. * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
  17725. (WebSocketServer._create_sockets):
  17726. (_get_logger_from_class):
  17727. (_configure_logging):
  17728. (_build_option_parser):
  17729. (_main.if):
  17730. * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
  17731. (RepeatedXorMasker.mask):
  17732. 2012-06-14 Zoltan Horvath <zoltan@webkit.org>
  17733. [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
  17734. Reviewed by Noam Rosenthal.
  17735. * qmake/mkspecs/features/features.prf:
  17736. 2012-06-14 Christophe Dumez <christophe.dumez@intel.com>
  17737. [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
  17738. https://bugs.webkit.org/show_bug.cgi?id=88399
  17739. Reviewed by Kenneth Rohde Christiansen.
  17740. Update initialization of WKPageLoaderClient.
  17741. * MiniBrowser/mac/BrowserWindowController.m:
  17742. (-[BrowserWindowController awakeFromNib]):
  17743. * WebKitTestRunner/TestController.cpp:
  17744. (WTR::TestController::initialize):
  17745. 2012-06-14 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  17746. [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
  17747. https://bugs.webkit.org/show_bug.cgi?id=84577
  17748. Reviewed by Ryosuke Niwa.
  17749. Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
  17750. LayoutTestController.
  17751. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  17752. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  17753. 2012-06-13 Christophe Dumez <christophe.dumez@intel.com>
  17754. [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
  17755. https://bugs.webkit.org/show_bug.cgi?id=88340
  17756. Reviewed by Kenneth Rohde Christiansen.
  17757. Update initialization of WKPageLoaderClient.
  17758. * MiniBrowser/mac/BrowserWindowController.m:
  17759. (-[BrowserWindowController awakeFromNib]):
  17760. * WebKitTestRunner/TestController.cpp:
  17761. (WTR::TestController::initialize):
  17762. 2012-06-13 Sheriff Bot <webkit.review.bot@gmail.com>
  17763. Unreviewed, rolling out r120268.
  17764. http://trac.webkit.org/changeset/120268
  17765. https://bugs.webkit.org/show_bug.cgi?id=89060
  17766. WebCompositor::setPerTilePaintingEnabled hits an assertion in
  17767. DEBUG (Requested by dominicc|work on #webkit).
  17768. * DumpRenderTree/chromium/WebPreferences.cpp:
  17769. (WebPreferences::applyTo):
  17770. 2012-06-13 Tim Horton <timothy_horton@apple.com>
  17771. REGRESSION (r120252): run-webkit-tests on Mac fails
  17772. https://bugs.webkit.org/show_bug.cgi?id=89057
  17773. Reviewed by Dan Bernstein.
  17774. get_option will happily return None (the default only kicks in if
  17775. the option is actually *not set*). We should instead check get_option's
  17776. return value and default to "x86_64" architecture ourselves.
  17777. * Scripts/webkitpy/layout_tests/port/mac.py:
  17778. (MacPort.__init__):
  17779. 2012-06-13 Ian Vollick <vollick@chromium.org>
  17780. [chromium] Certain settings in CCSettings could be global
  17781. https://bugs.webkit.org/show_bug.cgi?id=88384
  17782. Reviewed by James Robinson.
  17783. * DumpRenderTree/chromium/WebPreferences.cpp:
  17784. (WebPreferences::applyTo):
  17785. 2012-06-13 Dirk Pranke <dpranke@chromium.org>
  17786. new-run-webkit-tests does not support --32-bit like ORWT did
  17787. https://bugs.webkit.org/show_bug.cgi?id=71634
  17788. Reviewed by Ojan Vafai.
  17789. This patch adds support for 32-bit apple mac builds, adding the
  17790. --32-bit flag for compatibility with ORWT and fixing the port
  17791. architecture() definition to actually return the correct values.
  17792. * Scripts/webkitpy/layout_tests/port/apple.py:
  17793. (ApplePort._generate_all_test_configurations):
  17794. * Scripts/webkitpy/layout_tests/port/factory.py:
  17795. (port_options):
  17796. * Scripts/webkitpy/layout_tests/port/mac.py:
  17797. (MacPort):
  17798. (MacPort.__init__):
  17799. (MacPort._build_driver_flags):
  17800. (MacPort.setup_environ_for_server):
  17801. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  17802. (test_sample_process_throws_exception):
  17803. (test_32bit):
  17804. (test_32bit.run_script):
  17805. (test_64bit):
  17806. (test_64bit.run_script):
  17807. * Scripts/webkitpy/layout_tests/port/webkit.py:
  17808. (WebKitPort._build_driver):
  17809. (WebKitPort._build_driver_flags):
  17810. * Scripts/webkitpy/layout_tests/port/win.py:
  17811. (WinPort):
  17812. 2012-06-13 Ryosuke Niwa <rniwa@webkit.org>
  17813. Remove webkitpy code to support legacy test_expectations.txt files
  17814. https://bugs.webkit.org/show_bug.cgi?id=89038
  17815. Reviewed by Dirk Pranke.
  17816. * Scripts/webkitpy/layout_tests/port/base.py:
  17817. (Port.path_to_test_expectations_file):
  17818. (Port.expectations_dict):
  17819. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  17820. (PortTest.test_uses_test_expectations_file):
  17821. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  17822. (WebKitPortTest.test_path_to_test_expectations_file):
  17823. (test_test_expectations):
  17824. * Scripts/webkitpy/style/checker.py:
  17825. (CheckerDispatcher.should_skip_without_warning):
  17826. (CheckerDispatcher._create_checker):
  17827. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  17828. (TestExpectationsTestCase._expect_port_for_expectations_path):
  17829. * Scripts/webkitpy/tool/steps/commit.py:
  17830. (Commit._check_test_expectations):
  17831. * Scripts/webkitpy/tool/steps/commit_unittest.py:
  17832. (CommitTest.test_check_test_expectations):
  17833. 2012-06-13 Dirk Pranke <dpranke@chromium.org>
  17834. nrwt: remove port.test_expectations() and port.test_expectations_overrides()
  17835. https://bugs.webkit.org/show_bug.cgi?id=88948
  17836. Reviewed by Ojan Vafai.
  17837. In the final patch of this run, we remove the
  17838. test_expectations() and test_expectation_overrides() methods
  17839. from the Port class - callers must now use just
  17840. expectations_dict().
  17841. Note that support for the cascade in new-run-webkit-tests is
  17842. complete but only Chromium uses it; webkit-patch
  17843. rebaseline-expectations still does not support updating entries
  17844. in any file other than the first expectations file, however.
  17845. * Scripts/webkitpy/layout_tests/port/base.py:
  17846. (Port.path_to_test_expectations_file):
  17847. (Port.uses_test_expectations_file):
  17848. (Port.expectations_files):
  17849. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  17850. (PortTest.test_additional_expectations):
  17851. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  17852. (ChromiumPortTest.test_expectations_files):
  17853. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  17854. (TestGoogleChromePort.test_get_google_chrome_port):
  17855. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  17856. (test_test_expectations):
  17857. (test_legacy_test_expectations):
  17858. 2012-06-13 Dirk Pranke <dpranke@chromium.org>
  17859. nrwt: implement the actual cascade of TestExpectations
  17860. https://bugs.webkit.org/show_bug.cgi?id=88947
  17861. Reviewed by Ojan Vafai.
  17862. This change implements the actual cascade by removing the
  17863. concept of 'overrides' from the TestExpectations object and
  17864. parsing each file separately.
  17865. There is an actual semantic change in this patch, in that
  17866. setting an expectation on a directory in one file will override
  17867. the expectations on any individual tests set in prior files. The
  17868. test_overrides__directory() unit test verifies this.
  17869. Otherwise, this patch mostly consists of deleting code :).
  17870. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  17871. (TestExpectationsModel.__init__):
  17872. (TestExpectationsModel.add_expectation_line):
  17873. (TestExpectationsModel._add_test):
  17874. (TestExpectationsModel._already_seen_better_match):
  17875. (TestExpectations.__init__):
  17876. (TestExpectations._add_expectations):
  17877. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  17878. (test_overrides__directory):
  17879. 2012-06-13 Dirk Pranke <dpranke@chromium.org>
  17880. webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
  17881. https://bugs.webkit.org/show_bug.cgi?id=88946
  17882. Reviewed by Ojan Vafai.
  17883. In preparation for fully supporting cascading expectations files
  17884. and removing the 'overrides' concept.
  17885. There should be no functional changes in this patch.
  17886. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  17887. (ManagerTest.test_update_summary_with_result):
  17888. (ResultSummaryTest.get_result_summary):
  17889. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  17890. (TestExpectations.__init__):
  17891. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  17892. (parse_exp):
  17893. (SkippedTests.check):
  17894. (RemoveConfigurationsTest.test_remove):
  17895. (test_remove_line):
  17896. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  17897. (LintTest.test_all_configurations.FakePort.__init__):
  17898. (LintTest.test_all_configurations.FakePort.expectations_dict):
  17899. (LintTest.test_lint_test_files__errors):
  17900. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  17901. (test_overrides_are_included_correctly):
  17902. 2012-06-13 Dirk Pranke <dpranke@chromium.org>
  17903. webkitpy: rework the TestExpectations style checker in preparation for the cascade
  17904. https://bugs.webkit.org/show_bug.cgi?id=88945
  17905. Reviewed by Ojan Vafai.
  17906. This patch changes the style checker to call the
  17907. TestExpectations parser directly and be oblivious as to what the
  17908. port's actual expectations are.
  17909. * Scripts/webkitpy/style/checkers/test_expectations.py:
  17910. (TestExpectationsChecker.__init__):
  17911. (TestExpectationsChecker.check_test_expectations):
  17912. 2012-06-13 Dirk Pranke <dpranke@chromium.org>
  17913. nrwt: restructure the port classes to handle multiple expectations files
  17914. https://bugs.webkit.org/show_bug.cgi?id=88944
  17915. Reviewed by Ojan Vafai.
  17916. This patch restructures the Port classes so that each port
  17917. returns a list of TestExpectations files to be used (in a new, public,
  17918. expectations_files() method), and the base implementation rolls them
  17919. up into the ordered expectations_dict(), which becomes a public
  17920. method.
  17921. port.path_to_test_expectations_file(), port.test_expectations(),
  17922. and port.test_expectations_overrides() are then reimplemented as
  17923. wrappers around port.expectations_dict().
  17924. port.test_expectations() and port.test_expectations_overrides()
  17925. will eventually be removed when the cascade is fully completed,
  17926. and port.path_to_test_expectations_file() will be removed when
  17927. the rebaselining tool supports the cascade
  17928. (expectations_files() may also become private at that point).
  17929. There should be no functional changes in this patch, but a bunch
  17930. of custom logic gets deleted!
  17931. * Scripts/webkitpy/layout_tests/port/base.py:
  17932. (Port.expectations_dict):
  17933. (Port):
  17934. (Port.expectations_files):
  17935. (Port.test_expectations):
  17936. (Port.test_expectations_overrides):
  17937. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  17938. (PortTest.test_additional_expectations):
  17939. (PortTest.test_uses_test_expectations_file):
  17940. * Scripts/webkitpy/layout_tests/port/chromium.py:
  17941. (ChromiumPort.all_baseline_variants):
  17942. (ChromiumPort.expectations_files):
  17943. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  17944. (ChromiumPortTest.test_overrides_and_builder_names):
  17945. * Scripts/webkitpy/layout_tests/port/google_chrome.py:
  17946. (_expectations_files):
  17947. (GoogleChromeLinux32Port.expectations_files):
  17948. (GoogleChromeLinux64Port.expectations_files):
  17949. (GoogleChromeMacPort.expectations_files):
  17950. (GoogleChromeWinPort.expectations_files):
  17951. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  17952. (TestGoogleChromePort._verify_expectations_overrides):
  17953. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  17954. (PortTestCase.test_expectations_ordering):
  17955. * Scripts/webkitpy/layout_tests/port/webkit.py:
  17956. (WebKitPort._skipped_file_search_paths):
  17957. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  17958. (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
  17959. (test_rebaseline_updates_expectations_file):
  17960. (test_rebaseline_does_not_include_overrides):
  17961. (test_rebaseline_expectations):
  17962. (test_overrides_are_included_correctly):
  17963. 2012-06-13 Brent Fulgham <bfulgham@webkit.org>
  17964. [WinCairo] Update URL of WinCairoRequirements.zip download.
  17965. https://bugs.webkit.org/show_bug.cgi?id=89009
  17966. Reviewed by Martin Robinson.
  17967. * Tools/Scripts/update-webkit-dependency: Put fallback code
  17968. to download a "last update" time from servers that don't properly
  17969. report Last-Modified in their HTTP header.
  17970. * Tools/Scripts/update-webkit-wincairo-libs: Change download link
  17971. for the WinCairo build requirements bundle.
  17972. 2012-06-13 Dirk Pranke <dpranke@chromium.org>
  17973. nrwt: preliminary cleanup before supporting cascading expectations files
  17974. https://bugs.webkit.org/show_bug.cgi?id=88942
  17975. Reviewed by Ojan Vafai.
  17976. This change just prepares the TestExpectations parser to get filenames
  17977. along with the expectations, and improves the warning messages so that
  17978. they contain the filenames along with the line numbers.
  17979. There should be no functional changes in this patch.
  17980. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  17981. (TestExpectationEditorTests.make_parsed_expectation_lines):
  17982. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  17983. (TestExpectationParser.parse):
  17984. (TestExpectationParser.expectation_for_skipped_test):
  17985. (TestExpectationParser._tokenize):
  17986. (TestExpectationParser._tokenize_list):
  17987. (TestExpectationLine):
  17988. (TestExpectationsModel.__init__):
  17989. (TestExpectationsModel._already_seen_better_match):
  17990. (TestExpectations.__init__):
  17991. (TestExpectations._shorten_filename):
  17992. (TestExpectations._report_warnings):
  17993. (TestExpectations._add_skipped_tests):
  17994. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  17995. (TestExpectationParserTests._tokenize):
  17996. (TestExpectationParserTests.test_tokenize_blank):
  17997. (TestExpectationParserTests.test_tokenize_missing_colon):
  17998. (TestExpectationParserTests.test_tokenize_extra_colon):
  17999. (TestExpectationParserTests.test_tokenize_empty_comment):
  18000. (TestExpectationParserTests.test_tokenize_comment):
  18001. (TestExpectationParserTests.test_tokenize_missing_equal):
  18002. (TestExpectationParserTests.test_tokenize_extra_equal):
  18003. (TestExpectationParserTests.test_tokenize_valid):
  18004. (TestExpectationParserTests.test_tokenize_valid_with_comment):
  18005. (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
  18006. (TestExpectationParserTests.test_parse_empty_string):
  18007. (TestExpectationSerializerTests._tokenize):
  18008. (TestExpectationSerializerTests.assert_round_trip):
  18009. (TestExpectationSerializerTests.assert_list_round_trip):
  18010. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  18011. (GardeningExpectationsUpdater.update_expectations):
  18012. 2012-06-13 Zan Dobersek <zandobersek@gmail.com>
  18013. [Gtk] Enable link prefetch support in the developer builds
  18014. https://bugs.webkit.org/show_bug.cgi?id=89011
  18015. Reviewed by Martin Robinson.
  18016. Enable the link prefetch support for Gtk by default in developer
  18017. builds.
  18018. * Scripts/webkitperl/FeatureList.pm:
  18019. 2012-06-13 Csaba Osztrogonác <ossy@webkit.org>
  18020. Update buildbot master in autoinstaller to match build.webkit.org
  18021. https://bugs.webkit.org/show_bug.cgi?id=88992
  18022. Reviewed by Adam Barth.
  18023. * Scripts/webkitpy/thirdparty/__init__.py:
  18024. (AutoinstallImportHook._install_buildbot):
  18025. 2012-06-13 Sheriff Bot <webkit.review.bot@gmail.com>
  18026. Unreviewed, rolling out r120209.
  18027. http://trac.webkit.org/changeset/120209
  18028. https://bugs.webkit.org/show_bug.cgi?id=89007
  18029. Broke the WebKit2 mac build. (Requested by andersca on
  18030. #webkit).
  18031. * MiniBrowser/mac/BrowserWindowController.m:
  18032. (-[BrowserWindowController awakeFromNib]):
  18033. * WebKitTestRunner/TestController.cpp:
  18034. (WTR::TestController::initialize):
  18035. 2012-06-13 Zoltan Horvath <zoltan@webkit.org>
  18036. check-webkit-style needs to respect Qt API coding style
  18037. https://bugs.webkit.org/show_bug.cgi?id=88995
  18038. Reviewed by Csaba Osztrogonác.
  18039. Add -whitespace/declaration exception to Qt API files.
  18040. * Scripts/webkitpy/style/checker.py:
  18041. 2012-06-13 Christophe Dumez <christophe.dumez@intel.com>
  18042. [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
  18043. https://bugs.webkit.org/show_bug.cgi?id=88340
  18044. Reviewed by Kenneth Rohde Christiansen.
  18045. Update initialization of WKPageLoaderClient.
  18046. * MiniBrowser/mac/BrowserWindowController.m:
  18047. (-[BrowserWindowController awakeFromNib]):
  18048. * WebKitTestRunner/TestController.cpp:
  18049. (WTR::TestController::initialize):
  18050. 2012-06-13 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  18051. [Qt] Handle multiple held buttons in touch mocking.
  18052. https://bugs.webkit.org/show_bug.cgi?id=88865
  18053. Reviewed by Kenneth Rohde Christiansen.
  18054. Add handling for multiple held mouse-buttons in the appropiate places.
  18055. To do this last-pos and start-pos are now also read from the last recorded
  18056. touch-point instead from object-global variables.
  18057. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  18058. (MiniBrowserApplication::notify):
  18059. (MiniBrowserApplication::updateTouchPoint):
  18060. * MiniBrowser/qt/MiniBrowserApplication.h:
  18061. (MiniBrowserApplication):
  18062. 2012-06-13 Simon Hausmann <simon.hausmann@nokia.com>
  18063. [Qt] Make it possible to disable -Werror in production builds
  18064. Reviewed by Tor Arne Vestbø.
  18065. Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
  18066. something qt5.git's qtwebkit.pri will soon do.
  18067. * qmake/mkspecs/features/unix/default_post.prf:
  18068. 2012-06-13 Dominik Röttsches <dominik.rottsches@intel.com>
  18069. [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
  18070. https://bugs.webkit.org/show_bug.cgi?id=85790
  18071. Reviewed by Gustavo Noronha Silva.
  18072. Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
  18073. code in webkitdirs.pm.
  18074. * Scripts/webkitdirs.pm:
  18075. (jhbuildConfigurationChanged):
  18076. (saveJhbuildMd5):
  18077. (cleanJhbuild):
  18078. (buildAutotoolsProject):
  18079. (generateBuildSystemFromCMakeProject):
  18080. 2012-06-13 Qi Zhang <qi.2.zhang@nokia.com>
  18081. [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
  18082. https://bugs.webkit.org/show_bug.cgi?id=88763
  18083. Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
  18084. extension.
  18085. Reviewed by Simon Hausmann.
  18086. * qmake/config.tests/libzlib: Added.
  18087. * qmake/config.tests/libzlib/libzlib.cpp: Added.
  18088. (main):
  18089. * qmake/config.tests/libzlib/libzlib.pro: Added.
  18090. * qmake/mkspecs/features/features.prf:
  18091. * qmake/sync.profile:
  18092. 2012-06-13 Robin Cao <robin.cao@torchmobile.com.cn>
  18093. [BlackBerry] Enable MEDIA_STREAM by default
  18094. https://bugs.webkit.org/show_bug.cgi?id=88849
  18095. Reviewed by Antonio Gomes.
  18096. * Scripts/webkitperl/FeatureList.pm:
  18097. 2012-06-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  18098. Prevent stderr output from messing up detection of build path
  18099. https://bugs.webkit.org/show_bug.cgi?id=88075
  18100. Warnings such as 'perl: warning: Setting locale failed' will otherwise
  18101. end up as the build path when calling out to webkit-build-directory.
  18102. Reviewed by Ojan Vafai.
  18103. * Scripts/webkitpy/layout_tests/port/config.py:
  18104. (Config.build_directory):
  18105. 2012-06-13 Ryosuke Niwa <rniwa@webkit.org>
  18106. Update the builder name for Apple Lion builders.
  18107. * Scripts/webkitpy/layout_tests/port/builders.py:
  18108. 2012-06-13 Joel Dillon <joel.dillon@codethink.co.uk>
  18109. [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
  18110. https://bugs.webkit.org/show_bug.cgi?id=88874
  18111. Reviewed by Simon Hausmann.
  18112. Rename main.cpp in QtTestBrowser because on Windows
  18113. it conflicts with main.cpp from DumpRenderTree.
  18114. * QtTestBrowser/QtTestBrowser.pro:
  18115. * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
  18116. (launcherMain):
  18117. (LauncherApplication):
  18118. (LauncherApplication::urls):
  18119. (LauncherApplication::isRobotized):
  18120. (LauncherApplication::robotTimeout):
  18121. (LauncherApplication::robotExtraTime):
  18122. (LauncherApplication::applyDefaultSettings):
  18123. (LauncherApplication::LauncherApplication):
  18124. (requiresGraphicsView):
  18125. (LauncherApplication::handleUserOptions):
  18126. (main):
  18127. 2012-06-12 Lucas Forschler <lforschler@apple.com>
  18128. Wrap bot types inside ().
  18129. https://bugs.webkit.org/show_bug.cgi?id=88893
  18130. Reviewed by Stephanie Lewis.
  18131. * BuildSlaveSupport/build.webkit.org-config/config.json:
  18132. 2012-06-12 Christophe Dumez <christophe.dumez@intel.com>
  18133. [soup] Prevent setting or editing httpOnly cookies from JavaScript
  18134. https://bugs.webkit.org/show_bug.cgi?id=88760
  18135. Reviewed by Gustavo Noronha Silva.
  18136. Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
  18137. to v2.33.2 for both GTK and EFL ports.
  18138. * efl/jhbuild.modules:
  18139. * gtk/jhbuild.modules:
  18140. 2012-06-12 Christophe Dumez <christophe.dumez@intel.com>
  18141. [EFL] Enable SHADOW_DOM flag
  18142. https://bugs.webkit.org/show_bug.cgi?id=87732
  18143. Reviewed by Kentaro Hara.
  18144. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  18145. (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
  18146. SHADOW_DOM by default in DRT.
  18147. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  18148. (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
  18149. Chromium and Mac ports.
  18150. (drtViewAdd):
  18151. * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
  18152. at compile time for EFL port.
  18153. 2012-06-12 Ashod Nakashian <ashodnakashian@yahoo.com>
  18154. WinLauncher should show loading errors
  18155. https://bugs.webkit.org/show_bug.cgi?id=80760
  18156. Reviewed by Brent Fulgham.
  18157. * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
  18158. (WinLauncherWebHost::didFailProvisionalLoadWithError):
  18159. * WinLauncher/WinLauncher.h:
  18160. (WinLauncherWebHost::didFailProvisionalLoadWithError):
  18161. (WinLauncherWebHost):
  18162. 2012-06-12 Ryuan Choi <ryuan.choi@samsung.com>
  18163. [EFL][WK2] Add MiniBrowserEfl.
  18164. https://bugs.webkit.org/show_bug.cgi?id=61850
  18165. Reviewed by Chang Shu.
  18166. Implement MiniBrowser for EFL.
  18167. * CMakeLists.txt:
  18168. * MiniBrowser/efl/CMakeLists.txt: Added.
  18169. * MiniBrowser/efl/main.c: Added.
  18170. (_MiniBrowser):
  18171. (main_signal_exit):
  18172. (on_ecore_evas_resize):
  18173. (browserCreate):
  18174. (main):
  18175. 2012-06-12 Helder Correia <helder.correia@nokia.com>
  18176. Unreviewed. Update my email address in committers.py.
  18177. * Scripts/webkitpy/common/config/committers.py:
  18178. 2012-06-12 Dominik Röttsches <dominik.rottsches@intel.com>
  18179. [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
  18180. https://bugs.webkit.org/show_bug.cgi?id=84707
  18181. Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
  18182. use_lib64 variable is preconfigured to True by jhbuild.
  18183. Reviewed by Dirk Pranke.
  18184. * efl/jhbuildrc:
  18185. 2012-06-12 Dana Jansens <danakj@chromium.org>
  18186. Add zlieber@chromium.org to contributors list
  18187. https://bugs.webkit.org/show_bug.cgi?id=88904
  18188. Unreviewed.
  18189. * Scripts/webkitpy/common/config/committers.py:
  18190. 2012-06-12 Lucas Forschler <lforschler@apple.com>
  18191. Rename Apple bots to a standard convention.
  18192. https://bugs.webkit.org/show_bug.cgi?id=88893
  18193. Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
  18194. Reviewed by Simon Fraser.
  18195. * BuildSlaveSupport/build.webkit.org-config/config.json:
  18196. 2012-06-12 Mike West <mkwst@chromium.org>
  18197. Make document.documentURI readonly from JavaScript
  18198. https://bugs.webkit.org/show_bug.cgi?id=65187
  18199. Reviewed by Alexey Proskuryakov.
  18200. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  18201. * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
  18202. * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
  18203. (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
  18204. (TestWebKitAPI):
  18205. (TestWebKitAPI::TEST):
  18206. 2012-06-12 Christophe Dumez <christophe.dumez@intel.com>
  18207. [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
  18208. https://bugs.webkit.org/show_bug.cgi?id=88715
  18209. Reviewed by Noam Rosenthal.
  18210. Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
  18211. * Scripts/webkitperl/FeatureList.pm:
  18212. 2012-06-12 Csaba Osztrogonác <ossy@webkit.org>
  18213. [Qt] Fix -Werror for the buildbots
  18214. https://bugs.webkit.org/show_bug.cgi?id=88223
  18215. Rubber-stamped by Tor Arne Vestbø.
  18216. Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
  18217. * qmake/mkspecs/features/unix/default_post.prf:
  18218. 2012-06-12 Balazs Kelemen <kbalazs@webkit.org>
  18219. [REGRESSION][WTR] Build fail with werror after r120054
  18220. https://bugs.webkit.org/show_bug.cgi?id=88862
  18221. Reviewed by Csaba Osztrogonác.
  18222. Some static helpers become unused after counterValueForElementById
  18223. has moved to Internals. Let's remove them.
  18224. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  18225. (WTR):
  18226. 2012-06-12 Csaba Osztrogonác <ossy@webkit.org>
  18227. [Qt] Slave losts cause build break on bots
  18228. https://bugs.webkit.org/show_bug.cgi?id=38980
  18229. Minor fix after r59261.
  18230. Reviewed by Tor Arne Vestbø.
  18231. * Scripts/build-webkit:
  18232. (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
  18233. 2012-06-11 Kaustubh Atrawalkar <kaustubh@motorola.com>
  18234. [DRT] LTC:: counterValueForElementById() could be moved to Internals.
  18235. https://bugs.webkit.org/show_bug.cgi?id=84406
  18236. Reviewed by Hajime Morita.
  18237. Move the counterValueForElementById from LayoutTestCotroller to Internals and
  18238. remove the old platform specific implementations as it exclusively tests WebCore functionality.
  18239. * DumpRenderTree/LayoutTestController.cpp:
  18240. (LayoutTestController::staticFunctions):
  18241. * DumpRenderTree/LayoutTestController.h:
  18242. (LayoutTestController):
  18243. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  18244. * DumpRenderTree/chromium/LayoutTestController.cpp:
  18245. (LayoutTestController::LayoutTestController):
  18246. (LayoutTestController::setPOSIXLocale):
  18247. * DumpRenderTree/chromium/LayoutTestController.h:
  18248. (LayoutTestController):
  18249. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  18250. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  18251. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  18252. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  18253. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  18254. (LayoutTestController):
  18255. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  18256. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  18257. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  18258. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  18259. (WTR):
  18260. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  18261. (LayoutTestController):
  18262. 2012-06-11 Hans Wennborg <hans@chromium.org>
  18263. Speech JavaScript API: Make SpeechRecognitionError an Event
  18264. https://bugs.webkit.org/show_bug.cgi?id=88784
  18265. Reviewed by Adam Barth.
  18266. Make it possible to have MockWebSpeechRecognizer fire error events.
  18267. * DumpRenderTree/chromium/LayoutTestController.cpp:
  18268. (LayoutTestController::LayoutTestController):
  18269. (LayoutTestController::setMockSpeechRecognitionError):
  18270. * DumpRenderTree/chromium/LayoutTestController.h:
  18271. (LayoutTestController):
  18272. * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
  18273. (WebKit):
  18274. (ErrorTask):
  18275. (WebKit::ErrorTask::ErrorTask):
  18276. (MockWebSpeechRecognizer::addMockResult):
  18277. (MockWebSpeechRecognizer::setError):
  18278. * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
  18279. (MockWebSpeechRecognizer):
  18280. 2012-06-11 Ojan Vafai <ojan@chromium.org>
  18281. Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
  18282. https://bugs.webkit.org/show_bug.cgi?id=88836
  18283. Reviewed by Dirk Pranke.
  18284. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  18285. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  18286. 2012-06-11 Christophe Dumez <christophe.dumez@intel.com>
  18287. [EFL] Remove CMakeCache.txt before building
  18288. https://bugs.webkit.org/show_bug.cgi?id=88717
  18289. Reviewed by Antonio Gomes.
  18290. Remove CMake cache file before every build to avoid using outdated
  18291. build flags when new features get enabled. This will avoid unexpected
  18292. failures on the bots due to outdated build flags.
  18293. * Scripts/webkitdirs.pm:
  18294. (generateBuildSystemFromCMakeProject):
  18295. 2012-06-11 Vincent Scheib <scheib@chromium.org>
  18296. Add new Pointer Lock spec attribute webkitPointerLockElement.
  18297. https://bugs.webkit.org/show_bug.cgi?id=88799
  18298. Reviewed by Dimitri Glazkov.
  18299. Part of a series of refactoring changes to update pointer lock API to
  18300. the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
  18301. New attribute webkitPointerLockElement added. Follow up patches
  18302. will remove the previous isLocked attribute. Tests updated to use
  18303. the new attribute.
  18304. WebViewHost logic required modification to correctly repond to
  18305. a lock, unlock, pointerLockElement call series. Specifically,
  18306. unlocking must be queued after a lock command is issued always
  18307. as the lock state may not be set yet with a lock request in flight.
  18308. * DumpRenderTree/chromium/WebViewHost.cpp:
  18309. (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
  18310. (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
  18311. 2012-06-11 Alexis Menard <alexis.menard@openbossa.org>
  18312. [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
  18313. https://bugs.webkit.org/show_bug.cgi?id=88804
  18314. Reviewed by Tony Chang.
  18315. Protect box-decoration-break behind a feature flag enabled by default.
  18316. * Scripts/webkitperl/FeatureList.pm:
  18317. * qmake/mkspecs/features/features.pri:
  18318. 2012-06-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  18319. [CMAKE][EFL] Remove duplicated executable output path
  18320. https://bugs.webkit.org/show_bug.cgi?id=88765
  18321. Reviewed by Daniel Bates.
  18322. CMake files for EFL port have redefined executable output path. However, EFL port doesn't
  18323. need to define again because it is already defined in top-level CMake file.
  18324. * DumpRenderTree/efl/CMakeLists.txt:
  18325. * EWebLauncher/CMakeLists.txt:
  18326. 2012-06-11 Ojan Vafai <ojan@chromium.org>
  18327. Don't consider show warnings in the garden-o-matic UI for non-layout test failures
  18328. https://bugs.webkit.org/show_bug.cgi?id=88816
  18329. Reviewed by Dirk Pranke.
  18330. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  18331. Expose a way to clear AsynchronousCaches.
  18332. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  18333. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  18334. Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
  18335. 2012-06-11 Dirk Pranke <dpranke@chromium.org>
  18336. nrwt exits early too frequently
  18337. https://bugs.webkit.org/show_bug.cgi?id=73843
  18338. Reviewed by Ryosuke Niwa.
  18339. Change the defaults for new-run-webkit-tests for both
  18340. --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
  18341. to zero (i.e., we will never exit early by default).
  18342. If people want their buildbots to exit early it is their
  18343. responsibility to update their buildbot configs appropriately.
  18344. Note that we have tests that ensure that these flags work for
  18345. non-zero numbers, but we don't have tests that either test the
  18346. default or ensure that zero means "run all of the tests". I
  18347. think that's okay but can add tests if others disagree.
  18348. Also note that it looks like no changes on the build.webkit.org
  18349. master.cfg are necessary; all of the bots seem to be using the
  18350. RunWebKitTests wrapper which is already setting the flags. There
  18351. is a NewRunWebKitTests wrapper, but that looks to be unused; I
  18352. will delete that in a separate patch.
  18353. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  18354. (parse_args):
  18355. 2012-06-11 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  18356. [EFL] [DRT] Reset CacheModel before running each test
  18357. https://bugs.webkit.org/show_bug.cgi?id=87534
  18358. Reviewed by Gustavo Noronha Silva.
  18359. Reset cache model to default before running each test to fix some
  18360. flaky tests on EFL build bots. Also fix case value in setCacheModel.
  18361. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  18362. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  18363. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  18364. (LayoutTestController::setCacheModel):
  18365. 2012-06-11 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  18366. [GTK] Memory leaks in DRT EventSender.cpp
  18367. https://bugs.webkit.org/show_bug.cgi?id=88774
  18368. Reviewed by Martin Robinson.
  18369. Fix a few possible memory leaks in EventSender code.
  18370. * DumpRenderTree/gtk/EventSender.cpp:
  18371. (contextClickCallback): Free the event returned by gdk_event_new().
  18372. (mouseDownCallback): Ditto.
  18373. (mouseUpCallback): Ditto.
  18374. 2012-06-11 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  18375. [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
  18376. https://bugs.webkit.org/show_bug.cgi?id=88661
  18377. Reviewed by Dirk Pranke.
  18378. Pass string length explicitly when creating String object from
  18379. non-null-terminated UChar* returned by characters().
  18380. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  18381. (LayoutTestController::pathToLocalResource):
  18382. 2012-06-11 David Dorwin <ddorwin@chromium.org>
  18383. [chromium] Provide access to the WebPlugin created by the helper plugin widget
  18384. https://bugs.webkit.org/show_bug.cgi?id=88028
  18385. Reviewed by Adam Barth.
  18386. Added isPlaceholder() to WebPlugin.
  18387. * DumpRenderTree/chromium/TestWebPlugin.h:
  18388. (TestWebPlugin::isPlaceholder):
  18389. 2012-06-11 Tony Chang <tony@chromium.org>
  18390. rebaseline from garden-o-matic leaves N processes each time it is run
  18391. https://bugs.webkit.org/show_bug.cgi?id=88586
  18392. Reviewed by Dirk Pranke.
  18393. This appears to only be a problem on python 2.7. Maybe a bug causing
  18394. pools to not be garbage collected?
  18395. * Scripts/webkitpy/common/system/executive.py:
  18396. (Executive.run_in_parallel): close() and join() the process pool.
  18397. * Scripts/webkitpy/common/system/executive_unittest.py:
  18398. (ExecutiveTest.test_run_in_parallel):
  18399. 2012-06-11 Zoltan Horvath <zoltan@webkit.org>
  18400. [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
  18401. https://bugs.webkit.org/show_bug.cgi?id=87841
  18402. Reviewed by Simon Hausmann.
  18403. * qmake/config.tests/libwebp/libwebp.cpp: Added.
  18404. (main):
  18405. * qmake/config.tests/libwebp/libwebp.pro: Added.
  18406. * qmake/sync.profile:
  18407. 2012-06-10 Ryosuke Niwa <rniwa@webkit.org>
  18408. Expose layoutTestController as testRunner
  18409. https://bugs.webkit.org/show_bug.cgi?id=88210
  18410. Reviewed by Darin Adler.
  18411. * DumpRenderTree/LayoutTestController.cpp:
  18412. (LayoutTestController::makeWindowObject):
  18413. * DumpRenderTree/chromium/TestShell.cpp:
  18414. (TestShell::bindJSObjectsToWindow):
  18415. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  18416. (WebCore::DumpRenderTree::initJSObjects):
  18417. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  18418. (WTR::LayoutTestController::makeWindowObject):
  18419. 2012-06-09 Dominic Cooney <dominicc@chromium.org>
  18420. [Chromium] Remove JavaScriptCore dependencies from gyp
  18421. https://bugs.webkit.org/show_bug.cgi?id=88510
  18422. Reviewed by Adam Barth.
  18423. Chromium doesn't support JSC any more and there doesn't seem to be
  18424. a strong interest in using GYP as the common build system in other
  18425. ports.
  18426. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  18427. * Scripts/generate-project-files: Removed.
  18428. 2012-06-09 Sukolsak Sakshuwong <sukolsak@google.com>
  18429. Add UNDO_MANAGER flag
  18430. https://bugs.webkit.org/show_bug.cgi?id=87908
  18431. Reviewed by Tony Chang.
  18432. * Scripts/webkitperl/FeatureList.pm:
  18433. * qmake/mkspecs/features/features.pri:
  18434. 2012-06-08 Ryosuke Niwa <rniwa@webkit.org>
  18435. webkit-patch land-safely should set cq? if the patch author is not in committers.py
  18436. https://bugs.webkit.org/show_bug.cgi?id=88689
  18437. Reviewed by Dirk Pranke.
  18438. When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
  18439. in committers.py or the contributor cannot commit. If anything, the contributor can still
  18440. set cq+ on thier patches manually so I don't think this will be an issue for people who
  18441. don't list their Bugzille email on committers.py.
  18442. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  18443. (Bugzilla._commit_queue_flag):
  18444. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  18445. (test_commit_queue_flag):
  18446. (test_commit_queue_flag.assert_commit_queue_flag):
  18447. 2012-06-08 Dirk Pranke <dpranke@chromium.org>
  18448. remove obsolete NewRunWebKitTests buildbot master factory classes
  18449. https://bugs.webkit.org/show_bug.cgi?id=88693
  18450. Reviewed by Ryosuke Niwa.
  18451. I believe these aren't used any more ...
  18452. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  18453. (RunWebKitTests.getText2):
  18454. (BuildAndTestLeaksFactory):
  18455. 2012-06-08 Xianzhu Wang <wangxianzhu@chromium.org>
  18456. [Chromium-Android] Build DumpRenderTree with Android SDK
  18457. https://bugs.webkit.org/show_bug.cgi?id=88598
  18458. Change WebKit side of DRT related code according to some recent changes at chromium side.
  18459. Reviewed by Adam Barth.
  18460. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  18461. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  18462. (ChromiumAndroidPort.__init__):
  18463. (ChromiumAndroidPort._path_to_driver):
  18464. 2012-06-08 Wei James <james.wei@intel.com>
  18465. Add app_abi option for DumpRenderTree_apk
  18466. https://bugs.webkit.org/show_bug.cgi?id=88626
  18467. Reviewed by Adam Barth.
  18468. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  18469. 2012-06-08 Carlos Garcia Campos <cgarcia@igalia.com>
  18470. [GTK] Add API to get the library version to WebKit2 GTK+
  18471. https://bugs.webkit.org/show_bug.cgi?id=88426
  18472. Reviewed by Martin Robinson.
  18473. * gtk/generate-gtkdoc:
  18474. (get_webkit2_options): Add built sources to the list of files, but
  18475. ignore enum types and marshallers.
  18476. 2012-06-07 Vincent Scheib <scheib@chromium.org>
  18477. Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
  18478. https://bugs.webkit.org/show_bug.cgi?id=88604
  18479. Reviewed by Kent Tamura.
  18480. DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
  18481. Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
  18482. * DumpRenderTree/chromium/WebViewHost.cpp:
  18483. (WebViewHost::requestPointerUnlock):
  18484. 2012-06-08 Hans Wennborg <hans@chromium.org>
  18485. Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
  18486. https://bugs.webkit.org/show_bug.cgi?id=87976
  18487. Reviewed by Kent Tamura.
  18488. Provide a mock implementation of WebSpeechRecognizer for
  18489. DumpRenderTree. This will allow better testing of the API via layout
  18490. tests.
  18491. * DumpRenderTree/DumpRenderTree.gypi:
  18492. * DumpRenderTree/chromium/LayoutTestController.cpp:
  18493. (LayoutTestController::LayoutTestController):
  18494. (LayoutTestController::addMockSpeechRecognitionResult):
  18495. * DumpRenderTree/chromium/LayoutTestController.h:
  18496. (LayoutTestController):
  18497. * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
  18498. (MockWebSpeechRecognizer::create):
  18499. (MockWebSpeechRecognizer::start):
  18500. (MockWebSpeechRecognizer::stop):
  18501. (MockWebSpeechRecognizer::abort):
  18502. (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
  18503. (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
  18504. (MockWebSpeechRecognizer::ResultTask::runIfValid):
  18505. * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
  18506. (WebKit):
  18507. (MockWebSpeechRecognizer):
  18508. (MockWebSpeechRecognizer::addMockResult):
  18509. (MockWebSpeechRecognizer::taskList):
  18510. (ClientCallTask):
  18511. (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
  18512. (ResultTask):
  18513. (MockWebSpeechRecognizer::ResultTask::ResultTask):
  18514. (NoMatchTask):
  18515. (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
  18516. * DumpRenderTree/chromium/WebViewHost.cpp:
  18517. (WebViewHost::speechRecognizer):
  18518. * DumpRenderTree/chromium/WebViewHost.h:
  18519. (WebViewHost):
  18520. (WebViewHost::mockSpeechRecognizer):
  18521. 2012-06-07 Kinuko Yasuda <kinuko@chromium.org>
  18522. check-webkit-style needs to be taught about <public/Foo.h>
  18523. https://bugs.webkit.org/show_bug.cgi?id=88524
  18524. Reviewed by David Levin.
  18525. * Scripts/webkitpy/style/checkers/cpp.py:
  18526. (_classify_include):
  18527. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  18528. (OrderOfIncludesTest.test_public_primary_header):
  18529. (OrderOfIncludesTest.test_classify_include):
  18530. 2012-06-07 Joshua Lock <joshua.lock@intel.com>
  18531. [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
  18532. https://bugs.webkit.org/show_bug.cgi?id=67255
  18533. Reviewed by Dirk Pranke.
  18534. Implement pathToLocalResource to redirect file:///tmp URL's to
  18535. DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
  18536. LayoutTests sub-directory of the WebKit source tree.
  18537. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  18538. (LayoutTestController::pathToLocalResource):
  18539. 2012-06-07 Tony Payne <tpayne@chromium.org>
  18540. [chromium] Allow LayoutTests under new git workflow
  18541. https://bugs.webkit.org/show_bug.cgi?id=88575
  18542. On Windows, chromium indirects through git.bat. Adds the same hack that
  18543. is currently used for discovering svn.bat to support the new git
  18544. workflow.
  18545. Reviewed by Dirk Pranke.
  18546. * Scripts/webkitpy/common/checkout/scm/git.py:
  18547. (Git): Replaces all hard-coded references to 'git' with the class
  18548. variable executable_name.
  18549. (Git._check_git_architecture):
  18550. (Git.in_working_directory):
  18551. (Git.find_checkout_root):
  18552. (Git.read_git_config):
  18553. (Git.discard_local_commits):
  18554. (Git.local_commits):
  18555. (Git.working_directory_is_clean):
  18556. (Git.clean_working_directory):
  18557. (Git.status_command):
  18558. (Git.add_list):
  18559. (Git.delete_list):
  18560. (Git.exists):
  18561. (Git._current_branch):
  18562. (Git.changed_files):
  18563. (Git._changes_files_for_commit):
  18564. (Git.revisions_changing_file):
  18565. (Git.conflicted_files):
  18566. (Git.svn_revision):
  18567. (Git.create_patch):
  18568. (Git._run_git_svn_find_rev):
  18569. (Git.contents_at_revision):
  18570. (Git.diff_for_file):
  18571. (Git.show_head):
  18572. (Git.committer_email_for_revision):
  18573. (Git.apply_reverse_diff):
  18574. (Git.revert_files):
  18575. (Git.commit_with_message):
  18576. (Git._commit_on_branch):
  18577. (Git.svn_commit_log):
  18578. (Git.last_svn_commit_log):
  18579. (Git.svn_blame):
  18580. (Git._branch_ref_exists):
  18581. (Git.delete_branch):
  18582. (Git.remote_merge_base):
  18583. (Git.commit_locally_with_message):
  18584. (Git.push_local_commits_to_server):
  18585. (Git.commit_ids_from_commitish_arguments):
  18586. (Git.commit_message_for_local_commit):
  18587. (Git.files_changed_summary_for_commit):
  18588. * Scripts/webkitpy/common/host.py:
  18589. (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
  18590. that duplicates the logic in the existing 'svn.bat' hack.
  18591. 2012-06-07 Ojan Vafai <ojan@chromium.org>
  18592. Style build architectures like build versions for non-layout test failures
  18593. https://bugs.webkit.org/show_bug.cgi?id=88590
  18594. Reviewed by Tony Chang.
  18595. Since we show the list of failing tests after the architecture, we want the
  18596. buildtype and architecture to be grouped together visually.
  18597. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
  18598. (.effects a.failing-builder>span.architecture):
  18599. 2012-06-07 Xianzhu Wang <wangxianzhu@chromium.org>
  18600. [Chromium] Remove header dependency of ImageDiff to WTF
  18601. https://bugs.webkit.org/show_bug.cgi?id=88422
  18602. Reviewed by Ryosuke Niwa.
  18603. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  18604. * DumpRenderTree/chromium/ImageDiff.cpp:
  18605. (untestedCompareImages):
  18606. 2012-06-07 Dongwoo Im <dw.im@samsung.com>
  18607. [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
  18608. https://bugs.webkit.org/show_bug.cgi?id=88491
  18609. Reviewed by Dirk Pranke.
  18610. DRT should enable WebAudio when WebAudio feature is enabled,
  18611. so that the WebAudio feature could be tested by the Layouttest.
  18612. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
  18613. (LayoutTestController::overridePreference):
  18614. 2012-06-07 Dirk Pranke <dpranke@chromium.org>
  18615. webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
  18616. https://bugs.webkit.org/show_bug.cgi?id=88581
  18617. Reviewed by Ojan Vafai.
  18618. webkit-paptch rebaseline-expectations was ignoring what the
  18619. expected results for a test were and pulling down all the result
  18620. files from a bot. This could lead to us pulling down old,
  18621. incorrect .txt or .png files. With this patch we will now only
  18622. pull down expectations of the appropriate file types (so an
  18623. IMAGE failure will only pull the png and not the txt file).
  18624. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  18625. (has_pixel_failures):
  18626. (suffixes_for_expectations):
  18627. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  18628. (FunctionsTest.test_suffixes_for_expectations):
  18629. * Scripts/webkitpy/tool/commands/rebaseline.py:
  18630. (AbstractRebaseliningCommand.__init__):
  18631. (RebaselineExpectations._is_supported_port):
  18632. (RebaselineExpectations._update_expectations_file):
  18633. (RebaselineExpectations._tests_to_rebaseline):
  18634. (RebaselineExpectations._rebaseline_port):
  18635. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  18636. (test_overrides_are_included_correctly):
  18637. 2012-06-07 Ojan Vafai <ojan@chromium.org>
  18638. Fix recent null pointer error regression in the flakiness dashboard
  18639. https://bugs.webkit.org/show_bug.cgi?id=88573
  18640. Reviewed by Dirk Pranke.
  18641. * TestResultServer/static-dashboards/builders.js:
  18642. (requestBuilderList):
  18643. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  18644. 2012-06-07 Konrad Piascik <kpiascik@rim.com>
  18645. Add Konrad Piascik to committers.py
  18646. https://bugs.webkit.org/show_bug.cgi?id=88560
  18647. Unreviewed.
  18648. * Scripts/webkitpy/common/config/committers.py:
  18649. 2012-06-07 Tony Chang <tony@chromium.org>
  18650. [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
  18651. https://bugs.webkit.org/show_bug.cgi?id=77368
  18652. Reviewed by Ojan Vafai.
  18653. It doesn't look like we ever get a rect with width or height of 0.
  18654. I ran css1, css2.1, fast/forms, and tables without any crashes.
  18655. * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
  18656. (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
  18657. 2012-06-07 Dirk Pranke <dpranke@chromium.org>
  18658. run-webkit-tests --lint-test-files gives an error when run on linux
  18659. https://bugs.webkit.org/show_bug.cgi?id=88551
  18660. Reviewed by Ojan Vafai.
  18661. We weren't mapping the expectations properly for the
  18662. google-chrome ports.
  18663. * Scripts/webkitpy/layout_tests/port/base.py:
  18664. (Port.path_to_test_expectations_file):
  18665. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  18666. (TestGoogleChromePort.test_path_to_expectations):
  18667. 2012-06-07 Daniel Erat <derat@chromium.org>
  18668. [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
  18669. https://bugs.webkit.org/show_bug.cgi?id=88263
  18670. Reviewed by Tony Chang.
  18671. * DumpRenderTree/chromium/LayoutTestController.cpp:
  18672. (LayoutTestController::LayoutTestController):
  18673. (LayoutTestController::reset):
  18674. (LayoutTestController::setTextSubpixelPositioning):
  18675. * DumpRenderTree/chromium/LayoutTestController.h:
  18676. (LayoutTestController):
  18677. * DumpRenderTree/chromium/fonts.conf:
  18678. 2012-06-07 Zan Dobersek <zandobersek@gmail.com>
  18679. [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
  18680. https://bugs.webkit.org/show_bug.cgi?id=88060
  18681. Reviewed by Martin Robinson.
  18682. Spin the main loop before acquiring the pixel content. This ensures things
  18683. like late size allocations are finished before calling gtk_widget_draw,
  18684. avoiding assertions and subsequent empty pixel results.
  18685. * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
  18686. (createBitmapContextFromWebView):
  18687. 2012-06-06 Kenneth Rohde Christiansen <kenneth@webkit.org>
  18688. [Qt] Improve the visual of the viewport info box
  18689. https://bugs.webkit.org/show_bug.cgi?id=88410
  18690. Reviewed by Tor Arne Vestbø.
  18691. Improve the visual and make it possible to see the content more easy.
  18692. * MiniBrowser/qt/qml/ViewportInfoItem.qml:
  18693. 2012-06-06 Mariusz Grzegorczyk <mariusz.g@samsung.com>
  18694. [EFL][WK2] Compile webkit1 and webkit2 by default.
  18695. https://bugs.webkit.org/show_bug.cgi?id=85041
  18696. Reviewed by Chang Shu.
  18697. Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
  18698. Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
  18699. * Scripts/build-webkit:
  18700. 2012-06-06 Sheriff Bot <webkit.review.bot@gmail.com>
  18701. Unreviewed, rolling out r119662.
  18702. http://trac.webkit.org/changeset/119662
  18703. https://bugs.webkit.org/show_bug.cgi?id=88487
  18704. Broke builds (Requested by rniwa on #webkit).
  18705. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  18706. * DumpRenderTree/chromium/ImageDiff.cpp:
  18707. (untestedCompareImages):
  18708. 2012-06-06 Xianzhu Wang <wangxianzhu@chromium.org>
  18709. [Chromium] Remove header dependency of ImageDiff to WTF
  18710. https://bugs.webkit.org/show_bug.cgi?id=88422
  18711. Reviewed by Adam Barth.
  18712. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  18713. * DumpRenderTree/chromium/ImageDiff.cpp:
  18714. (untestedCompareImages):
  18715. 2012-06-06 Amy Ousterhout <aousterh@chromium.org>
  18716. [WebKit] DeviceOrientation cleanup
  18717. https://bugs.webkit.org/show_bug.cgi?id=88406
  18718. Reviewed by Kent Tamura.
  18719. Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
  18720. * DumpRenderTree/chromium/LayoutTestController.cpp:
  18721. (LayoutTestController::setMockDeviceOrientation):
  18722. 2012-05-29 Dirk Pranke <dpranke@chromium.org>
  18723. webkitpy: add support for an ordered dict of test expectations
  18724. https://bugs.webkit.org/show_bug.cgi?id=87802
  18725. Reviewed by Ojan Vafai.
  18726. As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
  18727. support a cascaded list of test expectations files. An easy way
  18728. to think of this is as an ordered dictionary of name -> contents
  18729. for files, where the name is usually a path on disk (I say
  18730. usually because we want to support other kinds of expectations
  18731. like the compile-time skips for unsupported features in
  18732. webkit.py, and we want to continue to support "in-memory" test
  18733. expectations that don't require a filesystem).
  18734. Conveniently there is an OrderedDict implementation in Python
  18735. 2.7+ and it is available as a backport, so the first step in
  18736. adding this support is to use that implementation. Subsequent
  18737. patches will update the test_expectations.py module (and other
  18738. callers) to access the dict directly.
  18739. This patch just changes the base internal implementation and
  18740. provides wrappers for compatibility. The derived ports
  18741. (WebKitPort, TestPort, etc.) still need to be updated.
  18742. * Scripts/webkitpy/layout_tests/port/base.py:
  18743. (Port._expectations_dict):
  18744. (Port.test_expectations):
  18745. (Port):
  18746. (Port._expectations_overrides_dict):
  18747. (Port.test_expectations_overrides):
  18748. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  18749. (PortTestCase.test_expectations_ordering):
  18750. (PortTestCase):
  18751. (PortTestCase.test_expectations_overrides_ordering):
  18752. * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
  18753. (OrderedDict):
  18754. (OrderedDict.__init__):
  18755. (OrderedDict.clear):
  18756. (OrderedDict.__setitem__):
  18757. (OrderedDict.__delitem__):
  18758. (OrderedDict.__iter__):
  18759. (OrderedDict.__reversed__):
  18760. (OrderedDict.popitem):
  18761. (OrderedDict.__reduce__):
  18762. (OrderedDict.__repr__):
  18763. (OrderedDict.copy):
  18764. (OrderedDict.fromkeys):
  18765. 2012-06-06 Mario Sanchez Prada <msanchez@igalia.com>
  18766. Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
  18767. * gtk/run-api-tests:
  18768. (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
  18769. 2012-06-06 Dirk Pranke <dpranke@chromium.org>
  18770. nrwt should look in 'out' for binaries on chromium win to support ninja
  18771. https://bugs.webkit.org/show_bug.cgi?id=88273
  18772. Reviewed by Tony Chang.
  18773. This patch standardizes the search algorithm the chromium ports
  18774. use to figure out which driver to run. We will look in a
  18775. chromium location before a webkit location (e.g., in
  18776. Source/WebKit/chromium/out before out/) and we will look in the
  18777. "legacy" directory (xcodebuild) before the directory ninja uses
  18778. (out).
  18779. Unfortunately due to the way the test code is set up testing the
  18780. properly requires some duplication of test code. I will fix that
  18781. in a followup patch.
  18782. * Scripts/webkitpy/layout_tests/port/chromium.py:
  18783. (ChromiumPort):
  18784. (ChromiumPort._static_build_path):
  18785. (ChromiumPort._build_path):
  18786. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  18787. (ChromiumLinuxPort):
  18788. (ChromiumLinuxPort._determine_driver_path_statically):
  18789. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  18790. (ChromiumLinuxPortTest.test_build_path):
  18791. (ChromiumLinuxPortTest):
  18792. (ChromiumLinuxPortTest.test_driver_name_option):
  18793. (ChromiumLinuxPortTest.path_to_image_diff):
  18794. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  18795. (ChromiumMacPort):
  18796. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  18797. (ChromiumMacPortTest.test_build_path):
  18798. (ChromiumMacPortTest):
  18799. (ChromiumMacPortTest.test_driver_name_option):
  18800. (ChromiumMacPortTest.path_to_image_diff):
  18801. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  18802. (ChromiumPortTest.test_overrides_and_builder_names):
  18803. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  18804. (ChromiumWinPort):
  18805. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  18806. (ChromiumWinTest.test_build_path):
  18807. (ChromiumWinTest.test_operating_system):
  18808. (ChromiumWinTest):
  18809. (ChromiumWinTest.test_driver_name_option):
  18810. (ChromiumWinPortTest.path_to_image_diff):
  18811. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  18812. (PortTestCase.assert_build_path):
  18813. 2012-06-06 Jessie Berlin <jberlin@apple.com>
  18814. Remove very red Windows WebKit2 testers
  18815. https://bugs.webkit.org/show_bug.cgi?id=88452
  18816. Reviewed by Steve Falkenburg.
  18817. Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
  18818. need to focus on getting the WK1 testers green.
  18819. * BuildSlaveSupport/build.webkit.org-config/config.json:
  18820. 2012-06-06 Dirk Pranke <dpranke@chromium.org>
  18821. get rebaselining tools to kinda work with the skia overrides file
  18822. https://bugs.webkit.org/show_bug.cgi?id=88456
  18823. Reviewed by Ryosuke Niwa.
  18824. Update rebaseline-expectations so that we read in the overrides
  18825. when looking for tests to rebaseline, but don't read in the
  18826. overrides when we are writing the expectations file back out.
  18827. This prevents the overrides from getting written into the main
  18828. file. This is kind of a hack but will have to do until we
  18829. support multiple expectations files properly.
  18830. * Scripts/webkitpy/tool/commands/rebaseline.py:
  18831. (RebaselineExpectations._expectations):
  18832. (RebaselineExpectations._update_expectations_file):
  18833. (RebaselineExpectations._tests_to_rebaseline):
  18834. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  18835. (test_overrides_are_included_correctly):
  18836. 2012-06-06 Dirk Pranke <dpranke@chromium.org>
  18837. webkitpy: two manager_worker_broker_unittest tests are broken
  18838. https://bugs.webkit.org/show_bug.cgi?id=88445
  18839. Reviewed by Ojan Vafai.
  18840. These tests were never updated when we removed the
  18841. --worker-model argument, and we were passing 'inline' instead of
  18842. 1 (for the number of workers) :(. As a result we were creating
  18843. multiprocessing queues unnecessarily and that was failing on cygwin.
  18844. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  18845. (InterfaceTest.test_managerconnection_is_abstract):
  18846. (InterfaceTest.test_workerconnection_is_abstract):
  18847. 2012-06-06 Ryosuke Niwa <rniwa@webkit.org>
  18848. REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
  18849. https://bugs.webkit.org/show_bug.cgi?id=87406
  18850. Reviewed by Dirk Pranke.
  18851. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  18852. (TestExpectations.__init__):
  18853. * Scripts/webkitpy/tool/commands/rebaseline.py:
  18854. (RebaselineTest._update_expectations_file):
  18855. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  18856. (test_rebaseline_does_not_include_overrides):
  18857. 2012-06-06 Dirk Pranke <dpranke@chromium.org>
  18858. webkitpy: perf tests unit tests fail on chromium win
  18859. https://bugs.webkit.org/show_bug.cgi?id=88279
  18860. Reviewed by Ryosuke Niwa.
  18861. I'm seeing weird failures running the unit tests in my win32
  18862. checkout, and we don't really expect webpagereplay to work on
  18863. win32 anyway, so I'm skipping the import of that module for now
  18864. and adding a warning.
  18865. * Scripts/run-perf-tests:
  18866. * Scripts/webkitpy/performance_tests/perftest.py:
  18867. 2012-06-06 Yong Li <yoli@rim.com>
  18868. Unreviewed. Update my email address in committers.py.
  18869. * Scripts/webkitpy/common/config/committers.py:
  18870. 2012-06-06 Robert Kroeger <rjkroege@chromium.org>
  18871. Add Robert Kroeger to commiters.py
  18872. https://bugs.webkit.org/show_bug.cgi?id=88415
  18873. Unreviewed.
  18874. * Scripts/webkitpy/common/config/committers.py:
  18875. 2012-06-06 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  18876. [EFL][DRT] http/tests/globalhistory testcases do not pass
  18877. https://bugs.webkit.org/show_bug.cgi?id=82579
  18878. Reviewed by Csaba Osztrogonác.
  18879. DRT has provided callbacks for ewk_view "global history delegate" signals.
  18880. * DumpRenderTree/efl/DumpRenderTree.cpp:
  18881. (isGlobalHistoryTest): Aux function to ident global history testcase.
  18882. (createLayoutTestController):
  18883. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  18884. (DumpRenderTreeChrome::createView):
  18885. (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
  18886. (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
  18887. (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
  18888. (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
  18889. (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
  18890. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  18891. (DumpRenderTreeChrome):
  18892. 2012-06-06 János Badics <jbadics@inf.u-szeged.hu>
  18893. [Qt] run-qtwebkit-tests hangs with -j1
  18894. run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
  18895. This could happen due to an uncancelled timer after results were returned. This timer was
  18896. started only if --timeout was set.
  18897. https://bugs.webkit.org/show_bug.cgi?id=85475
  18898. Reviewed by Csaba Osztrogonác.
  18899. * Scripts/run-qtwebkit-tests:
  18900. (run_test):
  18901. 2012-06-06 Michael Brüning <michael.bruning@nokia.com>
  18902. [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
  18903. https://bugs.webkit.org/show_bug.cgi?id=88327
  18904. Reviewed by Kenneth Rohde Christiansen.
  18905. * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
  18906. * MiniBrowser/qt/icons/contents_width.png: Added.
  18907. * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
  18908. * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
  18909. 2012-06-05 Jon Lee <jonlee@apple.com>
  18910. Buildbot fix.
  18911. * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
  18912. in the function. Store in a local variable.
  18913. (loadBuilderConfig):
  18914. 2012-06-05 Jon Lee <jonlee@apple.com>
  18915. Buildbot fix.
  18916. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  18917. (loadBuilderConfig):
  18918. 2012-06-04 Dirk Pranke <dpranke@chromium.org>
  18919. webkitpy: clean up win-specific path handling and tests
  18920. https://bugs.webkit.org/show_bug.cgi?id=88281
  18921. Reviewed by Adam Barth.
  18922. There was a bunch of inconsistent logic for handling path
  18923. conversions for win32 and cygwin paths due to us sometimes
  18924. looking at sys.platform and sometimes using mock hosts. This
  18925. patch cleans everything up so that we are required to pass
  18926. PlatformInfo objects to the path module and stop trying to do
  18927. different things when running on cygwin or win32 hosts (except
  18928. in the path_unittest module itself).
  18929. This may slightly reduce test coverage for the win32 code paths
  18930. but will be a lot easier to follow and maintain.
  18931. * Scripts/webkitpy/common/system/path.py:
  18932. (abspath_to_uri):
  18933. (_convert_path):
  18934. * Scripts/webkitpy/common/system/path_unittest.py:
  18935. (AbspathTest.platforminfo):
  18936. (AbspathTest.test_abspath_to_uri_cygwin):
  18937. (AbspathTest.test_abspath_to_uri_unixy):
  18938. (AbspathTest.test_abspath_to_uri_win):
  18939. (AbspathTest.test_abspath_to_uri_escaping_unixy):
  18940. (AbspathTest.test_abspath_to_uri_escaping_cygwin):
  18941. (AbspathTest.test_stop_cygpath_subprocess):
  18942. * Scripts/webkitpy/common/system/platforminfo.py:
  18943. (PlatformInfo.__init__):
  18944. (PlatformInfo.is_cygwin):
  18945. * Scripts/webkitpy/common/system/platforminfo_mock.py:
  18946. (MockPlatformInfo.is_cygwin):
  18947. * Scripts/webkitpy/layout_tests/port/base.py:
  18948. (Port.to.show_results_html_file):
  18949. * Scripts/webkitpy/layout_tests/port/driver.py:
  18950. (Driver.test_to_uri):
  18951. (Driver.uri_to_test):
  18952. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  18953. (DriverTest.test_test_to_uri):
  18954. (DriverTest.test_uri_to_test):
  18955. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  18956. (MockDRTPortTest.make_port):
  18957. (MockDRTTest.input_line):
  18958. (MockChromiumDRTTest.test_pixeltest__fails):
  18959. * Scripts/webkitpy/layout_tests/port/test.py:
  18960. * Scripts/webkitpy/layout_tests/port/win.py:
  18961. (WinPort.show_results_html_file):
  18962. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  18963. (MainTest.test_unexpected_failures):
  18964. (MainTest.test_results_directory_absolute):
  18965. (MainTest.test_results_directory_default):
  18966. (MainTest.test_results_directory_relative):
  18967. 2012-06-05 Jon Lee <jonlee@apple.com>
  18968. Workaround buildbot bug when merging build requests.
  18969. https://bugs.webkit.org/show_bug.cgi?id=88158
  18970. Reviewed by Mark Rowe.
  18971. For expediency, we still want testers to pick the latest build to test, but to ensure
  18972. that the builders are reporting the correct revision number, we should let the building bots
  18973. run as they normally would. That is, the builder picks the oldest revision, and merges
  18974. subsequent requests. Because merged requests get appended to the list of changes for a given
  18975. build, the last change in that list is also the latest change. When we used pickLatestBuild
  18976. for the builders, this was not the case (it would always report the penultimate change).
  18977. http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
  18978. * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
  18979. for all Apple builders.
  18980. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
  18981. the latest build to run.
  18982. (loadBuilderConfig):
  18983. 2012-06-05 Jessie Berlin <jberlin@apple.com>
  18984. [Win] DumpRenderTree should call resetInternalsObject
  18985. https://bugs.webkit.org/show_bug.cgi?id=88346
  18986. Reviewed by Simon Fraser.
  18987. Invoke it on Windows in the same place it is invoked on Mac.
  18988. * DumpRenderTree/win/DumpRenderTree.cpp:
  18989. (resetWebViewToConsistentStateBeforeTesting):
  18990. 2012-06-05 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  18991. [GTK] Fix two more memory leaks in DRT
  18992. https://bugs.webkit.org/show_bug.cgi?id=88255
  18993. Reviewed by Martin Robinson.
  18994. Fixed memory leaks in GTK's DRT code.
  18995. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  18996. (dumpHistoryItem): webkit_web_history_item_get_target() returns a
  18997. g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
  18998. * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
  18999. (createBitmapContextFromWebView): Free the cairo surface.
  19000. 2012-06-05 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  19001. [Qt] Building when a top directory is named Source
  19002. https://bugs.webkit.org/show_bug.cgi?id=77727
  19003. Reviewed by Tor Arne Vestbø.
  19004. Change regex to only replace the last instance of OUT_PWD.
  19005. * qmake/mkspecs/features/default_pre.prf:
  19006. 2012-06-05 Dongwoo Im <dw.im@samsung.com>
  19007. Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
  19008. https://bugs.webkit.org/show_bug.cgi?id=73176
  19009. Reviewed by Adam Barth.
  19010. Two more APIs are added in Custom Scheme Handler specification.
  19011. http://dev.w3.org/html5/spec/Overview.html#custom-handlers
  19012. One is 'isProtocolHandlerRegistered' to query whether the specific URL
  19013. is registered or not.
  19014. The other is 'unregisterProtocolHandler' to remove the registered URL.
  19015. * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  19016. 2012-06-05 Mario Sanchez Prada <msanchez@igalia.com>
  19017. [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
  19018. https://bugs.webkit.org/show_bug.cgi?id=83879
  19019. Reviewed by Carlos Garcia Campos.
  19020. Make minibrowser connect to the new 'permission requests' signal
  19021. to allow users handle the Geolocation permission requests.
  19022. * MiniBrowser/gtk/BrowserWindow.c:
  19023. (geolocationRequestDialogCallback): Callback for the dialog asking
  19024. the user for allowing or not geolocation permission requests.
  19025. (webViewDecidePermissionRequest): Launch a dialog to ask the user
  19026. whether to allow or deny geolocation permission requests.
  19027. (browserWindowConstructed): Connect to 'permission-request' signal.
  19028. 2012-06-04 Chase Phillips <cmp@google.com>
  19029. Make a builder group support+expect multiple loads.
  19030. https://bugs.webkit.org/show_bug.cgi?id=88260
  19031. Change BuilderGroup to allow expecting multiple
  19032. loads. This allows merging results for a given set
  19033. of builders into one group.
  19034. Add a test that verifies that the group count
  19035. increments correctly based on successful and failed
  19036. list loads.
  19037. Reviewed by Ojan Vafai.
  19038. * TestResultServer/static-dashboards/builders.js:
  19039. (BuilderGroup):
  19040. (BuilderGroup.prototype.setbuilder):
  19041. (BuilderGroup.prototype.append):
  19042. (BuilderGroup.prototype.loaded):
  19043. (requestBuilderList.xhr.onload):
  19044. (requestBuilderList.xhr.onerror):
  19045. (onErrorLoadingBuilderList):
  19046. (loadBuildersList):
  19047. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  19048. (test):
  19049. * TestResultServer/static-dashboards/run-unittests.html:
  19050. 2012-06-04 Ryosuke Niwa <rniwa@webkit.org>
  19051. Python test fix attempt for Chromium Windows.
  19052. * Scripts/webkitpy/layout_tests/port/driver.py:
  19053. (Driver.uri_to_test):
  19054. 2012-06-04 Hugo Parente Lima <hugo.lima@openbossa.org>
  19055. Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
  19056. https://bugs.webkit.org/show_bug.cgi?id=88243
  19057. Reviewed by Adam Barth.
  19058. * qmake/mkspecs/features/features.prf:
  19059. 2012-06-04 Dirk Pranke <dpranke@chromium.org>
  19060. webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
  19061. https://bugs.webkit.org/show_bug.cgi?id=88280
  19062. Unreviewed, build fix.
  19063. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  19064. (TestServerProcess.test_basic):
  19065. 2012-06-04 Dirk Pranke <dpranke@chromium.org>
  19066. test-webkitpy is hanging under cygwin
  19067. https://bugs.webkit.org/show_bug.cgi?id=88269
  19068. Reviewed by Ryosuke Niwa.
  19069. The 'multiprocessing' module doesn't work correctly under Cygwin yet,
  19070. so we need to skip any tests that use it.
  19071. * Scripts/webkitpy/common/system/executive.py:
  19072. (Executive.run_in_parallel):
  19073. * Scripts/webkitpy/common/system/executive_unittest.py:
  19074. (ExecutiveTest.test_run_in_parallel):
  19075. 2012-06-04 Dirk Pranke <dpranke@chromium.org>
  19076. test-webkitpy is failing on win32 after r115054
  19077. https://bugs.webkit.org/show_bug.cgi?id=88264
  19078. Reviewed by Ryosuke Niwa.
  19079. The failing http_server test was improperly suppressed (the
  19080. tuple was missing a comma, and so wasn't a tuple at all, just a
  19081. string) and so we were skipping *all* tests on win32. The right
  19082. way to skip a single test is to disable it inside the test
  19083. itself.
  19084. * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
  19085. (TestHttpServer.test_start_cmd):
  19086. * Scripts/webkitpy/test/test_finder.py:
  19087. (TestFinder._default_names):
  19088. * Scripts/webkitpy/test/main.py:
  19089. (Tester.run): Add error message if we don't find any tests to run.
  19090. * Scripts/webkitpy/test/main_unittest.py:
  19091. 2012-06-04 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  19092. [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
  19093. https://bugs.webkit.org/show_bug.cgi?id=88215
  19094. Reviewed by Martin Robinson.
  19095. Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
  19096. for newly allocated strings.
  19097. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  19098. (attributeSetToString):
  19099. (AccessibilityUIElement::allAttributes):
  19100. 2012-06-04 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  19101. [GTK] Memory leaks in DumpRenderTree.cpp
  19102. https://bugs.webkit.org/show_bug.cgi?id=88213
  19103. Reviewed by Martin Robinson.
  19104. Fixed memory leaks in DumpRenderTree.
  19105. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  19106. (appendString): Accepts const gchar* as the second argument.
  19107. (dumpFramesAsText): Free the string returned by g_strdup_printf().
  19108. (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
  19109. 2012-06-04 David Dorwin <ddorwin@chromium.org>
  19110. Enable Chromium media player to instantiate a plugin
  19111. https://bugs.webkit.org/show_bug.cgi?id=87399
  19112. Reviewed by Kent Tamura.
  19113. Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
  19114. * DumpRenderTree/chromium/WebViewHost.cpp:
  19115. (WebViewHost::createPopupMenu):
  19116. 2012-06-04 Mario Sanchez Prada <msanchez@igalia.com>
  19117. [GTK][WK2] Implement geolocation provider for the GTK port
  19118. https://bugs.webkit.org/show_bug.cgi?id=83877
  19119. Reviewed by Carlos Garcia Campos.
  19120. * gtk/generate-gtkdoc:
  19121. (get_webkit2_options): Ignore WebKitGeolocationProvider files.
  19122. 2012-06-04 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  19123. [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
  19124. https://bugs.webkit.org/show_bug.cgi?id=87668
  19125. Reviewed by Ryosuke Niwa.
  19126. Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
  19127. otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might
  19128. be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true).
  19129. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  19130. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  19131. 2012-06-04 Tomasz Morawski <t.morawski@samsung.com>
  19132. [EFL] Refactor ewk_view_context_paint code.
  19133. https://bugs.webkit.org/show_bug.cgi?id=85588
  19134. Reviewed by Hajime Morita.
  19135. * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
  19136. 2012-06-04 Christophe Dumez <christophe.dumez@intel.com>
  19137. [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
  19138. https://bugs.webkit.org/show_bug.cgi?id=87869
  19139. Reviewed by Andreas Kling.
  19140. Replace %lld by PRId64 macro to print an int64_t value and silent a
  19141. compilation warning on 64-Bit.
  19142. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  19143. (onExceededApplicationCacheQuota):
  19144. 2012-06-03 Varun Jain <varunjain@google.com>
  19145. [chromium] Add new gesture type (two finger tap) that triggers context menu.
  19146. https://bugs.webkit.org/show_bug.cgi?id=88173
  19147. Reviewed by Adam Barth.
  19148. * DumpRenderTree/chromium/EventSender.cpp:
  19149. (EventSender::EventSender):
  19150. (EventSender::gestureTwoFingerTap):
  19151. (EventSender::gestureEvent):
  19152. * DumpRenderTree/chromium/EventSender.h:
  19153. (EventSender):
  19154. 2012-06-02 Zeno Albisser <zeno@webkit.org>
  19155. Fix and enable WebGL for WebKit2 on Qt.
  19156. https://bugs.webkit.org/show_bug.cgi?id=86214
  19157. Enable WebGL by default for Qt MiniBrowser.
  19158. Reviewed by Noam Rosenthal.
  19159. * MiniBrowser/qt/qml/BrowserWindow.qml:
  19160. 2012-06-02 Ryosuke Niwa <rniwa@webkit.org>
  19161. Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
  19162. https://bugs.webkit.org/show_bug.cgi?id=88164
  19163. Reviewed by Kentaro Hara.
  19164. Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
  19165. Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
  19166. * Scripts/VCSUtils.pm:
  19167. (adjustPathForRecentRenamings):
  19168. (fixChangeLogPatch):
  19169. 2012-06-01 Ryosuke Niwa <rniwa@webkit.org>
  19170. Rename test_expectations.txt to TestExpectations
  19171. https://bugs.webkit.org/show_bug.cgi?id=86690
  19172. Reviewed by Dirk Pranke.
  19173. Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
  19174. We can the code to read test_expectations.txt once we've successfully transitioned.
  19175. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  19176. (TestExpectationParser._check_path_does_not_exist):
  19177. (TestExpectationParser._tokenize):
  19178. (TestExpectations): Removed TEST_LIST, which is not used anywhere.
  19179. * Scripts/webkitpy/layout_tests/port/base.py:
  19180. (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
  19181. test_expectations.txt if one exists and the path to TestExpectations otherwise.
  19182. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  19183. (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
  19184. virtual.
  19185. * Scripts/webkitpy/layout_tests/port/chromium.py:
  19186. (ChromiumPort.path_from_chromium_base):
  19187. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  19188. (ChromiumAndroidPort.test_expectations):
  19189. * Scripts/webkitpy/layout_tests/port/test.py:
  19190. (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
  19191. (TestPort.__init__):
  19192. * Scripts/webkitpy/layout_tests/port/webkit.py:
  19193. (WebKitPort.baseline_search_path):
  19194. (WebKitPort.test_expectations):
  19195. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
  19196. tests to base as a follow up.
  19197. (WebKitPortTest.test_path_to_test_expectations_file):
  19198. (test_test_expectations):
  19199. (test_legacy_test_expectations):
  19200. * Scripts/webkitpy/style/checker.py:
  19201. (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
  19202. with one for TestExpectations.
  19203. * Scripts/webkitpy/style/checkers/test_expectations.py:
  19204. (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
  19205. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  19206. (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
  19207. test_expectations.txt.
  19208. (TestExpectationsTestCase.test_determine_port_from_expectations_path):
  19209. (TestExpectationsTestCase.assert_lines_lint):
  19210. * Scripts/webkitpy/tool/commands/queries.py:
  19211. (PrintExpectations.__init__):
  19212. * Scripts/webkitpy/tool/commands/rebaseline.py:
  19213. (RebaselineExpectations):
  19214. * Scripts/webkitpy/tool/steps/commit.py:
  19215. (Commit._check_test_expectations):
  19216. * Scripts/webkitpy/tool/steps/commit_unittest.py:
  19217. (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
  19218. (CommitTest.test_check_test_expectations): For TestExpectations.
  19219. (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
  19220. * TestResultServer/static-dashboards/dashboard_base.js:
  19221. (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
  19222. Error only when neither exists.
  19223. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  19224. (processMissingAndExtraExpectations):
  19225. (htmlForTestsWithExpectationsButNoFailures):
  19226. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  19227. 2012-06-01 Xianzhu Wang <wangxianzhu@chromium.org>
  19228. Remove dependency from ImageDiff to WTF
  19229. https://bugs.webkit.org/show_bug.cgi?id=88147
  19230. Reviewed by Adam Barth.
  19231. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  19232. 2012-06-01 Dirk Pranke <dpranke@chromium.org>
  19233. NRWT seems to leak (more?) temp dirs
  19234. https://bugs.webkit.org/show_bug.cgi?id=88126
  19235. Re-land r119297 with chromium fix (weren't calling the
  19236. super() method if not in --test-shell mode in start().
  19237. Add unit tests to chromium_unittest as well to check.
  19238. * Scripts/webkitpy/layout_tests/port/chromium.py:
  19239. (ChromiumDriver.start):
  19240. * Scripts/webkitpy/layout_tests/port/webkit.py:
  19241. (WebKitDriver.__del__):
  19242. (WebKitDriver._start):
  19243. (WebKitDriver.run_test):
  19244. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  19245. (WebKitDriverTest.test_check_for_driver_crash):
  19246. (WebKitDriverTest.test_stop_cleans_up_properly):
  19247. (WebKitDriverTest):
  19248. (WebKitDriverTest.test_two_starts_cleans_up_properly):
  19249. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  19250. (ChromiumDriverTest.test_stop_cleans_up_properly):
  19251. (ChromiumDriverTest.test_two_starts_cleans_up_properly):
  19252. 2012-06-01 Tim Horton <timothy_horton@apple.com>
  19253. Lots of "failed download-built-product" on Apple bots
  19254. https://bugs.webkit.org/show_bug.cgi?id=88158
  19255. Reviewed by Jessie Berlin.
  19256. Disable mergeRequests on all Apple builders. This is a speculative fix.
  19257. * BuildSlaveSupport/build.webkit.org-config/config.json:
  19258. 2012-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
  19259. Unreviewed, rolling out r119297.
  19260. http://trac.webkit.org/changeset/119297
  19261. https://bugs.webkit.org/show_bug.cgi?id=88156
  19262. May have broken Chromium bots (Requested by rniwa on #webkit).
  19263. * Scripts/webkitpy/layout_tests/port/webkit.py:
  19264. (WebKitDriver.__del__):
  19265. (WebKitDriver.run_test):
  19266. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  19267. (WebKitDriverTest.test_check_for_driver_crash):
  19268. (WebKitDriverTest.test_stop_cleans_up_properly):
  19269. 2012-06-01 Dirk Pranke <dpranke@chromium.org>
  19270. nrwt seems to leak tmpdirs
  19271. https://bugs.webkit.org/show_bug.cgi?id=88126
  19272. Reviewed by Ojan Vafai.
  19273. Fix leak possibly introduced in r118979 - we now will
  19274. make sure we clean up any stale temp directories during the
  19275. start routine and attempt to clean up again in __del__. It
  19276. turns out that asserting in __del__ logs a message but is
  19277. caught by the runtime, so it's mostly useless.
  19278. * Scripts/webkitpy/layout_tests/port/webkit.py:
  19279. (WebKitDriver.__del__):
  19280. (WebKitDriver._start):
  19281. (WebKitDriver.run_test):
  19282. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  19283. (WebKitDriverTest.test_check_for_driver_crash):
  19284. (WebKitDriverTest.test_stop_cleans_up_properly):
  19285. (WebKitDriverTest):
  19286. (WebKitDriverTest.test_two_starts_cleans_up_properly):
  19287. 2012-06-01 Michael Saboff <msaboff@apple.com>
  19288. WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
  19289. https://bugs.webkit.org/show_bug.cgi?id=88109
  19290. Reviewed by Geoffrey Garen.
  19291. Additional test case.
  19292. * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
  19293. (TestWebKitAPI::TEST):
  19294. 2012-06-01 Simon Hausmann <simon.hausmann@nokia.com>
  19295. [Qt] Use -Werror only in developer builds
  19296. Rubber-stamped by Tor Arne Vestbø.
  19297. In production builds -Werror with custom toolchains and wierd system
  19298. headers, -Werror is of no use and just creates confusion. So use it
  19299. only if Qt is configured with -developer-build.
  19300. * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
  19301. * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
  19302. only if qt_developer_build is set.
  19303. 2012-06-01 Jochen Eisinger <jochen@chromium.org>
  19304. [watchlist] Add myself to loader and v8 bindings changes
  19305. https://bugs.webkit.org/show_bug.cgi?id=88112
  19306. Reviewed by Adam Barth.
  19307. * Scripts/webkitpy/common/config/watchlist:
  19308. 2012-06-01 Jacky Jiang <zhajiang@rim.com>
  19309. Adding Jacky Jiang to committers.py
  19310. https://bugs.webkit.org/show_bug.cgi?id=88122
  19311. Reviewed by Rob Buis.
  19312. Adding myself to committers.py as a Committer.
  19313. * Scripts/webkitpy/common/config/committers.py:
  19314. 2012-06-01 Jessie Berlin <jberlin@apple.com>
  19315. Fix Windows build.
  19316. * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
  19317. 2012-06-01 Jessie Berlin <jberlin@apple.com>
  19318. Windows WK2 MouseMoveAfterCrash API test failing
  19319. https://bugs.webkit.org/show_bug.cgi?id=69982
  19320. Disable the test on Windows to get the bots greener.
  19321. * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
  19322. (TestWebKitAPI::TEST):
  19323. 2012-06-01 Christophe Dumez <christophe.dumez@intel.com>
  19324. [EFL] EFL port does not enable WEB_INTENTS_TAG flag
  19325. https://bugs.webkit.org/show_bug.cgi?id=86866
  19326. Reviewed by Adam Barth.
  19327. Catch new "intent,service,register" signal on the frame and print out
  19328. information about the Web Intent service in EFL's DumpRenderTree.
  19329. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  19330. (DumpRenderTreeChrome::createView):
  19331. (DumpRenderTreeChrome::onFrameCreated):
  19332. (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
  19333. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  19334. (DumpRenderTreeChrome):
  19335. 2012-06-01 Martin Robinson <mrobinson@igalia.com>
  19336. The ChangeLog parser cannot handle reviewers with initials in their name
  19337. https://bugs.webkit.org/show_bug.cgi?id=87864
  19338. Reviewed by Ryosuke Niwa.
  19339. Add support in the ChangeLog parser for reviewer names that have
  19340. initials in them.
  19341. * Scripts/webkitpy/common/checkout/changelog.py:
  19342. (ChangeLogEntry): Add a new group of regular expressions that need a backreference
  19343. in the replacement string. This allows for matching the word characters before a
  19344. period, without totally throwing them away.
  19345. (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
  19346. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  19347. (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
  19348. 2012-06-01 Christophe Dumez <christophe.dumez@intel.com>
  19349. [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
  19350. https://bugs.webkit.org/show_bug.cgi?id=86865
  19351. Reviewed by Adam Barth.
  19352. Add deliverWebIntent method to LayoutTestController and provide
  19353. implementation for EFL port.
  19354. * DumpRenderTree/LayoutTestController.cpp:
  19355. (deliverWebIntentCallback):
  19356. (LayoutTestController::staticFunctions):
  19357. * DumpRenderTree/LayoutTestController.h:
  19358. (LayoutTestController):
  19359. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  19360. (LayoutTestController::deliverWebIntent):
  19361. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  19362. (LayoutTestController::deliverWebIntent):
  19363. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  19364. (LayoutTestController::deliverWebIntent):
  19365. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  19366. (LayoutTestController::deliverWebIntent):
  19367. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  19368. (LayoutTestController::deliverWebIntent):
  19369. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  19370. (LayoutTestController::deliverWebIntent):
  19371. 2012-06-01 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19372. [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
  19373. Reviewed by Simon Hausmann.
  19374. * Tools.pro:
  19375. 2012-06-01 Ryosuke Niwa <rniwa@webkit.org>
  19376. Add public page loading performance tests using web-page-replay
  19377. https://bugs.webkit.org/show_bug.cgi?id=84008
  19378. Reviewed by Dirk Pranke.
  19379. Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
  19380. to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
  19381. To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
  19382. Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
  19383. to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
  19384. excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
  19385. run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
  19386. * Scripts/webkitpy/layout_tests/port/driver.py:
  19387. (Driver.is_external_http_test): Added.
  19388. * Scripts/webkitpy/layout_tests/port/webkit.py:
  19389. (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
  19390. * Scripts/webkitpy/performance_tests/perftest.py:
  19391. (PerfTest.__init__): Takes port.
  19392. (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
  19393. (PerfTest):
  19394. (PerfTest.run): Calls run_single.
  19395. (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
  19396. (ChromiumStylePerfTest.__init__):
  19397. (PageLoadingPerfTest.__init__):
  19398. (PageLoadingPerfTest.run):
  19399. (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
  19400. (ReplayServer.__init__):
  19401. (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
  19402. but it caused a dead lock on some web pages.
  19403. (ReplayServer.stop):
  19404. (ReplayServer.__del__):
  19405. (ReplayPerfTest):
  19406. (ReplayPerfTest.__init__):
  19407. (ReplayPerfTest._start_replay_server):
  19408. (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
  19409. The subsequent runs of the same test will just use test.wpr.
  19410. (ReplayPerfTest.run_single):
  19411. (PerfTestFactory):
  19412. (PerfTestFactory.create_perf_test):
  19413. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  19414. (MainTest.test_parse_output):
  19415. (MainTest.test_parse_output_with_failing_line):
  19416. (TestPageLoadingPerfTest.test_run):
  19417. (TestPageLoadingPerfTest.test_run_with_bad_output):
  19418. (TestReplayPerfTest):
  19419. (TestReplayPerfTest.ReplayTestPort):
  19420. (TestReplayPerfTest.ReplayTestPort.__init__):
  19421. (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
  19422. (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
  19423. (TestReplayPerfTest.ReplayTestPort._driver_class):
  19424. (TestReplayPerfTest.MockReplayServer):
  19425. (TestReplayPerfTest.MockReplayServer.__init__):
  19426. (TestReplayPerfTest.MockReplayServer.stop):
  19427. (TestReplayPerfTest._add_file):
  19428. (TestReplayPerfTest._setup_test):
  19429. (TestReplayPerfTest.test_run_single):
  19430. (TestReplayPerfTest.test_run_single.run_test):
  19431. (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
  19432. (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
  19433. (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
  19434. (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
  19435. (TestReplayPerfTest.test_prepare):
  19436. (TestReplayPerfTest.test_prepare.run_test):
  19437. (TestReplayPerfTest.test_prepare_calls_run_single):
  19438. (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
  19439. (TestPerfTestFactory.test_regular_test):
  19440. (TestPerfTestFactory.test_inspector_test):
  19441. (TestPerfTestFactory.test_page_loading_test):
  19442. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  19443. (PerfTestsRunner):
  19444. (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
  19445. (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
  19446. (PerfTestsRunner._collect_tests._is_test_file):
  19447. (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
  19448. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  19449. (create_runner):
  19450. (run_test):
  19451. (_tests_for_runner):
  19452. (test_run_test_set):
  19453. (test_run_test_set_kills_drt_per_run):
  19454. (test_run_test_pause_before_testing):
  19455. (test_run_test_set_for_parser_tests):
  19456. (test_run_test_set_with_json_output):
  19457. (test_run_test_set_with_json_source):
  19458. (test_run_test_set_with_multiple_repositories):
  19459. (test_run_with_upload_json):
  19460. (test_upload_json):
  19461. (test_upload_json.MockFileUploader.upload_single_text_file):
  19462. (_add_file):
  19463. (test_collect_tests):
  19464. (test_collect_tests_with_multile_files):
  19465. (test_collect_tests_with_multile_files.add_file):
  19466. (test_collect_tests_with_skipped_list):
  19467. (test_collect_tests_with_page_load_svg):
  19468. (test_collect_tests_should_ignore_replay_tests_by_default):
  19469. (test_collect_tests_with_replay_tests):
  19470. (test_parse_args):
  19471. * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
  19472. (AutoinstallImportHook.find_module):
  19473. (AutoinstallImportHook._install_webpagereplay):
  19474. 2012-05-31 Yaron Friedman <yfriedman@chromium.org>
  19475. Support building the Android port of chromium with Ninja
  19476. https://bugs.webkit.org/show_bug.cgi?id=87545
  19477. Reviewed by Adam Barth.
  19478. Ensures that shared libraries are looked up in a generator-agnostic
  19479. way and that output is placed in the correct directory.
  19480. Depends on http://codereview.chromium.org/10386188/
  19481. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  19482. 2012-05-31 Ryosuke Niwa <rniwa@webkit.org>
  19483. [Chromium] Chromium DRT should be able to load external resources
  19484. https://bugs.webkit.org/show_bug.cgi?id=87893
  19485. Reviewed by Dirk Pranke.
  19486. Allow external resources to be loaded when the main frame's URL is also an external resource.
  19487. This change is analogous to r118231 for Mac port.
  19488. * DumpRenderTree/chromium/WebViewHost.cpp:
  19489. (blockRequest):
  19490. (isLocalhost):
  19491. (hostIsUsedBySomeTestsToGenerateError):
  19492. (WebViewHost::willSendRequest):
  19493. 2012-05-31 Anders Carlsson <andersca@apple.com>
  19494. Build fixes.
  19495. Disable the C++11 extensions warning.
  19496. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  19497. * TestWebKitAPI/Configurations/Base.xcconfig:
  19498. * WebKitTestRunner/Configurations/Base.xcconfig:
  19499. 2012-05-31 Alexey Proskuryakov <ap@apple.com>
  19500. [WK2] window.internals settings are not reset between tests
  19501. https://bugs.webkit.org/show_bug.cgi?id=87783
  19502. Reviewed by Mihai Parparita.
  19503. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  19504. (WTR::InjectedBundle::done): Call resetAfterTest().
  19505. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  19506. (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
  19507. (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
  19508. This needs to be done after a tets, because the code assumes that there is an object
  19509. with this name in global scope.
  19510. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  19511. 2012-05-31 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  19512. [EFL][DRT] EFL's DRT navigation_policy_decision implementation
  19513. https://bugs.webkit.org/show_bug.cgi?id=85006
  19514. Reviewed by Tor Arne Vestbø.
  19515. Added navigation_policy_decision implementation for DumpRenderTreeView.
  19516. Added LayoutTestController::setCustomPolicyDelegate implementation.
  19517. Modified LayoutTestController::waitForPolicyDelegate.
  19518. * DumpRenderTree/efl/DumpRenderTree.cpp:
  19519. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  19520. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  19521. * DumpRenderTree/efl/DumpRenderTreeEfl.h:
  19522. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  19523. (navigationTypeToString): aux function
  19524. (onNavigationPolicyDecision): navigation_policy_decision implementation
  19525. (drtViewAdd):
  19526. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  19527. (LayoutTestController::setCustomPolicyDelegate):
  19528. (LayoutTestController::waitForPolicyDelegate):
  19529. 2012-05-31 Jussi Kukkonen <jussi.kukkonen@intel.com>
  19530. [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
  19531. https://bugs.webkit.org/show_bug.cgi?id=86195
  19532. Reviewed by Gustavo Noronha Silva.
  19533. Implement clearApplicationCacheForOrigin in EFL
  19534. LayoutTestController.
  19535. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  19536. (LayoutTestController::clearApplicationCacheForOrigin):
  19537. 2012-05-31 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19538. [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
  19539. https://bugs.webkit.org/show_bug.cgi?id=87955
  19540. Reviewed by Simon Hausmann.
  19541. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  19542. * DumpRenderTree/qt/EventSenderQt.cpp:
  19543. * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
  19544. * DumpRenderTree/qt/main.cpp:
  19545. * QtTestBrowser/cookiejar.cpp:
  19546. * QtTestBrowser/launcherwindow.cpp:
  19547. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  19548. * qmake/mkspecs/features/default_post.prf:
  19549. 2012-05-31 Zoltan Horvath <zoltan@webkit.org>
  19550. [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
  19551. Rubber-stamped by Kenneth Rohde Christiansen.
  19552. * qmake/config.tests/libpng/libpng.pro:
  19553. 2012-05-30 Peter Beverloo <peter@chromium.org>
  19554. [Chromium] Automatically install 64-bit linker for Android
  19555. https://bugs.webkit.org/show_bug.cgi?id=79780
  19556. Reviewed by Adam Barth.
  19557. Change the update-webkit-chromium script to check whether the 64-bit
  19558. linker needs to be installed as part of the update process. The actual
  19559. code for doing these checks and "installing" it has been added to the
  19560. webkitdirs.pm script.
  19561. The linker itself is part of the third_party/aosp repository, which
  19562. will be pulled in through the DEPS change.
  19563. * Scripts/update-webkit-chromium:
  19564. * Scripts/webkitdirs.pm:
  19565. (chromiumInstall64BitAndroidLinkerIfNeeded):
  19566. (chromiumReplaceAndroidLinkerIfNeeded):
  19567. 2012-05-30 Stephanie Lewis <slewis@apple.com>
  19568. https://bugs.webkit.org/show_bug.cgi?id=87803
  19569. Layout tests often fail trying to stat nonexistent logs
  19570. Reviewed by Dirk Pranke.
  19571. CrashReporter removes logs using a heuristic to conserve space. Wrap a
  19572. try/catch block around accessing the logs as a precaution.
  19573. * Scripts/webkitpy/common/system/crashlogs.py:
  19574. (CrashLogs._find_newest_log_darwin):
  19575. 2012-05-30 Gavin Peters <gavinp@chromium.org>
  19576. Add a LayoutTest for prerender remove after stop.
  19577. https://bugs.webkit.org/show_bug.cgi?id=87860
  19578. These very boring mocks in DumpRenderTree mean that the basic Prerendering API
  19579. can be tested by LayoutTests now.
  19580. Reviewed by Adam Barth.
  19581. * DumpRenderTree/DumpRenderTree.gypi:
  19582. * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
  19583. (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
  19584. (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
  19585. (MockWebPrerenderingSupport::add):
  19586. (MockWebPrerenderingSupport::cancel):
  19587. (MockWebPrerenderingSupport::abandon):
  19588. * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
  19589. (MockWebPrerenderingSupport):
  19590. * DumpRenderTree/chromium/TestShell.cpp:
  19591. (TestShell::initialize):
  19592. * DumpRenderTree/chromium/TestShell.h:
  19593. (TestShell):
  19594. * DumpRenderTree/chromium/WebViewHost.cpp:
  19595. (WebViewHost::willAddPrerender):
  19596. (WebViewHost::setWebWidget):
  19597. * DumpRenderTree/chromium/WebViewHost.h:
  19598. (WebViewHost):
  19599. 2012-05-30 Stephanie Lewis <slewis@apple.com>
  19600. https://bugs.webkit.org/show_bug.cgi?id=87717
  19601. Unresponsive WebProcesses can be mistaken for WebProcess crashes.
  19602. Reviewed by Dirk Pranke.
  19603. Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
  19604. If there isn't a crash log found for the process add a message saying
  19605. the process was unresponsive.
  19606. * Scripts/webkitpy/layout_tests/port/webkit.py:
  19607. (WebKitDriver.__init__):
  19608. (WebKitDriver._check_for_driver_crash):
  19609. (WebKitDriver.run_test):
  19610. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  19611. (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
  19612. (WebKitDriverTest):
  19613. (WebKitDriverTest.test_check_for_driver_crash):
  19614. * WebKitTestRunner/TestController.cpp:
  19615. (WTR):
  19616. (WTR::TestController::runTest):
  19617. 2012-05-30 Stephanie Lewis <slewis@apple.com>
  19618. https://bugs.webkit.org/show_bug.cgi?id=87714
  19619. Mac crash logs can take a really long time to be written out.
  19620. Reviewed by Dirk Pranke.
  19621. Make a second pass looking for crash logs after the tests have completed running.
  19622. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  19623. (use_trac_links_in_results_html):
  19624. (Manager.run):
  19625. * Scripts/webkitpy/layout_tests/port/base.py:
  19626. (Port.repository_paths):
  19627. (Port.look_for_new_crash_logs):
  19628. * Scripts/webkitpy/layout_tests/port/mac.py:
  19629. (MacPort.look_for_new_crash_logs):
  19630. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  19631. (test_get_crash_log):
  19632. (test_look_for_new_crash_logs):
  19633. (test_look_for_new_crash_logs.fake_time_cb):
  19634. 2012-05-30 Kevin Ollivier <kevino@theolliviers.com>
  19635. [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
  19636. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  19637. (LayoutWebViewEventHandler::OnAlertEvent):
  19638. (LayoutWebViewEventHandler::OnConfirmEvent):
  19639. (LayoutWebViewEventHandler):
  19640. (LayoutWebViewEventHandler::OnPromptEvent):
  19641. (LayoutWebViewEventHandler::OnConsoleMessageEvent):
  19642. (LayoutWebViewEventHandler::OnReceivedTitleEvent):
  19643. 2012-05-30 Ojan Vafai <ojan@chromium.org>
  19644. Only give lint errors for -expected.png png files that lack a checksum
  19645. https://bugs.webkit.org/show_bug.cgi?id=87875
  19646. Reviewed by Tony Chang.
  19647. We have other pngs in the tree, e.g. for the inspector, that legitimately
  19648. lack a checksum.
  19649. * Scripts/webkitpy/style/checkers/png.py:
  19650. (PNGChecker.check):
  19651. * Scripts/webkitpy/style/checkers/png_unittest.py:
  19652. (PNGCheckerTest.test_check):
  19653. 2012-05-30 Dirk Pranke <dpranke@chromium.org>
  19654. nrwt: seems to leak temp dirs
  19655. https://bugs.webkit.org/show_bug.cgi?id=87795
  19656. Reviewed by Ojan Vafai.
  19657. There appears to be a bug where the chromium bots are creating
  19658. temporary directories and not cleaning them up that started
  19659. after the switch to WebKitDriver. It's possible that __del__
  19660. wasn't getting called in a timely manner (or at all), and it's
  19661. generally bad style to rely on __del__ being called, so this
  19662. code changes things so that we create a temp dir in
  19663. driver.start() and remove it in driver.stop(). We could be
  19664. paranoid and leave the __del__ code in, but there doesn't seem
  19665. to be much advantage to it. If there are bugs that result in
  19666. drivers being started but not stopped, we have other problems.
  19667. * Scripts/webkitpy/common/system/filesystem_mock.py:
  19668. (MockFileSystem.__init__):
  19669. (MockFileSystem._mktemp):
  19670. (MockFileSystem.mkdtemp):
  19671. * Scripts/webkitpy/layout_tests/port/webkit.py:
  19672. (WebKitDriver.__init__):
  19673. (WebKitDriver._start):
  19674. (WebKitDriver.stop):
  19675. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  19676. (WebKitDriverTest.test_check_for_driver_crash):
  19677. (WebKitDriverTest):
  19678. (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
  19679. (WebKitDriverTest.test_stop_cleans_up_properly):
  19680. 2012-05-30 Christophe Dumez <christophe.dumez@intel.com>
  19681. [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
  19682. https://bugs.webkit.org/show_bug.cgi?id=86841
  19683. Reviewed by Adam Barth.
  19684. Print the number of MessagePorts for each new intent in EFL's DRT.
  19685. This output is expected by several Web Intents test cases.
  19686. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  19687. (DumpRenderTreeChrome::onFrameIntentNew):
  19688. 2012-05-30 Kevin Ollivier <kevino@theolliviers.com>
  19689. [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
  19690. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  19691. 2012-05-30 Christophe Dumez <christophe.dumez@intel.com>
  19692. [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
  19693. https://bugs.webkit.org/show_bug.cgi?id=87829
  19694. Reviewed by Adam Barth.
  19695. EFL's LayoutTestController now makes uses of the new helper method in
  19696. DumpRenderTreeSupportEfl in order to send the intent response. This is
  19697. now needed because the Ewk_Intent_Request postResult / postFailure
  19698. methods were made private.
  19699. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  19700. (LayoutTestController::sendWebIntentResponse):
  19701. 2012-05-30 Xueqing Huang <huangxueqing@baidu.com>
  19702. eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
  19703. https://bugs.webkit.org/show_bug.cgi?id=86296
  19704. Reviewed by Tony Chang.
  19705. * DumpRenderTree/win/DRTDataObject.cpp: Added.
  19706. (cfHDropFormat):
  19707. (cfFileNameWFormat):
  19708. (cfUrlWFormat):
  19709. (WCEnumFormatEtc):
  19710. (WCEnumFormatEtc::WCEnumFormatEtc):
  19711. (WCEnumFormatEtc::QueryInterface):
  19712. (WCEnumFormatEtc::AddRef):
  19713. (WCEnumFormatEtc::Release):
  19714. (WCEnumFormatEtc::Next):
  19715. (WCEnumFormatEtc::Skip):
  19716. (WCEnumFormatEtc::Reset):
  19717. (WCEnumFormatEtc::Clone):
  19718. (DRTDataObject::createInstance):
  19719. (DRTDataObject::DRTDataObject):
  19720. (DRTDataObject::~DRTDataObject):
  19721. (DRTDataObject::QueryInterface):
  19722. (DRTDataObject::AddRef):
  19723. (DRTDataObject::Release):
  19724. (DRTDataObject::GetData):
  19725. (DRTDataObject::GetDataHere):
  19726. (DRTDataObject::QueryGetData):
  19727. (DRTDataObject::GetCanonicalFormatEtc):
  19728. (DRTDataObject::SetData):
  19729. (DRTDataObject::CopyMedium):
  19730. (DRTDataObject::EnumFormatEtc):
  19731. (DRTDataObject::DAdvise):
  19732. (DRTDataObject::DUnadvise):
  19733. (DRTDataObject::EnumDAdvise):
  19734. (DRTDataObject::clearData):
  19735. * DumpRenderTree/win/DRTDataObject.h: Added.
  19736. (DRTDataObject):
  19737. * DumpRenderTree/win/DRTDropSource.cpp: Added.
  19738. (DRTDropSource::DRTDropSource):
  19739. (DRTDropSource::~DRTDropSource):
  19740. (DRTDropSource::QueryInterface):
  19741. (DRTDropSource::AddRef):
  19742. (DRTDropSource::Release):
  19743. (DRTDropSource::createInstance):
  19744. (DRTDropSource::QueryContinueDrag):
  19745. (DRTDropSource::GiveFeedback):
  19746. * DumpRenderTree/win/DRTDropSource.h: Added.
  19747. (DRTDropSource):
  19748. * DumpRenderTree/win/DumpRenderTree.vcproj:
  19749. * DumpRenderTree/win/EventSender.cpp:
  19750. (beginDragWithFilesCallback):
  19751. 2012-05-30 Marcelo Lira <marcelo.lira@openbossa.org>
  19752. WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
  19753. https://bugs.webkit.org/show_bug.cgi?id=58593
  19754. Adds the ability to change the pluginsEnabled flag in WebCore::Settings
  19755. to WebKitTestRunner's LayoutTestController. The flag is modified via the
  19756. public C API of the WebProcess.
  19757. Reviewed by Darin Adler.
  19758. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  19759. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  19760. (WTR::LayoutTestController::setPluginsEnabled): Just calls the
  19761. WKBundleSetPluginsEnabled function in the public C API of WebProcess.
  19762. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  19763. 2012-05-30 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  19764. [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
  19765. https://bugs.webkit.org/show_bug.cgi?id=87848
  19766. Reviewed by Csaba Osztrogonác.
  19767. The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
  19768. and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
  19769. (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
  19770. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  19771. (DumpRenderTreeChrome::extraViews):
  19772. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  19773. (DumpRenderTreeChrome):
  19774. 2012-05-30 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  19775. [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
  19776. https://bugs.webkit.org/show_bug.cgi?id=87833
  19777. Reviewed by Tor Arne Vestbø.
  19778. Print "postProgressFinishedNotification" message if frame load finished
  19779. to unskip http/tests/loading/progress-finished-callback.html.
  19780. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  19781. (DumpRenderTreeChrome::onFrameLoadFinished):
  19782. 2012-05-30 Mariusz Grzegorczyk <mariusz.g@samsung.com>, Ryuan Choi <ryuan.choi@samsung.com>
  19783. [EFL][WK2] Fix WebKit2-EFL build
  19784. https://bugs.webkit.org/show_bug.cgi?id=83693
  19785. Reviewed by Carlos Garcia Campos.
  19786. * CMakeLists.txt: Guard Webkit1 related codes with ENABLE_WEBKIT.
  19787. 2012-05-29 János Badics <jbadics@inf.u-szeged.hu>
  19788. [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
  19789. (They only used to check for Skipped in platform/qt-5.0-wk1)
  19790. https://bugs.webkit.org/show_bug.cgi?id=87376
  19791. Reviewed by Csaba Osztrogonác.
  19792. * Scripts/old-run-webkit-tests:
  19793. (buildPlatformResultHierarchy):
  19794. * Scripts/webkitpy/layout_tests/port/qt.py:
  19795. (QtPort.baseline_search_path):
  19796. 2012-05-29 Ojan Vafai <ojan@chromium.org>
  19797. Add a linter error for pngs that lack an embedded checksum
  19798. https://bugs.webkit.org/show_bug.cgi?id=87793
  19799. Reviewed by Dirk Pranke.
  19800. * Scripts/read-checksum-from-png:
  19801. * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
  19802. (read_checksum):
  19803. * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
  19804. (ReadChecksumFromPngTest):
  19805. (ReadChecksumFromPngTest.test_read_checksum):
  19806. * Scripts/webkitpy/layout_tests/port/base.py:
  19807. * Scripts/webkitpy/style/checkers/png.py:
  19808. (PNGChecker.check):
  19809. * Scripts/webkitpy/style/checkers/png_unittest.py:
  19810. (PNGCheckerTest.test_check):
  19811. 2012-05-29 Stephanie Lewis <slewis@apple.com>
  19812. https://bugs.webkit.org/show_bug.cgi?id=87720
  19813. WebProcess is often killed due to being unresponsive on the bots
  19814. Reviewed by Alexey Proskuryakov.
  19815. Blind attempt to improve flakiness on the bots by reducing the number
  19816. of crashes due to an unresponsive process. This helped on my personal machine
  19817. under stress conditions. I don't have enough cores to hit the problem
  19818. under normal conditions.
  19819. * WebKitTestRunner/TestController.cpp:
  19820. (WTR):
  19821. 2012-05-29 Dirk Pranke <dpranke@chromium.org>
  19822. webkitpy: rename 'rm' to 'delete' in rebaseline scm output
  19823. https://bugs.webkit.org/show_bug.cgi?id=87779
  19824. Reviewed by Eric Seidel.
  19825. Update output to match the names in scm.py as per
  19826. https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
  19827. * Scripts/webkitpy/tool/commands/rebaseline.py:
  19828. (RebaselineTest.execute):
  19829. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  19830. (test_rebaseline_test_and_print_scm_changes):
  19831. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  19832. (GardeningServerTest.test_rebaselineall):
  19833. 2012-05-29 Stephanie Lewis <slewis@apple.com>
  19834. https://bugs.webkit.org/show_bug.cgi?id=87711
  19835. Reviewed by Jessie Berlin.
  19836. Remove Snowleopard testers so the hardware can be repurposed. The lion bots
  19837. are better maintained.
  19838. * BuildSlaveSupport/build.webkit.org-config/config.json:
  19839. 2012-05-29 Dirk Pranke <dpranke@chromium.org>
  19840. webkit-patch optimize-baselines should add/delete files in batches from the vcs
  19841. https://bugs.webkit.org/show_bug.cgi?id=87538
  19842. Reviewed by Ojan Vafai.
  19843. Invoking git and svn on one file at a time is kinda slow. We
  19844. should batch the add and rm operations together.
  19845. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  19846. (BaselineOptimizer._move_baselines):
  19847. 2012-05-29 Dirk Pranke <dpranke@chromium.org>
  19848. garden-o-matic should rebaseline baselines in parallel
  19849. https://bugs.webkit.org/show_bug.cgi?id=87451
  19850. Reviewed by Ojan Vafai.
  19851. This modifies garden-o-matic so that we will fetch all
  19852. of the baselines in parallel from the bots, and then
  19853. optimize the baselines serially (since that should be fairly
  19854. quick and we get into trouble if we optimize in parallel due
  19855. to concurrent access to the source control system).
  19856. This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
  19857. so that the files that need to be modified in the SCM are returned to
  19858. garden-o-matic rather than actually added or removed. This is done so that
  19859. we can run multiple rebaseline-tests in parallel (we can't modify the SCM
  19860. concurrently). In order to safely return the files (as a JSON dict) I
  19861. needed to shift all of the logging in rebaseline-test to use the logging
  19862. module (and hence log to stderr).
  19863. I also had to stub out a line in chromium.py that would get confused if
  19864. the skia overrides file didn't exist in a mock checkout.
  19865. * Scripts/webkitpy/common/system/executive.py:
  19866. (Executive.popen):
  19867. (Executive):
  19868. (Executive.run_in_parallel):
  19869. (_run_command_thunk):
  19870. * Scripts/webkitpy/common/system/executive_mock.py:
  19871. (MockExecutive.run_in_parallel):
  19872. * Scripts/webkitpy/common/system/executive_unittest.py:
  19873. (ExecutiveTest.test_run_in_parallel):
  19874. * Scripts/webkitpy/layout_tests/port/chromium.py:
  19875. (ChromiumPort._expectations_file_contents):
  19876. * Scripts/webkitpy/tool/commands/rebaseline.py:
  19877. (AbstractRebaseliningCommand.__init__):
  19878. (RebaselineTest.__init__):
  19879. (RebaselineTest._copy_existing_baseline):
  19880. (RebaselineTest._save_baseline):
  19881. (RebaselineTest):
  19882. (RebaselineTest._add_to_scm):
  19883. (RebaselineTest._rebaseline_test):
  19884. (RebaselineTest.execute):
  19885. (RebaselineExpectations._rebaseline_port):
  19886. (RebaselineExpectations.execute):
  19887. (Rebaseline._builder_to_pull_from):
  19888. (Rebaseline.execute):
  19889. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  19890. (test_rebaseline_updates_expectations_file):
  19891. (test_rebaseline_test):
  19892. (test_rebaseline_test_and_print_scm_changes):
  19893. (test_rebaseline_and_copy_test):
  19894. (test_rebaseline_and_copy_test_no_existing_result):
  19895. (test_rebaseline_and_copy_test_with_lion_result):
  19896. (test_rebaseline_and_copy_no_overwrite_test):
  19897. (test_rebaseline_expectations):
  19898. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  19899. (GardeningHTTPRequestHandler._rebaseline_commands):
  19900. (GardeningHTTPRequestHandler):
  19901. (GardeningHTTPRequestHandler._files_to_add):
  19902. (GardeningHTTPRequestHandler._optimize_baselines):
  19903. (GardeningHTTPRequestHandler.rebaselineall):
  19904. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  19905. (GardeningServerTest._post_to_path):
  19906. (GardeningServerTest.test_rebaselineall):
  19907. (GardeningServerTest.test_rebaselineall.run_command):
  19908. 2012-05-29 Benjamin Poulain <bpoulain@apple.com>
  19909. Fix the type of dispatch_time() offset
  19910. Rubber-stamped by Joseph Pecoraro.
  19911. In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
  19912. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  19913. (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
  19914. 2012-05-29 Arvid Nilsson <anilsson@rim.com>
  19915. 2012-05-29 Arvid Nilsson <anilsson@rim.com>
  19916. [BlackBerry] OpenGL content is not rendered on simulator
  19917. https://bugs.webkit.org/show_bug.cgi?id=87721
  19918. Reviewed by George Staikos.
  19919. Fixed by enabling GLES2 support in simulator builds.
  19920. To experiment with building without OpenGL support, you can set the
  19921. DISABLE_GLES2 environment variable to a non-empty string and rebuild.
  19922. PR #150695
  19923. * Scripts/webkitdirs.pm:
  19924. (blackberryCMakeArguments):
  19925. 2012-05-29 David Barr <davidbarr@chromium.org>
  19926. Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
  19927. https://bugs.webkit.org/show_bug.cgi?id=87685
  19928. Reviewed by Eric Seidel.
  19929. Add a configuration option for CSS image-resolution support, disabling it by default.
  19930. * Scripts/webkitperl/FeatureList.pm:
  19931. * qmake/mkspecs/features/features.pri:
  19932. 2012-05-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19933. [Qt] Don't add cxx-flags to QMAKE_CFLAGS
  19934. Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
  19935. valid for C++/ObjC++ but not for C [enabled by default]"
  19936. Reviewed by Simon Hausmann.
  19937. * qmake/mkspecs/features/unix/default_post.prf:
  19938. 2012-05-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19939. [Qt] Sync up favicon-implementation with WebView url changes in r118158
  19940. https://bugs.webkit.org/show_bug.cgi?id=87133
  19941. We now base64-encode the page url in the image-provider url, so that any
  19942. normalization done by QUrl will not mess up the page-url. The logic of
  19943. creating and parsing the provider-url has been moved into the image
  19944. provider, to keep it in one place.
  19945. We were also releasing icons (even ones we hadn't retained), which we can't
  19946. do since we don't know when the icon url is no longer in use.
  19947. Reviewed-by Simon Hausmann.
  19948. * MiniBrowser/qt/icons/favicon.png:
  19949. * MiniBrowser/qt/qml/BrowserWindow.qml:
  19950. 2012-05-29 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  19951. [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
  19952. https://bugs.webkit.org/show_bug.cgi?id=87654
  19953. Reviewed by Csaba Osztrogonác.
  19954. Event sender provides strings for all the key events.
  19955. Also KeyEventInfo constructor parameters order was changed to simplify the case when
  19956. a key event has empty string.
  19957. * DumpRenderTree/efl/EventSender.cpp:
  19958. (KeyEventInfo::KeyEventInfo):
  19959. (keyPadNameFromJSValue):
  19960. (keyNameFromJSValue):
  19961. 2012-05-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19962. [Qt] Cancel potential url-edit when going back/forward
  19963. Reviewed by Kenneth Rohde Christiansen.
  19964. * MiniBrowser/qt/qml/BrowserWindow.qml:
  19965. 2012-05-29 Christophe Dumez <christophe.dumez@intel.com>
  19966. [EFL] Compilation warning in DumpRenderTreeView.cpp
  19967. https://bugs.webkit.org/show_bug.cgi?id=87636
  19968. Reviewed by Filip Pizlo.
  19969. Fix compilation error in DumpRenderTreeView.cpp due to wrong format
  19970. specifier in printf. Also fix the return type for
  19971. onExceededApplicationCacheQuota callback.
  19972. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  19973. (onExceededApplicationCacheQuota):
  19974. 2012-05-29 Hironori Bono <hbono@chromium.org>
  19975. Adding Hironori Bono to committers.py.
  19976. https://bugs.webkit.org/show_bug.cgi?id=87697
  19977. * Scripts/webkitpy/common/config/committers.py:
  19978. 2012-05-28 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  19979. [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
  19980. https://bugs.webkit.org/show_bug.cgi?id=80135
  19981. Reviewed by Rob Buis.
  19982. Implemented interface function didReceiveAuthenticationChallenge in class
  19983. DumpRenderTree.
  19984. Resubmit the patch reverted by r115104 after the digest infinite loop
  19985. issue for BlackBerry porting get identified and fixed.
  19986. Internally reviewed by Joe Mason <jmason@rim.com>
  19987. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  19988. (drtCredentialDescription):
  19989. (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
  19990. (WebKit):
  19991. * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
  19992. (WebCore):
  19993. (DumpRenderTree):
  19994. 2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  19995. WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
  19996. https://bugs.webkit.org/show_bug.cgi?id=42328
  19997. Reviewed by Eric Seidel.
  19998. Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
  19999. move to windows.internals.settings.
  20000. * DumpRenderTree/LayoutTestController.cpp:
  20001. (LayoutTestController::staticFunctions):
  20002. * DumpRenderTree/LayoutTestController.h:
  20003. (LayoutTestController):
  20004. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  20005. * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  20006. * DumpRenderTree/chromium/DRTDevToolsAgent.h:
  20007. (DRTDevToolsAgent):
  20008. * DumpRenderTree/chromium/LayoutTestController.cpp:
  20009. (LayoutTestController::LayoutTestController):
  20010. * DumpRenderTree/chromium/LayoutTestController.h:
  20011. (LayoutTestController):
  20012. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  20013. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  20014. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  20015. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  20016. * DumpRenderTree/mac/DumpRenderTree.mm:
  20017. (resetWebViewToConsistentStateBeforeTesting):
  20018. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  20019. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  20020. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  20021. (LayoutTestController):
  20022. * DumpRenderTree/win/DumpRenderTree.cpp:
  20023. (resetWebViewToConsistentStateBeforeTesting):
  20024. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  20025. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  20026. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  20027. (LayoutTestController):
  20028. 2012-05-28 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  20029. Move allowRoundingHacks to Internals interface
  20030. https://bugs.webkit.org/show_bug.cgi?id=87328
  20031. Reviewed by Hajime Morita.
  20032. Remove allowRoundingHacks functions, because it is able to work in the
  20033. cross-port way through the Internals interface.
  20034. * DumpRenderTree/LayoutTestController.cpp:
  20035. (LayoutTestController::staticFunctions):
  20036. * DumpRenderTree/LayoutTestController.h:
  20037. (LayoutTestController):
  20038. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  20039. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  20040. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  20041. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  20042. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  20043. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  20044. 2012-05-28 Luke Macpherson <macpherson@chromium.org>
  20045. Fix mac build with older XCode by defining NSEC_PER_MSEC.
  20046. https://bugs.webkit.org/show_bug.cgi?id=87616
  20047. Reviewed by Hajime Morita.
  20048. The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
  20049. http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
  20050. Patch just adds a #ifndef / #define check.
  20051. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  20052. (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
  20053. 2012-05-27 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  20054. [EFL] Enable blob support for the EFL port
  20055. https://bugs.webkit.org/show_bug.cgi?id=85363
  20056. Reviewed by Hajime Morita.
  20057. Enable Blob support by default for the EFL port.
  20058. * Scripts/webkitperl/FeatureList.pm:
  20059. 2012-05-27 Benjamin Poulain <bpoulain@apple.com>
  20060. When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
  20061. https://bugs.webkit.org/show_bug.cgi?id=87582
  20062. Reviewed by Darin Adler.
  20063. Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
  20064. possible to test pages in a similar way as they are loaded in Browsers.
  20065. * DumpRenderTree/LayoutTestController.cpp:
  20066. (LayoutTestController::LayoutTestController):
  20067. (setUseDeferredFrameLoadingCallback):
  20068. (LayoutTestController::staticFunctions):
  20069. * DumpRenderTree/LayoutTestController.h:
  20070. (LayoutTestController::useDeferredFrameLoading):
  20071. (LayoutTestController::setUseDeferredFrameLoading):
  20072. (LayoutTestController):
  20073. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  20074. (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
  20075. 2012-05-27 David Barton <dbarton@mathscribe.com>
  20076. [watchlist] Improve MathML rule
  20077. https://bugs.webkit.org/show_bug.cgi?id=87592
  20078. Reviewed by Adam Barth.
  20079. The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
  20080. but if this changed the rule would be slow. We protect against this, clarify the rule,
  20081. and make it more similar to existing rules.
  20082. * Scripts/webkitpy/common/config/watchlist:
  20083. 2012-05-27 David Barton <dbarton@mathscribe.com>
  20084. [watchlist] Add myself & a rule for MathML
  20085. https://bugs.webkit.org/show_bug.cgi?id=87586
  20086. Reviewed by Adam Barth.
  20087. * Scripts/webkitpy/common/config/watchlist:
  20088. 2012-05-26 David Kilzer <ddkilzer@apple.com>
  20089. Use xcrun to find path to nm for Mac port
  20090. <http://webkit.org/b/87588>
  20091. Reviewed by Dan Bernstein.
  20092. * Scripts/webkitpy/layout_tests/port/mac.py:
  20093. (MacPort.nm_command): Add. Tries to find a path for the nm
  20094. command using xcrun. Falls back to returning 'nm'.
  20095. * Scripts/webkitpy/layout_tests/port/webkit.py:
  20096. (WebKitPort.nm_command): Add. Returns 'nm'.
  20097. (WebKitPort._webcore_symbols_string): Call self.nm_command().
  20098. 2012-05-25 Lynn Neir <lynn.neir@skype.net>
  20099. Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
  20100. Reviewed by Eric Seidel.
  20101. * DumpRenderTree/win/DumpRenderTree.vcproj:
  20102. * DumpRenderTree/win/FrameLoadDelegate.cpp:
  20103. (FrameLoadDelegate::FrameLoadDelegate):
  20104. (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
  20105. * DumpRenderTree/win/FrameLoadDelegate.h:
  20106. (FrameLoadDelegate):
  20107. * DumpRenderTree/win/TextInputController.cpp: Added.
  20108. (setMarkedTextCallback):
  20109. (hasMarkedTextCallback):
  20110. (unmarkTextCallback):
  20111. (markedRangeCallback):
  20112. (insertTextCallback):
  20113. (firstRectForCharacterRangeCallback):
  20114. (selectedRangeCallback):
  20115. (TextInputController::makeWindowObject):
  20116. (TextInputController::getJSClass):
  20117. (TextInputController::staticValues):
  20118. (TextInputController::staticFunctions):
  20119. * DumpRenderTree/win/TextInputController.h: Added.
  20120. (TextInputController):
  20121. * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
  20122. (TextInputController::setMarkedText):
  20123. (TextInputController::hasMarkedText):
  20124. (TextInputController::unmarkText):
  20125. (TextInputController::markedRange):
  20126. (TextInputController::insertText):
  20127. (TextInputController::firstRectForCharacterRange):
  20128. (TextInputController::selectedRange):
  20129. 2012-05-25 Dirk Pranke <dpranke@chromium.org>
  20130. webkitpy: change scm.add(), scm.delete() to accept multiple paths
  20131. https://bugs.webkit.org/show_bug.cgi?id=87528
  20132. Reviewed by Ojan Vafai.
  20133. launching git or svn for individual files can be slow; this
  20134. change will hand multiple paths at once to git and svn so they
  20135. can be added in a batch.
  20136. * Scripts/webkitpy/common/checkout/scm/git.py:
  20137. (Git.add_list):
  20138. (Git.delete_list):
  20139. * Scripts/webkitpy/common/checkout/scm/scm.py:
  20140. (SCM.add):
  20141. (SCM):
  20142. (SCM.add_list):
  20143. (SCM.delete):
  20144. (SCM.delete_list):
  20145. * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
  20146. (MockSCM.add):
  20147. (MockSCM):
  20148. (MockSCM.add_list):
  20149. (MockSCM.delete):
  20150. (MockSCM.delete_list):
  20151. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  20152. (_shared_test_exists):
  20153. (_shared_test_added_files):
  20154. (_test_delete_list):
  20155. * Scripts/webkitpy/common/checkout/scm/svn.py:
  20156. (SVN.add_list):
  20157. (SVN.delete_list):
  20158. 2012-05-25 Thiago Marcos P. Santos <thiago.santos@intel.com>
  20159. [NRWT] Add unit testing for perf tests on locked shards
  20160. https://bugs.webkit.org/show_bug.cgi?id=87489
  20161. Reviewed by Dirk Pranke.
  20162. Adding utests that makes sure that perf tests are running in locked
  20163. shards and by passing --no-http won't break NRWT (r118421).
  20164. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  20165. (ShardingTests):
  20166. (ShardingTests.test_shard_by_dir):
  20167. (ShardingTests.test_shard_every_file):
  20168. (ShardingTests.test_shard_in_two):
  20169. (ShardingTests.test_multiple_locked_shards):
  20170. (LockCheckingManager):
  20171. (LockCheckingManager.__init__):
  20172. (LockCheckingManager.handle_finished_list):
  20173. (ManagerTest.test_http_locking):
  20174. (ManagerTest):
  20175. (ManagerTest.test_perf_locking):
  20176. * Scripts/webkitpy/layout_tests/port/test.py:
  20177. 2012-05-25 Jessie Berlin <jberlin@apple.com>
  20178. [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
  20179. https://bugs.webkit.org/show_bug.cgi?id=87511
  20180. Reviewed by Alexey Proskuryakov.
  20181. Update the Windows implementation of keyDown to match the Mac one changed in r118001.
  20182. * DumpRenderTree/win/EventSender.cpp:
  20183. (keyDownCallback):
  20184. 2012-05-25 Ken Buchanan <kenrb@chromium.org>
  20185. Adding Ken Buchanan to committers.py
  20186. https://bugs.webkit.org/show_bug.cgi?id=87443
  20187. Unreviewed.
  20188. Adding self to committers.py as a Committer.
  20189. * Scripts/webkitpy/common/config/committers.py:
  20190. 2012-05-25 Csaba Osztrogonác <ossy@webkit.org>
  20191. [Qt] Buildfix for newer Qt5
  20192. https://bugs.webkit.org/show_bug.cgi?id=87257
  20193. Reviewed by Simon Hausmann.
  20194. * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
  20195. 2012-05-25 Csaba Osztrogonác <ossy@webkit.org>
  20196. [Qt] Unreviewed fix after r118484.
  20197. Enable CSS_EXCLUSIONS and CSS_REGIONS.
  20198. They were enabled uncoditinally before r118484.
  20199. * qmake/mkspecs/features/features.pri:
  20200. 2012-05-24 Tim Horton <timothy_horton@apple.com>
  20201. Add feature defines for web-facing parts of CSS Regions and Exclusions
  20202. https://bugs.webkit.org/show_bug.cgi?id=87442
  20203. <rdar://problem/10887709>
  20204. Reviewed by Dan Bernstein.
  20205. * Scripts/webkitperl/FeatureList.pm:
  20206. 2012-05-24 Hironori Bono <hbono@chromium.org>
  20207. Enable grammar checking on Chromium when we paste text (Take 2)
  20208. https://bugs.webkit.org/show_bug.cgi?id=74393
  20209. Reviewed by Ryosuke Niwa.
  20210. This change enables grammar checking on Chromium and implements a mock grammar
  20211. checker to fix a failing test.
  20212. * DumpRenderTree/DumpRenderTree.gypi:
  20213. * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
  20214. (MockGrammarCheck::checkGrammarOfString):
  20215. * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
  20216. (WebKit):
  20217. (MockGrammarCheck):
  20218. * DumpRenderTree/chromium/WebViewHost.cpp:
  20219. (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
  20220. 2012-05-24 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  20221. [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
  20222. https://bugs.webkit.org/show_bug.cgi?id=86842
  20223. Reviewed by Antonio Gomes.
  20224. Add support for overriding the application cache support preference
  20225. through EFL's LayoutTestController.
  20226. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  20227. (LayoutTestController::overridePreference):
  20228. 2012-05-24 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  20229. [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
  20230. https://bugs.webkit.org/show_bug.cgi?id=85209
  20231. Reviewed by Antonio Gomes.
  20232. Set developer extras setting called twice on the test startup. Hence, removing
  20233. an unnecessary extra call which set wrong value.
  20234. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  20235. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  20236. 2012-05-24 Dirk Pranke <dpranke@chromium.org>
  20237. garden-o-matic should not fetch from debug bots if it also knows about the release bots
  20238. https://bugs.webkit.org/show_bug.cgi?id=86916
  20239. Reviewed by Adam Barth.
  20240. Note that if release and debug are failing differently, debug
  20241. will be ignored ...
  20242. Note: also change the use of a fake port name from
  20243. "mock-port-name" to "test-mac-leopard" to make it more friendly
  20244. to the port factory ("mock" actually is a real port).
  20245. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  20246. (GardeningHTTPRequestHandler._builders_to_fetch_from):
  20247. (GardeningHTTPRequestHandler.rebaselineall):
  20248. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  20249. (GardeningServerTest.test_rebaselineall):
  20250. (GardeningServerTest.test_rebaseline_new_port):
  20251. 2012-05-24 Dirk Pranke <dpranke@chromium.org>
  20252. nrwt: fix baseline search path for official chrome builders
  20253. https://bugs.webkit.org/show_bug.cgi?id=87432
  20254. Reviewed by Tony Chang.
  20255. The official chrome builders need to use the win7 and SL
  20256. baseline paths, not the XP and Leopard paths. Linux is correct.
  20257. * Scripts/webkitpy/layout_tests/port/google_chrome.py:
  20258. (GoogleChromeMacPort.determine_full_port_name):
  20259. (GoogleChromeWinPort.determine_full_port_name):
  20260. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  20261. (TestGoogleChromePort._verify_baseline_search_path_startswith):
  20262. (TestGoogleChromePort.test_get_google_chrome_port):
  20263. 2012-05-24 Thiago Marcos P. Santos <thiago.santos@intel.com>
  20264. [NRWT] REGRESSION(r116021): Assertion when running with --no-http
  20265. https://bugs.webkit.org/show_bug.cgi?id=86800
  20266. Reviewed by Dirk Pranke.
  20267. Don't launch a HTTP server with lock based only on the existence of
  20268. locked shards since we now run perf on locked shards too.
  20269. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  20270. (Manager._run_tests):
  20271. 2012-05-24 Jochen Eisinger <jochen@chromium.org>
  20272. Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
  20273. https://bugs.webkit.org/show_bug.cgi?id=87128
  20274. Reviewed by Dirk Pranke.
  20275. * Scripts/webkitpy/layout_tests/port/base.py:
  20276. (Port.driver_name):
  20277. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  20278. (ChromiumLinuxPort._path_to_driver):
  20279. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  20280. (ChromiumPortTest.test_driver_name_option):
  20281. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  20282. (ChromiumWinPort._path_to_driver):
  20283. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  20284. (parse_args):
  20285. 2012-05-24 John Mellor <johnme@chromium.org>
  20286. Font Boosting: Add compile flag and runtime setting
  20287. https://bugs.webkit.org/show_bug.cgi?id=87394
  20288. Reviewed by Adam Barth.
  20289. Add ENABLE_FONT_BOOSTING.
  20290. * Scripts/webkitperl/FeatureList.pm:
  20291. * qmake/mkspecs/features/features.pri:
  20292. 2012-05-24 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  20293. [EFL] [DRT] keyboard-related tests do not pass
  20294. https://bugs.webkit.org/show_bug.cgi?id=85369
  20295. Reviewed by Gustavo Noronha Silva.
  20296. Add SHIFT modifier for capital letters as VK_
  20297. codes do not distinguish between lows and caps and also to be consistent
  20298. with other ports which send caps as lowercase letters with the shift key down.
  20299. * DumpRenderTree/efl/EventSender.cpp:
  20300. (keyNameFromJSValue):
  20301. 2012-05-24 Alexey Proskuryakov <ap@apple.com>
  20302. [WK2] Let the client give local files universal access on a case by case basis
  20303. https://bugs.webkit.org/show_bug.cgi?id=87174
  20304. <rdar://problem/11024330>
  20305. Reviewed by Maciej Stachowiak.
  20306. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
  20307. Added initialization of a new structure member to prevent build failure.
  20308. 2012-05-24 Raphael Kubo da Costa <rakuco@webkit.org>
  20309. [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
  20310. https://bugs.webkit.org/show_bug.cgi?id=87203
  20311. Reviewed by Andreas Kling.
  20312. Add the required changes to make
  20313. fast/events/keydown-leftright-keys.html pass after r118001.
  20314. * DumpRenderTree/efl/EventSender.cpp:
  20315. (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
  20316. into the proper X11 keysym definitions.
  20317. 2012-05-24 Sheriff Bot <webkit.review.bot@gmail.com>
  20318. Unreviewed, rolling out r118352.
  20319. http://trac.webkit.org/changeset/118352
  20320. https://bugs.webkit.org/show_bug.cgi?id=87390
  20321. Caused 6 editing/spelling tests crash/fail on chromium in
  20322. debug. (Requested by vsevik on #webkit).
  20323. * DumpRenderTree/DumpRenderTree.gypi:
  20324. * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
  20325. * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
  20326. * DumpRenderTree/chromium/WebViewHost.cpp:
  20327. (WebViewHost::finishLastTextCheck):
  20328. 2012-05-24 Peter Beverloo <peter@chromium.org>
  20329. Add John Mellor as a contributor
  20330. https://bugs.webkit.org/show_bug.cgi?id=87389
  20331. Reviewed by Kenneth Rohde Christiansen.
  20332. John will be working on Font Boosting and is very involved with various
  20333. web-facing subjects of Chrome for Android, such as viewport.
  20334. * Scripts/webkitpy/common/config/committers.py:
  20335. 2012-05-24 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  20336. [EFL][DRT] LayoutTestController's setCacheModel() implementation
  20337. https://bugs.webkit.org/show_bug.cgi?id=86840
  20338. Reviewed by Csaba Osztrogonác.
  20339. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  20340. (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
  20341. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  20342. (LayoutTestController::setCacheModel): Implementation added.
  20343. 2012-05-24 Hironori Bono <hbono@chromium.org>
  20344. Enable grammar checking on Chromium when we paste text.
  20345. https://bugs.webkit.org/show_bug.cgi?id=74393
  20346. Reviewed by Hajime Morita.
  20347. This change enables grammar checking on Chromium and implements a mock grammar
  20348. checker to fix a failing test.
  20349. * DumpRenderTree/DumpRenderTree.gypi:
  20350. * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
  20351. (MockGrammarCheck::checkGrammarOfString):
  20352. * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
  20353. (WebKit):
  20354. (MockGrammarCheck):
  20355. * DumpRenderTree/chromium/WebViewHost.cpp:
  20356. (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
  20357. 2012-05-24 Csaba Osztrogonác <ossy@webkit.org>
  20358. [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
  20359. * qmake/mkspecs/features/features.pri:
  20360. 2012-05-24 Christophe Dumez <christophe.dumez@intel.com>
  20361. [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
  20362. https://bugs.webkit.org/show_bug.cgi?id=86867
  20363. Reviewed by Adam Barth.
  20364. Add implementation for sendWebIntentResponse() in EFL's
  20365. LayoutTestController and add empty implementation for other ports.
  20366. * DumpRenderTree/LayoutTestController.cpp:
  20367. (sendWebIntentResponseCallback):
  20368. (LayoutTestController::staticFunctions):
  20369. * DumpRenderTree/LayoutTestController.h:
  20370. (LayoutTestController):
  20371. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  20372. (LayoutTestController::sendWebIntentResponse):
  20373. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  20374. (DumpRenderTreeChrome::currentIntentRequest):
  20375. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  20376. (DumpRenderTreeChrome::onFrameIntentNew):
  20377. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  20378. (DumpRenderTreeChrome):
  20379. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  20380. (LayoutTestController::sendWebIntentResponse):
  20381. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  20382. (LayoutTestController::sendWebIntentResponse):
  20383. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  20384. (LayoutTestController::sendWebIntentResponse):
  20385. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  20386. (LayoutTestController::sendWebIntentResponse):
  20387. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  20388. (LayoutTestController::sendWebIntentResponse):
  20389. 2012-05-24 Christophe Dumez <christophe.dumez@intel.com>
  20390. [EFL] The EFL port has no support for title directionality
  20391. https://bugs.webkit.org/show_bug.cgi?id=86462
  20392. Reviewed by Gustavo Noronha Silva.
  20393. Update "title,changed" signal handlers in DRT and EWebLauncher to
  20394. reflect the change from const char* to Ewk_Text_With_Direction* type
  20395. for the title.
  20396. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  20397. (DumpRenderTreeChrome::onTitleChanged):
  20398. * EWebLauncher/main.c:
  20399. (title_set):
  20400. (on_title_changed):
  20401. (on_key_down):
  20402. 2012-05-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  20403. Change EFL debug build name with more detail one
  20404. https://bugs.webkit.org/show_bug.cgi?id=87254
  20405. Reviewed by Ryosuke Niwa.
  20406. EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
  20407. In addition, remove efl-linux-debug triggerable since nobody uses it.
  20408. * BuildSlaveSupport/build.webkit.org-config/config.json:
  20409. 2012-05-23 Kangil Han <kangil.han@samsung.com>
  20410. [EFL][DRT] Fix WebCore library path and rebaseline result
  20411. https://bugs.webkit.org/show_bug.cgi?id=86355
  20412. Reviewed by Dirk Pranke.
  20413. Currently EFL DRT uses wrong WebCore library path when running DRT.
  20414. Therefore, this patch adjusted the path correctly.
  20415. * Scripts/webkitpy/layout_tests/port/efl.py:
  20416. (EflPort._path_to_webcore_library):
  20417. 2012-05-23 Ojan Vafai <ojan@chromium.org>
  20418. add back the ability to disable flexbox
  20419. https://bugs.webkit.org/show_bug.cgi?id=87147
  20420. Reviewed by Tony Chang.
  20421. * Scripts/webkitperl/FeatureList.pm:
  20422. 2012-05-23 Tony Chang <tony@chromium.org>
  20423. Remove the Chromium Grid Layout bot from the waterfall
  20424. https://bugs.webkit.org/show_bug.cgi?id=87311
  20425. Reviewed by Ryosuke Niwa.
  20426. I removed the compiler define in r117613, so we don't need a separate
  20427. bot to compile/test this code.
  20428. * BuildSlaveSupport/build.webkit.org-config/config.json:
  20429. 2012-05-23 Ian Vollick <vollick@chromium.org>
  20430. Add vollick to list of contributors.
  20431. https://bugs.webkit.org/show_bug.cgi?id=87305
  20432. Reviewed by Adam Barth.
  20433. * Scripts/webkitpy/common/config/committers.py:
  20434. 2012-05-23 Xianzhu Wang <wangxianzhu@chromium.org>
  20435. [Chromium-Android] Fix chromium_android_unittest
  20436. https://bugs.webkit.org/show_bug.cgi?id=87196
  20437. Reviewed by Tony Chang.
  20438. Update unit tests after ChromiumAndroidPort supported apk based
  20439. DumpRenderTree.
  20440. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  20441. (ChromiumAndroidPortTest):
  20442. (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
  20443. (ChromiumAndroidPortTest.test_get_last_stacktrace):
  20444. (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
  20445. (ChromiumAndroidDriverTest):
  20446. (ChromiumAndroidDriverTest.setUp):
  20447. (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
  20448. (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
  20449. 2012-05-23 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  20450. [watchlist] Add myself and create a watch rule to catch Attribute related patches
  20451. https://bugs.webkit.org/show_bug.cgi?id=87303
  20452. Reviewed by Alexis Menard.
  20453. * Scripts/webkitpy/common/config/watchlist:
  20454. 2012-05-23 Dirk Pranke <dpranke@chromium.org>
  20455. garden-o-matic should not fetch from debug bots if it also knows about the release bots
  20456. https://bugs.webkit.org/show_bug.cgi?id=86916
  20457. Reviewed by Adam Barth.
  20458. This change pushes all of the logic for rebaselining a cluster
  20459. of failures (a list of tests failing a list of suffixes on a
  20460. list of bots) onto the server, so there is a single call from
  20461. the web page; we will then be able to optimize the performance
  20462. of the rebaselining better.
  20463. Also remove the 'optimizebaseline' entry point on garden-o-matic
  20464. (and the client-side call) since we don't need it any more.
  20465. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  20466. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  20467. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  20468. (GardeningHTTPRequestHandler.rebaselineall):
  20469. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  20470. 2012-05-21 Ryosuke Niwa <rniwa@webkit.org>
  20471. Mac DRT should be able to load external URLs for replay performance tests
  20472. https://bugs.webkit.org/show_bug.cgi?id=86191
  20473. Reviewed by Alexey Proskuryakov.
  20474. Let external URL requests go through if the test file is not a local file or hosted at localhost.
  20475. e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
  20476. "DumpRenderTree http://localhost:8000/".
  20477. * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  20478. (isLocalhost):
  20479. (hostIsUsedBySomeTestsToGenerateError):
  20480. (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  20481. 2012-05-23 Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
  20482. [wx] In wxWebKit release builds on MSW, keep release settings but also build the
  20483. debug symbols for easier debugging.
  20484. https://bugs.webkit.org/show_bug.cgi?id=87151
  20485. Reviewed by Kevin Ollivier.
  20486. * waf/build/settings.py:
  20487. (common_configure):
  20488. 2012-05-23 Carlos Garcia Campos <cgarcia@igalia.com>
  20489. Unreviewed. Move myself to reviewers.
  20490. * Scripts/webkitpy/common/config/committers.py:
  20491. 2012-05-23 Dongwoo Im <dw.im@samsung.com>
  20492. [EFL] Implements the registerProtocolHandler method and option.
  20493. https://bugs.webkit.org/show_bug.cgi?id=73638
  20494. Reviewed by Andreas Kling.
  20495. * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
  20496. 2012-05-23 Zan Dobersek <zandobersek@gmail.com>
  20497. [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
  20498. https://bugs.webkit.org/show_bug.cgi?id=87221
  20499. Reviewed by Martin Robinson.
  20500. Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
  20501. rightShift key names into proper GDK key symbols.
  20502. * DumpRenderTree/gtk/EventSender.cpp:
  20503. (createKeyPressEvent):
  20504. 2012-04-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  20505. [Qt] Make the web view's url property follow the active url
  20506. https://bugs.webkit.org/show_bug.cgi?id=77554
  20507. Update the location bar in the minibrowser to behave
  20508. a bit more like normal browsers in terms of when the url will change
  20509. and how active focus is handled.
  20510. Reviewed by Simon Hausmann.
  20511. * MiniBrowser/qt/qml/BrowserWindow.qml:
  20512. 2012-05-23 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  20513. [Qt] Remove references to $$QT_SOURCE_TREE
  20514. With a modularized Qt, it's ambigious. What we really want is qtbase,
  20515. which qtcore is a proxy for (we assume it will always live in qtbase).
  20516. Reviewed by Tor Arne Vestbø.
  20517. * DumpRenderTree/qt/DumpRenderTree.pro:
  20518. 2012-05-23 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
  20519. [Qt] Fix qmake conditional for c++-11 compat warnings
  20520. Reviewed by Tor Arne Vestbø.
  20521. * qmake/mkspecs/features/unix/default_post.prf:
  20522. 2012-05-23 Christophe Dumez <christophe.dumez@intel.com>
  20523. [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
  20524. https://bugs.webkit.org/show_bug.cgi?id=85956
  20525. Reviewed by Gustavo Noronha Silva.
  20526. Catch new "load,provisional,failed" signal and print
  20527. didFailProvisionalLoadWithError messages when LayoutTestController's
  20528. dumpFrameLoadCallbacks() returns true. Also make sure the
  20529. didFailLoadWithError message is not printed in case of provisional
  20530. load failure.
  20531. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  20532. (DumpRenderTreeChrome::createView):
  20533. (DumpRenderTreeChrome::onFrameCreated):
  20534. (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
  20535. (DumpRenderTreeChrome::onFrameLoadError):
  20536. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  20537. (DumpRenderTreeChrome):
  20538. 2012-05-23 Christophe Dumez <christophe.dumez@intel.com>
  20539. [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
  20540. https://bugs.webkit.org/show_bug.cgi?id=86366
  20541. Reviewed by Antonio Gomes.
  20542. Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
  20543. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  20544. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  20545. 2012-05-22 Darin Adler <darin@apple.com>
  20546. * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
  20547. * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
  20548. 2012-05-22 Xianzhu Wang <wangxianzhu@chromium.org>
  20549. [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
  20550. https://bugs.webkit.org/show_bug.cgi?id=86922
  20551. Because we have new platformInit() in TestShellAndroid.cpp, and
  20552. we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
  20553. is split into TestShellPosix.cpp and TestShellX11.cpp.
  20554. Reviewed by Kent Tamura.
  20555. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  20556. * DumpRenderTree/DumpRenderTree.gypi:
  20557. * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
  20558. (platformInit):
  20559. * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
  20560. * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
  20561. * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
  20562. (AlarmHandler):
  20563. (TestShell::waitTestFinished):
  20564. * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
  20565. (openStartupDialog): from TestShellGtk.cpp
  20566. (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
  20567. (setupFontconfig):
  20568. (platformInit):
  20569. 2012-05-22 Kangil Han <kangil.han@samsung.com>
  20570. [EFL][DRT] Implement touch event
  20571. https://bugs.webkit.org/show_bug.cgi?id=86720
  20572. Reviewed by Hajime Morita.
  20573. Currently EFL DRT doesn't support touch event.
  20574. Therefore, this patch enabled it and implemented some eventSender function callbacks.
  20575. * DumpRenderTree/efl/EventSender.cpp:
  20576. (TouchEventInfo::TouchEventInfo):
  20577. (TouchEventInfo):
  20578. (touchPointList):
  20579. (sendTouchEvent):
  20580. (addTouchPointCallback):
  20581. (touchStartCallback):
  20582. (updateTouchPointCallback):
  20583. (touchMoveCallback):
  20584. (cancelTouchPointCallback):
  20585. (touchCancelCallback):
  20586. (releaseTouchPointCallback):
  20587. (touchEndCallback):
  20588. (clearTouchPointsCallback):
  20589. (setTouchModifierCallback):
  20590. * Scripts/webkitperl/FeatureList.pm:
  20591. 2012-05-22 Xianzhu Wang <wangxianzhu@chromium.org>
  20592. [Chromium-Android] Fix chromium_android_unittest
  20593. https://bugs.webkit.org/show_bug.cgi?id=87196
  20594. Not reviewed.
  20595. Temporarily disable chromium_android_unittest.
  20596. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  20597. (ChromiumAndroidPortTest):
  20598. (ChromiumAndroidDriverTest):
  20599. 2012-05-22 Jessie Berlin <jberlin@apple.com>
  20600. WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
  20601. https://bugs.webkit.org/show_bug.cgi?id=64313
  20602. Reviewed by Jon Honeycutt.
  20603. Add it.
  20604. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  20605. Make sure to generate the binding.
  20606. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  20607. (WTR::LayoutTestController::setDefersLoading):
  20608. Call WKBundlePageSetDefersLoading.
  20609. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  20610. 2012-05-22 Xianzhu Wang <wangxianzhu@chromium.org>
  20611. [Chromium-Android] Run DumpRenderTree as an apk (python part)
  20612. https://bugs.webkit.org/show_bug.cgi?id=86923
  20613. chromium_android.py is modified to support running DumpRenderTree as
  20614. an apk, so that we can run the tests (e.g. video) requiring features
  20615. implemented in Java on Android.
  20616. Reviewed by Adam Barth.
  20617. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  20618. (ChromiumAndroidPort.__init__):
  20619. (ChromiumAndroidPort.default_child_processes):
  20620. (ChromiumAndroidPort.check_wdiff):
  20621. (ChromiumAndroidPort.check_build):
  20622. (ChromiumAndroidPort.start_helper):
  20623. (ChromiumAndroidPort.skipped_layout_tests):
  20624. (ChromiumAndroidPort):
  20625. (ChromiumAndroidPort._path_to_driver):
  20626. (ChromiumAndroidPort._get_crash_log):
  20627. (ChromiumAndroidPort._push_executable):
  20628. (ChromiumAndroidPort._run_adb_command):
  20629. (ChromiumAndroidPort._get_last_stacktrace):
  20630. (ChromiumAndroidPort._get_logcat):
  20631. (ChromiumAndroidPort._setup_performance):
  20632. (ChromiumAndroidDriver):
  20633. (ChromiumAndroidDriver.__init__):
  20634. (ChromiumAndroidDriver._command_wrapper):
  20635. (ChromiumAndroidDriver.cmd_line):
  20636. (ChromiumAndroidDriver._file_exists_on_device):
  20637. (ChromiumAndroidDriver._deadlock_detector):
  20638. (ChromiumAndroidDriver._start):
  20639. (ChromiumAndroidDriver.run_test):
  20640. (ChromiumAndroidDriver.stop):
  20641. (ChromiumAndroidDriver._write_command_and_read_line):
  20642. (ChromiumAndroidDriver._output_image):
  20643. (ChromiumAndroidDriver._get_stderr):
  20644. 2012-05-22 Joshua Bell <jsbell@chromium.org>
  20645. [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
  20646. Unreviewed gardening.
  20647. * Scripts/webkitpy/layout_tests/port/base.py:
  20648. (Port.driver_name):
  20649. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  20650. (ChromiumLinuxPort._path_to_driver):
  20651. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  20652. (ChromiumPortTest.test_overrides_and_builder_names):
  20653. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  20654. (ChromiumWinPort._path_to_driver):
  20655. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  20656. (parse_args):
  20657. 2012-05-22 Xianzhu Wang <wangxianzhu@chromium.org>
  20658. [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
  20659. https://bugs.webkit.org/show_bug.cgi?id=87176
  20660. Reviewed by Tony Chang.
  20661. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  20662. * DumpRenderTree/DumpRenderTree.gypi:
  20663. 2012-05-22 Jochen Eisinger <jochen@chromium.org>
  20664. [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
  20665. https://bugs.webkit.org/show_bug.cgi?id=87128
  20666. Reviewed by Dirk Pranke.
  20667. * Scripts/webkitpy/layout_tests/port/base.py:
  20668. (Port.driver_name):
  20669. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  20670. (ChromiumLinuxPort._path_to_driver):
  20671. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  20672. (ChromiumPortTest.test_driver_name_option):
  20673. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  20674. (ChromiumWinPort._path_to_driver):
  20675. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  20676. (parse_args):
  20677. 2012-05-22 Jessie Berlin <jberlin@apple.com>
  20678. WTR fix after r118001.
  20679. Rubber-stamped by Alexey Proskuryakov.
  20680. Update the WTR implementation of keyDown to match the DRT one changed in r118001.
  20681. * WebKitTestRunner/mac/EventSenderProxy.mm:
  20682. (WTR::EventSenderProxy::keyDown):
  20683. 2012-05-22 Kausalya Madhusudhanan <kmadhusu@chromium.org>
  20684. [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
  20685. https://bugs.webkit.org/show_bug.cgi?id=86684
  20686. Reviewed by Darin Fisher.
  20687. * DumpRenderTree/chromium/LayoutTestController.cpp:
  20688. (LayoutTestController::numberOfPages):
  20689. * DumpRenderTree/chromium/WebViewHost.cpp:
  20690. (WebViewHost::printPage):
  20691. == Rolled over to ChangeLog-2012-05-22 ==