#461 Updater predowload does not work on 4.2.0 -> 4.3.0

/code/dawn ▚ git pull
Updating fc7893b..77e0e48
Fast-forward
 420/patch.sh                     |  1 +
 420/patch_files/launcher.bat     |  2 +-
 INSTALLATION.md                  |  6 +++---
 README.md                        | 11 +++++++----
 TROUBLESHOOTING.md               | 13 ++++++++-----
 updater/find_surplus_binaries.sh | 23 +++++++++++++++++++++++
 6 files changed, 43 insertions(+), 13 deletions(-)
 create mode 100644 updater/find_surplus_binaries.sh

~/code/dawn $ z Genshin

~/games/genshin-impact/…/Genshin Impact/Genshin Impact Game Ξ bash ~/code/dawn/updater/update_gi.sh predownload
--- Using download application: /usr/bin/wget -c
--- Checking for predownload versions
--- Installed version: 4.2.0

--2023-12-20 00:15:00--  https://sdk-os-static.mihoyo.com/hk4e_global/mdk/launcher/api/resource?channel_id=1&key=gcStgarh&launcher_id=10
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving sdk-os-static.mihoyo.com (sdk-os-static.mihoyo.com)... 163.181.92.233, 163.181.92.232, 163.181.92.235, ...
Connecting to sdk-os-static.mihoyo.com (sdk-os-static.mihoyo.com)|163.181.92.233|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/json]
Saving to: ‘resource?channel_id=1&key=gcStgarh&launcher_id=10’

resource?channel_id=1&key=gcStgarh&laun     [ <=>                                                                           ]  10.30K  --.-KB/s    in 0s

2023-12-20 00:15:02 (244 MB/s) - ‘resource?channel_id=1&key=gcStgarh&launcher_id=10’ saved [10546]


  *  Could not find any matching update entry

 ?=1

Haven't checked in code why it would print that because I am a little short on time currently. I suppose the native launcher should also work (see also #455), but I found dawn's that I could simply trigger from the terminal to be more convenient (and verbose/transparent).

@FichteFoll With DEBUG=1 in update_gi.sh I used a local backup of the 4.2.0 -> 4.3.0 JSON file. Unfortunately I cannot reproduce your issue with jq version 1.6.

If you would like to investigate this further, here is the JSON backup: https://file.io/KhbIv3sHD8WE (expires in 5 days).

An alternative update_gi.sh JSON generator can be found here. However, it does currently not include any predownload paths: https://notabug.org/Krock/custom-resource

Hm, after pulling the latest changes I can run the normal update (without predownload) but I couldn't before. Predownload also still doesn't work, but that may be because of upstream JSON changes now that the patch is out.

re DEBUG=1: I consistently thought I could set it from outside the script and was surprised to see that it wasn't doing anything. I might PR that some time later. Since it works for me now and I'm still somewhat short on time, I don't plan on investigating further.

I was using jq 1.7.1 btw.

Closing since it's not reproducible currently and I forgot to archive the old JSON. Will reopen or file a PR when it also occurs for the next patch.

I've opened #462 with the DEBUG change.