#305 Progress of the 2.7.0 patch

Closed
opened 1 year ago by Krock · 13 comments
Krock commented 1 year ago

Official release date: 31 May (pre-download: 27 May)

Patch completion/script unlock: 4 Jun ¹

Progress so far (updated incrementally):

  • DONE - Locate the "check functions"
    • Unable to locate the login function using static analysis. The UserAssembly layout has changed. This needs debugging, hence will be done on release day. Inputs are welcome.
  • DONE - Locate the service start function
  • DONE - Locate & patch the manufacturer string ("Wine")
  • DONE - Write patch skeleton
  • DONE - Anti-abuse quirk
  • DONE - Check for new launcher key

Tasks after official launch:

  • DONE - Dump "correct" values from a Windows installation
  • DONE - Check for newly added logging servers
  • DONE - New code for the second validation check
  • DONE - Publish patch for testing
  • TODO - Test that patch (crowdsourcing)

Note: The CN counterpart is done by @y0soro and will have the same changes.

Please only answer to this issue if you have questions or helpful inputs.

¹) Might also take longer. New code is an unknown time factor.

Official release date: 31 May (pre-download: 27 May) Patch completion/script unlock: 4 Jun ¹ **Progress so far (updated incrementally):** * DONE - Locate the "check functions" * Unable to locate the login function using static analysis. The UserAssembly layout has changed. This needs debugging, hence will be done on release day. Inputs are welcome. * DONE - Locate the service start function * DONE - Locate & patch the manufacturer string ("Wine") * DONE - Write patch skeleton * DONE - Anti-abuse quirk * DONE - Check for new launcher key **Tasks after official launch:** * DONE - Dump "correct" values from a Windows installation * DONE - Check for newly added logging servers * DONE - New code for the second validation check * DONE - Publish patch for testing * TODO - Test that patch (crowdsourcing) Note: The CN counterpart is done by @y0soro and will have the same changes. Please only answer to this issue if you have questions or helpful inputs. ¹) Might also take longer. New code is an unknown time factor.
cybik commented 1 year ago

Test Report

System Information

  • Pop_OS 22.04
  • i7 8700k / 32gb RAM
  • Kernel 5.18.1-xanmod1-x64v2
  • nVidia RTX 3060 Ti on nVidia 510.68.02 (Full blobs)

Environment

  • AAGL AppImage Launcher, via Steam (Futex2 enabled, FSR disabled)
  • GE-Proton7-16
  • DXVK 1.10.1

Test Notes / Issues

Junk account - America server, Patch v1

  • First Play Session - 1h15m of faffing around and doing things
    • Globally fine, no crash nor ban
  • Second Play Session - 15 + 40 minutes
    • Hardcrash 15 minutes in, after triggering a level gate check for a domain requiring AR22
      • Gameplay picks back up fine after a restart
    • Further 40min faffing around - works, not banned
  • Third Play Session - Quick peek before going to work, 2 min
    • Game let me in - not autobanned during daily reset
  • Fourth Play Session - ~50m
    • Globally fine, no crash nor ban

Junk account - America server, Patch v2

  • One play session - 53min
    • Globally fine, no crash nor ban

Main Account - America server, Patch v2

  • First play session - ~1hr
    • Login, Daylies, Exit & Relogin - works as expected
  • Second play session - ~1hr
    • Boss fight, teleporting, character config, BP - works as expected
    • Exit, get back in game - no autoban trigger
  • Third play session - 2h+
    • Did the FOMO quest in its entirety. No crash to report.

Conclusion

Patch v1

Without passing judgement on safety, looks functional.

Patch v2

Multiple shutdowns and starts, teleports, faffing around the map, without autoban. Patch works here.

# Test Report ## System Information * Pop_OS 22.04 * i7 8700k / 32gb RAM * Kernel 5.18.1-xanmod1-x64v2 * nVidia RTX 3060 Ti on nVidia 510.68.02 (Full blobs) ## Environment * AAGL AppImage Launcher, via Steam (Futex2 enabled, FSR disabled) * GE-Proton7-16 * DXVK 1.10.1 ## Test Notes / Issues ### Junk account - America server, Patch v1 * First Play Session - 1h15m of faffing around and doing things * Globally fine, no crash nor ban * Second Play Session - 15 + 40 minutes * Hardcrash 15 minutes in, after triggering a level gate check for a domain requiring AR22 * Gameplay picks back up fine after a restart * Further 40min faffing around - works, not banned * Third Play Session - Quick peek before going to work, 2 min * Game let me in - not autobanned during daily reset * Fourth Play Session - ~50m * Globally fine, no crash nor ban ### Junk account - America server, Patch v2 * One play session - 53min * Globally fine, no crash nor ban ### Main Account - America server, Patch v2 * First play session - ~1hr * Login, Daylies, Exit & Relogin - works as expected * Second play session - ~1hr * Boss fight, teleporting, character config, BP - works as expected * Exit, get back in game - no autoban trigger * Third play session - 2h+ * Did the FOMO quest in its entirety. No crash to report. ## Conclusion ### Patch v1 Without passing judgement on safety, looks functional. ### Patch v2 Multiple shutdowns and starts, teleports, faffing around the map, without autoban. Patch works here.
xiee commented 1 year ago

Finally, notabug is back up. Waiting eagerly for this update.

Finally, notabug is back up. Waiting eagerly for this update.
cybik commented 1 year ago

Previous reports on https://gitlab.com/SmallJoker/dawn_temporary/-/issues/1 - linking here until they're moved over (or yeeted).

Previous reports on https://gitlab.com/SmallJoker/dawn_temporary/-/issues/1 - linking here until they're moved over (or yeeted).
xiee commented 1 year ago

@cybik thanks for the heads up. Didn't know that backup site existed!

@cybik thanks for the heads up. Didn't know that backup site existed!
Fanixtar commented 1 year ago

Been playing for 2 hours, no problem so far

Been playing for **2 hours**, **no problem** so far
Krock commented 1 year ago
Owner

The current patch will be unlocked on 4 Jun. As usual, I recommend to use testing accounts in the meantime.

Annotations:

  • I appreciate the gameplay reports, but there is no need for this many details. Please rather highlight what you were doing before a game crash (if it is reproducible).
  • The GitLab instance will de deleted in a few days. If you would like to keep a comment, feel free to migrate (copy&paste) it.

Development information recap/import:

  • 2nd check function: different data handling. -> use memcpy
  • 3rd check function: return value is apparently not relevant (found in 2.5.0 too)
  • Delayed server-side checks (intentional or not), hence 31-4302 after approx. 2 days.
  • UnityPlayer uses C++' std::wstring standard memory layout.
The current patch will be unlocked on 4 Jun. As usual, I recommend to **use testing accounts** in the meantime. Annotations: * I appreciate the gameplay reports, but there is no need for this many details. Please rather highlight what you were doing before a game crash (if it is reproducible). * The GitLab instance will de deleted in a few days. If you would like to keep a comment, feel free to migrate (copy&paste) it. Development information recap/import: * 2nd check function: different data handling. -> use `memcpy` * 3rd check function: return value is apparently not relevant (found in 2.5.0 too) * Delayed server-side checks (intentional or not), hence 31-4302 after approx. 2 days. * UnityPlayer uses C++' `std::wstring` standard memory layout.
zeGolem commented 1 year ago

Here is my report of the patchv2, completing the one I did for the patchv1 on GitLab:

Test report

System information

  • Kernel 5.18-AMD-znver2
  • Distro: Arch Linux
  • APU: Ryzen 7 4700U
  • GPU Driver: amdgpu

Environment

Using an-anime-game-launcher, installed from the AUR.

  • Wine: Lutris GE 7.2, also tested on Proton GE 7.20
  • DXVK: 1.10.1
  • FSR 1.0
  • Esync and Fsync synchronization
  • Gamemode, both enabled and disabled

General Linux support

  • Using a throwaway account, only had ~1h playtime on it before this, AR7
  • Surveys using the in-game browser works! (Though it takes some time to open)
  • Performance was as expected, not great, but I'm running on integrated graphics…
  • Using a Steam controller and SC-Controller works as expected, hotplugging even worked

Patch support

Worked flawlessly. Haven't been banned, I used the patch for the first time >12h ago, and nothing appears to be wrong…

Conclusion

Patch doesn't cause any issue for me, I hope it'll stay that way :) I may have the courage of testing it on my main account on my desktop later today, if no ban is reported

Thanks again, Krock, for the great work, looking forward to playing the game again :)

Here is my report of the patchv2, completing the one I did for the patchv1 on GitLab: # Test report ## System information * Kernel 5.18-AMD-znver2 * Distro: Arch Linux * APU: Ryzen 7 4700U * GPU Driver: amdgpu ## Environment Using `an-anime-game-launcher`, installed from the AUR. * Wine: Lutris GE 7.2, also tested on Proton GE 7.20 * DXVK: 1.10.1 * FSR 1.0 * Esync and Fsync synchronization * Gamemode, both enabled and disabled ## General Linux support * Using a throwaway account, only had ~1h playtime on it before this, AR7 * Surveys using the in-game browser works! (Though it takes some time to open) * Performance was as expected, not great, but I'm running on integrated graphics… * Using a Steam controller and SC-Controller works as expected, hotplugging even worked ## Patch support Worked flawlessly. Haven't been banned, I used the patch for the first time >12h ago, and nothing appears to be wrong… ## Conclusion Patch doesn't cause any issue for me, I hope it'll stay that way :) I may have the courage of testing it on my main account on my desktop later today, if no ban is reported Thanks again, Krock, for the great work, looking forward to playing the game again :)
  • Inventory
    • Using food
    • Upgrading artifacts / weapons
  • Wish system
    • Buying wishes from shop
    • Making wishes
  • World exploration
    • Teleportation
    • Entering buildings (e.g. Mondstadt's cathedral)
    • Entering domains (artifacts / with reward)
    • Sitting on a chair
    • Gliding from a cliff
    • Beating mobs (enemies, animals)
    • Doing quests
    • Going to abyss
  • Co-op
    • Joining others' worlds
    • Letting others to join your world
    • Sending chat messages
    • Going to domains
  • Teapot
    • Entering teapot
    • Buying items
    • Placing furnishing
    • Interacting with companions

Pattern for other people (write [x] for checked items):

- [ ] Inventory
  - [ ] Using food
  - [ ] Upgrading artifacts / weapons
- [ ] Wish system
  - [ ] Buying wishes from shop
  - [ ] Making wishes
- [ ] World exploration
  - [ ] Teleportation
  - [ ] Entering buildings (e.g. Mondstadt's cathedral)
  - [ ] Entering domains (artifacts / with reward)
  - [ ] Sitting on a chair
  - [ ] Gliding from a cliff
  - [ ] Beating mobs (enemies, animals)
  - [ ] Doing quests
  - [ ] Going to abyss
- [ ] Co-op
  - [ ] Joining others' worlds
  - [ ] Letting others to join your world
  - [ ] Sending chat messages
  - [ ] Going to domains
- [ ] Teapot
  - [ ] Entering teapot
  - [ ] Buying items
  - [ ] Placing furnishing
  - [ ] Interacting with companions
- [x] Inventory - [x] Using food - [x] Upgrading artifacts / weapons - [x] Wish system - [x] Buying wishes from shop - [x] Making wishes - [x] World exploration - [x] Teleportation - [x] Entering buildings (e.g. Mondstadt's cathedral) - [x] Entering domains (artifacts / with reward) - [x] Sitting on a chair - [x] Gliding from a cliff - [x] Beating mobs (enemies, animals) - [x] Doing quests - [x] Going to abyss - [ ] Co-op - [ ] Joining others' worlds - [ ] Letting others to join your world - [ ] Sending chat messages - [ ] Going to domains - [x] Teapot - [x] Entering teapot - [x] Buying items - [x] Placing furnishing - [x] Interacting with companions Pattern for other people (write [x] for checked items): ``` - [ ] Inventory - [ ] Using food - [ ] Upgrading artifacts / weapons - [ ] Wish system - [ ] Buying wishes from shop - [ ] Making wishes - [ ] World exploration - [ ] Teleportation - [ ] Entering buildings (e.g. Mondstadt's cathedral) - [ ] Entering domains (artifacts / with reward) - [ ] Sitting on a chair - [ ] Gliding from a cliff - [ ] Beating mobs (enemies, animals) - [ ] Doing quests - [ ] Going to abyss - [ ] Co-op - [ ] Joining others' worlds - [ ] Letting others to join your world - [ ] Sending chat messages - [ ] Going to domains - [ ] Teapot - [ ] Entering teapot - [ ] Buying items - [ ] Placing furnishing - [ ] Interacting with companions ```
Miga commented 1 year ago

System:

  • Intel Core i9 12900K
  • 32 GB of RAM
  • AMD Radeon 6950XT / AMDGPU driver

Environment:

  • Debian GNU/Linux 11, kernel 5.17.0-12.1-liquorix-amd64
  • Wine/Lutris-GE 6.21-1
  • DXVK 1.10.1 (async)
  • Esync enabled

Test Results:

Played for 2 hours, game works beautifully. Would like to note that the FPS unlocker 1.4.2 was causing all kinds of crashes with 2.7, but 2.0.0 has no issues. Thanks for the patch as always!

**System:** - Intel Core i9 12900K - 32 GB of RAM - AMD Radeon 6950XT / AMDGPU driver **Environment:** - Debian GNU/Linux 11, kernel 5.17.0-12.1-liquorix-amd64 - Wine/Lutris-GE 6.21-1 - DXVK 1.10.1 (async) - Esync enabled **Test Results:** Played for 2 hours, game works beautifully. Would like to note that the FPS unlocker 1.4.2 was causing all kinds of crashes with 2.7, but 2.0.0 has no issues. Thanks for the patch as always!
cybik commented 1 year ago

@krock yeah sorry >.<

I went overboard as a "dayjob defect". I'll try to reel it in.

@krock yeah sorry >.< I went overboard as a "dayjob defect". I'll try to reel it in.
kumik commented 1 year ago

Gentoo, kernel 5.18, nvidia-drivers 510.73.05, wine 7.9 with dxvk 1.10.1.

Played for around 10 hours on my main account, doing all of my normal activities (dailies, coop, domains, wishes, upgrading artifacts, quests, bosses, abyss). But couldn't find a crash. As of now it's working fine. Thank you so much for the patch!

Gentoo, kernel 5.18, nvidia-drivers 510.73.05, wine 7.9 with dxvk 1.10.1. Played for around 10 hours on my main account, doing all of my normal activities (dailies, coop, domains, wishes, upgrading artifacts, quests, bosses, abyss). But couldn't find a crash. As of now it's working fine. Thank you so much for the patch!
zeGolem commented 1 year ago

Started using the patch >24h ago, still not banned, I think it can be considered safe, as I don't think anyone else got banned

Started using the patch >24h ago, still not banned, I think it can be considered safe, as I don't think anyone else got banned
Krock commented 1 year ago
Owner

Thanks everybody for testing. Despite the short delay and the unfortunate NotABug downtime, everything looks fine so far. The scripts are unlocked now.

If you find any new bug, please open a separate issue (or check for duplicate ones).

Thanks everybody for testing. Despite the short delay and the unfortunate NotABug downtime, everything looks fine so far. The scripts are unlocked now. If you find any new bug, please open a separate issue (or check for duplicate ones).
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.