#266 Progress of the 2.5.0 patch

Sorry, I forgot to open an issue in advance.

Official release date: 16 Feb (pre-download now)

Patch completion/script unlock: 19 Feb ¹

Progress so far (updated incrementally):

• DONE - Locate the "check functions"
• DONE - Locate the service start function
  • Parent function has changed.
  • A new new files (see dev_tools/README.txt)
  • crashreporter.exe and metakeeper.dll: CrashSDK written in Go
• DONE - Locate & patch the manufacturer string ("Wine")
• DONE - Write patch skeleton
• DONE - Anti-abuse quirk
• DONE - Check for new launcher key

Tasks after official launch:

• DONE - Check for influence of mhyprot3 -> none?
• DONE - Dump "correct" values from a Windows installation
• DONE - Check for newly added logging servers
• DONE - Publish patch for testing
• TODO - Test that patch (crowdsourcing)

Note: The CN counterpart is done by @y0soro and will have the same changes.

Please only answer to this issue if you have questions or helpful inputs.

¹) Might also take longer. New code is an unknown time factor.

I will submit the CN patch (maybe via PR this time) after @Krock has released initial patch for OS GI. Merged.

Works on CN patch will also be recorded in https://notabug.org/y0soro/dawn-cn/src/main/250 .

My game installation corrupted due to faulty update and needed a re-install.

Idea for the launcher developers: (@loentar, @nobody) To reduce server load, please consider using git clone/git pull (if available or not already done) and caching. I assume NotABug does not cache generated zip exports. The service code was slightly changed, hence I took the liberty to (possibly) break your sed scripts for unlocking test patches.

Patch was completed at 10:14:10 UTC+0, but the git server was unreachable until now.

Version 2.5.0 is ready for testing. As usual, please use testing accounts for your safety.

The CN patch will be merged when I can confirm that #267 works properly. DONE

Many thanks for your understanding.

@Krock, thank you for information. The scripts are get using git clone/pull. I've updated the script output handling and PL v1.3.7 (released just now) patches the game correctly.

@Krock my launcher's already caching a lot of stuff, including information about the patch. Also, we have a mirror of the repository for such cases like there were several hours before. And yeah, I'll make it using git clone / pull a bit later

Also, I'll test the patch today, and write a report as before

Thanks for your work

UPD: made an update with patch-related fixes and git clone / git pull usage instead of the repo archive downloading and unpacking

Thanks for the superb work as always. I've been running the game for roughly over an hour on an alt account. So far so good.

Arch Linux 5.16.8 Wine Lutris GE 7.0rc3

2.5.0 working well on older PC running Ubuntu. Thank you for the patch!

EU server here, virtual_setup_exception (025c:err:virtual:virtual_setup_exception stack overflow 1936 bytes in thread 025c addr 0x170054148 stack 0x1de20870 (0x1de20000-0x1de21000-0x1df20000)) seems to be back and the program hangs on Geo half-filled up, reproducible across reboots. Tried applying patch_anti_logincrash.sh, but it complained about wrong md5sum. Thank you!

Edit: seems like the md5sum in the current patch_anti_logincrash.sh is still the old value for the 2.4.0 patch; changing it to the new one does not work since there's no xlua_patch.vcdiff in the patch_files folder.

At least the game starts. I had some issues during downloading additional resources, but it's not likely linux- or patch-related (source). Some of the launcher's users already noticed this issue a long time ago

As the month ago I'll be updating this comment over the next hour

Tests are made on my test account*

15 minutes: tried Yae in the test run, and spend some freemogems on her banner. Everything's ok

30 minutes: completed Kaeya's quest. Everything's ok. I don't see bodies in the water (sorry)

45 minutes: completed Lisa's quest and saved Mondstadt from the tornado. Everything's ok

60 minutes: got Fischl from the banner, explored the world a bit. Everything's ok

So at least to me, everything works as intended

UPD: spent another 2.5 hours without any issues

Thanks for the launcher status updates.

@Ramiel Is there a newly generated crash report in your WINEPREFIX' %TEMP% directory (see FAQ.md)?

• Yes? Compare it to the cases mentioned in TROUBLESHOOTING (xaudio and hid). If it is something else, please provide the first few lines of error.log.
• No? Check whether the newly added anti_logincrash.sh helps. If not, please open a new issue providing your system and setup information.

@nobody -9011 seems to be a vague error code. Does deleting the Persistent directory help? Other users report success using a VPN, which is an entirely different approach.

@Krock The game has let me download resources by parts. I could download like 500 MB, then get this error and then download another 500 MB again. That's how I downloaded the update :D

@Krock Thank you for the patch. The new patch_anti_logincrash.sh did fix the problem after a reboot, similar to my previous case documented in #259. The game works properly now, thank you!

For the record, error.log shows the following problem:

UnityPlayer.dll caused an Access Violation (0xc0000005)
  in module UnityPlayer.dll at 0033:812aa925.

OS is Arch Linux x86_64, Wine is wine-7.2, dxvk 1.9.4-2. Graphics cards are Intel TigerLake-LP GT2 and NVIDIA GeForce MX450.

Thanks for your amazing work. Played for around 30 minutes with no issues. Asia server, Debian 11, lutris-fshack-6.21, Nvidia 470.103.01

Played for around 2 hours,

After like 40-ish min (can't exactly remember the time) i encountered a crash:

wine: Unhandled page fault on write access to 0000000000000010 at address 00000001808D0DE7 (thread 01b4), starting debugger...

But I'm not sure if this is wine specific or game specific, unfortunately i use Lutris (with the output log set to disabled) so the output log wasn't detailed.

Then 30-ish minutes after relaunching the game, i encountered a freeze. also not exactly sure if it's related to the patch, no logs found here.

Other than that, it runs great!

Thank you very much!

Edit: Additional Log from the game itself (from the crash above)

UserAssembly.dll caused an Access Violation (0xc0000005) in module UserAssembly.dll at 0033:13dadbb0.

Update (In reply to Krock also): Played for around 4-5 Hours today, no more crashes/freezes encountered. So does not related to the patch/wine at all.

For those who faced with -9011 error. It appear on Windows machine as well.. After appearing about 6-7 times (few additional fractions of percent is downloaded every time) it allowed to download the rest of the resources. So it's a global thing, just keep trying.

@pureshores The address reported by Wine lies within the Unity game engine. The side-effects of "fixing" this specific crash are unclear to me, hence I would recommend you to disable ESYNC/FSYNC, check for driver updates and to test other Wine and DXVK versions to narrow down the issue.

Thanks for the reports so far.

Played some minutes just to test, works as expected. FreeBSD 13.0-RELEASE-p7 with wine-proton 6.3. (FYI: Graphics at max but with the recomendations, i5-3470 @ 3Ghz, 16Gb RAM, GTX650 TI Boost 2Gb).

Seems to work fine on my machine: Arch Linux with wine-ge-custom 7.1.GE.1-1.

Edit: Did some more testing and seems there's a BGM problem? Only the wish menu and login screen has BGM.

Edit 2: BGM seems fixed after launching the client again.

In order:

• A ~15min session (faffing around) on my test account showed no issues and nothing that would be telling me the account is marked.
• An ~hour yolosession (failing the 50/50 on Yae and being salty about it, daylies) on my main account showed no issues and nothing that would be telling me the account is marked.

Any "consequences" from mhy/Cognosphere/Hoyoverse possibly being timeshifted, I will circle back and check if I'm still able to play after work, as a point of information.

Pop_OS (impish) using Proton GE 7.1-GE-1

Played for 4-5 hours and pulled yae, everything seems to run fine (archlinux w/ kde, wine-ge-custom 7.0rc3)

Played for 1+ Hours, No problem at all, everything worked fine. Thank you very much!!

Arch Linux, Lutris, Wine-Fshack-6.21.

Played for 30 mins , did some pulls and exploration on a throwaway account . No issues encountered in gameplay Pop OS 21.10 , lutris-fshack-6.21 Got the -9011 thing , but it just downloads again .

Thanks a lot !

My game does not run. Once I update de launcher to the 2.5 version, the message "Failed to install plug-ins units nedded for effetuation of the game(1%)." Never had any issue with the game, I use KDE Neon 5.19.3 (I think) and run the game with Lutris. Is this related with the laucher issues talked in the comments above?

@Hcaelb: Mine did the same, but just closing the error allows it to continue and update normally. Apparently they're trying to install some windows hotfix or something. Game definitely still working without it.

@r4mOn That's odd, mine did not start at all... I'll try some more times, thaks for the info. :)

Played for one hour, no issues found so far. Download completed without any errors or interruptions. Haven't used patch_anti_logincrash.sh yet.

Arch, Nvidia, 16GB RAM, wine-staging custom 6.5 + fsync, dxvk-async git (1.9.4).

Edit: Just one concern, the log-upload-os domain could change in the future due to the domain migration, might want to keep an eye on that in case they update the backend specific code.

Edit 2: Finished the new event, 100%. All good. Thanks!

Played for an hour, no issues to report.

Arch + lutris

Thanks for the amazing job as usual!

Hey, thank you so much for the patch.

I have been playing for around 2 hours, the only issue I found was the BGM missing in game (the wish interface still had it working), but that was entirely on me, I think. When downloading the update with the script it was interrupted and later resumed, I skipped the MD5 check since it mismatched. After unpatching, repairing the files with the launcher, and patching again everything worked without issues.

My System: Gentoo Linux kernel version 5.15.13 wine 7.1 dxvk 1.9.4 nvidia drivers 470.94

@kumik actually the missing BGM issue might be from the devs, because I got hit with that glitch as well. Might be on the engine or the audio library misbehaving - though the latter seems unlikely, since the logs didn't show anything to point to that.

first of all thanks a lot for the fast update

I've been done my daily and killing bosses for BP, and some domain run still haven't encountering any problem, I don't even need the anti login crash patch like previous patch

My System: manjaro with kernel 5.16.7 nvidia driver 510.47.3 wine 7.1 dxvk 1.9.4

Thanks for the update

did dailies and no problem so far

For me the patch_anti_login_crash was not required (europe) (maybe this will change for longer sessions)

Interesting that the game uses HDiffPatch now. Needed to change my update workflow a little bit

System: wine-6.17 / Ubuntu 20.04.3 / Nvidia driver: 470.103.01

Circling back 8hrs+ after the morning play session and my main account is not banned, for whatever this is worth.

@kumik @cybik I think BGM broke for me partway into the first gaming session, but restarting the game fixed that.

Loading screen BGM and Wish screen BGM worked fine, so it's most likely a game issue, not audio issue.

asia server here, game crash/not launching after click yellow "launch" button.

@CorvusAI can you share your config, why yours working and im not ? im also use Pop OS 21.10 , lutris-fshack-6.21.

i already do this :

kentut@pop-os:~/Games/genshin-impact/drive_c/Program Files/Genshin Impact/Genshin Impact game$ bash dawn/250/patch.sh
 === !! UNTESTED PATCH. CHECK FOR BANS USING A TRASH ACCOUNT !! ===
 ===      REPORT RESULTS TO THE MAIN REPOSITORY. THANK YOU.     ===

and load lutris from /home/kentut/Games/genshin-impact/drive_c/Program Files/Genshin Impact/launcher.exe (this is working when patch 240)

if i use launcher from .bat files, this is what i get

kentut@pop-os:~/Games/genshin-impact/drive_c/Program Files/Genshin Impact$ wine cmd /c launcher.bat
000d:err:module:__wine_process_init L"C:\\windows\\system32\\winemenubuilder.exe" not found
000b:err:wineboot:process_run_key Error running cmd L"C:\\windows\\system32\\winemenubuilder.exe -a -r" (126).
001c:err:ntoskrnl:ZwLoadDriver failed to create driver L"\\Registry\\Machine\\System\\CurrentControlSet\\Services\\wineusb": c0000142
wine: Call from 0x7bc7c9b8 to unimplemented function ntoskrnl.exe.RtlPcToFileHeader, aborting
wine: Unimplemented function ntoskrnl.exe.RtlPcToFileHeader called at address 000000007BC7C9B8 (thread 0016), starting debugger...
000f:err:service:process_send_command service protocol error - failed to read pipe r = 0  count = 0!
000f:err:service:process_send_start_message pipe connect failed
File not found.

regedit: The file 'mhyprot2_running.reg' was not found.
Application could not be started, or no application associated with the specified file.
ShellExecuteEx failed: File not found.

thanks

@tempdrive Did you remove the "exit 1" line of the patch.sh script? (Line 7) This is necessary since the patch is in early testing

If not: remove it and rerun patch.sh. Afterwards you should be able to start the game using the .bat file

That regedit error means the patch did not copy mhyprot2_running.reg and the other wine error sounds like you are trying to run an unpatched version of the game (but I am not sure with that)

@extremeCrazyCoder thanks a lot man, this solve my problem and i can login now. and i think i now can login from launcher.bat also. but now i remember why i not using launch from bat files, beacuse keyboard not working and the grafic seems weird, it feel not load properly driver GPU. any tips

kentut@pop-os:~/Games/genshin-impact/drive_c/Program Files/Genshin Impact/Genshin Impact game$ wine cmd /c launcher.bat
000d:err:module:__wine_process_init L"C:\\windows\\system32\\winemenubuilder.exe" not found
000b:err:wineboot:process_run_key Error running cmd L"C:\\windows\\system32\\winemenubuilder.exe -a -r" (126).
001c:err:ntoskrnl:ZwLoadDriver failed to create driver L"\\Registry\\Machine\\System\\CurrentControlSet\\Services\\wineusb": c0000142
wine: Call from 0x7bc7c9b8 to unimplemented function ntoskrnl.exe.RtlPcToFileHeader, aborting
wine: Unimplemented function ntoskrnl.exe.RtlPcToFileHeader called at address 000000007BC7C9B8 (thread 0016), starting debugger...
000f:err:service:process_send_command service protocol error - failed to read pipe r = 0  count = 0!
000f:err:service:process_send_start_message pipe connect failed

EDIT by Krock: use ``` for code blocks

Played for a few hours in co-op without any issues. (America server)

Artix Linux, Wine lutris-6.0-x86_64, DXVK v1.9.4L-2 w/ vkBasalt

Played a couple of hours yesterday, and today.

Spent some primos, did new story quest and weekly, explored event area a bit.

Managed to freeze earlier in the event area after shooting explosive barrels, chalking it up to a game bug, but other than that, no issues.

Didn't use anti login crash patch. Using self-compiled protonified wine-tkg 7.1 build with some patches.

Update 2 : Completed the event in my main account , did co-op and dailies too with no issues . I did not encounter any audio issues.

Everything looks good , thanks again !

@tempdrive I see @extremeCrazyCoder helped you in applying the patch correctly. If you still have issues , we can discuss on another thread.

hey guys just want to ask, is this in-game update normal? i upgrade manually using aria2c from 240 to 250 with this url.

after downloading this 3 files:

• game_2.4.0_2.5.0_hdiff_G7AskHSpFPiXwRyU.zip (7,4 GiB)
• en-us_2.4.0_2.5.0_hdiff_FGN5bsVa0BZLKqEA.zip (355,5 MiB)
• ja-jp_2.4.0_2.5.0_hdiff_t0MU7XpPc3ofbYwD.zip (362,7 MiB)

then extract and patch it. why i had to download 4GiB resource again? is it normal?

p.s. just curious why the resource is big since im using mobile data to download it.

@rafihadi04, That sounds funny, but the same happen on Win machine for me. Downloaded update using official launcher, then some GBs ingame.

@loentar okay then, i continue to download.

in-game download that big just wasting my potato computer since that background is rendering too :")

@TwistedSystems Then the official launcher on windows should have done installing it, but by some reason it didn't?

@TwistedSystems The info of HDiffPatch you provided is very useful, thank you. I'll integrate it into my launcher.

It seems game updater script needs to be updated as well: to apply and then remove hdiff files. Or at least to avoid the waste of drive space (around 3GB .hdiffs for 2.4->2.5 patch).

Thanks to everybody for testing. The scripts are unlocked now.

If you find any new bug, please open a separate issue (or check for duplicate ones).

Please continue the HDiffPatch discussion in #268.