#106 Progress of the 1.5.1 patch (was: update notice)

Closed
opened 3 years ago by massivegoose · 20 comments

A few minutes ago, I opened the launcher and it told me that there was an update to download. After downloading the update, the game would crash upon clicking the "Launch" button. I tried reverting the patch, downloading the latest version, and re-applying the patch, but now it says "wrong file version or patch already applied".

Reverting the patch

bash "/home/goose/gipatch/150/patch_revert.sh"
==> ERROR: Backup 'UnityPlayer.dll.bak' is older than the current game version. Ignoring.
==> ERROR: Backup 'GenshinImpact_Data/Plugins/xlua.dll.bak' is older than the current game version. Ignoring.
--- Crash reporter already exists
--- Removing all newly added files
rm: cannot remove 'no message': No such file or directory
==> Patch reverted.

Re-applying the patch

bash "/home/goose/gipatch/150/patch.sh"
Wrong file version or patch is already applied
md5sum: 02353c7c29cfc4ff8b9ae3a217ad2cb1

It seems the game update caused this problem.

A few minutes ago, I opened the launcher and it told me that there was an update to download. After downloading the update, the game would crash upon clicking the "Launch" button. I tried reverting the patch, downloading the latest version, and re-applying the patch, but now it says "wrong file version or patch already applied". ### Reverting the patch ``` bash "/home/goose/gipatch/150/patch_revert.sh" ==> ERROR: Backup 'UnityPlayer.dll.bak' is older than the current game version. Ignoring. ==> ERROR: Backup 'GenshinImpact_Data/Plugins/xlua.dll.bak' is older than the current game version. Ignoring. --- Crash reporter already exists --- Removing all newly added files rm: cannot remove 'no message': No such file or directory ==> Patch reverted. ``` ### Re-applying the patch ``` bash "/home/goose/gipatch/150/patch.sh" Wrong file version or patch is already applied md5sum: 02353c7c29cfc4ff8b9ae3a217ad2cb1 ``` It seems the game update caused this problem.
Krock commented 3 years ago
Owner

Very cool. Working on it...

PS: Just in case: Please do not run the game directly from the official launcher. Instead, run launcher.bat inside your game directory to perform sanity-checks upon startup.

Very cool. Working on it... PS: Just in case: Please do not run the game directly from the official launcher. Instead, run `launcher.bat` inside your game directory to perform sanity-checks upon startup.
massivegoose commented 3 years ago
Poster

By the way, thank you for all of your hard work! I really appreciate it.

By the way, thank you for all of your hard work! I really appreciate it.
massivegoose commented 3 years ago
Poster

I see, I forgot to do that. I'll start running it from the batch file from now on.

I see, I forgot to do that. I'll start running it from the batch file from now on.
Krock commented 3 years ago
Owner

Testing patch for 1.5.1 is now available

.. but you may continue using 1.5.0 until the game requests you to update.

This script will be unlocked tomorrow if there are no issues reported by testers. Please report your results here.

### Testing patch for 1.5.1 is now available .. but you may continue using 1.5.0 until the game requests you to update. This script will be unlocked tomorrow if there are no issues reported by testers. Please report your results here.
Alex72 commented 3 years ago

I just wanted to note that 1.5.1 update is optional and if you have 1.5.0 working, there seems to be no need to update right now.

As of now I can't confirm nor deny the startup issue was fixed in 1.5.1, and it's not mentioned in the patch notes.

I just wanted to note that 1.5.1 update is optional and if you have 1.5.0 working, there seems to be no need to update right now. As of now I can't confirm nor deny the startup issue was fixed in 1.5.1, and it's not mentioned in the patch notes.
Appleson commented 3 years ago

A clean installation (lutris) + patch 1.5.1 works fine.

OS: Arch Linux x86_64 Kernel: 5.11.16-arch1-1 NVidia: 465.27-2

A clean installation (lutris) + patch 1.5.1 works fine. OS: Arch Linux x86_64 Kernel: 5.11.16-arch1-1 NVidia: 465.27-2
Ghost commented 3 years ago

Just tested it on my gentoo system (5.12 kernel) and it works perfectly, many thanks

EDIT: Played for an hour and logged out then back in, no problems :)

Just tested it on my gentoo system (5.12 kernel) and it works perfectly, many thanks EDIT: Played for an hour and logged out then back in, no problems :)
yagocl commented 3 years ago

Updated via the update-gi script.

Game wouldn't start up anymore with my "workaround" proton-ge scripts setup, so I deleted everything and did a clean re-install on a new wineprefix.

Installed dxvk, faudio and corefonts with winetricks.

Now, it works just fine with lutris and wine-6.4 from lutris.

With this new Lutris-based setup and game update...

Mouse/keyboard input issues

Easiest solution:

    wine explorer /desktop=anyname,1920x1080 cmd /c launcher.bat (adjust to your resolution)
    Try Proton: add cmd /c launcher.bat to your game library

No longer seems to happen, and alt-tab works fine now without the virtual desktop. (Gnome shell)

Updated via the update-gi script. Game wouldn't start up anymore with my "workaround" proton-ge scripts setup, so I deleted everything and did a clean re-install on a new wineprefix. Installed dxvk, faudio and corefonts with winetricks. Now, it works just fine with lutris and wine-6.4 from lutris. With this new Lutris-based setup and game update... ``` Mouse/keyboard input issues Easiest solution: wine explorer /desktop=anyname,1920x1080 cmd /c launcher.bat (adjust to your resolution) Try Proton: add cmd /c launcher.bat to your game library ``` No longer seems to happen, and alt-tab works fine now without the virtual desktop. (Gnome shell)
massivegoose commented 3 years ago
Poster

Hi, I've tested the patch and I've found some issues that may or may not be related to the patch, but I'll put them here just in case.

After applying the patch and launching the game using launcher.bat, it seemed like dvxk was not applied(I installed GI using Lutris).

However, launching from Lutris(after applying the patch) seemed to have no issues at all.

I attached a picture of the game when I launched from launcher.bat.

Would a clean reinstall of GI through Lutris fix this problem?

Hi, I've tested the patch and I've found some issues that may or may not be related to the patch, but I'll put them here just in case. After applying the patch and launching the game using launcher.bat, it seemed like dvxk was not applied(I installed GI using Lutris). However, launching from Lutris(after applying the patch) seemed to have no issues at all. I attached a picture of the game when I launched from launcher.bat. Would a clean reinstall of GI through Lutris fix this problem?

So if you set lutris to target the launcher.bat and not the GenshinImpact.exe, it doesnt start with dxvk?

For the alt tab problems, I believe I ran into a similar problem, in the launcher.bat file, change the last line to start GenshinImpact.exe -screen-width 1920 -screen-height 1080 -screen-fullscreen 0 -popupwindow maybe change the resolution if your screen is different

So if you set lutris to target the launcher.bat and not the GenshinImpact.exe, it doesnt start with dxvk? For the alt tab problems, I believe I ran into a similar problem, in the launcher.bat file, change the last line to `start GenshinImpact.exe -screen-width 1920 -screen-height 1080 -screen-fullscreen 0 -popupwindow ` maybe change the resolution if your screen is different
massivegoose commented 3 years ago
Poster

Launching with wine cmd /c launcher.bat in terminal causes the game to start without dxvk(I think). There doesn't seem to be any apparent issues when I launch through Lutris, which is targeted at launcher.exe, the GI launcher.

Launching with `wine cmd /c launcher.bat` in terminal causes the game to start without dxvk(I think). There doesn't seem to be any apparent issues when I launch through Lutris, which is targeted at launcher.exe, the GI launcher.
yagocl commented 3 years ago

Hmm. Krock won't be happy about usage of launcher.exe since it bypasses the checks and workarounds in the launcher.bat;

see code here

I am using launcher.bat through lutris with the wine runner and it works. However, it shouldn't have even been possible to use the launcher.exe in the first place, since the mhyprot2_running.reg thing was required or the game would instacrash. But, I tried running through the launcher.exe out of curiosity and it works. What implications could this have I don't know.

Also, launching through regular terminal with wine cmd /c launcher.bat does two things:

  • Launches the game with your system wine binary, which is not the lutris-patched one.
  • Launches the game with the default wineprefix in ~/.wine, which usually does not have dxvk on it.
Hmm. Krock won't be happy about usage of launcher.exe since it bypasses the checks and workarounds in the launcher.bat; [see code here](https://notabug.org/Krock/GI-on-Linux/src/master/151/patch_files/launcher.bat) I am using launcher.bat through lutris with the wine runner and it works. However, it shouldn't have even been possible to use the launcher.exe in the first place, since the mhyprot2_running.reg thing was required or the game would instacrash. But, I tried running through the launcher.exe out of curiosity and it works. What implications could this have I don't know. Also, launching through regular terminal with `wine cmd /c launcher.bat` does two things: * Launches the game with your system wine binary, which is not the lutris-patched one. * Launches the game with the default wineprefix in ~/.wine, which usually does not have dxvk on it.

@massivegoose set lutris to open the launcher.bat instead of genshinimpact.exe

@massivegoose set lutris to open the launcher.bat instead of genshinimpact.exe
yagocl commented 3 years ago

I'm gonna revise the README.md because right now it assumes people have certain knowledge, too often.

I'm gonna revise the README.md because right now it assumes people have certain knowledge, too often.
massivegoose commented 3 years ago
Poster

I just installed dxvk in the default wineprefix in ~/.wine, and the issues with color are gone. The game works for the most part when launching the game with wine cmd /c launcher.bat.

I just installed dxvk in the default wineprefix in ~/.wine, and the issues with color are gone. The game works for the most part when launching the game with `wine cmd /c launcher.bat`.
bakepo commented 3 years ago

The treasure map is not displayed.Only installed in lutris

The treasure map is not displayed.Only installed in lutris
massivegoose commented 3 years ago
Poster

My bad, I accidentally clicked "Comment and close".

My bad, I accidentally clicked "Comment and close".
massivegoose commented 3 years ago
Poster

@bakepo I had that issue too, but I just searched up the treasure map location and I was able to progress through the quest just fine. Not a fix, but if you are concerned with progressing through the game.

@bakepo I had that issue too, but I just searched up the treasure map location and I was able to progress through the quest just fine. Not a fix, but if you are concerned with progressing through the game.
yagocl commented 3 years ago
https://notabug.org/Krock/GI-on-Linux/pulls/110
Krock commented 3 years ago
Owner

1.5.1 works just fine. Script unlocked.

Please report upcoming bugs in separate issues. Keep in mind that there are also a few game bugs that will be fixed in the update on 6 May, according to the news page.

1.5.1 works just fine. Script unlocked. Please report upcoming bugs in separate issues. Keep in mind that there are also a few game bugs that will be fixed in the update on 6 May, according to the news page.
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.