#1 Some optimizations

Merged
pgimeno merged 2 commits from uniabis/p1 into pgimeno/master 3 years ago
uniabis commented 3 years ago

Some optimizations. Changed getbit_routine to local and moved to bottom.

Some optimizations. Changed getbit_routine to local and moved to bottom.
Pedro Gimeno commented 3 years ago
Owner

Thanks a lot! After this change I think I'm going to split the size optimized and the speed optimized versions into two files; they are becoming too different, and counting cycles/bytes for each is getting harder, plus the readability is suffering more and more.

Changes proposed:

Please remove this or merge it with the 1.1p1 change log:

+;  1.0p1 137/ 98 bytes 10-06-2020 : Modified for sjasmplus, optimized

https://notabug.org/pgimeno/z80unlze/pulls/1/files#diff-5f8d20e9beecf65497056441c6856622b70543bR19

Please remove this comment, it's already in the commit message:

+		; moved getbit_routine to bottom

https://notabug.org/pgimeno/z80unlze/pulls/1/files#diff-5f8d20e9beecf65497056441c6856622b70543bR83

How would you like to be credited?

Thanks a lot! After this change I think I'm going to split the size optimized and the speed optimized versions into two files; they are becoming too different, and counting cycles/bytes for each is getting harder, plus the readability is suffering more and more. Changes proposed: Please remove this or merge it with the 1.1p1 change log: ``` +; 1.0p1 137/ 98 bytes 10-06-2020 : Modified for sjasmplus, optimized ``` https://notabug.org/pgimeno/z80unlze/pulls/1/files#diff-5f8d20e9beecf65497056441c6856622b70543bR19 Please remove this comment, it's already in the commit message: ``` + ; moved getbit_routine to bottom ``` https://notabug.org/pgimeno/z80unlze/pulls/1/files#diff-5f8d20e9beecf65497056441c6856622b70543bR83 How would you like to be credited?
Pedro Gimeno commented 3 years ago
Owner
@uniabis ^
Pedro Gimeno commented 3 years ago
Owner

I didn't notice the added commit, sorry. Merged.

I didn't notice the added commit, sorry. Merged.
This pull request has been merged successfully!
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.