If I report an issue on GitHub, and embed an image from another domain, like this:
GitHub moves the image to its own domain. I imagine it does this in case the other site goes down. Should Gogs do this as well?
Probably not. I think this mainly depends on disk space. Github has basically infinite (for all intents and purposes), so they can probably afford to automatically set this up and do it.
I don't really see a problem with linking to (or hotlinking) to images hosted somewhere else, and I think it's somewhat out of scope for nab. Just use a 'reliable' image host.
Just my 2c though of course.
@pharpend can you check this again please? The new Gogs version has a "Drop files here" box for each comment. I'm not sure if this answers your question.
Just testing with a link
OK this is not fixed because the image is still fetched from the external domain. There is however a "drop files here" box to attach files to a commit, so I'd personally consider this fixed.